RE: [PATCH dpdk-latest v2] system-dpdk: Update vhost tests to be compatible with DPDK 22.07.

2022-07-26 Thread Pai G, Sunil
Copy paste error of wrong mailing list , please ignore this patch, was intended for OVS ML

RE: [PATCH] dma/idxd: fix missing default for workqueue options

2022-06-19 Thread Pai G, Sunil
> From: Richardson, Bruce > Sent: Friday, June 17, 2022 4:48 PM > To: dev@dpdk.org > Cc: Laatz, Kevin ; Pai G, Sunil > ; Richardson, Bruce > Subject: [PATCH] dma/idxd: fix missing default for workqueue options > > When no --wq-option flag is passed to dpdk_idxd_cf

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-04-07 Thread Pai G, Sunil
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, April 5, 2022 5:38 PM > To: Ilya Maximets ; Chengwen Feng > ; Radha Mohan Chintakuntla ; > Veerasenareddy Burru ; Gagandeep Singh > ; Nipun Gupta > Cc: Pai G, Sunil ; Stokes, Ian > ; Hu, Jiayu ; Fe

RE: [PATCH v3] dma/idxd: add generic option for queue config

2022-04-04 Thread Pai G, Sunil
> -Original Message- > From: Kevin Laatz > Sent: Friday, April 1, 2022 4:05 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Laatz, Kevin > > Subject: [PATCH v3] dma/idxd: add generic option for queue config > > The device config script currently uses some defaults to configure devices

RE: [RFC PATCH v2 4/9] vhost: fix async access

2022-04-03 Thread Pai G, Sunil
> -Original Message- > From: David Marchand > Sent: Wednesday, March 30, 2022 7:20 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, > Jiayu ; Wang, YuanX ; Ding, Xuan > ; sta...@dpdk.org; Patrick Fu > Subject: [RFC PATCH v2 4/9] vhost: fix async access > > vq->

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-03-28 Thread Pai G, Sunil
Sent: Thursday, March 24, 2022 9:07 PM To: Pai G, Sunil; Hu, Jiayu; Ferriter, Cian; Van Haaren, Harry; Ilya Maximets; Maxime Coquelin (maxime.coque...@redhat.com); ovs-...@openvswitch.org; dev@dpdk.org Cc: Mcnamara, John; O'Driscoll, Tim; Finn, Emma Subject: OVS DPDK DM

RE: [RFC v2 1/2] vhost: support clear in-flight packets for async dequeue

2022-03-27 Thread Pai G, Sunil
Hi Yuan, Thanks for the patch, comment inline. > +uint16_t > +rte_vhost_clear_queue(int vid, uint16_t queue_id, struct rte_mbuf **pkts, > + uint16_t count, int16_t dma_id, uint16_t vchan_id) { > + struct virtio_net *dev = get_device(vid); > + struct vhost_virtqueue *vq; > +

RE: [PATCH v1] dmadev: add telemetry support

2022-03-25 Thread Pai G, Sunil
> -Original Message- > From: Sean Morrissey > Sent: Wednesday, March 23, 2022 10:19 PM > To: Chengwen Feng ; Laatz, Kevin > ; Richardson, Bruce > Cc: dev@dpdk.org; Morrissey, Sean > Subject: [PATCH v1] dmadev: add telemetry support > > Telemetry commands are now registered through the

RE: [ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-03-21 Thread Pai G, Sunil
> Hi, Sunil. > > Mail-list strips attachments. So, if you want to share the presentation, > upload it somewhere accessible and provide a link instead. Hi , Thanks for the suggestion, Ilya. Here is a publicly accessible link to the presentation: https://github.com/Sunil-Pai-G/OVS-DPDK-presenta

RE: [PATCH v2 3/4] dma/idxd: fix wrap-around in burst capacity calculation

2022-01-11 Thread Pai G, Sunil
Tested-by: Sunil Pai G Thanks and regards, Sunil

RE: [PATCH] dma/idxd: fix burst capacity calculation

2022-01-10 Thread Pai G, Sunil
Hi Bruce, > what values for the write_idx and ids_returned vars give this error, and how > does masking help? I'd expect masking to increase the number of times the > function returns zero, rather than decreasing it. Here are the values from the idxd dump: dev_capa: 0x50051 - mem2mem sva han

RE: [PATCH] dma/idxd: fix burst capacity calculation

2022-01-10 Thread Pai G, Sunil
Hi Bruce, Kevin This patch seems to have uncovered a bug in the driver. On applying, the idxd_burst_capacity API seems to return 0 for cases even when there are batch descriptors and ring space available. Seems like there is a wraparound missing when calculating the descriptor ring space, causin

RE: [PATCH v4 0/2] Add functions to calculate UDP/TCP cksum in mbuf

2021-12-07 Thread Pai G, Sunil
Tested-by: Sunil Pai G Hi , Tested the series with OVS - with both TCP and UDP packets by printing out the csum before sending and after reception of packets from testpmd. Getting expected csum values with this patch. Thanks and regards Sunil

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Pai G, Sunil
Hi Jerin, > > > To understand it better, Could you share more details on feedback > > > mechanism on your application enqueue > > > > > > app_enqueue_v1(.., nb_seg) > > > { > > > /* Not enough space, Let application handle it by > > > dropping or resubmitting */ > > >

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Pai G, Sunil
Hi Jerin, > > > > The fact is that it's very hard for apps to calculate the > > > > available space of a > > > DMA ring. > > > > > > Yes, I agree. > > > > > > My question is more why to calculate the space per burst and > > > introduce yet another fastpath API. > > > For example, the applicatio

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread Pai G, Sunil
Hi Jerin, > > > > > From: Kevin Laatz <[2]kevin.la...@intel.com> > > > > > Add a burst capacity check API to the dmadev library. This API is > > > > > useful to > > > > > applications which need to how many descriptors can be enqueued > in > > > > > the > > > > > cur

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-17 Thread Pai G, Sunil
Hi Jerin, > > > Add a burst capacity check API to the dmadev library. This API is > > > useful to > > > applications which need to how many descriptors can be enqueued in > > > the > > > current batch. For example, it could be used to determine whether > > > all >

Re: [dpdk-dev] [PATCH RFC 0/1] vhost-add-DMADEV-support-for-async-datapath

2021-09-13 Thread Pai G, Sunil
Just as FYI, An alternate approach is up on the OVS mailing list : http://patchwork.ozlabs.org/project/openvswitch/list/?series=261277

Re: [dpdk-dev] [PATCH RFC 0/1] vhost-add-DMADEV-support-for-async-datapath

2021-08-31 Thread Pai G, Sunil
Hi Maxime, > Hi Sunil, > > On 8/23/21 11:53 AM, Sunil Pai G wrote: > > Note to the reader: > > --- > > The intent of this patch is to explore possible different approaches > > of async implementations. > > Please consider this patch for discussions only and not for > > merge/up

Re: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost

2021-07-08 Thread Pai G, Sunil
Hi Cheng, Repsonse inline. > As for this one, I'm not sure why we need have the loop in the application. > The function of this API is that caller need to drain all the inflight pkts, > it > should be called only once to get the job done. > Don't you think? Perhaps yes, but my thought was to

Re: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost

2021-07-05 Thread Pai G, Sunil
Hi Cheng, Comments inline. > +uint16_t rte_vhost_drain_queue_thread_unsafe(int vid, uint16_t > queue_id, > + struct rte_mbuf **pkts, uint16_t count) { > + struct virtio_net *dev = get_device(vid); > + struct vhost_virtqueue *vq; > + uint16_t n_pkts = count; > + > +

Re: [dpdk-dev] [PATCH] raw/ioat: fix missing device name in idxd bus scan

2021-06-04 Thread Pai G, Sunil
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, May 27, 2021 7:58 PM > To: Laatz, Kevin > Cc: dev@dpdk.org; sta...@dpdk.org; Pai G, Sunil > Subject: Re: [PATCH] raw/ioat: fix missing device name in idxd bus scan > > On Thu, May 27, 2021 at

Re: [dpdk-dev] [PATCH] raw/ioat: fix parameter shadow warning

2021-05-08 Thread Pai G, Sunil
Tested-by: Sunil Pai G

Re: [dpdk-dev] [PATCH v1 5/6] raw/ioat: add api to query remaining ring space

2021-03-29 Thread Pai G, Sunil
Tested-by: Sunil Pai G

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-24 Thread Pai G, Sunil
> -Original Message- > From: Christian Ehrhardt > Sent: Wednesday, March 24, 2021 1:15 PM > To: Ilya Maximets > Cc: Thomas Monjalon ; Luca Boccassi > ; Richardson, Bruce ; Pai > G, Sunil ; Stokes, Ian ; > Govindharajan, Hariprasad ; > sta...@dpdk.org; dev ;

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-18 Thread Pai G, Sunil
Hi Christian, Ilya > -Original Message- > From: Ilya Maximets > Sent: Thursday, March 18, 2021 8:18 PM > To: Pai G, Sunil ; Christian Ehrhardt > ; Stokes, Ian ; > Ilya Maximets ; Govindharajan, Hariprasad > > Cc: Richardson, Bruce ; Luca Boccassi > ; sta...

Re: [dpdk-dev] 19.11.4 patches review and test

2021-03-18 Thread Pai G, Sunil
Hey Christian, > back in 19.11.4 these DPDK changes were not picked up as they have broken > builds as discussed here. > Later on the communication was that all this works fine now and thereby > Luca has "reverted the reverts" in 19.11.6 [1]. > > But today we were made aware that still no OVS

Re: [dpdk-dev] [PATCH] eal: fix detection of static or shared DPDK builds

2021-02-09 Thread Pai G, Sunil
Hi Bruce, Thanks for the fix. I do see the issue mentioned when using DPDK shared libs with OVS and this patch fixes it. However, I saw the issue only for system installed DPDK but not for directory installed DPDK. > I saw this issue with OVS, where I was getting weird failures about ports n

Re: [dpdk-dev] [PATCH v3 02/25] raw/ioat: fix missing close function

2020-09-25 Thread Pai G, Sunil
> -Original Message- > From: Richardson, Bruce > Sent: Friday, September 25, 2020 4:39 PM > To: dev@dpdk.org > Cc: Fu, Patrick ; Laatz, Kevin ; > sta...@dpdk.org; Pai G, Sunil > Subject: [PATCH v3 02/25] raw/ioat: fix missing close function > > F

Re: [dpdk-dev] 19.11.4 patches review and test

2020-09-01 Thread Pai G, Sunil
are ready as well and will them out soon. Thanks and Regards, Pai G, Sunil Sunil > -Original Message- > From: Bruce Richardson > Sent: Tuesday, September 1, 2020 6:18 PM > To: Christian Ehrhardt > Cc: Luca Boccassi ; sta...@dpdk.org; dev ; > Pai G, Sunil ; Stokes,

Re: [dpdk-dev] [PATCH v4] doc: add deprecation notice for sched changes

2020-08-04 Thread Pai G, Sunil
> -Original Message- > From: dev On Behalf Of Savinay Dharmappa > Sent: Wednesday, July 29, 2020 4:38 PM > To: Dharmappa, Savinay ; Singh, Jasvinder > ; Shetty, Praveen ; > Tummala, Sivaprasad ; dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH v4] doc: add deprecation

Re: [dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-06-30 Thread Pai G, Sunil
> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Friday, June 26, 2020 8:30 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH] eal: don't use default library path for static > binaries > > When using statically linked DPDK binaries, the EAL

Re: [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson

2020-06-30 Thread Pai G, Sunil
> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Friday, May 1, 2020 7:24 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; bl...@debian.org; > david.march...@redhat.com; ktray...@redhat.com; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH v2 0/7] improve DPDK static