RE: [PATCH] mbuf: add transport mode ESP packet type

2024-10-29 Thread Ori Kam
Hi Ajit, Nithin and Olivier > -Original Message- > From: Ajit Khaparde > Sent: Friday, October 25, 2024 2:33 AM > > On Thu, Oct 24, 2024 at 12:30 PM Alexander Kozyrev > wrote: > > > > >>And we definitely need RTE_PTYPE_INNER_L4_ESP for ESP over UDP > support. > > >Isn't this already tak

RE: [PATCH v2 7/7] ethdev: add trace points to flow insertion by index

2024-09-26 Thread Ori Kam
d-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 6/7] app/testpmd: add jump to table index action

2024-09-26 Thread Ori Kam
te_table 0 pattern_template 0 > actions_template 0 postpone no pattern eth / end > actions jump_to_table_index table 0x166f9ce00 index 5 / end > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 5/7] ethdev: add jump to table index action

2024-09-26 Thread Ori Kam
> -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, September 25, 2024 9:06 PM > > Introduce the RTE_FLOW_ACTION_TYPE_JUMP_TO_TABLE_INDEX action. > It redirects packets to a particular index in a flow table. > > Signed-off-by: Alexander Kozyrev

RE: [PATCH v2 4/7] app/testpmd: add insertion by index with pattern option

2024-09-26 Thread Ori Kam
_pattern(). > > flow queue 0 create 0 template_table 2 rule_index 5 > pattern_template 0 actions_template 0 postpone no pattern eth / end > actions count / queue index 1 / end > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 3/7] ethdev: add flow rule insertion by index with pattern

2024-09-26 Thread Ori Kam
ew flow rule creation > function with both rule index and pattern provided. > Packets will match on the provided pattern at the provided index. > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 2/7] app/testpmd: add index with pattern insertion type

2024-09-26 Thread Ori Kam
ity 0 > insertion_type index_with_pattern ingress rules_number 64 > pattern_template 2 actions_template 2 > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 1/7] ethdev: add insertion by index with pattern

2024-09-26 Thread Ori Kam
the index. > We need another mode that allows to match on the pattern at > the index: insertion by index with pattern. > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence

2024-06-10 Thread Ori Kam
t; Cc: michae...@nvidia.com > Cc: sta...@dpdk.org > > Signed-off-by: Rongwei Liu > Acked-by: Dariusz Sosnowski > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v6 1/4] app/testpmd: fix the testpmd field string sequence

2024-06-09 Thread Ori Kam
> > Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") > Cc: michae...@nvidia.com > Cc: sta...@dpdk.org > > Signed-off-by: Rongwei Liu > Acked-by: Dariusz Sosnowski > --- Acked-by: Ori Kam

RE: [v1 2/2] app/testpmd: introduce VXLAN-GBP and VXLAN-GPE fields

2024-05-23 Thread Ori Kam
; ... / udp dst is 4789 / vxlan ... / ... > To match VXLAN-GBP group policy ID 4321, > ... / udp dst is 4789 / vxlan group_policy_id is 4321 ... / ... > To match VXLAN-GPE, > ... / udp dst is 4790 / vxlan protocol is 2 ... / ... > > Signed-off-by: Gavin Li > Acked-by: Thomas Monjalon > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH 00/11] net/mlx5: flow insertion performance improvements

2024-02-29 Thread Ori Kam
| 6 + > drivers/net/mlx5/hws/mlx5dr_action.h | 2 + > drivers/net/mlx5/hws/mlx5dr_matcher.c | 29 + > drivers/net/mlx5/mlx5.h | 29 +- > drivers/net/mlx5/mlx5_flow.h | 128 - > drivers/net/mlx5/mlx5_flow_hw.c | 794 -- > 7 files changed, 666 insertions(+), 338 deletions(-) > > -- > 2.39.2 Series-acked-by: Ori Kam Best, Ori

RE: rss calculation as the nic

2024-02-25 Thread Ori Kam
Sent: Thursday, February 22, 2024 8:49 AM To: Yaron Illouz Cc: Ori Kam ; dev@dpdk.org; us...@dpdk.org Subject: Re: rss calculation as the nic On Wed, Feb 21, 2024 at 9:40 PM Yaron Illouz mailto:yar...@radcom.com>> wrote: Hi Ori Thank you for your answer it helped me But I can see th

RE: [PATCH v3 0/5] NAT64 support in mlx5 PMD

2024-02-21 Thread Ori Kam
drivers/net/mlx5/mlx5.h| 8 + > drivers/net/mlx5/mlx5_flow.h | 12 + > drivers/net/mlx5/mlx5_flow_dv.c| 4 +- > drivers/net/mlx5/mlx5_flow_hw.c| 136 ++++ > 12 files changed, 686 insertions(+), 2 deletions(-) > > -- > 2.34.1 Series-acked-by: Ori Kam Best, Ori

RE: rss calculation as the nic

2024-02-14 Thread Ori Kam
Hi Yaron, I can see some possible issues with your code, please see below. From: Yaron Illouz Sent: Saturday, February 3, 2024 7:03 PM To: dev@dpdk.org; 'us...@dpdk.org' Subject: rss calculation as the nic [Snip] static inline uint32_t do_softrss(struct rte_mbuf *m) { uint32_t input_len;

[PATCH v4 4/4] app/testpmd: add encap hash calculation

2024-02-13 Thread Ori Kam
/ udp dst is 5678 src is 1234 / end Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 57 +++-- app/test-pmd/config.c | 30 +++ app/test-pmd/testpmd.h | 3 ++ doc/guides

[PATCH v4 3/4] net/mlx5: add calc encap hash support

2024-02-13 Thread Ori Kam
This commit adds support for encap hash calculation. Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c| 29 +++ drivers/net/mlx5/mlx5_flow.h| 8 drivers/net/mlx5/mlx5_flow_hw.c | 66 + 3 files changed

[PATCH v4 2/4] net/mlx5/hws: introduce encap entropy hash calculation API

2024-02-13 Thread Ori Kam
From: Hamdan Igbaria Add new function for encap entropy hash calculation, the function will check the device capability for the entropy hash type used by the device, and will calculate the entropy hash value of the user passed fields according this type. Signed-off-by: Hamdan Igbaria Acked-by:

[PATCH v4 1/4] ethdev: introduce encap hash calculation

2024-02-13 Thread Ori Kam
will do for the rest of the packets in this flow. the new function rte_flow_calc_encap_hash can query the hash value from the driver for a given packet as if the packet was passed through the HW. Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- doc/guides/prog_guide/rte_flow.rst | 14

[PATCH v3 4/4] app/testpmd: add encap hash calculation

2024-02-13 Thread Ori Kam
/ udp dst is 5678 src is 1234 / end Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 57 +++-- app/test-pmd/config.c | 30 +++ app/test-pmd/testpmd.h | 3 ++ doc/guides

[PATCH v3 2/4] net/mlx5/hws: introduce encap entropy hash calculation API

2024-02-13 Thread Ori Kam
From: Hamdan Igbaria Add new function for encap entropy hash calculation, the function will check the device capability for the entropy hash type used by the device, and will calculate the entropy hash value of the user passed fields according this type. Signed-off-by: Hamdan Igbaria Acked-by:

[PATCH v3 3/4] net/mlx5: add calc encap hash support

2024-02-13 Thread Ori Kam
This commit adds support for encap hash calculation. Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c| 29 +++ drivers/net/mlx5/mlx5_flow.h| 8 drivers/net/mlx5/mlx5_flow_hw.c | 66 + 3 files changed

[PATCH v3 1/4] ethdev: introduce encap hash calculation

2024-02-13 Thread Ori Kam
will do for the rest of the packets in this flow. the new function rte_flow_calc_encap_hash can query the hash value fromm the driver for a given packet as if the packet was passed through the HW. Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- doc/guides/prog_guide/rte_flow.rst | 14

RE: [PATCH v2 1/4] ethdev: introduce encap hash calculation

2024-02-12 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Monday, February 12, 2024 10:10 PM > > On 2/12/2024 6:44 PM, Ori Kam wrote: > > Hi Ferruh > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Monday, February 12

RE: [PATCH v2 1/4] ethdev: introduce encap hash calculation

2024-02-12 Thread Ori Kam
Hi Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Monday, February 12, 2024 7:05 PM > > On 2/11/2024 7:29 AM, Ori Kam wrote: > > Hi Ferruh, > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Thursda

RE: [PATCH v2 1/4] ethdev: introduce encap hash calculation

2024-02-10 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, February 8, 2024 7:13 PM > To: Ori Kam ; Dariusz Sosnowski > > On 2/8/2024 9:09 AM, Ori Kam wrote: > > During encapsulation of a packet, it is possible to change some > > outer header

RE: [PATCH v3 4/6] ethdev: add modify action support for IPsec fields

2024-02-08 Thread Ori Kam
LD_ESP_SEQ_NUM, /**< ESP Sequence Number. > */ > + RTE_FLOW_FIELD_ESP_PROTO/**< ESP next protocol value. */ > }; > > /** > -- > 2.18.1 Acked-by: Ori Kam Best, Ori

[PATCH v2 4/4] app/testpmd: add encap hash calculation

2024-02-08 Thread Ori Kam
/ udp dst is 5678 src is 1234 / end Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 57 +++-- app/test-pmd/config.c | 30 +++ app/test-pmd/testpmd.h | 3 ++ doc/guides

[PATCH v2 3/4] net/mlx5: add calc encap hash support

2024-02-08 Thread Ori Kam
This commit adds support for encap hash calculation. Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c| 29 +++ drivers/net/mlx5/mlx5_flow.h| 8 drivers/net/mlx5/mlx5_flow_hw.c | 66 + 3 files changed

[PATCH v2 2/4] net/mlx5/hws: introduce encap entropy hash calculation API

2024-02-08 Thread Ori Kam
From: Hamdan Igbaria Add new function for encap entropy hash calculation, the function will check the device capability for the entropy hash type used by the device, and will calculate the entropy hash value of the user passed fields according this type. Signed-off-by: Hamdan Igbaria Acked-by:

[PATCH v2 1/4] ethdev: introduce encap hash calculation

2024-02-08 Thread Ori Kam
will do for the rest of the packets in this flow. the new function rte_flow_calc_encap_hash can query the hash value fromm the driver for a given packet as if the packet was passed through the HW. Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- doc/guides/prog_guide/rte_flow.rst | 14

RE: [PATCH 1/4] ethdev: introduce encap hash calculation

2024-02-06 Thread Ori Kam
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, February 7, 2024 12:40 AM > > 28/01/2024 10:39, Ori Kam: > > During the encapsulation of a packet, it is expected to calculate the > > hash value which is based on the original packet (

RE: [PATCH 2/6] app/testpmd: add modify IPv4 next protocol command line

2024-02-06 Thread Ori Kam
cmdline_flow.c > @@ -962,6 +962,7 @@ static const char *const modify_field_ids[] = { > "geneve_opt_type", "geneve_opt_class", "geneve_opt_data", > "mpls", > "tcp_data_off", "ipv4_ihl", "ipv4_total_len", "ipv6_payload_len", > "random", > + "ipv4_proto", > NULL > }; > > -- > 2.18.1 Acked-by: Ori Kam Best, Ori

RE: [PATCH 1/6] ethdev: add modify IPv4 next protocol field

2024-02-06 Thread Ori Kam
; IPv6 payload length. */ > - RTE_FLOW_FIELD_RANDOM /**< Random value. */ > + RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > + RTE_FLOW_FIELD_IPV4_PROTO /**< IPv4 next protocol. */ > }; > > /** > -- > 2.18.1 Acked-by: Ori Kam Best, Ori

RE: [PATCH 1/4] ethdev: introduce encap hash calculation

2024-02-01 Thread Ori Kam
Hi Ferruh, Can you please review my patch? Thanks, Ori > -Original Message- > From: Ori Kam > Sent: Sunday, January 28, 2024 11:40 AM > To: Dariusz Sosnowski ; ferruh.yi...@amd.com; > > During the encapsulation of a packet, it is expected to calculate the > hash

RE: [PATCH v2 2/2] app/testpmd: add support for NAT64 in the command line

2024-02-01 Thread Ori Kam
testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -4169,6 +4169,10 @@ This section lists supported actions and their > attributes, if any. >- ``src_ptr``: pointer to source immediate value. >- ``width``: number of bits to copy. > > +- ``nat64``: NAT64 IP headers translation > + > + - ``type {unsigned}``: NAT64 translation type > + > Destroying flow rules > ~ > > -- > 2.34.1 Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 1/2] ethdev: introduce NAT64 action

2024-02-01 Thread Ori Kam
ce links: > - https://datatracker.ietf.org/doc/html/rfc6146 > - https://datatracker.ietf.org/doc/html/rfc6052 > - https://datatracker.ietf.org/doc/html/rfc6145 > > Signed-off-by: Bing Zhao > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 31, 2024 7:54 PM > > On 1/31/2024 5:43 PM, Ori Kam wrote: > > > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Wednesday, January 31, 202

RE: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 31, 2024 6:46 PM > Subject: Re: [PATCH v3 2/3] ethdev: add compare item > > On 1/31/2024 3:56 PM, Ori Kam wrote: > > Hi > > > >> -Original Message- > >> From

RE: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Ori Kam
Hi > -Original Message- > From: Suanming Mou > Sent: Wednesday, January 31, 2024 4:48 AM > > Hi, > > > -Original Message- > > From: Ferruh Yigit > > Sent: Wednesday, January 31, 2024 1:34 AM > > To: Suanming Mou ; Ori Kam > ; &g

RE: [PATCH v2] ethdev: fast path async flow API

2024-01-31 Thread Ori Kam
_async_action_handle_query_update() > - rte_flow_async_action_list_handle_create() > - rte_flow_async_action_list_handle_destroy() > - rte_flow_async_action_list_handle_query_update() > > This patch also adjusts the mlx5 PMD to the introduced flow API changes. > > Signed-off-by: Dariusz Sosnowski > --- > v2: > - Fixed mlx5 PMD build issue with older versions of rdma-core. > --- Acked-by: Ori Kam Best, Ori

[PATCH 4/4] app/testpmd: add encap hash calculation

2024-01-28 Thread Ori Kam
/ udp dst is 5678 src is 1234 / end Signed-off-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 57 +++-- app/test-pmd/config.c | 30 +++ app/test-pmd/testpmd.h | 3 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 21

[PATCH 3/4] net/mlx5: add calc encap hash support

2024-01-28 Thread Ori Kam
This commit adds support for encap hash calculation. Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c| 29 +++ drivers/net/mlx5/mlx5_flow.h| 8 drivers/net/mlx5/mlx5_flow_hw.c | 66 + 3 files changed, 103 insertions(+) diff --git

[PATCH 2/4] net/mlx5/hws: introduce encap entropy hash calculation API

2024-01-28 Thread Ori Kam
From: Hamdan Igbaria Add new function for encap entropy hash calculation, the function will check the device capability for the entropy hash type used by the device, and will calculate the entropy hash value of the user passed fields according this type. Signed-off-by: Hamdan Igbaria --- drive

[PATCH 1/4] ethdev: introduce encap hash calculation

2024-01-28 Thread Ori Kam
lates the packet and must use the same hash calculation as the HW will do for the rest of the packets in this flow. This patch gives the SW a way to query the hash value for a given packet as if the packet was passed through the HW. Signed-off-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst

[PATCH 0/4] introduce encap hash calculation

2024-01-28 Thread Ori Kam
This patch set adds the support for encap hash calculation. It is based on RFC: https://patchwork.dpdk.org/project/dpdk/patch/20231210083100.7893-1-or...@nvidia.com/ Hamdan Igbaria (1): net/mlx5/hws: introduce encap entropy hash calculation API Ori Kam (3): ethdev: introduce encap hash

RE: [RFC] ethdev: introduce entropy calculation

2024-01-21 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Friday, January 12, 2024 9:46 AM > To: Ori Kam ; Dariusz Sosnowski > ; ferruh.yi...@amd.com; > cristian.dumitre...@intel.com; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Cc: dev@dpdk.org; Raslan

RE: [PATCH v2 3/3] net/mlx5: add compare item support

2024-01-09 Thread Ori Kam
supported. > - Only 32-bit comparison is supported. > - Only single compare flow is supported in the flow table. > - Only match with compare result between packet fields is > supported. > > Signed-off-by: Suanming Mou > --- Acked-by: Ori Kam Best Ori

RE: [PATCH v2 2/3] ethdev: add compare item

2024-01-09 Thread Ori Kam
as below: > - RTE_FLOW_ITEM_COMPARE_EQ (equal) > - RTE_FLOW_ITEM_COMPARE_NE (not equal) > - RTE_FLOW_ITEM_COMPARE_LT (less than) > - RTE_FLOW_ITEM_COMPARE_LE (less than or equal) > - RTE_FLOW_ITEM_COMPARE_GT (great than) > - RTE_FLOW_ITEM_COMPARE_GE (great than or equal) > > Signed-off-by: Suanming Mou > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 1/3] ethdev: rename action modify field data structure

2024-01-09 Thread Ori Kam
s commit renames > it to "rte_flow_field_data" making it compatible to be used by item. > > Signed-off-by: Suanming Mou > --- Acked-by: Ori Kam Best, Ori

RE: [RFC] ethdev: introduce entropy calculation

2024-01-07 Thread Ori Kam
Hi > -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 4, 2024 8:19 PM > > 04/01/2024 15:33, Ori Kam: > > Hi Cristian, > > > > > From: Dumitrescu, Cristian > > > Sent: Thursday, January 4, 2024 2:57 PM > > > >

RE: [RFC] ethdev: introduce entropy calculation

2024-01-04 Thread Ori Kam
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > Sent: Thursday, January 4, 2024 2:57 PM > > > >> > > > >> And unless this is specifically defined as 'entropy' in spec, I am too > > > >> for rename. > > > >> > > > >> At least in VXLAN spec, it is mentioned that this field

RE: [RFC] ethdev: introduce entropy calculation

2023-12-27 Thread Ori Kam
er wrote: > >>> On Thu, 14 Dec 2023 17:18:25 + > >>> Ori Kam wrote: > >>> > >>>>>> Since encap groups number of different 5 tuples together, if HW > doesn’t know > >>>>>> how to RSS > >>>>>> b

RE: [RFC] ethdev: introduce entropy calculation

2023-12-17 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Saturday, December 16, 2023 11:19 AM > > On 12/10/23 11:30, Ori Kam wrote: > > When offloading rules with the encap action, the HW may calculate entropy > based on the encap protocol. > > Eac

RE: [RFC] ethdev: introduce entropy calculation

2023-12-14 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Dumitrescu, Cristian > Sent: Thursday, December 14, 2023 5:25 PM > > Hi Ori, > > A few questions on top of Ferruh's questions for better understanding the > concept inlined below: > > > -----Original Me

RE: [RFC] ethdev: introduce entropy calculation

2023-12-14 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, December 14, 2023 1:35 PM > > On 12/10/2023 8:30 AM, Ori Kam wrote: > > When offloading rules with the encap action, the HW may calculate entropy > based on the encap protocol. > > Eac

RE: [PATCH 4/4] net/mlx5: add modify field action ADD fields validation

2023-12-14 Thread Ori Kam
t; Signed-off-by: Suanming Mou > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH 3/4] net/mlx5: add modify field action ADD fields support

2023-12-14 Thread Ori Kam
field has the sum of src field value and original > dst field value. > > Signed-off-by: Suanming Mou > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH 2/4] net/mlx5: rename modify copy destination to destination

2023-12-14 Thread Ori Kam
D operation will also use that dcopy as ADD_FIELD's > destination. > > This commit renames the dcopy to dest which makes things much clearer. > > Signed-off-by: Suanming Mou > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH 1/4] net/mlx5: add TCP/IP length modify field

2023-12-14 Thread Ori Kam
Hi Suanming > -Original Message- > From: Suanming Mou > Sent: Thursday, December 14, 2023 5:04 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 1/4] net/mlx5: add TCP/IP length modif

RE: [PATCH 1/4] net/mlx5: add TCP/IP length modify field

2023-12-14 Thread Ori Kam
Hi Suanming > -Original Message- > From: Suanming Mou > Sent: Thursday, December 14, 2023 5:04 AM IHL, > IPv6 payload length in modify field operation. > > Signed-off-by: Suanming Mou > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v4 1/2] ethdev: add random item support

2023-12-14 Thread Ori Kam
: Michael Baum > --- Acked-by: Ori Kam Best, Ori

RE: [RFC v2 02/14] regexdev: fix logtype register

2023-12-14 Thread Ori Kam
v_logtype, INFO); > > static uint16_t > regexdev_find_free_dev(void) > -- > 2.43.0 Acked-by: Ori Kam Best, Or

[RFC] ethdev: introduce entropy calculation

2023-12-10 Thread Ori Kam
then when encap is done in SW, application must apply the same entropy calculation algorithm. Using the new API application can request the PMD to calculate the value as if the packet passed in the HW. Signed-off-by: Ori Kam --- lib/ethdev/rte_flow.h

RE: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP'

2023-11-28 Thread Ori Kam
Hi Joey, > -Original Message- > From: Sunyang Wu > Sent: Friday, November 24, 2023 5:31 AM > To: dev@dpdk.org > Cc: Ori Kam ; sta...@dpdk.org; Joey Xing > > Subject: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP' > > Fix the issue of

RE: [PATCH] ethdev: fix 32-bit build with GCC-13

2023-11-01 Thread Ori Kam
ss->queue) * src.rss->queue_num; > - if (size >= off + tmp) > + if (size >= (uint64_t)off + (uint64_t)tmp) > dst.rss->queue = rte_memcpy > ((void *)((uintptr_t)dst.rss + off), >src.rss->queue, tmp); > -- > 2.25.1 Acked-by: Ori Kam Best, Ori

RE: [PATCH 08/13] net/mlx5/hws: adding method to query rule hash

2023-10-29 Thread Ori Kam
ct the location of the rule in the hash table. > > Signed-off-by: Itamar Gozlan > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH] ethdev: fix RTE_FLOW_PORT_FLAG_SHARE_INDIRECT definition

2023-10-29 Thread Ori Kam
LAG_SHARE_INDIRECT RTE_BIT32(0) > - > /** > * @warning > * @b EXPERIMENTAL: this API may change without prior notice. > -- > 2.39.2 Acked-by: Ori Kam Best, Ori

RE: [PATCH] net/mlx5: supporting group set miss actions API

2023-10-29 Thread Ori Kam
vich > --- > Depends-on: series-29572 ("ethdev: add group set miss actions API") > Depends-on: patch-130772 ("net/mlx5: fix jump ipool entry size") > Depends-on: patch-131567 ("net/mlx5/hws: supporting default miss table in > HWS") > Acked-by: Ori Kam Best, Ori

RE: [PATCH 4/5] net/mlx5/hws: supporting default miss table in HWS

2023-10-29 Thread Ori Kam
he target table using the RTC. > This ensures that traffic that does not match any rule in the source table > is forwarded to the target table. > Issue: 3441251 > > Signed-off-by: Itamar Gozlan > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH 2/2] net/mlx5: add random item support

2023-10-29 Thread Ori Kam
> -Original Message- > From: Michael Baum > Sent: Tuesday, August 22, 2023 1:36 PM > Add support for random item in HWS mode. > > Signed-off-by: Michael Baum > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH 1/2] net/mlx5/hws: add support for random number match

2023-10-29 Thread Ori Kam
he mask of that filed we will get half of the traffic in the flow, and > so on with the rest of the mask. > > Signed-off-by: Erez Shitrit > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 2/2] net/mlx5: support new RSS symmetric hash function

2023-10-29 Thread Ori Kam
wapping > the source and destination IP and L4 port automatically. > > Signed-off-by: Xueming Li > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v3] net/mlx5: reuse reformat and modify header actions in a table

2023-10-29 Thread Ori Kam
t; - modify field does not allow empty action template masks. > - raw encap added action template mask validation. > > Signed-off-by: Gregory Etelson > --- > Depends-on: series-28881 ("net/mlx5/hws: add support for multi pattern") > --- > v2: remove Depends-on: patch > v3: add Depends-on: series > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH] net/mlx5: fix the E-Switch mirror flow rule validation

2023-10-29 Thread Ori Kam
ion (to make sure we cover the hardware limitation). > > This patch adds the validation for E-Switch mirror flow rule checking > and rejects as invalid. > > Fixes: 6a951567c159 ("net/mlx5: support E-Switch mirroring and jump in one > flow") > Cc: sta...@dpdk.org > > Signed-off-by: Jiawei Wang > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH 0/3] net/mlx5: add port representor destination to mirror

2023-10-29 Thread Ori Kam
| 2 + > drivers/net/mlx5/mlx5_flow.h| 4 +- > drivers/net/mlx5/mlx5_flow_hw.c | 74 > - > 5 files changed, 85 insertions(+), 2 deletions(-) > > -- Series-acked-by: Ori Kam Best, Ori

RE: [PATCH] net/mlx5/hws: remove csum check from L3 ok check

2023-10-29 Thread Ori Kam
ipv4_csum_ok" is always miss. > For SW steering the old behavior is kept as same as for L4 ok. > > Signed-off-by: Michael Baum > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH] net/mlx5/hws: fix integrity bits level

2023-10-29 Thread Ori Kam
out the encapsulation > level according to the protocol items involved. > > Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v4 4/4] doc: add packet type matching item to release notes

2023-10-29 Thread Ori Kam
> -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, October 25, 2023 11:51 PM > Document new RTE_FLOW_ITEM_TYPE_PTYPE in the release notes. > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v4 3/4] doc: add PMD ptype item limitations

2023-10-29 Thread Ori Kam
Hi > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, October 25, 2023 11:51 PM > > From: Michael Baum > > Add limitations for ptype item support in "mlx5.rst" file. > > Signed-off-by: Michael Baum > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v4 2/4] net/mlx5/hws: add support for fragmented ptype match

2023-10-29 Thread Ori Kam
Hi > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, October 25, 2023 11:51 PM > > Expand packet type matching with support of the > Fragmented IP (Internet Protocol) packet type. > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH v4 1/4] net/mlx5: add support for ptype match in hardware steering

2023-10-29 Thread Ori Kam
tocols in a given packet. That helps with > optimized flow rules matching, eliminating the need of > stacking all the packet headers in the matching criteria. > > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH 1/9] ethdev: overwrite some comment related to RSS

2023-10-29 Thread Ori Kam
Hi Jei, > -Original Message- > From: Jie Hai > Sent: Friday, October 27, 2023 12:28 PM > > 1. overwrite the comments of fields of 'rte_eth_rss_conf'. > 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.h | 33 ++

RE: [PATCH] ethdev: fix flow API support for P4-programmable devices

2023-10-29 Thread Ori Kam
sizeof(struct rte_flow_action_indirect_list)), > + MK_FLOW_ACTION(PROG, > + sizeof(struct rte_flow_action_prog)), > }; > > int > -- > 2.34.1 Acked-by: Ori Kam Best, Ori

RE: [PATCH v5 23/26] regexdev: remove experimental tag

2023-10-22 Thread Ori Kam
s are here to stay, and we don't want to force future HW provider with API that doesn't meet their need. Thanks, Ori > -Original Message- > From: Stephen Hemminger > Sent: Friday, October 20, 2023 11:58 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Ori Kam >

RE: [PATCH] ethdev: fix flow action async query coverity

2023-10-17 Thread Ori Kam
andle_query(dev, queue_id, op_attr, > action_handle, data, user_data, > error); > ret = flow_err(port_id, ret, error); > -- > 2.34.1 Acked-by: Ori Kam

RE: [PATCH] ethdev: remove init_color from METER_MARK action

2023-10-12 Thread Ori Kam
} > + ret = mlx5_flow_update_meter_mark(dev, queue, update, idx, > push, > + job, error); > break; > case MLX5_INDIRECT_ACTION_TYPE_RSS: > ret = flow_dv_action_update(dev, handle, update, error); > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 86ed98c562..b44e6077ad 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -4025,8 +4025,6 @@ struct rte_flow_action_meter_mark { > struct rte_flow_meter_policy *policy; > /** Metering mode: 0 - Color-Blind, 1 - Color-Aware. */ > int color_mode; > - /** Initial Color applied to packets in Color-Aware mode. */ > - enum rte_color init_color; > /** Metering state: 0 - Disabled, 1 - Enabled. */ > int state; > }; > @@ -4045,12 +4043,10 @@ struct rte_flow_update_meter_mark { > uint32_t policy_valid:1; > /** The color mode will be updated. */ > uint32_t color_mode_valid:1; > - /** The initial color will be updated. */ > - uint32_t init_color_valid:1; > /** The meter state will be updated. */ > uint32_t state_valid:1; > /** Reserved bits for the future usage. */ > - uint32_t reserved:27; > + uint32_t reserved:28; > }; > > /** > -- > 2.34.1 Acked-by: Ori Kam Best, Ori

RE: [PATCH v2 25/29] regexdev: remove experimental tag

2023-10-11 Thread Ori Kam
arvel can comment on this lib support? Thanks, Ori > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, August 9, 2023 3:10 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Ori Kam > > Subject: [PATCH v2 25/29] regexdev: remove experimental tag >

RE: [PATCH v1] app/testpmd: refine encap content

2023-10-11 Thread Ori Kam
Hi Zhang, > -Original Message- > From: Zhang, Yuying > Sent: Tuesday, August 22, 2023 4:13 AM > > From: Yuying Zhang > > Refine vxlan encap content of all protocol headers. > > Fixes: 1960be7d32f8 ("app/testpmd: add VXLAN encap/decap") > Cc: sta...@dpdk.org > > Signed-off-by: Yuying

[PATCH v2] ethdev: add calculate hash function

2023-10-10 Thread Ori Kam
d the packet to the correct port. This new API allows applications to calculate the hash value of a given packet for a given table. [1] - http://patches.dpdk.org/project/dpdk/patch/20230208030624.78465-2-akozy...@nvidia.com/ Signed-off-by: Ori Kam --- v2: add rst documentations --- app/tes

RE: [PATCH] ethdev: add calculate hash function

2023-10-10 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 10, 2023 2:06 PM > > On 9/26/2023 12:37 PM, Ori Kam wrote: > > rte_flow supports insert by index table[1]. > > > > Using the above table, the application can create rules &g

[PATCH] ethdev: add calculate hash function

2023-09-26 Thread Ori Kam
d the packet to the correct port. This new API allows applications to calculate the hash value of a given packet for a given table. [1] - http://patches.dpdk.org/project/dpdk/patch/20230208030624.78465-2-akozy...@nvidia.com/ Signed-off-by: Ori Kam --- app/test-pmd/cmdline_flow.c

RE: [PATCH V2] ethdev: add flow API support for P4-programmable devices

2023-09-26 Thread Ori Kam
/** Action name. */ > + const char *name; > + /** Number of action arguments. */ > + uint32_t args_num; > + /** Action arguments array. */ > + const struct rte_flow_action_prog_argument *args; > +}; > + > /* Mbuf dynamic field offset for metadata. */ > extern int32_t rte_flow_dynf_metadata_offs; > > -- > 2.34.1 Acked-by: Ori Kam Best, Ori

RE: [PATCH] ethdev: add flow API support for P4-programmable devices

2023-09-21 Thread Ori Kam
Hi Cristian, > -Original Message- > From: Cristian Dumitrescu > Sent: Friday, September 15, 2023 10:00 PM > Subject: [PATCH] ethdev: add flow API support for P4-programmable devices > > This patch introduces the new "program" action type to enable flow API > support for P4-programmable d

RE: [RFC PATCH] ethdev: introduce NAT64 action

2023-09-19 Thread Ori Kam
s protocol is out of the scope of NAT64 > rte_flow action. > > Reference links: > - https://datatracker.ietf.org/doc/html/rfc6146 > - https://datatracker.ietf.org/doc/html/rfc6052 > - https://datatracker.ietf.org/doc/html/rfc6145 > > Signed-off-by: Bing Zhao > --- Acked-by: Ori Kam Best, Ori

RE: [PATCH] ethdev: add packet type matching item

2023-09-19 Thread Ori Kam
gt; Please add testpmd example line. > Signed-off-by: Alexander Kozyrev > --- Acked-by: Ori Kam Thanks, Ori

RE: [PATCH v2 2/2] app/testpmd: add random item support

2023-09-18 Thread Ori Kam
25% of the traffic, it hits only > when random value suffix is "01" and miss the others ("00", "10", "11"). > > Signed-off-by: Michael Baum > --- Acked-by: Ori Kam Best, Ori

RE: DPDK community: RTE_FLOW support for P4-programmable devices

2023-09-06 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Monday, September 4, 2023 10:46 AM > > On 9/1/2023 10:52 AM, Jerin Jacob wrote: > > On Fri, Sep 1, 2023 at 12:27 PM Ori Kam wrote: > >> > >> > >> > >>> -Original Message--

RE: DPDK community: RTE_FLOW support for P4-programmable devices

2023-08-31 Thread Ori Kam
> -Original Message- > From: Jerin Jacob > Sent: Friday, September 1, 2023 5:07 AM > > On Thu, Aug 31, 2023 at 4:02 PM Ori Kam wrote: > > > > Hi > > > > >> > > > >> 3. Everybody on the call agreed that the P4-programmable

RE: DPDK community: RTE_FLOW support for P4-programmable devices

2023-08-31 Thread Ori Kam
Hi > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, August 29, 2023 1:18 PM > devices > > On 8/29/2023 8:38 AM, Jerin Jacob wrote: > > On Mon, Aug 28, 2023 at 9:43 PM Dumitrescu, Cristian > > wrote: > >> > We just set up a community call for next week to discuss in more d

  1   2   3   4   5   6   7   8   9   10   >