Re: [PATCH V3] doc: announce the pipeline legacy API deprecation

On 3/9/2023 8:09 PM, Cristian Dumitrescu wrote: Announce the deprecation of the legacy pipeline, table and port library API and gradual stabilization of the new API. Signed-off-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 18 ++ 1 file changed, 18 inse

RE: [EXT] Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

Hi Tejasree, I think it will make more sense but I will let Akhil decide. -Original Message- From: Tejasree Kondoj Sent: Tuesday, February 21, 2023 4:38 PM To: Nicolau, Radu ; Akhil Goyal Cc: Anoob Joseph ; dev@dpdk.org Subject: RE: [EXT] Re: [PATCH v2] examples/ipsec-secgw: set AES

Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

Hi On 2/1/2023 2:16 PM, Akhil Goyal wrote: Hi Radu, Subject: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16 Set AES-CTR IV length as 16 instead of taking from SA config option since the application populates 16B IV in the datapath. AES-CTR requires 16B IV constructed from nonce

Re: [PATCH v4] net/iavf: fix TSO offload for tunnel case

On 9/29/2022 6:27 AM, Zhichao Zeng wrote: This patch is to fix the tunnel TSO not enabling issue, simplify the logic of calculating 'Tx Buffer Size' of data descriptor with IPSec, and fix handling that the mbuf size exceeds the TX descriptor hardware limit(1B-16KB) which causes malicious behavi

Re: [PATCH] net/iavf: remove unimplemented function call

On 5/30/2022 12:36 PM, Qi Zhang wrote: Remove unimplemented function call be wrapped by RTE_LIBRTE_IAVF_DEBUG_TX_DESC_RING Fixes: 1e728b01120c ("net/iavf: rework Tx path") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- Acked-by: Radu Nicolau

Re: [PATCH] crypto/ipsec_mb: fix GMAC parameters setting

On 3/9/2022 10:45 AM, Pablo de Lara wrote: AES-GMAC requires plaintext length to be 0 when using AES-GCM, so only AAD data is used. Fixes: a501609ea646 ("crypto/ipsec_mb: fix length and offset settings") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara ---

Re: [PATCH] net/iavf: fix segmentation offload buffer size

On 2/15/2022 12:48 PM, Ferruh Yigit wrote: On 2/15/2022 12:44 PM, Ferruh Yigit wrote: On 2/15/2022 12:30 PM, Nicolau, Radu wrote: On 2/15/2022 11:19 AM, Ferruh Yigit wrote: On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu

Re: [PATCH] net/iavf: fix segmentation offload buffer size

On 2/15/2022 11:19 AM, Ferruh Yigit wrote: On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes

Re: [PATCH] net/iavf: fix segmentation offload buffer size

On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") Commit 'ff8b8bcd2ebe' was alr

Re: [PATCH] net/iavf: fix null pointer dereference

On 1/25/2022 2:23 PM, Weiguo Li wrote: Check for memory allocation failure is added to avoid null pointer dereference. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Signed-off-by: Weiguo Li --- Acked-by: Radu Nicolau

Re: [PATCH v1] net/iavf: remove the extra symbol '+'

On 12/16/2021 4:43 AM, Haiyue Wang wrote: This extra symbol '+' should be added when patch was reapplied, and the compiler treats it as unsigned type, so the code still runs well. Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message") Cc:sta...@dpdk.org Signed-off-by: H

Re: [dpdk-dev] [EXT] [PATCH v6 1/7] examples/ipsec-secgw: add stats interval argument

On 11/3/2021 9:23 AM, Akhil Goyal wrote: -#if (STATS_INTERVAL > 0) struct ipsec_core_statistics { uint64_t tx; uint64_t rx; @@ -94,7 +90,6 @@ struct ipsec_core_statistics { } __rte_cache_aligned; struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE]; -#endif /* STAT

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: add support for event vector

Hi Akhil, I'm even less familiar with this section, so no objection from me neither. On 11/1/2021 10:39 AM, Ananyev, Konstantin wrote: Hi Akhil, Hi Konstantin/Radu, Adds event vector support to inline protocol offload mode. By default vector support is disabled, it can be enabled by using

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add support for TSO

I'm seeing this problem: if we support both TCP and UDP TSO then we will check the TX offloads for both (and IPsec) and so far the only PMDs that support IPsec and TSO only support TCP TSO. So I will rework the patch to only enable TSO for TCP Inline crypto. On 10/27/2021 1:44 PM, Ni

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add support for TSO

On 10/27/2021 1:02 PM, Ananyev, Konstantin wrote: Add support to allow user to specific MSS for TSO offload on a per SA basis. MSS configuration in the context of IPsec is only supported for outbound SA's in the context of an inline IPsec Crypto offload. Signed-off-by: Declan Doherty Signed

Re: [dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

On 10/26/2021 6:45 PM, Ananyev, Konstantin wrote: Hi, I reworked this patch as part of a new patchset, and some comments below. On the comment about the offload capabilities, i.e. what happens if a PMD supports SECURITY and TSO but not both in the same time, well, if this is the case they sh

Re: [dpdk-dev] [EXT] [PATCH 1/2] ipsec: add transmit segmentation offload support

Hi Akhil, I will address all issues except the last one with a comment below: - n = num; - sqn = esn_outb_update_sqn(sa, &n); - if (n != num) + n_sqn = nb_segs_t; + sqn = esn_outb_update_sqn(sa, &n_sqn); + if (n_sqn != nb_segs_t) { rte_errno =

Re: [dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

Hi, I reworked this patch as part of a new patchset, and some comments below. On the comment about the offload capabilities, i.e. what happens if a PMD supports SECURITY and TSO but not both in the same time, well, if this is the case they should not be set both, and also this can theoretical

Re: [dpdk-dev] [EXT] [PATCH v10 0/9] new features for ipsec and security libraries

On 10/17/2021 1:17 PM, Akhil Goyal wrote: Add support for: NAT-T/UDP encapsulation AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry ESN with initial SQN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Ra

Re: [dpdk-dev] [PATCH] net: add support for UDP segmentation case

Hi Olivier, thanks for the feedback. I marked it as deferred for this release. On 10/14/2021 4:46 PM, Olivier Matz wrote: Hi Radu, On Fri, Sep 03, 2021 at 11:59:42AM +0100, Radu Nicolau wrote: [PATCH] net: add support for UDP segmentation case What about this title instead? net: exclude IP

Re: [dpdk-dev] [PATCH v8 06/10] ipsec: add transmit segmentation offload support

On 10/12/2021 5:25 PM, Ananyev, Konstantin wrote: +/* check if packet will exceed MSS and segmentation is required */ +static inline int +esn_outb_nb_segments(struct rte_mbuf *m) { DPDK codying style pls. + uint16_t segments = 1; + uint16_t pkt_l3len = m->pkt_len - m->l2_len; + +

Re: [dpdk-dev] [PATCH v8 04/10] ipsec: add support for NAT-T

On 10/12/2021 11:50 AM, Ananyev, Konstantin wrote: + memcpy(sa->hdr, prm->tun.hdr, prm->tun.hdr_len); + + /* insert UDP header if UDP encapsulation is inabled */ + if (sa->type & RTE_IPSEC_SATP_NATT_ENABLE) { + struct rte_udp_hdr *udph = (struct rte_udp_hdr *

Re: [dpdk-dev] [EXT] [PATCH v3 8/8] examples/ipsec-secgw: add support for additional algorithms

Hi Akhil, thanks for the feedback, some comments below. On 10/8/2021 8:07 PM, Akhil Goyal wrote: Add support for AES-GMAC, AES_CTR, AES_XCBC_MAC, AES_CCM, CHACHA20_POLY1305 Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.h | 3 +- examples/ipsec-s

Re: [dpdk-dev] [EXT] [PATCH 1/3] crypto/aesni_mb: add NULL/NULL support

On 10/8/2021 7:18 PM, Akhil Goyal wrote: Hi Radu and Akhil We can add this change as a patch into http://patchwork.dpdk.org/project/dpdk/cover/20210929163035.608387-1-ciara.po...@intel.com/ v4 it is ok. The doc can be updated accordingly. No issues from my side. Same for my side, no issu

Re: [dpdk-dev] [PATCH v4 6/6] net/iavf: add watchdog for VFLR

On 10/8/2021 7:19 AM, Wu, Jingjing wrote: Besides checking VFGEN_RSTAT, there is a process to handle VIRTCHNL_OP_EVENT from PF. What is the change for? Any scenario which VIRTCHNL_OP_EVENT doesn't cover? And how is the 500us been determined? Hi Jingjing, thanks for reviewing, I think this

Re: [dpdk-dev] [PATCH v4 6/6] net/iavf: add watchdog for VFLR

On 10/4/2021 12:18 PM, Nicolau, Radu wrote: On 10/4/2021 3:15 AM, Wu, Jingjing wrote: -Original Message- From: Nicolau, Radu Sent: Friday, October 1, 2021 5:52 PM To: Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Doherty, Declan ; Sinha, Abhijit ; Zhang, Qi Z ; Richardson

Re: [dpdk-dev] [PATCH v4 6/6] net/iavf: add watchdog for VFLR

On 10/4/2021 3:15 AM, Wu, Jingjing wrote: -Original Message- From: Nicolau, Radu Sent: Friday, October 1, 2021 5:52 PM To: Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Doherty, Declan ; Sinha, Abhijit ; Zhang, Qi Z ; Richardson, Bruce ; Ananyev, Konstantin ; Nicolau, Radu

Re: [dpdk-dev] [PATCH v6 04/10] mbuf: add IPsec ESP tunnel type

On 9/23/2021 1:59 PM, Ananyev, Konstantin wrote: Add tunnel type for IPsec ESP tunnels Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang Acked-by: Akhil Goyal Acked-by: Olivier Matz --- lib/m

Re: [dpdk-dev] [PATCH v6 06/10] ipsec: add transmit segmentation offload support

On 9/23/2021 3:09 PM, Ananyev, Konstantin wrote: Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by:

Re: [dpdk-dev] [PATCH v6 07/10] ipsec: add support for NAT-T

On 9/27/2021 3:55 PM, Ananyev, Konstantin wrote: On 9/23/2021 5:43 PM, Ananyev, Konstantin wrote: Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin

Re: [dpdk-dev] [PATCH v6 07/10] ipsec: add support for NAT-T

On 9/23/2021 5:43 PM, Ananyev, Konstantin wrote: Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang --- lib/ipsec/iph.

Re: [dpdk-dev] [PATCH v6 03/10] security: add ESN field to ipsec_xform

On 9/23/2021 1:46 PM, Ananyev, Konstantin wrote: Update ipsec_xform definition to include ESN field. This allows the application to control the ESN starting value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Ac

Re: [dpdk-dev] [PATCH v6 02/10] security: add UDP params for IPsec NAT-T

On 9/23/2021 1:43 PM, Ananyev, Konstantin wrote: Add support for specifying UDP port params for UDP encapsulation option. RFC3948 section-2.1 does not enforce using specific the UDP ports for UDP-Encapsulated ESP Header Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by:

Re: [dpdk-dev] [EXT] [PATCH v4 02/10] security: add UDP params for IPsec NAT-T

On 9/24/2021 10:11 AM, Hemant Agrawal wrote: On 9/6/2021 4:39 PM, Nicolau, Radu wrote: On 9/5/2021 3:19 PM, Akhil Goyal wrote: Hi Radu, Add support for specifying UDP port params for UDP encapsulation option. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by

Re: [dpdk-dev] [PATCH v2 2/4] net/iavf: add iAVF IPsec inline crypto support

Hi Jingjing, thanks for reviewing! On 9/18/2021 6:28 AM, Wu, Jingjing wrote: In general, the patch is too big to review. Patch split would help a lot! I will do my best to split in in the next revision. [...] +static const struct rte_cryptodev_symmetric_capability * +get_capability(struct i

Re: [dpdk-dev] [EXT] [PATCH v2 4/9] examples/ipsec-secgw: add stats interval argument

Hi Anoob, On 9/16/2021 10:30 AM, Anoob Joseph wrote: Hi Radu, Making stats dynamic would have a perf cost. That was the reason it was introduced as a compile time option. Why do we need it changed? We changed it for two reasons, for a better UX and for the telemetry feature that is introduced

Re: [dpdk-dev] [PATCH] build: fix building when essential drivers in disable list

On 8/18/2021 2:42 PM, Bruce Richardson wrote: The PCI and vdev bus drivers cannot be disabled for DPDK builds and special logic is put in place to not skip them when they are specified in the disable list. This logic is broken though, as the inclusion of the driver-specific meson.build file is

Re: [dpdk-dev] [EXT] [PATCH 1/7] examples/ipsec-secgw: add ol_flags support

Hi Akhil, On 9/8/2021 1:48 PM, Akhil Goyal wrote: Add support for ol_flags to the IPsec GW sample app. Description is not appropriate. ol_flags are supported to do what? How the existing code was not good and what benefit do we get from this patch? Thanks for reviewing the series! I will addre

Re: [dpdk-dev] [PATCH] telemetry: add support for dicts of dicts

On 9/6/2021 5:25 PM, Power, Ciara wrote: Hi Radu, -Original Message- From: Nicolau, Radu Sent: Friday 3 September 2021 11:57 To: Power, Ciara Cc: dev@dpdk.org; Nicolau, Radu ; Doherty, Declan Subject: [PATCH] telemetry: add support for dicts of dicts Add support for dicts of

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

On 9/6/2021 12:36 PM, Anoob Joseph wrote: Hi Radu, Hi Akhil, I suppose they can be complementary, with this one being a hard ESN limit that the user can enforce by setting the initial ESN value - but there is no requirement to do so. Also, this change doesn't need explicit support added in th

Re: [dpdk-dev] [EXT] [PATCH v4 10/10] ipsec: add ol_flags support

On 9/5/2021 4:14 PM, Akhil Goyal wrote: Set mbuff->ol_flags for IPsec packets. Could you please add more information in the description About the need of the patch and what issue this patch is resolving. I will add something like below, is that ok? "Update the IPsec library to set mbuff->o

Re: [dpdk-dev] [EXT] [PATCH v4 07/10] ipsec: add support for NAT-T

On 9/5/2021 4:00 PM, Akhil Goyal wrote: Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley --- These ports are not getting used in this patch,

Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform

On 9/5/2021 3:47 PM, Akhil Goyal wrote: Hi Radu, -- Update ipsec_xform definition to include ESN field. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin B

Re: [dpdk-dev] [EXT] [PATCH v4 02/10] security: add UDP params for IPsec NAT-T

On 9/5/2021 3:19 PM, Akhil Goyal wrote: Hi Radu, Add support for specifying UDP port params for UDP encapsulation option. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Do we really need to specify the port num

Re: [dpdk-dev] [EXT] [PATCH v3 00/10] new features for ipsec and security libraries

On 8/13/2021 12:08 PM, Akhil Goyal wrote: Changelog?? Sorry, just a small fix for a build error and corrected misspelled email address. Add support for: TSO, NAT-T/UDP encapsulation, ESN AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry mbuf offload flags Initial SQN value Signed-off-by

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

On 7/31/2021 6:44 PM, Akhil Goyal wrote: From: Archana Muniganti Propose new fields to support offloads like - IPsec inner checksum(L3/L4) - IPsec tunnel header verification - TSO - etc in the structure ``rte_security_ipsec_sa_options``. Signed-off-by: Archana Muniganti Signed-off-by: Tejas

Re: [dpdk-dev] [EXT] [PATCH 01/10] security: add support for TSO on IPsec session

Hi, thanks for reviewing. I'm OOO at the moment, I will send an updated patchset next week. On 7/27/2021 9:34 PM, Akhil Goyal wrote: Allow user to provision a per security session maximum segment size (MSS) for use when Transmit Segmentation Offload (TSO) is supported. The MSS value will be use

Re: [dpdk-dev] [PATCH] eal: add experimental tags for write combining store

On 10/14/2020 9:14 AM, David Marchand wrote: Only marking the doxygen declarations is not enough. Arch specific implementations must be tagged as well since there is no common declaration of those inlines. Fixes: 8a00dfc738fe ("eal: add write combining store") Signed-off-by: David Marchand -

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

On 10/13/2020 8:11 PM, Jerin Jacob wrote: On Wed, Oct 7, 2020 at 4:22 PM Ananyev, Konstantin wrote: On 10/6/2020 11:13 AM, Ananyev, Konstantin wrote: -Original Message- From: Jerin Jacob Sent: Monday, October 5, 2020 5:35 PM To: Nicolau, Radu Cc: Honnappa Nagarahalli ; Richardson

Re: [dpdk-dev] [PATCH v2 4/4] examples/mp_server: clear string truncation warning

On 8/21/2020 6:10 PM, Bruce Richardson wrote: Compiling with GCC 9.3 on Ubuntu 20.04 gives a warning about possible string truncation when getting the RX queue name: In file included from init.c:36: init.c: In function ‘init’: ../shared/common.h:38:28: warning: ‘%u’ directive output may be tru

Re: [dpdk-dev] [PATCH v2 3/4] examples/mp_server: fix snprintf overflow

On 8/21/2020 6:10 PM, Bruce Richardson wrote: When producing a printable mac address the buffer was appropriately sized for holding the mac address exactly, but the actual snprintf included a '\n' character at the end, which means that the snprintf technically is getting truncated i.e. the \n w

Re: [dpdk-dev] [PATCH v12 0/5] eal: add WC store functions

On 10/8/2020 8:28 AM, David Marchand wrote: On Wed, Sep 23, 2020 at 4:23 PM Radu Nicolau wrote: Implement 2 new functions that will enable write combining stores depending on architecture. The functions are provided as a generic stub and a x86 specific implementation. The reason to implement

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

On 10/6/2020 11:13 AM, Ananyev, Konstantin wrote: -Original Message- From: Jerin Jacob Sent: Monday, October 5, 2020 5:35 PM To: Nicolau, Radu Cc: Honnappa Nagarahalli ; Richardson, Bruce ; Ananyev, Konstantin ; Van Haaren, Harry ; dev@dpdk.org; jer...@marvell.com; nd Subject: Re

Re: [dpdk-dev] [PATCH v4 00/25] raw/ioat: enhancements and new hardware support

On 9/28/2020 5:42 PM, Bruce Richardson wrote: This patchset adds some small enhancements, some rework and also support for new hardware to the ioat rawdev driver. Most rework and enhancements are largely self-explanatory from the individual patches. The new hardware support is for the Intel(R)

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

On 9/28/2020 5:02 PM, Honnappa Nagarahalli wrote: Add minimum burst throughout the scheduler pipeline and a flush counter. Replace ring API calls with local single threaded implementation where possible. Signed-off-by: Radu Nicolau mailto:radu.nico...@intel.com Thanks for the patch, a few c

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

On 9/24/2020 12:10 AM, Honnappa Nagarahalli wrote: Add minimum burst throughout the scheduler pipeline and a flush counter. Replace ring API calls with local single threaded implementation where possible. Signed-off-by: Radu Nicolau Thanks for the pa

Re: [dpdk-dev] [PATCH v1 0/4] Remove RTE_MACHINE_CPUFLAG_ macros

On 9/2/2020 5:57 PM, David Christensen wrote: On 9/2/20 3:43 AM, Radu Nicolau wrote: Remove RTE_MACHINE_CPUFLAG_ macros from the build. Deprecation notice sent, pasted here for reference:    build macros: The macros defining RTE_MACHINE_CPUFLAG_* will be removed    from the build. The infor

Re: [dpdk-dev] [PATCH v9 1/4] eal: add WC store functions

On 7/20/2020 1:20 PM, David Marchand wrote: On Mon, Jul 20, 2020 at 11:12 AM Radu Nicolau wrote: Add rte_write32_wc and rte_write32_wc_relaxed functions that implement 32bit stores using write combining memory protocol. Provided generic stubs and x86 implementation. What is the difference of

Re: [dpdk-dev] [PATCH v8 2/4] net/i40e: use WC store to update queue tail registers

On 7/20/2020 7:46 AM, Ruifeng Wang wrote: -Original Message- From: Radu Nicolau Sent: Friday, July 17, 2020 6:50 PM To: dev@dpdk.org Cc: beilei.x...@intel.com; jia@intel.com; bruce.richard...@intel.com; konstantin.anan...@intel.com; jerinjac...@gmail.com; david.march...@redhat.com;

Re: [dpdk-dev] [PATCH v8 1/4] eal: add WC store functions

On 7/20/2020 7:42 AM, Ruifeng Wang wrote: -Original Message- From: Radu Nicolau Sent: Friday, July 17, 2020 6:50 PM To: dev@dpdk.org Cc: beilei.x...@intel.com; jia@intel.com; bruce.richard...@intel.com; konstantin.anan...@intel.com; jerinjac...@gmail.com; david.march...@redhat.com;

Re: [dpdk-dev] [PATCH v4 1/2] eal: add WC store functions

Hi David, thanks for reviewing! Some comments inline. On 7/3/2020 4:19 PM, David Marchand wrote: On Thu, Jul 2, 2020 at 11:24 AM Radu Nicolau wrote: +static inline void +rte_write32_wc(uint32_t value, volatile void *addr); This is a new API, and even if inlined, it should be marked experime

Re: [dpdk-dev] [PATCH v1 1/2] eal/x86: add WC store function

On 6/11/2020 1:23 PM, Jerin Jacob wrote: On Thu, Jun 11, 2020 at 3:41 PM Radu Nicolau wrote: Add rte_write32_wc function that implements a WC store using movdiri instruction. Signed-off-by: Radu Nicolau --- lib/librte_eal/x86/include/rte_io.h | 20 1 file changed, 20

Re: [dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: update pktest.sh script

On 10/1/2019 4:18 PM, Bernard Iremonger wrote: Drop SGW_CMD_XPRM=l, as default is IPsec library now. Signed-off-by: Bernard Iremonger --- Acked-by: Radu Nicolau >

Re: [dpdk-dev] [PATCH v2 2/3] examples/ipsec-secgw: add -l 0 parameter to old scripts

On 10/1/2019 4:17 PM, Bernard Iremonger wrote: enable legacy mode in *_old scripts Signed-off-by: Bernard Iremonger --- Acked-by: Radu Nicolau >

Re: [dpdk-dev] [PATCH v2 1/3] examples/ipsec-secgw: set default to IPsec library mode

On 10/1/2019 4:17 PM, Bernard Iremonger wrote: Set the default code path to librte_ipsec mode. Add parameter 0 | 1 to -l option and update error message. Check for conflicting options, -w -a -e and reassembly options are not supported in legacy mode. Show fragment table size. Update print_usage

Re: [dpdk-dev] [PATCH v5 1/4] examples/ipsec-secgw: ipsec_sa structure cleanup

On 9/27/2019 4:54 PM, Marcin Smoczynski wrote: Cleanup ipsec_sa structure by removing every field that is already in the rte_ipsec_session structure: * cryptodev/security session union * action type * offload flags * security context References to abovementioned fields are changed to di

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix SAD selection logic

On 9/24/2019 11:35 AM, Drost, MariuszX wrote: Ipsec-secgw example application fails to initialize when using default configuration file (ep0.cfg) in library mode (librte_ipsec enabled). The reason is that two of SP rules in ep0.cfg, one for IPv4 and one for IPv6, are using the same SPI number.

Re: [dpdk-dev] [PATCH] net/ixgbe: add security statistics

Hi, On 9/8/2019 12:45 PM, Ananyev, Konstantin wrote: Hi Radu, Update IXGBE PMD with support for IPsec statistics. The proposed approach - have a new hash table per device, plus parse each packet on RX and TX and do hash lookup seems way too heavy to put it into PMD. It is indeed heavy, but

Re: [dpdk-dev] [PATCH v2] security: add statistics definitions and update API

Hi, replies inline: On 9/3/2019 11:04 AM, Anoob Joseph wrote: Hi Radu, Please see inline. Thanks, Anoob -Original Message- From: dev On Behalf Of Radu Nicolau Sent: Tuesday, September 3, 2019 3:12 PM To: dev@dpdk.org Cc: akhil.go...@nxp.com; konstantin.anan...@intel.com; bernard.ire

Re: [dpdk-dev] [PATCH] security: add statistics definitions and update API

On 8/30/2019 3:33 PM, Stephen Hemminger wrote: On Fri, 30 Aug 2019 10:19:20 +0100 Radu Nicolau wrote: struct rte_security_ipsec_stats { + uint64_t ipackets; /**< Successfully received IPsec packets. */ + uint64_t opackets; /**< Successfully transmitted IPsec packets.*/ +

Re: [dpdk-dev] [PATCH] examples/bond: wait for slaves to become active

I'm ok with the updates, thanks! -Original Message- From: Yigit, Ferruh Sent: Thursday, November 29, 2018 8:57 AM To: Nicolau, Radu ; dev@dpdk.org Cc: Doherty, Declan ; ch...@att.com Subject: [dpdk-dev] [PATCH] examples/bond: wait for slaves to become active On 11/28/2018 1:48 PM,

Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

Hi, > -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Tuesday, February 27, 2018 11:32 AM > To: Nicolau, Radu ; Akhil Goyal > ; Doherty, Declan > Cc: Jerin Jacob ; Narayana Prasad > ; Nelio Laranjeiro > ; dev@dpdk.org &

Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Tuesday, February 27, 2018 6:57 AM > To: Nicolau, Radu ; Akhil Goyal > ; Doherty, Declan > Cc: Jerin Jacob ; Narayana Prasad > ; Nelio Laranjeiro > ; dev@dpdk.org > S

Re: [dpdk-dev] [PATCH 1/5] lib/ethdev: support for inline IPsec events

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Wednesday, February 21, 2018 5:37 AM > To: Akhil Goyal ; Doherty, Declan > ; Nicolau, Radu > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad > ; Nelio Laranjeiro &g

Re: [dpdk-dev] [PATCH] doc: fix ethdev API port_id parameter size

> -Original Message- > From: Yigit, Ferruh > Sent: Friday, February 9, 2018 9:54 AM > To: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; Yigit, Ferruh ; Thomas Monjalon > ; Boris Pismenny ; Aviad > Yehezkel ; Nicolau, Radu > ; Dohe

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add support for AES 256

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, February 8, 2018 6:13 AM > To: Akhil Goyal ; Doherty, Declan > ; Nicolau, Radu ; > Sergio Gonzalez Monroy > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad &g

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Monday, January 29, 2018 8:04 AM > To: Akhil Goyal ; Nicolau, Radu > > Cc: anoob.jos...@caviumnetworks.com; Doherty, Declan > ; Gonzalez Monroy, Sergio > ; Jerin J

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Friday, January 26, 2018 2:38 PM > To: Nicolau, Radu ; Akhil Goyal > > Cc: anoob.jos...@caviumnetworks.com; Doherty, Declan > ; Gonzalez Monroy, Sergio > ; Jerin J

Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, January 25, 2018 5:13 PM > To: Akhil Goyal ; Nicolau, Radu > > Cc: Doherty, Declan ; Gonzalez Monroy, Sergio > ; > anoob.jos...@caviumnetworks.com; Jerin J

Re: [dpdk-dev] [PATCH 1/2] crypto/qat: fix null auth algo issue

> -Original Message- > From: Trahe, Fiona > Sent: Thursday, January 25, 2018 5:19 PM > To: dev@dpdk.org > Cc: Nicolau, Radu ; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [PATCH 1/2] crypto/qat: fix null auth algo issue > > If auth algorithm

Re: [dpdk-dev] [PATCH] net/bonding: don't early mark eth device as bonded

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams > Sent: Wednesday, January 17, 2018 4:45 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; Charles (Chas) Williams > ; Chas Williams > Subject: [dpdk-dev] [PATCH] net/bonding: don't early mark eth device

Re: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Tuesday, January 23, 2018 12:32 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session > > Fixes: 3da37f682173 ("examples/ipse

Re: [dpdk-dev] [PATCH v2 3/3] examples/ipsec_secgw: create session mempools for ethdevs

> -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, January 18, 2018 3:11 PM > To: Nicolau, Radu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Yigit, Ferruh > ; Doherty, Declan ; > akhil.go...@nxp.com > Subject: RE: [PATCH v2 3/3] examples/ips

Re: [dpdk-dev] [PATCH] net/ixgbe: check if security capabilities are enabled by HW

> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, January 17, 2018 11:34 AM > To: Nicolau, Radu ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao, XinfengX > ; De Lara Guarch, Pablo > > Subject: RE: [PATCH] net/ixgbe: check if security capabilities are

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: improve ipsec dequeue logic

> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, December 14, 2017 7:19 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Gonzalez Monroy, Sergio > ; Nicolau, Radu > ; Akhil Goyal > Subject: [

Re: [dpdk-dev] [PATCH v5 3/3] examples/ipsec-secgw: add Egress flow actions

> -Original Message- > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Monday, December 18, 2017 10:25 AM > To: Gonzalez Monroy, Sergio ; Nicolau, > Radu ; Anoob Joseph > > Cc: dev@dpdk.org > Subject: [PATCH v5 3/3] examples/ipsec-secgw: add Egre

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: update mbuf packet type

> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, December 14, 2017 7:06 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Gonzalez Monroy, Sergio > ; Nicolau, Radu > ; Akhil Goyal > Subject: [

Re: [dpdk-dev] [PATCH v3 15/39] examples/ipsec-secgw: convert to new ethdev offloads API

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Tuesday, December 26, 2017 9:23 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 15/39] examples/ipsec-secgw: convert to > new ethdev offloads API > > Ethdev offloads API has changed si

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix corner case for spi value

> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, January 11, 2018 11:56 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Gonzalez Monroy, Sergio > ; Nicolau, Radu > ; Akhil Goyal > Subject: [

Re: [dpdk-dev] [PATCH v6 2/2] examples/ipsec-secgw: add support for inline protocol

> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Monday, December 18, 2017 7:15 AM > To: Akhil Goyal ; Doherty, Declan > ; Nicolau, Radu ; > Gonzalez Monroy, Sergio > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad &g

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: update incremental checksum

> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, January 16, 2018 6:30 AM > To: Nicolau, Radu ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com > Subject: Re: [PATCH] examples/ipsec-secgw: update incremental

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: update incremental checksum

> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, January 15, 2018 12:48 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Nicolau, Radu > Subject: Re: [PATCH] examples/ipsec-secgw: update incremental

Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, December 15, 2017 4:20 PM > To: Nicolau, Radu > Cc: dev@dpdk.org; Yigit, Ferruh ; > pascal.ma...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink

Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions

> -Original Message- > From: Richardson, Bruce > Sent: Friday, December 15, 2017 11:58 AM > To: Nicolau, Radu > Cc: dev@dpdk.org; Yigit, Ferruh ; > pascal.ma...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions > > On Fri, Dec 1

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage of incorrect port

Hi, Please send a v2 with the doc update that describes the new behavior and I will ack it. Regards, Radu > -Original Message- > From: Anoob Joseph [mailto:ajos...@caviumnetworks.com] > Sent: Monday, November 13, 2017 7:25 PM > To: Nicolau, Radu ; Anoob Joseph >

Re: [dpdk-dev] [PATCH v4 06/12] ethdev: support security APIs

> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 23, 2017 10:57 AM > To: Akhil Goyal ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; Nicolau, > Radu ; bor...@mellanox.com; > avia...@mellanox.

Re: [dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: config ethernet MACs dynamically

lanox.co.il [mailto:avia...@dev.mellanox.co.il] > Sent: Thursday, October 19, 2017 7:53 PM > To: dev@dpdk.org; Gonzalez Monroy, Sergio > ; De Lara Guarch, Pablo > ; avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.agra...@nxp.com; Nicolau, Ra

Re: [dpdk-dev] [PATCH v2] examples/ipsec_secgw: support jumbo frames

Hi, I did, sorry :) Working on them now. > -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, October 19, 2017 4:40 PM > To: Nicolau, Radu ; dev@dpdk.org > Cc: Gonzalez Monroy, Sergio > Subject: RE: [PATCH v2] examples/ipsec_secgw: support jumbo f

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 19, 2017 2:23 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 19, 2017 12:04 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.

  1   2   >