Hi
On 2/1/2023 2:16 PM, Akhil Goyal wrote:
Hi Radu,
Subject: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16
Set AES-CTR IV length as 16 instead of taking from
SA config option since the application populates
16B IV in the datapath. AES-CTR requires 16B IV
constructed from nonce and counter.
Signed-off-by: Tejasree Kondoj <ktejas...@marvell.com>
Do you have a comment on this?
No real objection, only that there is already an inconsistency in the
definitions of the aes-xxx-ctr entries, 128 bit IV is 8 bytes, 192 and
256 are 16 bytes. Maybe it would be better to change the 128 bit variant
definition? In any case:
Reviewed-by: Radu Nicolau <radu.nico...@intel.com>
