On Fri, Aug 21, 2020 at 10:14:50AM +0100, Louise Kilheeney wrote:
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Cc: Neil Horman
> Cc: Ray Kinsella
>
> Signed-off-by: Louise Kilheeney
>
On Fri, Aug 21, 2020 at 10:14:46AM +0100, Louise Kilheeney wrote:
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Cc: Neil Horman
>
> Signed-off-by: Louise Kilheeney
> Reviewed-by: Bruce Richardson
&g
On Fri, Jul 10, 2020 at 11:10:53AM +0100, Louise Kilheeney wrote:
> Cc: Neil Horman
>
> Signed-off-by: Louise Kilheeney
> ---
> usertools/dpdk-pmdinfo.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/usertools/dpdk-pmdinfo.py b/usertools
On Fri, Jul 10, 2020 at 11:10:50AM +0100, Louise Kilheeney wrote:
> Cc: Neil Horman
> Cc: Ray Kinsella
>
> Signed-off-by: Louise Kilheeney
> ---
> devtools/update_version_map_abi.py | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/devtools/update_versi
GE, this change requires a review
> (abidiff flagged this as a potential issue)."
> + fi
> + if [ $(($abiret & 8)) != 0 ]; then
> + echo "ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change
> breaks the ABI."
> + fi
> + echo
> + }
> done
>
> [ -z "$error" ] || [ -n "$warnonly" ]
> --
> 2.23.0
>
>
this looks pretty reasonable to me, sure.
Acked-by: Neil Horman
r pmdinfogen
> pmdinfogen: remove C implementation
>
I'm not currently setup to test with cross compiling, but for direct targets
(tested on power and x86), it seems to work well
Acked-by: Neil Horman
On Mon, Jul 06, 2020 at 04:24:29PM +0300, Dmitry Kozlyuk wrote:
> On Mon, 6 Jul 2020 08:52:57 -0400, Neil Horman wrote:
> > On Thu, Jul 02, 2020 at 03:02:32AM +0300, Dmitry Kozlyuk wrote:
> > > The package is available on all major distributions.
> > > FreeBSD has no sys
On Thu, Jul 02, 2020 at 03:02:32AM +0300, Dmitry Kozlyuk wrote:
> The package is available on all major distributions.
> FreeBSD has no system requirements section in its GSG,
> Windows currently neither uses pmdinfogen not is supported by it.
>
Why doesn't windows use pmdinfogen? That tool doesn
On Wed, Jun 17, 2020 at 04:10:46PM +0100, Louise Kilheeney wrote:
> Changed script to explicitly use python3 only to avoid
> maintaining python 2.
>
> Cc: Neil Horman
>
> Signed-off-by: Louise Kilheeney
> ---
> usertools/dpdk-pmdinfo.py | 4 +---
> 1 file changed,
On Mon, Jun 22, 2020 at 10:39:46PM +0300, Dmitry Kozlyuk wrote:
> On Mon, 22 Jun 2020 08:41:17 -0400, Neil Horman wrote:
> > On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote:
> [snip]
> > > 1. No standard ELF or COFF module for Python
> > > (amount
On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote:
> This is a PoC rewrite of pmdinfogen in Python with missing bits
> described below and in commits. Community input is desired.
>
> Pros:
>
> 1. Simpler build process without host apps.
> 2. Less build requirements (host libelf).
> 3
On Wed, Jun 17, 2020 at 04:10:46PM +0100, Louise Kilheeney wrote:
> Changed script to explicitly use python3 only to avoid
> maintaining python 2.
>
> Cc: Neil Horman
>
> Signed-off-by: Louise Kilheeney
Acked-by: Neil Horman
> ---
> usertools/dpdk-pmdinfo.py | 4 +
On Mon, Jun 15, 2020 at 10:41:20AM +0300, Dmitry Kozlyuk wrote:
> On Mon, 15 Jun 2020 07:03:23 +0100
> "Kinsella, Ray" wrote:
>
> [snip]
> > > +
> > > +INTERNAL {
> > > + global:
> > > +
> > > + rte_mem_lock;
> > > + rte_mem_map;
> > > + rte_mem_page_size;
> > > + rte_mem_unmap;
> > > +};
> >
On Fri, Jun 05, 2020 at 03:16:03AM +0300, Dmitry Kozlyuk wrote:
> On Thu, 4 Jun 2020 17:07:07 -0400
> Neil Horman wrote:
>
> > On Wed, Jun 03, 2020 at 03:34:03PM +0300, Dmitry Kozlyuk wrote:
> > > On Wed, 3 Jun 2020 08:07:59 -0400
> > > Neil Horman wrote:
>
On Wed, Jun 03, 2020 at 03:34:03PM +0300, Dmitry Kozlyuk wrote:
> On Wed, 3 Jun 2020 08:07:59 -0400
> Neil Horman wrote:
>
> [snip]
> > > +int
> > > +eal_file_create(const char *path)
> > > +{
> > > + int ret;
> > > +
> > &g
On Wed, Jun 03, 2020 at 02:03:20AM +0300, Dmitry Kozlyuk wrote:
> Introduce OS-independent wrappers in order to support common EAL code
> on Unix and Windows:
>
> * eal_file_create: open an existing file.
> * eal_file_open: create a file or open it if exists.
> * eal_file_lock: lock or unlock an o
w it, and redefine VERSION_SYMBOL[_EXPERIMENTAL]
to do nothing, and implement BIND_DEFAULT_SYMBOL to act like MAP_STATIC_SYMBOL
by aliasing the supplied symbol name to the provided export name. I think msvc
supports aliasing, correct?
Neil
>
> -Original Message-
> From: Neil Horman
On Mon, Jun 01, 2020 at 01:31:36PM +0300, Fady Bader wrote:
> Function versioning is not needed on Windows, also the function versioning
> implementation is not supported by Windows.
> Function versioning was disabled on Windows.
>
I get that windows doesn't seem to support symbol level versioning
On Wed, May 27, 2020 at 11:43:49PM +0200, Thomas Monjalon wrote:
> 27/05/2020 23:27, Thomas Monjalon:
> > 27/05/2020 22:35, Neil Horman:
> > > On Wed, May 27, 2020 at 02:50:07PM +0200, Thomas Monjalon wrote:
> > > > +Cc more people
> > > >
> >
On Wed, May 27, 2020 at 11:27:12PM +0200, Thomas Monjalon wrote:
> 27/05/2020 22:35, Neil Horman:
> > On Wed, May 27, 2020 at 02:50:07PM +0200, Thomas Monjalon wrote:
> > > +Cc more people
> > >
> > > 27/05/2020 12:41, Fady Bader:
> > > > What
On Wed, May 27, 2020 at 02:50:07PM +0200, Thomas Monjalon wrote:
> +Cc more people
>
> 27/05/2020 12:41, Fady Bader:
> > What should we do with the ABI versioning in Windows ?
>
> I think there are 2 questions here:
>
> 1/ Do we want to maintain ABI compatibility on Windows like we do for Linux
tag duplicated in some other block in .map file (versioned)
>
> Signed-off-by: Ferruh Yigit
> Signed-off-by: Ray Kinsella
> ---
>
> This patch depends on "doc: fix references to bind_default_symbol".
> https://patches.dpdk.org/patch/69850/
>
> Cc: Ne
On Wed, May 13, 2020 at 11:15:44AM +0200, Renata Saiakhova wrote:
> Free previously allocated memzone for HW rings
>
> Signed-off-by: Renata Saiakhova
> ---
> lib/librte_ethdev/rte_ethdev.c | 30 ++--
> lib/librte_ethdev/rte_ethdev_driver.h| 19 +++
>
On Mon, Apr 27, 2020 at 02:58:07PM +0100, Ray Kinsella wrote:
>
>
> On 27/04/2020 13:31, Thomas Monjalon wrote:
> > 27/04/2020 11:27, Ray Kinsella:
> >> On 25/04/2020 17:04, Thomas Monjalon wrote:
> >>> PS: Who is REALLY maintaining the ABI?
> >>> We really miss someone who carefully check all th
On Wed, Apr 22, 2020 at 02:18:05PM +0200, Thomas Monjalon wrote:
> 22/04/2020 14:07, Neil Horman:
> > On Wed, Apr 22, 2020 at 12:43:44PM +0100, Ray Kinsella wrote:
> > > On 21/04/2020 22:42, Thomas Monjalon wrote:
> > > > 21/04/2020 20:56, Neil Horman:
> > >
On Wed, Apr 22, 2020 at 02:16:57PM +0200, Thomas Monjalon wrote:
> 22/04/2020 14:01, Neil Horman:
> > On Tue, Apr 21, 2020 at 11:42:42PM +0200, Thomas Monjalon wrote:
> > > 21/04/2020 20:56, Neil Horman:
> > > > On Tue, Apr 21, 2020 at 01:46:43PM +0200, Thomas Monjal
On Wed, Apr 22, 2020 at 12:43:44PM +0100, Ray Kinsella wrote:
>
>
> On 21/04/2020 22:42, Thomas Monjalon wrote:
> > 21/04/2020 20:56, Neil Horman:
> >> On Tue, Apr 21, 2020 at 01:46:43PM +0200, Thomas Monjalon wrote:
> >>> 21/04/2020 13:12, Neil Horman:
>
On Tue, Apr 21, 2020 at 11:42:42PM +0200, Thomas Monjalon wrote:
> 21/04/2020 20:56, Neil Horman:
> > On Tue, Apr 21, 2020 at 01:46:43PM +0200, Thomas Monjalon wrote:
> > > 21/04/2020 13:12, Neil Horman:
> > > > On Fri, Apr 17, 2020 at 04:42:38PM +0100, Ray Kinsella
On Tue, Apr 21, 2020 at 01:46:43PM +0200, Thomas Monjalon wrote:
> 21/04/2020 13:12, Neil Horman:
> > On Fri, Apr 17, 2020 at 04:42:38PM +0100, Ray Kinsella wrote:
> > > On 17/04/2020 13:10, Thomas Monjalon wrote:
> > > > 17/04/2020 13:47, Ray Kinsella:
> &
On Fri, Apr 17, 2020 at 04:42:38PM +0100, Ray Kinsella wrote:
>
>
> On 17/04/2020 13:10, Thomas Monjalon wrote:
> > 17/04/2020 13:47, Ray Kinsella:
> >> On 17/04/2020 11:20, Thomas Monjalon wrote:
> >>> 17/04/2020 12:11, Ray Kinsella:
> check-abi.sh appears to be backward step in terms of us
On Fri, Apr 17, 2020 at 04:38:42AM +, Michael Lilja wrote:
> > -Original Message-
> > From: Neil Horman
> > Sent: 17. april 2020 04:55
> > To: Thomas Monjalon
> > Cc: Finn Christensen ; dev@dpdk.org; Bent Kuhre
> > ; Michael Lilja ; techbo...
On Tue, Mar 31, 2020 at 10:07:12PM +0200, Thomas Monjalon wrote:
> 31/03/2020 21:56, Neil Horman:
> > On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon wrote:
> > > 31/03/2020 14:17, Neil Horman:
> > > > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thoma
On Fri, Apr 17, 2020 at 02:04:30AM +, Wang, Haiyue wrote:
> Hi Neil,
>
> > -Original Message-
> > From: dev On Behalf Of Neil Horman
> > Sent: Thursday, June 13, 2019 22:24
> > To: dev@dpdk.org
> > Cc: Neil Horman ; Jerin Jacob Kollanukkaran
Since we've moved away from our initial validate-abi.sh script, in
favor of check-abi.sh, which uses libabigail, remove the old script from
the tree, and update the docs accordingly
Signed-off-by: Neil Horman
CC: tho...@monjalon.net
CC: david.march...@redhat.com
CC: m...@ashr
On Thu, Apr 09, 2020 at 12:59:50PM +0200, Thomas Monjalon wrote:
> 09/04/2020 12:45, Ray Kinsella:
> > On 09/04/2020 11:43, Bruce Richardson wrote:
> > > On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote:
> > >> On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray
On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote:
>
>
> On 08/04/2020 20:56, Neil Horman wrote:
> > Since we've moved away from our initial validate-abi.sh script, in
> > favor of check-abi.sh, which uses libabigail, remove the old script from
> &g
Since we've moved away from our initial validate-abi.sh script, in
favor of check-abi.sh, which uses libabigail, remove the old script from
the tree, and update the docs accordingly
Signed-off-by: Neil Horman
CC: tho...@monjalon.net
CC: david.march...@redhat.com
CC: m...@ashr
On Tue, Apr 07, 2020 at 01:58:57PM +0200, Thomas Monjalon wrote:
> 07/04/2020 13:33, Neil Horman:
> > On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote:
> > > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote:
> > > >
> > > > Since we'v
On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote:
> On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote:
> >
> > Since we've moved away from our initial abi_versioning.sh script, in
>
> abi_versioning.sh does not exist (idem with the patch title).
> I supp
On Tue, Apr 07, 2020 at 08:32:15AM +0100, Ray Kinsella wrote:
>
>
> On 06/04/2020 15:36, Neil Horman wrote:
> > On Mon, Apr 06, 2020 at 04:02:22PM +0200, Thomas Monjalon wrote:
> >> 01/04/2020 14:52, Neil Horman:
> >>> On Tue, Mar 31, 2020 at 09:24:41PM +0200,
Since we've moved away from our initial abi_versioning.sh script, in
favor of check_abi.sh, which uses libabigail, remove the old script from
the tree, and update the docs accordingly
Signed-off-by: Neil Horman
CC: tho...@monjalon.net
---
MAINTAINERS
On Mon, Apr 06, 2020 at 04:02:22PM +0200, Thomas Monjalon wrote:
> 01/04/2020 14:52, Neil Horman:
> > On Tue, Mar 31, 2020 at 09:24:41PM +0200, Thomas Monjalon wrote:
> > > 31/03/2020 21:22, Thomas Monjalon:
> > > > 31/03/2020 19:05, Ananyev, Kon
ternal dpbp_open(struct fsl_mc_io *mc_io,
> > uint32_t cmd_flags,
> > int dpbp_id,
> > uint16_t *token)
>
> => approach used in rte_experimental
> >__rte_experimental
> >uint16_t
> >rte_bbdev_count(void);
>
> This will help in minimiz
On Tue, Mar 31, 2020 at 09:24:41PM +0200, Thomas Monjalon wrote:
> 31/03/2020 21:22, Thomas Monjalon:
> > 31/03/2020 19:05, Ananyev, Konstantin:
> > > Hi everyone,
> > >
> > > Have a question regarding validate-abi.sh.
> >
> > devtools/validate-abi.sh should be removed.
> > Please use the new dev
On Tue, Mar 31, 2020 at 10:07:12PM +0200, Thomas Monjalon wrote:
> 31/03/2020 21:56, Neil Horman:
> > On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon wrote:
> > > 31/03/2020 14:17, Neil Horman:
> > > > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thoma
On Tue, Mar 31, 2020 at 09:59:27PM +0200, Thomas Monjalon wrote:
> 31/03/2020 21:51, Neil Horman:
> > On Tue, Mar 31, 2020 at 07:58:45AM -0700, Stephen Hemminger wrote:
> > > On Tue, 31 Mar 2020 12:39:17 +
> > > Michael Lilja wrote:
> > >
> >
On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon wrote:
> 31/03/2020 14:17, Neil Horman:
> > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thomas Monjalon wrote:
> > > Hi,
> > >
> > > Raising this topic again.
> > >
> > > As said
On Tue, Mar 31, 2020 at 07:58:45AM -0700, Stephen Hemminger wrote:
> On Tue, 31 Mar 2020 12:39:17 +
> Michael Lilja wrote:
>
> > Hi,
> >
> > I appreciate the discussion. It would of course be nice if vendors could be
> > allowed to use external libraries/drivers and have a DPDK shim but I a
On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thomas Monjalon wrote:
> Hi,
>
> Raising this topic again.
>
> As said in the past, it is better to have this PMD inside DPDK.
> We discussed some concerns, but I think the consensus was to integrate
> Napatech PMD anyway.
>
> I am sad that you did not f
On Fri, Mar 27, 2020 at 01:24:12PM +0100, David Marchand wrote:
> On Wed, Mar 25, 2020 at 12:11 PM Kevin Laatz wrote:
> >
> > This patch adds CPU flags which will enable the detection of ISA
> > features available on more recent x86 based CPUs.
> >
> > The CPUID leaf information can be found in Se
On Thu, Mar 19, 2020 at 09:15:50PM +0530, Nithin Dabilpuram wrote:
> On Thu, Mar 19, 2020 at 11:40:39AM -0400, Neil Horman wrote:
> > External Email
> >
> > --
> > On Thu, Mar 19, 2020 at 03:56:03PM
On Thu, Mar 19, 2020 at 03:56:03PM +0100, David Marchand wrote:
> On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram
> wrote:
> >
> > Fix check symbol change script to detect new diff file when
> > it is in between "--- /dev/null" to "b/lib/...".
> > Current awk line expects line to start with "a/
On Wed, Feb 05, 2020 at 03:17:52PM +, Ray Kinsella wrote:
> When a maintainer is promoting an API to become part of the next major ABI
> version by removing the experimental tag, possibly a few releases in advance
> of
> the declaration of the next ABI version. The maintainer may choose to off
On Wed, Feb 19, 2020 at 01:43:01PM +0100, Thomas Monjalon wrote:
> 19/02/2020 12:43, Neil Horman:
> > On Tue, Feb 18, 2020 at 10:50:09AM +0100, Thomas Monjalon wrote:
> > > 18/02/2020 10:42, Bruce Richardson:
> > > > On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thoma
On Tue, Feb 18, 2020 at 10:50:09AM +0100, Thomas Monjalon wrote:
> 18/02/2020 10:42, Bruce Richardson:
> > On Tue, Feb 18, 2020 at 12:15:56AM +0100, Thomas Monjalon wrote:
> > > Hi,
> > >
> > > I would like to remind everybody our mistake when defining ABI versions.
> > > It has been "fixed" in th
x27;t work, thats a bug in DPDK.
Neil
> Regards,
>
> El mar., 18 feb. 2020 a las 14:13, Neil Horman ()
> escribió:
>
> > On Mon, Feb 17, 2020 at 02:39:58PM +, Bruce Richardson wrote:
> > > On Mon, Feb 17, 2020 at 11:01:21AM +0100, Victor Huertas wrote:
> &
On Mon, Feb 17, 2020 at 02:39:58PM +, Bruce Richardson wrote:
> On Mon, Feb 17, 2020 at 11:01:21AM +0100, Victor Huertas wrote:
> > Hi all,
> >
> > I am using DPDK development environment to develop an application from
> > which I have to access C++ code.
> > I managed to modify some internal
On Mon, Feb 17, 2020 at 02:23:15PM +, Ray Kinsella wrote:
>
>
> On 14/02/2020 20:48, Neil Horman wrote:
> > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote:
> >> On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote:
> >>> On Thu, F
On Mon, Feb 17, 2020 at 11:01:21AM +0100, Victor Huertas wrote:
> Hi all,
>
> I am using DPDK development environment to develop an application from
> which I have to access C++ code.
> I managed to modify some internal mk files in the dpdk-stable repository to
> allow g++ compiler to be supported
will be completely removed in 20.11.
> + In 20.08, explicit deprecation warnings will be displayed when running
> + scripts with Python 2.
> --
> 2.24.1
>
>
Acked-by: Neil Horman
On Fri, Feb 14, 2020 at 09:52:53PM +, Bruce Richardson wrote:
> On Fri, Feb 14, 2020 at 03:48:48PM -0500, Neil Horman wrote:
> > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote:
> > > On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote:
> > >
On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote:
> On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote:
> > On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote:
> > >
> > >
> > > On 05/02/2020 11:32, Neil Horman wrote:
> &
On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote:
>
>
> On 05/02/2020 11:32, Neil Horman wrote:
> > On Wed, Feb 05, 2020 at 11:04:29AM +0100, Luca Boccassi wrote:
> >> On Tue, 2020-02-04 at 07:02 -0500, Neil Horman wrote:
> >>>> But if we can d
a/lib/librte_eal/common/eal_common_mcfg.c
> +++ b/lib/librte_eal/common/eal_common_mcfg.c
> @@ -2,7 +2,6 @@
> * Copyright(c) 2019 Intel Corporation
> */
>
> -#include
> #include
> #include
>
> diff --git a/lib/librte_eal/common/eal_memcfg.h
> b/lib/librte_eal/common/eal_memcfg.h
> index 4d650025c2..583fcb5953 100644
> --- a/lib/librte_eal/common/eal_memcfg.h
> +++ b/lib/librte_eal/common/eal_memcfg.h
> @@ -5,7 +5,6 @@
> #ifndef EAL_MEMCFG_H
> #define EAL_MEMCFG_H
>
> -#include
> #include
> #include
> #include
> --
> 2.25.0
>
>
Acked-by: Neil Horman
On Wed, Feb 05, 2020 at 11:04:29AM +0100, Luca Boccassi wrote:
> On Tue, 2020-02-04 at 07:02 -0500, Neil Horman wrote:
> > > But if we can do the versioning in the master, LTS can backport it
> > > and can have
> > > mature version of that API in LTS without bre
On Tue, Feb 04, 2020 at 10:32:01AM +, Akhil Goyal wrote:
>
> >
> > 04/02/2020 11:16, Akhil Goyal:
> > > Hi,
> > > > On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > > > > 03/02/2020 10:30, Ferruh Yigit:
> > > > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > > > >>> 02/02/2020 14:05, Th
On Tue, Feb 04, 2020 at 10:16:56AM +, Akhil Goyal wrote:
> Hi,
> > On 2/3/2020 5:09 PM, Thomas Monjalon wrote:
> > > 03/02/2020 10:30, Ferruh Yigit:
> > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> > >>> 02/02/2020 14:05, Thomas Monjalon:
> > 31/01/2020 15:16, Trahe, Fiona:
> > >>>
On Tue, Feb 04, 2020 at 09:44:53AM -0500, Aaron Conole wrote:
> Thomas Monjalon writes:
>
> > RED FLAG
> >
> > I don't see a lot of reactions, so I summarize the issue.
> > We need action TODAY!
> >
> > API makes think that rte_cryptodev_info_get() cannot return
> > a value >= 3 (RTE_CRYPTO_AEAD_
On Mon, Feb 03, 2020 at 12:53:28PM +, Ferruh Yigit wrote:
> On 2/2/2020 6:53 PM, Neil Horman wrote:
> > On Wed, Jan 29, 2020 at 12:29:53PM +, Ferruh Yigit wrote:
> >> Duplicated the existing symbol and versioned one as experimental and
> >> other a
On Mon, Feb 03, 2020 at 09:30:06AM +, Ferruh Yigit wrote:
> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote:
> >
> >> 31/01/2020 15:16, Trahe, Fiona:
> >>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote:
> 30/01/2020 17:09, Ferruh Yigit:
> > On 1/29/2020 8:13 PM, Akhil Goyal wrote:
>
intaining a modicum of
stability in experimental symobls.
A few more nits in line
> Signed-off-by: Ferruh Yigit
> ---
> Cc: Neil Horman
> Cc: Thomas Monjalon
> Cc: Luca Boccassi
> Cc: David Marchand
> Cc: Bruce Richardson
> Cc: Ian Stokes
> Cc: Eelco Chaudron
>
On Thu, Jan 16, 2020 at 09:01:52PM +0100, Thomas Monjalon wrote:
> 16/01/2020 19:49, Neil Horman:
> > On Thu, Jan 16, 2020 at 03:20:48PM +0100, Thomas Monjalon wrote:
> > > 16/01/2020 12:52, Neil Horman:
> > > > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjal
On Thu, Jan 16, 2020 at 03:20:48PM +0100, Thomas Monjalon wrote:
> 16/01/2020 12:52, Neil Horman:
> > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote:
> > > 15/01/2020 12:33, Neil Horman:
> > > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjal
On Thu, Jan 16, 2020 at 12:25:06PM +0100, David Marchand wrote:
> On Tue, Dec 17, 2019 at 2:08 PM Eelco Chaudron wrote:
> >
> > Moved RFC4115 APIs to none experimental as they have been there
> > since 19.02. Also, these APIs are the same as the none RFC4115 APIs.
> >
> > Signed-off-by: Eelco Chau
On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote:
> 15/01/2020 12:33, Neil Horman:
> > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote:
> > > 20/12/2019 17:20, Kinsella, Ray:
> > > > From: Richardson, Bruce
> > > > > Fr
On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote:
> 20/12/2019 17:20, Kinsella, Ray:
> > From: Richardson, Bruce
> > > From: David Marchand
> > > > +Checking ABI compatibility
> > > > +--
> > > > +
> > > > +The first thing is to build reference binaries for
On Fri, Jun 07, 2019 at 06:21:21PM +, Wiles, Keith wrote:
>
>
> > On Jun 7, 2019, at 10:42 AM, Ray Kinsella wrote:
> >
> >
> >
> > On 06/06/2019 16:03, Neil Horman wrote:
> >> On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin Jacob Koll
On Thu, Jan 09, 2020 at 10:55:04AM +0100, David Marchand wrote:
> Hello Neil,
>
> On Tue, Aug 6, 2019 at 2:22 PM Neil Horman wrote:
> >
> > On Tue, Aug 06, 2019 at 12:03:38PM +0200, Thomas Monjalon wrote:
> > > I think it would be good to rebase and send
On Fri, Dec 20, 2019 at 04:20:58PM +0100, David Marchand wrote:
> Starting from Kevin and Bruce idea of using libabigail, here is an
> alternate approach to implement ABI checks.
>
> By default, those checks are disabled and enabling them requires a
> manual step that generates the ABI dumps on a
MAP)
> @@ -74,7 +76,7 @@ NO_UNDEFINED := -z defs
> endif
>
> O_TO_S = $(LD) -L$(RTE_SDK_BIN)/lib $(_CPU_LDFLAGS) $(EXTRA_LDFLAGS) \
> - -shared $(OBJS-y) $(NO_UNDEFINED) $(LDLIBS) -Wl,-soname,$(LIB) -o
> $(LIB)
> + -shared $(OBJS-y) $(NO_UNDEFINED) $(LDLIBS) -Wl,-soname,$(SONAME) -o
> $(LIB)
> O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
> O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)")
> O_TO_S_DO = @set -e; \
> @@ -133,6 +135,7 @@ $(RTE_OUTPUT)/lib/$(LIB): $(LIB)
> $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib
> ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> $(Q)ln -s -f $< $(shell echo $@ | sed 's/\.so.*/.so/')
> + $(Q)ln -s -f $< $(shell echo $@ | sed 's/\.so.*/.so.$(SOVER)/')
> endif
>
> #
> --
> 2.23.0
>
>
Acked-by: Neil Horman
On Wed, Dec 11, 2019 at 01:30:07PM +, Ferruh Yigit wrote:
> On 12/11/2019 1:11 PM, Neil Horman wrote:
> > On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote:
> >> Hi,
> >>
> >> With new process, the major ABI releases will be compatible until it is
On Tue, Dec 10, 2019 at 02:36:43PM +, Bruce Richardson wrote:
> On Tue, Dec 10, 2019 at 12:40:53PM +, Ferruh Yigit wrote:
> > On 12/10/2019 12:04 PM, Bruce Richardson wrote:
> > > On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote:
> > >> Hi,
> > >>
> > >> With new process, the ma
On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote:
> Hi,
>
> With new process, the major ABI releases will be compatible until it is
> deprecated (until next LTS for now),
> like current ABI version is 20 in DPDK_19.11 and DPDK versions until
> DPDK_20.11
> will be ABI compatible with
On Wed, Dec 04, 2019 at 09:47:31AM +0100, David Marchand wrote:
> On Tue, Dec 3, 2019 at 4:27 PM Laatz, Kevin wrote:
> > > Build targets in project: 1019
> > > WARNING: Project specifies a minimum meson_version '>= 0.47.1' but
> > > uses features which were added in newer versions:
> > > * 0.48.
lib/librte_port/rte_port_eventdev.h
> +++ b/lib/librte_port/rte_port_eventdev.h
> @@ -25,6 +25,8 @@ extern "C" {
> **/
>
> #include
> +
> +#include
> #include
>
> #include "rte_port.h"
> @@ -39,6 +41,7 @@ struct rte_port_eventdev_reader_params {
> };
>
> /** Eventdev_reader port operations. */
> +__rte_experimental_var
> extern struct rte_port_in_ops rte_port_eventdev_reader_ops;
>
> /** Eventdev_writer port parameters. */
> @@ -63,6 +66,7 @@ struct rte_port_eventdev_writer_params {
> };
>
> /** Eventdev_writer port operations. */
> +__rte_experimental_var
> extern struct rte_port_out_ops rte_port_eventdev_writer_ops;
>
> /** Event_writer_nodrop port parameters. */
> @@ -90,6 +94,7 @@ struct rte_port_eventdev_writer_nodrop_params {
> };
>
> /** Eventdev_writer_nodrop port operations. */
> +__rte_experimental_var
> extern struct rte_port_out_ops rte_port_eventdev_writer_nodrop_ops;
>
> #ifdef __cplusplus
> diff --git a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.h
> index 0b5585925..55c100673 100644
> --- a/lib/librte_rcu/rte_rcu_qsbr.h
> +++ b/lib/librte_rcu/rte_rcu_qsbr.h
> @@ -35,6 +35,7 @@ extern "C" {
> #include
> #include
>
> +__rte_experimental_var
> extern int rte_rcu_log_type;
>
> #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> --
> 2.23.0
>
>
Acked-by: Neil Horman
On Wed, Nov 27, 2019 at 09:45:46PM +0100, David Marchand wrote:
> On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote:
> > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote:
> > > So far, we did not pay attention to direct access to variables but they
> > >
On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote:
> So far, we did not pay attention to direct access to variables but they
> are part of the API/ABI too and should be clearly identified.
>
> Introduce a __rte_experimental_var tag and mark existing variables.
>
> Fixes: a4bcd61de82d
On Tue, Nov 26, 2019 at 09:25:49AM +, Ray Kinsella wrote:
>
> My 2c is that it feels a little unweildy to have to annotate, every variable
> declaration.
> and also extern reference with __rte_experimental_var.
>
> Is there any easier way?
>
Note, just to be clear, its not every variable, o
gt; +for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3`
> do
> if grep -q "\.text.*$SYM$" $DUMPFILE &&
> ! grep -q "\.text\.experimental.*$SYM$" $DUMPFILE
> --
> 2.23.0
>
>
Series
Acked-by: Neil Horman
gt; enum rte_timer_type type, unsigned int tim_lcore,
> rte_timer_cb_t fct, void *arg)
> @@ -574,7 +574,7 @@ rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,
> }
> VERSION_SYMBOL(rte_timer_reset, _v20, 2.0);
>
> -int
> +int __vsym
> rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,
> enum rte_timer_type type, unsigned int tim_lcore,
> rte_timer_cb_t fct, void *arg)
> @@ -657,14 +657,14 @@ __rte_timer_stop(struct rte_timer *tim, int
> local_is_locked,
> }
>
> /* Stop the timer associated with the timer handle tim */
> -int
> +int __vsym
> rte_timer_stop_v20(struct rte_timer *tim)
> {
> return __rte_timer_stop(tim, 0, &default_timer_data);
> }
> VERSION_SYMBOL(rte_timer_stop, _v20, 2.0);
>
> -int
> +int __vsym
> rte_timer_stop_v1905(struct rte_timer *tim)
> {
> return rte_timer_alt_stop(default_data_id, tim);
> @@ -817,14 +817,14 @@ __rte_timer_manage(struct rte_timer_data *timer_data)
> priv_timer[lcore_id].running_tim = NULL;
> }
>
> -void
> +void __vsym
> rte_timer_manage_v20(void)
> {
> __rte_timer_manage(&default_timer_data);
> }
> VERSION_SYMBOL(rte_timer_manage, _v20, 2.0);
>
> -int
> +int __vsym
> rte_timer_manage_v1905(void)
> {
> struct rte_timer_data *timer_data;
> @@ -1074,14 +1074,14 @@ __rte_timer_dump_stats(struct rte_timer_data
> *timer_data __rte_unused, FILE *f)
> #endif
> }
>
> -void
> +void __vsym
> rte_timer_dump_stats_v20(FILE *f)
> {
> __rte_timer_dump_stats(&default_timer_data, f);
> }
> VERSION_SYMBOL(rte_timer_dump_stats, _v20, 2.0);
>
> -int
> +int __vsym
> rte_timer_dump_stats_v1905(FILE *f)
> {
> return rte_timer_alt_dump_stats(default_data_id, f);
> --
> 2.17.1
>
>
Acked-by: Neil Horman
te_ethdev_version.map
> index e59d51648f..4b31668a55 100644
> --- a/lib/librte_ethdev/rte_ethdev_version.map
> +++ b/lib/librte_ethdev/rte_ethdev_version.map
> @@ -12,7 +12,6 @@ DPDK_2.2 {
> rte_eth_dev_callback_unregister;
> rte_eth_dev_close;
> rte_eth_dev_configure;
> - rte_eth_dev_count;
> rte_eth_dev_default_mac_addr_set;
> rte_eth_dev_filter_supported;
> rte_eth_dev_flow_ctrl_get;
> --
> 2.23.0
>
>
Acked-by: Neil Horman
On Wed, Sep 25, 2019 at 02:01:01PM +0100, Ray Kinsella wrote:
> Hi Neil,
>
> Thanks for the feedback, other comment below.
>
> On 25/09/2019 13:24, Neil Horman wrote:
> > On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote:
> >> Separate versioning.rst into
On Wed, Sep 25, 2019 at 11:23:53AM +0100, Ray Kinsella wrote:
> Separate versioning.rst into abi versioning and abi policy guidance, in
> preparation for adding more detail to the abi policy.
>
> Signed-off-by: Ray Kinsella
> ---
> doc/guides/contributing/abi_policy.rst | 169 +
> do
On Tue, Sep 24, 2019 at 12:25:35PM +0200, Bruce Richardson wrote:
> On Tue, Sep 24, 2019 at 08:46:25AM +0200, Andrzej Ostruszka wrote:
> > On 9/23/19 6:13 PM, Bruce Richardson wrote:
> > [...]
> > > However, testing on my system with the meson build, I'm getting lots of
> > > link errors [See below
Postprocess pmd object files to export hw support
> +/* SPDX-License-Identifier: GPL-2.0
> + * Postprocess pmd object files to export hw support
> *
> * Copyright 2016 Neil Horman
> * Based in part on modpost.c from the linux kernel
> - *
> - * This software may be used and d
On Tue, Aug 13, 2019 at 08:32:44AM +0200, David Marchand wrote:
> On Mon, Aug 12, 2019 at 10:14 PM Neil Horman wrote:
> >
> > On Mon, Aug 12, 2019 at 09:02:28AM +0200, David Marchand wrote:
> > > Dumping every object file for every symbol is too heavy.
>
On Mon, Aug 12, 2019 at 09:02:28AM +0200, David Marchand wrote:
> Dumping every object file for every symbol is too heavy.
> Use a temporary storage.
>
> Before:
> $ rm -rf master && make defconfig O=master
> $ time make EXTRA_CFLAGS=-g O=master
> [...]
> real 2m24.063s
> user 1m16.985s
> sys
On Tue, Aug 06, 2019 at 12:03:38PM +0200, Thomas Monjalon wrote:
> I think it would be good to rebase and send at the beginning of the 19.11
> cycle.
> Thank you
>
I'm on PTO for the next 10 days or so, but yes, I'll take care of that asap.
Thanks
Neil
> 13/0
On Wed, Jul 31, 2019 at 11:57:05AM +0530, pbhagavat...@marvell.com wrote:
> From: Pavan Nikhilesh
>
> Pmdinfogen is always compiled with host gcc.
> If host gcc version is lessthan 7 and target gcc is greaterthan 7
> pmdinfogen fails to compile due to unsupported cflags.
> This patch removes unsu
On Tue, Jul 30, 2019 at 10:17:46AM +0200, Thomas Monjalon wrote:
> 05/07/2019 11:39, Thomas Monjalon:
> > 05/07/2019 11:38, Thomas Monjalon:
> > > 05/07/2019 11:35, Bruce Richardson:
> > > > On Fri, Jul 05, 2019 at 10:33:59AM +0100, Bruce Richardson wrote:
> > > > > The names of the rawdev drivers
1 - 100 of 1694 matches
Mail list logo
