Re: [PATCH] rcu: fix build failure with debug dp log level

2022-08-30 Thread Morrissey, Sean
On 29/08/2022 17:55, Honnappa Nagarahalli wrote: -Original Message- From: Anoob Joseph Sent: Monday, August 29, 2022 11:52 AM To: Honnappa Nagarahalli Cc: jer...@marvell.com; dev@dpdk.org; sean.morris...@intel.com Subject: [PATCH] rcu: fix build failure with debug dp log level Build

Re: [PATCH] app/testpmd: fix memory leak for dscp table

2022-06-29 Thread Morrissey, Sean
Reviewed-by: Sean Morrissey Thanks. On 28/06/2022 14:29, Jasvinder Singh wrote: This patch fixes memory leak reported by coverity. Coverity issue: 379220 Fixes: 9f5488e326d3 ("app/testpmd: support different input color method") Cc: sta...@dpdk.org Signed-off-by: Jasvinder Singh --- app/t

Re: [PATCH v1 18/19] timer: remove unneeded header includes

2022-04-22 Thread Morrissey, Sean
On 21/04/2022 21:08, Stephen Hemminger wrote: On Thu, 21 Apr 2022 19:08:58 + Sean Morrissey wrote: diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index c51a393e5c..f52ccc33ed 100644 --- a/lib/timer/rte_timer.c +++ b/lib/timer/rte_timer.c @@ -5,12 +5,9 @@ #include #includ

Re: [PATCH v4] examples/l3fwd: merge l3fwd-acl into l3fwd

2022-04-08 Thread Morrissey, Sean
Hi Konstantin, Comment on some of your feedback below. I will make the rest of the changes and send a new version. On 08/04/2022 18:26, Ananyev, Konstantin wrote: Hi Sean, Few nits, that I didn't spot previously, pls see below. + +/* Setup ACL context. 8< */ Looks like some typo within

Re: [PATCH v3] dmadev: add telemetry support

2022-04-01 Thread Morrissey, Sean
On 01/04/2022 12:00, Walsh, Conor wrote: From: Bruce Richardson Sent: Friday 1 April 2022 11:50 To: Morrissey, Sean Cc: Chengwen Feng ; Laatz, Kevin ; dev@dpdk.org; Pai G, Sunil Subject: Re: [PATCH v3] dmadev: add telemetry support On Fri, Apr 01, 2022 at 10:24:02AM +, Sean Morrissey

Re: [dpdk-dev] [PATCH v3 4/5] lib/kvargs: remove unneeded header includes

2021-10-15 Thread Morrissey, Sean
On 15/10/2021 10:00, Olivier Matz wrote: Hi Sean, On Thu, Oct 07, 2021 at 10:25:56AM +, Sean Morrissey wrote: These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kvargs/rte_kvargs.c | 1 - 1 file changed, 1 deletion(-) diff --g

Re: [dpdk-dev] [PATCH v1 1/5] devtools: script to remove unused headers includes

2021-10-06 Thread Morrissey, Sean
On 06/10/2021 14:37, Thomas Monjalon wrote: 04/10/2021 12:10, Sean Morrissey: This script can be used for removing headers flagged for removal by the include-what-you-use (IWYU) tool. The script has the ability to remove headers from specified sub-directories or dpdk as a whole. My fear is th

Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-25 Thread Morrissey, Sean
Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" 24/07/2019 18:28, Morrissey, Sean: > > Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" > > 24/07/2019 17:20, Sean Morrissey: > > This reverts commit de

Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Morrissey, Sean
Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" 24/07/2019 17:20, Sean Morrissey: > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > Reverting this patch as it currently breaks the initialization of > telemetry, more investigation is ongoing to fix the iss

Re: [dpdk-dev] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg

2019-07-15 Thread Morrissey, Sean
+Harry Van Haaren -- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confi