Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry"
24/07/2019 18:28, Morrissey, Sean: > > Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" > > 24/07/2019 17:20, Sean Morrissey: > > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > > > Reverting this patch as it currently breaks the initialization of > > telemetry, more investigation is ongoing to fix the issue for the > > printed error message for unrecognized argument. > > > > Signed-off-by: Sean Morrissey <sean.morris...@intel.com> > > It's very disapointing. > Did you or the reviewer tested the previous patch? > > The reporter of the bug tested this and verified functionality and closed the > internal bug. So the reverted commit is supposed to work? I won't apply this revert until I fully understand what happens. The patch that I sent up was to remove an "unrecognized option telemetry" warning message, which the patch removed and was tested to ensure the message was removed. Further testing, after the patch was sent up, revealed that the unix domain socket, which is required by telemetry consumers, was no longer being created, rendering the telemetry functionality non-functional. On further investigation, the full fix involves a change in the EAL command line parameter handling, which is probably too risky for RC3. This revert will allow telemetry to function again, but with the erroneous message still in place. We will aim to fix in the next release. -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
