Re: [PATCH 1/2] net/hns3: optimized Tx performance by mbuf fast free

2021-11-15 Thread Min Hu (Connor)
Hi, Ferruh, fixed in v2, thanks. 在 2021/11/16 1:30, Ferruh Yigit 写道: On 11/11/2021 1:38 PM, Min Hu (Connor) wrote: From: Chengwen Feng Currently the vector and simple xmit algorithm don't support multi_segs, so if Tx offload support MBUF_FAST_FREE, driver could invoke rte_mempool_put

[PATCH v2 1/2] net/hns3: optimized Tx performance by mbuf fast free

2021-11-15 Thread Min Hu (Connor)
From: Chengwen Feng Currently the vector and simple xmit algorithm don't support multi_segs, so if Tx offload support MBUF_FAST_FREE, driver could invoke rte_mempool_put_bulk() to free Tx mbufs in this situation. In the testpmd single core MAC forwarding scenario, the performance is improved by

[PATCH v2 2/2] net/hns3: optimized Tx performance

2021-11-15 Thread Min Hu (Connor)
From: Chengwen Feng This patch uses tx_free_thresh to control mbufs free when the common xmit algorithm is used. This patch also modifies the implementation of PMD's tx_done_cleanup because the mbuf free algorithm changed. In the testpmd single core MAC forwarding scenario, the performance is i

[PATCH v2 0/2] performance optimized for hns3 PMD

2021-11-15 Thread Min Hu (Connor)
This patch set contains two ways to optimized Tx performance. Chengwen Feng (2): net/hns3: optimized Tx performance by mbuf fast free net/hns3: optimized Tx performance doc/guides/nics/features/hns3.ini | 1 + drivers/net/hns3/hns3_rxtx.c | 129 +++--- drivers/

Re: [PATCH v1] app/testpmd: avoid the process ID out of range

2021-11-15 Thread Min Hu (Connor)
Acked-by: Min Hu (Connor) 在 2021/11/15 14:05, Haiyue Wang 写道: The 'proc-id' should be less than 'num-procs', if not, exit the testpmd and show the error message. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Signed-off-by: Haiyue Wang ---

[PATCH 1/2] net/hns3: optimized Tx performance by mbuf fast free

2021-11-11 Thread Min Hu (Connor)
ed by 8% at 64B on Kunpeng920 platform. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 11 +++ drivers/net/hns3/hns3_rxtx.h | 2 ++ drivers/net/hns3/hns3_rxtx_vec.h | 9 + 3 files changed, 22 inser

[PATCH 2/2] net/hns3: optimized Tx performance

2021-11-11 Thread Min Hu (Connor)
forwarding scenario, the performance is improved by 10% at 64B on Kunpeng920 platform. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 118 --- 1 file changed, 54 insertions(+), 64 deletions(-) di

[PATCH 0/2] performance optimized for hns3 PMD

2021-11-11 Thread Min Hu (Connor)
This patch set contains two ways to optimized Tx performance. Chengwen Feng (2): net/hns3: optimized Tx performance by mbuf fast free net/hns3: optimized Tx performance drivers/net/hns3/hns3_rxtx.c | 129 --- drivers/net/hns3/hns3_rxtx.h | 2 + drivers/n

Re: [dpdk-dev] Questions about mmap in Asan APP

2021-11-09 Thread Min Hu (Connor)
在 2021/11/6 21:11, Thomas Monjalon 写道: 06/11/2021 10:27, Min Hu (Connor): Hi, Jonas Pfefferle and all, I met one questions: When I ran APP on Kasan OS, secondary process occasionally init failed. BTW: testpmd is built with Asan, that is to add "CFLAGS="-fsaniti

[dpdk-dev] [PATCH] net/bonding: fix offloading configuration

2021-11-08 Thread Min Hu (Connor)
devices. Fixes: e8b3e1a9b1bb ("net/bonding: switch to new offloading API") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) di

[dpdk-dev] Questions about mmap in Asan APP

2021-11-06 Thread Min Hu (Connor)
Hi, Jonas Pfefferle and all, I met one questions: When I ran APP on Kasan OS, secondary process occasionally init failed. BTW: testpmd is built with Asan, that is to add "CFLAGS="-fsanitize=address -fno-omit-frame-pointer -pthread"". Kasan OS is what opens this: CONFIG_SLUB_DEBU

[dpdk-dev] [PATCH v3 9/9] net/hns3: remove PF/VF duplicate code

2021-11-05 Thread Min Hu (Connor)
From: Chengwen Feng This patch remove PF/VF duplicate code of: 1. get firmware version. 2. get device info. 3. rx interrupt related functions. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c| 339 +- drivers/net

[dpdk-dev] [PATCH v3 5/9] net/hns3: extract a common file

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li This patch extracts a common file to store the common code for PF and VF driver. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.c | 2 +- drivers/net/hns3/hns3_common.c| 426 + drivers/net/hns3

[dpdk-dev] [PATCH v3 3/9] net/hns3: modifying code alignment

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li This patch modifies some code alignment issues to make the code style more consistent. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b

[dpdk-dev] [PATCH v3 6/9] net/hns3: add hns3 flow header file

2021-11-05 Thread Min Hu (Connor)
This patch adds a hns3_flow.h to make the code easier to maintain. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 1 + drivers/net/hns3/hns3_ethdev.h| 3 +-- drivers/net/hns3/hns3_ethdev_vf.c | 1 + drivers/net/hns3/hns3_fdir.h | 31

[dpdk-dev] [PATCH v3 8/9] net/hns3: fix the return value of the function

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li Fixing the return value of the function to clear static warning. Fixes: 1181500b2fc5 ("net/hns3: adjust MAC address logging") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 8 1 file

[dpdk-dev] [PATCH v3 4/9] net/hns3: use unsigned integer for bitwise operations

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li Bitwise operations should be used only with unsigned integer. This patch modifies some code that does not meet this rule. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[dpdk-dev] [PATCH v3 0/9] code optimization for hns3 PMD

2021-11-05 Thread Min Hu (Connor)
: use unsigned integer for bitwise operations net/hns3: extract a common file net/hns3: remove magic numbers net/hns3: fix the return value of the function Min Hu (Connor) (1): net/hns3: add hns3 flow header file --- v3: * fixed build error and some other adjustment. v2: * rebase patch on

[dpdk-dev] [PATCH v3 2/9] net/hns3: remove a redundant function declaration

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li This patch removes a redundant function declaration for hns3_rx_check_vec_support(). Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3

[dpdk-dev] [PATCH v3 1/9] net/hns3: fix the shift of DMA address in Rx/Tx queue

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li The patch obtains the upper 32 bits of the Rx/Tx queue DMA address in one step instead of two steps. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- driver

[dpdk-dev] [PATCH v3 7/9] net/hns3: remove magic numbers

2021-11-05 Thread Min Hu (Connor)
From: Huisong Li Removing magic numbers with macros. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 4 ++-- drivers/net/hns3/hns3_common.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_common.c b

Re: [dpdk-dev] [PATCH 9/9] net/hns3: remove PF/VF duplicate code

2021-11-04 Thread Min Hu (Connor)
Hi, 在 2021/11/4 22:55, Ferruh Yigit 写道: On 11/2/2021 3:17 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch remove PF/VF duplicate code of: 1. get firmware version. 2. get device info. 3. rx interrupt related functions. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor

[dpdk-dev] [PATCH v2 6/9] net/hns3: add hns3 flow header file

2021-11-04 Thread Min Hu (Connor)
This patch adds a hns3_flow.h to make the code easier to maintain. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 1 + drivers/net/hns3/hns3_ethdev.h| 3 +-- drivers/net/hns3/hns3_ethdev_vf.c | 1 + drivers/net/hns3/hns3_fdir.h | 31

[dpdk-dev] [PATCH v2 5/9] net/hns3: extract a common file

2021-11-04 Thread Min Hu (Connor)
From: Huisong Li This patch extracts a common file to store the common code for PF and VF driver. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.c | 2 +- drivers/net/hns3/hns3_common.c| 427 + drivers/net/hns3

[dpdk-dev] [PATCH v2 8/9] net/hns3: fix the return value of the function

2021-11-04 Thread Min Hu (Connor)
From: Huisong Li Fixing the return value of the function to clear static warning. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/hns3/hns3_common.c b/drivers

[dpdk-dev] [PATCH v2 7/9] net/hns3: remove magic numbers

2021-11-04 Thread Min Hu (Connor)
From: Huisong Li Removing magic numbers with macros. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 4 ++-- drivers/net/hns3/hns3_common.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_common.c b

[dpdk-dev] [PATCH v2 3/9] net/hns3: modifying code alignment

2021-11-04 Thread Min Hu (Connor)
From: Huisong Li This patch modifies some code alignment issues to make the code style more consistent. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b

[dpdk-dev] [PATCH v2 1/9] net/hns3: fix the shift of DMA address in Rx/Tx queue

2021-11-04 Thread Min Hu (Connor)
From: Huisong Li The patch obtains the upper 32 bits of the Rx/Tx queue DMA address in one step instead of two steps. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] [PATCH v2 4/9] net/hns3: use unsigned integer for bitwise operations

2021-11-04 Thread Min Hu (Connor)
From: Huisong Li Bitwise operations should be used only with unsigned integer. This patch modifies some code that does not meet this rule. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[dpdk-dev] [PATCH v2 2/9] net/hns3: remove a redundant function declaration

2021-11-04 Thread Min Hu (Connor)
From: Huisong Li This patch removes a redundant function declaration for hns3_rx_check_vec_support(). Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3

[dpdk-dev] [PATCH v2 0/9] code optimization for hns3 PMD

2021-11-04 Thread Min Hu (Connor)
: use unsigned integer for bitwise operations net/hns3: extract a common file net/hns3: remove magic numbers net/hns3: fix the return value of the function Min Hu (Connor) (1): net/hns3: add hns3 flow header file --- v2: * rebase patch on top of latest next-net drivers/net/hns3.tar.gz

[dpdk-dev] [PATCH 9/9] net/hns3: remove PF/VF duplicate code

2021-11-01 Thread Min Hu (Connor)
From: Chengwen Feng This patch remove PF/VF duplicate code of: 1. get firmware version. 2. get device info. 3. rx interrupt related functions. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c| 337 +- drivers/net

[dpdk-dev] [PATCH 5/9] net/hns3: extract a common file

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li This patch extracts a common file to store the common code for PF and VF driver. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_cmd.c | 2 +- drivers/net/hns3/hns3_common.c| 427 + drivers/net/hns3

[dpdk-dev] [PATCH 1/9] net/hns3: fix the shift of DMA address in Rx/Tx queue

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li The patch obtains the upper 32 bits of the Rx/Tx queue DMA address in one step instead of two steps. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] [PATCH 6/9] net/hns3: add hns3 flow header file

2021-11-01 Thread Min Hu (Connor)
This patch adds a hns3_flow.h to make the code easier to maintain. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 1 + drivers/net/hns3/hns3_ethdev.h| 3 +-- drivers/net/hns3/hns3_ethdev_vf.c | 1 + drivers/net/hns3/hns3_fdir.h | 31

[dpdk-dev] [PATCH 0/9] code optimization for hns3 PMD

2021-11-01 Thread Min Hu (Connor)
: use unsigned integer for bitwise operations net/hns3: extract a common file net/hns3: remove magic numbers net/hns3: fix the return value of the function Min Hu (Connor) (1): net/hns3: add hns3 flow header file drivers/net/hns3/hns3_cmd.c | 2 +- drivers/net/hns3/hns3_common.c

[dpdk-dev] [PATCH 8/9] net/hns3: fix the return value of the function

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li Fixing the return value of the function to clear static warning. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/hns3/hns3_common.c b/drivers

[dpdk-dev] [PATCH 4/9] net/hns3: use unsigned integer for bitwise operations

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li Bitwise operations should be used only with unsigned integer. This patch modifies some code that does not meet this rule. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[dpdk-dev] [PATCH 3/9] net/hns3: modifying code alignment

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li This patch modifies some code alignment issues to make the code style more consistent. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b

[dpdk-dev] [PATCH 2/9] net/hns3: remove a redundant function declaration

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li This patch removes a redundant function declaration for hns3_rx_check_vec_support(). Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3

[dpdk-dev] [PATCH 7/9] net/hns3: remove magic numbers

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li Removing magic numbers with macros. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_common.c | 4 ++-- drivers/net/hns3/hns3_common.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_common.c b

[dpdk-dev] [PATCH 0/4] bugfix for multi process of hns3 PMD

2021-11-01 Thread Min Hu (Connor)
This patch set contains bugfix and code optimization for multi process of hns3 PMD. Huisong Li (4): net/hns3: decrease the count when secondary process exits net/hns3: fix MP action register and unregister net/hns3: fix lack of unregistering MP action for secondary net/hns3: refactor multi

[dpdk-dev] [PATCH 3/4] net/hns3: fix lack of unregistering MP action for secondary

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li This patch fixes lack of unregistering MP action for secondary process when PMD is closed. Fixes: 9570b1fdbdad ("net/hns3: check multi-process action register result") Fixes: 23d4b61fee5d ("net/hns3: support multiple process") Signed-off-by: Huisong Li S

[dpdk-dev] [PATCH 4/4] net/hns3: refactor multi-process initialization

2021-11-01 Thread Min Hu (Connor)
From: Huisong Li Currently, the logic of the PF and VF initialization codes for multiple process is the same. A common function can be extracted to initialize and unload multiple process. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 34

[dpdk-dev] [PATCH 2/4] net/hns3: fix MP action register and unregister

2021-11-01 Thread Min Hu (Connor)
ple process") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 2 ++ drivers/net/hns3/hns3_ethdev_vf.c | 2 ++ drivers/net/hns3/hns3_mp.c| 37 ++- drivers/net/hns3/hns3_mp.h| 7 ++ 4 files cha

[dpdk-dev] [PATCH 1/4] net/hns3: decrease the count when secondary process exits

2021-11-01 Thread Min Hu (Connor)
cess fails to send messages to the secondary process after the secondary process exits. Fixes: 23d4b61fee5d ("net/hns3: support multiple process") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 10 +++-

Re: [dpdk-dev] [RFC] ethdev: improve link speed to string

2021-10-31 Thread Min Hu (Connor)
在 2021/10/30 17:59, Morten Brørup 写道: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Min Hu (Connor) Sent: Friday, 17 September 2021 02.44 Agree with you. Thanks Andrew 在 2021/9/16 16:21, Andrew Rybchenko 写道: On 9/16/21 11:16 AM, Min Hu (Connor) wrote: Hi, Andrew, 在 2021/9/16 14:22

Re: [dpdk-dev] [PATCH] net/hns3: fix mailbox communication with HW

2021-10-28 Thread Min Hu (Connor)
Hi, Thomos, Ferruh, As this patch is to fix a critical bug for hns3 PMD, we hope this patch could be merged into 21.11. Please check it out. Thanks. 在 2021/10/28 19:52, Min Hu (Connor) 写道: Mailbox is the communication mechanism between SW and HW. There exist two approaches for SW to

[dpdk-dev] [PATCH] net/hns3: fix mailbox communication with HW

2021-10-28 Thread Min Hu (Connor)
k.org Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_mbx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c index a47622b8a6..245652e2ed 100644 --- a/drivers/net/hns3/hns3_mbx.c +++ b/drivers/net/hns3/hns3_mb

Re: [dpdk-dev] Question about bonding port promiscuous

2021-10-27 Thread Min Hu (Connor)
在 2021/10/27 21:47, David Marchand 写道: On Wed, Oct 27, 2021 at 5:21 AM Min Hu (Connor) wrote: Hi, David, In function "bond_ethdev_promiscuous_disable", for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode is propagat

[dpdk-dev] Question about bonding port promiscuous

2021-10-26 Thread Min Hu (Connor)
Hi, David, In function "bond_ethdev_promiscuous_disable", for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode is propagated to all slaves. While for "ACTIVE_BACKUP", "TLB", "ALB", promiscuous mode is propagated only to primary slave. Why? The second question, for "ACTIVE_B

Re: [dpdk-dev] [PATCH] app/testpmd: fix statistics in multiple process

2021-10-26 Thread Min Hu (Connor)
在 2021/10/27 0:22, Ferruh Yigit 写道: On 9/17/2021 4:33 AM, Min Hu (Connor) wrote: Hi, Xiaoyun, 在 2021/9/16 13:17, Li, Xiaoyun 写道: Hi -Original Message- From: Min Hu (Connor) Sent: Tuesday, September 14, 2021 11:13 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun Subject

[dpdk-dev] [PATCH 3/3] app/testpmd: remove unused header file

2021-10-24 Thread Min Hu (Connor)
From: Huisong Li This patch removes unused "rte_eth_bond.h" header file. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- app/test-pmd/parameters.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index

[dpdk-dev] [PATCH 1/3] app/testpmd: fix port status of active slave device

2021-10-24 Thread Min Hu (Connor)
;) Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- app/test-pmd/cmdline.c | 1 + app/test-pmd/testpmd.c | 49 +++--- app/test-pmd/testpmd.h | 3 ++- 3 files changed, 49 insertions(+), 4 deletions(-) diff --git a/app/test-pmd

[dpdk-dev] [PATCH 2/3] app/testpmd: fix slave device isn't released

2021-10-24 Thread Min Hu (Connor)
ot in bonding") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- app/test-pmd/cmdline.c | 1 + app/test-pmd/testpmd.c | 67 -- app/test-pmd/testpmd.h | 1 + 3 files changed, 60 insertions(+), 9 deletions(-) diff --git

[dpdk-dev] [PATCH 0/3] bugfix for testpmd

2021-10-24 Thread Min Hu (Connor)
This patchset contains three bugfixes for testpmd. Huisong Li (3): app/testpmd: fix port status of active slave device app/testpmd: fix slave device isn't released app/testpmd: remove unused header file app/test-pmd/cmdline.c| 2 + app/test-pmd/parameters.c | 3 - app/test-pmd/test

[dpdk-dev] [PATCH] bonding: show xmit policy for 802.3AD mode

2021-10-24 Thread Min Hu (Connor)
ble Slaves (2): [0 1] Active Slaves (2): [1 0] Primary: [1] Signed-off-by: Min Hu (Connor) --- app/test-pmd/cmdline.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 3221f6e1aa..722f4fb9d9 100

[dpdk-dev] [PATCH 10/14] net/hns3: uniform to config all MAC and MC address

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li Currently, the interface logic for adding and deleting all MAC address and multicast address in PF and VF driver is the same. This patch extracts two common interfaces to configure them separately. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3

[dpdk-dev] [PATCH 12/14] net/hns3: uniform common function to check multicast

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch uniforms a common function to check multicast address validity for PF and VF. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 12 -- drivers/net/hns3/hns3_ethdev.h| 4 +- drivers/net/hns3/hns3_ethdev_vf.c

[dpdk-dev] [PATCH 13/14] net/hns3: refactor hns3 set MC MAC addr list API for PF

2021-10-22 Thread Min Hu (Connor)
all previous MAC addresses and then adding new MAC addresses. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 112 - 1 file changed, 11 insertions(+), 101 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b

[dpdk-dev] [PATCH 14/14] net/hns3: replace set MC MAC addr list API in VF

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch removes hns3vf_set_mc_mac_addr_list() and uses hns3_set_mc_mac_addr_list() to do this. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 4 +-- drivers/net/hns3/hns3_ethdev.h| 7 ++--- drivers/net/hns3

[dpdk-dev] [PATCH 07/14] net/hns3: remove redundant multicast operation interface

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch removes redundant hns3_remove_mc_addr_common(), which can be replaced by hns3_remove_mc_mac_addr(). Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions

[dpdk-dev] [PATCH 11/14] net/hns3: uniform adding and removing MAC address API

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li The code logic of adding and removing MAC address in PF and VF is the same. This patch extracts two common interfaces to add and remove them separately. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 11 ++--- drivers/net

[dpdk-dev] [PATCH 09/14] net/hns3: use APIs in hns3 HW ops to config MAC features

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch uses APIs in hns3_hw_ops to configure MAC related features. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 32 +++ drivers/net/hns3/hns3_ethdev_vf.c | 27 +- 2

[dpdk-dev] [PATCH 08/14] net/hns3: add hns3 HW ops structure to operate hardware

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch adds hns3_hw_ops structure to operate hardware in PF and VF driver. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 10 ++ drivers/net/hns3/hns3_ethdev.h| 13 + drivers/net/hns3

[dpdk-dev] [PATCH 02/14] net/hns3: rename adding unicast address function in PF

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch renames hns3_add_uc_addr() to hns3_add_uc_mac_addr(). Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b

[dpdk-dev] [PATCH 00/14] refactor MAC handling for hns3 PMD

2021-10-22 Thread Min Hu (Connor)
This patchset refactor MAC handling for hns3 PMD, including unicast, multicast and operation for MAC address. Huisong Li (14): net/hns3: rename adding multicast address function in PF net/hns3: rename adding unicast address function in PF net/hns3: rename removing multicast address function

[dpdk-dev] [PATCH 04/14] net/hns3: extract a common interface to check duplicates

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li Extract a common interface for PF and VF to check whether the configured multicast MAC address from rte_eth_dev_mac_addr_add() is the same as the multicast MAC address from rte_eth_dev_set_mc_addr_list(). Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers

[dpdk-dev] [PATCH 05/14] net/hns3: remove redundant adding multicast MAC interface

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch removes hns3_add_mc_addr_common() in PF and hns3vf_add_mc_addr_common() in VF. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c| 31 --- drivers/net/hns3/hns3_ethdev_vf.c | 30

[dpdk-dev] [PATCH 06/14] net/hns3: rename removing unicast address function in PF

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch renames hns3_remove_uc_addr_common() to hns3_remove_uc_mac_addr() in PF. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/hns3

[dpdk-dev] [PATCH 01/14] net/hns3: rename adding multicast address function in PF

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch renames hns3_add_mc_addr() to hns3_add_mc_mac_addr(). Signed-off-by: Huisong Li --- drivers/net/hns3/hns3_ethdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c inde

[dpdk-dev] [PATCH 03/14] net/hns3: rename removing multicast address function in PF

2021-10-22 Thread Min Hu (Connor)
From: Huisong Li This patch renames hns3_remove_mc_addr() to hns3_remove_mc_mac_addr(). Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/hns3

Re: [dpdk-dev] [PATCH v2] net/hns3: add runtime config to set MBX limit time

2021-10-21 Thread Min Hu (Connor)
Hi, Ferruh, V3 has been sent,please check it out, thanks. 在 2021/10/21 21:06, Ferruh Yigit 写道: On 10/21/2021 3:22 AM, Min Hu (Connor) wrote: From: Chengchang Tang Current, the max waiting time for MBX response is 500ms, but in some scenarios, it is not enough. Since it depends on the

[dpdk-dev] [PATCH v3] net/hns3: add runtime config to set MBX limit time

2021-10-21 Thread Min Hu (Connor)
wait time. For the above scenes, users can adjust the waiting time to a suitable value by themselves. Fixes: 463e748964f5 ("net/hns3: support mailbox") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- v3: * set mbx_time_limit_ms to be documented.

Re: [dpdk-dev] Question about bonding port promiscuous

2021-10-21 Thread Min Hu (Connor)
Hi, David, how about your opinion ? 在 2021/10/21 20:58, Min Hu (Connor) 写道: Hi, Ferruh, Thomas, any comments? 在 2021/10/19 19:52, Min Hu (Connor) 写道: Hi, anyone could give me a reply? thanks. 在 2021/10/14 10:13, Min Hu (Connor) 写道: Hi, Declan Doherty,  In function

Re: [dpdk-dev] Question about bonding port promiscuous

2021-10-21 Thread Min Hu (Connor)
Hi, Ferruh, Thomas, any comments? 在 2021/10/19 19:52, Min Hu (Connor) 写道: Hi, anyone could give me a reply? thanks. 在 2021/10/14 10:13, Min Hu (Connor) 写道: Hi, Declan Doherty,  In function "bond_ethdev_promiscuous_disable", for "ROUND ROBIN","BALANCE&q

Re: [dpdk-dev] Question about bonding mode set API

2021-10-21 Thread Min Hu (Connor)
Hi, Thomas, Ferruh, have any suggustions? 在 2021/10/19 21:34, Min Hu (Connor) 写道: Hi, all, I met one questions: when I start testpmd, and type command like this, it will lead to Segmentation fault, like: testpmd> create bonded device 4 0 testpmd> add bonding slave 0 2 testpm

Re: [dpdk-dev] [PATCH] net/hns3: add runtime config to set MBX limit time

2021-10-20 Thread Min Hu (Connor)
Hi, Ferruh, 在 2021/9/9 21:20, Ferruh Yigit 写道: On 8/30/2021 4:48 AM, Min Hu (Connor) wrote: From: Chengchang Tang Current, the max waiting time for MBX response is 500ms, but in some scenarios, it is not enough. Since it depends on the response of the kernel mode driver, and its response

[dpdk-dev] [PATCH v2] net/hns3: add runtime config to set MBX limit time

2021-10-20 Thread Min Hu (Connor)
wait time. For the above scenes, users can adjust the waiting time to a suitable value by themselves. Fixes: 463e748964f5 ("net/hns3: support mailbox") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- v2: * add some comment for HNS3_MBX_DEF_TIM

[dpdk-dev] Question about bonding mode set API

2021-10-19 Thread Min Hu (Connor)
Hi, all, I met one questions: when I start testpmd, and type command like this, it will lead to Segmentation fault, like: testpmd> create bonded device 4 0 testpmd> add bonding slave 0 2 testpmd> add bonding slave 1 2 testpmd> port start 2 testpmd> set bonding mode 0 2 testpmd> quit Stopp

Re: [dpdk-dev] Question about bonding port promiscuous

2021-10-19 Thread Min Hu (Connor)
Hi, anyone could give me a reply? thanks. 在 2021/10/14 10:13, Min Hu (Connor) 写道: Hi, Declan Doherty, In function "bond_ethdev_promiscuous_disable", for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode is propagated to a

[dpdk-dev] Question about bonding port promiscuous

2021-10-13 Thread Min Hu (Connor)
Hi, Declan Doherty, In function "bond_ethdev_promiscuous_disable", for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode is propagated to all slaves. While for "ACTIVE_BACKUP", "TLB", "ALB", promiscuous mode is propagated only to primary slave. Why? The second questi

[dpdk-dev] [PATCH] net/hns3: fix incorrect free function

2021-10-13 Thread Min Hu (Connor)
From: Chengwen Feng The intr_handle->intr_vec is allocated by rte_zmalloc(), but freed by free(), this patch fixes it. Fixes: 02a7b55657b2 ("net/hns3: support Rx interrupt") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- 1 file changed, 1 insert

[dpdk-dev] [PATCH v2] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-11 Thread Min Hu (Connor)
dev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- v2: * fixed commit log. --- lib/ethdev/rte_ethdev.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethd

Re: [dpdk-dev] [PATCH] app/testpmd: retain all original dev conf when config DCB

2021-10-11 Thread Min Hu (Connor)
在 2021/10/11 14:49, Li, Xiaoyun 写道: Hi -Original Message- From: Min Hu (Connor) Sent: Saturday, October 9, 2021 16:42 To: dev@dpdk.org Cc: Yigit, Ferruh ; tho...@monjalon.net; Li, Xiaoyun Subject: [PATCH] app/testpmd: retain all original dev conf when config DCB From: Huisong Li

[dpdk-dev] [PATCH v2] app/testpmd: retain all original dev conf when config DCB

2021-10-11 Thread Min Hu (Connor)
ic class") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) Acked-by: Xiaoyun Li --- v2: * fixed commit log. --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c ind

Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-09 Thread Min Hu (Connor)
Hope for your reply 在 2021/10/8 18:04, Thomas Monjalon 写道: 08/10/2021 09:02, Min Hu (Connor): Hi, Thomas, 在 2021/10/6 3:21, Thomas Monjalon 写道: 22/09/2021 05:36, Min Hu (Connor): From: Huisong Li Use the testpmd to perform the following operations: 1) mac_addr add 0 00:18:2D:00:00:90 2) mac_ad

[dpdk-dev] [PATCH] app/testpmd: retain all original dev conf when config DCB

2021-10-09 Thread Min Hu (Connor)
ic class") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index eec4f1b81d..12a0db8796 100644 --- a/app/test-

[dpdk-dev] [PATCH] net/hns3: remove similar macro function definitions

2021-10-09 Thread Min Hu (Connor)
From: Chengchang Tang For different capabilities, we declare different macro functions to determine whether the capabilities are supported. This patch declare a unified macro function to judge capabilities. Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- drivers/net/hns3

Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-08 Thread Min Hu (Connor)
Hi, Thomas, 在 2021/10/6 3:21, Thomas Monjalon 写道: 22/09/2021 05:36, Min Hu (Connor): From: Huisong Li Use the testpmd to perform the following operations: 1) mac_addr add 0 00:18:2D:00:00:90 2) mac_addr add 0 00:18:2D:00:00:91 3) mac_addr add 0 00:18:2D:00:00:92 4) mac_addr set 0 00:18:2D:00

Re: [dpdk-dev] Questions about vm2vm vhost-user/virtio-net test

2021-10-07 Thread Min Hu (Connor)
Hi, David, thanks for your reply, other question as below, 在 2021/10/1 2:25, David Christensen 写道: On 9/30/21 2:07 AM, Min Hu (Connor) wrote: Hi, all,  I got the answer: testpmd fwd mode should be set "io", then ping OK.  IO fwd mode, it will not change packet MAC address

Re: [dpdk-dev] Questions about vm2vm vhost-user/virtio-net test

2021-09-30 Thread Min Hu (Connor)
r change packet src MAC and dst MAC, but ping OK, testpmd vhost, treated as switch, also changes packert src MAC and dst MAC, but ping failed ? 在 2021/9/29 20:09, Min Hu (Connor) 写道: Hi, Coquelin, Chenbo, all, I  want to seek help about vm2vm vhost-user/virtio-net test from

[dpdk-dev] Questions about vm2vm vhost-user/virtio-net test

2021-09-29 Thread Min Hu (Connor)
Hi, Coquelin, Chenbo, all, I want to seek help about vm2vm vhost-user/virtio-net test from you. When I set up vm2vm vhost-user/virtio-net test, I cannot ping vm2 in vm1. That is, ping failed between vm1 and vm2. Detailed description are as flows: host configuration: Linux

Re: [dpdk-dev] [PATCH v2 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id

2021-09-27 Thread Min Hu (Connor)
Hi, Thomas, any comments? 在 2021/5/6 11:46, Min Hu (Connor) 写道: From: Chengwen Feng In DPDK, 'rte_socket_id' means the running socket while 'rte_eth_dev_socket_id' is the device socket. For better performance, memory which queue setup used and device should b

Re: [dpdk-dev] [PATCH v2 2/2] examples/ethtool: add closing port operation

2021-09-27 Thread Min Hu (Connor)
Hi, Ferruh, any comments? 在 2021/5/6 11:46, Min Hu (Connor) 写道: From: Huisong Li Currently, ethtool directly ends the process after 'quit' cmd. In this case, software resources are not released and hardware resources of the device are not uninstalled. This patch adds cl

Re: [dpdk-dev] [PATCH] examples/ethtool: fix pause configuration

2021-09-27 Thread Min Hu (Connor)
Hi, Ferruh, any comments about this patch? 在 2021/7/17 10:15, Min Hu (Connor) 写道: Hi, all, any comments? 在 2021/6/28 10:17, Min Hu (Connor) 写道: Hi, all,  any comments? 在 2021/4/28 16:42, Min Hu (Connor) 写道: From: Huisong Li Currently, the pause command in ethtool to

[dpdk-dev] [PATCH v3] app/testpmd: add cmdline to show LACP bonding info

2021-09-24 Thread Min Hu (Connor)
From: Chengchang Tang Add a new cmdline to help diagnostic the bonding mode 4 in testpmd. Show the lacp information about the bonded device and its slaves: show bonding lacp info Signed-off-by: Chengchang Tang Signed-off-by: Min Hu(Connor) --- v3: * fix state show. v2: * same patch with v1

[dpdk-dev] [PATCH v2] app/testpmd: add cmdline to show LACP bonding info

2021-09-24 Thread Min Hu (Connor)
From: Chengchang Tang Add a new cmdline to help diagnostic the bonding mode 4 in testpmd. Show the lacp information about the bonded device and its slaves: show bonding lacp info Signed-off-by: Chengchang Tang Signed-off-by: Min Hu(Connor) --- app/test-pmd/cmdline.c

Re: [dpdk-dev] [PATCH] app/testpmd: add cmdline to show LACP bonding info

2021-09-24 Thread Min Hu (Connor)
Hi, 在 2021/9/23 11:20, Li, Xiaoyun 写道: Hi -Original Message- From: dev On Behalf Of Min Hu (Connor) Sent: Wednesday, September 22, 2021 14:25 To: dev@dpdk.org Cc: Yigit, Ferruh ; tho...@monjalon.net Subject: [dpdk-dev] [PATCH] app/testpmd: add cmdline to show LACP bonding info From

[dpdk-dev] [PATCH 2/2] net/bonding: fix RSS key length

2021-09-22 Thread Min Hu (Connor)
onding: support RSS dynamic configuration") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Min Hu(Connor) --- drivers/net/bonding/rte_eth_bond_api.c | 6 drivers/net/bonding/rte_eth_bond_pmd.c | 44 -- 2 files changed, 33 insertions(+), 17 de

  1   2   3   4   5   6   7   8   9   10   >