[dpdk-dev] [PATCH] EAL: count nr_overcommit_hugepages as available

From: Michał Mirosław With nr_overcommit_hugepages > 0 application may be able to allocate hugepages even when free_hugepages == 0. Take this into account when counting available hugepages. Signed-off-by: Michał Mirosław --- .../linuxapp/eal/eal_hugepage_info.c |

Re: [dpdk-dev] [PATCH v2 01/13] EAL: count nr_overcommit_hugepages as available

On Sun, Apr 30, 2017 at 05:53:55PM +0200, Thomas Monjalon wrote: > 13/12/2016 02:28, Michał Mirosław: > > Signed-off-by: Michał Mirosław > > --- > > lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 43 > > ++--- > > 1 file changed, 32 inser

Re: [dpdk-dev] [PATCH] mk: parallelize make config

ig > real0m1.826s [...] > +$(RTE_OUTPUT)/.depdirs: $(DEPDIRS) > + @rm -f $@ > + @for f in $(DEPDIRS); do cat $$f >> $@; done > + @sort -u -o $@ $@ This could be just one 'sort -u -o $@ $(DEPDIRS)' Best Regards, Michał Mirosław

Re: [dpdk-dev] [PATCH v4 2/2] kni: Use bulk functions to allocate and free mbufs

ted buffer\n"); > rte_pktmbuf_free(pkts[j]); > + } This could also use bulk free, even if only to shave two lines of code. Best Regards, Michał Mirosław

[dpdk-dev] [PATCH 2/2] acl: allow zero verdict

This enables ACL matches to return 0 where the distinction from no-match case is not needed. From: Michał Mirosław Signed-off-by: Michał Mirosław --- app/test/test_acl.c | 13 - doc/guides/prog_guide/packet_classif_access_ctrl.rst | 3 ++- lib

[dpdk-dev] [PATCH 1/2] acl: remove invalid test

rte_acl_add_rules() has no way of checking rule size. This was hidden because the test effectively checked that adding a rule with userdata == 0 failed. From: Michał Mirosław Signed-off-by: Michał Mirosław --- app/test/test_acl.c | 20 1 file changed, 20 deletions

[dpdk-dev] [PATCH 0/2] Enable zero verdicts in ACLs

This set enables one to have ACL matches return 0 where the distinction from no-match case is not needed. This is a resubmission of the patches as a series, rebased on net-next tree, no other changes vs v2. v2: fixes to prog_guide and ACL tests Michał Mirosław (2): acl: remove invalid test

Re: [dpdk-dev] [PATCH 08/13] PMD/af_packet: guard against buffer overruns in RX path

On Wed, Jan 18, 2017 at 11:48:52AM +, Ferruh Yigit wrote: > On 12/13/2016 1:08 AM, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław > Form main address () which sets git author > field, and Signed-off mail address are different. > > As author, any objection t

[dpdk-dev] [PATCH v3 1/1] i40e: improve message grepability

From: Michał Mirosław Join message lines for easier grepping. PRIxXX are left glued to strings as they are in other parts of the file. Signed-off-by: Michał Mirosław --- v2: move long strings on a line by themselves v3: indent modified lines with TAB only Change-Id

Re: [dpdk-dev] [PATCH v4] null: fake PMD capabilities

On Mon, Jan 09, 2017 at 12:07:36PM +, Ferruh Yigit wrote: > On 12/14/2016 7:16 PM, Michał Mirosław wrote: > > From: Paweł Małachowski > > > > This allows for testing code which needs offloads to be supported. > > > > Signed-off-by: Michał Mirosł

[dpdk-dev] [PATCH] i40e: improve message grepability

Join message lines for easier grepping. PRIxXX are left glued to strings as they are in other parts of the file. Signed-off-by: Michał Mirosław --- drivers/net/i40e/i40e_ethdev.c | 308 + 1 file changed, 160 insertions(+), 148 deletions(-) diff --git a

Re: [dpdk-dev] [PATCH 12/13] i40e: return -errno when intr setup fails

On Thu, Dec 22, 2016 at 03:45:35PM +, Ferruh Yigit wrote: > On 12/13/2016 1:08 AM, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław > > --- > > drivers/net/i40e/i40e_ethdev.c | 5 +++-- > > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2

[dpdk-dev] [PATCH v4] null: fake PMD capabilities

From: Paweł Małachowski This allows for testing code which needs offloads to be supported. Signed-off-by: Michał Mirosław --- drivers/net/null/rte_eth_null.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers

Re: [dpdk-dev] [PATCH 11/13] KNI: guard against unterminated dev_info.name leading to BUG in alloc_netdev()

On Wed, Dec 14, 2016 at 05:33:11PM +, Ferruh Yigit wrote: > On 12/13/2016 1:08 AM, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław > > --- > > Acked-by: Ferruh Yigit > > I guess no harm doing extra check on user input. This actually prevents an OOPS t

Re: [dpdk-dev] [PATCH 10/13] KNI: provided netif name's source is user-space

On Wed, Dec 14, 2016 at 05:06:23PM +, Ferruh Yigit wrote: > Hi Michal, > > On 12/13/2016 1:08 AM, Michał Mirosław wrote: > > Signed-off-by: Michał Mirosław > > --- > > lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 d

[dpdk-dev] [PATCH] acl: remove invalid test

rte_acl_add_rules() has no way of checking rule size. This was hidden because the test effectively checked that adding a rule with userdata == 0 failed. Signed-off-by: Michał Mirosław --- app/test/test_acl.c | 20 1 file changed, 20 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH v2] acl: allow zero verdict

Signed-off-by: Michał Mirosław --- v2: fixes prog_guide and ACL tests --- app/test/test_acl.c | 13 - doc/guides/prog_guide/packet_classif_access_ctrl.rst | 3 ++- lib/librte_acl/rte_acl.c | 3 +-- lib/librte_acl

Re: [dpdk-dev] [PATCH 02/13] mbuf: rte_pktmbuf_free_bulk()

On Tue, Dec 13, 2016 at 01:41:11PM -0800, Stephen Hemminger wrote: > On Tue, 13 Dec 2016 02:08:15 +0100 (CET) > Michał Mirosław wrote: > > > Signed-off-by: Michał Mirosław > > > > --- > > lib/librte_mbuf/rte_mbuf.h | 15 +++ > > 1 file change

[dpdk-dev] [-- 06/13] null: fake PMD capabilities

From: Paweł Małachowski Signed-off-by: Michał Mirosław --- drivers/net/null/rte_eth_null.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 836d982..c802bc0 100644 --- a/drivers/net/null

[dpdk-dev] [PATCH v2 09/13] PMD/af_packet: guard against buffer overruns in TX path

Signed-off-by: Michał Mirosław --- drivers/net/af_packet/rte_eth_af_packet.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 5599e02..fc2dc4a 100644 --- a

[dpdk-dev] [PATCH v2 08/13] PMD/af_packet: guard against buffer overruns in RX path

Signed-off-by: Michał Mirosław --- drivers/net/af_packet/rte_eth_af_packet.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index ff45068..5599e02 100644 --- a/drivers/net

[dpdk-dev] [PATCH v2 06/13] null: fake PMD capabilities

From: Paweł Małachowski Thanks to that change we can use Null PMD for testing purposes. Signed-off-by: Michał Mirosław --- drivers/net/null/rte_eth_null.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null

[dpdk-dev] [PATCH v2 01/13] EAL: count nr_overcommit_hugepages as available

Signed-off-by: Michał Mirosław --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 43 ++--- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c index 18858e2

[dpdk-dev] [PATCH 13/13] i40e: improve message grepability

Signed-off-by: Michał Mirosław --- drivers/net/i40e/i40e_ethdev.c | 198 +++-- 1 file changed, 73 insertions(+), 125 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 39fbcfe..4d73aca 100644 --- a/drivers/net/i40e

[dpdk-dev] [PATCH 12/13] i40e: return -errno when intr setup fails

Signed-off-by: Michał Mirosław --- drivers/net/i40e/i40e_ethdev.c | 5 +++-- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 67778ba..39fbcfe

[dpdk-dev] [PATCH 11/13] KNI: guard against unterminated dev_info.name leading to BUG in alloc_netdev()

Signed-off-by: Michał Mirosław --- lib/librte_eal/linuxapp/kni/kni_misc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index f0247aa..14a2e3b 100644 --- a/lib/librte_eal/linuxapp/kni/kni_misc.c +++ b

[dpdk-dev] [PATCH 10/13] KNI: provided netif name's source is user-space

Signed-off-by: Michał Mirosław --- lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index 497db9b..f0247aa 100644 --- a/lib/librte_eal/linuxapp/kni

[dpdk-dev] [PATCH 08/13] PMD/af_packet: guard against buffer overruns in RX path

Signed-off-by: Michał Mirosław --- drivers/net/af_packet/rte_eth_af_packet.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index ff45068..b1005c6 100644 --- a/drivers/net

[dpdk-dev] [PATCH 09/13] PMD/af_packet: guard against buffer overruns in TX path

Signed-off-by: Michał Mirosław --- drivers/net/af_packet/rte_eth_af_packet.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index b1005c6..2c81d25 100644 --- a/drivers

[dpdk-dev] [PATCH 06/13] null: fake PMD capabilities

From: Paweł Małachowski Thanks to that change we can use Null PMD for testing purposes. Signed-off-by: Michał Mirosław --- drivers/net/null/rte_eth_null.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null

[dpdk-dev] [PATCH 07/13] pcap: fix timestamps in output pcap file

From: Piotr Bartosiewicz Signed-off-by: Michał Mirosław --- drivers/net/pcap/rte_eth_pcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 0162f44..57b0b31 100644 --- a/drivers/net/pcap/rte_eth_pcap.c

[dpdk-dev] [PATCH 05/13] acl: fix acl_flow_data comments

Signed-off-by: Michał Mirosław --- lib/librte_acl/acl_run.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_acl/acl_run.h b/lib/librte_acl/acl_run.h index 024f393..a862ff6 100644 --- a/lib/librte_acl/acl_run.h +++ b/lib/librte_acl/acl_run.h @@ -69,10 +69,10

[dpdk-dev] [PATCH 03/13] rte_ether: set PKT_RX_VLAN_STRIPPED in rte_vlan_strip()

Signed-off-by: Michał Mirosław --- lib/librte_net/rte_ether.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index ff3d065..26a8843 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -357,7

[dpdk-dev] [PATCH 04/13] acl: allow zero verdict

Signed-off-by: Michał Mirosław --- lib/librte_acl/rte_acl.c | 3 +-- lib/librte_acl/rte_acl.h | 2 -- lib/librte_table/rte_table_acl.c | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/librte_acl/rte_acl.c b/lib/librte_acl/rte_acl.c index 8b7e92c..d1f40be

[dpdk-dev] [PATCH 02/13] mbuf: rte_pktmbuf_free_bulk()

Signed-off-by: Michał Mirosław --- lib/librte_mbuf/rte_mbuf.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index ead7c6e..a95d99f 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -1248,6

[dpdk-dev] [PATCH 01/13] EAL: count nr_overcommit_hugepages as available

Signed-off-by: Michał Mirosław --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 43 ++--- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c index 18858e2

[dpdk-dev] [PATCH 00/13] Fixes and tweaks

This is a loose set of small fixes accumulated here at Atende Software to be upstreamed. Please consider and apply each one separately. Best Regards, Michal Mirosław --- Michał Mirosław (11): EAL: count nr_overcommit_hugepages as available mbuf: rte_pktmbuf_free_bulk() rte_ether: set

Re: [dpdk-dev] [PATCH 3/4] crypto: add sgl support for sw PMDs

qp->qp_stats.enqueue_err_count++; > + break; > + } > +#endif [...] Why are there so many copies of this code? Best Regards, Michał Mirosław

[dpdk-dev] [PATCH v4] drivers/net:new PMD using tun/tap host interface

2016-10-11 22:56 GMT+02:00 Wiles, Keith : >> On Oct 11, 2016, at 6:30 AM, Micha? Miros?aw wrote: >> >> 2016-10-04 16:45 GMT+02:00, Keith Wiles : >>> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces >>> on the local host. The PMD allows for DPDK and the host to >>> communicate using

[dpdk-dev] [PATCH v4] drivers/net:new PMD using tun/tap host interface

2016-10-04 16:45 GMT+02:00, Keith Wiles : > The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces > on the local host. The PMD allows for DPDK and the host to > communicate using a raw device interface on the host and in > the DPDK application. The device created is a Tap device with > a