On 1/16/25 10:54 AM, Maxime Coquelin wrote:
This series starts with a fix for a regression in the Vhost
dequeue error path.
The other patches improve the error handling to reduce the
chance of such regressions in the future.
Changes in v3:
==
- Squashed patches 2 & 3 (D
On 1/9/25 3:31 PM, Maxime Coquelin wrote:
rte_vhost_driver_set_max_queue_num API returns early when
called for a Vhost-user device, as this API is intended to
limit the maximum number of queue pairs supported by VDUSE
devices. However, a log mentioning the maximim number of
queue pairs is
On 12/20/24 4:45 AM, Yunjian Wang wrote:
The value of tso_segsz cannot be 0, instead check that value of
gso_size was set.
Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
lib/vhost/virtio_net.c | 3 +++
1 file changed, 3 inse
On 11/27/24 3:03 AM, Jianping Zhao wrote:
Clear ring addresses during vring base retrieval to handle guest reboot
scenarios correctly. This is particularly important for vdpa-blk devices
where the following issue occurs:
When a guest OS with vdpa-blk device reboots, during UEFI stage, only
on
On 1/15/25 5:46 PM, David Marchand wrote:
On Wed, Jan 15, 2025 at 1:59 PM Maxime Coquelin
wrote:
With previous refactoring, we can now simplify the RARP
packet injection handling in both the sync and async
dequeue paths.
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 42
With previous refactoring, we can now simplify the RARP
packet injection handling in both the sync and async
dequeue paths.
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 72 ++
1 file changed, 30 insertions(+), 42 deletions(-)
diff --git a
")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 69901ab3b5..a340e5a772 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -3629
This patch refactors the error handling in the Vhost
dequeue paths to ease its maintenance and readability.
Suggested-by: David Marchand
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 58 +++---
1 file changed, 26 insertions(+), 32 deletions
s in v2:
==
- Add RARP handling refactoring
Maxime Coquelin (3):
vhost: fix missing packets count reset when not ready
vhost: rework dequeue paths error handling
vhost: improve RARP handling in dequeue paths
lib/vhost/virtio_net.c | 110 ++--
On 1/15/25 5:49 PM, David Marchand wrote:
On Wed, Jan 15, 2025 at 5:42 PM David Marchand
wrote:
On Wed, Jan 15, 2025 at 1:59 PM Maxime Coquelin
wrote:
This patch refactors the error handling in the Vhost async
dequeue path to ease its maintenance and readability.
Suggested-by: David
With previous refactoring, we can now simplify the RARP
packet injection handling in both the sync and async
dequeue paths.
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 42 ++
1 file changed, 18 insertions(+), 24 deletions(-)
diff --git a
This patch refactors the error handling in the Vhost async
dequeue path to ease its maintenance and readability.
Suggested-by: David Marchand
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff
This patch refactors the error handling in the Vhost
dequeue path to ease its maintenance and readability.
Suggested-by: David Marchand
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a
")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 69901ab3b5..a340e5a772 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -3629
This series starts with a fix for a regression in the Vhost
dequeue error path.
The other patches improve the error handling to reduce the
chance of such regressions in the future.
Changes in v2:
==
- Add RARP handling refactoring
Maxime Coquelin (4):
vhost: fix missing packets
This patch refactors the error handling in the Vhost async
dequeue path to ease its maintenance and readability.
Suggested-by: David Marchand
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff
This patch refactors the error handling in the Vhost
dequeue path to ease its maintenance and readability.
Suggested-by: David Marchand
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a
")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 69901ab3b5..a340e5a772 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -3629
This series starts with a fix for a regression in the Vhost
dequeue error path.
The other patches improve the error handling to reduce the
chance of such regressions in the future.
Maxime Coquelin (3):
vhost: fix missing packets count reset when not ready
vhost: rework dequeue path error
On 1/14/25 8:50 AM, Ariel Otilibili wrote:
pthread_mutex_init always returns 0. The other mutex functions
return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Cc: Maxime Coquelin
Cc: Chenbo Xia
4:
case VIRTIO_NET_HDR_GSO_TCPV6:
With the title amended, the patch looks good to me:
Reviewed-by: Maxime Coquelin
No need to send a new version, I can fix the title while applying.
Thanks,
Maxime
>ring_addrs, 0, sizeof(struct vhost_vring_addr));
rte_rwlock_write_unlock(&vq->access_lock);
return RTE_VHOST_MSG_RESULT_REPLY;
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
Signed-off-by: Maxime Coquelin
---
lib/vhost/socket.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index d29d15494c..07247907b0 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -844
This patch implements MAC address setting with Vhost-kernel
backends.
With this, it is possible to set the TAP interface MAC address
using the Ethdev API.
Signed-off-by: Maxime Coquelin
---
drivers/net/virtio/virtio_user/vhost_kernel.c | 23 +++
.../net/virtio/virtio_user
This patch makes use of the new FD entry cleanup callback
to close the VDUSE reconnect eventfd after its removal
from the FD set.
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/lib/vhost/vduse.c b/lib/vhost
This patch leverages the new FD entry cleanup callback
to properly cleanup the vhost-user socket on disconnection
from the frontend.
Fixes: 0e38b42bf61c ("vhost: manage FD with epoll")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
lib/vhost/soc
.
Fixes: 0e38b42bf61c ("vhost: manage FD with epoll")
Cc: sta...@dpdk.org
Reported-by: David Marchand
Signed-off-by: Maxime Coquelin
---
lib/vhost/fd_man.c | 16
lib/vhost/fd_man.h | 3 ++-
lib/vhost/socket.c | 4 ++--
lib/vhost/vduse.c | 6 +++---
4 files c
. It includes closing the FD before it is removed
from the epoll FD set.
This series introduces a new cleanup callback which, if
implemented, is closed right after the FD is removed from
FD set.
Maxime Coquelin (3):
vhost: add cleanup callback to FD entries
vhost: fix vhost-user socket cleanup
This patch adds missing 'client' devarg documentation and
improve other devargs.
Bugzilla ID: 1603
Signed-off-by: Maxime Coquelin
---
doc/guides/nics/vhost.rst | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/doc/guides/nics/vhost.rst b/doc/guides/nics
Hi,
On 12/18/24 08:34, Wangyunjian(wangyunjian,TongTu) wrote:
-Original Message-
From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
Sent: Tuesday, December 17, 2024 11:33 PM
To: dev@dpdk.org
Cc: Olivier Matz ; Maxime Gouin
; Maxime Coquelin
Subject: [PATCH] net/virtio: fix Rx
Signed-off-by: Maxime Gouin
Signed-off-by: Olivier Matz
Reviewed-by: Maxime Coquelin
---
lib/vhost/virtio_net.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index d764d4bc6a..69901ab3b5 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost
A vulnerability was fixed in DPDK.
Some downstream stakeholders were warned in advance through
security-prerele...@dpdk.org in order to coordinate the release
of fixes and reduce the vulnerability window [0].
A malicious guest using a virtio driver can cause the vhost-user side to
crash by sendi
(with DPDK ML that got removed)
On 12/13/24 11:46, Maxime Coquelin wrote:
On 12/13/24 11:21, Mukul Sinha wrote:
Thanks @joshw...@google.com <mailto:joshw...@google.com> @Maxime
Coquelin <mailto:maxime.coque...@redhat.com> for the inputs.
@Maxime Coquelin <mailto:maxime.coqu
Hi Mukul,
On 12/5/24 23:54, Mukul Sinha wrote:
Thanks @maxime.coque...@redhat.com <mailto:maxime.coque...@redhat.com>
Have included dev@dpdk.org <mailto:dev@dpdk.org>
On Fri, Dec 6, 2024 at 2:11 AM Maxime Coquelin
mailto:maxime.coque...@redhat.com>> wrote:
Hi Mukul,
On 11/17/24 18:32, Stephen Hemminger wrote:
The file vduse.h does not have a license that is compatiable
with current DPDK license policy.
This reverts commit 9fec3f0569087de0129c7f2badaf5be2776e.
Signed-off-by: Stephen Hemminger
---
kernel/linux/uapi/linux/vduse.h | 353 -
On 11/18/24 17:24, Stephen Hemminger wrote:
If lock is acquired for write, it must be released for write
or a deadlock is likely.
Bugzilla ID: 1582
Fixes: 9fc93a1e2320 ("vhost: fix virtqueue access check in datapath")
Cc: david.march...@redhat.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen H
On 11/25/24 17:28, David Marchand wrote:
On Mon, Nov 25, 2024 at 5:20 PM Maxime Coquelin
wrote:
On 11/25/24 12:14, David Marchand wrote:
On Mon, Nov 18, 2024 at 5:24 PM Stephen Hemminger
wrote:
If lock is acquired for write, it must be released for write
or a deadlock is likely
but would change the commit title to:
vhost: fix deadlock in Rx async path
With this change:
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
lib/vhost/meson.build | 5 +-
lib/vhost/vduse.c | 2 +-
lib/vhost/vduse.h | 22 ++
4 files changed, 27 insertions(+), 355 deletions(-)
delete mode 100644 kernel/linux/uapi/linux/vduse.h
Acked-by: Maxime Coquelin
Thanks
On 11/8/24 01:32, Nicolas Chautru wrote:
Allowing ring memory allocation whose end address is aligned with 64 MB.
Previous logic was off by one.
Fixes: 060e76729302 ("baseband/acc100: add queue configuration")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc
On 10/25/24 19:57, Nicolas Chautru wrote:
Hi Maxime, all,
Adding a couple of changes to the built in test application for bbdev
test on top of previous changes.
Thanks,
Nic
Nicolas Chautru (2):
app/bbdev: add capture of queue dump
app/bbdev: add support for interrupt disable
app/te
a_end_addr = sw_rings_base_iova + dev_sw_ring_size;
+ sw_ring_iova_end_addr = sw_rings_base_iova + dev_sw_ring_size -
1;
/* Check if the end of the sw ring memory block is before the
* start of next 64MB aligned mem address
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
}
+
/* Free active device resources and return */
free_buffers(ad, op_params);
return t_ret;
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 10/25/24 19:57, Nicolas Chautru wrote:
Adding support for calling the interrupt disable api
for coverage.
Signed-off-by: Nicolas Chautru
---
app/test-bbdev/test_bbdev_perf.c | 24
1 file changed, 24 insertions(+)
Reviewed-by: Maxime Coquelin
Thanks
Hi Stephen,
On 10/30/24 22:56, Stephen Hemminger wrote:
The current tap device is slow both due to architectural choices and the
overhead of Linux system calls. I am exploring a how to fix that but some
of the choices require some tradeoffs. Which leads to some open questions:
1. DPDK tap also
Hi Nicolas,
On 10/30/24 19:56, Nicolas Chautru wrote:
Allowing ring memory allocation whose end address is aligned with 64 MB.
Previous logic was off by one.
Fixes: 060e76729302 ("baseband/acc100: add queue configuration")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseb
This patch makes use of the imported VDUSE headers.
The VDUSE support is now systematically built on Linux
systems, even if the build system does not support its
ioctl().
Signed-off-by: Maxime Coquelin
Acked-by: Morten Brørup
---
lib/vhost/meson.build | 5 +
lib/vhost/vduse.c | 2
Import VDUSE headers to be included in the Vhost library.
Set header version to v6.10 Linux Kernel release.
Signed-off-by: Maxime Coquelin
Acked-by: Morten Brørup
---
kernel/linux/uapi/linux/vduse.h | 353
kernel/linux/uapi/version | 2 +-
2 files
imported.
Guidelines are provided in the documentation, and helper
script is also provided to ensure proper import of the
headers (unmodified content from a released Kernel
version).
Signed-off-by: Maxime Coquelin
Acked-by: Morten Brørup
---
devtools/linux-uapi.sh | 171
ation
Changes in RFC v2:
==
- Fix typos in documentation and commit messags (David, Morten)
- Add uAPI checker script
- Add uAPI to global_inc
- Fix build issues on FreeBSD and documentation (CI, David)
- Simplify import script (David)
Maxime Coquelin (3):
uapi: introduce kernel uAPI he
issues on FreeBSD and documentation (CI, David)
- Simplify import script (David)
Maxime Coquelin (3):
uapi: introduce kernel uAPI headers import
uapi: import VDUSE header
vduse: use imported VDUSE uAPI header
devtools/linux-uapi.sh | 171
doc/guides
Import VDUSE headers to be included in the Vhost library.
Set header version to v6.10 Linux Kernel release.
Signed-off-by: Maxime Coquelin
---
kernel/linux/uapi/linux/vduse.h | 353
kernel/linux/uapi/version | 2 +-
2 files changed, 354 insertions(+), 1
imported.
Guidelines are provided in the documentation, and helper
script is also provided to ensure proper import of the
headers (unmodified content from a released Kernel
version).
Signed-off-by: Maxime Coquelin
---
devtools/linux-uapi.sh | 171 +
doc
This patch makes use of the imported VDUSE headers.
The VDUSE support is now systematically built on Linux
systems, even if the build system does not support its
ioctl().
Signed-off-by: Maxime Coquelin
---
lib/vhost/meson.build | 5 +
lib/vhost/vduse.c | 2 +-
lib/vhost/vduse.h
On 10/24/24 18:14, Stephen Hemminger wrote:
On Thu, 24 Oct 2024 14:45:10 +0200
Maxime Coquelin wrote:
Rather than copy-pasting headers_install.sh, could you use it directly?
The copy/paste from GPL-2.0 concerns me.
And the potential upstream change as well.
The downside I see by
This patch fixes missing error handling in checking the
reconnect log version, and takes the opportunity to move
all the checks into a dedicated function to simply VDUSE
device creation code.
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxim
On 10/14/24 14:14, Maxime Coquelin wrote:
On 10/9/24 16:50, Stephen Hemminger wrote:
On Wed, 9 Oct 2024 10:58:03 +0200
Maxime Coquelin wrote:
+fixup_includes()
+{
+ local path=$1
+
+ sed -i -E -e '
+ s/([[:space:](])(__user|__force|__iomem)[[:space:]]/\1/g
+
This patch fixes missing reconnection log unmapping
miss in the error path at VDUSE creation time.
Coverity issue: 445525
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 27 +++
1 file c
This patch moves the VDUSE reconnection log mapping, as
well as creation if needed, into a dedicated function.
This is a preliminary rework to simplify VDUSE device
creation.
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 138 --
1 file
On 10/24/24 11:44, Maxime Coquelin wrote:
This series provides various fixes for VDUSE reconnection
introduced in -rc1, some of them being reported by
Coverity.
The series also takes the opportunity to refactor
reconnection to make it more self-contained to simplify
readability and error
On 10/15/24 00:30, Nicolas Chautru wrote:
Supporting recent change in the device to
extend FFT capability processing in latest stepping.
Also including cosmetic change to VRB2 register definition.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.h | 2 +-
drivers/base
This patch fixes a FD leak in the VDUSE device reconnect
code fails to start the device.
Also take the opportunity to refactor the related code into
a dedicated function.
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
---
lib/vhost/vd
On 10/15/24 00:30, Nicolas Chautru wrote:
Hi,
Additional and final series for the VRB2 PMD.
Now supporting latest FFT processing (available on final stepping
of the device ) and generic improvement to decoder configuration.
Thanks
Nic
Nicolas Chautru (2):
baseband/acc: FFT support in VRB2
This patch moves the VDUSE reconnection log mapping and
setup after the Vhost device is created in order to
simplify the device creation and its error path.
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 111 ++
1 file changed, 52 insertions
On 10/24/24 10:36, David Marchand wrote:
On Thu, Oct 24, 2024 at 9:55 AM Maxime Coquelin
wrote:
- if (reconnect_log->nr_vrings != total_queues) {
- VHOST_CONFIG_LOG(name, ERR,
- "Queues number mismatch between
This patch fixes a possible TOCTOU on the VDUSE
device chardev opening at device creation time.
Coverity issue: 445526
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
Reviewed-by: David Marchand
---
lib/vhost/vd
:
==
- Avoid superluous error logging (David)
- VDUSE in capital letter in commit title 1 (David)
- Declare dev_config in the code block it is used (David)
- Fix wrong goto in intermediate patch (Maxime)
Maxime Coquelin (6):
vhost: fix VDUSE device creation error handling
vhost: fix possible TOCTOU in
This patch moves the VDUSE reconnection log mapping and
setup after the Vhost device is created in order to
simplify the device creation and its error path.
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 115 +-
1 file changed, 52 insertions
This patch moves the VDUSE reconnection log mapping, as
well as creation if needed, into a dedicated function.
This is a preliminary rework to simplify VDUSE device
creation.
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 136 +-
1 file
:
==
- Avoid superluous error logging (David)
- VDUSE in capital letter in commit title 1 (David)
- Declare dev_config in the code block it is used (David)
- Fix wrong goto in intermediate patch (Maxime)
Maxime Coquelin (6):
vhost: fix VDUSE device creation error handling
vhost: fix possible TOCTOU in
This patch fixes missing error handling in checking the
reconnect log version, and takes the opportunity to move
all the checks into a dedicated function to simply VDUSE
device creation code.
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxim
This patch fixes a FD leak in the VDUSE device reconnect
code fails to start the device.
Also take the opportunity to refactor the related code into
a dedicated function.
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
---
lib/vhost/vd
This patch fixes a possible TOCTOU on the VDUSE
device chardev opening at device creation time.
Coverity issue: 445526
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
Reviewed-by: David Marchand
---
lib/vhost/vd
This patch fixes missing reconnection log unmapping
miss in the error path at VDUSE creation time.
Coverity issue: 445525
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 27 +++
1 file c
On 10/23/24 18:06, David Marchand wrote:
On Wed, Oct 23, 2024 at 5:16 PM Maxime Coquelin
wrote:
This patch fixes missing reconnection log unmapping
miss in the error path at VDUSE creation time.
Coverity issue: 445525
Fixes: da79cc7fda76 ("vhost: add reconnection support to
On 10/23/24 18:07, David Marchand wrote:
On Wed, Oct 23, 2024 at 5:16 PM Maxime Coquelin
wrote:
This patch moves the VDUSE reconnection log mapping, as
well as creation if needed, into a dedicated function.
This is a preliminary rework to simplify VDUSE device
creation.
Signed-off-by
On 10/23/24 18:06, David Marchand wrote:
On Wed, Oct 23, 2024 at 5:16 PM Maxime Coquelin
wrote:
This patch fixes a FD leak in the VDUSE device reconnect
code fails to start the device.
Also take the opportunity to refactor the related code into
a dedicated function.
Fixes: da79cc7fda76
This series provides various fixes for VDUSE reconnection
introduced in -rc1, some of them being reported by
Coverity.
The series also takes the opportunity to refactor
reconnection to make it more self-contained to simplify
readability and error path handling.
Maxime Coquelin (6):
vhost: fix
This patch fixes missing error handling in checking the
reconnect log version, and takes the opportunity to move
all the checks into a dedicated function to simply VDUSE
device creation code.
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxim
This patch moves the VDUSE reconnection log mapping and
setup after the Vhost device is created in order to
simplify the device creation and its error path.
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 120 +-
1 file changed, 55 insertions
This patch moves the VDUSE reconnection log mapping, as
well as creation if needed, into a dedicated function.
This is a preliminary rework to simplify VDUSE device
creation.
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 138 +-
1 file
This patch fixes a FD leak in the VDUSE device reconnect
code fails to start the device.
Also take the opportunity to refactor the related code into
a dedicated function.
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
---
lib/vhost/vd
This patch fixes missing reconnection log unmapping
miss in the error path at VDUSE creation time.
Coverity issue: 445525
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 24 +---
1 file c
This patch fixes a possible TOCTOU on the VDUSE
device chardev opening at device creation time.
Coverity issue: 445526
Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
Signed-off-by: Maxime Coquelin
---
lib/vhost/vduse.c | 34 --
1 fi
al Message-----
From: Maxime Coquelin
Sent: Monday, October 21, 2024 8:06 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; Vargas, Hernan
Subject: Re: [PATCH v1 1/2] baseband/acc: FFT support in VRB2 PRQ device
Hi,
On 10/18/24 20:42, Chautru, Nicolas wrote:
Hi Maxime,
---
Hi,
On 10/18/24 20:42, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Friday, October 18, 2024 12:54 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; Vargas, Hernan
Subject: Re: [PATCH v1 1/2] baseband/acc: FFT support in VRB2 PRQ
= 0;
}
+ /* Force saturation to 6 bits LLR. */
+ fcw->saturate_input = 1;
+
fcw->tb_crc_select = 0;
if (check_bit(op->ldpc_dec.op_flags, RTE_BBDEV_LDPC_CRC_TYPE_24A_CHECK))
fcw->tb_crc_select = 2;
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
Hi Nicolas,
On 10/15/24 00:30, Nicolas Chautru wrote:
Supporting recent change in the device to
extend FFT capability processing in latest stepping.
Also including cosmetic change to VRB2 register definition.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.h | 2 +-
dr
lib/vhost/rte_vdpa.h | 17 -
1 file changed, 17 deletions(-)
Good catch!
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 10/9/24 16:50, Stephen Hemminger wrote:
On Wed, 9 Oct 2024 10:58:03 +0200
Maxime Coquelin wrote:
+fixup_includes()
+{
+ local path=$1
+
+ sed -i -E -e '
+ s/([[:space:](])(__user|__force|__iomem)[[:space:]]/\1/g
+ s/__attribute_const__([[:space:]]|$)
On 10/9/24 15:00, Maxime Coquelin wrote:
This patch promotes the rte_vhost_driver_set_max_queue_num
API to stable.
Signed-off-by: Maxime Coquelin
---
lib/vhost/rte_vhost.h | 4
lib/vhost/version.map | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
Applied to next-virtio
On 10/9/24 23:12, Hernan Vargas wrote:
This series targets 24.11.
v3: Updated code with community recommendations. Added 2 commits for rte_free
refactor and clean up of VRB1 capabilities.
v2: Rebased to the latest next-baseband-for-main which includes needed
rte_bbdev lib updates.
v1: It inc
: Maxime Coquelin
Maxime
pmd.c | 23 +++--
drivers/baseband/acc/rte_vrb_pmd.c| 48 +++
2 files changed, 39 insertions(+), 32 deletions(-)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
(-)
Reviewed-by: Maxime Coquelin
deletions(-)
Reviewed-by: Maxime Coquelin
insertions(+), 62 deletions(-)
Reviewed-by: Maxime Coquelin
_pmd.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
This patch promotes the rte_vhost_driver_set_max_queue_num
API to stable.
Signed-off-by: Maxime Coquelin
---
lib/vhost/rte_vhost.h | 4
lib/vhost/version.map | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
index 328281ba0f
This patch makes use of the imported VDUSE headers.
The VDUSE support is now systematically built on Linux
systems, even if the build system does not support its
ioctl().
Signed-off-by: Maxime Coquelin
---
lib/vhost/meson.build | 5 +
lib/vhost/vduse.c | 2 +-
lib/vhost/vduse.h
1 - 100 of 1372 matches
Mail list logo
