RE: [PATCH] maintainers: Adding new maintainer to Nvidia mlx5

2023-11-14 Thread Matan Azrad
From: Suanming Mou > > > Adding Dariusz Sosnowski as NVIDIA mlx5 maintainer. > > > > > > Signed-off-by: Maayan Kashani > > > > Welcome, Dariusz > > Acked-by: Viacheslav Ovsiienko > Acked-by: Suanming Mou Welcome Dariusz! Acked-by: Matan Azrad

RE: [PATCH 1/5] net/mlx5/hws: add support for matching on bth_a bit

2023-10-09 Thread Matan Azrad
> RTE_FLOW_ITEM_TYPE_IB_BTH matches an InfiniBand base transport header. > We extend the match on the acknowledgment bit (BTH_A). > > Signed-off-by: Itamar Gozlan Series-acked-by: Matan Azrad > --- > drivers/net/mlx5/hws/mlx5dr_definer.c | 12 ++-- >

RE: [PATCH v2] net/mlx5: support symmetric RSS hash function

2023-07-06 Thread Matan Azrad
ation. > > Signed-off-by: Xueming Li Acked-by: Matan Azrad

RE: [PATCH v2] net/mlx5: fix flow workspace destruction

2023-07-03 Thread Matan Azrad
> Signed-off-by: Gregory Etelson > Signed-off-by: Bing Zhao Acked-by: Matan Azrad

RE: [PATCH v2 0/9] crypto/mlx5: support AES-GCM

2023-06-20 Thread Matan Azrad
po here, it is v3 in fact. So I understand why the > cover-letter was > "missing". For v3 series: Series-acked-by: Matan Azrad

[PATCH] maintainers: add maintainers to Nvidia net mlx5

2023-05-17 Thread Matan Azrad
Add Ori Kam and Suanming Mou to the mainterners list of the Nvidia network mlx5 PMD. Signed-off-by: Matan Azrad --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8df23e5099..a5219926ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -864,6

RE: [v1 1/3] net/mlx5/hws: support dest root table action

2023-05-15 Thread Matan Azrad
From: Hamdan Igbaria > Add support for dest root table action creation. > This support will allow to redirect the packets to the kernel from non root > tables. > > Signed-off-by: Hamdan Igbaria > Reviewed-by: Alex Vesker Series-acked-by: Matan Azrad

RE: [PATCH] net/mlx5: fix CQEs dumping for Tx

2023-03-27 Thread Matan Azrad
. > > Fixes: 957e45fb7b ("net/mlx5: handle Tx completion with error") > Cc: sta...@dpdk.org > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH v3] net/mlx5: fix the sysfs port name translation

2023-03-27 Thread Matan Azrad
ady done in the NL message > handling. In the meanwhile, the possible incorrect line feed character is also > taken into consideration. > > Fixes: 654810b56828 ("common/mlx5: share Netlink commands") > Fixes: 420bbdae89f2 ("net/mlx5: fix host physical function representor > naming") > Cc: sta...@dpdk.org > > Signed-off-by: Bing Zhao Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: relax hws meter validation

2023-03-23 Thread Matan Azrad
_profile_get(). > Do not enforce the preallocation of meter profiles and policies. > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: reject flow template API reconfiguration

2023-03-19 Thread Matan Azrad
ate > data structure. On any subsequent call to rte_flow_configure(), the provided > configuration is compared against the stored configuration. > If both are equal, rte_flow_configure() reports a success and configuration is > unaffected. Otherwise, (-ENOTSUP) is returned. > > Signed-off-by: Dariusz Sosnowski Acked-by: Matan Azrad

RE: [PATCH 0/2] net/mlx5: fix representor matching

2023-03-19 Thread Matan Azrad
/nics/mlx5.rst | 3 +++ > drivers/net/mlx5/linux/mlx5_os.c | 16 > drivers/net/mlx5/mlx5_flow.c | 4 > drivers/net/mlx5/mlx5_flow_hw.c | 14 +- > 4 files changed, 32 insertions(+), 5 deletions(-) > Series-acked-by: Matan Azrad

RE: [v2 1/5] net/mlx5/hws: fix alias_rtc_0 print location in debug dump

2023-02-12 Thread Matan Azrad
Igbaria > --- > drivers/net/mlx5/hws/mlx5dr_debug.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Looks ok to me. Series-acked-by: Matan Azrad

RE: [v2 00/16] net/mlx5/hws: support range and partial hash matching

2023-02-06 Thread Matan Azrad
net/mlx5/hws: rename pattern cache object > net/mlx5/hws: cache definer for reuse Series-acked-by: Matan Azrad > drivers/common/mlx5/mlx5_prm.h | 53 +- > drivers/net/mlx5/hws/mlx5dr.h | 6 +- > drivers/net/mlx5/hws/mlx5dr_cmd.c | 72 ++- > drivers/

RE: [PATCH] net/mlx5: check compressed CQE opcode for an error

2023-02-06 Thread Matan Azrad
uot;) > Cc: sta...@dpdk.org > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: ignore non-critical syndromes for Rx queue

2023-02-06 Thread Matan Azrad
USH_ERR. > Do not initiate a Rx queue reset in any other cases. > Skip all non-critical error CQEs and continue with packet processing. > > Fixes: 88c0733535 ("net/mlx5: extend Rx completion with error handling") > Cc: sta...@dpdk.org > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: fix error CQE dumping for vectorized Rx burst

2023-02-06 Thread Matan Azrad
/mlx5: extend Rx completion with error handling") > Cc: sta...@dpdk.org > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH] net/mlx5/hws: fix memory leak on general pool db init

2023-01-26 Thread Matan Azrad
From: Alex Vesker > On elemend db init we allocated the element_manager which was unused > and not freed. > > Fixes: b4dd7bcb0dcbe ("net/mlx5/hws: add pool and buddy") > Signed-off-by: Alex Vesker > Reviewed-by: Erez Shitrit Acked-by: Matan Azrad

RE: [PATCH v2] net/mlx5: add stub functions to null drv ops

2022-12-29 Thread Matan Azrad
virtual function without basing > the > decision on a specific drv type. > > Signed-off-by: Asaf Penso Acked-by: Matan Azrad

RE: [PATCH] net/mlx5/hws: fix incorrect dw_8_6_ext PRM offset

2022-12-12 Thread Matan Azrad
off-by: Alex Vesker > Reviewed-by: Erez Shitrit Acked-by: Matan Azrad

RE: [PATCH] common/mlx5: improve AES-XTS tweek capability check

2022-12-07 Thread Matan Azrad
th all the devices. > > Signed-off-by: Suanming Mou Acked-by: Matan Azrad

[PATCH] doc: improve event core description in vDPA mlx5

2022-11-13 Thread Matan Azrad
: Matan Azrad --- doc/guides/vdpadevs/mlx5.rst | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst index 9767fbe42d..3b5ce6df38 100644 --- a/doc/guides/vdpadevs/mlx5.rst +++ b/doc/guides/vdpadevs/mlx5.rst @@ -86,8

RE: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables

2022-11-09 Thread Matan Azrad
ed. > > Erez Shitrit (2): > net/mlx5/hws: fix order of destroying default tables > net/mlx5/hws: fix disconnecting matcher > > drivers/net/mlx5/hws/mlx5dr_matcher.c | 35 > +++ > drivers/net/mlx5/hws/mlx5dr_table.c | 2 +- > 2 f

RE: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled

2022-11-06 Thread Matan Azrad
e6ae ("app/testpmd: add host shaper command") > Cc: sta...@dpdk.org > > Signed-off-by: Spike Du Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: fix shared Rx queue config reuse

2022-11-06 Thread Matan Azrad
5: support shared Rx queue") > > Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad

RE: [PATCH] net/mlx5/hws: remove deprecated rte_atomic

2022-11-02 Thread Matan Azrad
> The use of rte_atomic functions is deprecated and is not required in HWS > code. HWS refcounts are used only during control and always under lock. > > Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") > Signed-off-by: Alex Vesker Acked-by: Matan Azrad

RE: [PATCH] net/mlx5: enable flow aging action

2022-10-31 Thread Matan Azrad
> As the queue-based aging API has been integrated[1], the flow aging action > support in HWS steering code can be enabled now. > > [1]: > https://patchwork.dpdk.org/project/dpdk/cover/20221026214943.3686635- > 1-michae...@nvidia.com/ > > Signed-off-by: Suanming Mou Acked-by: Matan Azrad

RE: [PATCH v2 2/2] common/mlx5: move Meson config initialization and check

2022-10-30 Thread Matan Azrad
t the top of > net/mlx5/hws/meson.build so HWS requirements are in the right context. > > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko Acked-by: Matan Azrad

RE: [PATCH v2 1/2] common/mlx5: fix build disabling

2022-10-30 Thread Matan Azrad
s, so it will allow using > the > variable mlx5_config in future. > > Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") > > Reported-by: Andrew Rybchenko > Signed-off-by: Thomas Monjalon > Tested-by: Andrew Rybchenko Acked-by: Matan Azrad

RE: [dpdk-dev] [PATCH 1/1] net/mlx5: fix memory leak when releasing a drop action

2022-07-31 Thread Matan Azrad
Hi Yunjian From: Yunjian Wang > When the memory for hrxq->action is allocated in mlx5_devx_hrxq_new(). Memory -> resources .. are > But it was not being freed when the drop action was released in > mlx5_devx_drop_action_destroy(). These cause a memory leak. > > Fixes: bc5bee028ebc ("net/mlx5: c

RE: [PATCH v2] doc: announce transition to vDPA device name function

2022-07-13 Thread Matan Azrad
ryptodev_sym_session`` and >``rte_cryptodev_asym_session`` to remove unnecessary indirection between > session and the private data of session. An opaque pointer can be exposed > -- > 2.36.1 Acked-by: Matan Azrad

RE: [PATCH v2] common/mlx5: fix non-expandable global MR cache

2022-07-04 Thread Matan Azrad
From: Dmitry Kozlyuk > Sent: Thursday, June 30, 2022 1:08 AM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; sta...@dpdk.org; Matan > Azrad ; Slava Ovsiienko > Subject: [PATCH v2] common/mlx5: fix non-expandable global MR cache > > The number of memory regions (MR) that

RE: [PATCH] vdpa/mlx5: fix leak on event thread creation

2022-07-03 Thread Matan Azrad
e. > Stick to a correct use of the API. > > Fixes: 5cf3fd3af4df ("vdpa/mlx5: add CPU core parameter to bind polling > thread") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Acked-by: Matan Azrad Thanks David!

RE: [PATCH 1/3] vdpa/mlx5: remove unnecessary null check

2022-06-23 Thread Matan Azrad
From: Stephen Hemminger > Found by nullfree.cocci. > > Signed-off-by: Stephen Hemminger Acked-by: Matan Azrad

RE: [PATCH] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed

2022-06-22 Thread Matan Azrad
Hi I put here again the comment the putted on another version of this commit. I saw it is already integrated but still not in master. But please look. From: Maxime Coquelin > Hi newsky647, > > On 6/12/22 16:09, 835703...@qq.com wrote: > > From: newsky647 <835703...@qq.com> > > > > After functi

RE: [PATCH v7] app/testpmd: add Host Shaper command

2022-06-15 Thread Matan Azrad
ilable > descriptor threshold event. > > Signed-off-by: Spike Du Acked-by: Matan Azrad

RE: [PATCH V2] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed

2022-06-15 Thread Matan Azrad
Hi Shiqi From: 835703...@qq.com <835703...@qq.com> > From: Shiqi Liu <835703...@qq.com> > > To Maxime, > I am so sorry too late to reply your comment.My name is Shiqi Liu. > I got stuck in how to reply the comment before.Now, it seenms to be > ok!Maybe there will be some mistakes I have taken ,

Re: [PATCH v5 1/7] net/mlx5: add LWM support for Rxq

2022-06-08 Thread Matan Azrad
Series-acked-by: Matan Azrad mailto:ma...@nvidia.com>> קבל ‏Outlook עבור Android‏<https://aka.ms/AAb9ysg> From: Spike Du Sent: Tuesday, June 7, 2022 3:59:36 PM To: Matan Azrad ; Slava Ovsiienko ; Ori Kam ; NBU-Contact-Thomas Monjalon (EX

RE: [PATCH] net/mlx5: fix linux stats gathering function

2022-06-02 Thread Matan Azrad
gt; using trash stats values. > > Fixes: 7ed15acdcd69 ("net/mlx5: improve xstats of bonding port") > Signed-off-by: Didier Pallard > Signed-off-by: Geoffrey Le Gourriérec > Acked-by: Matan Azrad

RE: [PATCH V5] net/mlx5: support ESP SPI match and RSS hash

2022-05-12 Thread Matan Azrad
by hashing SPI field. > > Signed-off-by: Raja Zidane Acked-by: Matan Azrad

RE: [PATCH V4] net/mlx5: support ESP SPI match and RSS hash

2022-05-11 Thread Matan Azrad
by hashing SPI field. > > Signed-off-by: Raja Zidane Acked-by: Matan Azrad

RE: [PATCH v7] net/bonding: another fix to LACP mempool size

2022-05-01 Thread Matan Azrad
Hi Ferruh, Gaoxiang From: Ferruh Yigit > On 3/28/2022 4:16 PM, Gaoxiang Liu wrote: > > The following log message may appear after a slave is idle(or nearly > > idle) > > for a few minutes:"PMD: Failed to allocate LACP packet from pool". > > And bond mode 4 negotiation may fail. > > > > Problem:Wh

RE: [PATCH] net/mlx5: fix FD configuration for Rx interrupt

2022-03-14 Thread Matan Azrad
From: David Marchand > On Thu, Mar 10, 2022 at 6:04 PM Michael Baum > wrote: > > > > # strace -r -f ./dpdk-dir/v21.11/examples/dpdk-l3fwd-power > > > > --lcores > > > > 0@3,1@5 -a :82:00.0 --in-memory -- -p 0x1 -P --config '(0,0,1)' > > > > ... > > > > [pid 534983] 0.000348 epoll_wait(2

RE: [PATCH] net/mlx5: set correct CPU socket ID for mlx5_rxq_ctrl

2022-03-08 Thread Matan Azrad
ot created Interactive-mode > selected .. > Configuring Port 0 (socket 1) > Port 0: 0C:42:A1:ED:C1:20 > Configuring Port 1 (socket 1) > Port 1: 0C:42:A1:ED:C1:21 > Checking link statuses... > Done > > > Signed-off-by: Thinh Tran > Reviewed-by: David Christensen Acked-by: Matan Azrad

RE: [PATCH v1] net/mlx5: fix meter creation default state

2022-03-07 Thread Matan Azrad
ixes: 444320186393 ("net/mlx5: support meter creation with policy") > Cc: sta...@dpdk.org > Signed-off-by: Rongwei Liu Acked-by: Matan Azrad

Re: mlx5_pci Decompression Error

2022-03-06 Thread Matan Azrad
Hi Shafiqul Your compressed data for decompress OP doesn't include b-final bit in the last block. May point to memory issue: cutting/garbage... השג את ‏Outlook עבור Android‏ מאת: Shafiqul Abedin נשלח: יום חמישי, 3 במרץ 2022, 02:32 אל: d

RE: [PATCH v2 0/6] mlx5: external RxQ support

2022-02-24 Thread Matan Azrad
rect DevX flag updating. > - Improve explanations in doc and comments. > - Remove teatpmd part. > Series-acked-by: Matan Azrad > Michael Baum (6): > common/mlx5: consider local functions as internal > common/mlx5: glue device and PD importation > common/mlx5: add remote PD a

RE: mellanox connect x 5 drops when cache full

2022-01-20 Thread Matan Azrad
Hi Yaron Maybe the caching takes PCI bandwidth? Matan From: Yaron Illouz Sent: Wednesday, January 19, 2022 4:27 PM To: dev@dpdk.org Cc: Matan Azrad Subject: mellanox connect x 5 drops when cache full External email: Use caution opening links or attachments Hi I am using multiqueue with

RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

2022-01-18 Thread Matan Azrad
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 18, 2022 3:03 PM > To: Matan Azrad ; Raja Zidane ; > dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode > > External email: U

RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

2022-01-18 Thread Matan Azrad
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 18, 2022 2:28 PM > To: Matan Azrad ; Raja Zidane ; > dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode > > External email: U

RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

2022-01-18 Thread Matan Azrad
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 18, 2022 11:52 AM > To: Raja Zidane ; dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode > > External email: Use

RE: [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs

2021-12-08 Thread Matan Azrad
ng values to make it work looks like behavior change to me. The driver should not return an error - the driver should adjust to a legal value in case of illegal values by the user. It is documented in the devargs description. Not behavior change but a bug fix; previously, the adjustment may return an error(which is a bug) or cause unexpected behavior in the HW(which is an old FW bug). Now, no error, no unexpected behavior - bug should be fixed for any FW version. > This is more of a process question, than technical detail in the driver, so > @Luca, @Kevin, @Christian, can you please comment? I will follow your > suggestion. > > > >> > >> But I think it is wrong to backport the behavior change. > >> > >>> Signed-off-by: Michael Baum > >>> Acked-by: Matan Azrad > >>> --- > >

RE: [PATCH] net/mlx5: fix devargs validation for multiclass probe

2021-11-25 Thread Matan Azrad
t; Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Michael Baum > > Acked-by: Matan Azrad > > --- > > drivers/net/mlx5/mlx5.c | 68 > > ++--- > >

RE: [PATCH] common/mlx5: fix error handling in multi-class probe

2021-11-25 Thread Matan Azrad
evice and misses > > the newly probed classes. > > > > This patch removes the condition from the release function, and > > ensures that the caller function sends a more accurate parameter. > > > > Fixes: 8a41f4deccc3 ("common/mlx5: introduce layer for multiple class

RE: [PATCH] compress/mlx5: fix double close for context device

2021-11-25 Thread Matan Azrad
ta...@dpdk.org > > Signed-off-by: Michael Baum Acked-by: Matan Azrad

[PATCH] vdpa/mlx5: workaround queue stop with traffic

2021-11-22 Thread Matan Azrad
/mlx5: support close and config operations") Cc: sta...@dpdk.org Signed-off-by: Matan Azrad Acked-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c index

Re: [dpdk-dev] [PATCH v3 5/7] drivers/crypto: invoke probing finish function

2021-10-20 Thread Matan Azrad
khil Goyal Acked-by: Matan Azrad

Re: [dpdk-dev] [EXT] [PATCH V3] compress/mlx5: allow partial transformations support

2021-10-19 Thread Matan Azrad
ompress/decompress/dma support check to allow partial > > transformations. > > > > V2: fix checkpatch errors > > V3: rebase. > > > > ---mlx5: replaced hardware queue object > > > > Signed-off-by: Raja Zidane > > Acked-by: Matan Azrad > >

Re: [dpdk-dev] [PATCH v2 0/6] Support MLX5 crypto driver on Windows

2021-10-17 Thread Matan Azrad
t; drivers/crypto/virtio/meson.build| 6 ++ > drivers/crypto/zuc/meson.build | 6 ++ > 24 files changed, 126 insertions(+), 18 deletions(-) > Series-acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: fix max Rx packet length

2021-10-12 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > On 10/10/2021 7:30 AM, Matan Azrad wrote: > > > > Hi Ferruh > > > > From: Ferruh Yigit > >> There is a confusion on setting max Rx packet length, this patch aims > >> to clarify it. > >> > >&g

Re: [dpdk-dev] [PATCH v2] ethdev: remove deprecated shared counter attribute

2021-10-11 Thread Matan Azrad
From: Andrew Rybchenko > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko > Acked-by: Thomas Monjalon > Acked-by: Ajit Khaparde > Acked-by: Somnath Kotur > Acked-by: Ori Kam Acked-by: Matan Azrad for mlx5.

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: fix max Rx packet length

2021-10-10 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit > There is a confusion on setting max Rx packet length, this patch aims to > clarify it. > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > 'uint32_t max_rx_pkt_len' field of the config struct 'struct > rte_eth_conf'. > > Also 'rte_eth_dev_set_mtu()

Re: [dpdk-dev] [PATCH v5 4/6] ethdev: remove jumbo offload flag

2021-10-10 Thread Matan Azrad
yev > Signed-off-by: Ferruh Yigit > Acked-by: Andrew Rybchenko > Reviewed-by: Rosen Xu > Acked-by: Somnath Kotur Acked-by: Matan Azrad For mlx4/5 PMDs.

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated shared counter attribute

2021-10-06 Thread Matan Azrad
Hi Andrew Thank you for the big effort to adjust mlx5. I left some comments inside. If you feel it is too much, we can do a later patch to improve. Matan > From: Andrew Rybchenko > Indirect actions should be used to do shared counters. > > Signed-off-by: Andrew Rybchenko > --- > app/test-pmd

Re: [dpdk-dev] [PATCH v23 2/6] dmadev: add control plane function support

2021-10-05 Thread Matan Azrad
Hi Chengwen API looks good to me, thanks! I have some questions below. > This patch add control plane functions for dmadev. > > +/** > + * DMA transfer direction defines. > + * > + * @see struct rte_dma_vchan_conf::direction */ enum rte_dma_direction > +{ > + /** DMA transfer direction

[dpdk-dev] [PATCH] cryptodev: extend data-unit length field

2021-10-04 Thread Matan Azrad
todev: support multiple cipher data-units") [2] commit 9a5c09211b3a ("doc: announce extension of crypto data-unit length") Signed-off-by: Matan Azrad --- app/test/test_cryptodev_blockcipher.h | 2 +- doc/guides/rel_notes/deprecation.rst | 4 --- doc/guides/rel_notes/re

Re: [dpdk-dev] [PATCH v6 2/2] ethdev: change queue release callback

2021-10-03 Thread Matan Azrad
t; - queue release callbacks are changed to use queue ID > - all drivers are adapted > > Signed-off-by: Xueming Li > Reviewed-by: Andrew Rybchenko Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release

2021-09-29 Thread Matan Azrad
uble release may cause a crash. > > By setting the tables pointer to NULL as done for other resources, the double > release and crash could be solved. > > Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion") > Cc: ma...@mellanox.com > Cc: sta...@dpdk.org > > Signed-off-by: Bing Zhao Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] compress/mlx5: fix QP setup error flow

2021-09-01 Thread Matan Azrad
From: Michael Baum > Sent: Tuesday, August 31, 2021 11:40 PM > To: dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: [PATCH] compress/mlx5: fix QP setup error flow > > The QP setup function allocates buffer for its opaque MR and register it into > MR structu

Re: [dpdk-dev] [PATCH] crypto/mlx5: support timestamp format

2021-09-01 Thread Matan Azrad
t; > Signed-off-by: Michael Baum Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] regex/mlx5: fix RegEx probing error flow

2021-09-01 Thread Matan Azrad
t combined rule file") > Cc: sta...@dpdk.org > > Signed-off-by: Michael Baum Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 0/6] mlx5: some independent fixes

2021-09-01 Thread Matan Azrad
drivers/net/mlx5/mlx5.c | 4 +++- > drivers/net/mlx5/mlx5.h | 1 + > 4 files changed, 34 insertions(+), 12 deletions(-) Series-acked-by: Matan Azrad > -- > 2.25.1

Re: [dpdk-dev] [PATCH v2 4/4] cryptodev: expose driver interface as internal

2021-08-11 Thread Matan Azrad
From: Akhil Goyal > The rte_cryptodev_pmd.* files are for drivers only and should be private to > DPDK, and not installed for app use. > > Signed-off-by: Akhil Goyal Please consider adding to release notes. Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs

2021-08-11 Thread Matan Azrad
hil Goyal Look's like it should be backported to stable releases with a Fixes reference. What do you think? Besides, Acked-by: Matan Azrad > --- > examples/fips_validation/fips_dev_self_test.c | 19 ++- > examples/fips_validation/main.c | 7 ++-

Re: [dpdk-dev] [PATCH v2 2/4] cryptodev: change valid dev API

2021-08-11 Thread Matan Azrad
From: Akhil Goyal > The API rte_cryptodev_pmd_is_valid_dev, can be used by the application as > well as PMD to check whether the device is valid or not. Hence, _pmd is > removed from the API. > The applications and drivers which use this API are also updated. > > Signed-off-by: Akhil Goyal Ag

Re: [dpdk-dev] [PATCH v2 1/4] test/crypto: remove illegal header include

2021-08-11 Thread Matan Azrad
From: Akhil Goyal > rte_cryptodev_pmd.h is an interface between driver and library and it is > mentioned in the file that application cannot use it directly. > Hence, removing the include. > > Signed-off-by: Akhil Goyal Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] net/mlx5: fix matching on eCPRI

2021-08-10 Thread Matan Azrad
;eth / end". Implicitly add Ethernet type condition, so > that "eth / ecpri / end" behaves as "eth type is 0xAEFE / end". > > Fixes: daa38a8924a0 ("net/mlx5: add flow translation of eCPRI header") > Cc: bi...@nvidia.com > Cc: sta...@dpdk.org > > Signed-off-by: Dmitry Kozlyuk Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v3 3/5] vdpa/mlx5: fix minsize build

2021-08-09 Thread Matan Azrad
~~~^~~~~ > > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad Thanks

Re: [dpdk-dev] [PATCH v2] doc: announce restructuring of crypto session structs

2021-08-08 Thread Matan Azrad
library hidden from the user. > > Signed-off-by: Akhil Goyal Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] maintainers: update for net mlx4/mlx5

2021-08-05 Thread Matan Azrad
From: Slava Ovsiienko > From: Shahaf Shuler > > For net/mlx4: > - removing Shahaf Shuler > - add Viacheslav Ovsiienko > > For net/mlx5: > - removing Shahaf Shuler > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad > ---

Re: [dpdk-dev] [PATCH] doc: announce cryptodev-PMD interface as internal

2021-08-04 Thread Matan Azrad
From: Ajit Khaparde > > The APIs which are internal to PMD and cryptodev library > > can be marked as internal so that ABI checking do not > > shout for changes in APIs which are internal to DPDK. > > > > Signed-off-by: Akhil Goyal > Acked-by: Ajit Khaparde Acked-by: Matan Azrad

[dpdk-dev] [PATCH 2/2] ethdev: announce moving to general modify function

2021-08-02 Thread Matan Azrad
rte_flow_action_modif_field DPDK added the ability to use the same function to modify any field, in addtion to be able to modify the value based on different field and not just immediate value. Signed-off-by: Ori Kam Acked-by: Matan Azrad --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH 1/2] ethdev: announce change to action modify data

2021-08-02 Thread Matan Azrad
From: Ori Kam In the current implementation, the action rte_flow_action_modify_field is not well defined for fields larger than 64 bits (for example IPv6 source) In addtion, the byte order is also not well defined. Both of those issue should be fixed. Signed-off-by: Ori Kam Acked-by: Matan

Re: [dpdk-dev] [PATCH] doc: announce extension of crypto data-unit length

2021-08-02 Thread Matan Azrad
> Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH] compress/mlx5: fix level translation in xform API

2021-08-01 Thread Matan Azrad
; Fixes: 39a2c8715f8f ("compress/mlx5: add transformation operations") > Cc: ma...@nvidia.com > Cc: sta...@dpdk.org > > Signed-off-by: Raja Zidane Congrats on your first patch, Raja! Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: fix typo in flow engine type

2021-07-28 Thread Matan Azrad
on name to include dv. > > Fixes: fa2d01c87d2 ("net/mlx5: support flow aging") > Cc: sta...@dpdk.org > > Signed-off-by: Asaf Penso Acked-by: Matan Azrad

[dpdk-dev] [PATCH v2] examples/l2fwd-crypto: support cipher multiple data-unit

2021-07-28 Thread Matan Azrad
: Matan Azrad --- v2: remove the feature patch reference. .../sample_app_ug/l2_forward_crypto.rst | 7 ++- examples/l2fwd-crypto/main.c | 61 +++ 2 files changed, 66 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/l2_forward_crypto.rst

Re: [dpdk-dev] Question about hardware error handling policy

2021-07-25 Thread Matan Azrad
Hi From: fengchengwen: > On 2021/7/22 23:46, Thomas Monjalon wrote: > > 22/07/2021 15:50, fengchengwen: > >> Hi, all > >> > >> I notice ethdev support dev_reset ops, which could be used to > >> recover from errors, and only 13+ drivers support this function. > >> And also there is event fo

Re: [dpdk-dev] imissed drop with mellanox connectx5

2021-07-22 Thread Matan Azrad
Hi Yaron Freeing mbufs from a different lcore than the original lcore allocated them causes cache miss in the mempool cache of the original lcore per mbuf allocation - all the time the PMD will get non-hot mbufs to work with. It can be one of the reasons for the earlier drops you see. Matan

Re: [dpdk-dev] [PATCH] net/mlx5: fix indexed pools allocate on Windows

2021-07-21 Thread Matan Azrad
r the Windows case too. > issue. > > Fixes: b4edeaf3efd5 ("net/mlx5: replace flow list with indexed pool") > > Signed-off-by: Suanming Mou Better title: net/mlx5/windows: fix indexed pools allocation Besides, Acked-by: Matan Azrad > --- > drivers/net/mlx5/windows/mlx5

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

2021-07-14 Thread Matan Azrad
From: Thomas Monjalon > 13/07/2021 15:42, Matan Azrad: > > Hi Thomas > > > > From: Thomas Monjalon > > > When registering a new event callback, if allocation fails, there is > > > no need for unregistering the callback, because it is not registered. &

Re: [dpdk-dev] [PATCH] ethdev: avoid unregistering a non-allocated callback

2021-07-13 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon > When registering a new event callback, if allocation fails, there is no need > for > unregistering the callback, because it is not registered. > > Fixes: 9ec0b3869d8d ("ethdev: allow event registration for all ports") > Cc: sta...@dpdk.org > > Signed-off-by: Th

Re: [dpdk-dev] [PATCH 0/2] fix RSS expansion missing items

2021-07-07 Thread Matan Azrad
From: Xiaoyu Min > This patch set fixs the missing items in RSS expansion. > > Xiaoyu Min (2): > net/mlx5: fix missing RSS expandable items > net/mlx5: fix missing RSS expansion of IPv6 frag > Series-acked -by: Matan Azrad > drivers/net/mlx5/mlx5_flow.c | 10

Re: [dpdk-dev] [PATCH 0/3] MPLS RSS fixs

2021-07-06 Thread Matan Azrad
PLS over IP > net/mlx5: fix MPLS RSS expansion > net/mlx5: limit inner RSS expansion for MPLS Series-acked by Matan Azrad > drivers/net/mlx5/mlx5_flow.c| 31 +-- > drivers/net/mlx5/mlx5_flow_dv.c | 3 --- > 2 files changed, 21 insertions(+), 13 deletions(-) > > -- > 2.32.0

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-06 Thread Matan Azrad
From: fengchengwen > On 2021/7/6 14:50, Matan Azrad wrote: > > Hi > > > > From: fengchengwen > >> On 2021/7/4 23:21, Matan Azrad wrote: > >>> > >>> > >>> From: Chengwen Feng > >>>> This patch introduces 'dma

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread Matan Azrad
Hi From: fengchengwen > On 2021/7/4 23:21, Matan Azrad wrote: > > > > > > From: Chengwen Feng > >> This patch introduces 'dmadevice' which is a generic type of DMA > >> device. > >> > >> The APIs of dmadev library exposes some

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-04 Thread Matan Azrad
From: Chengwen Feng > This patch introduces 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > Did you consider RTE_COMP_ALGO_NULL xform in compressdev library? >

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-07-04 Thread Matan Azrad
From: Havlík Martin > Dne 2021-06-23 09:04, Min Hu (Connor) napsal: > > 在 2021/6/22 17:25, Martin Havlik 写道: > >> When dedicated queues are enabled, mlx5 PMD fails to install RTE > >> Flows if the underlying ethdev is not started: > >> bond_ethdev_8023ad_flow_set(267) - bond_ethdev_8023ad_flow_se

Re: [dpdk-dev] [PATCH] net/mlx5: fix match MPLS over GRE with key

2021-07-01 Thread Matan Azrad
966138 / end actions queue index 1 / mark id 0xa / end > > Fixes: a7a0365565a4 ("net/mlx5: match GRE key and present bits") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH 1/3] regex/mlx5: fix memory region unregistration

2021-06-29 Thread Matan Azrad
From: Michael Baum > The issue can cause illegal physical address access while a huge-page A is > released and huge-page B is allocated on the same virtual address. > The old MR can be matched using the virtual address of huge-page B but the > HW will access the physical address of huge-page A w

  1   2   3   4   5   6   7   8   9   10   >