[PATCH] net/fm10k: fix cleanup during init failure

2024-04-03 Thread Julien Meunier
: a6061d9e7075 ("fm10k: register PF driver") Fixes: 4c287332c39a ("fm10k: add PF and VF interrupt handling") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- drivers/net/fm10k/fm10k_ethdev.c | 39 +++- 1 file changed, 33 insertions(+), 6 deleti

[dpdk-dev] [PATCH v2] net/ixgbe: fix RxQ/TxQ release

2021-09-28 Thread Julien Meunier
: c95584dc2b18 ("ixgbe: new vectorized functions for Rx/Tx") Cc: bruce.richard...@intel.com Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_c

Re: [dpdk-dev] [PATCH] net/ixgbe: fix RxQ/TxQ release

2021-09-28 Thread Julien Meunier
Hello, On 28/09/2021 05:21, Wang, Haiyue wrote: -Original Message- From: Wang, Haiyue Sent: Tuesday, September 28, 2021 11:06 To: 'Julien Meunier' ; dev@dpdk.org Cc: sta...@dpdk.org; Richardson, Bruce Subject: RE: [PATCH] net/ixgbe: fix RxQ/TxQ release -Original Message

[dpdk-dev] [PATCH] net/ixgbe: fix RxQ/TxQ release

2021-09-27 Thread Julien Meunier
: c95584dc2b18 ("ixgbe: new vectorized functions for Rx/Tx") Cc: bruce.richard...@intel.com Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v2] stack: fix reload head when pop fails

2021-09-21 Thread Julien Meunier
thout ever loading the new correct head. Fixes: 3340202f5954 ("stack: add lock-free implementation") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- v2: * rebase * update commit log + remove invalid CC email address lib/stack/rte_stack_lf_generic.h | 4 +++- 1 file changed, 3 inser

[dpdk-dev] [PATCH] stack: reload head when pop fails (generic)

2021-08-19 Thread Julien Meunier
thout ever loading the new correct head. Fixes: 3340202f5954 ("stack: add lock-free implementation") Cc: gage.e...@intel.com Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- lib/stack/rte_stack_lf_generic.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

2020-01-09 Thread Julien Meunier
ef09a28252c44cfe4ac6 Author: Fiona Trahe Date: Tue Sep 10 17:32:10 2019 +0100 crypto/qat: fix digest length in XCBC capability [ upstream commit 0996ed0d5ad65b6419e3ce66a420199c3ed45ca9 ] commit 8db57afd7ab9a3c12d73f1f5461415690b8c173c Author: Julien Meunier Date: Wed Oct 16

[dpdk-dev] [PATCH v3] cryptodev: fix check related to device id

2019-10-16 Thread Julien Meunier
ns a valid cryptodev is available. Also, remove max_devs field and use RTE_CRYPTO_MAX_DEVS in order to unify the code. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- v3: * Set rte_cryptodev_is_valid_d

[dpdk-dev] [PATCH v2] cryptodev: fix check related to device id

2019-10-15 Thread Julien Meunier
ns a valid cryptodev is available. Also, remove max_devs field and use RTE_CRYPTO_MAX_DEVS in order to unify the code. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- v2: * Restore nb_devs * Update

[dpdk-dev] [PATCH] cryptodev: fix pmd allocation on multi-process

2019-08-07 Thread Julien Meunier
Primary process is responsible to initialize the data struct of each crypto devices. Secondary process should not override this data during the initialization. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Juli

[dpdk-dev] [PATCH] cryptodev: fix invalid dev_id after a pmd close

2019-08-07 Thread Julien Meunier
le. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- lib/librte_cryptodev/rte_cryptodev.c | 42 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/

[dpdk-dev] [PATCH v3] test/pmd_perf: fix the way to drain the port

2019-02-20 Thread Julien Meunier
: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- v3: * add timeout on stop * add log details v2: * rename commit title * fix nb_free display --- test/test/test_pmd_perf.c | 13 + 1 file changed, 9 insert

[dpdk-dev] [PATCH v3 1/2] net/ixgbe: do not start on unsupported loopback mode

2019-02-20 Thread Julien Meunier
mode is correct for the current device, before starting it. If it is not valid, PMD will refuse to start. Signed-off-by: Julien Meunier --- v3: - code style + checkpatch compliance v2: - factorize code - check if loopback is really supported --- drivers/net/ixgbe/ixgbe_ethde

[dpdk-dev] [PATCH v3 2/2] net/ixgbe: add support of loopback for X540/X550

2019-02-20 Thread Julien Meunier
Loopback mode is also supported on X540 and X550 NICs, according to their datasheet (section 15.2). The way to set it up is a little different of the 82599. Signed-off-by: Julien Meunier --- v3: - reorganize and merge common code - restore MACC_FLU on stop v2: - disable / enable autoneg when

[dpdk-dev] [PATCH 2/2] net/ixgbe: add support of loopback for X540/X550

2019-02-07 Thread Julien Meunier
Loopback mode is also supported on X540 and X550 NICs, according to their datasheet (section 15.2). The way to set it up is a little different of the 82599. Signed-off-by: Julien Meunier --- v2: - disable / enable autoneg when loopback is requested for X540 / X550 --- drivers/net/ixgbe/base

[dpdk-dev] [PATCH 1/2] net/ixgbe: do not start on unsupported loopback mode

2019-02-07 Thread Julien Meunier
mode is correct for the current device, before starting it. If it is not valid, PMD will refuse to start. Signed-off-by: Julien Meunier --- v2: - factorize code - check if loopback is really supported --- drivers/net/ixgbe/ixgbe_ethdev.c | 13 + drivers/net/ixgbe/ixgbe_rxtx.

[dpdk-dev] [PATCH v2] test/pmd_perf: fix the way to drain the port

2019-02-03 Thread Julien Meunier
: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- v2: * rename commit title * fix nb_free display --- test/test/test_pmd_perf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test/test_pm

[dpdk-dev] [PATCH] net/ixgbe: add support of loopback for X540/X550

2019-01-02 Thread Julien Meunier
Loopback mode is also supported on X540 and X550 NICs, according to their datasheet (section 15.2). The way to set it up is a little different of the 82599. Signed-off-by: Julien Meunier --- drivers/net/ixgbe/ixgbe_ethdev.c | 10 ++--- drivers/net/ixgbe/ixgbe_ethdev.h | 5 ++--- drivers

[dpdk-dev] [PATCH] net/fm10k: initialize sm_down variable

2019-01-02 Thread Julien Meunier
Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 85fb6c

[dpdk-dev] [PATCH] test/pmd_perf: change the way to drain the port

2019-01-02 Thread Julien Meunier
: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Julien Meunier --- test/test/test_pmd_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test/test_pmd_perf.c b/test/test/test_pmd_perf.c index f5095c

[dpdk-dev] [PATCH] net/fm10k: add imissed stats

2018-09-10 Thread Julien Meunier
Add support of imissed and q_errors statistics, reported by PCIE_QPRDC register (see datasheet, section 11.27.2.60), which exposes the number of receive packets dropped for a queue. Signed-off-by: Julien Meunier --- drivers/net/fm10k/fm10k_ethdev.c | 7 +-- 1 file changed, 5 insertions

[dpdk-dev] [PATCH] i40e: configure MTU

2016-04-27 Thread Julien Meunier
onfigure rxq here ? All these operations are already done when you call i40e_dev_rx_init. i40e_dev_rx_init => i40e_rx_queue_init (for each queue) => i40e_rx_queue_config => redefine rxq->max_pkt_len Moreover, you should move dev_data->dev_conf.rxmode.max_rx_pkt_len out of the loop. frame_size is the same for all rx_queues. -- Julien MEUNIER 6WIND

[dpdk-dev] i40e: cannot change mtu to enable jumbo frame

2016-02-12 Thread Julien Meunier
On 02/10/2016 04:20 PM, Zhang, Helin wrote: > > >> -Original Message----- >> From: Julien Meunier [mailto:julien.meunier at 6wind.com] >> Sent: Wednesday, February 10, 2016 12:36 AM >> To: Zhang, Helin ; dev at dpdk.org >> Subject: i40e: cannot change mtu to

[dpdk-dev] i40e: cannot change mtu to enable jumbo frame

2016-02-10 Thread Julien Meunier
o the --max-pkt-len command-line option. > > > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Julien Meunier > Sent: Tuesday, February 9, 2016 9:36 AM > To: Zhang, Helin ; dev at dpdk.org > Subject: [dpdk-dev] i40e: cannot change mtu to en

[dpdk-dev] i40e: cannot change mtu to enable jumbo frame

2016-02-09 Thread Julien Meunier
eveloped soon in order to support jumbo frame ? Regards, -- Julien MEUNIER 6WIND

[dpdk-dev] [PATCH v3] i40e: fix vlan filtering

2016-02-04 Thread Julien Meunier
restore default behavior, if HW VLAN filtering is activated, set a filter to match MAC and VLAN. If not, set a filter to only match MAC. Signed-off-by: Julien Meunier --- Changes since v2: - switch log level from INFO to ERR in case of failure Changes since v1: - use ether_addr_copy() for mac

[dpdk-dev] [PATCH v2] i40e: fix vlan filtering

2016-02-03 Thread Julien Meunier
-Original Message- >> From: Julien Meunier [mailto:julien.meunier at 6wind.com] >> Sent: Tuesday, February 2, 2016 9:51 PM >> To: Zhang, Helin >> Cc: dev at dpdk.org >> Subject: [PATCH v2] i40e: fix vlan filtering >> >> VLAN filtering was always perfor

[dpdk-dev] [PATCH v2] i40e: fix vlan filtering

2016-02-02 Thread Julien Meunier
restore default behavior, if HW VLAN filtering is activated, set a filter to match MAC and VLAN. If not, set a filter to only match MAC. Signed-off-by: Julien Meunier --- Changes since v1: - use ether_addr_copy() for mac copy - add more debug messages in case of failure - update all existing

[dpdk-dev] [PATCH] i40e: fix vlan filtering

2016-01-20 Thread Julien Meunier
, On 01/20/2016 06:00 AM, Zhang, Helin wrote: >> -Original Message- >> From: Julien Meunier [mailto:julien.meunier at 6wind.com] >> Sent: Tuesday, January 19, 2016 1:19 AM >> To: Zhang, Helin >> Cc:dev at dpdk.org >> Subject: [PATCH] i40e: fix vlan filte

[dpdk-dev] [PATCH] i40e: fix vlan filtering

2016-01-18 Thread Julien Meunier
restore default behavior, if HW VLAN filtering is activated, set a filter to match MAC and VLAN. If not, set a filter to only match MAC. Signed-off-by: Julien Meunier Signed-off-by: David Marchand --- drivers/net/i40e/i40e_ethdev.c | 39 ++- drivers/net/i40e