Hi Nicolas,
I spoke with the code author and this file was not intended to be upstreamed.
It will be removed in V2.
-John
> On Oct 26, 2022, at 7:22 PM, Chautru, Nicolas
> wrote:
>
> Hi John,
>
>> -Original Message-
>> From: John Miller > <m
Add ark baseband device to build system.
Signed-off-by: John Miller
---
drivers/baseband/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
index 686e98b2ed..084ff46155 100644
--- a/drivers/baseband/meson.build
+++ b
This patch introduces the Arkville baseband device driver build files.
Signed-off-by: John Miller
---
drivers/baseband/ark/meson.build | 11 +++
drivers/baseband/ark/version.map | 3 +++
2 files changed, 14 insertions(+)
create mode 100644 drivers/baseband/ark/meson.build
create mode
This patch introduces the Arkville baseband device driver common functions.
Signed-off-by: John Miller
---
drivers/baseband/ark/ark_bbdev_common.c | 109
drivers/baseband/ark/ark_bbdev_common.h | 100 ++
2 files changed, 209 insertions(+)
create
This patch introduces the Arkville baseband device driver custom functions.
Signed-off-by: John Miller
---
drivers/baseband/ark/ark_bbdev_custom.c | 201
drivers/baseband/ark/ark_bbdev_custom.h | 30
2 files changed, 231 insertions(+)
create mode 100644 drivers
This patch introduces the Arkville baseband device driver.
Signed-off-by: John Miller
---
drivers/baseband/ark/ark_bbdev.c | 1127 ++
drivers/baseband/ark/ark_bbext.h | 163 +
2 files changed, 1290 insertions(+)
create mode 100644 drivers/baseband/ark
Added ark PMD log interface for use in arkville devices.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 86 ---
drivers/net/ark/ark_ethdev_logs.c | 8 +++
drivers/net/ark/ark_ethdev_logs.h | 25 +
drivers/net/ark/ark_ethdev_rx.c | 36
Some HW variants support sr-iov, add this to the device
capabilities record.
Signed-off-by: John Miller
---
drivers/common/ark/ark_common.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/common/ark/ark_common.h b/drivers/common/ark/ark_common.h
index
Update the version map file with new common functions.
Signed-off-by: John Miller
---
drivers/common/ark/version.map | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/common/ark/version.map b/drivers/common/ark/version.map
index 74d9f4b668..64d78cff24
Add __rte_internal to all internal functions
Signed-off-by: John Miller
---
drivers/common/ark/ark_ddm.h | 8
drivers/common/ark/ark_mpu.h | 8 +++-
drivers/common/ark/ark_rqp.h | 3 +++
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/common/ark/ark_ddm.h b
Add common ark to build system.
Signed-off-by: John Miller
---
drivers/common/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/common/meson.build b/drivers/common/meson.build
index ea261dd70a..5514f4ba83 100644
--- a/drivers/common/meson.build
+++ b/drivers/common
Remove build files moved to common.
Signed-off-by: John Miller
---
drivers/net/ark/meson.build | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ark/meson.build b/drivers/net/ark/meson.build
index 8d87744c22..c48044b8ee 100644
--- a/drivers/net/ark
Add common ark files to drivers/common directory in
preparation to support Arkville baseband device.
Signed-off-by: John Miller
---
drivers/common/ark/ark_common.c | 9
drivers/common/ark/ark_common.h | 47
drivers/common/ark/meson.build | 19 +++
drivers/common/ark
Create a common directory in drivers/common and move common
ark files to prepare support for Arkville baseband device.
Signed-off-by: John Miller
---
MAINTAINERS | 1 +
drivers/{net => common}/ark/ark_ddm.c | 2 +-
drivers/{net => common}/ark/ark
baseband PMD,
including documentation.
Finally we modify the build system to support the changes.
Signed-off-by: John Miller
---
doc/guides/bbdevs/ark.rst | 52 +++
1 file changed, 52 insertions(+)
create mode 100644 doc/guides/bbdevs/ark.rst
diff --git a
Repair meson dependency format.
Signed-off-by: John Miller
---
drivers/net/ark/meson.build | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ark/meson.build b/drivers/net/ark/meson.build
index 8d87744c22..c48044b8ee 100644
--- a/drivers/net/ark
Add ark baseband device to build system.
Signed-off-by: John Miller
---
drivers/baseband/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
index 686e98b2ed..084ff46155 100644
--- a/drivers/baseband/meson.build
+++ b
Add ark baseband user extensions.
Signed-off-by: John Miller
---
drivers/baseband/ark/ark_bbdev.c| 146 +++--
drivers/baseband/ark/ark_bbdev_common.h | 8 ++
drivers/baseband/ark/ark_bbext.h| 163
3 files changed, 306 insertions(+), 11
Add Atomic Rules ARK baseband device.
Signed-off-by: John Miller
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4716c92e78..380dd204a6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1330,6 +1330,13 @@ F: drivers/baseband/la12xx/
F
Added ark PMD log interface for use in arkville devices.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 93 ---
drivers/net/ark/ark_ethdev_logs.c | 7 +++
drivers/net/ark/ark_ethdev_logs.h | 25 +
drivers/net/ark/ark_ethdev_rx.c | 40
Add new ark baseband device.
Signed-off-by: John Miller
---
drivers/baseband/ark/ark_bbdev.c| 1064 +++
drivers/baseband/ark/ark_bbdev_common.c | 125 +++
drivers/baseband/ark/ark_bbdev_common.h | 92 ++
drivers/baseband/ark/ark_bbdev_custom.c | 201
Add common ark to build system.
Signed-off-by: John Miller
---
drivers/common/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/common/meson.build b/drivers/common/meson.build
index ea261dd70a..5514f4ba83 100644
--- a/drivers/common/meson.build
+++ b/drivers/common
Add common ark files to drivers/common directory in
preparation to support Arkville baseband device.
Signed-off-by: John Miller
---
drivers/common/ark/ark_common.c | 7 ++
drivers/common/ark/ark_common.h | 48 ++
drivers/common/ark/meson.build | 13
drivers/common/ark
Create a common directory in drivers/common and move common
ark files to prepare support for Arkville baseband device.
Signed-off-by: John Miller
---
MAINTAINERS | 1 +
drivers/{net => common}/ark/ark_ddm.c | 2 +-
drivers/{net => common}/ark/ark
baseband PMD,
including documentation.
Finally we modify the build system to support the changes.
Signed-off-by: John Miller
---
doc/guides/bbdevs/ark.rst | 54 +++
1 file changed, 54 insertions(+)
create mode 100644 doc/guides/bbdevs/ark.rst
diff --git a
Added support for packet generation in
multi-port Arkville implementations. The packet
generator is a singleton within the device but is
capable of generating packets for any port within
one device.
Signed-off-by: John Miller
---
v2:
- Incorporated changes from Ferruh's comments.
---
dr
Added support for packet generation in
multi-port Arkville implementations. The packet
generator is a singleton within the device but is
capable of generating packets for any port within
one device.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 4 +++-
drivers/net/ark
Add memory write barriers for read and wait status functions
in ddm, udm and mpu.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ddm.c | 1 +
drivers/net/ark/ark_mpu.c | 1 +
drivers/net/ark/ark_udm.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/net/ark/ark_ddm.c b/drivers
Added software register writes for hw optimization and
performance fixes.
Signed-off-by: John Miller
---
drivers/net/ark/ark_udm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ark/ark_udm.c b/drivers/net/ark/ark_udm.c
index cb3cf5c941..9ebed89627 100644
--- a/drivers/net
Add support for chunk DMA transfers.
Chunk mpu transfer use 64 objects (512 byte) to maintain memory
read alignment.
Align mpu memory allocation to be at 512 byte boundaries.
Reduce force-close allocation from 1 objects to 64 objects.
Signed-off-by: John Miller
---
drivers/net/ark
Configuration status updates for internal packet checker and
generator.
Signed-off-by: John Miller
---
drivers/net/ark/ark_pktchkr.c | 2 +-
drivers/net/ark/ark_pktgen.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ark/ark_pktchkr.c b/drivers/net/ark
Added arbitrary mbuf size per queue capability.
Updated ARK_UDM_CONST3 value to reflect the version number
read from the HW that is required to support this change.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c| 8
drivers/net/ark/ark_ethdev_rx.c | 23
Add two new supported device ID's.
Add documentation for new devices.
Signed-off-by: John Miller
---
v3:
- Split patch and added documentation
---
doc/guides/nics/ark.rst | 2 ++
drivers/net/ark/ark_ethdev.c | 4
2 files changed, 6 insertions(+)
diff --git a/doc/guides/nics/ar
Add a device capabilities record for supported features.
Certain variants require that PCIe read-requests be correctly
throttled. This is called "rqpacing" in Arkville, and has to do
with credit and flow control on certain Arkville implementations.
Signed-off-by: John Miller
---
v2:
memory write barriers for read and wait status functions
in ddm, udm and mpu.
Configuration status updates for internal packet checker and
generator.
Signed-off-by: John Miller
---
v2:
- Added more details to the git log.
---
drivers/net/ark/ark_ddm.c | 1 +
drivers/net/ark/ark_ethdev_rx.c
Added arbitrary mbuf size per queue capability.
Updated ARK_UDM_CONST3 value to reflect the version number
read from the HW that is required to support this change.
Signed-off-by: John Miller
---
v2:
- Added more details to the git log.
---
drivers/net/ark/ark_ethdev.c| 8
Add a device capabilities record for supported features.
Certain variants require that PCIe read-requests be correctly
throttled. This is called "rqpacing" in Arkville, and has to do
with credit and flow control on certain Arkville implementations.
Signed-off-by: John Miller
---
v2:
for read and wait status functions
in ddm, udm and mpu.
- Configuration status updates for internal packet checker and generator.
---
Signed-off-by: John Miller
---
drivers/net/ark/ark_ddm.c | 1 +
drivers/net/ark/ark_ethdev_rx.c | 16 +---
drivers/net/ark/ark_mpu.c
---
v2:
Added arbitrary mbuf size per queue capability.
Updated ARK_UDM_CONST3 value to reflect the version number
read from the HW that is required to support this change.
---
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c| 8
drivers/net/ark/ark_ethdev_rx.c | 23
---
v2:
Certain variants require that PCIe read-requests be correctly
throttled. This is called "rqpacing" in Arkville, and has to do
with credit and flow control on certain Arkville implementations.
Improved code readability and comments.
---
Signed-off-by: John Miller
---
drive
Add support for chunk DMA transfers.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ddm.c | 1 +
drivers/net/ark/ark_ethdev_rx.c | 16 +---
drivers/net/ark/ark_mpu.c | 1 +
drivers/net/ark/ark_pktchkr.c | 2 +-
drivers/net/ark/ark_pktgen.c| 2 +-
drivers
publish rte_pmd_ark.h for external access to extension
Signed-off-by: John Miller
---
doc/guides/nics/ark.rst | 4 ++--
drivers/net/ark/meson.build | 2 ++
drivers/net/ark/{ark_ext.h => rte_pmd_ark.h} | 8 ++--
3 files changed, 10 insertions(+)
Support arbitrary mbuf size per queue.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c| 8
drivers/net/ark/ark_ethdev_rx.c | 23 +++
drivers/net/ark/ark_udm.h | 2 +-
3 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/drivers
Add static record of supported device capabilities.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 58 +---
1 file changed, 48 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index b618cba3f0
/* First port is already allocated by DPDK */
> eth_dev = ark->eth_dev;
> + rte_eth_dev_probing_finish(eth_dev);
> continue;
> }
>
> --
> 2.7.4
>
Acked-by: John Miller mailto:john.mil...@atomicrules.com>>
Hello,
We have been testing the dpdk-17.11-rc1 candidate on our Ubuntu platforms. We
just tried to compile it on one of our CentOS platform and get this error.
== Build lib/librte_eal/linuxapp/igb_uio
CC [M]
/projects/dpdk/dpdk-17.11-rc1/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.
Hello,
Is there a release candidate available for 17.11 ?I could not find a tag in
the dpdk-next-net repo.
Thank you,
-John
Change loop counter that should be based on the number
of rx queues, not tx queues. This only affects debug
output.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark
Repairs a bug in the stats_reset where the wrong queue was
being passed into tx reset.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 5733ba3
Allows a user extension to set a callback for the set_mtu
operation.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 19 +++
drivers/net/ark/ark_ext.h| 4
drivers/net/ark/ark_global.h | 1 +
3 files changed, 24 insertions(+)
diff --git a/drivers/net/ark
RTE_MAX_ETHPORTS in the arkville structure and
are indexed by port_id in the PMD. The motivation for this change is that
users of the arkville PMD extension have a unique pointer per port rather
then one per function.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 51
v2:
* Split the user extension private data per port patch and the
set_mtu patch into separate patches.
* Add better description to per port private data patch
* stats_reset patch untouched from V1
John Miller (3):
net/ark: allow unique user data for each port in extension calls
net/ark
Repairs a bug in the stats_reset where the wrong queue was
being passed into tx reset.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 55e6b24
Provide unique user data pointer in the extension calls for
each port.
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 71 +---
drivers/net/ark/ark_ext.h| 4 +++
drivers/net/ark/ark_global.h | 5 ++--
3 files changed, 60 insertions
Coverity issue: 144517
Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville")
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index f8fb35
Coverity issue: 144514
Fixes: 727b3fe292bc ("net/ark: integrate PMD")
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 995c93d..9143
Coverity issue: 144520
Fixes: 727b3fe292bc ("net/ark: integrate PMD")
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 9143fc4..f8fb
Coverity issue: 144512
Coverity issue: 144513
Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and
pktgen")
Signed-off-by: John Miller
---
drivers/net/ark/ark_pktchkr.c | 2 +-
drivers/net/ark/ark_pktgen.c | 2 +-
2 files changed, 2 insertions(+), 2 deletion
Hi Ferruh,
Thank you for your review.
I will create a new patchset for these fixes with all of the changes you
requested.
-John
> On May 12, 2017, at 7:11 AM, Ferruh Yigit wrote:
>
> On 5/11/2017 12:02 PM, John Miller wrote:
>> Fixes: 9c7188a68d7b ("net/ark: provide API
Coverity issue: 144512
Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville")
Coverity issue: 144517
Fixes: 727b3fe292bc ("net/ark: integrate PMD")
Coverity issue: 144520
Signed-off-by: John Miller
---
drivers/net/ark/ark_ethdev.c | 18 --
drive
Coverity issue: 1428042
Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville")
Signed-off-by: Ferruh Yigit
Acked-by: John Miller mailto:john.mil...@atomicrules.com>>
"net/ark: stub PMD for Atomic Rules Arkville")
>
> Signed-off-by: Bruce Richardson
Thanks Bruce.
Acked-by: John Miller mailto:john.mil...@atomicrules.com>>
> On Apr 11, 2017, at 11:41 AM, Ed Czeck wrote:
>
> Expose additional fpga status registers.
> Report hardware status during PMD init.
>
> Signed-off-by: Ed Czeck
Acked-by: John Miller mailto:john.mil...@atomicrules.com>>
We are seeing an issue when running from the head of the master branch in
dpdk-next-net and building with CONFIG_RTE_BUILD_SHARED_LIB=y. When we run
testpmd using -d to point to our PMD we get this error
EAL: Error - exiting with code: 1
Cause: Creation of mbuf pool for socket 0 failed: In
> Signed-off-by: Ed Czeck
Acked-by: John Miller mailto:john.mil...@atomicrules.com>>
65 matches
Mail list logo
