Hi Ferruh,
Thank you for your review.
I will create a new patchset for these fixes with all of the changes you
requested.
-John
> On May 12, 2017, at 7:11 AM, Ferruh Yigit <ferruh.yi...@intel.com> wrote:
>
> On 5/11/2017 12:02 PM, John Miller wrote:
>> Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and
>> pktgen")
>> Coverity issue: 144513
>>
>> Fixes: 727b3fe292bc ("net/ark: integrate PMD")
>> Coverity issue: 144514
>>
>> Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and
>> pktgen")
>> Coverity issue: 144512
>>
>> Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville")
>> Coverity issue: 144517
>
> The convention is Coverity line first, Fixes line later.
>
>>
>> Fixes: 727b3fe292bc ("net/ark: integrate PMD")
>> Coverity issue: 144520
>
> Hi John,
>
> Thanks for fixing coverity issues.
>
> Can you please split patch into a patchset with multiple patches,
> grouped to same kind of fixes?
>
> And instead of having "coverity fix" in patch title, can you please
> describe what is really fixed, like "fix not null terminated buffer" or
> "fix missing function return check" etc ...
>
> Thanks,
> ferruh
>
>> Signed-off-by: John Miller <john.mil...@atomicrules.com>
>
> <...>
>
>> --- a/drivers/net/ark/ark_pktgen.c
>> +++ b/drivers/net/ark/ark_pktgen.c
>> @@ -354,7 +354,8 @@ struct OPTIONS {
>> o->v.INT = atoll(val);
>> break;
>> case OTSTRING:
>> - strncpy(o->v.STR, val, ARK_MAX_STR_LEN);
>> + strncpy(o->v.STR, val, ARK_MAX_STR_LEN - 1);
>> + o->v.STR[ARK_MAX_STR_LEN - 1] = 0;
>
> This also works, but you can prefer to switch snprintf(), which
> guaranties the null termination.
>
>> break;
>> }
>> return 1;
>>
>
