"first public release")
Cc: sta...@dpdk.org
Signed-off-by: Thomas Monjalon
Acked-by: Ajit Khaparde
Acked-by: Bruce Richardson
Acked-by: Andrew Rybchenko
---
app/test-pmd/parameters.c | 35 ---
1 file changed, 8 insertions(+), 27 deletions(-)
Thank you Thomas!
Reviewed-by: Jens Freimann
regards,
Jens
-
1 file changed, 1 insertion(+), 2 deletions(-)
looks good to me.
Reviewed-by: Jens Freimann
regards,
Jens
: Honnappa Nagarahalli
Reviewed-by: Ruifeng Wang
---
app/test-pmd/noisy_vnf.c | 12
1 file changed, 12 insertions(+)
Reviewed-by: Jens Freimann
regards,
Jens
On Mon, Jun 17, 2019 at 09:09:59AM +, Zhang, Roy Fan wrote:
Hi Jens,
You are right. Sorry the code wasn't cleaned up properly in the first place.
Do you want me to send a v2 with new title?
No it's fine for me :)
regards,
Jens
On Wed, Jun 05, 2019 at 12:00:38PM +0200, Maxime Coquelin wrote:
Head segment data_len field is wrongly summed with the length
of all the segments of the chain, whereas it should be the
length of of the first segment only.
s/of of/of/
Reviewed-by: Jens Freimann
regards,
Jens
On Fri, May 17, 2019 at 10:15:08AM +0200, David Marchand wrote:
We currently have no check on the mempool pointer passed to
rte_eth_rx_queue_setup.
Let's avoid a plain crash when dereferencing it.
Suggested-by: Jens Freimann
Signed-off-by: David Marchand
---
lib/librte_ethdev/rte_ethdev.
ample application")
Cc: sta...@dpdk.org
Signed-off-by: Fan Zhang
---
examples/vhost_crypto/main.c | 6 --
1 file changed, 6 deletions(-)
It really is unused.
Reviewed-by: Jens Freimann
;)
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Agree, the pointer is accessed before in the caller. That said, afaics the
pointer is never checked in rte_eth_rx_queue_setup() before it's
dereferenced...
Reviewed-by: Jens Freimann
r callbacks for socket open/close")
Cc: sta...@dpdk.org
Reported-by: David Marchand
Signed-off-by: Ilya Maximets
---
lib/librte_vhost/socket.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Jens Freimann
++-
1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Jens Freimann
is
not a valid index to look up device information any more. So, yes we
should destroy the device after the callback.
Reviewed-by: Jens Freimann
regards,
Jens
as it was for v1.
Reviewed-by: Jens Freimann
On Thu, Apr 04, 2019 at 05:03:43PM -0700, Stephen Hemminger wrote:
The function rte_vlan_insert may allocate a new buffer for the
vlan header and return a different mbuf than originally passed.
In this case, the stored mbuf in txm[] array could point to wrong
buffer.
Fixes: dd856dfcb9e7 ("virtio
++---
drivers/net/virtio/virtqueue.h | 4 ++--
5 files changed, 27 insertions(+), 22 deletions(-)
Reviewed-by: Jens Freimann
On Thu, Mar 21, 2019 at 02:45:20PM +0100, Maxime Coquelin wrote:
Most of 'virtqueue' struct fields are prefixed with 'vq_'.
This redundant, this patch removes them all.
Signed-off-by: Maxime Coquelin
---
Hi,
Following our discussions on removing the 'vq_' prefix, I did
the patch to see how it
On Tue, Mar 19, 2019 at 02:28:30PM +0100, Maxime Coquelin wrote:
On 3/19/19 11:09 AM, Tiwei Bie wrote:
On Tue, Mar 19, 2019 at 10:44:32AM +0100, Jens Freimann wrote:
On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote:
Put split ring and packed ring specific fields into separate
sub
On Tue, Mar 19, 2019 at 05:37:34PM +0800, Tiwei Bie wrote:
On Tue, Mar 19, 2019 at 09:54:03AM +0100, Jens Freimann wrote:
On Tue, Mar 19, 2019 at 02:43:06PM +0800, Tiwei Bie wrote:
> Cache the AVAIL, USED and WRITE bits to avoid calculating
> them as much as possible. Note that, the WRI
insertions(+), 26 deletions(-)
Looks good. How much do we gain by this?
Reviewed-by: Jens Freimann
, 43 insertions(+), 33 deletions(-)
Reviewed-by: Jens Freimann
(+), 2 deletions(-)
Reviewed-by: Jens Freimann
deletions(-)
Reviewed-by: Jens Freimann
-
7 files changed, 36 insertions(+), 40 deletions(-)
Reviewed-by: Jens Freimann
On Tue, Mar 19, 2019 at 02:43:07PM +0800, Tiwei Bie wrote:
Put split ring and packed ring specific fields into separate
sub-structures, and also union them as they won't be available
at the same time.
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 71 +--
On Tue, Mar 19, 2019 at 02:43:06PM +0800, Tiwei Bie wrote:
Cache the AVAIL, USED and WRITE bits to avoid calculating
them as much as possible. Note that, the WRITE bit isn't
cached for control queue.
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 35 ++
le changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jens Freimann
eds the maximum MTU supported by the device we remove
the VIRTIO_NET_F_MTU flag from requested features.
Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")
Cc: sta...@dpdk.org
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 6 ++
1 file changed, 6 insertions
o Chaudron
---
v2 - Removed configuration change that got included by accident
lib/librte_meter/rte_meter.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Jens Freimann
On Fri, Feb 01, 2019 at 05:27:37PM +0300, Ilya Maximets wrote:
On 01.02.2019 13:03, Jens Freimann wrote:
+ if (host_features & (1ULL << VIRTIO_NET_F_MTU)) {
+ uint32_t ether_hdr_len = ETHER_HDR_LEN + VLAN_TAG_LEN +
+ hw->v
fits into the MTU plus header. If yes we set the
offload flag.
2. VIRTIO_NET_F_MTU is not set. We can set the offload flag.
Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")
Cc: sta...@dpdk.org
Signed-off-by: Jens Freimann
---
v3->v4:
* make use of hw-max_mtu which is calcul
On Thu, Jan 31, 2019 at 02:01:53PM +0300, Ilya Maximets wrote:
On 31.01.2019 12:17, Jens Freimann wrote:
Port configuration fails because offload flags don't match the expected
value when max-pkt-len is set to a value that should enable receive port
offloading but doesn't.
There are
fits into the MTU plus header. If yes we set the
offload flag.
2. VIRTIO_NET_F_MTU is not set. We can set the offload flag.
Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")
Cc: sta...@dpdk.org
Signed-off-by: Jens Freimann
---
v2->v3:
* remove unnecessary brackets (Maxime
fits into the MTU plus header. If yes we set the offload flag.
2. VIRTIO_NET_F_MTU is not set. We can set the offload flag.
Fixes: a4996bd89c42 (""ethdev: new Rx/Tx offloads API)
Cc: sta...@dpdk.org
Signed-off-by: Jens Freimann
---
v1->v2:
* include virtnet hdr, ethernet header,
On Wed, Jan 30, 2019 at 04:41:55PM +0100, Maxime Coquelin wrote:
On 1/30/19 4:26 PM, Jens Freimann wrote:
Port configuration fails when offload flags don't match the expected
value, e.g. when max-pkt-len is set to a value that should enable
receive port offloading but doesn't.
T
flag.
2. VIRTIO_NET_F_MTU is not negotiated. We can set the offload flag.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 7c4c1df0
On Thu, Jan 24, 2019 at 07:59:00PM +0300, Ilya Maximets wrote:
Read barrier must be implied between reading descriptor flags
and descriptor id. Otherwise, in case of reordering, we could
read wrong descriptor id.
For the reference, similar barrier for split rings is the read
barrier between VIRT
On Thu, Jan 24, 2019 at 07:59:02PM +0300, Ilya Maximets wrote:
Read barrier is required between reading the flags (desc_is_used)
and the content of descriptor to ensure the ordering.
Otherwise, speculative read of desc.id could be reordered with
reading of the desc.flags.
Fixes: a76290c8f1cf ("n
("net/virtio: implement Rx path for packed queues")
Cc: sta...@dpdk.org
Signed-off-by: Ilya Maximets
---
drivers/net/virtio/virtio_rxtx.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Jens Freimann
Signed-off-by: Ilya Maximets
---
drivers/net/virtio/virtio_rxtx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Jens Freimann
Add support to virtio-user for control virtqueues.
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
.../net/virtio/virtio_user/virtio_user_dev.c | 102 --
.../net/virtio/virtio_user/virtio_user_dev.h | 15 ++-
drivers/net/virtio/virtio_user_ethdev.c | 56
state of the head descriptor.
Fixes: ec194c2 ("net/virtio: support packed queue in send command")
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 11 ++-
drivers/net/virtio/virtqueue.h | 10 --
2 files chang
ctly
* add to unsupported_features when packed_vq is 0
Jens Freimann (2):
net/virtio: check head desc with correct wrap counter
net/virtio-user: ctrl vq support for packed
drivers/net/virtio/virtio_ethdev.c| 11 +-
.../net/virtio/virtio_user/virtio_user_dev.c | 102 --
state of the head descriptor.
Fixes: ec194c2 ("net/virtio: support packed queue in send command")
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 11 ++-
drivers/net/virtio/virtqueue.h | 10 --
2 files changed, 14 insertions(+), 7 deletions(-
Add support to virtio-user for control virtqueues.
Signed-off-by: Jens Freimann
---
.../net/virtio/virtio_user/virtio_user_dev.c | 104 --
.../net/virtio/virtio_user/virtio_user_dev.h | 15 ++-
drivers/net/virtio/virtio_user_ethdev.c | 56 +-
3 files changed
sed index to virtio_user code
* tested wrap around of ring
v1->v2:
* split into two patches
* handle ring wrap correctly
* add to unsupported_features when packed_vq is 0
Jens Freimann (2):
net/virtio: check head desc with correct wrap counter
net/virtio-user: ctrl vq support for packed
d
On Thu, Jan 10, 2019 at 03:23:29PM +0100, Maxime Coquelin wrote:
On 1/10/19 2:17 PM, Jens Freimann wrote:
Add support to virtio-user for control virtqueues.
Signed-off-by: Jens Freimann
---
.../net/virtio/virtio_user/virtio_user_dev.c | 92 ++-
.../net/virtio/virtio_user
On Thu, Jan 10, 2019 at 10:40:25PM +0800, Tiwei Bie wrote:
On Thu, Jan 10, 2019 at 02:17:51PM +0100, Jens Freimann wrote:
This reverts commit 5e4e7a7524a30c176bd6b1789ab30963f27f2681.
Not a clean revert, I had to resolve a conflict due to
616ea5519 net/virtio-user: fix packed vq option
Revert patch to error out when cq is used with packed vq and
in second patch add support for packed virtqueues in control
virtqueue code.
v1->v2:
* split into two patches
* handle ring wrap correctly
* add to unsupported_features when packed_vq is 0
Jens Freimann (2):
net/virtio-u
This reverts commit 5e4e7a7524a30c176bd6b1789ab30963f27f2681.
Not a clean revert, I had to resolve a conflict due to
616ea5519 net/virtio-user: fix packed vq option parsing
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 11 +++
1 file changed, 3
Add support to virtio-user for control virtqueues.
Signed-off-by: Jens Freimann
---
.../net/virtio/virtio_user/virtio_user_dev.c | 92 ++-
.../net/virtio/virtio_user/virtio_user_dev.h | 8 +-
drivers/net/virtio/virtio_user_ethdev.c | 49 +-
3 files changed, 141
On Thu, Jan 10, 2019 at 09:46:37AM +0100, Maxime Coquelin wrote:
Hi Jens,
On 1/9/19 5:59 PM, Jens Freimann wrote:
Add support to virtio-user for control virtqueues
and reverts commit "5e4e7a752 net/virtio-user: fail if
cq used with packed vq".
I would prefer you send two patches:
1
Add support to virtio-user for control virtqueues
and reverts commit "5e4e7a752 net/virtio-user: fail if
cq used with packed vq".
Signed-off-by: Jens Freimann
---
.../net/virtio/virtio_user/virtio_user_dev.c | 111 --
.../net/virtio/virtio_user/virtio_user_de
red memory).
This is a RFC because it only supports in-order use of descriptors
in the ring. I'm looking for ideas how to change this without the
.next field in the descriptor as we have it with split virtqueues.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c
Accounting of bytes was moved to a common function, so at the moment we do
it twice. This patches fixes it for sending packets with packed virtqueues.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_rxtx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/virtio
On Wed, Dec 19, 2018 at 10:26:10AM +, Gavin Hu (Arm Technology China) wrote:
-Original Message-
From: dev On Behalf Of Jens Freimann
Sent: Wednesday, December 19, 2018 5:25 PM
To: Maxime Coquelin
Cc: dev@dpdk.org; tiwei@intel.com; zhihong.w...@intel.com
Subject: Re: [dpdk
= &vq->vq_descx[idx];
+ dxp->cookie = (void *)cookie[i];
I think code is safe as it is, but should we check if cookie actually points to
something?
I tested this patch and saw the same performance improvement, so
Tested-by: Jens Freimann
Reviewed-by: Jens Freimann
regards,
Jens
On Tue, Dec 11, 2018 at 02:48:02PM +0100, Maxime Coquelin wrote:
Signed-off-by: Maxime Coquelin
---
drivers/net/virtio/virtio_rxtx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index eb891433e..e1c
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.h | 1 +
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio
Until we have support for control virtqueues let's disable it and
fail device initalization if specified as a parameter.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/driver
From: Yuanhan Liu
Add option to enable packed queue support for virtio-user
devices.
Signed-off-by: Yuanhan Liu
Reviewed-by: Maxime Coquelin
---
.../net/virtio/virtio_user/virtio_user_dev.c | 18 ++
.../net/virtio/virtio_user/virtio_user_dev.h | 2 +-
drivers/net/virtio/v
This implements the transmit path for devices with
support for packed virtqueues.
Signed-off-by: Jens Freiman
Signed-off-by: Tiwei Bie
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 56 ---
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/virtio/virtio_rxtx.c
Add and initialize descriptor data structures.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 32 --
drivers/net/virtio/virtio_ring.h | 28 ++
drivers/net/virtio
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_pci.h | 6 +++
drivers/net/virtio/virtqueue.h | 72 -
2 files changed, 76 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_pci.h | 1 +
drivers/net/virtio/virtio_ring.h | 30 ++
drivers/net/virtio/virtqueue.h | 6 ++
3 files changed, 37 insertions(+)
diff --git a/drivers/net/virtio
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 56 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
drivers/net/virtio/virtio_rxtx.c | 375 -
drivers/net
Use packed virtqueue format when reading and writing descriptors
to/from the ring.
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 96 ++
1 file changed, 96 insertions(+)
diff --git a/drivers/net/virtio
Add support to dump packed virtqueue data to the
VIRTQUEUE_DUMP() macro.
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtqueue.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
out-of-order
* fix check in virtqueue_xmit_cleanup_packed() to improve performance
v7->v8:
* move desc_is_used change to correct patch
* remove trailing newline
* correct xmit code, flags update and memory barrier
* move packed desc init to dedicated function, split
and packed variant
On Mon, Dec 17, 2018 at 05:52:08PM +0100, Maxime Coquelin wrote:
I think you meant control queue in the title?
On 12/14/18 4:59 PM, Jens Freimann wrote:
Until we have support for ctrl virtqueues let's disable it and
fail device initalization if specified as a parameter.
Signed-off-by:
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.h | 1 +
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/virtio_ethdev.h
index
Until we have support for ctrl virtqueues let's disable it and
fail device initalization if specified as a parameter.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/driver
Use packed virtqueue format when reading and writing descriptors
to/from the ring.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 90 ++
1 file changed, 90 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio
Add support to dump packed virtqueue data to the
VIRTQUEUE_DUMP() macro.
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtqueue.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
From: Yuanhan Liu
Add option to enable packed queue support for virtio-user
devices.
Signed-off-by: Yuanhan Liu
---
.../net/virtio/virtio_user/virtio_user_dev.c | 18 ++
.../net/virtio/virtio_user/virtio_user_dev.h | 2 +-
drivers/net/virtio/virtio_user_ethdev.c| 1
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 58 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
drivers/net/virtio/virtio_rxtx.c | 375 -
drivers/net/virtio/virtqueue.c | 43
This implements the transmit path for devices with
support for packed virtqueues.
Signed-off-by: Jens Freiman
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 57 ---
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/virtio/virtio_rxtx.c | 236 +
Add and initialize descriptor data structures.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 32 ++--
drivers/net/virtio/virtio_ring.h | 34 --
drivers/net/virtio/virtqueue.h | 2 +-
3
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_pci.h | 6 +++
drivers/net/virtio/virtqueue.h | 91 -
2 files changed, 95 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_pci.h | 1 +
drivers/net/virtio/virtio_ring.h | 30 ++
drivers/net/virtio/virtqueue.h | 6 ++
3 files changed, 37 insertions(+)
diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio
orrectly in case of out-of-order
* fix check in virtqueue_xmit_cleanup_packed() to improve performance
v7->v8:
* move desc_is_used change to correct patch
* remove trailing newline
* correct xmit code, flags update and memory barrier
* move packed desc init to dedicated function, split
On Thu, Dec 13, 2018 at 05:09:03PM +0100, Maxime Coquelin wrote:
On 12/13/18 1:34 PM, Jens Freimann wrote:
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtqueue.h | 72 +-
1 file changed
On Thu, Dec 13, 2018 at 05:38:02PM +0100, Maxime Coquelin wrote:
On 12/13/18 1:34 PM, Jens Freimann wrote:
This is a basic implementation of packed virtqueues as specified in the
Virtio 1.1 draft. A compiled version of the current draft is available
at https://github.com/oasis-tcs/virtio
On Thu, Dec 13, 2018 at 05:42:02PM +0100, Maxime Coquelin wrote:
It seems check-git-log.sh returns an error for this one.
On 12/13/18 1:34 PM, Jens Freimann wrote:
Until we have support for ctrl virtqueues let's disable it and
exit if specified as a parameter.
Signed-off-by: Jens Fre
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.h | 1 +
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/virtio_ethdev.h
index
Until we have support for ctrl virtqueues let's disable it and
exit if specified as a parameter.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/virtio
From: Yuanhan Liu
Add option to enable packed queue support for virtio-user
devices.
Signed-off-by: Yuanhan Liu
---
.../net/virtio/virtio_user/virtio_user_dev.c | 18 ++
.../net/virtio/virtio_user/virtio_user_dev.h | 2 +-
drivers/net/virtio/virtio_user_ethdev.c| 1
Use packed virtqueue format when reading and writing descriptors
to/from the ring.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 90 ++
1 file changed, 90 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 61 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
drivers/net/virtio/virtio_rxtx.c | 385 -
drivers/net/virtio/virtqueue.c | 22
Add support to dump packed virtqueue data to the
VIRTQUEUE_DUMP() macro.
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtqueue.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtqueue.h | 72 +-
1 file changed, 70 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ring.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h
index e155eb17d..9ab007c11 100644
--- a/drivers/net/virtio/virtio_ring.h
+++ b/drivers/net/virtio
nup_packed() to improve performance
v7->v8:
* move desc_is_used change to correct patch
* remove trailing newline
* correct xmit code, flags update and memory barrier
* move packed desc init to dedicated function, split
and packed variant
Jens Freimann (9):
net/virtio: vring init for packe
This implements the transmit path for devices with
support for packed virtqueues.
Signed-off-by: Jens Freiman
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 54 ---
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/virtio/virtio_rxtx.c | 235 +
Add and initialize descriptor data structures.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 36 +++---
drivers/net/virtio/virtio_pci.h| 7
drivers/net/virtio/virtio_ring.h | 60 ++
drivers/net
On Wed, Dec 05, 2018 at 12:28:27PM +0100, Maxime Coquelin wrote:
On 12/3/18 3:15 PM, Jens Freimann wrote:
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 61 +++--
drivers/net/virtio/virtio_ethdev.h | 5
On Mon, Dec 03, 2018 at 03:15:06PM +0100, Jens Freimann wrote:
This is a basic implementation of packed virtqueues as specified in the
Virtio 1.1 draft. A compiled version of the current draft is available
at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at
https://github.com/oasis
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.h | 1 +
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/virtio_ethdev.h
index
From: Yuanhan Liu
Add option to enable packed queue support for virtio-user
devices.
Signed-off-by: Yuanhan Liu
---
.../net/virtio/virtio_user/virtio_user_dev.c | 18 ++
.../net/virtio/virtio_user/virtio_user_dev.h | 2 +-
drivers/net/virtio/virtio_user_ethdev.c| 1
Use packed virtqueue format when reading and writing descriptors
to/from the ring.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 90 ++
1 file changed, 90 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 61 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
drivers/net/virtio/virtio_rxtx.c | 369 -
drivers/net/virtio/virtqueue.c | 22
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 2 +
drivers/net/virtio/virtqueue.h | 73 +-
2 files changed, 73 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio
1 - 100 of 390 matches
Mail list logo
