Hi David,
Thanks for the recommendation. In future, I will add a cover letter for a
long patch set.
If you want, I can submit the cover letter for this patch set too.
On Thu, Feb 18, 2021 at 2:59 PM David Marchand
wrote:
> On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq
> wrote:
> >
Short option "s" was passed to getopt_long function, while there was
no condition on this option.
Fixes: f5188211c7 ("examples/vhost_crypto: add sample application")
Cc: roy.fan.zh...@intel.com
Signed-off-by: Ibtisam Tariq
---
examples/vhost_crypto/main.c | 2 +-
1 file
: roy.fan.zh...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v4:
* Set indentation of preprocessor directives.
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from
: jiayu...@intel.com
Cc: huawei@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v4:
* Set indentation of preprocessor directives.
* Add enums for OPT_BUILTIN_NET_DRIVER and OPT_CLIENT in getopt_long.
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block
: step...@networkplumber.org
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v4:
* None.
v3:
* Remove str_is function.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1
: ian.be...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v4:
* Set indentation of preprocessor directives.
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum
: sergio.gonzalez.mon...@intel.com
Cc: phil.y...@arm.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v4:
* None.
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum
: konstantin.anan...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v4:
* Set indentation of preprocessor directives.
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD
: marko.kovace...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v4:
* Set indentation of preprocessor directives.
* Remove condition on question mark.
v3:
* None.
v2:
* Added parser_read_uint16 function to remove extra variable.
* Remove extra indentations.
* Remove extra
example,
>
What should I do for built_net_driver. The convention used in eal is the
2nd option.
On Mon, Dec 7, 2020 at 3:51 PM David Marchand
wrote:
> On Tue, Nov 24, 2020 at 1:35 PM Ibtisam Tariq
> wrote:
> > diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> &
Thank you for applying it.
On Fri, Nov 20, 2020 at 5:04 PM David Marchand
wrote:
> On Thu, Nov 5, 2020 at 9:54 AM David Marchand
> wrote:
> > On Mon, Nov 2, 2020 at 12:20 PM Ibtisam Tariq
> wrote:
> > >
> > > Add "--" and remove extra spaces in l3fwd
: roy.fan.zh...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
* Remove unused short options.
v1
: jiayu...@intel.com
Cc: huawei@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1:
* enhance
: step...@networkplumber.org
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v3:
* Remove str_is function.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1:
* enhance
: ian.be...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1:
* enhance getopt_long usage
: sergio.gonzalez.mon...@intel.com
Cc: phil.y...@arm.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1
: konstantin.anan...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v3:
* None.
v2:
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1:
* enhance getopt_long usage
: marko.kovace...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v3:
* None.
v2:
* Added parser_read_uint16 function to remove extra variable.
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Replace the pre-processor with actual value, if it
ity and consistency in
> > all examples.
> >
> > Bugzilla ID: 238
> > Cc: konstantin.anan...@intel.com
> >
> > Reported-by: David Marchand
> > Signed-off-by: Ibtisam Tariq
> > ---
> > v2
> > * Remove extra indentations.
> > * Remove extra block br
Yes, I will remove str_is function and submit the v3 of this patch soon.
On Sat, Nov 14, 2020 at 4:13 PM David Marchand
wrote:
> On Wed, Nov 11, 2020 at 9:17 AM Ibtisam Tariq
> wrote:
> >
> > Instead of using getopt_long return value, strcmp was used to
> > compare t
: jiayu...@intel.com
Cc: huawei@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v2
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1
* enhance getopt_long usage
: step...@networkplumber.org
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v2
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1
* enhance getopt_long usage
---
examples
: roy.fan.zh...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v2
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
* Remove unused short options
v1
* enhance getopt_long
: konstantin.anan...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v2
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1
* enhance getopt_long usage
---
examples
: ian.be...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v2
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1
* enhance getopt_long usage
---
.../performance-thread
: sergio.gonzalez.mon...@intel.com
Cc: phil.y...@arm.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v2
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Change enum names to start with OPT_ and remove KEYWORD from enum names.
v1
* enhance
: marko.kovace...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
v2:
* Added parser_read_uint16 function to remove extra variable.
* Remove extra indentations.
* Remove extra block brackets in switch statement.
* Replace the pre-processor with actual value, if it used once
Thanks for explaining. I got it.
I will submit the patches with new updates.
On Tue, Nov 10, 2020 at 1:23 PM David Marchand
wrote:
>
> On Tue, Nov 10, 2020 at 7:10 AM Ibtisam Tariq
> wrote:
> > IMHO, it cannot be moved to read_uint16 parser.
> > If we do, we can't
On Thu, Nov 5, 2020 at 1:59 PM David Marchand wrote:
>
> Hello Ibtisam,
>
> On Wed, Nov 4, 2020 at 11:00 AM Ibtisam Tariq
> wrote:
> > > + case MBUF_DATAROOM_KEYWORD_NUM:
> > > + {
> > > + uint32_t data_ro
break;
> + }
The type of env.mbuf_data_room is uint16_t and the temp variable type
is uint32_t. In my opinion, the temp variable size is bigger than
env.mbuf_data_room to handle overflow value.
--
- Ibtisam
On Mon, Nov 2, 2020 at 1:32 PM Ibtisam Tariq wrote:
>
>
The short option written for interactive mode is --i in usage of
this qos_sched example. Actually, it is -i.
Fixes: cfd5c971e5e ("examples/qos_sched: add stats")
Signed-off-by: Ibtisam Tariq
---
examples/qos_sched/args.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Add new line character(\n) in the usage of vhost_crypto example for
better readability
Fixes: 709521f4c2c ("examples/vhost_crypto: support multi-core")
Cc: roy.fan.zh...@intel.com
Signed-off-by: Ibtisam Tariq
---
examples/vhost_crypto/main.c | 2 +-
1 file changed, 1 insertion(+),
Add "--" and remove extra spaces in l3fwd-acl commands.
Fixes: d0dff9ba4 ("doc: sample application user guide")
Cc: bernard.iremon...@intel.com
Signed-off-by: Ibtisam Tariq
---
doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 8
1 file changed, 4 insert
Hi David,
Thank you for reviewing the patch. I will submit the v2 of the patchset
with new updates.
On Fri, Oct 30, 2020 at 3:07 AM David Marchand
wrote:
> Hello Ibtisam,
>
> On Thu, Oct 29, 2020 at 1:55 PM Ibtisam Tariq
> wrote:
> >
> > Instead of using getopt_long
Hi David,
Thank you for the update.
On Thu, Oct 29, 2020 at 6:16 PM David Marchand
wrote:
> Hello Ibtisam,
>
> On Thu, Oct 29, 2020 at 1:58 PM Ibtisam Tariq
> wrote:
> >
> > Instead of using getopt_long return value, strcmp was used to
> > compare the input par
uot;examples/tep_term: add tunnel filter type configuration")
Fixes: c6a0fb5f54 ("examples/tep_term: add encap/decap configuration")
Cc: jijiang@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/tep_termination/main.c | 341 ---
11a8 ("eal: rename lcore master and slave")
Cc: step...@networkplumber.org
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/qos_sched/args.c | 161 +++---
1 file changed, 99 insertions(+), 62 deletions(-)
diff --git a/examples/qos_sch
ot;)
Fixes: bde19a4d4b ("examples/vhost: rename --dev-basename to --socket-file")
Cc: jiayu...@intel.com
Cc: huawei@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/vhost/main.c | 264 +++---
1 file changed, 14
ation")
Cc: roy.fan.zh...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/vhost_crypto/main.c | 78 ++--
1 file changed, 49 insertions(+), 29 deletions(-)
diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/ma
d app")
Cc: ian.be...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
.../performance-thread/l3fwd-thread/main.c| 221 ++
1 file changed, 121 insertions(+), 100 deletions(-)
diff --git a/examples/performance-thread/l3fwd-thread/main.c
antin.anan...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/l3fwd-acl/main.c | 189 +++---
1 file changed, 97 insertions(+), 92 deletions(-)
diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
index 961594f5f..5c8de1
ot;)
Fixes: 016493307a ("examples/packet_ordering: add stats per worker thread")
Cc: sergio.gonzalez.mon...@intel.com
Cc: phil.y...@arm.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/packet_ordering/main.c | 32
1 file ch
FIPS application"}
Cc: marko.kovace...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/fips_validation/main.c | 241 +++-
1 file changed, 143 insertions(+), 98 deletions(-)
diff --git a/examples/fips_validation/main.c b/examples/fips_
Ok, thanks for the clarification.
On Tue, Jul 28, 2020 at 3:31 PM Bruce Richardson
wrote:
> On Tue, Jul 28, 2020 at 03:23:48PM +0500, Ibtisam Tariq wrote:
> > Hello.
> >
> > We have several targets in dpdk/config when compiling using MAKE. The
> > dpdk target for
Hello.
We have several targets in dpdk/config when compiling using MAKE. The
dpdk target format is ARCH-MACHINE-EXECENV-TOOLCHAIN where EXECENV can
be linux, linuxapp, freebsd and bsdapp. What is the difference between
linuxapp and linux?
It seems the same because they both have the same .config
When exiting the application, resources should be cleared.
Signed-off-by: Ibtisam Tariq
---
examples/l2fwd-crypto/main.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index
When exiting the application, resources should be cleared.
Signed-off-by: Ibtisam Tariq
---
examples/l2fwd-jobstats/main.c | 49 +-
1 file changed, 48 insertions(+), 1 deletion(-)
diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c
index
ned-off-by: Ibtisam Tariq
---
v4:
* None
v3:
* None
v2:
* Added fixed id in commit body
---
examples/ip_pipeline/parser.c | 189 +-
1 file changed, 3 insertions(+), 186 deletions(-)
diff --git a/examples/ip_pipeline/parser.c b/examples/ip_pipeline/parser.c
index
inet_pton4 and inet_pton6 was reimplemented. Replace implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
Cc: roy.fan.zh...@intel.com
Reported-by: David Marchand
Signed-off-b
inet_pton4 and inet_pton6 was reimplemented. Replace implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Fixes: 31ce8d888625 ("net/softnic: add command interface")
Cc: jasvinder.si...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibt
ned-off-by: Ibtisam Tariq
---
v3:
* None
v2:
* Added fixed id in commit body
---
examples/ip_pipeline/parser.c | 189 +-
1 file changed, 3 insertions(+), 186 deletions(-)
diff --git a/examples/ip_pipeline/parser.c b/examples/ip_pipeline/parser.c
index fb0769fe3.
inet_pton4 and inet_pton6 was reimplemented. Replace implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
Cc: roy.fan.zh...@intel.com
Reported-by: David Marchand
Signed-off-b
inet_pton4 and inet_pton6 was reimplemented. Replace implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Fixes: 31ce8d888625 ("net/softnic: add command interface")
Cc: jasvinder.si...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibt
Okay.
Thank you for clarification.
On Mon, Jul 6, 2020 at 1:26 PM Bruce Richardson
wrote:
>
> On Sun, Jul 05, 2020 at 03:27:30PM +0500, Ibtisam Tariq wrote:
> > Hey.
> >
> > I've tried to install a new copy of FreeBSD. But it can't find the
> > sys/epol
Hey.
I've tried to install a new copy of FreeBSD. But it can't find the
sys/epoll.h header file.
I have searched and sys/epoll.h is not available on FreeBSD.
The output of meson builds on FreeBSD.
--
Has header "sys/epoll.h" : NO
pton4 and inet_pton6 with libc inet_pton function
> >
> > Bugzilla ID: 365
> > Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
> > Cc: roy.fan.zh...@intel.com
> >
> > Reported-by: David Marchand
> > Signed-off-by: Ibtisam Tariq
&
ned-off-by: Ibtisam Tariq
---
v2:
* Add fixed id in commit body
---
examples/ip_pipeline/parser.c | 189 +-
1 file changed, 3 insertions(+), 186 deletions(-)
diff --git a/examples/ip_pipeline/parser.c b/examples/ip_pipeline/parser.c
index fb0769fe3..6ddf0bec4 10
inet_pton4 and inet_pton6 was reimplemented. Replace implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file")
Cc: roy.fan.zh...@intel.com
Reported-by: David Marchand
Signed-off-b
inet_pton4 and inet_pton6 was reimplemented. Replace implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Fixes: 31ce8d888625 ("net/softnic: add command interface")
Cc: jasvinder.si...@intel.com
Reported-by: David Marchand
Signed-off-by: Ibt
on function
> > Bugzilla ID: 365
>
> NACK
> After that patch ispec-secgw wouldn't even start.
> Next time before submitting a patch - spend some time to test it first.
>
> > Cc: dev@dpdk.org
> >
> > Reported-by: David Marchand
> &
inet_pton4 and inet_pton6 was reimplemented. Replacing implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Cc: dev@dpdk.org
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/ipsec-secgw/parser.c | 171
inet_pton4 and inet_pton6 was reimplemented. Replacing implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Cc: dev@dpdk.org
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
examples/ip_pipeline/parser.c | 189
inet_pton4 and inet_pton6 was reimplemented. Replacing implementation of
inet_pton4 and inet_pton6 with libc inet_pton function
Bugzilla ID: 365
Cc: dev@dpdk.org
Reported-by: David Marchand
Signed-off-by: Ibtisam Tariq
---
drivers/net/softnic/parser.c | 187
63 matches
Mail list logo
