RE: [PATCH v7 1/2] vfio: add get device info API

2023-11-28 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Mingjin Ye > Sent: Wednesday, November 22, 2023 3:53 PM > To: dev@dpdk.org > Cc: qiming.y...@intel.com; Mingjin Ye ; Anatoly > Burakov > Subject: [PATCH v7 1/2] vfio: add get device info API > > This patch adds an API to supp

Re: [PATCH v7 2/2] bus/pci: fix legacy device missing region info

2023-11-24 Thread Gupta, Nipun
On 11/22/2023 3:52 PM, Mingjin Ye wrote: If the legacy device in the primary process does not support mapping the io port bar, the secondary process needs to proactively get the device information and fil the region information. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel

Re: [PATCH v6] bus/pci: fix legacy device IO port map

2023-11-15 Thread Gupta, Nipun
On 11/14/2023 3:54 PM, Mingjin Ye wrote: When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye ---

Re: [PATCH v2 1/2] bus/cdx: add support for devices without MSI

2023-11-07 Thread Gupta, Nipun
On 11/3/2023 4:50 PM, Shubham Rohila wrote: From: Nikhil Agarwal Update the cleanup routine for cdx device to support device without MSI. Also, set vfio_dev_fd for such devices This fd can be used for BME reload operations. Signed-off-by: Nikhil Agarwal Signed-off-by: Shubham Rohila Ack

Re: [PATCH v2 2/2] bus/cdx: add bus master enable/disable APIs

2023-11-07 Thread Gupta, Nipun
On 11/3/2023 4:50 PM, Shubham Rohila wrote: Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to enable or disable bus master functionality for cdx devices. Signed-off-by: Shubham Rohila --- v2 - Fix indentations and alphabetical orderings. - Wrap checks in parenthesis for read

Re: [PATCH v2 1/2] bus/cdx: add support for devices without MSI

2023-11-06 Thread Gupta, Nipun
On 11/3/2023 4:50 PM, Shubham Rohila wrote: From: Nikhil Agarwal Update the cleanup routine for cdx device to support device without MSI. Also, set vfio_dev_fd for such devices This fd can be used for BME reload operations. Signed-off-by: Nikhil Agarwal Signed-off-by: Shubham Rohila ---

Re: [PATCH] Add bus master enable/disable APIs for CDX devices

2023-10-27 Thread Gupta, Nipun
On 10/26/2023 8:50 AM, Shubham Rohila wrote: Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to enable or disable bus master functionality for cdx devices. Signed-off-by: Shubham Rohila --- drivers/bus/cdx/bus_cdx_driver.h | 25 drivers/bus/cdx/cdx_vfio.c | 97 +++

Re: [PATCH v5] bus/pci: fix legacy device IO port map in secondary process

2023-10-27 Thread Gupta, Nipun
On 10/24/2023 7:30 AM, Wenwu Ma wrote: When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- v5:

Re: [PATCH v4] bus/pci: fix legacy device IO port map in secondary process

2023-10-18 Thread Gupta, Nipun
On 10/18/2023 3:35 PM, David Marchand wrote: On Mon, Oct 9, 2023 at 5:06 AM Ma, WenwuX wrote: From a pci bus API pov, nothing prevents a driver from mixing memory mapped with vfio and ioport resources (iow, calls to rte_pci_map_resource() and rte_pci_ioport_map()). IOW, it may not be the ca

Re: [PATCH v4] bus/pci: fix legacy device IO port map in secondary process

2023-09-04 Thread Gupta, Nipun
On 8/30/2023 10:37 AM, Wenwu Ma wrote: When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma Acked

Re: [PATCH v3] bus/pci: fix legacy device IO port map in secondary process

2023-08-27 Thread Gupta, Nipun
Hi Wenwu On 8/22/2023 7:48 AM, Wenwu Ma wrote: When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Please use 72 columns in the commit log Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc:

Re: [PATCH] bus/pci: fix legacy device IO port map in secondary process

2023-08-12 Thread Gupta, Nipun
Hi Wenwu, On 8/7/2023 7:28 AM, Wenwu Ma wrote: When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma -

Re: [PATCH v3] bus/cdx: provide driver flag for optional resource mapping

2023-07-11 Thread Gupta, Nipun
Please use 'in-reply-to' of the first submission when sending any subsequent patches. On 7/11/2023 11:21 AM, Abhijit Gangurde wrote: Provide driver flag which gives an option to map the cdx device resource before probing the device driver. Also, make rte_cdx_map_device() API as public to map de

Re: [PATCH v2 1/2] net/virtio: fix legacy device IO port map in secondary process

2023-07-07 Thread Gupta, Nipun
On 7/3/2023 3:01 PM, Xia, Chenbo wrote: +Nipun -Original Message- From: David Marchand Sent: Monday, July 3, 2023 4:58 PM To: Li, Miao Cc: dev@dpdk.org; sta...@dpdk.org; Maxime Coquelin ; Xia, Chenbo Subject: Re: [PATCH v2 1/2] net/virtio: fix legacy device IO port map in secondar

RE: [PATCH] bus/cdx: provide driver flag for optional resource mapping

2023-07-07 Thread Gupta, Nipun
> -Original Message- > From: Abhijit Gangurde > Sent: Monday, June 26, 2023 4:10 PM > To: Gupta, Nipun ; Agarwal, Nikhil > > Cc: dev@dpdk.org; david.march...@redhat.com; Yigit, Ferruh > ; Gangurde, Abhijit > Subject: [PATCH] bus/cdx: provide driver flag for o

Re: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Gupta, Nipun
On 7/4/2023 8:41 PM, Ding, Xuan wrote: Hi Nipun, -Original Message- From: Gupta, Nipun Sent: Tuesday, July 4, 2023 5:23 PM To: Ding, Xuan ; dev@dpdk.org; tho...@monjalon.net; Burakov, Anatoly ; Yigit, Ferruh ; David Marchand Cc: Agarwal, Nikhil ; He, Xingguang ; Ling, WeiX

Re: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Gupta, Nipun
On 7/4/2023 7:39 PM, Thomas Monjalon wrote: 04/07/2023 11:23, Gupta, Nipun: On 7/4/2023 1:36 PM, Ding, Xuan wrote: From: Gupta, Nipun From: Ding, Xuan From: Ding, Xuan From: Nipun Gupta Hi Xuan, Thanks for pointing out the issue and figuring out the patch which introduced this. If

Re: [PATCH] bus/cdx: provide driver flag for optional resource mapping

2023-07-04 Thread Gupta, Nipun
On 6/26/2023 4:09 PM, Abhijit Gangurde wrote: Provide driver flag which gives an option to map the cdx device resource before probing the device driver. Also, make rte_cdx_map_device() API as public to map device resource separately. Signed-off-by: Abhijit Gangurde --- drivers/bus/cdx/bus_

Re: [PATCH] vfio: do not coalesce DMA mappings

2023-07-04 Thread Gupta, Nipun
Hi Xuan, On 7/4/2023 1:36 PM, Ding, Xuan wrote: Hi Nipun, -Original Message- From: Gupta, Nipun Sent: Tuesday, July 4, 2023 2:54 PM To: Ding, Xuan ; dev@dpdk.org; tho...@monjalon.net; Burakov, Anatoly ; Yigit, Ferruh ; David Marchand Cc: Agarwal, Nikhil ; He, Xingguang ; Ling, WeiX

RE: [PATCH] vfio: do not coalesce DMA mappings

2023-07-03 Thread Gupta, Nipun
Hi Xuan, Please see inline. > -Original Message- > From: Ding, Xuan > Sent: Tuesday, July 4, 2023 10:43 AM > To: Gupta, Nipun ; dev@dpdk.org; > tho...@monjalon.net; Burakov, Anatoly ; Yigit, > Ferruh > Cc: Agarwal, Nikhil ; He, Xingguang > ; Ling, WeiX > Su

RE: [PATCH] bus/cdx: silence bus scan when CDX is unavailable

2023-06-09 Thread Gupta, Nipun
[Public] Acked-by: Nipun Gupta > -Original Message- > From: David Marchand > Sent: Friday, June 9, 2023 4:41 PM > To: dev@dpdk.org > Cc: Gupta, Nipun ; Agarwal, Nikhil > ; Yigit, Ferruh > Subject: [PATCH] bus/cdx: silence bus scan when CDX is unavailable > >

RE: [PATCH v5 3/5] eal/interrupts: add IRQ count in interrupt handle

2023-06-01 Thread Gupta, Nipun
> -Original Message- > From: Gupta, Nipun > Sent: Thursday, June 1, 2023 11:35 PM > To: David Marchand > Cc: dev@dpdk.org; tho...@monjalon.net; hka...@marvell.com; > anatoly.bura...@intel.com; step...@networkplumber.org; Yigit, Ferruh > ; Anand, Harpreet ; > Ag

RE: [PATCH v4 3/4] bus/cdx: add support for MSI

2023-05-24 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, May 24, 2023 4:37 PM > To: Gupta, Nipun > Cc: dev@dpdk.org; david.march...@redhat.com; Yigit, Ferruh > ; Anand, Harpreet ; > Agarwal, Nikhil > Subject: Re: [PA

RE: [PATCH v4 1/4] bus/cdx: introduce cdx bus

2023-05-24 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, May 24, 2023 4:45 PM > To: Gupta, Nipun > Cc: dev@dpdk.org; david.march...@redhat.com; Yigit, Ferruh > ; Anand, Harpreet ; > Agarwal, Nikhil > Subject: Re

RE: [PATCH v4 1/4] bus/cdx: introduce cdx bus

2023-05-09 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 9, 2023 12:25 PM > To: Gupta, Nipun ; dev@dpdk.org; > tho...@monjalon.net; david.march...@redhat.com > Cc: Yigit, Ferruh ; Anand, Harpreet > ; Agarwal, Nikhil > Su

RE: [PATCH v3 5/5] config/arm: add AMD CDX

2023-05-08 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Yigit, Ferruh > Sent: Monday, May 8, 2023 11:17 PM > To: Honnappa Nagarahalli ; Gupta, Nipun > ; dev@dpdk.org; tho...@monjalon.net; > david.march...@redhat.com; Ruifeng Wang > Cc: Anand, Harpreet ; A

RE: [PATCH v3 5/5] config/arm: add AMD CDX

2023-05-08 Thread Gupta, Nipun
> -Original Message- > From: Thomas Monjalon > Sent: Monday, May 8, 2023 4:14 PM > To: Yigit, Ferruh ; Gupta, Nipun > > Cc: dev@dpdk.org; david.march...@redhat.com; Anand, Harpreet > ; Agarwal, Nikhil > Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX

RE: [PATCH v3 5/5] config/arm: add AMD CDX

2023-05-08 Thread Gupta, Nipun
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, May 4, 2023 8:59 PM > To: Gupta, Nipun ; dev@dpdk.org; > tho...@monjalon.net; david.march...@redhat.com > Cc: Anand, Harpreet ; Agarwal, Nikhil > > Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX &

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-24 Thread Gupta, Nipun
> -Original Message- > From: Stephen Hemminger > Sent: Monday, April 24, 2023 9:41 PM > To: David Marchand > Cc: Burakov, Anatoly ; Gupta, Nipun > ; dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Agarwal, Nikhil > Subject: Re: [PATCH v2] vfio: do n

RE: [PATCH v2 5/6] bus: enable cdx bus

2023-04-16 Thread Gupta, Nipun
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 14, 2023 10:16 PM > To: Gupta, Nipun ; dev@dpdk.org; > tho...@monjalon.net; david.march...@redhat.com > Cc: Anand, Harpreet ; Agarwal, Nikhil > > Subject: Re: [PATCH v2 5/6] bus: enable cdx bus &

RE: [PATCH v2 3/6] bus/cdx: add support for MSI

2023-04-16 Thread Gupta, Nipun
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 14, 2023 10:15 PM > To: Gupta, Nipun ; dev@dpdk.org; > tho...@monjalon.net; david.march...@redhat.com > Cc: Anand, Harpreet ; Agarwal, Nikhil > > Subject: Re: [PATCH v2 3/6] bus/cdx: add support f

RE: [PATCH v2 1/6] bus/cdx: introduce cdx bus

2023-04-16 Thread Gupta, Nipun
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 14, 2023 10:15 PM > To: Gupta, Nipun ; dev@dpdk.org; > tho...@monjalon.net; david.march...@redhat.com > Cc: Anand, Harpreet ; Agarwal, Nikhil > > Subject: Re: [PATCH v2 1/6] bus/cdx: introduce cdx

RE: [PATCH 0/6] add support for CDX bus

2023-04-13 Thread Gupta, Nipun
> -Original Message- > From: Gupta, Nipun > Sent: Friday, April 7, 2023 1:00 PM > To: David Marchand > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Anand, Harpreet ; > Agarwal, Nikhil > Subject: Re: [PATCH 0/6] add support for CDX bus > > &g

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-11 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 11, 2023 8:43 PM > To: Burakov, Anatoly ; David Marchand > ; Gupta, Nipun > Cc: dev@dpdk.org; Yigit, Ferruh ; Agarwal, Nikhil > > Subject: Re: [PATCH v2] v

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-05 Thread Gupta, Nipun
[AMD Official Use Only - General] > -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, April 5, 2023 7:46 PM > To: Gupta, Nipun ; David Marchand > > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Agarwal, Nikhil > Subject: Re: [PATCH v

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-04 Thread Gupta, Nipun
Hi David, As the DPDK 23.03 release is out can we have a relook at this change? Thanks, Nipun > -Original Message- > From: Gupta, Nipun > Sent: Tuesday, February 7, 2023 2:27 PM > To: David Marchand ; > anatoly.bura...@intel.com > Cc: dev@dpdk.org; tho...@m

RE: [PATCH v2] vfio: do not coalesce DMA mappings

2023-02-07 Thread Gupta, Nipun
nal Message- > From: David Marchand > Sent: Thursday, February 2, 2023 4:19 PM > To: anatoly.bura...@intel.com; Gupta, Nipun > Cc: dev@dpdk.org; tho...@monjalon.net; Yigit, Ferruh > ; Agarwal, Nikhil > Subject: Re: [PATCH v2] vfio: do not coalesce DMA mappings > > Caution: T