> -----Original Message----- > From: Yigit, Ferruh <ferruh.yi...@amd.com> > Sent: Friday, April 14, 2023 10:16 PM > To: Gupta, Nipun <nipun.gu...@amd.com>; dev@dpdk.org; > tho...@monjalon.net; david.march...@redhat.com > Cc: Anand, Harpreet <harpreet.an...@amd.com>; Agarwal, Nikhil > <nikhil.agar...@amd.com> > Subject: Re: [PATCH v2 5/6] bus: enable cdx bus > > On 4/13/2023 2:27 PM, Nipun Gupta wrote: > > enable the compilation of cdx bus > > > > Signed-off-by: Nipun Gupta <nipun.gu...@amd.com> > > --- > > drivers/bus/meson.build | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build > > index 6d2520c543..a78b4283bf 100644 > > --- a/drivers/bus/meson.build > > +++ b/drivers/bus/meson.build > > @@ -3,6 +3,7 @@ > > > > drivers = [ > > 'auxiliary', > > + 'cdx', > > 'dpaa', > > 'fslmc', > > 'ifpga', > > Why not squash this to the first patch? > > I think better to enable bus with the first patch and gradually expand > the feature, this way each patch is checked that it builds fine. > > There are cases some interim patches can't be built successfully, which > may required enabling after a few patches, but I think this is not the case.
Sure, I will merge into the first patch. Compilation should be working there too. Thanks, Nipun
