[PATCH] net/bnxt: fix newline character in speed display

2024-10-04 Thread Damodharam Ammepalli
Mistakenly "\n" sneaked into bnxt_print_link_info which prints the speed and lanes information of Broadcom Thor2 NIC. This patch removes this newline character. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Cc: sta...@dpdk.org Signed-off-by: Damodharam Amm

Re: [PATCH v6 2/2] net/bnxt: code refactor for supporting speed lanes

2024-10-04 Thread Damodharam Ammepalli
On Fri, Oct 4, 2024 at 6:56 AM David Marchand wrote: > > Hello, > > On Thu, Sep 26, 2024 at 11:56 PM Damodharam Ammepalli > wrote: > > @@ -1331,16 +1376,17 @@ static int bnxt_dev_configure_op(struct rte_eth_dev > > *eth_dev) > > void bnxt_print_link

[PATCH v6 2/2] net/bnxt: code refactor for supporting speed lanes

2024-09-26 Thread Damodharam Ammepalli
Broadcom Thor2 NICs support link mode settings where user can configure fixed speed and associated supported number of lanes. This patch does code-refactoring to address proposed poll mode library design updates. Signed-off-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h| 3

[PATCH v6 1/2] ethdev: Add link_speed lanes support

2024-09-26 Thread Damodharam Ammepalli
: net_bnxt Firmware-version: 228.9.115.0 Connect to socket: 2 memory allocation on the socket: 2 Link status: up Link speed: 200 Gbps Active Lanes: 4 Link duplex: full-duplex Autoneg status: Off Signed-off-by: Damodharam Ammepalli --- app/test-pmd/cmdline.c | 248 +

[PATCH v6 0/2] Add link_speed lanes support

2024-09-26 Thread Damodharam Ammepalli
->v4 Addressed comments and fix help string and documentation. v4->v5 Addressed comments given in v4 and also driver implementation of bnxt PMD. v5->v6 Removed LANE_xx enums and updated driver source files. Minor help string fix. Damodharam Ammepalli (2): ethdev: Add link_speed lanes s

Re: [PATCH v5 1/2] ethdev: Add link_speed lanes support

2024-09-25 Thread Damodharam Ammepalli
On Tue, Sep 24, 2024 at 3:59 PM Damodharam Ammepalli wrote: > > On Sun, Sep 22, 2024 at 10:02 AM Ferruh Yigit wrote: > > > > On 9/4/2024 6:50 PM, Damodharam Ammepalli wrote: > > > Update the eth_dev_ops structure with new function vectors > > > to get, ge

Re: [PATCH v5 1/2] ethdev: Add link_speed lanes support

2024-09-24 Thread Damodharam Ammepalli
On Sun, Sep 22, 2024 at 10:02 AM Ferruh Yigit wrote: > > On 9/4/2024 6:50 PM, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get, get capabilities and set ethernet link speed lanes. > > Update the testpmd to pro

[PATCH v5 2/2] net/bnxt: code refactor for supporting speed lanes

2024-09-04 Thread Damodharam Ammepalli
Broadcom Thor2 NICs support link mode settings where user can configure fixed speed and associated supported number of lanes. This patch does code-refactoring to address proposed poll mode library design updates. Signed-off-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h| 3

[PATCH v5 1/2] ethdev: Add link_speed lanes support

2024-09-04 Thread Damodharam Ammepalli
: net_bnxt Firmware-version: 228.9.115.0 Connect to socket: 2 memory allocation on the socket: 2 Link status: up Link speed: 200 Gbps Active Lanes: 4 Link duplex: full-duplex Autoneg status: Off Signed-off-by: Damodharam Ammepalli --- app/test-pmd/cmdline.c | 248 +

[PATCH v5 0/2] Add link_speed lanes support

2024-09-04 Thread Damodharam Ammepalli
->v4 Addressed comments and fix help string and documentation. v4->v5 Addressed comments given in v4 and also driver implementation of bnxt PMD. Damodharam Ammepalli (2): ethdev: Add link_speed lanes support net/bnxt: code refactor for supporting speed lanes app/tes

Re: [PATCH v4] ethdev: Add link_speed lanes support

2024-09-03 Thread Damodharam Ammepalli
On Wed, Jul 10, 2024 at 2:06 AM Ferruh Yigit wrote: > > On 7/9/2024 10:20 PM, Damodharam Ammepalli wrote: > > On Tue, Jul 9, 2024 at 4:10 AM Ferruh Yigit wrote: > >> > >> On 7/9/2024 12:22 AM, Damodharam Ammepalli wrote: > >>> Update the eth_dev_ops st

Re: [PATCH v4] ethdev: Add link_speed lanes support

2024-07-09 Thread Damodharam Ammepalli
On Tue, Jul 9, 2024 at 4:10 AM Ferruh Yigit wrote: > > On 7/9/2024 12:22 AM, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get, get capabilities and set ethernet link speed lanes. > > Update the testpmd to provide require

[PATCH v4] ethdev: Add link_speed lanes support

2024-07-08 Thread Damodharam Ammepalli
: net_bnxt Firmware-version: 228.9.115.0 Connect to socket: 2 memory allocation on the socket: 2 Link status: up Link speed: 200 Gbps Active Lanes: 4 Link duplex: full-duplex Autoneg status: Off Signed-off-by: Damodharam Ammepalli --- v2->v3 Consolidating the testpmd and rtelib patches into a single patch

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-07-08 Thread Damodharam Ammepalli
On Fri, Jul 5, 2024 at 10:33 AM Ferruh Yigit wrote: > > On 6/26/2024 3:19 AM, huangdengdui wrote: > > > > On 2024/6/26 5:07, Damodharam Ammepalli wrote: > >> On Wed, Jun 19, 2024 at 8:23 PM huangdengdui > >> wrote: > >>> > >>&

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-07-08 Thread Damodharam Ammepalli
On Fri, Jul 5, 2024 at 10:35 AM Ferruh Yigit wrote: > > On 6/17/2024 9:34 PM, Damodharam Ammepalli wrote: > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change, or be removed, without prior > > notice > > + * > > + * Set speed lanes su

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-06-25 Thread Damodharam Ammepalli
On Wed, Jun 19, 2024 at 8:23 PM huangdengdui wrote: > > Hi Damodharam > Here are some suggestions. See below. > Thank you for the review. > On 2024/6/18 4:34, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get, get ca

[PATCH v3] ethdev: Add link_speed lanes support

2024-06-17 Thread Damodharam Ammepalli
: net_bnxt Firmware-version: 228.9.115.0 Connect to socket: 2 memory allocation on the socket: 2 Link status: up Link speed: 200 Gbps Active Lanes: 4 Link duplex: full-duplex Autoneg status: Off Signed-off-by: Damodharam Ammepalli --- v2->v3 Consolidating the testpmd and rtelib patches into a single patc

Re: [PATCH v2 1/4] lib/ethdev: Add link_speed lanes support into rte lib

2024-06-14 Thread Damodharam Ammepalli
On Tue, Jun 11, 2024 at 4:39 PM Ferruh Yigit wrote: > > On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get and set number of speed lanes. This will help user to > > configure the same fixed speed

Re: [PATCH v2 4/4] testpmd: add support for displaying lanes capability

2024-06-12 Thread Damodharam Ammepalli
On Tue, Jun 11, 2024 at 4:39 PM Ferruh Yigit wrote: > > On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > > Add a new api support that displays the speeds and bitmap of > > supported lanes configuration by the ethernet controller. > > This patch adds support

Re: [PATCH v2 0/4] Add support for link speed lanes

2024-06-12 Thread Damodharam Ammepalli
Hi Ferruh, Thanks for the review. Will implement the review comments. Have a question in patch 4/4, you can directly index into that patchset for my question. Thanks Damo On Tue, Jun 11, 2024 at 4:39 PM Ferruh Yigit wrote: > > On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > >

[PATCH v2 4/4] testpmd: add support for displaying lanes capability

2024-06-01 Thread Damodharam Ammepalli
Add a new api support that displays the speeds and bitmap of supported lanes configuration by the ethernet controller. This patch adds support in the testpmd cli chain. Signed-off-by: Damodharam Ammepalli --- app/test-pmd/cmdline.c | 128 + 1 file

[PATCH v2 3/4] lib/ethdev: add support for displaying lanes capability

2024-06-01 Thread Damodharam Ammepalli
10 Gbps 1 25 Gbps 1 40 Gbps 4 50 Gbps 1 2 100 Gbps 1 2 4 200 Gbps 2 4 400 Gbps 4 8 testpmd> Signed-off-by: Damodharam Ammepalli --- lib/ethdev/ethdev_driver.h | 21 +++

[PATCH v2 2/4] testpmd: Add speed lanes to testpmd config and show command

2024-06-01 Thread Damodharam Ammepalli
dress: 14:23:F2:C3:BA:D2 Device name: :b1:00.0 Driver name: net_bnxt Firmware-version: 228.9.115.0 Connect to socket: 2 memory allocation on the socket: 2 Link status: up Link speed: 200 Gbps Lanes: 4 Link duplex: full-duplex Autoneg status: Off Signed-off-by: Damodharam Ammepalli Reviewed-by

[PATCH v2 1/4] lib/ethdev: Add link_speed lanes support into rte lib

2024-06-01 Thread Damodharam Ammepalli
Update the eth_dev_ops structure with new function vectors to get and set number of speed lanes. This will help user to configure the same fixed speed with different number of lanes based on the physical carrier type. Signed-off-by: Damodharam Ammepalli Reviewed-by: Kalesh AP Reviewed-by: Ajit

[PATCH v2 0/4] Add support for link speed lanes

2024-06-01 Thread Damodharam Ammepalli
1 2 4 200 Gbps 2 4 400 Gbps 4 8 testpmd> Damodharam Ammepalli (4): lib/ethdev: Add link_speed lanes support into rte lib testpmd: Add speed lanes to testpmd config and show command lib/ethdev: add support for displaying lanes capability testpmd: add su

Re: [RFC 0/2] Add support for link speed lanes

2024-05-28 Thread Damodharam Ammepalli
From: Ferruh Yigit Date: Wednesday, May 22, 2024 at 2:00 PM To: Damodharam Ammepalli , Ajit Khaparde Cc: dev@dpdk.org , Thomas Monjalon , huangdengdui , lihuisong (C) , step...@networkplumber.org , fengcheng...@huawei.com , haij...@huawei.com < haij...@huawei.com> Subject: Re: [RFC 0/

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-04-01 Thread Damodharam Ammepalli
On Mon, Apr 1, 2024 at 1:07 PM Thomas Monjalon wrote: > > 30/03/2024 12:38, huangdengdui: > > But, there are different solutions for the device to report the setting > > lane capability, as following: > > 1. Like the current patch, reporting device capabilities in speed and > >lane coupling mo

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-26 Thread Damodharam Ammepalli
On Tue, Mar 26, 2024 at 11:12 AM Ajit Khaparde wrote: > > On Tue, Mar 26, 2024 at 6:47 AM Ajit Khaparde > wrote: > > > > On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C) wrote: > > > > > > > > > 在 2024/3/26 18:30, Thomas Monjalon 写道: > > > > 26/03/2024 02:42, lihuisong (C): > > > >> 在 2024/3/25 17:

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-25 Thread Damodharam Ammepalli
On Mon, Mar 25, 2024 at 2:30 AM Thomas Monjalon wrote: > > 25/03/2024 07:24, huangdengdui: > > > > On 2024/3/22 21:58, Thomas Monjalon wrote: > > > 22/03/2024 08:09, Dengdui Huang: > > >> -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8) /**< 10 Gbps */ > > >> -#define RTE_ETH_LINK_SPEED_20G R

Re: [PATCH v2 1/6] ethdev: support setting lanes

2024-03-22 Thread Damodharam Ammepalli
On Fri, Mar 22, 2024 at 10:32 AM Tyler Retzlaff wrote: > > On Fri, Mar 22, 2024 at 08:15:00AM -0700, Ajit Khaparde wrote: > > On Fri, Mar 22, 2024 at 6:58 AM Thomas Monjalon wrote: > > > > > > 22/03/2024 08:09, Dengdui Huang: > > > > -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8) /**< 10 Gbps

[RFC 2/2] testpmd: Add speed lanes to testpmd config and show command

2024-03-22 Thread Damodharam Ammepalli
dress: 14:23:F2:C3:BA:D2 Device name: :b1:00.0 Driver name: net_bnxt Firmware-version: 228.9.115.0 Connect to socket: 2 memory allocation on the socket: 2 Link status: up Link speed: 200 Gbps Lanes: 4 Link duplex: full-duplex Autoneg status: Off Signed-off-by: Damodharam Ammepalli Reviewed-by

[RFC 1/2] lib/ethdev: Add link_speed lanes support into rte lib

2024-03-22 Thread Damodharam Ammepalli
Update the eth_dev_ops structure with new function vectors to get and set number of speed lanes. This will help user to configure the same fixed speed with different number of lanes based on the physical carrier type. Signed-off-by: Damodharam Ammepalli Reviewed-by: Kalesh AP Reviewed-by: Ajit

[RFC 0/2] Add support for link speed lanes

2024-03-22 Thread Damodharam Ammepalli
BRCM576xx NIC modules support speeds with different lanes configuration. This is an alternate proposal to https://patchwork.dpdk.org/project/dpdk/list/?series=31593 Please provide your review. Broadcom driver patches will follow. Damodharam Ammepalli (2): lib/ethdev: Add link_speed lanes

Re: [PATCH 0/3] support setting lanes

2024-03-18 Thread Damodharam Ammepalli
On Mon, Mar 18, 2024 at 7:56 AM Thomas Monjalon wrote: > > 12/03/2024 08:52, Dengdui Huang: > > Some speeds can be achieved with different number of lanes. For example, > > 100Gbps can be achieved using two lanes of 50Gbps or four lanes of 25Gbps. > > When use different lanes, the port cannot be u

Re: [PATCH 3/3] app/testpmd: support setting lanes

2024-03-15 Thread Damodharam Ammepalli
On Tue, Mar 12, 2024 at 12:52 AM Dengdui Huang wrote: > > Extended speed command for setting lane number and > Show info print lane number. > > Signed-off-by: Dengdui Huang > --- > app/test-pmd/cmdline.c | 110 +++- > app/test-pmd/config.c

RE: [dpdk-dev] [PATCH 4/8] net/bnxt: allow Tx only or Rx only configs in PMD

2022-06-20 Thread Damodharam Ammepalli
Hi Ferruh, Please see my inline responses [Damo]; Thanks Damo From: Kalesh Anakkur Purayil Sent: Monday, June 20, 2022 9:47 PM To: Ferruh Yigit ; Damodharam Ammepalli Cc: Ajit Kumar Khaparde ; dpdk-dev Subject: Re: [dpdk-dev] [PATCH 4/8] net/bnxt: allow Tx only or Rx only configs