[dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)

2015-10-13 Thread Christoph Gysin
Hi David Is there anything I can do to help getting this merged? Thanks, Chris On Mon, Oct 5, 2015 at 12:44 PM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christoph Gysin >> Sent: Tuesday, Se

[dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)

2015-10-03 Thread Christoph Gysin
I added the Signed-off, is there anything else missing? Any chance to get this merged? On Tue, Sep 29, 2015 at 9:53 AM, Christoph Gysin wrote: > 'virtual' is a keyword and can't be used if the code is to compile with > C++ compilers. > > If rte_devargs.h was includ

[dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)

2015-09-29 Thread Christoph Gysin
hich it ignores. This simply renames the member to 'virt'. Signed-off-by: Christoph Gysin --- app/test/test_devargs.c | 4 ++-- lib/librte_eal/common/eal_common_dev.c | 4 ++-- lib/librte_eal/common/eal_common_devargs.c | 8 lib/librte_eal/common/

[dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)

2015-09-26 Thread Christoph Gysin
'virtual' is a keyword and can't be used if the code is to compile with C++ compilers. If rte_devargs.h was included in C++ code, compilation with clang++ failed with an error. g++ did not fail, but only because of a bug that treats it as an anonymous struct with a decl-specifier which it ignores.

[dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)

2015-09-26 Thread Christoph Gysin
'virtual' is a keyword and can't be used if the code is to compile with C++ compilers. If rte_devargs.h was included in C++ code, compilation with clang++ failed with an error. g++ did not fail, but only because of a bug that treats it as an anonymous struct with a decl-specifier which it ignores.