Hi David Is there anything I can do to help getting this merged?
Thanks, Chris On Mon, Oct 5, 2015 at 12:44 PM, Dumitrescu, Cristian <cristian.dumitrescu at intel.com> wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christoph Gysin >> Sent: Tuesday, September 29, 2015 7:53 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) >> >> 'virtual' is a keyword and can't be used if the code is to compile with >> C++ compilers. >> >> If rte_devargs.h was included in C++ code, compilation with clang++ >> failed with an error. g++ did not fail, but only because of a bug >> that treats it as an anonymous struct with a decl-specifier which it >> ignores. >> >> This simply renames the member to 'virt'. >> >> Signed-off-by: Christoph Gysin <christoph.gysin at gmail.com> >> --- > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com> > > Christoph, please also copy David Marchand for further updates of this patch, > as David is the maintainer of this component. Whenever in doubt about the > maintainer, you can check file MAINTAINERS from DPDK root folder. > > Regards, > Cristian > -- echo mailto: NOSPAM !#$.'<*>'|sed 's. ..'|tr "<*> !#:2" org at fr33z3
