On 5/18/2020 9:00 AM, Ferruh Yigit wrote:
On 5/18/2020 12:20 PM, Wei Hu (Xavier) wrote:
Adding Xavier as additional maintainer to bonding.
Signed-off-by: Wei Hu (Xavier)
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6a14622..46b6535 10
After commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") is it
much harder to detect a "double free". If the developer makes a copy
of an mbuf pointer and frees it twice, this condition is never detected
and the mbuf gets returned to the pool twice.
Since this requires extra work to trac
After commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") is it
much harder to detect a "double free". If the developer makes a copy
of an mbuf pointer and frees it twice, this condition is never detected
and the mbuf gets returned to the pool twice.
Since this requires extra work to trac
After commit 8f094a9ac5d7 is it much harder to detect a "double free".
If the developer makes a copy of an mbuf pointer and frees it twice, this
condition is never detected and the mbuf gets returned to the pool twice.
Since this requires extra work to track, make this behavior conditional
on CONF
On 08/01/2017 07:41 PM, Shrikrishna Khare wrote:
On Mon, 24 Jul 2017, Charles (Chas) Williams wrote:
We should only restore shadow_vfta when hw_vlan_filter is active.
Otherwise, we should restore the previous filtering behavior.
Fixes: f003fc383487("vmxnet3: enable vlan filtering
We should only restore shadow_vfta when hw_vlan_filter is active.
Otherwise, we should restore the previous filtering behavior.
Fixes: f003fc383487("vmxnet3: enable vlan filtering")
Cc: sta...@dpdk.org
Signed-off-by: Chas Williams
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 -
1 file chang
This function wasn't provided in the original commit.
Fixes: 4f0981e6ec6c ("eal: deprecate log functions")
Cc: sta...@dpdk.org
Signed-off-by: Chas Williams
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/eal_common_log.c | 9 +
lib/librte_eal/
On 07/18/2017 07:50 AM, Ferruh Yigit wrote:
On 7/18/2017 12:05 AM, Charles (Chas) Williams wrote:
Just a couple small changes to net/virtio that make it a little more
well behaved.
Same question here, is this patchset targets the 17.08-rc2? Can this be
postponed?
Yes, these can all be
From: Brian Russell
Register and unregister the virtio interrupt handler when the device is
started and stopped.
Signed-off-by: Brian Russell
---
drivers/net/virtio/virtio_ethdev.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/net/virt
.dev_uninit calls .dev_stop and .dev_close. The work that is done in
those routines doesn't need repeated. Use started and opened to track
the adapter's status.
Signed-off-by: Chas Williams
---
drivers/net/virtio/virtio_ethdev.c | 15 ---
drivers/net/virtio/virtio_pci.h| 4 +++
Just a couple small changes to net/virtio that make it a little more
well behaved.
Brian Russell (1):
net/virtio: register/unregister intr handler on start/stop
Charles (Chas) Williams (1):
net/virtio: do not re-enter clean up routines
drivers/net/virtio/virtio_ethdev.c | 41
The transmit and receive controller state machines are only enabled after
receiving an interrupt and the link status is now valid. If an adapter
is being used in conjuction with NC-SI, network controller sideband
interface, the adapter may never get a link state change interrupt since
the adapter'
Refactor vmxnet3_post_rx_bufs() to call vmxnet3_renew_desc()
to update the newly allocated mbufs. While here, relocate the
relevant comments to vmxnet3_renew_desc().
Signed-off-by: Chas Williams
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 61 +-
1 file changed,
On 06/28/2017 08:52 AM, Ferruh Yigit wrote:
On 6/28/2017 12:30 PM, Ferruh Yigit wrote:
On 6/15/2017 1:16 PM, Charles (Chas) Williams wrote:
This series addresses some local issues with the vmxnet3 driver that
others might find of interest.
Changes in v2:
- net/vmxnet3: Implement retrieval
Update vmxnet3.ini to indicate extended stats support
Signed-off-by: Chas Williams
---
doc/guides/nics/features/vmxnet3.ini | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/nics/features/vmxnet3.ini
b/doc/guides/nics/features/vmxnet3.ini
index 8f7f8e0..4e60183 100644
--- a/doc/gui
On 06/28/2017 08:52 AM, Ferruh Yigit wrote:
On 6/28/2017 12:30 PM, Ferruh Yigit wrote:
On 6/15/2017 1:16 PM, Charles (Chas) Williams wrote:
This series addresses some local issues with the vmxnet3 driver that
others might find of interest.
Changes in v2:
- net/vmxnet3: Implement retrieval
From: George Wilkie
When starting a vmxnet3 device, it is always writing the permanent MAC
address, even if a different MAC address was configured. Write from
the device data instead which holds the current one.
Signed-off-by: George Wilkie
Acked-by: Shrikrishna Khare
---
drivers/net/vmxnet3
From: Mandeep Rohilla
This addresses an mbuf leak in an error condition during packet
receive.
Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
implementation")
Signed-off-by: Mandeep Rohilla
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 6 ++
1 file changed, 6 insertions(+)
From: Robert Shearman
Generate link-state change notifications by listening to interrupts
generated by the device. Make use of the existing
vmxnet3_process_events function that was compiled out, but change it
to call vmxnet3_dev_link_update on a VMXNET3_ECR_LINK event and to not
be so noisy in it
From: Robert Shearman
Implement xstats_get() to allow a number of driver-specific tx and rx
stats to be retrieved.
Signed-off-by: Robert Shearman
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 113 +++
1 file changed, 113 insertions(+)
diff --git a/drivers/net/vmxn
From: Robert Shearman
Make vmxnet3_process_events less noisy by removing logging when there
are no events to process and by making link, device-change and debug
events DEBUG level rather than ERR.
Change these to use PMD_DRV_LOG instead of PMD_INIT_LOG since they
don't happen at device init.
Si
From: Nachiketa Prachanda
Most nics like virtio, igb/ixgbe etc. don't reset counters on
dev_start and arguably this helps in monitoring the counters
across a longer time span with multiple device start/stops.
vmxnet3 behavior is opposite to that and counters are reset by
the host side implementat
This series addresses some local issues with the vmxnet3 driver that
others might find of interest.
Changes in v2:
- net/vmxnet3: Implement retrieval of extended stats
.id field wasn't being filled in xstats.
- net/vmxnet3: receive queue memory leak
The leak and buffer reallcation were
s. That can be
refactored into a new commit.
On 05/19/2017 01:55 PM, Charles (Chas) Williams wrote:
From: Mandeep Rohilla
The receive queue can lockup if all the rx descriptors have lost
their mbufs and temporarily there are no mbufs available. This
can happen if there is an mbuf leak or if the applicat
When .mac_addr_add() was changed to allow a return code, ring was changed
to return -ENOTSUP. This changes the behavior of the rte_ring driver in
a way that does not maintain backward compatibility. Additionally, if
the intent is to return -ENOTSUP, you could simply not define the stubs.
Fixes:
On 05/22/2017 05:39 AM, Ferruh Yigit wrote:
Hi Chas,
On 5/17/2017 7:03 PM, Charles (Chas) Williams wrote:
Provide an accessor for the name of the underlying linux interface
used by the AF_PACKET-based interface.
This patch provides a PMD specific API to get PMD internal data
(internals
From: George Wilkie
When starting a vmxnet3 device, it is always writing the permanent MAC
address, even if a different MAC address was configured. Write from
the device data instead which holds the current one.
Signed-off-by: George Wilkie
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
1 f
From: Robert Shearman
Make vmxnet3_process_events less noisy by removing logging when there
are no events to process and by making link, device-change and debug
events DEBUG level rather than ERR.
Change these to use PMD_DRV_LOG instead of PMD_INIT_LOG since they
don't happen at device init.
Si
From: Robert Shearman
Generate link-state change notifications by listening to interrupts
generated by the device. Make use of the existing
vmxnet3_process_events function that was compiled out, but change it
to call vmxnet3_dev_link_update on a VMXNET3_ECR_LINK event and to not
be so noisy in it
From: Mandeep Rohilla
The receive queue can lockup if all the rx descriptors have lost
their mbufs and temporarily there are no mbufs available. This
can happen if there is an mbuf leak or if the application holds
on to the mbuf for a while.
This also addresses an mbuf leak in an error condition
From: Robert Shearman
Implement xstats_get() to allow a number of driver-specific tx and rx
stats to be retrieved.
Signed-off-by: Robert Shearman
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 111 +++
1 file changed, 111 insertions(+)
diff --git a/drivers/net/vmxn
From: Nachiketa Prachanda
Most nics like virtio, igb/ixgbe etc. don't reset counters on
dev_start and arguably this helps in monitoring the counters
across a longer time span with multiple device start/stops.
vmxnet3 behavior is opposite to that and counters are reset by
the host side implementat
On error, we also need to zero the bytes transmitted.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/af_packet
Fixes: 1b93c2aa81b4 ("net/af_packet: add interface name to internals")
Signed-off-by: Chas Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/af_packet/rte_eth_af_packet.c
index a03
Provide an accessor for the name of the underlying linux interface
used by the AF_PACKET-based interface.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/Makefile | 2 +
drivers/net/af_packet/rte_eth_af_packet.c | 17 +++
drivers/net/af_packet
If the user reconfigures the queue size, then the previously allocated
memzone may potentially be too small. Release the memzone when a queue
is released and allocate a new one each time a queue is setup.
While here convert to rte_eth_dma_zone_reserve() which does basically
the same things as the
On 03/15/2017 06:05 AM, Jan Blunck wrote:
On Wed, Mar 15, 2017 at 10:45 AM, Charles (Chas) Williams
wrote:
On 03/15/2017 04:18 AM, Jan Blunck wrote:
On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams
wrote:
On 03/14/2017 12:11 PM, Jan Blunck wrote:
On Mon, Mar 13, 2017 at
On 03/15/2017 06:05 AM, Jan Blunck wrote:
On Wed, Mar 15, 2017 at 10:45 AM, Charles (Chas) Williams
wrote:
On 03/15/2017 04:18 AM, Jan Blunck wrote:
On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams
wrote:
On 03/14/2017 12:11 PM, Jan Blunck wrote:
On Mon, Mar 13, 2017 at
On 03/15/2017 04:18 AM, Jan Blunck wrote:
On Tue, Mar 14, 2017 at 5:38 PM, Charles (Chas) Williams
wrote:
On 03/14/2017 12:11 PM, Jan Blunck wrote:
On Mon, Mar 13, 2017 at 11:41 PM, Charles (Chas) Williams
wrote:
If the user reconfigures the queues size, then the previosly allocated
On 03/14/2017 12:11 PM, Jan Blunck wrote:
On Mon, Mar 13, 2017 at 11:41 PM, Charles (Chas) Williams
wrote:
If the user reconfigures the queues size, then the previosly allocated
memzone may potentially be too small. Instead, always free the old
memzone and allocate a new one.
Fixes
If the user reconfigures the queues size, then the previosly allocated
memzone may potentially be too small. Instead, always free the old
memzone and allocate a new one.
Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
implementation")
Signed-off-by: Chas Williams
---
driver
The default tx_free_thresh is potentially larger than the allocated queue
which will result in TX queue cleanup never happening. To fix this,
lower the default free threshold and ensure that the free threshold is
never greater than the maximum outstanding transmit buffers.
Fixes: 827ed2a118cc ("n
AF_PACKET has some flags to check on the receive side for 802.1Q
information. If present, we copy into the mbuf. For transmit, we
insert any 802.1Q information into the packet before copying to the ring.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 14
Add promiscuous support to the AF_PACKET PMD. The underlying linux
device's IF_PROMISC flag is toggled to enable or disable.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 39 +++
1 file changed, 39 insertions(+)
diff --
The underlying linux device's MTU is changed subject to the frame size
limitations during device creation.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/driver
This will be used by later changes to determine the underlying linux
interface.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/af_packet
The underlying linux device's MTU is changed subject to the frame size
limitations during device creation.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/driver
Add promiscuous support to the AF_PACKET PMD. The underlying linux
device's IF_PROMISC flag is toggled to enable or disable.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 40 +++
1 file changed, 40 insertions(+)
diff --
AF_PACKET has some flags to check on the receive side for 802.1Q
information. If present, we copy into the mbuf. For transmit, we
insert any 802.1Q information into the packet before copying to the ring.
Signed-off-by: Charles (Chas) Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 14
This will be used by later changes to determine the underlying linux
interface.
Signed-off-by: Chas Williams
---
drivers/net/af_packet/rte_eth_af_packet.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/af_packet/rte_eth_af_packet.
.dev_start()/.dev_stop() roughly corresponds to the local device's port
being ready. This is different from the remote client being connected
which is roughly link up or down. Emulate the device start/stop behavior
by separately tracking the start/stop state to determine if we should
allow packet
If you create a vhost server device, it doesn't create the actual datagram
socket until you call .dev_start(). If you call .dev_stop() is also
deletes those sockets. For QEMU clients, this is a problem since QEMU
doesn't know how to re-attach to datagram sockets that have gone away.
To fix this,
On 01/03/2017 03:22 AM, Yuanhan Liu wrote:
On Sun, Jan 01, 2017 at 02:01:56PM -0500, Charles (Chas) Williams wrote:
If you create a vhost server device, it doesn't create the actual datagram
socket until you call .dev_start(). If you call .dev_stop() is also
deletes those sockets. For
.dev_start()/.dev_stop() roughly corresponds to the local device's
port being up or down. This is different from the remote client being
connected which is roughtly link up or down. Emulate the behavior by
separately tracking the local start/stop state to determine if we should
allow packets to b
If you create a vhost server device, it doesn't create the actual datagram
socket until you call .dev_start(). If you call .dev_stop() is also
deletes those sockets. For QEMU clients, this is a problem since QEMU
doesn't know how to re-attach to datagram sockets that have gone away.
To work arou
.dev_start()/.dev_stop() roughly corresponds to the local device's
port being up or down. This is different from the remote client being
connected which is roughtly link up or down. Emulate the behavior by
separately tracking the local start/stop state to determine if we should
allow packets to b
If you create a vhost server device, it doesn't create the actual datagram
socket until you call .dev_start(). If you call .dev_stop() is also
deletes those sockets. For QEMU clients, this is a problem since QEMU
doesn't know how to re-attach to datagram sockets that have gone away.
To work arou
On 12/29/2016 10:15 PM, Yuanhan Liu wrote:
On Thu, Dec 29, 2016 at 10:58:11AM -0500, Charles (Chas) Williams wrote:
On 12/29/2016 03:52 AM, Yuanhan Liu wrote:
On Wed, Dec 28, 2016 at 04:10:52PM -0500, Charles (Chas) Williams wrote:
Start a vhost server once during devinit instead of during
On 12/29/2016 03:52 AM, Yuanhan Liu wrote:
On Wed, Dec 28, 2016 at 04:10:52PM -0500, Charles (Chas) Williams wrote:
Start a vhost server once during devinit instead of during device start
and stop. Some vhost clients, QEMU, don't re-attaching to sockets when
the vhost server is stoppe
On 12/29/2016 03:51 AM, Yuanhan Liu wrote:
On Wed, Dec 28, 2016 at 04:10:51PM -0500, Charles (Chas) Williams wrote:
From: Wen Chiu
Only increment and decrement nb_started_ports on the first and last
device start and stop. Otherwise, nb_started_ports can become negative
if a device is
Start a vhost server once during devinit instead of during device start
and stop. Some vhost clients, QEMU, don't re-attaching to sockets when
the vhost server is stopped and later started. Preserve existing behavior
for vhost clients.
Fixes: ee584e9710b9 ("vhost: add driver on top of the librar
From: Wen Chiu
Only increment and decrement nb_started_ports on the first and last
device start and stop. Otherwise, nb_started_ports can become negative
if a device is stopped multiple times.
Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Signed-off-by: Wen Chiu
Reviewed-by:
I am afraid I don't understand what you are asking. This was broken in
the commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be
On 02/08/2016 05:51 AM, Bruce Richardson wrote:
> On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote:
>> From: "Char
On Mon, 2015-12-07 at 17:29 +, Harish Patil wrote:
> >
> >On Sun, 2015-12-06 at 23:34 +, Harish Patil wrote:
> >> >
> >> >The original was always setting unicast. While here, clean up some
> >> >other references that also point into the Ethernet header.
> >> >
> >> >Signed-off-by: Chas Wil
On Sun, 2015-12-06 at 23:34 +, Harish Patil wrote:
> >
> >The original was always setting unicast. While here, clean up some
> >other references that also point into the Ethernet header.
> >
> >Signed-off-by: Chas Williams <3chas3 at gmail.com>
> >---
> > drivers/net/bnx2x/bnx2x.c | 23 +++
On Wed, 2015-12-02 at 02:04 +0100, Thomas Monjalon wrote:
> 2015-12-01 18:58, Charles Williams:
> > On Wed, 2015-12-02 at 00:34 +0100, Thomas Monjalon wrote:
> > > 2015-12-01 14:37, Stephen Hemminger:
> > > > Harish Patil wrote:
> > > > > >2015-11-03 12:26, Chas Williams:
> > > > > >> --- a/dri
On Wed, 2015-12-02 at 00:34 +0100, Thomas Monjalon wrote:
> 2015-12-01 14:37, Stephen Hemminger:
> > Harish Patil wrote:
> > > >2015-11-03 12:26, Chas Williams:
> > > >> --- a/drivers/net/bnx2x/bnx2x.c
> > > >> +++ b/drivers/net/bnx2x/bnx2x.c
> > > >> -tx_start_bd->vl
On Thu, 2015-11-05 at 11:23 -0800, Stephen Hemminger wrote:
> On Thu, 05 Nov 2015 11:39:04 -0500
> "Charles (Chas) Williams" <3chas3 at gmail.com> wrote:
>
> > On Wed, 2015-11-04 at 23:40 +0100, Thomas Monjalon wrote:
> > > 2015-10-14 09:41, Charles Will
On Wed, 2015-11-04 at 23:40 +0100, Thomas Monjalon wrote:
> 2015-10-14 09:41, Charles Williams:
> > On Tue, 2015-10-13 at 14:49 +0200, Olivier MATZ wrote:
> > > For PCI devices that have several interfaces (I think it's the case for
> > > some Mellanox boards), maybe we should not store the interf
On Fri, 2015-10-30 at 18:10 -0400, Mussar, Gary wrote:
> I have been attempting to build testpmd with the bnx2x pmd enabled to try and
> talk through a bcm57810 10G NIC card. I have tried using SR-IOV VFs and I
> have tried using the PFs. Neither seem to be able to be properly initialized
> in t
On Tue, 2015-10-13 at 14:49 +0200, Olivier MATZ wrote:
> Hi Chas,
>
> > @@ -352,6 +354,19 @@ pci_scan_one(const char *dirname, uint16_t domain,
> > uint8_t bus,
> > return -1;
> > }
> >
> > + /* get network interface name */
> > + snprintf(filename, sizeof(filename), "%s/net
On Tue, 2015-10-06 at 08:35 +0100, Stephen Hemminger wrote:
> On Mon, 5 Oct 2015 11:26:08 -0400
> Chas Williams <3chas3 at gmail.com> wrote:
>
> > diff --git a/lib/librte_eal/common/include/rte_pci.h
> > b/lib/librte_eal/common/include/rte_pci.h
> > index 83e3c28..852c149 100644
> > --- a/lib/li
On Fri, 2015-10-02 at 16:44 +, Richardson, Bruce wrote:
> I'm not sure about that, to be honest. However, I'd rather not have
> too many cmd line options to be maintained in the code.
>
> Does you proposed blacklisting patch work with non-pci devices as well
> as with PCI ones as now?
I refa
On Fri, 2015-10-02 at 16:44 +, Richardson, Bruce wrote:
> > -Original Message-
> > From: Charles (Chas) Williams [mailto:3chas3 at gmail.com]
> >
> > On Fri, 2015-10-02 at 16:18 +0100, Bruce Richardson wrote:
> > > On Fri, Oct 02, 2015 at 11:0
On Fri, 2015-10-02 at 16:18 +0100, Bruce Richardson wrote:
> On Fri, Oct 02, 2015 at 11:00:07AM -0400, Chas Williams wrote:
> > If a system is using deterministic interface names, it may be easier in
> > some cases to use the interface name to blacklist an interface.
> >
>
> Is it possible to do t
75 matches
Mail list logo
