Re: [dpdk-dev] [PATCH] build: automatically create windows exports file

2019-04-12 Thread Anand Rawat
On 4/12/2019 1:29 AM, Bruce Richardson wrote: Rather than having a separate version.map file for linux/BSD and an exports definition file for windows for each library, generate the latter from the former automatically at build time. Signed-off-by: Bruce Richardson Acked-by: Anand Rawat

Re: [dpdk-dev] [PATCH v8 00/10] HelloWorld example for Windows

2019-04-02 Thread Anand Rawat
On 4/2/2019 4:25 PM, Thomas Monjalon wrote: 02/04/2019 05:54, Anand Rawat: Includes Windows-specific EAL changes and meson changes to build the code on Windows. [...] Anand Rawat (10): eal: eal stub to add windows support meson: required changes for windows eal: add new rte_os.h

Re: [dpdk-dev] [PATCH v8 10/10] build: meson changes to build on windows

2019-04-02 Thread Anand Rawat
On 4/2/2019 3:51 PM, Thomas Monjalon wrote: 02/04/2019 05:54, Anand Rawat: Added meson workarounds to build helloworld on Windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off

Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-02 Thread Anand Rawat
pthread lib functionality with Microsoft libc. I can start looking into porting those functionalities for rte_ctrl_thread_create() on Windows. -- Anand Rawat

Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system

2019-04-02 Thread Anand Rawat
On 4/2/2019 3:32 PM, Thomas Monjalon wrote: 03/04/2019 00:11, Anand Rawat: > On 4/2/2019 1:47 PM, Thomas Monjalon wrote: >> 02/04/2019 21:56, Thomas Monjalon: >>> 02/04/2019 05:54, Anand Rawat: >>>> Added rte_os.h files to support OS specific functionality. >&g

Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system

2019-04-02 Thread Anand Rawat
On 4/2/2019 1:47 PM, Thomas Monjalon wrote: 02/04/2019 21:56, Thomas Monjalon: 02/04/2019 05:54, Anand Rawat: Added rte_os.h files to support OS specific functionality. Updated build system to contain OS headers in the include path. Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam

[dpdk-dev] [PATCH v8 06/10] eal: sys/queue.h implementation for windows

2019-04-01 Thread Anand Rawat
Adding sys/queue.h on Windows for supporting common code. This implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions

[dpdk-dev] [PATCH v8 07/10] eal: add headers for compatibility with windows

2019-04-01 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib

[dpdk-dev] [PATCH v8 10/10] build: meson changes to build on windows

2019-04-01 Thread Anand Rawat
Added meson workarounds to build helloworld on Windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app

[dpdk-dev] [PATCH v8 09/10] doc: add documentation for windows

2019-04-01 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS | 1 + doc/guides/index.rst | 3 +- doc

Re: [dpdk-dev] [PATCH v7 8/8] build: meson changes to build on windows

2019-04-01 Thread Anand Rawat
On 4/1/2019 4:25 PM, Thomas Monjalon wrote: 29/03/2019 00:24, Anand Rawat: Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. [...] --- a/app/meson.build +++ b/app

[dpdk-dev] [PATCH v8 02/10] meson: required changes for windows

2019-04-01 Thread Anand Rawat
These are the required meson changes for Windows. kernel/windows/meson is a stub file added to support Windows specific source in future releases. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build

[dpdk-dev] [PATCH v8 00/10] HelloWorld example for Windows

2019-04-01 Thread Anand Rawat
raft repository *command-line parsing is not a part of this version as a result lcore mask is currently not supported. *kernel modules and documentation can not be built on windows currently and should not be enabled. Anand Rawat (10): eal: eal stub to add windows support meson: required chan

[dpdk-dev] [PATCH v8 05/10] build: add module definition file for windows

2019-04-01 Thread Anand Rawat
Updated lib/meson.build to create shared libraries on Windows. Added DEF files to list the exports for the eal and kvargs libraries. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/rte_eal_exports.def

[dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-01 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system

2019-04-01 Thread Anand Rawat
Added rte_os.h files to support OS specific functionality. Updated build system to contain OS headers in the include path. Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam --- lib/librte_eal/freebsd/eal/Makefile | 4 ++-- lib/librte_eal/freebsd/eal/include/rte_os.h | 14

[dpdk-dev] [PATCH v8 04/10] eal: update common headers to use rte_os.h

2019-04-01 Thread Anand Rawat
Updated rte_common.h to include rte_os.h to contain OS specific macros and functions. Updated rte_string_fns.h to include rte_common.h for rte_os.h Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/common/include/rte_common.h| 5

[dpdk-dev] [PATCH v8 01/10] eal: eal stub to add windows support

2019-04-01 Thread Anand Rawat
Added initial stub source files for windows support. Updated the MAINTAINERS list for windows support. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS | 7 ++ lib/librte_eal/windows/eal

Re: [dpdk-dev] [PATCH v7 2/8] eal: add header files to support os specifics

2019-04-01 Thread Anand Rawat
'librte_eal//eal/include' for rte_os.h. This is done to make it available during the build process. -- Anand Rawat

Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support

2019-04-01 Thread Anand Rawat
On 4/1/2019 9:34 AM, Bruce Richardson wrote: On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: config/meson.build | 23 -- config/x86/meson.build | 14 ++- lib/librte_eal/meson.build | 6 - lib

[dpdk-dev] [PATCH v7 8/8] build: meson changes to build on windows

2019-03-28 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app

[dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows

2019-03-28 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS

[dpdk-dev] [PATCH v7 5/8] eal: add headers for compatibility with windows

2019-03-28 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon

[dpdk-dev] [PATCH v7 6/8] eal: add minimum viable code for eal on windows

2019-03-28 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v7 4/8] eal: sys/queue.h implementation for windows

2019-03-28 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions

[dpdk-dev] [PATCH v7 0/8] HelloWorld example for windows

2019-03-28 Thread Anand Rawat
which will later be a part of the draft repository *command-line parsing is not a part of this version as a result lcore mask is currently not supported. *kernel modules and documentation can not be built on windows currently and should not be enabled. Anand Rawat (8): eal: eal stub to add win

[dpdk-dev] [PATCH v7 3/8] build: add module definition file for windows

2019-03-28 Thread Anand Rawat
Updated lib/meson.build to create shared libraries on windows. Added DEF files to list the exports for the eal and kvargs libraries. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/rte_eal_exports.def

[dpdk-dev] [PATCH v7 2/8] eal: add header files to support os specifics

2019-03-28 Thread Anand Rawat
Added rte_os.h files to support os specific functionality. Updated rte_common.h to include rte_os.h. Updated lib/meson.build to inject rte_os.h in every library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common

[dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support

2019-03-28 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86

Re: [dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Anand Rawat
On 3/27/2019 7:30 PM, Varghese, Vipin wrote: Hi Anand, snipped Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys

[dpdk-dev] [PATCH v6 6/8] eal: add minimum viable code for eal on windows

2019-03-27 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v6 3/8] build: add module definition file for windows

2019-03-27 Thread Anand Rawat
Updated lib/meson.build to create shared libraries on windows. Added DEF files to list the exports for the eal and kvargs libraries. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/rte_eal_exports.def

[dpdk-dev] [PATCH v6 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions

[dpdk-dev] [PATCH v6 5/8] eal: add headers for compatibility with windows

2019-03-27 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon

[dpdk-dev] [PATCH v6 8/8] build: meson changes to build on windows

2019-03-27 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app

[dpdk-dev] [PATCH v6 7/8] doc: add documentation for windows

2019-03-27 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS

[dpdk-dev] [PATCH v6 0/8] HelloWorld example for windows

2019-03-27 Thread Anand Rawat
umentation can not be built on windows currently and should not be enabled. Anand Rawat (8): eal: eal stub to add windows support eal: add header files to support os specifics build: add module definition file for windows eal: sys/queue.h implementation for windows eal: add headers for co

[dpdk-dev] [PATCH v6 2/8] eal: add header files to support os specifics

2019-03-27 Thread Anand Rawat
Added rte_os.h files to support os specific functionality. Updated rte_common.h to include rte_os.h. Updated lib/meson.build to inject rte_os.h in every library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common

[dpdk-dev] [PATCH v6 1/8] eal: eal stub to add windows support

2019-03-27 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86

Re: [dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-27 Thread Anand Rawat
On 3/27/2019 3:29 PM, Thomas Monjalon wrote: 27/03/2019 22:23, Ranjit Menon: > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote: >> On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: >>> Added header files to support windows on x86 platforms. >>> Upda

Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-27 Thread Anand Rawat
On 3/26/2019 12:06 PM, Stephen Hemminger wrote: On Mon, 25 Mar 2019 23:02:34 -0700 Anand Rawat wrote: +/*- + * SPDX-License-Identifier: BSD-3-Clause + * + * Copyright (c) 1991, 1993 + * The Regents of the University of California. All rights reserved. + * + * Redistribution and use in

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-26 Thread Anand Rawat
build flow. But if required shared library logic can be disabled as a part of meson workaround for windows for the initial release. -- Anand Rawat

Re: [dpdk-dev] [PATCH v5 7/8] doc: add documention for windows

2019-03-26 Thread Anand Rawat
On 3/26/2019 3:37 AM, David Marchand wrote: On Tue, Mar 26, 2019 at 7:04 AM Anand Rawat <mailto:anand.ra...@intel.com>> wrote: Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Ca

[dpdk-dev] [PATCH v5 8/8] build: meson changes to build on windows

2019-03-25 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app

[dpdk-dev] [PATCH v5 6/8] eal: add minimum viable code for eal on windows

2019-03-25 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v5 5/8] eal: add headers for compatibility with windows environment

2019-03-25 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib

[dpdk-dev] [PATCH v5 7/8] doc: add documention for windows

2019-03-25 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS

[dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows

2019-03-25 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions

[dpdk-dev] [PATCH v5 3/8] kvargs: adding a module definition file

2019-03-25 Thread Anand Rawat
adding a DEF file for kvargs to specify the exports for the creation of the shared library. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_kvargs/rte_kvargs_exports.def | 7 +++ 1 file changed, 7 insertions

[dpdk-dev] [PATCH v5 2/8] eal: add header files to support windows

2019-03-25 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_common.h to include rte_windows.h for windows build. Updated lib/meson.build to create shared libraries on windows. Added def file to list the exports for the eal library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam

[dpdk-dev] [PATCH v5 0/8] HelloWorld example for windows

2019-03-25 Thread Anand Rawat
hould not be enabled. Anand Rawat (8): eal: eal stub to add windows support eal: add header files to support windows kvargs: adding a module definition file eal: sys/queue.h implementation for windows eal: add headers for compatibility with windows environment eal: add minimum viable cod

[dpdk-dev] [PATCH v5 1/8] eal: eal stub to add windows support

2019-03-25 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86

[dpdk-dev] [PATCH v4 7/8] doc: add documention for windows

2019-03-22 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS

[dpdk-dev] [PATCH v4 8/8] build: meson changes to build on windows

2019-03-22 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- app

[dpdk-dev] [PATCH v4 4/8] eal: sys/queue.h implementation for windows

2019-03-22 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions

[dpdk-dev] [PATCH v4 5/8] eal: add headers for compatibility with windows environment

2019-03-22 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib

[dpdk-dev] [PATCH v4 6/8] eal: add minimum viable code for eal on windows

2019-03-22 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v4 3/8] kvargs: adding a module definition file

2019-03-22 Thread Anand Rawat
adding a DEF file for kvargs to specify the exports for the creation of the shared library. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_kvargs/rte_kvargs_exports.def | 7 +++ 1 file changed, 7 insertions

[dpdk-dev] [PATCH v4 1/8] eal: eal stub to add windows support

2019-03-22 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86

[dpdk-dev] [PATCH v4 0/8] HelloWorld example for windows

2019-03-22 Thread Anand Rawat
mand-line parsing is not a part of this version as a result lcore mask is currently not supported. Anand Rawat (8): eal: eal stub to add windows support eal: add header files to support windows kvargs: adding a module definition file eal: sys/queue.h implementation for windows

[dpdk-dev] [PATCH v4 2/8] eal: add header files to support windows

2019-03-22 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_common.h to include rte_windows.h for windows build. Updated lib/meson.build to create shared libraries on windows. Added def file to list the exports for the eal library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam

[dpdk-dev] [PATCH v3 4/8] eal: sys/queue.h implementation for windows

2019-03-19 Thread Anand Rawat
Adding sys/queue.h on windows for supporting common code. This is implementation has BSD-3-Clause licensing. Signed-off-by: Ranjit Menon Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw --- .../windows/eal/include/sys/queue.h | 320 ++ 1 file changed, 320 insertions

[dpdk-dev] [PATCH v3 7/8] doc: add documention for windows

2019-03-19 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS

[dpdk-dev] [PATCH v3 6/8] eal: add minimum viable code for eal on windows

2019-03-19 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c

[dpdk-dev] [PATCH v3 8/8] build: meson changes to build on windows

2019-03-19 Thread Anand Rawat
Added meson workarounds to build helloworld on windows. Windows currently only supports kvargs and eal libraries. This change restricts the build flow to supported libraries only. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon

[dpdk-dev] [PATCH v3 3/8] kvargs: adding a module definition file

2019-03-19 Thread Anand Rawat
adding a DEF file for kvargs to specify the exports for the creation of the shared library. Signed-off-by: Bruce Richardson Signed-off-by: Anand Rawat Reviewed-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_kvargs/rte_kvargs_exports.def | 7 +++ 1 file changed, 7 insertions

[dpdk-dev] [PATCH v3 0/8] HelloWorld example for windows

2019-03-19 Thread Anand Rawat
s notes: *patch 8/8 contains meson workarounds to build helloworld on windows, which will later be a part of the draft repository *command-line parsing is not a part of this version as a result lcore mask is currently not supported. Anand Rawat (8): eal: eal stub to add windows support eal:

[dpdk-dev] [PATCH v3 1/8] eal: eal stub to add windows support

2019-03-19 Thread Anand Rawat
Added initial stub source files for windows support and only the required meson changes for windows. Signed-off-by: Pallavi Kadam Signed-off-by: Anand Rawat Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 23 -- config/x86

[dpdk-dev] [PATCH v3 2/8] eal: add header files to support windows

2019-03-19 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_common.h to include rte_windows.h for windows build. Updated lib/meson.build to create shared libraries on windows. Added def file to list the exports for the eal library. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam

[dpdk-dev] [PATCH v3 5/8] eal: add headers for compatibility with windows environment

2019-03-19 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib

Re: [dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-13 Thread Anand Rawat
On 3/11/2019 5:45 AM, Jerin Jacob Kollanukkaran wrote: On Tue, 2019-03-05 at 20:16 -0800, Anand Rawat wrote: Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Anand Rawat Signed-off-by

Re: [dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-07 Thread Anand Rawat
On 3/7/2019 9:03 AM, Kovacevic, Marko wrote: Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon

Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-06 Thread Anand Rawat
On 3/6/2019 3:31 AM, Thomas Monjalon wrote: 06/03/2019 05:16, Anand Rawat: Added header files to support windows on x86 platforms. Updated rte_config to include rte_windows.h for windows build. [...] --- a/config/rte_config.h +++ b/config/rte_config.h +/* windows specific*/ +#ifdef

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-06 Thread Anand Rawat
lable tools + subdir('usertools') + subdir('app') + subdir('test') + + # build kernel modules if enabled + if get_option('enable_kmods') + subdir('kernel') + endif + + # build docs + subdir('doc') +endif I don't like modifying this file. Can we skip not supported directories inside the sub meson files? Since we now mandate meson 0.47 we can use the "subdir_done()" function to this. /Bruce Will be done as a part of v3 -- Anand Rawat

Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-06 Thread Anand Rawat
] [PATCH v2 1/6] eal: eal stub to add windows support 06/03/2019 12:20, Bruce Richardson: On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: Hi, 06/03/2019 05:16, Anand Rawat: -# some libs depend on maths lib -add_project_link_arguments('-lm', language: 'c')

Re: [dpdk-dev] [PATCH v2 0/6] HelloWorld example for windows

2019-03-06 Thread Anand Rawat
On 3/6/2019 12:29 AM, Thomas Monjalon wrote: Hi, 06/03/2019 05:16, Anand Rawat: v2 Changes: Incorporated reviews from v1. Fixed license period for updated files. Renamed 'winapp' folder to 'windows'. Cleaned unneeded meson changes. Fixed code style warnings. Added maintai

[dpdk-dev] [PATCH v2 4/6] eal: add minimum viable code for eal on windows

2019-03-05 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Update meson logic to build eal on windows. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common/meson.build | 94

[dpdk-dev] [PATCH v2 5/6] examples: add meson changes for windows

2019-03-05 Thread Anand Rawat
Add meson changes to build helloworld example on windows. Only EAL is supported currently. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- examples/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-05 Thread Anand Rawat
Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- MAINTAINERS

[dpdk-dev] [PATCH v2 3/6] eal: add headers for compatibility with windows environment

2019-03-05 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon

[dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support

2019-03-05 Thread Anand Rawat
Added initial stub source files for windows support and meson changes to build them. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/meson.build | 22 --- config/x86/meson.build | 14

[dpdk-dev] [PATCH v2 0/6] HelloWorld example for windows

2019-03-05 Thread Anand Rawat
ntainers information for windows branch lcore mask parameter for helloworld will be supported from v3. Anand Rawat (6): eal: eal stub to add windows support eal: add header files to support windows eal: add headers for compatibility with windows environment eal: add minimum viable cod

[dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows

2019-03-05 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_config to include rte_windows.h for windows build. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- config/rte_config.h | 7

Re: [dpdk-dev] [PATCH 0/6] HelloWorld example for Windows

2019-03-05 Thread Anand Rawat
On 3/4/2019 2:13 AM, David Marchand wrote: On Fri, Mar 1, 2019 at 2:48 PM Bruce Richardson mailto:bruce.richard...@intel.com>> wrote: On Thu, Feb 28, 2019 at 11:18:41PM -0800, Anand Rawat wrote: > Helloworld example for Windows. > Includes Windows-specific EAL

[dpdk-dev] [PATCH 6/6] doc: add documention for windows

2019-02-28 Thread Anand Rawat
Add documentation to build helloworld example on windows using meson and clang. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- doc/guides/index.rst | 1 + doc/guides/windows_gsg/build_dpdk.rst | 76

[dpdk-dev] [PATCH 5/6] examples: Add meson changes for windows

2019-02-28 Thread Anand Rawat
Add meson changes to build helloworld example on windows. Only EAL is supported currently. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- examples/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

[dpdk-dev] [PATCH 4/6] eal: add minimum viable code for eal on windows

2019-02-28 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Update meson logic to build eal on windows. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common/meson.build | 43

[dpdk-dev] [PATCH 2/6] eal: Add header files to support windows

2019-02-28 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_config to include rte_windows.h for windows build. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- config/rte_config.h | 15

[dpdk-dev] [PATCH 3/6] eal: Add headers for compatibility with windows environment

2019-02-28 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon

[dpdk-dev] [PATCH 0/6] HelloWorld example for Windows

2019-02-28 Thread Anand Rawat
Helloworld example for Windows. Includes Windows-specific EAL changes and meson changes to build the code on Windows. Anand Rawat (6): eal: eal stub to add windows support eal: Add header files to support windows eal: Add headers for compatibility with windows environment eal: add minimum

[dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support

2019-02-28 Thread Anand Rawat
Added initial stub source files for windows support and meson changes to build them. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- config/meson.build| 28 +-- config/x86/meson.build