[PATCH v2 7/9] net/dpaa2: configure buffer layout

2025-05-20 Thread Gagandeep Singh
From: Jun Yang Make header room big enough for IPSec with TX dynamic confirm enabled. Ingress minimum header room: 64(size of parser result) + 8(address of SEC context) * 2. Egress minimum header room: 88(FAEAD offset) + 8(FAEAD size) + 8(address of SEC context) * 2 + 114(expansion). Signed-off-

[PATCH v2 6/9] crypto/dpaa2_sec: add null algo capability

2025-05-20 Thread Gagandeep Singh
This patch adds NULL algo capabilities. Signed-off-by: Gagandeep Singh --- doc/guides/cryptodevs/dpaa2_sec.rst | 2 + doc/guides/cryptodevs/features/dpaa2_sec.ini | 2 + drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h| 41 3 files changed, 45 insertions(+) diff --g

[PATCH v2 4/9] crypto/dpaa2_sec: change custom device API to standard

2025-05-20 Thread Gagandeep Singh
Replacing existing device creation and deletion code in probe and remove functions with rte_cryptodev_pmd_create() and rte_cryptodev_pmd_destroy() APIs provided by the DPDK library, simplifying drivers initialization and teardown. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2

[PATCH v2 5/9] crypto/dpaa2_sec: fix coverity Issues

2025-05-20 Thread Gagandeep Singh
From: Vanshika Shukla Fixes the uninitialized variable issue - reported by NXP internal coverity. Fixes: 1182b364312c ("crypto/dpaax_sec: set authdata in non-auth case") Cc: g.si...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Vanshika Shukla --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1

[PATCH v2 3/9] common/dpaax: support 12bit SN in pdcp uplane

2025-05-20 Thread Gagandeep Singh
update pdcp_insert_uplane_no_int_op() to support 12bit SN size Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/pdcp.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/common/dpaax/caamflib/desc/pdcp.h b/drivers/common/dpaax/caamflib

[PATCH v2 2/9] common/dpaax: fix for PDCP AES only 12bit SN case

2025-05-20 Thread Gagandeep Singh
This workaround fixes the invalid key command SEC error. Fixes: 6127fff842a7 ("common/dpaax: remove outdated caamflib code") Cc: franck.lenorm...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/pdcp.h | 16 ++-- 1 file changed, 14 ins

[PATCH v2 1/9] common/dpaax: fix invalid key command error

2025-05-20 Thread Gagandeep Singh
A race condition between loading the key into CAAM’s internal memory and initiating cryptographic operations can cause SEC errors in PDCP AES algorithm combinations. To mitigate this, the CALM instruction is added for the 12-bit SN case, and the older version of the descriptor is used for the 18-b

[PATCH v2 0/9] DPAA2 crypto driver changes

2025-05-20 Thread Gagandeep Singh
V2 changes: - fix checkpatch warning - fix 32 bit compilation error - fix a commit message - update document Gagandeep Singh (5): common/dpaax: fix invalid key command error common/dpaax: fix for PDCP AES only 12bit SN case common/dpaax: support 12bit SN in pdcp uplane crypto/dpaa2_sec

RE: [EXTERNAL] Re: [PATCH v6 1/2] ethdev: support RSS based on RoCEv2 header

2025-05-20 Thread Kiran Kumar Kokkilagadda
From: Stephen Hemminger Sent: Tuesday, May 20, 2025 8:47 PM To: Kiran Kumar Kokkilagadda Cc: Aman Singh ; Thomas Monjalon ; Ferruh Yigit ; Andrew Rybchenko ; dev@dpdk.org Subject: [EXTERNAL] Re: [PATCH v6 1/2] ethdev: support RSS based on RoCEv2 header On Mon, 5 May 2025 11: 27: 15 +0530 w

[PATCH v2 2/2] app/testpmd: clear stale internal len information

2025-05-20 Thread skori
From: Sunil Kumar Kori hdr_lens is used to maintain header lengths after parsing packets. When port receives different type of packets (say first is VXLAN packet and second is GRE packet). For first packet, L2/L3/L4 lengths are set for inner and outer header alongwith tunnel_len. Now for second

RE: [PATCH] eal: fix return value of lcore role

2025-05-20 Thread Morten Brørup
> From: Pavan Nikhilesh > > Update rte_lcore_has_role() to return false instead of a > negative value for invalid lcore IDs, removing the need > for callers to pre-validate the ID. > > Fixes: b0a1502a277c ("eal: make semantics of lcore role function more > intuitive") > Cc: sta...@dpdk.org > >

RE: [EXTERNAL] Re: [PATCH 2/2] app/testpmd: clear stale internal len information

2025-05-20 Thread Sunil Kumar Kori
> On Mon, 19 May 2025 21:36:56 +0530 > wrote: > > > From: Sunil Kumar Kori > > > > hdr_lens is used to maintain header lengths after parsing packets. > > When port receives different type of packets (say first is VXLAN > > packet and second is GRE packet). > > > > For first packet, L2/L3/L4 leng

RE: [EXTERNAL] Re: [PATCH 1/2] net: fix offset calculation for GENEVE packet

2025-05-20 Thread Sunil Kumar Kori
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 21, 2025 2:52 AM > To: Sunil Kumar Kori > Cc: Jie Hai ; dev@dpdk.org > Subject: [EXTERNAL] Re: [PATCH 1/2] net: fix offset calculation for GENEVE > packet > > On Mon, 19 May 2025 21: 36: 55 +0530 wrote: > From: > Sun

RE: [PATCH 3/9] common/dpaax: support 12bit SN in pdcp uplane

2025-05-20 Thread Gagandeep Singh
Hi, > -Original Message- > From: Hemant Agrawal (OSS) > Sent: Tuesday, May 20, 2025 11:49 AM > To: Gagandeep Singh ; dev@dpdk.org; Hemant Agrawal > ; Sachin Saxena > Subject: Re: [PATCH 3/9] common/dpaax: support 12bit SN in pdcp uplane > > > On 20-05-2025 11:21, Gagandeep Singh wrote:

RE: [PATCH 1/9] common/dpaax: fix invalid key command error

2025-05-20 Thread Gagandeep Singh
Hi, > -Original Message- > From: Hemant Agrawal (OSS) > Sent: Tuesday, May 20, 2025 11:46 AM > To: Gagandeep Singh ; dev@dpdk.org; Hemant Agrawal > ; Sachin Saxena ; Franck > Lenormand ; Akhil Goyal > Cc: sta...@dpdk.org > Subject: Re: [PATCH 1/9] common/dpaax: fix invalid key command er

Re: [PATCH] eal: add getline() function for Windows

2025-05-20 Thread Andre Muezerie
On Tue, May 20, 2025 at 10:14:33AM -0700, Stephen Hemminger wrote: > On Mon, 5 May 2025 13:40:07 -0700 > Andre Muezerie wrote: > > > Existing DPDK code uses getline(), which is a POSIX function and is > > not available in the Windows APIs. > > > > Instead of rewriting it or coming up with some

[PATCH] net/mana: check for vendor_part_id when probing RDMA device

2025-05-20 Thread longli
From: Long Li The RDMA kernel driver may expose two MANA RDMA devices, for RC and RAW QP types. The purpose is to support fast service mode at SOC. Depending on kernel version, the probe may fail if DPDK picks up the wrong device. Add check for vendor_part_id and RAW QP capability when probing t

Re: [PATCH 1/2] net: fix offset calculation for GENEVE packet

2025-05-20 Thread Stephen Hemminger
On Mon, 19 May 2025 21:36:55 +0530 wrote: > From: Sunil Kumar Kori > > While parsing packet headers, offset must be added to get next > header but for geneve header parsing offset is overwritten. > Also inner_l2_len is not set in case of geneve packets. > > Fixes: 64ed7f854cf4 ("net: add tunne

Re: [PATCH 2/2] app/testpmd: clear stale internal len information

2025-05-20 Thread Stephen Hemminger
On Mon, 19 May 2025 21:36:56 +0530 wrote: > From: Sunil Kumar Kori > > hdr_lens is used to maintain header lengths after parsing packets. > When port receives different type of packets (say first is VXLAN > packet and second is GRE packet). > > For first packet, L2/L3/L4 lengths are set for in

Re: [RFC v2 1/6] dts: rework config module to support perf TGs

2025-05-20 Thread Dean Marx
> + - dest_mac: 3c:fd:fe:d5:e5:f9 # MAC OF LOOPBACK TO IT'S DUAL INTERFACE > +src_mac: 3c:fd:fe:d5:e5:f8 > + - dest_mac: 3c:fd:fe:d5:e5:f8 # MAC OF LOOPBACK TO IT'S DUAL INTERFACE > +src_mac: 3c:fd:fe:d5:e5:f9 Should be its not it's I like the concept of having a conf

[PATCH] eal: fix return value of lcore role

2025-05-20 Thread pbhagavatula
From: Pavan Nikhilesh Update rte_lcore_has_role() to return false instead of a negative value for invalid lcore IDs, removing the need for callers to pre-validate the ID. Fixes: b0a1502a277c ("eal: make semantics of lcore role function more intuitive") Cc: sta...@dpdk.org Suggested-by: Morten

Re: [PATCH] net/mlx5: fix transceiver warning when not exist

2025-05-20 Thread Stephen Hemminger
On Mon, 5 May 2025 12:14:51 + Yogev Chaimovich wrote: > From ffe666291bc531b89620cc28a7b45fa209700f35 Mon Sep 17 00:00:00 2001 > From: yogev > Date: Sun, 4 May 2025 23:11:46 +0300 > Subject: [PATCH] net/mlx5: fix transceiver warning when not exist > > In case no transceiver exist when tryin

[PATCH] examples/symmetric_mp: log/ignore promiscuous fail

2025-05-20 Thread mamcgove
From: Matthew G McGovern The example apps have a few different failure modes when enabling promiscuous mode: - testpmd will warn about the failure and continue. - l3fwd has a flag '-P' to explicitly require promiscuous mode. - symmetric_mp will exit with an error code This patch changes symm

Re: meson error on ARM Grace server 23.11/22.11

2025-05-20 Thread Patrick Robb
Hi Doug, Without overburdening you with details, at the CI lab we have some tests which run with werror=true (treat warnings as errors) and some which run without it. The tests which I'm currently trying to extend to LTS for Grace do not have this flag included, i.e. they are tolerant to warnings.

Re: [PATCH] bus/pci: introduce get_iova_mode for pci dev

2025-05-20 Thread Stephen Hemminger
On Thu, 24 Apr 2025 12:34:09 + Kyo Liu wrote: > I propose this patch for DPDK to enable coexistence between > DPDK and kernel drivers for regular NICs.This solution requires > adding a new pci_ops in rte_pci_driver, through which DPDK will > retrieve the required IOVA mode from the vendor dri

RE: meson error on ARM Grace server 23.11/22.11

2025-05-20 Thread Doug Foster
Hi Patrick, While building 22.11 and 23.11 with GCC 13.3, I noticed compiler warnings related to memcpy usage, specifically involving __builtin___memcpy_chk failures. Would these warnings be a concern for CI test runs, or are they generally tolerated? From: Doug Foster Sent: Friday, May 16, 202

[RFC PATCH 5/7] eal: gather EAL args before processing

2025-05-20 Thread Bruce Richardson
DPDK traditionally has iterated through all args and processed them as they appear in the commandline. The arg processing logic can be simplified if instead we initially gather all arguments into a structure which is then processed with the arguments dealt with in a fixed/known order. Signed-off-b

[RFC PATCH 7/7] eal: simplify handling of conflicting cmdline options

2025-05-20 Thread Bruce Richardson
Use a utility function and macro to simplify the code for checking for conflicting cmdline options. The checking can also be done at the initial argument collating stage, shortening the argument processing function which is very much on the long side. Signed-off-by: Bruce Richardson --- lib/eal/

[RFC PATCH 6/7] eal: combine parameter validation checks

2025-05-20 Thread Bruce Richardson
Remove the separate function to check combinations of cmdline parameters. Instead, just do those checks when parsing the parameters since we have all info about what parameters are provided at that point. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_common_memory.c | 3 +- lib/eal/c

[RFC PATCH 4/7] eal: define the EAL parameters in argparse format

2025-05-20 Thread Bruce Richardson
This table should allow us to parse all the eal args into a single structure for later parsing in a fixed-order field basis. For those elements that take multiple values, define a TAILQ and a callback to process those elements. Signed-off-by: Bruce Richardson --- Note: Within the structure to st

[RFC PATCH 2/7] argparse: add support for string and boolean args

2025-05-20 Thread Bruce Richardson
Sometimes we don't want to parse the string at all, when doing arg parsing, and just save it off for later. Add support for that. Also, rather than assuming boolean values have to be the same size as uint8 (or some other size), add an explicitly type for that - which also allows checking for true/

[RFC PATCH 3/7] argparse: make argparse EAL-args compatible

2025-05-20 Thread Bruce Richardson
The argparse library was missing two key features which made it unsuitable for use by EAL or any program wanting similar behaviour. 1. It didn't stop parsing arguments when it hit a "--" character 2. It never returned the number of arguments parsed Fix both these issues - the latter is a change t

[RFC PATCH 1/7] eal: add long options for each short option

2025-05-20 Thread Bruce Richardson
To simplify future rework of the EAL arg handling, add a long-option equivalent for each short option that doesn't already have one. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 9 + lib/eal/common/eal_options.h| 16 2 files changed,

[RFC PATCH 0/7] rework EAL argument parsing in DPDK

2025-05-20 Thread Bruce Richardson
This RFC is just an initial prototype of one approach we may want to take to help improve management of EAL cmdline arguments. Although not complete (no account taken yet for BSD or Windows), it's hopefully complete enough to give an idea of what I think would improve the handling. BACKGROUND: - T

Re: [PATCH v5 2/3] cmdline: add floating point support

2025-05-20 Thread Stephen Hemminger
On Wed, 7 May 2025 16:22:11 +0100 Anatoly Burakov wrote: > Add support for parsing floating point numbers in cmdline library, as well > as unit tests for the new functionality. Use C library for parsing. > > Signed-off-by: Anatoly Burakov This looks good, please resolve the checkpatch warning

Re: [PATCH] net/tap: fix add qdisc failed when create tap

2025-05-20 Thread Stephen Hemminger
On Mon, 12 May 2025 16:22:04 +0800 luyan <973788...@qq.com> wrote: > From: luyan > > The errno variable was assigned a positive value in the previous handling, > but here it is compared against -EEXIST, > When the tap already exists, this would falsely report an error. > > Signed-off-by: luyan

Re: [PATCH] ethdev: optimize how the values of the flag variables are assigned

2025-05-20 Thread Stephen Hemminger
On Thu, 8 May 2025 10:17:44 +0200 Morten Brørup wrote: > Wouldn't the correct fix assume the change has no effect if the operation > failed, like the _enable_ functions do, i.e.: > > int > rte_eth_promiscuous_disable(uint16_t port_id) > { > struct rte_eth_dev *dev; > int diag = 0; >

Re: [RFC 00/18] add hinic3 PMD driver

2025-05-20 Thread Stephen Hemminger
On Fri, 18 Apr 2025 15:02:38 +0800 Feifei Wang wrote: > *** BLURB HERE *** > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > Feifei Wang (3): > net/hinic3: add intro doc for hinic3 > net/hinic3: add

Re: [RFC 01/18] net/hinic3: add intro doc for hinic3

2025-05-20 Thread Stephen Hemminger
On Fri, 18 Apr 2025 15:02:39 +0800 Feifei Wang wrote: > diff --git a/doc/guides/rel_notes/release_25_07.rst > b/doc/guides/rel_notes/release_25_07.rst > index 093b85d206..1d65cf7829 100644 > --- a/doc/guides/rel_notes/release_25_07.rst > +++ b/doc/guides/rel_notes/release_25_07.rst > @@ -24,37 +

Re: [PATCH v6 1/2] ethdev: support RSS based on RoCEv2 header

2025-05-20 Thread Stephen Hemminger
On Mon, 5 May 2025 11:27:15 +0530 wrote: > @@ -149,6 +151,7 @@ const struct rss_type_info rss_type_table[] = { > { "l3-dst-only", RTE_ETH_RSS_L3_DST_ONLY }, > { "l3-src-only", RTE_ETH_RSS_L3_SRC_ONLY }, > { "ipv6-flow-label", RTE_ETH_RSS_IPV6_FLOW_LABEL }, > + { "ib_bth", RTE

[PATCH] eal/linux: unregister alarm callback before free ptr

2025-05-20 Thread Rui Ferreira
This was flagged by Address sanitizer as a use after free. The intr_handle ptr is shared between the main thread and the interrupt thread, and the interrupt thread can dereference the ptr after free is called when the main thread cleans up (from the alarm callback). The interrupt thread never term

Re: [PATCH 1/1] net/nbl add doc and minimun nbl build framework

2025-05-20 Thread Stephen Hemminger
On Thu, 24 Apr 2025 11:49:19 + Kyo Liu wrote: > Signed-off-by: Kyo Liu > diff --git a/MAINTAINERS b/MAINTAINERS > index 9b8bb60023..4cf891a312 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1020,6 +1020,15 @@ F: drivers/net/sfc/ > F: doc/guides/nics/sfc_efx.rst > F: doc/guides/nics/

Re: [RFC PATCH v4 3/3] ethdev: introduce the cache stashing hints API

2025-05-20 Thread Stephen Hemminger
On Sat, 17 May 2025 15:17:35 + Wathsala Vithanage wrote: > Extend the ethdev library to enable the stashing of different data > objects, such as the ones listed below, into CPU caches directly > from the NIC. > > - Rx/Tx queue descriptors > - Rx packets > - Packet headers > - packet payloads

Re: [Bug Report] KNI Module Causes Loopback Interface to Have Incorrect ifindex in Linux 5.4.46

2025-05-20 Thread Stephen Hemminger
On Wed, 23 Apr 2025 13:52:39 +0800 nan he wrote: > Dear DPDK Developers, > > I am reporting an issue encountered in an environment running Linux kernel > version 5.4.46 with DPDK 19.11. When attempting to run Docker containers in > bridge mode, the container creation fails consistently. The kmsg

Re: [PATCH 2/4] uapi: import VDUSE header from v6.14 kernel

2025-05-20 Thread Stephen Hemminger
On Wed, 16 Apr 2025 14:34:24 +0200 Maxime Coquelin wrote: > This header will be used by the Vhost library. > > Signed-off-by: Maxime Coquelin > --- > kernel/linux/uapi/linux/vduse.h | 353 > kernel/linux/uapi/version | 2 +- > 2 files changed, 354 inser

Re: [PATCH] event/eth_tx: prefetch mbuf headers

2025-05-20 Thread Mattias Rönnblom
On 2025-03-28 07:07, Mattias Rönnblom wrote: On 2025-03-28 06:43, Mattias Rönnblom wrote: Prefetch mbuf headers, resulting in ~10% throughput improvement when the Ethernet RX and TX Adapters are hosted on the same core (likely ~2x in case a dedicated TX core is used). Signed-off-by: Mattias Rön

[PATCH 3/9] common/dpaax: support 12bit SN in pdcp uplane

2025-05-20 Thread Gagandeep Singh
update pdcp_insert_uplane_no_int_op() to support 12bit SN size Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/pdcp.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/common/dpaax/caamflib/desc/pdcp.h b/drivers/common/dpaax/caamflib

RE: [PATCH] net/intel: fix ixgbe get macsec stats

2025-05-20 Thread Xu, HailinX
> -Original Message- > From: Kaiwen Deng > Sent: Tuesday, May 20, 2025 9:13 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Deng, KaiwenX ; Burakov, > Anatoly ; Medvedkin, Vladimir > ; Tiwei Bie ; Wenzhuo > Lu > Subject: [PATCH] net/intel: fix ixgbe get macsec stats > > The ixgbe macsec reg