> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Wednesday, May 21, 2025 2:52 AM
> To: Sunil Kumar Kori <sk...@marvell.com>
> Cc: Jie Hai <haij...@huawei.com>; dev@dpdk.org
> Subject: [EXTERNAL] Re: [PATCH 1/2] net: fix offset calculation for GENEVE
> packet
>
> On Mon, 19 May 2025 21: 36: 55 +0530 <skori@ marvell. com> wrote: > From:
> Sunil
> Kumar Kori <skori@ marvell. com> > > While parsing packet headers, offset must
> be added to get next > header but for geneve header parsing offset
>
> On Mon, 19 May 2025 21:36:55 +0530
> <sk...@marvell.com> wrote:
>
> > From: Sunil Kumar Kori <sk...@marvell.com>
> >
> > While parsing packet headers, offset must be added to get next header
> > but for geneve header parsing offset is overwritten.
> > Also inner_l2_len is not set in case of geneve packets.
> >
> > Fixes: 64ed7f854cf4 ("net: add tunnel packet type parsing")
> >
> > Signed-off-by: Sunil Kumar Kori <sk...@marvell.com>
>
> Looks good, but why reorder the assignment to *off ?
>
> Could just be:
>
No specific reason. It can be kept as it is. I will fix in next version.
