Re: pcapng_autotest unit test false positive

2025-05-14 Thread David Marchand
On Tue, Apr 2, 2024 at 2:46 AM Stephen Hemminger wrote: > > On Mon, 1 Apr 2024 18:26:44 -0400 > Patrick Robb wrote: > > > Another idea - maybe multiple timestamps are gathered from different > > CPU registers during the same test, and they are misaligned for that > > reason. Maybe we can try redu

Re: [PATCH] examples: remove check for old broken pkg-config

2025-05-14 Thread David Marchand
On Wed, May 14, 2025 at 12:03 PM Bruce Richardson wrote: > > The version of pkg-config shipped with RHEL 7 had issues reporting the > linker flags for DPDK, meaning we couldn't build the examples statically > using it. However, as RHEL 7 is no longer supported by future DPDK > releases, we can dro

Re: [PATCH] doc/linux_gsg: remove note referring to old pkg-config

2025-05-14 Thread David Marchand
On Tue, Apr 8, 2025 at 7:19 PM Bruce Richardson wrote: > > Latest DPDK releases no longer officially support RHEL 7 as a target > platform, so remove the note about pkg-config not working on those > systems. > > Signed-off-by: Bruce Richardson Applied, thanks. -- David Marchand

[PATCH v2] net/intel: reduce size of common Tx queue struct

2025-05-14 Thread Shaiq Wani
Removed redundant and unused fields from the idpf pmd specific field in common Tx queue structure to reduce its memory footprint. Signed-off-by: Shaiq Wani --- drivers/net/intel/common/tx.h | 6 +-- drivers/net/intel/cpfl/cpfl_ethdev.c | 6 --- drivers/net/intel/cpfl/c

[DPDK/examples Bug 1707] What Materials Are Best for a Tensile Gazebo Structure in Rajasthan?

2025-05-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1707 Bug ID: 1707 Summary: What Materials Are Best for a Tensile Gazebo Structure in Rajasthan? Product: DPDK Version: unspecified Hardware: All OS: All Stat

Re: [PATCH v1 4/4] change verification field in unified packet suite

2025-05-14 Thread Nicholas Pratte
Looks good! Reviewed-by: Nicholas Pratte On Thu, Mar 6, 2025 at 4:47 PM Dean Marx wrote: > > Changes the unified packet testing suite to use layer 4 > destination ports as packet verification IDs. > > Signed-off-by: Dean Marx > --- > dts/tests/TestSuite_uni_pkt.py | 106 --

Re: [PATCH v1 3/4] dts: remove unnecessary capability requirement

2025-05-14 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Thu, Mar 6, 2025 at 4:47 PM Dean Marx wrote: > > Remove capability requirement from checksum offload test suite > that was not required to run the test cases. > > Signed-off-by: Dean Marx > --- > dts/tests/TestSuite_checksum_offload.py | 1 - > 1 file changed, 1

Re: [PATCH v1 2/4] dts: change verification field in checksum offload suite

2025-05-14 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Thu, Mar 6, 2025 at 4:47 PM Dean Marx wrote: > > Changes the checksum offload testing suite to use layer 4 > destination ports as packet verification IDs. > > Signed-off-by: Dean Marx > --- > dts/tests/TestSuite_checksum_offload.py | 130 ++--

Re: [PATCH v1 1/4] dts: add layer 4 port field to verbose parser

2025-05-14 Thread Nicholas Pratte
Makes sense to me! Reviewed-by: Nicholas Pratte On Thu, Mar 6, 2025 at 4:47 PM Dean Marx wrote: > > Add a field to the TestPmdVerbosePacket text parser > that stores destination port values for TCP/UDP packets. > > Signed-off-by: Dean Marx > --- > dts/framework/remote_session/testpmd_shell.py

[PATCH] net/ice: fix flow creation failure

2025-05-14 Thread Dhanya Pillai
In non-pipeline mode, priority is ignored, a flow rule can be created as a flow director rule or a switch rule depends on its pattern/action. Hence removing the priority field check from ice_fdir_parse which is causing valid flow creation to return failure. Signed-off-by: Dhanya Pillai --- drive

Re: [PATCH v3 05/13] net/ice: use the common Rx queue structure

2025-05-14 Thread Bruce Richardson
On Mon, May 12, 2025 at 01:54:31PM +0100, Anatoly Burakov wrote: > Make the ice driver use the new common Rx queue structure. > > Because the ice driver supports both 16-byte and 32-byte descriptor > formats (controlled by RTE_LIBRTE_ICE_16BYTE_RX_DESC define), the common > queue structure has to

Re: [PATCH v3 04/13] net/i40e: use the common Rx queue structure

2025-05-14 Thread Bruce Richardson
On Mon, May 12, 2025 at 01:54:30PM +0100, Anatoly Burakov wrote: > Make the i40e driver use the new common Rx queue structure. > > Because the i40e driver supports both 16-byte and 32-byte descriptor > formats (controlled by RTE_LIBRTE_I40E_16BYTE_RX_DESC define), the common > queue structure has

Re: [PATCH v3 03/13] net/ixgbe: create common Rx queue structure

2025-05-14 Thread Bruce Richardson
On Mon, May 12, 2025 at 01:54:29PM +0100, Anatoly Burakov wrote: > In preparation for deduplication effort, generalize the Rx queue structure. > > Most of the fields are simply moved to common/rx.h, clarifying the comments > where necessary. There are some instances where the field is renamed when

Re: [PATCH v3 02/13] net/iavf: make IPsec stats dynamically allocated

2025-05-14 Thread Bruce Richardson
On Mon, May 12, 2025 at 01:54:28PM +0100, Anatoly Burakov wrote: > Currently, the stats structure is directly embedded in the queue structure. > We're about to move iavf driver to a common Rx queue structure, so we can't > have driver-specific structures that aren't pointers, inside the common > qu

Re: [PATCH v3 01/13] net/ixgbe: remove unused field in Rx queue struct

2025-05-14 Thread Bruce Richardson
On Mon, May 12, 2025 at 01:54:27PM +0100, Anatoly Burakov wrote: > The `rdh` (read head) field in the `ixgbe_rx_queue` struct is not used > anywhere in the codebase, and can be removed. > > Signed-off-by: Anatoly Burakov With the one comment below fixed. Acked-by: Bruce Richardson > --- > d

Re: [PATCH v1 1/2] app/testpmd: harmonize case in help strings

2025-05-14 Thread Bruce Richardson
On Wed, May 14, 2025 at 02:02:11PM +0100, Anatoly Burakov wrote: > Most testpmd help strings are lower case. Amend those that aren't. > > Signed-off-by: Anatoly Burakov > --- > app/test-pmd/cmdline.c| 4 ++-- > app/test-pmd/cmdline_tm.c | 36 ++-- > 2 files c

Re: [PATCH v1 3/4] dts: remove unnecessary capability requirement

2025-05-14 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v1 4/4] change verification field in unified packet suite

2025-05-14 Thread Luca Vizzarro
The changes look fine, so this is for them: Reviewed-by: Luca Vizzarro But the commit subject/body need amendment. The `dts: ` component prefix is missing in the subject On 06/03/2025 22:47, Dean Marx wrote: Changes the unified packet testing suite to use layer 4 destination ports as packet

Re: [PATCH v1 2/4] dts: change verification field in checksum offload suite

2025-05-14 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v1 1/4] dts: add layer 4 port field to verbose parser

2025-05-14 Thread Luca Vizzarro
Hi Dean, looks good to me. Just a minor optional nit. Reviewed-by: Luca Vizzarro On 06/03/2025 22:47, Dean Marx wrote: +#: +l4_dport: int | None = field( +default=None, +metadata=TextParser.find_int(r"(?:Destination TCP port=|Destination UDP port=)(\d+)"), +) th

Re: [PATCH v1 2/2] app/testpmd: sort commands by help string

2025-05-14 Thread Bruce Richardson
On Wed, May 14, 2025 at 02:02:12PM +0100, Anatoly Burakov wrote: > When using '?' to find commands, it occasionally is difficult to find the > needed commands because all commands are not in alphabetical order, but > rather can be ordered rather arbitrarily. > > To address this, use help string to

[PATCH] net/intel: reduce size of common Tx queue struct

2025-05-14 Thread Shaiq Wani
Removed redundant and unused fields from the idpf pmd specific field in common Tx queue structure to reduce its memory footprint. Signed-off-by: Shaiq Wani --- drivers/net/intel/common/tx.h | 6 +--- drivers/net/intel/cpfl/cpfl_ethdev.c | 6 drivers/net/intel/cpfl

[PATCH] crypto/qat: add caching of the asym config

2025-05-14 Thread Arkadiusz Kusztal
Added caching option of asymmetric crypto parameters. This helps to avoid cleaning of unused data and allows introducing the options to reuse the previous setup. Signed-off-by: Arkadiusz Kusztal --- drivers/crypto/qat/qat_asym.c | 125 ++ drivers/crypto/qat/qat_as

[PATCH v1 2/2] app/testpmd: sort commands by help string

2025-05-14 Thread Anatoly Burakov
When using '?' to find commands, it occasionally is difficult to find the needed commands because all commands are not in alphabetical order, but rather can be ordered rather arbitrarily. To address this, use help string to order commands. This sacrifices some amount of grouping (i.e. when tm comm

[PATCH v1 1/2] app/testpmd: harmonize case in help strings

2025-05-14 Thread Anatoly Burakov
Most testpmd help strings are lower case. Amend those that aren't. Signed-off-by: Anatoly Burakov --- app/test-pmd/cmdline.c| 4 ++-- app/test-pmd/cmdline_tm.c | 36 ++-- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/app/test-pmd/cmdline.c

Re: [PATCH v4 3/3] doc: provide examples of using lcores EAL parameter

2025-05-14 Thread Bruce Richardson
On Wed, May 14, 2025 at 01:38:59PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, 13 May 2025 18.17 > > > > The "--lcores" EAL parameter has a very powerful syntax that can be > > used > > to provide precise control over lcore mappings

RE: [PATCH v4 3/3] doc: provide examples of using lcores EAL parameter

2025-05-14 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, 13 May 2025 18.17 > > The "--lcores" EAL parameter has a very powerful syntax that can be > used > to provide precise control over lcore mappings. The docs however, only > provided a minimal description of what it can do

Re: [PATCH] net/gve: remove gve-specific PCI revision ID macros

2025-05-14 Thread David Marchand
Hello, Thanks for the cleanup. On Wed, May 14, 2025 at 2:46 AM Joshua Washington wrote: > > Patch doesn't apply to the main branch of dpdk-next-net: > https://mails.dpdk.org/archives/test-report/2025-May/877522.html > > It seems like the diffbase patch only exists in the for-main branch. > When

[PATCH] examples: remove check for old broken pkg-config

2025-05-14 Thread Bruce Richardson
The version of pkg-config shipped with RHEL 7 had issues reporting the linker flags for DPDK, meaning we couldn't build the examples statically using it. However, as RHEL 7 is no longer supported by future DPDK releases, we can drop the check for this condition from all the Makefiles. More recent p

Re: [PATCH] doc/linux_gsg: remove note referring to old pkg-config

2025-05-14 Thread Bruce Richardson
On Wed, May 14, 2025 at 11:12:27AM +0200, David Marchand wrote: > On Tue, Apr 8, 2025 at 7:19 PM Bruce Richardson > wrote: > > > > Latest DPDK releases no longer officially support RHEL 7 as a target > > platform, so remove the note about pkg-config not working on those > > systems. > > > > Signed

[PATCH v2] test/crypto: increment dequeue timeout

2025-05-14 Thread Gowrishankar Muthukrishnan
Increment dequeue timeout to allow implementations taking longer cycles. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - no changes. only for CI. --- app/test/test_cryptodev_asym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/

[DPDK/core Bug 1706] CPU affinity of registered non-EAL threads not reflected in lcore configuration

2025-05-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1706 Bug ID: 1706 Summary: CPU affinity of registered non-EAL threads not reflected in lcore configuration Product: DPDK Version: 25.03 Hardware: All OS: All

Re: [PATCH] doc/linux_gsg: remove note referring to old pkg-config

2025-05-14 Thread David Marchand
On Tue, Apr 8, 2025 at 7:19 PM Bruce Richardson wrote: > > Latest DPDK releases no longer officially support RHEL 7 as a target > platform, so remove the note about pkg-config not working on those > systems. > > Signed-off-by: Bruce Richardson Reviewed-by: David Marchand I see examples still r

Re: [PATCH v2] net/mlx5: fix the maximal queue size query

2025-05-14 Thread Raslan Darawsheh
Hi, On 14/05/2025 10:55 AM, Viacheslav Ovsiienko wrote: The mlx5 PMD manages the device using two modes: the Verbs API and the DevX API. Each API offers its own method for querying the maximum work queue size (in descriptors). The corrected patch enhanced the rte_eth_dev_info_get() API support

RE: [EXTERNAL] [PATCH v2 9/9] app/test: add zsda cryptodev test

2025-05-14 Thread Akhil Goyal
> Add crypto test for zsda device and driver. > > Signed-off-by: Hanxiao Li > --- > app/test/test_cryptodev.c| 7 +++ > app/test/test_cryptodev.h| 1 + > doc/guides/compressdevs/zsda.rst | 6 ++ > 3 files changed, 14 insertions(+) > > diff --git a/app/test/test_cryptodev

[PATCH v2] net/mlx5: fix the maximal queue size query

2025-05-14 Thread Viacheslav Ovsiienko
The mlx5 PMD manages the device using two modes: the Verbs API and the DevX API. Each API offers its own method for querying the maximum work queue size (in descriptors). The corrected patch enhanced the rte_eth_dev_info_get() API support in mlx5 PMD to return the true maximum number of descriptor

RE: [EXTERNAL] [PATCH v2 0/9] crypto/zsda: add zsda cryptodev driver

2025-05-14 Thread Akhil Goyal
Hi Hanxiao, I have completed my first level review. Please rework and rebase on TOT and ensure all patches are getting compiled sequentially. Thanks for your patience. Will try to merge in RC1 if all goes well. Regards, Akhil > v2: > - Modify the errors about cryptodevs/zsda.rst. > - Modify th

[PATCH] net/mlx5: fix mark action value in shared Rx queue setup

2025-05-14 Thread Gregory Etelson
Patch `2d8763432add` was not applied correctly. As a result, `mlx5_rxq_data::mark_flag` was assigned wrong value. Fixes: 2d8763432add ("net/mlx5: fix shared Rx queue data access race") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file

RE: [EXTERNAL] [PATCH v2 5/9] crypto/zsda: add session configuration

2025-05-14 Thread Akhil Goyal
> +static void > +zsda_sym_session_clear(struct rte_cryptodev *dev __rte_unused, > +struct rte_cryptodev_sym_session *sess __rte_unused) > +{} I believe you need to clear session private data in session clear.

RE: [EXTERNAL] [PATCH v2 3/9] crypto/zsda: add statistics

2025-05-14 Thread Akhil Goyal
> Add crypto statistics operations for zsda devices. > > Signed-off-by: Hanxiao Li > --- > drivers/crypto/zsda/zsda_sym_pmd.c | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c > b/drivers/crypto/zsda/zsda_sym_pmd

RE: [EXTERNAL] [PATCH v2 4/9] crypto/zsda: add queue pair configuration

2025-05-14 Thread Akhil Goyal
> Add crypto queue pair configuration operations for zsda device. > > Signed-off-by: Hanxiao Li > --- > drivers/crypto/zsda/zsda_sym_pmd.c | 68 +- > 1 file changed, 66 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c > b/drivers/cryp

RE: [EXTERNAL] [PATCH v2 2/9] crypto/zsda: add device operations

2025-05-14 Thread Akhil Goyal
> Add crypto device operations for zsda devices. > > Signed-off-by: Hanxiao Li > --- > drivers/crypto/zsda/zsda_sym_pmd.c | 94 -- > 1 file changed, 89 insertions(+), 5 deletions(-) > > diff --git a/drivers/crypto/zsda/zsda_sym_pmd.c > b/drivers/crypto/zsda/zsda_sym_