Re: [PATCH v2 0/7] dts: shell improvements

2025-04-24 Thread Patrick Robb
Thanks for this series Luca. Dean did a review earlier and I have just done one so we're almost good to proceed. I should probably apply it and do a testrun before merging, which should be possible tomorrow (Friday). I will flag that when I tried to apply the series, git complained of a sha1 issue

Re: [PATCH v2 7/7] dts: enable shell pooling

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 6/7] dts: remove multi-inheritance classes

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 5/7] dts: make shells path dynamic

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 4/7] dts: revert back to a single InteractiveShell

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 3/7] dts: add shells pool

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb > >

Re: [PATCH v2 2/7] dts: add blocking dpdk app class

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb

[PATCH 08/13] net/sxe: add dcb function

2025-04-24 Thread Jie Liu
From: JieLiu Add dcb function. Signed-off-by: Jie Liu --- drivers/net/sxe/Makefile| 2 + drivers/net/sxe/meson.build | 1 + drivers/net/sxe/pf/rte_pmd_sxe.h| 3 +- drivers/net/sxe/pf/sxe.h| 2 + drivers/net/sxe/pf/sxe_dcb.c

[PATCH 12/13] net/sxe: add simd function

2025-04-24 Thread Jie Liu
From: JieLiu Add simd function. Signed-off-by: Jie Liu --- drivers/net/sxe/Makefile| 7 + drivers/net/sxe/base/sxe_queue_common.c | 55 ++ drivers/net/sxe/base/sxe_rx_common.c| 145 - drivers/net/sxe/meson.build | 9 + drivers/net/sxe/pf/sxe.h

[PATCH 07/13] net/sxe: support rss offload

2025-04-24 Thread Jie Liu
From: JieLiu Support rss offload. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 12 +- drivers/net/sxe/pf/sxe.h | 2 + drivers/net/sxe/pf/sxe_ethdev.c | 12 +- drivers/net/sxe/pf/sxe_offload.c | 298 ++ driver

[PATCH 04/13] net/sxe: add link, flow ctrl, mac ops, mtu ops function

2025-04-24 Thread Jie Liu
From: JieLiu Add link, flow ctrl, mac ops, mtu ops function. Signed-off-by: Jie Liu --- drivers/net/sxe/Makefile |3 + drivers/net/sxe/meson.build|3 + drivers/net/sxe/pf/sxe.h | 18 + drivers/net/sxe/pf/sxe_ethdev.c| 287 drivers/net/sxe/pf/

[PATCH 09/13] net/sxe: support ptp

2025-04-24 Thread Jie Liu
From: JieLiu Add ptp module. Signed-off-by: Jie Liu --- drivers/net/sxe/Makefile| 1 + drivers/net/sxe/meson.build | 1 + drivers/net/sxe/pf/sxe.h| 9 ++ drivers/net/sxe/pf/sxe_ethdev.c | 9 ++ drivers/net/sxe/pf/sxe_ptp.c| 210

[PATCH 11/13] net/sxe: add custom cmd led ctrl

2025-04-24 Thread Jie Liu
From: JieLiu Add custom cmd led ctrl. Signed-off-by: Jie Liu --- drivers/net/sxe/Makefile| 2 + drivers/net/sxe/include/sxe/sxe_cli.h | 218 drivers/net/sxe/include/sxe/sxe_ioctl.h | 21 +++ drivers/net/sxe/meson.build | 2 + drivers/

[PATCH 05/13] net/sxe: support vlan filter

2025-04-24 Thread Jie Liu
From: JieLiu Support vlan filter. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 4 + drivers/net/sxe/pf/sxe.h | 4 + drivers/net/sxe/pf/sxe_ethdev.c | 17 ++ drivers/net/sxe/pf/sxe_filter.c | 277 ++ drivers

[PATCH 01/13] net/sxe: add base driver directory and doc

2025-04-24 Thread Jie Liu
From: JieLiu Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver. Signed-off-by: Jie Liu --- MAINTAINERS | 6 +++ doc/guides/nics/features/sxe.ini| 82 + doc/guides/nics/feat

[PATCH 06/13] net/sxe: add mac layer filter function

2025-04-24 Thread Jie Liu
From: JieLiu Add mac layer filter function. Signed-off-by: Jie Liu --- drivers/net/sxe/pf/sxe.h| 1 + drivers/net/sxe/pf/sxe_ethdev.c | 16 ++- drivers/net/sxe/pf/sxe_filter.c | 191 drivers/net/sxe/pf/sxe_filter.h | 29 + drivers/net/sxe/pf/sxe

[PATCH 10/13] net/sxe: add xstats function

2025-04-24 Thread Jie Liu
From: JieLiu Add xstats function. Signed-off-by: Jie Liu --- drivers/net/sxe/Makefile| 1 + drivers/net/sxe/meson.build | 1 + drivers/net/sxe/pf/sxe.h| 2 + drivers/net/sxe/pf/sxe_ethdev.c | 22 ++ drivers/net/sxe/pf/sxe_main.c | 2 + drivers/net/sxe/pf/sxe_stat

Re: [PATCH v2 1/7] dts: escape single quotes

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 00/45] Support AMD Solarflare X45xx adaptors

2025-04-24 Thread Stephen Hemminger
On Wed, 23 Apr 2025 19:59:17 +0400 Ivan Malov wrote: > New X4522 (dual port SFP56) and X4542 (dual port QSFP56) adaptors are > Medford4 (X4) chips that are based on EF10 architecture. An X4 NIC > supports multiple network engine types. This series provides support > only for the Medford2-alike, '

Re: [PATCH v2 18/45] common/sfc_efx/base: update MCDI headers

2025-04-24 Thread Stephen Hemminger
On Wed, 23 Apr 2025 19:59:35 +0400 Ivan Malov wrote: > Pick up new X4 network port MCDI defines. > > Signed-off-by: Ivan Malov > Reviewed-by: Andy Moreton > Reviewed-by: Pieter Jansen Van Vuuren > --- Lots of spelling errors in base code. ## [PATCH] common/sfc_efx/base: update MCDI headers

Re: 23.11.4 patches review and test

2025-04-24 Thread Ali Alnubani
On 4/21/25 5:19 PM, Xueming Li wrote: Hi all, Here is a list of patches targeted for stable release 23.11.4. The planned date for the final release is 25th April. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final

Re: [PATCH v2 7/7] dts: enable shell pooling

2025-04-24 Thread Dean Marx
Hi Luca, I've read through each patch and it looks good to me, but I did run into some issues applying the series on my end. It seems like the rebase messed something up with git, might need to do another version with a new rebase. Otherwise, Reviewed-by: Dean Marx

Re: [PATCH v2 6/7] dts: remove multi-inheritance classes

2025-04-24 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v2 5/7] dts: make shells path dynamic

2025-04-24 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v2 4/7] dts: revert back to a single InteractiveShell

2025-04-24 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v2 3/7] dts: add shells pool

2025-04-24 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v2 2/7] dts: add blocking dpdk app class

2025-04-24 Thread Dean Marx
Reviewed-by: Dean Marx

Re: [PATCH v2 1/7] dts: escape single quotes

2025-04-24 Thread Dean Marx
Reviewed-by: Dean Marx

[PATCH v2] trace: fix out of bounds write in __rte_trace_mem_get

2025-04-24 Thread Oleksandr Nahnybida
Offset should be aligned first before checking if there is free space for another write. Bugzilla ID: 1665 Fixes: 032a7e5499a0 ("trace: implement provider payload") Signed-off-by: Oleksandr Nahnybida --- Specified correct "Fixes" commit. lib/eal/include/rte_trace_point.h | 4 +--- 1 file chang

Re: [PATCH 2/2] dts: add port control testing suite

2025-04-24 Thread Patrick Robb
On Wed, Apr 23, 2025 at 9:48 PM Patrick Robb wrote: > From: Jeremy Spewock > Should add: @requires(topology_type=TopologyType.two_links) > +class TestPortControl(TestSuite): > +"""DPDK Port Control Testing Suite.""" > + > +def send_packets_and_verify(self) -> None: > +"""Send 10

Re: [PATCH v2 2/2] crypto/ipsec_mb: fix QP release in secondary

2025-04-24 Thread Yang Ming
Hi, On 2025/4/7 13:25, Yang Ming wrote: From: myang When a secondary process tries to release a queue pair (QP) that does not belong to it, error logs occur: CRYPTODEV: ipsec_mb_ipc_request() line 373: Unable to release qp_id=0 EAL: Message data is too long EAL: Fail to handle message: ipsec_m

[DPDK/ethdev Bug 1699] Bonding device documentation missing

2025-04-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1699 Bug ID: 1699 Summary: Bonding device documentation missing Product: DPDK Version: 25.03 Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priori

Re: [PATCH v2] doc: reword flow offload and api docs

2025-04-24 Thread Nandini Persad
Thanks Stephen. I think I know how to fix it. Might have to submit a new patch From: Stephen Hemminger Sent: Thursday, April 24, 2025 9:08:58 AM To: Nandini Persad Cc: dev@dpdk.org Subject: Re: [PATCH v2] doc: reword flow offload and api docs On Thu, 10 Apr 2025

Re: [PATCH v2] ethdev: add support for flow action pop E-tag

2025-04-24 Thread Stephen Hemminger
On Tue, 22 Apr 2025 11:17:17 +0530 wrote: > From: Kiran Kumar K > > Add support for the following OpenFlow-defined action. > > RTE_FLOW_ACTION_TYPE_OF_POP_ETAG: Pop E-tag from the packet. > > Signed-off-by: Kiran Kumar K I don't think flow actions should be added until/unless a current in t

Re: [PATCH v2] doc: reword flow offload and api docs

2025-04-24 Thread Stephen Hemminger
On Thu, 10 Apr 2025 11:39:31 -0700 Nandini Persad wrote: > I removed low level details of the code from the Flow Offload > section of the Programmer's Guide so that it is more about > the general usage of the APIs. I moved the specific details > and definitions of the constants/function to the AP

[PATCH] net/tap: do not force inline or unroll

2025-04-24 Thread Stephen Hemminger
The BPF code in TAP device was using outdated advice on how to write BPF programs. Modern BPF verifier has to do less work if force inlining and unrolling is not done. Signed-off-by: Stephen Hemminger --- drivers/net/tap/bpf/tap_rss.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletio

Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq

2025-04-24 Thread Van Haaren, Harry
> From: Gregory Etelson > Sent: Sunday, April 20, 2025 9:57 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce; owen.hily...@unh.edu > Subject: Re: [PATCH] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq > > Hello Harry, > > I implemented a working echo server with your API. > Th

[PATCH v2] net/mlx5: mitigate the Tx queue parameter adjustment

2025-04-24 Thread Viacheslav Ovsiienko
he DPDK API rte_eth_tx_queue_setup() has a parameter nb_tx_desc specifying the desired queue capacity, measured in packets. The ConnectX NIC series has a hardware-imposed queue size limit of 32K WQEs (packet hardware descriptors). Typically, one packet requires one WQE to be sent. There is a spec

Re: [PATCH v4 1/2] dts: add clearing port stats to testpmd shell

2025-04-24 Thread Patrick Robb
Reviewed-by: Patrick Robb Tested-by: Patrick Robb

Re: [PATCH v4 1/2] dts: add clearing port stats to testpmd shell

2025-04-24 Thread Patrick Robb
Applied to next-dts, thanks.

Re: [PATCH v4 2/2] dts: add port stats checks test suite

2025-04-24 Thread Patrick Robb
Applied to next-net, thanks. >

Re: [PATCH v4 2/2] dts: add port stats checks test suite

2025-04-24 Thread Patrick Robb
On Thu, Feb 20, 2025 at 4:24 PM Dean Marx wrote: > This patch adds a new test suite to DTS that validates the accuracy of > the port statistics using testpmd. The functionality is tested by > sending a packet of a fixed side to the SUT and verifying that the > Just updating side to size before I

[DPDK/examples Bug 1698] rte_eth_rx_burst causes segmentation fault when encountered in a Secondary process

2025-04-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1698 Bug ID: 1698 Summary: rte_eth_rx_burst causes segmentation fault when encountered in a Secondary process Product: DPDK Version: 23.11 Hardware: x86 OS: Linux

Re: [25.11 PATCH 1/3] dmadev: add enqueue dequeue operations

2025-04-24 Thread fengchengwen
Hi Pavan, On 2025/4/16 18:09, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add enqueue/dequeue operations that use struct rte_dma_op > to communicate with the dma device. > These operations need to be enabled at dma device configuration > time by setting the flag rte_dma_conf::ena

Re: [PATCH v9 4/5] app/graph: add custom feature nodes for ip4 output arc

2025-04-24 Thread Patrick Robb
All tests are passing now: https://lab.dpdk.org/results/dashboard/patchsets/33044/ Again, sorry about the oversight. On Wed, Apr 23, 2025 at 4:40 PM Patrick Robb wrote: > Hi Nitin, > > At the DPDK Community Lab, we inadvertently let CI testing on your patch > run concurrently with some system m