RE: [PATCH] net/ice: fix ACL filter uninit

2025-02-24 Thread Li, HongboX
> -Original Message- > From: Mingjin Ye > Sent: Friday, February 21, 2025 4:25 PM > To: dev@dpdk.org > Cc: Ye, MingjinX ; Richardson, Bruce > ; Burakov, Anatoly > > Subject: [PATCH] net/ice: fix ACL filter uninit > > The pf has enabled the ACL filter, so uninit is no longer limited to th

[PATCH 2/2] net/xsc: suppress assign the same value warning

2025-02-24 Thread Renyong Wan
This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v1048/ This warning is harmless since both structs have the same size. The tool is just being annoying, so we should suppress it. Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc

[PATCH 0/2] net/xsc: Resolve warnings from PVS

2025-02-24 Thread Renyong Wan
This patch series resolves two warnings reported by PVS studio. --- Renyong Wan (2): net/xsc: check possible null pointer dereference net/xsc: suppress assign the same value warning drivers/net/xsc/xsc_rx.c| 6 +- drivers/net/xsc/xsc_vfio_mbox.c | 2 +- 2 files changed, 6 inserti

[PATCH 1/2] net/xsc: check possible null pointer dereference

2025-02-24 Thread Renyong Wan
This issue was reported by PVS studio, described as: https://pvs-studio.com/en/docs/warnings/v522/ Signed-off-by: Rong Qian Signed-off-by: Renyong Wan --- drivers/net/xsc/xsc_rx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/xsc/xsc_rx.c b/drivers/net/xsc

[PATCH 3/3] net/mlx5: allow FDB RSS

2025-02-24 Thread Suanming Mou
RSS can be used in FDB Rx rules when JUMP_FDB_RX action to allow jump from FDB Tx to FDB Rx table. Different with NIC RSS, FDB RSS will not do the internal implicit metadata copy. This commit enables the FDB RSS if JUMP_FDB_RX is supported. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5

[PATCH] net/nfp: fix get represetor wrong port stats

2025-02-24 Thread Chaoyong He
From: Long Wu The 'ipackets'/'opackets' are used to record the number of packets on represetor port received/sent. But the code does not consider concurrent calculation of 'ipackets'/'opackets'. If multiple queues are calculated 'ipackets'/'opackets' simultaneously, it will result in incorrect re

[PATCH 2/3] net/mlx5: add jump FDB Rx flag

2025-02-24 Thread Suanming Mou
When jump FDB Rx is supported, flow will be able to jump from FDB Tx to FDB Rx, in that case the dest action in FDB Rx table should support FDB Tx as well. Signed-off-by: Suanming Mou --- drivers/common/mlx5/mlx5_devx_cmds.c | 8 drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/net/m

[PATCH 1/3] net/mlx5/hws: support jump FDB Rx

2025-02-24 Thread Suanming Mou
Before FW introduced the JUMP_FDB_RX action feature, jump from FDB Tx to Rx is not allowed. JUMP_FDB_RX feature introduces the internal loopback for Tx case and allow the REG C0 C1 B be preserved as well. This commit adds the JUMP_FDB_RX cap bit check and use JUMP_FDB_RX instead of FT for dest tab

[PATCH 0/3] net/mlx5: support jump FDB Rx

2025-02-24 Thread Suanming Mou
Before FW introduced the JUMP_FDB_RX action feature, jump from FDB Tx to Rx is not allowed. JUMP_FDB_RX feature introduces the internal loopback for Tx case and allow the REG C0 C1 B be preserved as well. This series adds the jump from FDB Tx to FDB Rx support and allows RSS action in FDB domain r

[PATCH 6/6] member: make compatible with instruction set updates for MSVC

2025-02-24 Thread Andre Muezerie
File meson.build was updated to handle the correct AVX512 flags depending on compiler used. Signed-off-by: Andre Muezerie --- lib/member/meson.build | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/member/meson.build b/lib/member/meson.build index f92cbb7f25..8

[PATCH 4/6] drivers/net: make compatible with instruction set updates for MSVC

2025-02-24 Thread Andre Muezerie
Top level 'cc_avx2_flags' was created and holds the correct flags depending on the compiler used. Signed-off-by: Andre Muezerie --- drivers/net/bnxt/meson.build | 2 +- drivers/net/enic/meson.build | 2 +- drivers/net/intel/i40e/meson.build | 2 +- drivers/net/intel/iavf/meson.build

[PATCH 5/6] acl: make compatible with instruction set updates for MSVC

2025-02-24 Thread Andre Muezerie
Top level 'cc_avx2_flags' was created and holds the correct flags depending on the compiler used. File meson.build was updated to handle the correct AVX512 flags depending on compiler used. Signed-off-by: Andre Muezerie --- lib/acl/meson.build | 16 +--- 1 file changed, 9 insertions

[PATCH 0/6] allow faster instruction sets to be used with MSVC

2025-02-24 Thread Andre Muezerie
Up to now MSVC has being used with the default mode, which uses SSE2 instructions for scalar floating-point and vector calculations. https://learn.microsoft.com/en-us/cpp/build/reference/arch-x64?view=msvc-170 This series allows users to specify the CPU for which the generated code should be optim

[PATCH 3/6] config: allow faster instruction sets to be used with MSVC

2025-02-24 Thread Andre Muezerie
Up to now MSVC has being used with the default mode, which uses SSE2 instructions for scalar floating-point and vector calculations. https://learn.microsoft.com/en-us/cpp/build/reference/arch-x64?view=msvc-170 This patch allows users to specify the CPU for which the generated code should be optimi

[PATCH 1/6] eal: make compatible with instruction set updates for MSVC

2025-02-24 Thread Andre Muezerie
After the instruction set updates for MSVC the error below poped up: ../lib/eal/common/rte_random.c(6): fatal error C1083: Cannot open include file: 'x86intrin.h': No such file or directory The fix is to not include header x86intrin.h with MSVC. Signed-off-by: Andre Muezerie --- lib/eal/co

[PATCH 2/6] eal: only use numbers as align parameters for MSVC

2025-02-24 Thread Andre Muezerie
After the instruction set updates for MSVC the error below poped up: ..\lib\eal\x86\include\rte_vect.h(82): error C2059: syntax error: '(' The issue is that MSVC does not allow __rte_aligned(RTE_X86_ZMM_SIZE). It only accepts numbers that are power of 2. So, even though RTE_X86_ZMM_SIZE represent

Re: [PATCH v7 1/4] bus/pci: fix registration of PCI device

2025-02-24 Thread Stephen Hemminger
On Wed, 12 Feb 2025 18:38:32 +0200 Shani Peretz wrote: > When registering a new PCI device, the device->name field stored > the user-provided string from devargs (e.g., "08:00.0" or ":08:00.0"). > This approach led to inconsistencies when registering new devices. > > This patch fix this issu

Re: [PATCH v13 00/28] [v13]drivers/net Add Support mucse N10 Pmd Driver

2025-02-24 Thread Stephen Hemminger
On Thu, 20 Feb 2025 13:06:30 +0800 "11" wrote: > Hi Stephen, > > For the release thing, that be ok. > > But for Debian 12 with MUSDK it be failed, do I need to fixed it , > The ability when I used it that I had been memset it. But the compile-tool > is warning it, > hw->phy_port_ids[idx] = abi

Re: [PATCH v6 2/2] net/af_xdp: Refactor af_xdp_tx_zc

2025-02-24 Thread Stephen Hemminger
On Sat, 1 Feb 2025 00:10:21 +0100 Ariel Otilibili wrote: > @ -559,21 +582,12 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, > uint16_t nb_pkts) > mbuf = bufs[i]; > > if (mbuf->pool == umem->mb_pool) { > - if (!xsk_ring_prod__reserve(&txq->

RE: [PATCH v0 1/1] dma/cnxk: support pending count per HW DMA channel

2025-02-24 Thread Jerin Jacob
> -Original Message- > From: Vamsi Krishna > Sent: Tuesday, February 11, 2025 10:36 PM > To: dev@dpdk.org > Cc: Jerin Jacob ; Vamsi Krishna Attunuru > > Subject: [PATCH v0 1/1] dma/cnxk: support pending count per HW DMA > channel > > From: Vamsi Attunuru > > Adds code changes to mai

[PATCH v5 2/3] crypto/ipsec_mb: add SM4 GCM support

2025-02-24 Thread Brian Dooley
This patch introduces SM4 GCM algorithm support to the AESNI_MB PMD. SM4 GCM is available in the v2.0 release of Intel IPsec MB. Signed-off-by: Brian Dooley --- v2: Added aad to cpu job params Added ipsec mb version checks v3: Fix naming for patchwork v4: Remove cr

[PATCH v5 3/3] app/test: add SM4 GCM tests

2025-02-24 Thread Brian Dooley
Added SM4-GCM tests for the AESNI MB PMD. Signed-off-by: Brian Dooley --- v4: Remove MAX_AAD_LENGTH array length from test vectors --- app/test/test_cryptodev.c | 158 + app/test/test_cryptodev_aead_test_vectors.h | 708 2 files changed, 866 ins

[PATCH v5 1/3] cryptodev: add SM4 GCM

2025-02-24 Thread Brian Dooley
Added support for symmetric algorithm SM4 GCM in cryptodev. Signed-off-by: Brian Dooley --- v5: Change with GCM mode to in GCM mode --- doc/guides/cryptodevs/features/default.ini | 2 ++ lib/cryptodev/rte_crypto_sym.h | 4 +++- lib/cryptodev/rte_cryptodev.c | 3 +

RE: [PATCH v3 01/33] net/cnxk: allow duplicate SPI in outbound IPsec

2025-02-24 Thread Jerin Jacob
> -Original Message- > From: Nithin Dabilpuram > Sent: Monday, February 24, 2025 3:22 PM > To: Jerin Jacob ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Harman Kalra > > Cc: dev@dpdk.org > Subject: [PATCH v3 01/33] net/cnx

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-24 Thread Ariel Otilibili
Hello Dmitry, hello Stephen; On Mon, Feb 24, 2025 at 4:42 PM Stephen Hemminger < step...@networkplumber.org> wrote: > The convention (back from Unix) is that errno is only set on failure. > Simpler fix would just to silently ignore NULL case. > Thanks for your feedback. Here they are addressed,

[PATCH v3 1/1] pcapng: fix null dereference in rte_pcapng_close

2025-02-24 Thread Ariel Otilibili
rte_pcapng_close() might dereference a null pointer; as example, PVS-Studio gives its usage in test_pcapng.c: indeed, that call to rte_pcapng_close() might receive a null pointer. Link: https://pvs-studio.com/en/docs/warnings/v522/ Link: https://github.com/DPDK/dpdk/blob/e5176f23ae8b31437c3e5eb87

[PATCH v3 0/1] pcapng: fix null dereference in rte_pcapng_close

2025-02-24 Thread Ariel Otilibili
Hello, This patch addresses a warning found by static analysis; courtesy of Stephen Hemminger. Thank you, --- v3 * silently ignores NULL pointers (Stephen Hemminger) * changed commit title v2 (https://inbox.dpdk.org/dev/20250223214123.447579-1-ariel.otilib...@6wind.com/) * rather change docume

[PATCH v6 06/10] test-pmd: avoid non-constant initializer

2025-02-24 Thread Andre Muezerie
Compiling with MSVC results in errors like the one below: app/test-pmd/cmdline_flow.c(8819): error C2099: initializer is not a constant Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline_flow.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-

[PATCH v6 08/10] test/test-pmd: declare lcore_count atomic

2025-02-24 Thread Andre Muezerie
Compiling with MSVC results in the error below: app/test/test_ring_perf.c(197): error C7712: address argument to atomic operation must be a pointer to an atomic integer, 'volatile unsigned int *' is not valid The fix is to mark lcore_count as atomic. Signed-off-by: Andre Muezerie Signed

[PATCH v6 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

2025-02-24 Thread Andre Muezerie
There's no MSVC equivalent for compiler extension __builtin_constant_p, so a workaround is needed. Signed-off-by: Andre Muezerie Acked-by: Chengwen Feng --- app/test/test_memcpy_perf.c | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/ap

[PATCH v6 00/10] enable "app" to be compiled with MSVC

2025-02-24 Thread Andre Muezerie
v6: - remove "volatile" and use rte_atomic_xxx to access the RTE_ATOMIC qualified lcore_count, which is cleaner than using "volatile". v5: - add "volatile" to declaration of lcore_count in test_ring_perf.c. v4: - add explanation about the expression used in __rte_constant during v3. v3: - use

[PATCH v6 07/10] test-pmd: don't return value from void function

2025-02-24 Thread Andre Muezerie
Compiling with MSVC results in the warning below: app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed': 'void' function returning a value Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test-pmd/cmdline_flow.c | 12 -

[PATCH v6 10/10] app: enable app directory to be compiled with MSVC

2025-02-24 Thread Andre Muezerie
Enabled "app" directory to be compiled with MSVC along with all its contents. Removed flag Wno-deprecated-declarations which is not needed anymore. Signed-off-by: Andre Muezerie Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- app/meson.build | 4 app/test-pmd/meson.build

[PATCH v6 04/10] test-pmd: do explicit 64-bit shift to avoid implicit conversion

2025-02-24 Thread Andre Muezerie
Compiling with MSVC results in warnings like the one below: app/test-pmd/util.c(201): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test

[PATCH v6 05/10] test-pmd: avoid undefined behavior

2025-02-24 Thread Andre Muezerie
Compiling with MSVC results in warnings like below: app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor directive in function-like macro argument list is undefined behavior Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 12

[PATCH v6 01/10] eal: add workaround for __builtin_constant_p

2025-02-24 Thread Andre Muezerie
There's no MSVC equivalent for compiler extension __builtin_constant_p, but the same result can be obtained through a clever expression using _Generic. This patch redefines the macro __rte_constant when msvc is used and uses it as a replacement for __builtin_constant_p. Signed-off-by: Andre Mueze

[PATCH v6 02/10] test_alarm: avoid warning about different qualifiers

2025-02-24 Thread Andre Muezerie
Compiling with MSVC results in the warning below: app/test/test_alarm.c(54): warning C4090: 'function': different '_Atomic' qualifiers The fix is to use a macro to explicitly drop the qualifier. Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test/test_alarm.c | 12

[PATCH v6 03/10] test-pmd: fix printf format string mismatch

2025-02-24 Thread Andre Muezerie
Compiling with MSVC results in warnings like the one below: app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'uint64_t' Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/tes

Re: [PATCH v5 08/10] test-pmd: declare lcore_count atomic

2025-02-24 Thread Andre Muezerie
On Fri, Feb 21, 2025 at 09:58:28PM +0100, Morten Brørup wrote: > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > Sent: Friday, 21 February 2025 20.53 > > > > Compiling with MSVC results in the error below: > > > > app/test/test_ring_perf.c(197): error C7712: address argument to a

Re: [PATCH 1/4] net/ena/base: upgrade ena-com to the latest version

2025-02-24 Thread Stephen Hemminger
On Mon, 24 Feb 2025 13:40:08 +0200 wrote: > @@ -768,8 +768,6 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 > mtu); > * > * @return: 0 on Success and negative value otherwise. > */ > -int ena_com_get_offload_settings(struct ena_com_dev *ena_dev, > -

Re: [PATCH v2 1/1] pcapng: warn if NULL is passed to rte_pcapng_close

2025-02-24 Thread Stephen Hemminger
On Sun, 23 Feb 2025 22:41:23 +0100 Ariel Otilibili wrote: > rte_pcapng_close() might dereference a null pointer; as example, > PVS-Studio gives its usage in test_pcapng.c: indeed, that call to > rte_pcapng_close() might receive a null pointer. > > In that case, rte_errno is set to EINVAL. The AP

Re: [PATCH v2 00/16] net/zxdh: updated net zxdh driver

2025-02-24 Thread Stephen Hemminger
On Mon, 24 Feb 2025 14:10:39 +0800 Junlong Wang wrote: > Hi maintainer, > Do these warnings need to be resolved? These warnings do need to be resolved, but not necessarily a blocker for inclusing now. > > The usage of this code is also supported by the standard C language, No VLA is a

[PATCH 3/3] doc/nics: document how to create large VFs for iavf

2025-02-24 Thread Bruce Richardson
Document the additional step necessary to create large VFs for iavf when using ice kernel driver v1.13.7 or later. Signed-off-by: Bruce Richardson --- doc/guides/nics/intel_vf.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst

[PATCH 2/3] doc/nics: rework notes for iavf use

2025-02-24 Thread Bruce Richardson
When describing the iavf driver, there was a lot of text in a single note block which could be clarified by splitting it up into separate sections and appropriate bulletted lists. Signed-off-by: Bruce Richardson --- doc/guides/nics/intel_vf.rst | 60 +--- 1 file c

[PATCH 1/3] doc/nics: improve structure of Intel VF section

2025-02-24 Thread Bruce Richardson
The Intel VF section in the NIC guide document had descriptions of the various drivers at a very deep level of the document hierarchy. Improve the structure of the doc by giving those per-driver subsections their own top-level section. Also create a new top-level section for details of hypervisor u

[PATCH 0/3] improve documentation iavf driver

2025-02-24 Thread Bruce Richardson
Some small cleanups and reformatting of the iavf driver documentation to make it easier to read. Also add an additional note on large VF support. Bruce Richardson (3): doc/nics: improve structure of Intel VF section doc/nics: rework notes for iavf use doc/nics: document how to create large V

[PATCH dpdk] net: fix IPv4 compat and mapped checks

2025-02-24 Thread Robin Jarry
The RFC states that the first 96 bits should be compared, not the first 32 bits. Add unit tests to ensure this works. Cc: sta...@dpdk.org Fixes: 3d6d85f58c1c ("net: add utilities for well known IPv6 address types") Reported-by: Junxiao Shi Closes: https://bugs.dpdk.org/show_bug.cgi?id=1664 Signe

Re: [PATCH] net/ice: fix incorrect mbuf cleanup function

2025-02-24 Thread Burakov, Anatoly
On 21/02/2025 17:04, Bruce Richardson wrote: The mbuf cleanup function is not being called correctly on close of the driver, due to the vector_tx flag not being set correctly on each Tx queue. Normally, this causes no visible problems, because the default is to have the vector flag unset, which m

[PATCH 1/6] dts: ensure runtime working directory

2025-02-24 Thread Luca Vizzarro
After loading the user's settings and supplied configuration files, make the dts folder the working directory for the runner. This allows DTS to easily access the local DPDK tree. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/main.py | 6 ++ 1 file changed, 6 insertions

[PATCH 5/6] dts: enable build-less DPDK driver binding

2025-02-24 Thread Luca Vizzarro
Add a facility to bind drivers for DPDK on runtimes where the DPDK build is lacking. This is needed to execute any program that is based on DPDK, but is unrelated to the testing. Bugzilla ID: 1420 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/dpdk.p

[PATCH 6/6] dts: restore TG setup and teardown

2025-02-24 Thread Luca Vizzarro
The setup and teardown was previously missed when reworking the execution internals into states. Add back the traffic generator setup and teardown respectively in TestRunSetup and TestRunTeardown. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/test_run.py

[PATCH 2/6] dts: use topology in smoke tests

2025-02-24 Thread Luca Vizzarro
The smoke tests where wrongly using all the node's ports for the smoke tests. Ensure only the ports specified in the current topology are used. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/tests/TestSuite_smoke_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 4/6] dts: decouple DPDK runtime from build

2025-02-24 Thread Luca Vizzarro
Allow the DPDKRuntimeEnvironment to work without an associated DPDK build. This is useful when executing any program that is based on DPDK, so that the common runtime functionality can be shared. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/context.py

[PATCH 0/6] dts: add build-less driver binding

2025-02-24 Thread Luca Vizzarro
Hi there, sending in a solution that could enable DTS to bind drivers for DPDK-based apps, like traffic generators, that lack the DPDK build to gather dpdk-devbind.py from. Best, Luca Luca Vizzarro (6): dts: ensure runtime working directory dts: use topology in smoke tests dts: add tmp dir

[PATCH 3/6] dts: add tmp directory facility

2025-02-24 Thread Luca Vizzarro
Add a facility to create and ues a temporary runtime directory on the remote nodes for each test run. This requires adding setup and teardown steps for Node. To ensure that setup is not performed twice in case of a loopback setup where the same node is used both as SUT and TG, an internal state ab

Re: [PATCH] power: use hugepage memory for queue list entry structure

2025-02-24 Thread lihuisong (C)
在 2025/2/24 19:12, Konstantin Ananyev 写道: 在 2025/2/20 17:41, Konstantin Ananyev 写道: Hi Hi all, Kindly ping for review. 在 2024/12/19 15:53, Huisong Li 写道: The queue_list_entry structure data is used in rx_callback of io path when enable PMD Power Management. However its memory is curren

[PATCH 3/4] net/ena: remove deprecated notifications

2025-02-24 Thread shaibran
From: Shai Brandes Remove deprecated asynchronous event notifications that may arrive from the device. The removal ensures that only supported event handling mechanisms are in use. Signed-off-by: Wajeeh Atrash Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 51 -

[PATCH 4/4] net/ena: upgrade driver version to 2.12.0

2025-02-24 Thread shaibran
From: Shai Brandes Upgrade ENA driver version to 2.12.0. Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 705b0b3a85..038b10eec2 100644 --- a/driver

[PATCH 0/4] net/ena: release 2.12.0

2025-02-24 Thread shaibran
From: Shai Brandes Dear DPDK maintainers and contributors, We would appreciate your review of the ENA driver 2.12.0 patchset, which includes readiness for the upcoming hardware generations. Your feedback and insights on the patchset would be highly appreciated. Thank you in advance for your time

[PATCH 1/4] net/ena/base: upgrade ena-com to the latest version

2025-02-24 Thread shaibran
From: Shai Brandes This update upgrades the ena-com module to the most recent version, which includes various cosmetic changes and the removal of obsolete routines. Signed-off-by: Shai Brandes --- drivers/net/ena/base/ena_com.c| 24 ++- drivers/net/ena/base/ena_

[PATCH 2/4] net/ena: add support for mutable RSS table size

2025-02-24 Thread shaibran
From: Shai Brandes This patch enables the configuration of a mutable RSS table size, allowing it to adapt to the device's capabilities instead of relying on a fixed 128 hardcoded value. Signed-off-by: Yosef Raisman Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- doc/guides/rel_no

RE: [PATCH] power: use hugepage memory for queue list entry structure

2025-02-24 Thread Konstantin Ananyev
> > 在 2025/2/20 17:41, Konstantin Ananyev 写道: > > Hi > > > >> Hi all, > >> > >> Kindly ping for review. > >> > >> > >> 在 2024/12/19 15:53, Huisong Li 写道: > >>> The queue_list_entry structure data is used in rx_callback of io path > >>> when enable PMD Power Management. However its memory is curr

Re: [PATCH] net/mlx5: fix err message overwrite for actions translation

2025-02-24 Thread Raslan Darawsheh
Hi, From: Junfeng Guo Sent: Thursday, February 20, 2025 9:08 AM To: dev@dpdk.org Cc: Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad; Minggang(Gavin) Li; Jiawei(Jonny) Wang; sta...@dpdk.org Subject: [PATCH] net/mlx5: fix err message overwrite for actions transla

[v5 5/5] examples/vhost_crypto: support asymmetric crypto

2025-02-24 Thread Gowrishankar Muthukrishnan
Support asymmetric crypto operations. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- v5: - doc update --- doc/guides/sample_app_ug/vhost_crypto.rst | 5 +++ examples/vhost_crypto/main.c | 50 +-- 2 files changed, 43 insertions(+), 12 delet

[v5 4/5] vhost: support asymmetric RSA crypto ops

2025-02-24 Thread Gowrishankar Muthukrishnan
Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- v5: - release notes --- doc/guides/rel_notes/release_25_03.rst | 3 + lib/vhost/vhost_crypto.c | 486 +++-- lib/vhost/virtio_crypto.h

[v5 3/5] examples/vhost_crypto: fix user callbacks

2025-02-24 Thread Gowrishankar Muthukrishnan
In order to handle new vhost user connection, use new_connection and destroy_connection callbacks. Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- examples/vhost_crypto/main.c | 4 ++--

[v5 2/5] vhost: update vhost_user crypto session parameters

2025-02-24 Thread Gowrishankar Muthukrishnan
As per requirements on vhost_user spec, session id should be located at the end of session parameter. Update VhostUserCryptoSessionParam structure to support newer QEMU versions (v9). Due to additional parameters added in QEMU, received payload from QEMU would be larger than existing payload. Henc

[v5 1/5] vhost: skip crypto op fetch before vring init

2025-02-24 Thread Gowrishankar Muthukrishnan
Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR), worker thread should not try to fetch crypto op, which would lead to memory fault. Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan Acked-b

[v5 0/5] vhost: add RSA support

2025-02-24 Thread Gowrishankar Muthukrishnan
This patch series supports asymmetric RSA in vhost crypto library. It also includes changes to improve vhost crypto library: * support newer QEMU versions. * fix broken vhost_crypto example application. * stabilize crypto fastpath operations. v5: - added docs. Gowrishankar Muthukrishnan (5):

[PATCH 2/2] net/txgbe: remove meaningless choice for SW-FW sync

2025-02-24 Thread Zaiyu Wang
Remove superfluous 'if' and 'else' for SW-FW sync. Bugzilla ID: 1581 Fixes: 5364a1ce30df ("net/txgbe: add PHY init") Cc: sta...@dpdk.org Signed-off-by: Zaiyu Wang --- drivers/net/txgbe/base/txgbe_phy.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/txgbe

[PATCH 1/2] net/ngbe: fix WOL and NCSI capability error

2025-02-24 Thread Zaiyu Wang
When determining NIC's WOL and NCSI capability via sub-system ID, flag matching must be exact, not inclusive. Misidentifying WOL/NCSI capability will skip PHY configuration, causing link-up failure. Fixes: 5f1ab0d529fc ("net/ngbe: add WOL and NCSI capability") Cc: sta...@dpdk.org Signed-off-by: Z

RE: [PATCH v5 08/10] test-pmd: declare lcore_count atomic

2025-02-24 Thread Konstantin Ananyev
> Subject: [PATCH v5 08/10] test-pmd: declare lcore_count atomic As a nit, the changes are not in testpmd, bit in the UT. Acked-by: Konstantin Ananyev > Compiling with MSVC results in the error below: > > app/test/test_ring_perf.c(197): error C7712: address argument to atomic > operati

[PATCH 0/2] Wangxun bug fixes

2025-02-24 Thread Zaiyu Wang
Fix some bugs for txgbe and ngbe. Zaiyu Wang (2): net/ngbe: fix WOL and NCSI capability error net/txgbe: remove meaningless choice for SW-FW sync drivers/net/ngbe/base/ngbe_hw.c| 8 +--- drivers/net/txgbe/base/txgbe_phy.c | 8 ++-- 2 files changed, 7 insertions(+), 9 deletions(-)

[PATCH v3 01/33] net/cnxk: allow duplicate SPI in outbound IPsec

2025-02-24 Thread Nithin Dabilpuram
Since outbound IPsec is not really dependent on SPI, allow duplicate SPI in outbound inline IPsec sessions. Signed-off-by: Nithin Dabilpuram --- v3: - Add cc stable to 29/33 patch v2: - Rebased on top of latest code - Fixed build issue with 26/33 - Updated release notes drivers/net/cnxk/cn10k

[PATCH v3 03/33] net/cnxk: remove unnecessary delay on stats read

2025-02-24 Thread Nithin Dabilpuram
Remove unnecessary delay on security stats read as application is expected to poll if stats are not updated as expected. It is expected that there would be a delay in stats to show up like any other ethdev stats get API. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev_sec.c |

[PATCH v3 33/33] common/cnxk: move interrupt handling to platform-specific

2025-02-24 Thread Nithin Dabilpuram
From: Satha Rao This change refactors the interrupt handling to be platform-specific. Some platforms directly call ioctls, while others provide a library API for the same functionality. Moving the interrupt handling to platform-specific implementations enhances clarity and maintainability. Signe

[PATCH v3 02/33] common/cnxk: remove unused param in SA init

2025-02-24 Thread Nithin Dabilpuram
From: Anoob Joseph Remove unused param in SA init. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 5 ++--- drivers/common/cnxk/cnxk_security.h | 3 +-- drivers/common/cnxk/roc_ie_ot.c | 4 +--- drivers/common/cnxk/roc_ie_ot.h | 3 +-- drivers/common/cnxk/

[PATCH v3 28/33] common/cnxk: enable allmulti mode on rpm/cgx VF

2025-02-24 Thread Nithin Dabilpuram
From: Monendra Singh Kushwaha This patch enables allmulti mode on rpm/cgx vf devices. Signed-off-by: Monendra Singh Kushwaha --- .mailmap | 1 + drivers/common/cnxk/roc_mbox.h| 1 + drivers/common/cnxk/roc_nix_npc.c | 10 +++--- 3 files changed, 9 insertions(

[PATCH v3 30/33] common/cnxk: add stats reset for inline device

2025-02-24 Thread Nithin Dabilpuram
From: Monendra Singh Kushwaha This patch adds support to reset inline device stats. Signed-off-by: Monendra Singh Kushwaha --- drivers/common/cnxk/roc_nix_inl.h | 1 + drivers/common/cnxk/roc_nix_inl_dev.c | 27 +++ drivers/common/cnxk/version.map | 1 + 3 f

[PATCH v3 22/33] common/cnxk: support for NPC inline rule for cn20k

2025-02-24 Thread Nithin Dabilpuram
Use UCAST_CPT in cn20k as opposed to UCAST_IPSEC in cn10k for inline IPsec rule. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/nix.h| 1 + drivers/common/cnxk/roc_npc.c | 15 +++ drivers/common/cnxk/roc_npc_mcam.c | 7 --- drivers/common

[PATCH v3 25/33] net/cnxk: store pool buffer size in lookup memory

2025-02-24 Thread Nithin Dabilpuram
From: Rahul Bhansali Store the pool buffer size in lookup memory to calculate mbuf start address for reassembly case in fastpath. Also, restructured lookup memory data per port. Signed-off-by: Rahul Bhansali --- drivers/net/cnxk/cn20k_ethdev.c | 17 + drivers/net/cnxk/cn20k_rxtx.h

[PATCH v3 18/33] common/cnxk: support for inline inbound queue

2025-02-24 Thread Nithin Dabilpuram
In CN20k, since we have 16 Inline inbound queues possible, add support to attach inline inbound queue directly to the application instead of getting it attached to CPT PF. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_features.h | 12 + drivers/common/cnxk/roc_mbox.h

[PATCH v3 13/33] common/cnxk: add cn20k meta pkt structs

2025-02-24 Thread Nithin Dabilpuram
From: Rahul Bhansali Adds below structures for cn20k, - cpt_parse_hdr_s - cpt_rxc_sg_s - cpt_rxc_ptr_info_s Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/hw/cpt.h| 211 +--- drivers/common/cnxk/roc_cpt.h | 2 +- drivers/common/cnxk/roc_cpt_debug.

[PATCH v3 09/33] common/cnxk: add CPT LMT defines

2025-02-24 Thread Nithin Dabilpuram
From: Anoob Joseph add CPT LMT defines Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_cpt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/common/cnxk/roc_cpt.h b/drivers/common/cnxk/roc_cpt.h index c8cf9354da..ac27479371 100644 --- a/drivers/common/cnxk/roc_cpt.h +++

[PATCH v3 31/33] common/cnxk: change the error log to a debug log

2025-02-24 Thread Nithin Dabilpuram
From: Srujana Challa This patch updates the error log to a debug log since it is not needed. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_nix_inl_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/

[PATCH v3 12/33] common/cnxk: support for cn20k IPsec session

2025-02-24 Thread Nithin Dabilpuram
Add support for cn20k IPsec session create/destroy. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/cnxk_security.c | 546 +++- drivers/common/cnxk/cnxk_security.h | 12 +- drivers/common/cnxk/version.map | 2 + 3 files changed, 557 insertions(+), 3 deleti

[PATCH v3 32/33] net/cnxk: update MC address list configure API

2025-02-24 Thread Nithin Dabilpuram
From: Satha Rao Return -ENOSPC when there is no space to update the complete MC address list, without flushing the existing list of addresses. Signed-off-by: Satha Rao --- drivers/net/cnxk/cnxk_ethdev_ops.c | 32 ++ 1 file changed, 24 insertions(+), 8 deletions(-)

[PATCH v3 11/33] common/cnxk: update default eng group for cn20k

2025-02-24 Thread Nithin Dabilpuram
CN20K does not have IE engines, hence change the default eng group for cn20k and use legacy for cn10k or older version. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_cpt.c | 6 +++--- drivers/common/cnxk/roc_cpt.h | 10 +++--- drivers/common/cnxk/roc_nix_inl.c

[PATCH v3 29/33] common/cnxk: fix inbound IPsec sa setup

2025-02-24 Thread Nithin Dabilpuram
Make sure the w2 in inbound SA is set for inline IPsec have L3 header on errors. Fixes: 350b7a536a51 ("common/cnxk: enable L3 header write back in SA") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/cnxk_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v3 10/33] common/cnxk: add 20k defines for IPsec

2025-02-24 Thread Nithin Dabilpuram
From: Anoob Joseph Add 20K defines for IPsec. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 1 + drivers/common/cnxk/roc_ie_ow.c | 41 +++ drivers/common/cnxk/roc_ie_ow.h | 537 drivers/common/cnxk

[PATCH v3 27/33] event/cnxk: inline IPsec Rx support for cn20k

2025-02-24 Thread Nithin Dabilpuram
From: Rahul Bhansali Inline IPsec Rx support for cn20k Signed-off-by: Rahul Bhansali --- doc/guides/rel_notes/release_25_03.rst | 1 + drivers/event/cnxk/cn20k_worker.h | 111 - 2 files changed, 108 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes

[PATCH v3 26/33] net/cnxk: inline IPsec Rx support for cn20k

2025-02-24 Thread Nithin Dabilpuram
From: Rahul Bhansali Inline IPsec Rx support for cn20k Signed-off-by: Rahul Bhansali --- drivers/event/cnxk/cn20k_worker.h | 4 +- drivers/net/cnxk/cn20k_rx.h | 736 -- 2 files changed, 688 insertions(+), 52 deletions(-) diff --git a/drivers/event/cnxk/cn20

[PATCH v3 07/33] common/cnxk: make special handling only for 9k

2025-02-24 Thread Nithin Dabilpuram
From: Anoob Joseph 9k would need special handling compared to 10k & 20k. Update the check to reflect the same. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_cpt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/

[PATCH v3 04/33] common/cnxk: move CTX defines to common

2025-02-24 Thread Nithin Dabilpuram
From: Anoob Joseph CTX defines are common for all cases using CPT CTX. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.h | 1 + drivers/common/cnxk/roc_cpt.h | 16 drivers/common/cnxk/roc_ie_ot.h | 16 drivers/net/cnxk/cn10k_rxtx.h

[PATCH v3 24/33] common/cnxk: update CPT RXC time config mbox for cn20k

2025-02-24 Thread Nithin Dabilpuram
From: Rahul Bhansali Sync in CPT_RXC_TIME_CFG mbox as per new fields added for cn20k and restructure to support it. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_mbox.h| 2 ++ drivers/common/cnxk/roc_nix_inl.c | 55 +-- drivers/common/cnxk/roc_nix_i

[PATCH v3 05/33] common/cnxk: add cn20k CPT result struct

2025-02-24 Thread Nithin Dabilpuram
From: Anoob Joseph CPT result structure is same as in cn10k. Add entry for cn20k. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/common/cnxk/hw/cpt.h b/drivers/common/cnxk/hw/cpt.h index 47df3fbf9f..b308a18f0

[PATCH v3 23/33] net/cnxk: support for cn20k inline IPsec session

2025-02-24 Thread Nithin Dabilpuram
Add support for cn20k inline IPsec session create/destroy. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev_sec.c |7 - drivers/net/cnxk/cn20k_ethdev.c | 11 + drivers/net/cnxk/cn20k_ethdev.h | 17 + drivers/net/cnxk/cn20k_ethdev_sec.c | 1182 +++

[PATCH v3 21/33] common/cnxk: add NPC action2 support

2025-02-24 Thread Nithin Dabilpuram
From: Rahul Bhansali Add action2 config for IPsec rule. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/hw/nix.h | 13 +++-- drivers/common/cnxk/roc_mbox.h | 1 + drivers/common/cnxk/roc_npc.h | 1 + drivers/common/cnxk/roc_npc_mcam.c | 1 + 4 files changed, 14

[PATCH v3 20/33] common/cnxk: add API to fetch inline profile ID

2025-02-24 Thread Nithin Dabilpuram
From: Rahul Bhansali For Inline device, add new roc API to get IPsec and reassembly profile id. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_nix_inl.c | 60 +++ drivers/common/cnxk/roc_nix_inl.h | 2 ++ 2 files changed, 62 insertions(+) diff --git a/d

[PATCH v3 19/33] common/cnxk: add NIX inline reassembly profile config

2025-02-24 Thread Nithin Dabilpuram
From: Rahul Bhansali Reassembly profile configuration for nix inline path. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_features.h | 6 + drivers/common/cnxk/roc_ie_ow.c| 22 +++ drivers/common/cnxk/roc_ie_ow.h| 2 + drivers/common/cnxk/roc_nix.h

  1   2   >