Re: [PATCH 08/32] event/dsw: replace memcpy with assignment

2025-02-11 Thread Mattias Rönnblom
On 2025-02-08 21:22, Stephen Hemminger wrote: Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- drivers/event/dsw/dsw_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/dsw/dsw_event.c b/d

Re: [PATCH v5 02/11] eal: add new secure free function

2025-02-11 Thread Stephen Hemminger
On Wed, 12 Feb 2025 10:01:13 +0800 fengchengwen wrote: > On 2025/2/12 1:35, Stephen Hemminger wrote: > > Although internally rte_free does poison the buffer in most > > cases, it is useful to have function that explicitly does > > this to avoid any security issues. > > > > Signed-off-by: Stephen

RE: [EXTERNAL] [PATCH v3 4/6] trace: support dumping binary inside a struct

2025-02-11 Thread Sunil Kumar Kori
> On Tue, Feb 11, 2025 at 9:53 AM Sunil Kumar Kori > wrote: > > > > > diff --git a/lib/eal/common/eal_common_trace_ctf.c > > > b/lib/eal/common/eal_common_trace_ctf.c > > > index 6bc8bb9036..d9b307e076 100644 > > > --- a/lib/eal/common/eal_common_trace_ctf.c > > > +++ b/lib/eal/common/eal_common_t

RE: [EXTERNAL] [PATCH v3 2/6] trace: support dereferencing arguments

2025-02-11 Thread Sunil Kumar Kori
> On Tue, Feb 11, 2025 at 9:44 AM Sunil Kumar Kori > wrote: > > > > > diff --git a/lib/eal/common/eal_common_trace_ctf.c > > > b/lib/eal/common/eal_common_trace_ctf.c > > > index 04c4f71462..3e4228ee7f 100644 > > > --- a/lib/eal/common/eal_common_trace_ctf.c > > > +++ b/lib/eal/common/eal_common_t

[PATCH] examples/l3fwd: adjust Tx burst size based on Rx burst

2025-02-11 Thread Sivaprasad Tummala
Previously, the TX burst size was fixed at 256, leading to performance degradation in certain scenarios. This patch introduces logic to set the TX burst size to match the configured RX burst size (--burst option, default 32, max 512) for better efficiency. Fixes: d5c4897ecfb2 ("examples/l3fwd: ad

Re: [PATCH v3 1/2] config/arm: strict use of -mcpu for supported CPUs

2025-02-11 Thread Thomas Monjalon
06/01/2025 19:31, Wathsala Vithanage: > Arm recommends using -mcpu over -march and march-extensions when the > compiler supports the target CPU (neoverse-n1 etc.). Arm build so far > has been an amalgam of -mcpu and -march. When march is in use, it has > been the case so far to silently fall back t

RE: [PATCH v9 12/28] net/rnp: add support link update operations

2025-02-11 Thread 11
Hi Stephen, For memcpy what ever base code or other code all used memcpy not rte_memcpy ? Even the memory is malloc from rte_malloc/zmalloc ? Regards Wenbo. > -Original Message- > From: Stephen Hemminger > Sent: 2025年2月11日 23:35 > To: Wenbo Cao > Cc: tho...@monjalon.net; dev@dpdk.org; f

RE: [PATCH v9 04/28] net/rnp: support mailbox basic operate

2025-02-11 Thread 11
Hi Stephen, This flag add will ignore some warning error ? > +error_cflags = ['-Wno-unused-value', > +'-Wno-unused-but-set-variable', > +'-Wno-unused-parameter', > +] Regards Wenbo > -Original Message- > From: Stephen Hemminger > Sent: 2025年2月11日 23:24 > To: Wenb

Re: [PATCH 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

2025-02-11 Thread Andre Muezerie
On Tue, Feb 11, 2025 at 02:13:05PM -0800, Stephen Hemminger wrote: > On Tue, 11 Feb 2025 14:02:05 -0800 > Andre Muezerie wrote: > > > There's no MSVC equivalent for compiler extension __builtin_constant_p, > > so a workaround is needed. > > > > Signed-off-by: Andre Muezerie > > Prefer that __r

Re: [PATCH v5 02/11] eal: add new secure free function

2025-02-11 Thread fengchengwen
On 2025/2/12 1:35, Stephen Hemminger wrote: > Although internally rte_free does poison the buffer in most > cases, it is useful to have function that explicitly does > this to avoid any security issues. > > Signed-off-by: Stephen Hemminger > --- > lib/eal/common/rte_malloc.c | 30 ++

RE: [PATCH v9 08/28] net/rnp: add queue setup and release operations

2025-02-11 Thread 11
Hi Stephe, The spinlock of rxq_reset_lock, and txq_reset than I need it to make sure one time just one user can call queue_stop operate a queue reset, hardware only support reset queue head to zero only one user operate. When queue_stop 0 and queue_stop 1 operate at the same time, the hardware qu

Re: [PATCH v5 08/11] test: remove unneeded memset

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 1:35, Stephen Hemminger wrote: > Since tmp is not used later in the function, this memset > is unnecessary. Even though this is harmless, > it causes tools that look for security issues > around memset to flag this a bug. > > Signed-off-by: Stephen Hemmi

Re: [PATCH v5 01/11] eal: introduce new secure memory fill

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 1:35, Stephen Hemminger wrote: > When memset() is used before a release function such as free, > the compiler if allowed to optimize the memset away under > the as-if rules. This is normally ok, but in certain cases such > as passwords or security keys it

Re: [PATCH 08/10] test-pmd: declare lcore_count atomic when using C11 memory model

2025-02-11 Thread Andre Muezerie
On Tue, Feb 11, 2025 at 02:12:12PM -0800, Stephen Hemminger wrote: > On Tue, 11 Feb 2025 14:02:04 -0800 > Andre Muezerie wrote: > > > Compiling with MSVC results in the error below: > > > > app/test/test_ring_perf.c(197): error C7712: address argument to atomic > > operation must be a pointe

Re: [PATCH 08/10] test-pmd: declare lcore_count atomic when using C11 memory model

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 6:02, Andre Muezerie wrote: > Compiling with MSVC results in the error below: > > app/test/test_ring_perf.c(197): error C7712: address argument to atomic > operation must be a pointer to an atomic integer, > 'volatile unsigned int *' is not valid

Re: [PATCH 07/10] test-pmd: don't return value from void function

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 6:02, Andre Muezerie wrote: > Compiling with MSVC results in the warning below: > > app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed': > 'void' function returning a value > > Signed-off-by: Andre Muezerie

Re: [PATCH 06/10] test-pmd: avoid non-constant initializer

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 6:02, Andre Muezerie wrote: > Compiling with MSVC results in errors like the one below: > > app/test-pmd/cmdline_flow.c(8819): error C2099: initializer > is not a constant > > Signed-off-by: Andre Muezerie

Re: [PATCH 05/10] test-pmd: avoid undefined behavior

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 6:02, Andre Muezerie wrote: > Compiling with MSVC results in warnings like below: > > app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor > directive in function-like macro argument list is undefined behavior > > Signed-off-by: Andre Mu

Re: [PATCH 04/10] test-pmd: do explicit 64-bit shift to avoid implicit conversion

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 6:02, Andre Muezerie wrote: > Compiling with MSVC results in warnings like the one below: > > app/test-pmd/util.c(201): warning C4334: '<<': result of 32-bit shift > implicitly converted to 64 bits (was 64-bit shift intended?) > > Signed-off-by: And

Re: [PATCH 03/10] test-pmd: fix printf format string mismatch

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 6:01, Andre Muezerie wrote: > Compiling with MSVC results in warnings like the one below: > > app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string > '%d' requires an argument of type 'int', > but variadic argument 1 has type 'ui

Re: [PATCH 02/10] test_alarm: avoid warning about different qualifiers

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 6:01, Andre Muezerie wrote: > Compiling with MSVC results in the warning below: > > app/test/test_alarm.c(54): warning C4090: 'function': > different '_Atomic' qualifiers > > The fix is to use a macro to explicitly drop the qualifier. > > Signed-of

Re: [PATCH 01/10] eal: add workaround for __builtin_constant_p

2025-02-11 Thread fengchengwen
Signed-off-by: Chengwen Feng On 2025/2/12 6:01, Andre Muezerie wrote: > There's no MSVC equivalent for compiler extension __builtin_constant_p. > EAL already had __rte_constant which was used as a first attempt to > workaround __builtin_constant_p when using MSVC. However, there are > pieces of c

Re: [PATCH v3 0/5] Defer lcore variables allocation

2025-02-11 Thread fengchengwen
Series-acked-by: Chengwen Feng On 2025/2/11 5:31, David Marchand wrote: > As I had reported in 24.11-rc2, the lcore variables allocation have a > noticeable impact on applications consuming DPDK, even when such > applications does not use DPDK, or use features associated to > some lcore variables

Re: [PATCH v6 1/4] bus/pci: fix registration of PCI device

2025-02-11 Thread Stephen Hemminger
On Thu, 6 Feb 2025 12:54:24 +0200 Shani Peretz wrote: > When registering a new PCI device, the device->name field stored > the user-provided string from devargs (e.g., "08:00.0" or ":08:00.0"). > This approach led to inconsistencies when registering new devices. > > This patch fix this issue

Re: [PATCH 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 14:02:05 -0800 Andre Muezerie wrote: > There's no MSVC equivalent for compiler extension __builtin_constant_p, > so a workaround is needed. > > Signed-off-by: Andre Muezerie Prefer that __rte_constant worked on all platforms, but template code is hard to maintain.

Re: [PATCH 08/10] test-pmd: declare lcore_count atomic when using C11 memory model

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 14:02:04 -0800 Andre Muezerie wrote: > Compiling with MSVC results in the error below: > > app/test/test_ring_perf.c(197): error C7712: address argument to atomic > operation must be a pointer to an atomic integer, > 'volatile unsigned int *' is not valid > > The fix

[PATCH 01/10] eal: add workaround for __builtin_constant_p

2025-02-11 Thread Andre Muezerie
There's no MSVC equivalent for compiler extension __builtin_constant_p. EAL already had __rte_constant which was used as a first attempt to workaround __builtin_constant_p when using MSVC. However, there are pieces of code that would benefit from being able to provide a default value to be used ins

Re: [PATCH 03/10] test-pmd: fix printf format string mismatch

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 14:01:59 -0800 Andre Muezerie wrote: > Compiling with MSVC results in warnings like the one below: > > app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string > '%d' requires an argument of type 'int', > but variadic argument 1 has type 'uint64_t' > >

Re: [PATCH 01/10] eal: add workaround for __builtin_constant_p

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 14:01:57 -0800 Andre Muezerie wrote: > There's no MSVC equivalent for compiler extension __builtin_constant_p. > EAL already had __rte_constant which was used as a first attempt to > workaround __builtin_constant_p when using MSVC. However, there are > pieces of code that woul

[PATCH 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

2025-02-11 Thread Andre Muezerie
There's no MSVC equivalent for compiler extension __builtin_constant_p, so a workaround is needed. Signed-off-by: Andre Muezerie --- app/test/test_memcpy_perf.c | 106 ++-- 1 file changed, 53 insertions(+), 53 deletions(-) diff --git a/app/test/test_memcpy_perf.c

[PATCH 06/10] test-pmd: avoid non-constant initializer

2025-02-11 Thread Andre Muezerie
Compiling with MSVC results in errors like the one below: app/test-pmd/cmdline_flow.c(8819): error C2099: initializer is not a constant Signed-off-by: Andre Muezerie --- app/test-pmd/cmdline_flow.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/app/test-pmd/c

[PATCH 08/10] test-pmd: declare lcore_count atomic when using C11 memory model

2025-02-11 Thread Andre Muezerie
Compiling with MSVC results in the error below: app/test/test_ring_perf.c(197): error C7712: address argument to atomic operation must be a pointer to an atomic integer, 'volatile unsigned int *' is not valid The fix is to mark lcore_count as atomic when using C11 memory model. Signed-of

[PATCH 07/10] test-pmd: don't return value from void function

2025-02-11 Thread Andre Muezerie
Compiling with MSVC results in the warning below: app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed': 'void' function returning a value Signed-off-by: Andre Muezerie --- app/test-pmd/cmdline_flow.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

[PATCH 05/10] test-pmd: avoid undefined behavior

2025-02-11 Thread Andre Muezerie
Compiling with MSVC results in warnings like below: app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor directive in function-like macro argument list is undefined behavior Signed-off-by: Andre Muezerie --- app/test-pmd/cmdline.c | 15 +-- 1 file changed, 13 inserti

[PATCH 02/10] test_alarm: avoid warning about different qualifiers

2025-02-11 Thread Andre Muezerie
Compiling with MSVC results in the warning below: app/test/test_alarm.c(54): warning C4090: 'function': different '_Atomic' qualifiers The fix is to use a macro to explicitly drop the qualifier. Signed-off-by: Andre Muezerie --- app/test/test_alarm.c | 12 ++-- 1 file changed, 6 in

[PATCH 03/10] test-pmd: fix printf format string mismatch

2025-02-11 Thread Andre Muezerie
Compiling with MSVC results in warnings like the one below: app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'uint64_t' Signed-off-by: Andre Muezerie --- app/test-pmd/csumonly.c | 12 ++--

[PATCH 04/10] test-pmd: do explicit 64-bit shift to avoid implicit conversion

2025-02-11 Thread Andre Muezerie
Compiling with MSVC results in warnings like the one below: app/test-pmd/util.c(201): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) Signed-off-by: Andre Muezerie --- app/test-pmd/cmdline.c | 4 ++-- app/test-pmd/testpmd.c | 2 +- ap

[PATCH 00/10] enable "app" to be compiled with MSVC

2025-02-11 Thread Andre Muezerie
This series fixes many issues that prevent the "app" directory from being compiled with MSVC. Andre Muezerie (10): eal: add workaround for __builtin_constant_p test_alarm: avoid warning about different qualifiers test-pmd: fix printf format string mismatch test-pmd: do explicit 64-bit shif

Re: [PATCH v5 00/11] memset security fixes

2025-02-11 Thread Patrick Robb
There is a performance failure for Intel E810 for this patch, but it is coming from dpdk mainline, not this patchseries. I think something was merged recently which bumped up the variance on forwarding because the periodic runs on the E810 for DPDK 24.11 are stable, but all the current runs on new

Re: [RFC PATCH 7/7] dts: revamp runtime internals

2025-02-11 Thread Dean Marx
On Mon, Feb 3, 2025 at 10:18 AM Luca Vizzarro wrote: > > Enforce separation of concerns by letting test runs being isolated > through a new TestRun class and respective module. This also means that > any actions taken on the nodes must be handled exclusively by the test > run. An example being the

Re: [RFC PATCH 6/7] dts: add global runtime context

2025-02-11 Thread Dean Marx
On Mon, Feb 3, 2025 at 10:18 AM Luca Vizzarro wrote: > > Add a new context module which holds the runtime context. The new > context will describe the current scenario and aid underlying classes > used by the test suites to automatically infer their parameters. This > futher simplies the test writ

Re: [RFC PATCH 5/7] dts: add runtime status

2025-02-11 Thread Dean Marx
On Mon, Feb 3, 2025 at 10:17 AM Luca Vizzarro wrote: > > Add a new module which defines the global runtime status of DTS and the > distinct execution stages and steps. > > Signed-off-by: Luca Vizzarro Looks great! Reviewed-by: Dean Marx

Re: [RFC PATCH 4/7] dts: improve Port model

2025-02-11 Thread Dean Marx
On Mon, Feb 3, 2025 at 10:17 AM Luca Vizzarro wrote: > > Make Port models standalone, so that they can be directly manipulated by > the test suites as needed. Moreover, let them handle themselves and > retrieve the logical name and mac address in autonomy. > > Signed-off-by: Luca Vizzarro Review

Link custom libarchive meson support

2025-02-11 Thread Ben Magistro
Will acknowledge this may be more of a meson question and less of a DPDK issue but things didn't seem to work as expected and had to tweak the config/meson.build to want to start with the DPDK team. Our project is cmake based and we use fetch content to pull in our external dependencies (eg dpdk,

Re: [RFC PATCH 3/7] dts: revamp Topology model

2025-02-11 Thread Dean Marx
On Mon, Feb 3, 2025 at 10:17 AM Luca Vizzarro wrote: > > Change the Topology model to add further flexility in its usage as a > standalone entry point to test suites. > > Signed-off-by: Luca Vizzarro Reviewed-by: Dean Marx

Re: [RFC PATCH 2/7] dts: isolate test specification to config

2025-02-11 Thread Dean Marx
On Mon, Feb 3, 2025 at 10:17 AM Luca Vizzarro wrote: > > In an effort to improve separation of concerns, make the TestRunConfig > class responsible for processing the configured test suites. Moreover, > give TestSuiteConfig a facility to yield references to the selected test > cases. > > Signed-of

Re: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 17:54:26 + Bruce Richardson wrote: > On Tue, Feb 11, 2025 at 09:48:32AM -0800, Stephen Hemminger wrote: > > On Thu, 6 Feb 2025 02:08:36 +0200 > > Shani Peretz wrote: > > > > > static int > > > -cdx_parse(const char *name, void *addr) > > > +cdx_parse(const char *name,

Re: [RFC PATCH 1/7] dts: add port topology configuration

2025-02-11 Thread Dean Marx
On Mon, Feb 3, 2025 at 10:17 AM Luca Vizzarro wrote: > > The current configuration makes the user re-specify the port links for > each port in an unintuitive and repetitive way. Moreover, this design > does not give the user to opportunity to map the port topology as > desired. > > This change add

Re: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-11 Thread Bruce Richardson
On Tue, Feb 11, 2025 at 09:48:32AM -0800, Stephen Hemminger wrote: > On Thu, 6 Feb 2025 02:08:36 +0200 > Shani Peretz wrote: > > > static int > > -cdx_parse(const char *name, void *addr) > > +cdx_parse(const char *name, void *addr, int *size) > > { > > - const char **out = addr; > > int r

Re: [RFC PATCH] app/test-pmd: add option to run startup cmds without echo

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 16:44:02 + Bruce Richardson wrote: > Depending on the scenario, a user may want to run testpmd with > pre-canned startup commands either with or without echoing of those > commands as they are executed. To observe progress of each command, or > to help determine what comma

Re: [PATCH v5 2/4] lib: fix comparison between devices

2025-02-11 Thread Stephen Hemminger
On Thu, 6 Feb 2025 02:08:36 +0200 Shani Peretz wrote: > static int > -cdx_parse(const char *name, void *addr) > +cdx_parse(const char *name, void *addr, int *size) > { > - const char **out = addr; > int ret; > > ret = strncmp(name, CDX_DEV_PREFIX, strlen(CDX_DEV_PREFIX)); >

[PATCH v5 08/11] test: remove unneeded memset

2025-02-11 Thread Stephen Hemminger
Since tmp is not used later in the function, this memset is unnecessary. Even though this is harmless, it causes tools that look for security issues around memset to flag this a bug. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- app/test/test_cmdline_cirbuf.c | 2 -- 1 file ch

[PATCH v5 11/11] devtools/cocci: add script to find problematic memset

2025-02-11 Thread Stephen Hemminger
Script that converts memset before free into rte_memset_sensitive and memset before rte_free into rte_free_sensitive Signed-off-by: Stephen Hemminger --- devtools/cocci/memset_free.cocci | 20 1 file changed, 20 insertions(+) create mode 100644 devtools/cocci/memset_free.co

[PATCH v5 09/11] net/ntnic: check result of malloc

2025-02-11 Thread Stephen Hemminger
Need to check the result of malloc() before calling memset. This is only place in this driver that forgot, other code does check. Fixes: 0d9bca480e26 ("net/ntnic: add FPGA modules for initialization") cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/ntnic/nthw/nthw_rac.c | 4

[PATCH v5 10/11] net/ntnic: remove unnecessary memset

2025-02-11 Thread Stephen Hemminger
Calling memset before free() has no effect and will be flagged by security parsing tools as a potential bug. None of these data structures have sensitive information. Signed-off-by: Stephen Hemminger --- drivers/net/ntnic/nthw/core/nthw_hif.c| 5 + drivers/net/ntnic/nthw/core

[PATCH v5 07/11] compress/octeontx: remove unnecessary memset

2025-02-11 Thread Stephen Hemminger
Calling memset before rte_free not necessary, and could be removed by the compiler. In this case, the data is not security sensitive so the memset can be removed. Some security scanning tools will flag this. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/compress/octeon

[PATCH v5 06/11] bus/uacce: remove memset before free

2025-02-11 Thread Stephen Hemminger
Doing memset before free maybe removed by compiler, and is flagged by security scanning tools as potential problem. In this case the memset is unnecessary. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng --- drivers/bus/uacce/uacce.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[PATCH v5 02/11] eal: add new secure free function

2025-02-11 Thread Stephen Hemminger
Although internally rte_free does poison the buffer in most cases, it is useful to have function that explicitly does this to avoid any security issues. Signed-off-by: Stephen Hemminger --- lib/eal/common/rte_malloc.c | 30 -- lib/eal/include/rte_malloc.h | 18 ++

[PATCH v5 05/11] crypto/qat: use secure memset

2025-02-11 Thread Stephen Hemminger
Regular memset maybe removed by compiler if done before a free function. Use new rte_free_sensitive instead. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_asym.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/qat/q

[PATCH v5 04/11] crypto/qat: fix size calculation for memset

2025-02-11 Thread Stephen Hemminger
The memset was always doing 0 bytes since size computed later. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 3a80d7fb2ecd ("crypto/qat: support SHA3 plain hash") Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_sym_sessio

[PATCH v5 03/11] crypto/qat: force zero of keys

2025-02-11 Thread Stephen Hemminger
Just doing memset() on keys is not enough, compiler can optimize it away. Need something with a barrier. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_sym_session.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/dri

[PATCH v5 01/11] eal: introduce new secure memory fill

2025-02-11 Thread Stephen Hemminger
When memset() is used before a release function such as free, the compiler if allowed to optimize the memset away under the as-if rules. This is normally ok, but in certain cases such as passwords or security keys it is problematic. Introduce a DPDK wrapper which is equivalent to the C++ memset_s

[PATCH v5 00/11] memset security fixes

2025-02-11 Thread Stephen Hemminger
This series handles memset related bugs indentified by PVS Studio. The root cause is that Gcc and other compilers are free to optimize away memset called before free. Most of the places memset was being used like this were bogus; probably some developer debug habit, and can be safely removed. v6

RE: [PATCH] build: allow disabling avx512 support via compiler flag

2025-02-11 Thread Stokes, Ian
> DPDK build checks for build support for various instruction sets by > checking both the target machine and the compiler for support. However, > any disabling of instruction sets via compiler flags was not taken into > account in many cases. For AVX512 support, check for a user-specified > "no-avx

Re: [PATCH v6 1/4] bus/pci: fix registration of PCI device

2025-02-11 Thread Bruce Richardson
On Thu, Feb 06, 2025 at 12:54:24PM +0200, Shani Peretz wrote: > When registering a new PCI device, the device->name field stored > the user-provided string from devargs (e.g., "08:00.0" or ":08:00.0"). > This approach led to inconsistencies when registering new devices. > > This patch fix this

[PATCH v0 1/1] dma/cnxk: support pending count per HW DMA channel

2025-02-11 Thread Vamsi Krishna
From: Vamsi Attunuru Adds code changes to maintain pending count per hw dma channel instead of per vchan. This enables ringing dbell for exact number of dma commands present in the DPI queue. Signed-off-by: Vamsi Attunuru --- drivers/dma/cnxk/cnxk_dmadev.c| 17 +++ drivers/dma/cnxk/cnx

[RFC PATCH] app/test-pmd: add option to run startup cmds without echo

2025-02-11 Thread Bruce Richardson
Depending on the scenario, a user may want to run testpmd with pre-canned startup commands either with or without echoing of those commands as they are executed. To observe progress of each command, or to help determine what command an error response is printed for, echoing is useful. When running

Re: [PATCH v10 00/28] [v10]drivers/net Add Support mucse N10 Pmd Driver

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 23:06:10 +0800 Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx

Re: [PATCH v10 00/28] [v10]drivers/net Add Support mucse N10 Pmd Driver

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 23:06:10 +0800 Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx

Re: [PATCH v9 08/28] net/rnp: add queue setup and release operations

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 16:49:58 +0800 Wenbo Cao wrote: > diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h > index da2c1d3b0e..ea4e1b8d83 100644 > --- a/drivers/net/rnp/base/rnp_hw.h > +++ b/drivers/net/rnp/base/rnp_hw.h > @@ -120,6 +120,9 @@ struct rnp_hw { > bool lan

Re: [PATCH v9 04/28] net/rnp: support mailbox basic operate

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 16:49:54 +0800 Wenbo Cao wrote: > +static inline u32 > +rnp_reg_read32(void *base, size_t offset) > +{ > + unsigned int v = rte_read32(((u8 *)base + offset)); > + > + RNP_PMD_REG_LOG(DEBUG, "offset=0x%08lx val=0x%04x", > + (unsigned long)offset, v);

Re: [PATCH v9 08/28] net/rnp: add queue setup and release operations

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 16:49:58 +0800 Wenbo Cao wrote: > diff --git a/drivers/net/rnp/base/meson.build > b/drivers/net/rnp/base/meson.build > index b9db033ff6..c2ef0d05be 100644 > --- a/drivers/net/rnp/base/meson.build > +++ b/drivers/net/rnp/base/meson.build > @@ -7,6 +7,7 @@ sources = [ >

Re: [PATCH v9 08/28] net/rnp: add queue setup and release operations

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 16:49:58 +0800 Wenbo Cao wrote: > +static void rnp_rx_queue_release(void *_rxq) > +{ > + struct rnp_rx_queue *rxq = (struct rnp_rx_queue *)_rxq; > + > + PMD_INIT_FUNC_TRACE(); > + > + if (rxq) { > + rnp_rx_queue_release_mbuf(rxq); > + if (rx

Re: [PATCH v9 12/28] net/rnp: add support link update operations

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 16:50:02 +0800 Wenbo Cao wrote: > static int > +rnp_mbx_fw_reply_handler(struct rnp_eth_adapter *adapter, > + struct rnp_mbx_fw_cmd_reply *reply) > +{ > + struct rnp_mbx_req_cookie *cookie; > + > + RTE_SET_USED(adapter); > + /* dbg_here; */ > +

Re: [PATCH v9 04/28] net/rnp: support mailbox basic operate

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 16:49:54 +0800 Wenbo Cao wrote: > diff --git a/drivers/net/rnp/base/meson.build > b/drivers/net/rnp/base/meson.build > new file mode 100644 > index 00..9ea88c3bff > --- /dev/null > +++ b/drivers/net/rnp/base/meson.build > @@ -0,0 +1,22 @@ > +# SPDX-License-Identifier:

Re: [PATCH v9 00/28] [v9]drivers/net Add Support mucse N10 Pmd Driver

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 23:18:34 +0800 "11" wrote: > Hi Stephen, > > For rsic-v,windows freebsd plaform, I need to limit compile meson file what > we not support ? > > Regards Wenbo You can stick to linux for first version. I assume issue with risc-v is byte order. All this can be blocked in mes

Re: [PATCH] drivers: fix build warnings when using icx

2025-02-11 Thread Bruce Richardson
On Mon, Feb 10, 2025 at 05:19:57PM +, Bruce Richardson wrote: > The Intel oneAPI DPC++/C++ Compiler (icx), issues warnings on build when > the "-march=native", or other configured global "-march" flag, is > overridden to "skylake-avx512", when compiling AVX-512 code. > > Allow building with ic

Re: [PATCH v5 0/4] remove common iavf and idpf drivers

2025-02-11 Thread Bruce Richardson
On Mon, Feb 10, 2025 at 04:44:22PM +, Bruce Richardson wrote: > The iavf and idpf common directories were used only to share code > between multiple net drivers and did not need to be drivers in their own > right, since it is just as easy to have a dependency from one net driver > on another as

Re: [RFC] git: consolidate .gitignore files

2025-02-11 Thread Patrick Robb
On Mon, Feb 10, 2025 at 12:21 PM Stephen Hemminger < step...@networkplumber.org> wrote: > > diff --git a/.gitignore b/.gitignore > index 903fe9bc64..a1a6843494 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -43,6 +43,8 @@ TAGS > > # DTS results > dts/output > +dts/nodes.yaml > +dts/test_rund.

[PATCH v10 24/28] net/rnp: add support Tx TSO offload

2025-02-11 Thread Wenbo Cao
Add support tx tso and tunnel tso. for tunnel just support vxlan/nvgre Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_bdq_if.h | 1 + drivers/net/rnp/rnp.h | 2 +- drivers/net/rnp/rnp_eth

[PATCH v10 15/28] net/rnp: add Tx burst simple support

2025-02-11 Thread Wenbo Cao
add only support simple send pkts. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 6 +++ drivers/net/rnp/rnp_rxtx.c | 85 +++- drivers/net/rnp/rnp_rxtx.h | 1 + 3 files changed, 91 insertions(+), 1 deletion(-) diff --git a/drivers/net/rnp/rnp_e

RE: [PATCH v9 00/28] [v9]drivers/net Add Support mucse N10 Pmd Driver

2025-02-11 Thread 11
Hi Stephen, For rsic-v,windows freebsd plaform, I need to limit compile meson file what we not support ? Regards Wenbo > -Original Message- > From: Stephen Hemminger > Sent: 2025年2月11日 22:57 > To: Wenbo Cao > Cc: tho...@monjalon.net; dev@dpdk.org; ferruh.yi...@amd.com; > andrew.rybche

[PATCH v10 05/28] net/rnp: add device init and uninit

2025-02-11 Thread Wenbo Cao
add firmware communic method and basic device init, uninit and close resource function. Signed-off-by: Wenbo Cao Reviewed-by: Ferruh Yigit --- drivers/net/rnp/base/meson.build| 4 + drivers/net/rnp/base/rnp_common.c | 73 ++ drivers/net/rnp/base/rnp_common.h | 12 + drivers/net/

[PATCH v10 26/28] net/rnp: add support VLAN filters operations

2025-02-11 Thread Wenbo Cao
add support to update vid for vlan filter. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 2 +- drivers/net/rnp/base/meson.build| 1 + drivers/net/rnp/base/rnp_bitrev.h | 64 ++ drivers/net/rnp/base/rnp_c

[PATCH v10 28/28] net/rnp: support Rx/Tx burst mode info

2025-02-11 Thread Wenbo Cao
add platform method for get rx/tx burst function select by upload func name. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 2 ++ drivers/net/rnp/rnp_rxtx.c | 58 drivers/net/rnp/rnp_rxtx.h | 6 3 files changed, 66 insertions(+) diff

[PATCH v10 25/28] net/rnp: support VLAN offloads

2025-02-11 Thread Wenbo Cao
add support rx vlan strip,filter,tx vlan/qinq insert. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 2 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_bdq_if.h | 2 +- drivers/net/rnp/base/rnp_eth_regs.h | 5 + drivers/net/rnp/base/rnp_hw.h

[PATCH v10 27/28] net/rnp: add queue info operation

2025-02-11 Thread Wenbo Cao
add support get queue configure info for user debug Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 2 ++ drivers/net/rnp/rnp_rxtx.c | 42 drivers/net/rnp/rnp_rxtx.h | 4 3 files changed, 48 insertions(+) diff --git a/drivers/net/rnp/r

[PATCH v10 19/28] net/rnp: add support basic stats operation

2025-02-11 Thread Wenbo Cao
add support hw-missed rx/tx packets bytes. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 2 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_eth_regs.h | 3 + drivers/net/rnp/rnp.h | 10 +- drivers/net/rnp/rnp_ethdev.c| 147 +

[PATCH v10 20/28] net/rnp: add support xstats operation

2025-02-11 Thread Wenbo Cao
add support mac eth rx tx hw xstats. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + drivers/net/rnp/base/rnp_eth_regs.h | 3 + drivers/net/rnp/base/rnp_mac_regs.h | 80 + drivers/net/rnp/rnp.h | 51 ++ drivers/net/rnp/rnp_ethdev.c|

[PATCH v10 23/28] net/rnp: add support Rx checksum offload

2025-02-11 Thread Wenbo Cao
Add support Rx l3/l4 checum and tunnel inner l3/l4, out l3 chksum. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 4 ++ doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_eth_regs.h | 13 drivers/net/rnp/rnp.h | 7 +++ drivers/net/rnp/rn

[PATCH v10 18/28] net/rnp: add Tx multiple segment version

2025-02-11 Thread Wenbo Cao
add support multiple segs mbuf send. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_rxtx.c | 126 - drivers/net/rnp/rnp_rxtx.h | 3 +- 2 files changed, 126 insertions(+), 3 deletions(-) diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c

[PATCH v10 22/28] net/rnp: add supported packet types

2025-02-11 Thread Wenbo Cao
add support parse hw packet types result. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_bdq_if.h | 4 +++ drivers/net/rnp/rnp_rxtx.c| 45 +++ 4 files changed, 51 inser

[PATCH v10 21/28] net/rnp: add unicast MAC filter operation

2025-02-11 Thread Wenbo Cao
add mac filter for single/multiple port. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_eth_regs.h | 4 ++ drivers/net/rnp/base/rnp_hw.h | 3 + drivers/net/rnp/base/rnp_mac.c | 91

[PATCH v10 14/28] net/rnp: add Rx burst simple support

2025-02-11 Thread Wenbo Cao
add only support simple recv pkts. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp_ethdev.c | 7 ++ drivers/net/rnp/rnp_rxtx.c | 129 +++ drivers/net/rnp/rnp_rxtx.h | 5 ++ 3 files changed, 141 insertions(+) diff --git a/drivers/net/rnp/rnp_ethdev.c b/dr

[PATCH v10 17/28] net/rnp: add Rx scatter segment version

2025-02-11 Thread Wenbo Cao
add support scatter multi segment received. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + doc/guides/nics/rnp.rst | 2 + drivers/net/rnp/rnp_rxtx.c | 131 ++- drivers/net/rnp/rnp_rxtx.h | 2 + 4 files changed, 134 inse

[PATCH v10 16/28] net/rnp: add MTU set operation

2025-02-11 Thread Wenbo Cao
add mtu update limit for multiple port mode. multiple mode just used the max-mtu of ports to limit receive. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini| 1 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_eth_regs.h | 3 + drivers/net/rnp/rnp.h

[PATCH v10 12/28] net/rnp: add support link update operations

2025-02-11 Thread Wenbo Cao
This patch add support poll/irq link get mode. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 2 + doc/guides/nics/rnp.rst | 1 + drivers/net/rnp/base/rnp_fw_cmd.c | 45 +++ drivers/net/rnp/base/rnp_fw_cmd.h | 58 +- drivers/net/rnp/base/rnp_

[PATCH v10 13/28] net/rnp: add support link setup operations

2025-02-11 Thread Wenbo Cao
add set link_down/link_up implement Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_eth_regs.h | 3 + drivers/net/rnp/base/rnp_fw_cmd.c | 22 +++ drivers/net/rnp/base/rnp_fw_cmd.h | 6 ++ drivers/net/rnp/base/rnp_mbx_fw.c | 33 ++ drivers/net/rnp/base/rnp_mbx_fw.h |

[PATCH v10 10/28] net/rnp: add support device start stop operations

2025-02-11 Thread Wenbo Cao
add basic support for device to start/stop function Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_common.c | 22 +++ drivers/net/rnp/base/rnp_common.h | 1 + drivers/net/rnp/base/rnp_dma_regs.h | 10 + drivers/net/rnp/base/rnp_eth_regs.h | 5 + drivers/net/rnp/base/rnp_hw.h

[PATCH v10 09/28] net/rnp: add queue stop and start operations

2025-02-11 Thread Wenbo Cao
support rx/tx queue stop/start,for rx queue stop need to reset a queue,must stop all rx queue during reset this queue. Signed-off-by: Wenbo Cao --- doc/guides/nics/features/rnp.ini | 1 + drivers/net/rnp/base/rnp_common.c | 3 + drivers/net/rnp/rnp_link.c| 340 ++

  1   2   >