L2 cryptography example application using nfb driver .

2025-02-10 Thread Thenveer Poolakkanni
Hi , I am using dpdk-23.11-rc1 version and nfb driver . When i am running l2fwd-crypto example application , getting the below error , [image] missing function definitions for - rte_cryptodev_get_cipher_algo_string , rte_cryptodev_get_auth_algo_string, and rte_cryptodev_get_aead_algo_string .

Re: [PATCH v6] net: add thread-safe crc api

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 21:27:10 + Arkadiusz Kusztal wrote: > The current net CRC API is not thread-safe, this patch > solves this by adding another, thread-safe API functions. > This API is also safe to use across multiple processes, > yet with limitations on max-simd-bitwidth, which will be che

Re: [PATCH] mbuf: enable to be compiled with MSVC

2025-02-10 Thread Andre Muezerie
On Mon, Feb 10, 2025 at 02:34:29PM -0800, Stephen Hemminger wrote: > On Mon, 10 Feb 2025 13:51:05 -0800 > Andre Muezerie wrote: > > > Now that the issues preventing this lib from be compiled with MSVC > > are fixed it can be included in the compilation. > > > > The "net" library will automatical

[PATCH] mbuf: enable to be compiled with MSVC

2025-02-10 Thread Andre Muezerie
Now that the issues preventing this lib from be compiled with MSVC are fixed it can be included in the compilation. The "net" library will automatically get compiled as well as it has a dependency on "mbuf" which will now get fulfilled. Signed-off-by: Andre Muezerie --- lib/mbuf/meson.build | 6

[PATCH v3 5/5] eal/x86: defer power intrinsics variable allocation

2025-02-10 Thread David Marchand
The lcore variable in this code unit is only used through rte_power_monitor*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 18b5049ab4fe ("eal/x86: keep power intrinsics state in lcore variable") Cc: sta...@dpdk.org Signed-off-by: David Marchand Ack

[PATCH v3 4/5] power: reduce memory footprint of per-lcore state

2025-02-10 Thread David Marchand
Now that the per-lcore state was moved into a lcore variable, there is no reason to align a per-lcore state on a cache line to avoid false sharing. Remove this alignment and save a few bytes. Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") Signed-off-by: David Marchand Acke

RE: [PATCH v5] net: add thread-safe crc api

2025-02-10 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Stephen Hemminger > Sent: Monday, February 10, 2025 8:57 PM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; ferruh.yi...@amd.com; Ji, Kai ; Dooley, > Brian > Subject: Re: [PATCH v5] net: add thread-safe crc api > > On Fri, 7 Feb 2025 18:24:43 + > Arkad

[PATCH v3 3/5] power: defer lcore variable allocation

2025-02-10 Thread David Marchand
The lcore variable in this code unit is only used through rte_power_ethdev_pmgmt_queue_*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") Cc: sta...@dpdk.org Signed-off-by: David Marchand

[PATCH v3 1/5] eal: check lcore variable handle

2025-02-10 Thread David Marchand
Add an assert to double check the passed handle is not NULL, as it points at an initialisation/allocation issue prior to accessing this lcore variable. Signed-off-by: David Marchand Acked-by: Anatoly Burakov Acked-by: Frode Nordahl --- lib/eal/include/rte_lcore_var.h | 2 ++ 1 file changed, 2

[PATCH v3 2/5] random: defer seeding to EAL init

2025-02-10 Thread David Marchand
The RNG is documented as being seeded as part of EAL init. Move the initialisation (seeding) helper out of a constructor and call it explicitly from rte_eal_init() as it was done before commit 3f002f069612 ("eal: replace libc-based random generation with LFSR"). This also moves the unconditional

[PATCH v3 0/5] Defer lcore variables allocation

2025-02-10 Thread David Marchand
As I had reported in 24.11-rc2, the lcore variables allocation have a noticeable impact on applications consuming DPDK, even when such applications does not use DPDK, or use features associated to some lcore variables. While the amount has been reduced in a rush before rc2, there are still cases w

[PATCH v6] net: add thread-safe crc api

2025-02-10 Thread Arkadiusz Kusztal
The current net CRC API is not thread-safe, this patch solves this by adding another, thread-safe API functions. This API is also safe to use across multiple processes, yet with limitations on max-simd-bitwidth, which will be checked only by the process that created the CRC context; all other proce

[PATCH] drivers/net: signed/unsigned mismatch

2025-02-10 Thread Andre Muezerie
This patch avoids warning C4018: '>=': signed/unsigned mismatch The fix is to use U suffix to indicate the numbers are unsigned before the comparisons are made. Also renamed variables to make them compliant to DPDK standards and avoid checkpatch warnings. Signed-off-by: Andre Muezerie --- driv

Re: [PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch

2025-02-10 Thread Andre Muezerie
On Mon, Feb 10, 2025 at 09:35:22AM +, Bruce Richardson wrote: > On Fri, Feb 07, 2025 at 11:01:57AM -0800, Stephen Hemminger wrote: > > On Fri, 7 Feb 2025 09:41:08 -0800 > > Andre Muezerie wrote: > > > > > This patch avoids warnings like the ones below emitted by MSVC: > > > > > > 1) > > > .

Re: [PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch

2025-02-10 Thread Andre Muezerie
On Mon, Feb 10, 2025 at 04:07:46PM +, Bruce Richardson wrote: > On Mon, Feb 10, 2025 at 09:35:22AM +, Bruce Richardson wrote: > > On Fri, Feb 07, 2025 at 11:01:57AM -0800, Stephen Hemminger wrote: > > > On Fri, 7 Feb 2025 09:41:08 -0800 > > > Andre Muezerie wrote: > > > > > > > This patc

Re: [PATCH v19 1/6] memarea: introduce memarea library

2025-02-10 Thread Stephen Hemminger
On Thu, 20 Jul 2023 09:22:49 + Chengwen Feng wrote: > The memarea library is an allocator of variable-size object which based > on a memory region. > > This patch provides rte_memarea_create() and rte_memarea_destroy() API. > > Signed-off-by: Chengwen Feng > Reviewed-by: Dongdong Liu > Ac

Re: [PATCH 0/2] net/hns3: bugfix on hns3

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 11:01:11 +0800 Jie Hai wrote: > Fix some possible failure on hns3 driver. > > Dengdui Huang (2): > net/hns3: fix possible copper port initialize fail > net/hns3: fix possible reset timeout > > drivers/net/hns3/hns3_cmd.c| 18 -- > drivers/net/hns3/hn

Re: [PATCH v5] net: add thread-safe crc api

2025-02-10 Thread Stephen Hemminger
On Fri, 7 Feb 2025 18:24:43 + Arkadiusz Kusztal wrote: > +static struct > +{ > + rte_net_crc_handler f[RTE_NET_CRC_REQS]; > +} handlers_dpdk26[RTE_NET_CRC_AVX512 + 1]; > + Should have { after the struct +void rte_net_crc_free(struct rte_net_crc *crc) +{ + rte_free(crc); +} Add r

Re: [RFC PATCH 3/7] dts: revamp Topology model

2025-02-10 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Mon, Feb 3, 2025 at 10:17 AM Luca Vizzarro wrote: > > Change the Topology model to add further flexility in its usage as a > standalone entry point to test suites. > > Signed-off-by: Luca Vizzarro > --- > dts/framework/testbed_model/topology.py | 85

Re: [RFC PATCH 2/7] dts: isolate test specification to config

2025-02-10 Thread Nicholas Pratte
This makes sense to me! Reviewed-by: Nicholas Pratte On Mon, Feb 3, 2025 at 10:17 AM Luca Vizzarro wrote: > > In an effort to improve separation of concerns, make the TestRunConfig > class responsible for processing the configured test suites. Moreover, > give TestSuiteConfig a facility to yiel

Re: [PATCH v8 06/28] net/rnp: add get device information operation

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 15:26:33 +0800 Wenbo Cao wrote: > add get device hardware capability function > --- > doc/guides/nics/features/rnp.ini | 1 + > drivers/net/rnp/base/rnp_fw_cmd.c | 20 ++ > drivers/net/rnp/base/rnp_fw_cmd.h | 80 + > drivers/net/rnp/base/rnp_mbx_f

Re: [PATCH v8 00/28] [v8]drivers/net Add Support mucse N10 Pmd Driver

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 15:26:27 +0800 Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx

Re: [PATCH v8 00/28] [v8]drivers/net Add Support mucse N10 Pmd Driver

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 15:26:27 +0800 Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx

Re: [PATCH v8 00/28] [v8]drivers/net Add Support mucse N10 Pmd Driver

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 15:26:27 +0800 Wenbo Cao wrote: > For This patchset just to support the basic chip init work > and user can just found the eth_dev, but can't control more. > For Now just support 2*10g nic,the chip can support > 2*10g,4*10g,4*1g,8*1g,8*10g. > The Feature rx side can support rx

Re: [PATCH v8 01/28] net/rnp: add skeleton

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 15:26:28 +0800 Wenbo Cao wrote: > Add basic PMD library and doc build infrastructure > Update maintainers file to claim responsibility. > > Signed-off-by: Wenbo Cao > Reviewed-by: Thomas Monjalon > --- > MAINTAINERS | 6 +++ > doc/guides/nics/features

Re: [PATCH v8 00/28] [v8]drivers/net Add Support mucse N10 Pmd Driver

2025-02-10 Thread Stephen Hemminger
Driver review checklist for mucse PMD Mark items with: ✔ passed ✘ Failed Basic hygiene ✘ Look at CI results in patchwork; notify submitter if any failures ✔ Merge cleanly with git am; look for missing newline at EOF etc ✘ Run checkpatches; warnings are ok, but look more carefu

Re: [PATCH v1 03/14] net/zxdh: add agent channel

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:47:02 +0800 Bingbin Chen wrote: > > +#define ZXDH_COMM_CHECK_DEV_RC_UNLOCK(dev_id, rc, becall, mutex)\ > +do {\ > + uint32_t temp_rc = rc;\ > + if ((temp_rc) != ZXDH_OK) {\ > + PMD_DRV_LOG(ERR, "ZXDH %s:%d [ErrorCode:0x%x]!-- %s"\ > +

Re: [PATCH v1 14/14] net/zxdh: clean stat values

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:50:17 +0800 Bingbin Chen wrote: > + p_temp_data = temp_data; > + for (i = 0; i < 4; i++) { > + rc = zxdh_np_reg_read(dev_id, > + > ZXDH_SMMU0_SMMU0_CPU_IND_RDAT0R + i, > +

Re: [PATCH v1 12/14] net/zxdh: delete all hash entries

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:50:15 +0800 Bingbin Chen wrote: > +#define ZXDH_COMM_CHECK_POINT_MEMORY_FREE2PTR(point, ptr0, ptr1)\ > +do {\ > + if ((point) == NULL) {\ > + PMD_DRV_LOG(ERR, " ZXDH %s:%d[Error:POINT NULL] ! FUNCTION"\ > + ": %s!", __FILE__, __LINE__, __func__);

Re: [PATCH v1 07/14] net/zxdh: get flow tables resources

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:50:10 +0800 Bingbin Chen wrote: > +static uint32_t > +zxdh_np_get_se_buff_size(uint32_t opr) > +{ > + uint32_t buff_size = 0; > + > + switch (opr) { > + case ZXDH_HASH_FUNC_BULK_REQ: > + { > + buff_size = sizeof(ZXDH_NP_SE_HASH_FUNC_BULK_T); > +

Re: [PATCH v1 04/14] net/zxdh: modify dtb queue ops

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:47:30 +0800 Bingbin Chen wrote: > diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c > index bab8b23a68..1f16f75a23 100644 > --- a/drivers/net/zxdh/zxdh_np.c > +++ b/drivers/net/zxdh/zxdh_np.c > @@ -27,6 +27,7 @@ ZXDH_PPU_STAT_CFG_T g_ppu_stat_cfg; > stat

Re: [PATCH v1 03/14] net/zxdh: add agent channel

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:47:02 +0800 Bingbin Chen wrote: > +static uint32_t > +zxdh_np_comm_mutex_create(ZXDH_MUTEX_T *p_mutex) > +{ > + int32_t rc = 0; > + > + rc = pthread_mutex_init(&p_mutex->mutex, NULL); > + if (rc != 0) { > + PMD_DRV_LOG(ERR, "ErrCode[ 0x%x ]: Create m

Re: [PATCH v1 03/14] net/zxdh: add agent channel

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:47:02 +0800 Bingbin Chen wrote: > Add agent channel to access (np)network processor registers > that are not mapped by PCIE. > > Signed-off-by: Bingbin Chen > --- > drivers/net/zxdh/zxdh_np.c | 481 - > drivers/net/zxdh/zxdh_np.h | 77

Re: [PATCH v1 14/14] net/zxdh: clean stat values

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:50:17 +0800 Bingbin Chen wrote: > + > + case ZXDH_ERAM128_OPR_64b: > + { > + if ((base_addr + (index >> 1)) > > ZXDH_SE_SMMU0_ERAM_ADDR_NUM_TOTAL - 1) { > + PMD_DRV_LOG(ERR, "%s : index out of range !"

Re: [PATCH v1 11/14] net/zxdh: get hash table entry result

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:50:14 +0800 Bingbin Chen wrote: > +static uint32_t > +zxdh_np_dtb_zcam_dump_info_write(uint32_t dev_id, > + uint32_t addr, > + uint32_t tb_width, > +

Re: [PATCH v1 07/14] net/zxdh: get flow tables resources

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:50:10 +0800 Bingbin Chen wrote: > +static uint32_t > +zxdh_np_agent_channel_se_res_get(uint32_t dev_id, > + uint32_t > sub_type, > + uint32_t opr, > +

Re: [PATCH v1 02/14] net/zxdh: support compatibility check

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:46:45 +0800 Bingbin Chen wrote: > + > +static void > +zxdh_np_fw_version_data_read(uint64_t compatible_base_addr, > + ZXDH_VERSION_COMPATIBLE_REG_T *p_fw_version_data, > uint32_t module_id) > +{ > + void *fw_addr = NULL; > + uint64_t module_comp

Re: [PATCH v1 03/14] net/zxdh: add agent channel

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:47:02 +0800 Bingbin Chen wrote: > + > + switch (type) { > + case ZXDH_DEV_MUTEX_T_DTB: > + { > + *p_mutex_out = &p_dev_info->dtb_mutex; > + } > + break; > + > + default: > + { > + PMD_DRV_LOG(ERR, "mutex type is invalid!")

Re: [PATCH v1 14/14] net/zxdh: clean stat values

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:50:17 +0800 Bingbin Chen wrote: > +static uint32_t > +zxdh_np_se_smmu0_ind_read(uint32_t dev_id, > + uint32_t base_addr, > + uint32_t index, > +

Re: [PATCH v1 08/14] net/zxdh: support hash resources configuration

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:50:11 +0800 Bingbin Chen wrote: > +static uint16_t g_lpm_crc[ZXDH_SE_ZBLK_NUM] = { > + 0x1021, 0x8005, 0x3D65, 0xab47, 0x3453, 0x0357, 0x0589, 0xa02b, > + 0x1021, 0x8005, 0x3D65, 0xab47, 0x3453, 0x0357, 0x0589, 0xa02b, > + 0x1021, 0x8005, 0x3D65, 0xab47, 0x3453,

Re: [PATCH v1 05/14] net/zxdh: add tables dump address ops

2025-02-10 Thread Stephen Hemminger
On Mon, 10 Feb 2025 09:48:50 +0800 Bingbin Chen wrote: > + > +#define ZXDH_INIT_D_NODE(ptr, pdata) \ > + do {\ > + ZXDH_D_NODE *temp_ptr = ptr;\ > + (temp_ptr)->data = pdata;\ > + (temp_ptr)->prev = NULL;\ > + (temp_ptr)->next = NULL;\ > + }

[PATCH v3 6/6] trace: fix undefined behavior in register

2025-02-10 Thread David Marchand
Registering a tracepoint handler was resulting so far in undefined behavior at runtime. The RTE_TRACE_POINT_REGISTER() macro was casting the tracepoint handler (which expects arguments) to a void (*)(void). At runtime, calling this handler while registering resulted in reading the current stack wi

[PATCH v3 5/6] dmadev: avoid copies in tracepoints

2025-02-10 Thread David Marchand
No need to copy values in intermediate variables. Just use the right trace point emitters. Signed-off-by: David Marchand --- Changes since v2: - split this change into multiple changes, only kept trivial parts in this patch, --- lib/dmadev/rte_dmadev_trace.h | 12 1 file changed,

[PATCH v3 3/6] trace: support expression for blob length

2025-02-10 Thread David Marchand
Support any expression as a blob length by using an intermediate variable in the trace point emitter itself. This also avoids any side effect on the passed variable. On the "register" side, prefix the length variable in the trace metadata with the name of the emitted argument. With this, we can u

[PATCH v3 4/6] trace: support dumping binary inside a struct

2025-02-10 Thread David Marchand
Make it possible to dump any point of a structure by accepting & and () in the CTF metadata. Update dmadev traces accordingly. Signed-off-by: David Marchand --- Changes since v2: - split this change out of patch 2, as it required updating CTF metadata fixup, --- lib/dmadev/rte_dmadev_trace.h

[PATCH v3 1/6] ci: check traces validity

2025-02-10 Thread David Marchand
We currently do not validate if generated traces can be parsed by a tracing tool. Add some check. Signed-off-by: David Marchand --- Changes since v2: - added this check, as v2 was breaking CTF metadata content, --- .ci/linux-build.sh | 10 ++ .github/workflows/build.yml | 2 +-

[PATCH v3 0/6] Trace point framework enhancement for dmadev

2025-02-10 Thread David Marchand
dmadev trace points have been working around trace point framework limitations. One of this workaround blocks enabling dmadev on MSVC. Traces files were not checked in CI, so this series also adds a new check. -- David Marchand Changes since v2: - added check of traces validity in GHA, - split

[PATCH v3 2/6] trace: support dereferencing arguments

2025-02-10 Thread David Marchand
Rather than use an intermediate variable, allow use of * to dereference a trace point argument. Update dmadev traces accordingly (and adjust the emitter type). Signed-off-by: David Marchand --- Changes since v2: - split this change out of patch 2, as it required updating CTF metadata fixup, --

[RFC] git: consolidate .gitignore files

2025-02-10 Thread Stephen Hemminger
Lets have only one .gitignore at top level. Signed-off-by: Stephen Hemminger --- .gitignore | 6 ++ dts/.gitignore | 4 kernel/linux/uapi/.gitignore | 4 3 files changed, 6 insertions(+), 8 deletions(-) delete mode 100644 dts/.gitignore delete mode

[PATCH] drivers: fix build warnings when using icx

2025-02-10 Thread Bruce Richardson
The Intel oneAPI DPC++/C++ Compiler (icx), issues warnings on build when the "-march=native", or other configured global "-march" flag, is overridden to "skylake-avx512", when compiling AVX-512 code. Allow building with icx with warnings-as-errors flag (werror) enabled by disabling the warning for

[PATCH v3] build: replace support for icc with icx

2025-02-10 Thread Bruce Richardson
The "Intel C++ Compiler" (icc) has been replaced by the newer clang-based "Intel oneAPI DPC++/C++ Compiler" (icx) compiler. DPDK compilation has also not been tested recently with the icc compiler, so let's remove doc and code references to icc, and any special macros or build support that was add

Re: [PATCH] crypto/mlx5: log when num of segs exceed max segs

2025-02-10 Thread Stephen Hemminger
On Sun, 9 Feb 2025 14:08:51 +0200 Gregory Etelson wrote: > - MLX5_ASSERT(nb_segs <= qp->priv->max_segs_num); > + if (nb_segs > qp->priv->max_segs_num) { > + DRV_LOG(WARNING, "Segment count exceeds limit. " > + "Current segments: %d, Maximum allowed:

Re: [PATCH] devtools: ignore .gitignore in SPDX check

2025-02-10 Thread Thomas Monjalon
07/02/2025 19:26, Stephen Hemminger: > New .gitignore file in dts was getting marked as error. > Change to ignore all .gitignore files. Actually I would prefer we don't create too much .gitignore files. It is easier to manage if we have all in a single .gitignore. We have already a line for DTS in

RE: [PATCH v5 2/3] graph: add support for node free API

2025-02-10 Thread Jerin Jacob
> -Original Message- > From: kirankum...@marvell.com > Sent: Tuesday, November 26, 2024 10:14 AM > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan > Cc: dev@dpdk.org; rja...@redhat.com; chcch...@163.com > Subject: [PATCH v5 2/3] graph: add support

RE: [PATCH v5 3/3] test/graph: fix graph autotest second run test failure

2025-02-10 Thread Jerin Jacob
> -Original Message- > From: kirankum...@marvell.com > Sent: Tuesday, November 26, 2024 10:14 AM > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan > Cc: dev@dpdk.org; rja...@redhat.com; chcch...@163.com > Subject: [PATCH v5 3/3] test/graph: fix gra

[PATCH v5 4/4] net/intel: allow building ice driver without iavf

2025-02-10 Thread Bruce Richardson
The ice PMD relies on a number of functions from the iavf base code, which can be got by linking against that iavf driver. However, since only three C files are necessary here, we can allow ice to be built independently of iavf by including the base files directly in cases where iavf is not part of

[PATCH v5 1/4] drivers: merge common and net idpf drivers

2025-02-10 Thread Bruce Richardson
Rather than having some of the idpf code split out into the "common" directory, used by both a net/idpf and a net/cpfl driver, we can merge all idpf code together under net/idpf and have the cpfl driver depend on "net/idpf" rather than "common/idpf". Signed-off-by: Bruce Richardson Acked-by: Prav

[PATCH v5 3/4] drivers: move iavf common folder to iavf net

2025-02-10 Thread Bruce Richardson
The common/iavf driver folder contains the base code for the iavf driver, which is also linked against by the ice driver and others. However, there is no need for this to be in common, and we can move it to the net/intel/iavf as a base code driver. This involves updating dependencies that were on c

[PATCH v5 2/4] net/idpf: re-enable unused variable warnings

2025-02-10 Thread Bruce Richardson
The idpf driver was being built with warnings disabled for unused variables. However, while the warning was being disabled in the base code directory, all suppressed warnings were in the main directory. Therefore, just remove the unused variables and re-enable the warnings. Signed-off-by: Bruce Ri

[PATCH v5 0/4] remove common iavf and idpf drivers

2025-02-10 Thread Bruce Richardson
The iavf and idpf common directories were used only to share code between multiple net drivers and did not need to be drivers in their own right, since it is just as easy to have a dependency from one net driver on another as a net driver on a common one. This patchset therefore aims to eliminate

Re: [PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch

2025-02-10 Thread Bruce Richardson
On Mon, Feb 10, 2025 at 09:35:22AM +, Bruce Richardson wrote: > On Fri, Feb 07, 2025 at 11:01:57AM -0800, Stephen Hemminger wrote: > > On Fri, 7 Feb 2025 09:41:08 -0800 > > Andre Muezerie wrote: > > > > > This patch avoids warnings like the ones below emitted by MSVC: > > > > > > 1) > > > .

Re: [PATCH v2 0/3] flexible IPv4 fragment action

2025-02-10 Thread Bruce Richardson
On Fri, Jan 24, 2025 at 09:13:20AM +, Mingjin Ye wrote: > Support for distributing the first and other segments of an IPv4 > segmented packet to different RX queues. > --- > V2: All names standardised to *_IPV4_FRAG_OFS. > > Mingjin Ye (3): > net/ice/base: add ipv4 fragment related field >

Re: [EXTERNAL] [PATCH v2 3/3] trace: fix undefined behavior in register

2025-02-10 Thread David Marchand
On Mon, Feb 10, 2025 at 2:37 PM Jerin Jacob wrote: > > + > > +#define __RTE_TRACE_POINT(_mode, _tp, _args, ...) \ extern > > +rte_trace_point_t __##_tp; \ static __rte_always_inline void _tp _args > > +{ } \ static __rte_always_inline void \ _tp ## _register (void) \ { \ > > + __rte_trace_poin

RE: [EXTERNAL] [PATCH v2 1/3] trace: support expression for blob length

2025-02-10 Thread Jerin Jacob
> -Original Message- > From: David Marchand > Sent: Thursday, January 30, 2025 8:29 PM > To: dev@dpdk.org > Cc: Jerin Jacob ; Sunil Kumar Kori ; > Tyler Retzlaff ; Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko > Subject: [EXTERNAL] [PATCH v2 1/3] trace: support expression for b

RE: [EXTERNAL] [PATCH v2 3/3] trace: fix undefined behavior in register

2025-02-10 Thread Jerin Jacob
> -Original Message- > From: David Marchand > Sent: Thursday, January 30, 2025 8:29 PM > To: dev@dpdk.org > Cc: Chengwen Feng ; Kevin Laatz > ; Bruce Richardson ; > Jerin Jacob ; Sunil Kumar Kori ; Tyler > Retzlaff > Subject: [EXTERNAL] [PATCH v2 3/3] trace: fix undefined behavior in r

Re: [PATCH v5 0/2] enable AVX2 for single queue Rx/Tx

2025-02-10 Thread Bruce Richardson
On Mon, Feb 03, 2025 at 01:25:06PM +0530, Shaiq Wani wrote: > > v5: > - Addressed review comments. > - Used newly introduced macros as suggested. > - Fixed build and compilation issues. > > Shaiq Wani (2): > common/idpf: enable AVX2 for single queue Rx > common/idpf: enable AVX2 for single qu

Re: [PATCH v5 2/2] common/idpf: enable AVX2 for single queue Tx

2025-02-10 Thread Bruce Richardson
On Mon, Feb 03, 2025 at 01:25:08PM +0530, Shaiq Wani wrote: > In case some CPUs don't support AVX512. Enable AVX2 for them to > get better per-core performance. > > The single queue model processes all packets in order while > the split queue model separates packet data and metadata into > differe

Re: [PATCH v2 2/2] drivers/net: fix void function returning a value

2025-02-10 Thread Bruce Richardson
On Wed, Jan 22, 2025 at 03:48:11PM +, Bruce Richardson wrote: > On Wed, Jan 22, 2025 at 07:20:44AM -0800, Andre Muezerie wrote: > > This patch avoids warnings like the one below emitted by MSVC: > > > > ../drivers/common/idpf/idpf_common_rxtx_avx512.c(139): > > warning C4098: 'idpf_singleq

Re: [PATCH v2 1/2] drivers/common: fix void function returning a value

2025-02-10 Thread Bruce Richardson
On Wed, Jan 22, 2025 at 03:47:29PM +, Bruce Richardson wrote: > On Wed, Jan 22, 2025 at 07:20:43AM -0800, Andre Muezerie wrote: > > This patch avoids warnings like the one below emitted by MSVC: > > > > ../drivers/common/idpf/idpf_common_rxtx_avx512.c(139): > > warning C4098: 'idpf_singleq

RE: [PATCH v2 2/2] build: replace support for icc with icx

2025-02-10 Thread Stokes, Ian
> The "Intel C++ Compiler" (icc) has been replaced by the newer clang-based > "Intel oneAPI DPC++/C++ Compiler" (icx) compiler. DPDK compilation has > also not been tested recently with the icc compiler, so let's remove doc > and code references to icc, and any special macros or build support that

RE: [PATCH v2 1/2] drivers: fix build warnings when using icx

2025-02-10 Thread Stokes, Ian
> The Intel oneAPI DPC++/C++ Compiler (icx), issues warnings on build when > the "-march=native", or other configured global "-march" flag, is > overridden to "skylake-avx512", when compiling AVX-512 code. > > Allow building with icx with warnings-as-errors flag (werror) enabled by > disabling the

RE: [PATCH 05/32] dma/dpaa2: replace memcpy with assignment

2025-02-10 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [PATCH 25/32] net/dpaa2: replace memcpy with structure assignment

2025-02-10 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 09-02-2025 01:52, Stephen Hemminger wrote: Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 5 ++--- drivers/net/dpaa2/dpaa2_flow.c | 9 +++-- 2 files changed, 5

Re: [PATCH 19/32] net/dpaa2: replace memcpy with assignment

2025-02-10 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 09-02-2025 01:52, Stephen Hemminger wrote: Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH 07/32] event/dpaa2: replace memcpy with structure assignment

2025-02-10 Thread Hemant Agrawal
Acked-by: Hemant Agrawal On 09-02-2025 01:51, Stephen Hemminger wrote: Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/event/dpaa2/dpaa2_eventdev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

Re: [PATCH 04/32] crypto/dpaa_sec: replace memcpy with assignment

2025-02-10 Thread Hemant Agrawal
On 09-02-2025 01:51, Stephen Hemminger wrote: Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa

Re: [PATCH] net/mlx5: fix the GRE mask set on root table

2025-02-10 Thread Raslan Darawsheh
Hi, From: Gregory Etelson Sent: Monday, February 10, 2025 12:14 PM To: dev@dpdk.org Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Bing Zhao; sta...@dpdk.org Subject: [PATCH] net/mlx5: fix the GRE mask set on root table From: Bing Zhao When setting the value, the GRE mask cannot reuse

Re: [PATCH] net/mlx5: fix GRE open matcher does not match packet

2025-02-10 Thread Raslan Darawsheh
Hi, From: Maayan Kashani Sent: Tuesday, January 28, 2025 9:59 AM To: dev@dpdk.org Cc: Maayan Kashani; Raslan Darawsheh; sta...@dpdk.org; Bing Zhao; Dariusz Sosnowski; Slava Ovsiienko; Ori Kam; Suanming Mou; Matan Azrad; Gregory Etelson Subject: [PATCH] net/mlx5: fix GRE open matcher does not mat

[PATCH] net/mlx5: fix the GRE mask set on root table

2025-02-10 Thread Gregory Etelson
From: Bing Zhao When setting the value, the GRE mask cannot reuse the one from the value, or else the value cannot be really ANDed with the proper input mask from the user. If the value contains more valid bits than the mask, the rule insertion on the root table will get a failure due to the extr

Re: [EXTERNAL] Re: [PATCH v2 3/3] trace: fix undefined behavior in register

2025-02-10 Thread David Marchand
On Mon, Feb 10, 2025 at 10:02 AM Sunil Kumar Kori wrote: > > Hi David, > > I tried validating series to see the trace results but babeltrace throws > error while reading metadata file and traces can’t be generated. > > Can you please have a look into this ? Ok, I see what is wrong, in the dma tr

Re: [PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch

2025-02-10 Thread Bruce Richardson
On Fri, Feb 07, 2025 at 11:01:57AM -0800, Stephen Hemminger wrote: > On Fri, 7 Feb 2025 09:41:08 -0800 > Andre Muezerie wrote: > > > This patch avoids warnings like the ones below emitted by MSVC: > > > > 1) > > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > > result of 32

Re: [PATCH] doc: document hash RSS limitations with CQE zipping

2025-02-10 Thread Raslan Darawsheh
Hi, From: Alexander Kozyrev Sent: Friday, January 10, 2025 12:34 AM To: dev@dpdk.org Cc: Raslan Darawsheh; Slava Ovsiienko; Dariusz Sosnowski; Bing Zhao; Suanming Mou Subject: [PATCH] doc: document hash RSS limitations with CQE zipping RSS hash is only fully supported when the Hash RSS format i

RE: [EXTERNAL] Re: [PATCH v2 3/3] trace: fix undefined behavior in register

2025-02-10 Thread Sunil Kumar Kori
Hi David, I tried validating series to see the trace results but babeltrace throws error while reading metadata file and traces can’t be generated. Can you please have a look into this ? Thanks. From: Sunil Kumar Kori Sent: Friday, February 7, 2025 5:09 PM To: David Marchand ; Jerin Jacob Cc:

Re: [PATCH] net/af_packet: fix socket close on device stop

2025-02-10 Thread Tudor Cornea
> Applied to next-net > Should this go to stable as well I think it would probably make sense to have it in stable.

RE: [PATCH] examples/ipsec-secgw: fix iv len in ctr 192/256

2025-02-10 Thread Anoob Joseph
> Subject: [PATCH] examples/ipsec-secgw: fix iv len in ctr 192/256 > > This patch fixes IV length to 8 in case of AES-CTR 192/256. > > Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional algorithms") > > Signed-off-by: Nithinsen Kaithakadan Acked-by: Anoob Joseph