Re: Testing dpdk application using openNIC driver

2025-02-04 Thread David Marchand
Hello, Please don't go private, as I tend to just ignore such mail. Re-adding ml and others. And don't top post. On Wed, Feb 5, 2025 at 8:06 AM Nafiah Siddiqha wrote: > > Hi, > I'm able to run testpmd with the given set of instructions you had mentioned > and tried it with pktgen fir which I'm

Re: [RFC 0/3] Vhost: fix FD entries cleanup

2025-02-04 Thread Chenbo Xia
Hi David, > On Feb 4, 2025, at 21:18, David Marchand wrote: > > External email: Use caution opening links or attachments > > > Hello vhost maintainers, > > On Tue, Dec 24, 2024 at 4:50 PM Maxime Coquelin > wrote: >> >> The vhost FD manager provides a way for the read/write >> callbacks to r

[dpdk-dev] [PATCH v5 1/2] common/cnxk: support NPC flow on cn20k

2025-02-04 Thread psatheesh
From: Satheesh Paul ROC changes to support NPC flow on cn20k. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- v2: * Fixed generic platform compiler error. v3: * Removed compile time macros. v4: * Rebased the patches. v5: * Updated release notes. * Fixed '__io' label for mbox field.

[dpdk-dev] [PATCH v5 2/2] net/cnxk: support rte flow on cn20k

2025-02-04 Thread psatheesh
From: Satheesh Paul Support for rte flow in cn20k. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- doc/guides/rel_notes/release_25_03.rst | 4 + drivers/net/cnxk/cn10k_flow.c | 227 ++--- drivers/net/cnxk/cn10k_flow.h | 10 +- drivers/net/c

RE: [EXTERNAL] [PATCH v2] drivers/net: use intrinsic to access content of __m128i

2025-02-04 Thread Vamsi Krishna Attunuru
>-Original Message- >From: Andre Muezerie >Sent: Saturday, December 28, 2024 6:53 AM >To: andre...@linux.microsoft.com >Cc: bruce.richard...@intel.com; dev@dpdk.org; >konstantin.v.anan...@yandex.ru; Vamsi Krishna Attunuru > >Subject: [EXTERNAL] [PATCH v2] drivers/net: use intrinsic to a

Re: [PATCH v4] bus: fix inconsistent representation of PCI numbers

2025-02-04 Thread fengchengwen
On 2025/1/30 2:06, Bruce Richardson wrote: > On Wed, Jan 29, 2025 at 09:17:38AM -0800, Stephen Hemminger wrote: >> On Wed, 29 Jan 2025 10:54:16 +0200 >> Shani Peretz wrote: >> >>> DPDK provides two formats for specifying PCI device numbers: >>> a full version (":08:00.0") and a short version (

Re: [PATCH 3/3] dts: bump up fabric version

2025-02-04 Thread Patrick Robb
Tested from a Fedora41/python3.13 container. Tested-by: Patrick Robb Reviewed-by: Patrick Robb Applying to next-dts, thanks for the patch Luca.

Re: [PATCH 2/3] dts: stop using partial in enums

2025-02-04 Thread Patrick Robb
Tested from a Fedora41/python3.13 container. Tested-by: Patrick Robb Reviewed-by: Patrick Robb Applying to next-dts, thanks for the patch Luca.

Re: [PATCH 1/3] dts: remove use of field validators

2025-02-04 Thread Patrick Robb
Tested from a Fedora41/python3.13 container. Tested-by: Patrick Robb Reviewed-by: Patrick Robb Applying to next-dts, thanks for the patch Luca.

[PATCH v21 10/27] net/ixgbe: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable len

[PATCH v21 01/27] eal: include header required for alloca

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/freebsd/include/rte_os.h | 1 + lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 3 files changed, 3 insertions(+) d

[PATCH v21 21/27] config: define no_wvla_cflag

2025-02-04 Thread Andre Muezerie
We define no_wvla_cflag in a top directory so that it can be used by meson.build files in lower directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- config/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/config/meson.build b/config/meson.build index 6a

[PATCH v21 27/27] config: add -Wvla project-wide

2025-02-04 Thread Andre Muezerie
Add -Wvla project-wide so that VLAs are not allowed by default. This is to avoid new VLAs from being introduced. Meson files in directories which are not yet VLA-free have already been updated with -Wno-vla to avoid build breaks. Signed-off-by: Andre Muezerie --- config/meson.build | 1 + 1 fil

[PATCH v21 14/27] common/idpf: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- drivers/common/idpf/idpf_common_rxtx.c

[PATCH v21 15/27] net/i40e: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Reviewed-by: Bruce Richardson --- drivers/net/intel/i40e/i40e_testpmd.c |

Re: [RFC PATCH 0/7] dts: revamp framework

2025-02-04 Thread Dean Marx
Hi Luca, I saw in the meeting minutes that the main purpose of this series is to implement the separation of concern principle better in DTS. Just wondering, what parts of the current framework did you think needed to be separated and why? I'm taking an OOP class this semester and we just started

[PATCH v21 23/27] drivers: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- drivers/common/cnxk/meson.build | 2 ++ drivers/common/mlx5/meson.build | 2 ++ drivers/common/qat/meson.build | 2 ++ drivers/crypto/ccp/meson.build

[PATCH v21 09/27] gro: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to collect un-used by GRO packets, and then cop

[PATCH v21 05/27] hash: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v21 24/27] lib: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- lib/acl/meson.build| 2 ++ lib/bpf/meson.build| 2 ++ lib/dispatcher/meson.build | 2 ++ lib/eventdev/meson.build | 2 ++ lib/ipsec/meson.build |

[PATCH v21 17/27] net/mlx5: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

[PATCH v21 16/27] common/mlx5: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v21 22/27] app: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- app/pdump/meson.build| 2 ++ app/proc-info/meson.build| 2 ++ app/test-acl/meson.build | 2 ++ app/test-bbdev/meson.build | 2 ++ app/

[PATCH v21 26/27] buildtools: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- buildtools/chkincs/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build index ed65105599..49dbc55

[PATCH v21 13/27] test: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng --- app/test/test.c | 2 +-

[PATCH v21 19/27] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

2025-02-04 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie Acked-by: Chengwen Feng --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH v21 18/27] test: remove use of VLAs for Windows built code in bitset tests

2025-02-04 Thread Andre Muezerie
1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=array-bounds=] 3695

[PATCH v21 20/27] hash: remove use of VLAs by using standard arrays

2025-02-04 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays. Signed-off-by: Andre Muezerie --- lib/hash/rte_thash_gf2_poly_math.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte_thash_gf2_poly_math.c b/lib/hash/rte_thash_gf2_poly_math.c index 1c6297

[PATCH v21 12/27] app/testpmd: remove use of VLAs for Windows built

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng --- app/test-pmd/cmdline.c | 2 +- app/test

[PATCH v21 25/27] examples: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- examples/fips_validation/meson.build | 2 ++ examples/ip_fragmentation/meson.build | 1 + examples/ipsec-secgw/meson.build | 3 +++ examples/l2fwd-crypto/meson.build

[PATCH v21 11/27] net/ice: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we ca

[PATCH v21 06/27] hash/thash: remove use of VLAs for Windows built

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ The tuple can exceed sizeof(union rte_thash_tuple), for example if any tunneling header is used in the RSS hash calculation. The longest RSS hash key currently supported is

[PATCH v21 08/27] gro: fix overwrite unprocessed packets

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Ferr

[PATCH v21 07/27] rcu: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v21 04/27] ethdev: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v21 00/27] remove use of VLAs for Windows

2025-02-04 Thread Andre Muezerie
As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

[PATCH v21 02/27] eal/linux: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array 'events' MSVC does not support VLAs. Use alloca() to allocate the memory on the stack. 2) ./lib/eal/linux/eal_interrupts.c:1319:16 : warning: ISO C90 forbids variable le

[PATCH v21 03/27] eal/common: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev Acked-by: Stephen Hemminger --- lib/eal/common/eal_common

[PATCH v2] eal: force compilation of RTE_ASSERT expression

2025-02-04 Thread Stephen Hemminger
Even if RTE_ENABLE_ASSERT is not enabled, the expression used should still be checked for compiler warnings. Use sizeof() and ternary operator in same manner as the assert() macro to cause the expression to be evaluated but not generate code. This was motivated by detection of problems in a driver

[PATCH v4 3/7] drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Andre Muezerie
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

[PATCH v4 6/7] drivers/raw: eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Andre Muezerie
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

[PATCH v4 5/7] drivers/net: eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Andre Muezerie
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

[PATCH v4 7/7] mldev: eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Andre Muezerie
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

[PATCH v4 1/7] eal: eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Andre Muezerie
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

[PATCH v4 4/7] drivers/dma: eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Andre Muezerie
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

[PATCH v4 2/7] drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Andre Muezerie
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

[PATCH v4 0/7] eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Andre Muezerie
Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. Therefore the errors below are seen with MSVC: ../lib/mldev/mldev_utils_scalar.c(465): error C2065: '__SIZEOF_LONG__': undeclared identifier ../lib/mldev/mldev_utils_scalar.c(478): error C2051: case expression not const

Re: [RFC] ci: Add support for Cirrus-CI service to test FreeBSD.

2025-02-04 Thread Patrick Robb
On Tue, Feb 4, 2025 at 11:07 AM Aaron Conole wrote: > This commit adds preliminary support for developer driven FreeBSD testing > via the Cirrus-CI cloud continuous integration system. > > NOTE: Currently, this does not successfully execute. See the following > build result: > https://cirrus-c

Re: [PATCH v3 2/2] stack: enable build with MSVC

2025-02-04 Thread Patrick Robb
Recheck-request: iol-intel-Performance Triggering a retest in CI for the failed performance result.

RE: [PATCH v2] net/cnxk: fix of NIX send header L3 type

2025-02-04 Thread Jerin Jacob
> -Original Message- > From: Rahul Bhansali > Sent: Thursday, January 30, 2025 5:25 PM > To: dev@dpdk.org; Nithin Kumar Dabilpuram ; > Kiran Kumar Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Harman Kalra ; Pavan > Nikhilesh Bhagavatula ; Jerin Jacob > ; Rahul Bha

[PATCH] eal: force evaluation of RTE_ASSERT expression

2025-02-04 Thread Stephen Hemminger
Even if RTE_ENABLE_ASSERT is not enabled, the expression used should still be evaluated to check for compiler warnings. Use sizeof and ternary operator in same manner as the assert() macro to cause the expression to be evaluated but not generate code. Signed-off-by: Stephen Hemminger --- lib/eal

[PATCH] net/af_packet: fix socket close on device stop

2025-02-04 Thread Tudor Cornea
Currently, if we call rte_eth_dev_stop(), the sockets are closed. If we attempt to start the port again, socket related operations will not work correctly. This can be alleviated by closing the socket at the same place in which we currently free the memory, in eth_dev_close(). If an application c

Re: [PATCH v19 00/27] remove use of VLAs for Windows

2025-02-04 Thread Andre Muezerie
On Tue, Feb 04, 2025 at 10:38:55AM -0500, Patrick Robb wrote: > It looks like this failed the check-meson script which we incorporated into > our apply/build pipeline recently, which is why this series got a "build > failure." It is indicating there are issues with lib/vhost/meson.build > and app/t

[PATCH v20 25/27] examples: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- examples/fips_validation/meson.build | 2 ++ examples/ip_fragmentation/meson.build | 1 + examples/ipsec-secgw/meson.build | 3 +++ examples/l2fwd-crypto/meson.build

[PATCH v20 18/27] test: remove use of VLAs for Windows built code in bitset tests

2025-02-04 Thread Andre Muezerie
1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=array-bounds=] 3695

[PATCH v20 22/27] app: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- app/pdump/meson.build| 2 ++ app/proc-info/meson.build| 2 ++ app/test-acl/meson.build | 2 ++ app/test-bbdev/meson.build | 2 ++ app/

[PATCH v20 26/27] buildtools: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- buildtools/chkincs/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build index ed65105599..49dbc55

[PATCH v20 27/27] config: add -Wvla project-wide

2025-02-04 Thread Andre Muezerie
Add -Wvla project-wide so that VLAs are not allowed by default. This is to avoid new VLAs from being introduced. Meson files in directories which are not yet VLA-free have already been updated with -Wno-vla to avoid build breaks. Signed-off-by: Andre Muezerie --- config/meson.build | 1 + 1 fil

[PATCH v20 15/27] net/i40e: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Reviewed-by: Bruce Richardson --- drivers/net/intel/i40e/i40e_testpmd.c |

[PATCH v20 13/27] test: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng --- app/test/test.c | 2 +-

[PATCH v20 17/27] net/mlx5: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

[PATCH v20 19/27] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

2025-02-04 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie Acked-by: Chengwen Feng --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH v20 23/27] drivers: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- drivers/common/cnxk/meson.build | 2 ++ drivers/common/mlx5/meson.build | 2 ++ drivers/common/qat/meson.build | 2 ++ drivers/crypto/ccp/meson.build

[PATCH v20 20/27] hash: remove use of VLAs by using standard arrays

2025-02-04 Thread Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays. Signed-off-by: Andre Muezerie --- lib/hash/rte_thash_gf2_poly_math.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/hash/rte_thash_gf2_poly_math.c b/lib/hash/rte_thash_gf2_poly_math.c index 1c6297

[PATCH v20 24/27] lib: add no_wvla_cflag to directories that are not VLA-free

2025-02-04 Thread Andre Muezerie
The no_wvla_cflag is added to meson.build files in directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- lib/acl/meson.build| 2 ++ lib/bpf/meson.build| 2 ++ lib/dispatcher/meson.build | 2 ++ lib/eventdev/meson.build | 2 ++ lib/ipsec/meson.build |

[PATCH v20 16/27] common/mlx5: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v20 21/27] config: define no_wvla_cflag

2025-02-04 Thread Andre Muezerie
We define no_wvla_cflag in a top directory so that it can be used by meson.build files in lower directories that are not yet VLA-free. Signed-off-by: Andre Muezerie --- config/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/config/meson.build b/config/meson.build index 6a

[PATCH v20 10/27] net/ixgbe: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable len

[PATCH v20 14/27] common/idpf: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- drivers/common/idpf/idpf_common_rxtx.c

[PATCH v20 06/27] hash/thash: remove use of VLAs for Windows built

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ The tuple can exceed sizeof(union rte_thash_tuple), for example if any tunneling header is used in the RSS hash calculation. The longest RSS hash key currently supported is

[PATCH v20 12/27] app/testpmd: remove use of VLAs for Windows built

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng --- app/test-pmd/cmdline.c | 2 +- app/test

[PATCH v20 05/27] hash: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v20 11/27] net/ice: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we ca

[PATCH v20 09/27] gro: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to collect un-used by GRO packets, and then cop

[PATCH v20 08/27] gro: fix overwrite unprocessed packets

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Ferr

[PATCH v20 04/27] ethdev: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v20 07/27] rcu: remove use of VLAs for Windows built code

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v20 01/27] eal: include header required for alloca

2025-02-04 Thread Andre Muezerie
From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/freebsd/include/rte_os.h | 1 + lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 3 files changed, 3 insertions(+) d

[PATCH v20 03/27] eal/common: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev Acked-by: Stephen Hemminger --- lib/eal/common/eal_common

[PATCH v20 00/27] remove use of VLAs for Windows

2025-02-04 Thread Andre Muezerie
As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

[PATCH v20 02/27] eal/linux: remove use of VLAs

2025-02-04 Thread Andre Muezerie
From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array 'events' MSVC does not support VLAs. Use alloca() to allocate the memory on the stack. 2) ./lib/eal/linux/eal_interrupts.c:1319:16 : warning: ISO C90 forbids variable le

RE: [EXTERNAL] [RFC PATCH v6 1/2] eventdev: add atomic queue to test-eventdev app

2025-02-04 Thread Pavan Nikhilesh Bhagavatula
> Add an atomic queue test to the test-eventdev app, which is based on the > order queue test that exclusively uses atomic queues. > > This makes it compatible with event devices such as the > distributed software eventdev. > > The test detects if port maintenance is required. > > To verify atom

[RFC] ci: Add support for Cirrus-CI service to test FreeBSD.

2025-02-04 Thread Aaron Conole
This commit adds preliminary support for developer driven FreeBSD testing via the Cirrus-CI cloud continuous integration system. NOTE: Currently, this does not successfully execute. See the following build result: https://cirrus-ci.com/task/5626189961756672 Full Logs: https://api.cirrus-ci.c

Re: [PATCH] net: support Arista L2 headers

2025-02-04 Thread Thomas Monjalon
04/02/2025 16:41, Denis Davidoglu: > Packet parsing and type detection fail for packets containing > Arista Vendor Specific Protocol (AVSP) headers. This patch adds > support for three L2 headers: Arista TGen, Arista 64-bit Timestamp > and Arista 48-bit Timestamp. I'm not familiar with these head

Re: [PATCH] devtools: forbid use of compiler pragmas

2025-02-04 Thread Thomas Monjalon
30/01/2025 09:37, David Marchand: > Using pragma must be prevented to avoid breaking builds with other > compilers. > Let EAL use them (like for abstraction macros). > > Signed-off-by: David Marchand > --- > + # forbid use of #pragma > + awk -v FOLDERS='lib drivers app examples' \ > +

Re: [PATCH v3 2/7] drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__

2025-02-04 Thread Thomas Monjalon
06/12/2024 19:14, Andre Muezerie: > On Fri, Dec 06, 2024 at 04:41:16PM +, Konstantin Ananyev wrote: > > > > > > > Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it. > > > > > Therefore the errors below are seen with MSVC: > > > > > > > > > > ../lib/mldev/mldev_utils_scalar.

RE: [PATCH] doc: update ODM dmadev guide

2025-02-04 Thread Jerin Jacob
> -Original Message- > From: Anoob Joseph > Sent: Tuesday, January 28, 2025 1:46 PM > To: Chengwen Feng ; Kevin Laatz > ; Bruce Richardson ; > Thomas Monjalon ; David Marchand > > Cc: Jerin Jacob ; Vidya Sagar Velumuri > ; dev@dpdk.org > Subject: [PATCH] doc: update ODM dmadev guide >

Re: [PATCH v1 00/42] Merge Intel IGC and E1000 drivers, and update E1000 base code

2025-02-04 Thread Burakov, Anatoly
On 03/02/2025 9:18, David Marchand wrote: Hello Anatoly, On Fri, Jan 31, 2025 at 1:59 PM Anatoly Burakov wrote: Intel IGC and E1000 drivers are distinct, but they are actually generated from the same base code. This patchset will merge together all e1000-derived drivers into one common base,

Re: [PATCH v19 00/27] remove use of VLAs for Windows

2025-02-04 Thread Patrick Robb
It looks like this failed the check-meson script which we incorporated into our apply/build pipeline recently, which is why this series got a "build failure." It is indicating there are issues with lib/vhost/meson.build and app/test/meson.build. Obviously we need to provide an email body which mak

[PATCH] net: support Arista L2 headers

2025-02-04 Thread Denis Davidoglu
Packet parsing and type detection fail for packets containing Arista Vendor Specific Protocol (AVSP) headers. This patch adds support for three L2 headers: Arista TGen, Arista 64-bit Timestamp and Arista 48-bit Timestamp. Signed-off-by: Denis Davidoglu --- lib/net/rte_ether.h | 31 ++

[PATCH v2 44/54] net/e1000/base: introduce PHY ID retry mechanism

2025-02-04 Thread Anatoly Burakov
From: Nir Efrati On some customer platforms it was observed that invalid PHY ID (0x) was returned on first try. This patch introduces PHY ID retry mechanism to perform retries on PHY ID read for up to a second. Because the original code was intentionally not checking PHY ID due to a different

Re: [PATCH v3 2/2] stack: enable build with MSVC

2025-02-04 Thread Andre Muezerie
On Tue, Feb 04, 2025 at 10:30:03AM +, Bruce Richardson wrote: > On Mon, Feb 03, 2025 at 05:58:38PM -0800, Andre Muezerie wrote: > > An implementation compatible with MSVC is provided for > > atomic128_cmp_exchange in rte_stack_lf_c11.h. > > > > Now that the issues preventing the code needed to

[PATCH v2 11/54] net/e1000/base: rename VLAN PQF macros

2025-02-04 Thread Anatoly Burakov
From: Sasha Neftin Align VLAN PQF naming convention to base code usage, as well as fix typos. Signed-off-by: Sasha Neftin Signed-off-by: Anatoly Burakov --- drivers/net/intel/e1000/base/e1000_defines.h | 6 +++--- drivers/net/intel/e1000/base/e1000_regs.h| 2 +- 2 files changed, 4 inserti

[PATCH v2 14/54] net/e1000/base: add LED blink support for i225

2025-02-04 Thread Anatoly Burakov
From: Menachem Fogel Implement LED blinking for i225. Signed-off-by: Fogel Menachem Signed-off-by: Anatoly Burakov --- drivers/net/intel/e1000/base/e1000_i225.c | 44 +++ drivers/net/intel/e1000/base/e1000_i225.h | 8 + 2 files changed, 52 insertions(+) diff --git a/

[PATCH v2 40/54] net/e1000/base: hardcode bus parameters for ICH8

2025-02-04 Thread Anatoly Burakov
From: Dima Ruinskiy Current implementation of e1000_get_bus_info_ich8lan first attempts to call e1000_get_bus_info_pcie_generic, and hard codes the bus width if the latter does not return a valid value. However, e1000_get_bus_info_pcie_generic will always fail on an ICH device, since no PCIe cap

[PATCH v2 07/54] net/e1000: add support for more I219 devices

2025-02-04 Thread Anatoly Burakov
From: Vitaly Lifshits Add support for new hardware ID's from the I219 series. Signed-off-by: Lifshits, Vitaly Signed-off-by: Anatoly Burakov --- drivers/net/intel/e1000/base/e1000_api.c | 32 + drivers/net/intel/e1000/base/e1000_hw.h | 36 +--- drivers

[PATCH v2 19/54] net/e1000/base: fix bitwise op type mismatch

2025-02-04 Thread Anatoly Burakov
From: Przemyslaw Ciesielski Static analysis has found type mismatch between mask and register value. Fix the bitwise operation type to avoid potential issues. Signed-off-by: Przemyslaw Ciesielski Signed-off-by: Anatoly Burakov --- drivers/net/intel/e1000/base/e1000_i225.c | 2 +- 1 file chang

[PATCH v2 15/54] net/e1000/base: increase PHY power up delay

2025-02-04 Thread Anatoly Burakov
From: Sasha Neftin PHY specification for i225 requires 300 microsecond delay after power up sequence, so increase the delay after power up to 300 microseconds. Signed-off-by: Sasha Neftin Signed-off-by: Anatoly Burakov --- drivers/net/intel/e1000/base/e1000_phy.c | 1 + 1 file changed, 1 inse

[PATCH v2 08/54] net/e1000/base: correct formatting differences

2025-02-04 Thread Anatoly Burakov
There are some mismatches between what's in the base driver, and what is in DPDK version of it. This patch fixes the following issues: - Unneeded #ifndef clause - Missing comments - Duplicate definitions - Moved definitions - Extraneous fall-through comments - Function comments not matching functi

[PATCH v2 53/54] net/e1000/base: rename NVM version variable

2025-02-04 Thread Anatoly Burakov
From: Piotr Kubaj Rename version to nvm_version to avoid shadowing global variables on some systems. Signed-off-by: Piotr Kubaj Signed-off-by: Anatoly Burakov --- drivers/net/intel/e1000/base/e1000_i210.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drive

  1   2   >