RE: [PATCH] test/crypto: check for RSA capability

2025-01-07 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: check for RSA capability > > In RSA crypto tests, check if it is supported by PMD before > executing it. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Acked-by: Akhil Goyal

RE: [PATCH] crypto/virtio: fix dataqueues iteration

2025-01-07 Thread Akhil Goyal
> Subject: [PATCH] crypto/virtio: fix dataqueues iteration > > Fix dataqueues iteration using nb_queue_pairs info available in > device data instead of max dataqueues as dataqueue count might > have been changed in device configuration. > > Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD o

[PATCH] app/testpmd: add ipv6 extension header parse

2025-01-07 Thread Jie Hai
This patch support parse ipv6 extension header, and support TSO for ipv6tcp packets with extension header. Signed-off-by: Jie Hai --- app/test-pmd/csumonly.c | 47 - 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/ap

Re: [PATCH v11 0/3] add diagnostics macros to make code portable

2025-01-07 Thread Andre Muezerie
On Mon, Jan 06, 2025 at 11:00:15AM +, Bruce Richardson wrote: > On Fri, Jan 03, 2025 at 01:26:34PM -0800, Andre Muezerie wrote: > > On Fri, Jan 03, 2025 at 11:24:02AM -0800, Stephen Hemminger wrote: > > > On Fri, 3 Jan 2025 07:36:48 -0800 > > > Andre Muezerie wrote: > > > > > > > From: Andre

Re: [PATCH 1/3] net/hns3: fix simple Tx path incorrect free the mbuf

2025-01-07 Thread Jie Hai
On 2024/12/31 1:55, Stephen Hemminger wrote: On Mon, 30 Dec 2024 14:54:03 +0800 Jie Hai wrote: From: Jie Hai To: , , , , , Chengwen Feng , "Wei Hu (Xavier)" , Huisong Li CC: , Subject: [PATCH 1/3] net/hns3: fix simple Tx path incorrect free the mbuf Date: Mon, 30 Dec 2024 14:54:03 +080

[PATCH v2] ring: add the second version of the RTS interface

2025-01-07 Thread Huichao Cai
Hi,Thomas This patch adds a field to the ABI structure.I have added the suppress_type field in the file libabigail.abignore, but "ci/github-robot: Build" still reported an error, could you please advise on how to fill in the suppress_type field?

[PATCH v4] dts: reform hello world test suite

2025-01-07 Thread Dean Marx
Add a test suite to replace hello_world which simply starts and stops a testpmd session. The user can use this as a confidence check to verify their configuration. Signed-off-by: Dean Marx Reviewed-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- dts/tests/TestSuite_hello_world.py | 70 +

[PATCH v3] net/gve: allocate RX QPL pages using malloc

2025-01-07 Thread Joshua Washington
From: Praveen Kaligineedi Allocating QPL for an RX queue might fail if enough contiguous IOVA memory cannot be allocated. This can commonly occur when using 2MB huge pages because the 1024 4K buffers are allocated for each RX ring by default, resulting in 4MB for each ring. However, the only requ

[v2 4/4] test/crypto: test virtio_crypto_user PMD

2025-01-07 Thread Gowrishankar Muthukrishnan
Reuse virtio_crypto tests for testing virtio_crypto_user PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + app/test/test_cryptodev_asym.c | 15 +++ 3 files changed, 23 insertions(+) diff --git a/app

[v2 3/4] crypto/virtio: add vhost backend to virtio_user

2025-01-07 Thread Gowrishankar Muthukrishnan
Add vhost backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virtio/virtio_cryptodev.h | 3 + drivers/crypto/virtio/virtio_pci.h

[v2 2/4] common/virtio: support cryptodev in vdev setup

2025-01-07 Thread Gowrishankar Muthukrishnan
Support cryptodev in vdev setup. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/virtio/virtio_user/vhost_vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/common/virtio/virtio_user/vhost_vdpa.c b/drivers/common/virtio/virtio_user/vhost_vdpa.c ind

[v2 1/4] common/virtio: move vDPA to common directory

2025-01-07 Thread Gowrishankar Muthukrishnan
Move vhost-vdpa backend implementation into common folder. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-149672 ("vhost: include AKCIPHER algorithms in crypto_config") Depends-on: patch-148913 ("crypto/virtio: remove redundant crypto queue free") Depends-on: series-34293 ("crypt

[v2 0/4] crypto/virtio: add vDPA backend support

2025-01-07 Thread Gowrishankar Muthukrishnan
This series add vDPA backend support in virtio crypto PMD. Depends-on: patch-149672 ("vhost: include AKCIPHER algorithms in crypto_config") Depends-on: patch-148913 ("crypto/virtio: remove redundant crypto queue free") Depends-on: series-34293 ("crypto/virtio: add packed ring support") Depends-on:

[v3] vhost: include AKCIPHER algorithms in crypto_config

2025-01-07 Thread Gowrishankar Muthukrishnan
Update virtio_crypto_config structure to include AKCIPHER algorithms, as per VirtIO standard. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- v3: - rebased on main. lib/vhost/virtio_crypto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/virt

[v2 2/2] crypto/virtio: add packed ring support

2025-01-07 Thread Gowrishankar Muthukrishnan
Add packed ring support. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/virtio_cryptodev.c | 125 +++ drivers/crypto/virtio/virtio_cryptodev.h | 13 +- drivers/crypto/virtio/virtio_cvq.c | 103 +- drivers/crypto/virtio/virtio_pci.h | 25 ++ drivers/cryp

[v2 0/2] crypto/virtio: add packed ring support

2025-01-07 Thread Gowrishankar Muthukrishnan
This series adds packed ring support in virtio crypto PMD. Depends-on: series-34291 ("crypto/virtio: add RSA support") v2: - split from v1 series. Gowrishankar Muthukrishnan (2): crypto/virtio: refactor queue operations crypto/virtio: add packed ring support drivers/crypto/virtio/meson.bu

[v2 1/2] crypto/virtio: refactor queue operations

2025-01-07 Thread Gowrishankar Muthukrishnan
Move existing control queue operations into a common place that would be shared with other virtio type of devices. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34291 ("crypto/virtio: add RSA support") drivers/crypto/virtio/meson.build | 1 + drivers/crypto/virtio/

[v2 1/2] vhost: add asymmetric RSA support

2025-01-07 Thread Gowrishankar Muthukrishnan
Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: series-34291 ("crypto/virtio: add RSA support") lib/vhost/vhost_crypto.c | 504 --- lib/vhost/vhost_user.h | 33 ++- 2 files changed, 498 inse

[v2 0/2] vhost: add RSA support

2025-01-07 Thread Gowrishankar Muthukrishnan
This series adds RSA support in vhost_crypto library. v2: - split from v1 series. Depends-on: series-34291 ("crypto/virtio: add RSA support") Gowrishankar Muthukrishnan (2): vhost: add asymmetric RSA support examples/vhost_crypto: add asymmetric support examples/vhost_crypto/main.c | 54

[v2 2/2] examples/vhost_crypto: add asymmetric support

2025-01-07 Thread Gowrishankar Muthukrishnan
Add symmetric support. Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 54 ++-- 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c index 558c09a60f..8bdfc40c4b 10

[v2 0/2] crypto/virtio: add RSA support

2025-01-07 Thread Gowrishankar Muthukrishnan
This series adds RSA support in virtio crypto PMD. v2: - split from v1 series. Gowrishankar Muthukrishnan (2): crypto/virtio: add asymmetric RSA support test/crypto: add asymmetric tests for virtio PMD app/test/test_cryptodev_asym.c| 29 ++ app/test/test_cryptodev_rsa_test

[v2 2/2] test/crypto: add asymmetric tests for virtio PMD

2025-01-07 Thread Gowrishankar Muthukrishnan
Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 29 ++ app/test/test_cryptodev_rsa_test_vectors.h | 4 +++ 2 files changed, 33 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/tes

[v2 1/2] crypto/virtio: add asymmetric RSA support

2025-01-07 Thread Gowrishankar Muthukrishnan
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- .../virtio/virtio_crypto_capabilities.h | 19 + drivers/crypto/virtio/virtio_cryptodev.c | 384 +++--- drivers/crypto/virtio/virtio_rxt

[PATCH] test/crypto: check for RSA capability

2025-01-07 Thread Gowrishankar Muthukrishnan
In RSA crypto tests, check if it is supported by PMD before executing it. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 24 1 file changed, 24 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c ind

[PATCH] crypto/virtio: fix dataqueues iteration

2025-01-07 Thread Gowrishankar Muthukrishnan
Fix dataqueues iteration using nb_queue_pairs info available in device data instead of max dataqueues as dataqueue count might have been changed in device configuration. Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan ---

Re: [PATCH v3] dts: reform hello world test suite

2025-01-07 Thread Patrick Robb
Actually, would you want to use logger to print a "hello world" message. It might make the testsuite name make more sense hah. On Mon, Jan 6, 2025 at 11:57 AM Dean Marx wrote: > Add a test suite to replace hello_world which simply > starts and stops a testpmd session. The user can use > this as

Re: [PATCH] net/memif: Fix memif-rx buffer linking

2025-01-07 Thread Stephen Hemminger
On Mon, 6 Jan 2025 11:43:28 -0800 Mike Bly wrote: > From: Mike Bly > To: dev@dpdk.org > Cc: sta...@dpdk.org, jgraj...@cisco.com > Subject: [PATCH] net/memif: Fix memif-rx buffer linking > Date: Mon, 6 Jan 2025 11:43:28 -0800 > > Moving where dst_off is set in memif-rx function > Bugzilla ID: 16

Re: [PATCH v3] dts: reform hello world test suite

2025-01-07 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH] dts: fix MTU set command

2025-01-07 Thread Nicholas Pratte
Thanks Luca! Reviewed-by: Nicholas Pratte On Tue, Jan 7, 2025 at 9:13 AM Luca Vizzarro wrote: > > There are some PMDs that in order to set a scatter-offload-compatible > MTU size, they need to have started at least once since the startup of > testpmd. This fixes the behaviour of the command to

Re: [PATCH] dts: fix MTU set command

2025-01-07 Thread Patrick Robb
Reviewed-by: Patrick Robb

RE: [EXTERNAL] [PATCH v22 13/13] compress/zsda: add zsda compressdev capabilities

2025-01-07 Thread Akhil Goyal
> Add zsda compressdev capabilities. > > Signed-off-by: Hanxiao Li > --- > doc/guides/compressdevs/features/zsda.ini | 9 + > doc/guides/compressdevs/zsda.rst | 23 +++ > doc/guides/rel_notes/release_24_11.rst| 7 +++ > drivers/compress/zsda/zsda_co

RE: [EXTERNAL] [PATCH v22 10/13] compress/zsda: add zsda compressdev qp ops

2025-01-07 Thread Akhil Goyal
> diff --git a/drivers/common/zsda/zsda_device.c > b/drivers/common/zsda/zsda_device.c > index 5c835651ea..5297c80ef9 100644 > --- a/drivers/common/zsda/zsda_device.c > +++ b/drivers/common/zsda/zsda_device.c > @@ -11,7 +11,6 @@ > #include "zsda_device.h" > #include "zsda_logs.h" > #include "zsd

Re: [PATCH v8 01/29] devtools: check packed attributes

2025-01-07 Thread David Marchand
Hello Andre, On Tue, Dec 31, 2024 at 7:39 PM Andre Muezerie wrote: > > Ensure __rte_packed_begin and __rte_packed_end show up in pairs > when checking patches. > > Signed-off-by: Andre Muezerie > Acked-by: Tyler Retzlaff > --- > devtools/checkpatches.sh | 43 +++

[PATCH] dts: fix MTU set command

2025-01-07 Thread Luca Vizzarro
There are some PMDs that in order to set a scatter-offload-compatible MTU size, they need to have started at least once since the startup of testpmd. This fixes the behaviour of the command to start and stop the ports before changing the MTU to ensure this happened Fixes: 9910db35962b ("dts: add M

RE: [EXTERNAL] [PATCH v22 07/13] compress/zsda: add zsda compressdev dev ops

2025-01-07 Thread Akhil Goyal
> add zsda compressdev dev interface implementation. > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build | 1 + > drivers/common/zsda/zsda_qp_common.c | 57 ++ > drivers/common/zsda/zsda_qp_common.h | 36 +++ > drivers/compress/zsda/zsda_comp_pmd.c | 144

RE: [EXTERNAL] [PATCH v22 06/13] compress/zsda: add zsda compressdev driver skeleton

2025-01-07 Thread Akhil Goyal
Hi Hanxiao, Please see comments inline. > Add zsda compressdev driver interface skeleton > > Signed-off-by: Hanxiao Li > --- > MAINTAINERS | 3 + > doc/guides/compressdevs/features/zsda.ini | 6 + > doc/guides/compressdevs/index.rst | 1 + > doc/guid

Re: Feature arc slides

2025-01-07 Thread Nitin Saxena
Hi Stephen, On Mon, Jan 6, 2025 at 5:45 AM Stephen Hemminger wrote: > > On Fri, 3 Jan 2025 20:29:15 +0530 > Nitin Saxena wrote: > > > Sending to DPDK community again > > > > Thanks, > > Nitin > > Why not convert the slides into useful long term documentation in > the doc/guides directory. I wi

RE: [EXTERNAL] Re: [v1 12/16] common/virtio: common virtio log

2025-01-07 Thread Gowrishankar Muthukrishnan
Hi David, > Hello Gowri, > > On Tue, Dec 24, 2024 at 8:39 AM Gowrishankar Muthukrishnan > wrote: > > > > Common virtio log include file. > > That's really a short commitlog.. > What are you trying to achieve? As part of sharing vDPA backend ops implementation between net and crypto (in patch

RE: [EXTERNAL] Re: [PATCH v16 0/4] add support for self monitoring

2025-01-07 Thread Tomasz Duszynski
>> This series adds self monitoring support i.e allows to configure and >> read performance measurement unit (PMU) counters in runtime without >> using perf utility. This has certain advantages when application runs >> on isolated cores running dedicated tasks. >> >> Events can be read directly usi

Re: [PATCH v2] service: add service maintenance callback

2025-01-07 Thread Mattias Rönnblom
On 2024-12-31 11:02, Piotr Krzewinski wrote: Add option to register a callback running on service lcores along regular services, which gets information about the service loop. It enables doing maintenance work or power saving during periods when all registered services are idling. As an example

Subject: [PATCH] net/memif: Fix memif-tx buffer flags handling

2025-01-07 Thread Mike Bly
Added missing initialization of memif flags field per memif buffer Bugzilla ID: 1609 Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: sta...@dpdk.org Cc: Jakub Grajciar Signed-off-by: Mike Bly --- drivers/net/memif/rte_eth_memif.c | 2 ++ 1 file changed, 2 insertions(+) di

[PATCH] net/memif: Fix memif-rx buffer linking

2025-01-07 Thread Mike Bly
Moving where dst_off is set in memif-rx function Bugzilla ID: 1609 Fixes: aa17df860891 ("net/memif: add a Rx fast path") Cc: sta...@dpdk.org Cc: Jakub Grajciar Signed-off-by: Mike Bly --- drivers/net/memif/rte_eth_memif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dri

RE: [EXTERNAL] Re: [PATCH v16 1/4] lib: add generic support for reading PMU events

2025-01-07 Thread Tomasz Duszynski
>> +Performance counter based profiling >> +--- >> + >> +Majority of architectures support some performance monitoring unit >(PMU). >> +Such unit provides programmable counters that monitor specific events. > >Sentence wording is awkward, maybe combine the two senten