On 2024/12/31 1:55, Stephen Hemminger wrote:
On Mon, 30 Dec 2024 14:54:03 +0800 Jie Hai <haij...@huawei.com> wrote:From: Jie Hai <haij...@huawei.com> To: <dev@dpdk.org>, <tho...@monjalon.net>, <ferruh.yi...@amd.com>, <david.march...@redhat.com>, <andrew.rybche...@oktetlabs.ru>, Chengwen Feng <fengcheng...@huawei.com>, "Wei Hu (Xavier)" <xavier.hu...@huawei.com>, Huisong Li <lihuis...@huawei.com> CC: <haij...@huawei.com>, <huangdeng...@huawei.com> Subject: [PATCH 1/3] net/hns3: fix simple Tx path incorrect free the mbuf Date: Mon, 30 Dec 2024 14:54:03 +0800 X-Mailer: git-send-email 2.22.0 From: Dengdui Huang <huangdeng...@huawei.com> When RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload is not set, use rte_pktmbuf_free_seg() to free the mbuf. Fixes: 7ef933908f04 ("net/hns3: add simple Tx path") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang <huangdeng...@huawei.com> Signed-off-by: Jie Hai <haij...@huawei.com>What about the fast free case which is using rte_mempool_put_bulk when it should use rte_pktmbuf_free_bulk instead?
Hi, Stephen Hemminger, During the fast free case, the performance of using rte_mempool_put_bulk is higher than that of using rte_pktmbuf_free_bulk because other references to mbuf do not need to be considered. So it's better to not change. Thanks, Jie Hai
