RE: [PATCH] net/virtio: fix Rx checksum calculation

2024-12-17 Thread Wangyunjian(wangyunjian,TongTu)
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, December 17, 2024 11:33 PM > To: dev@dpdk.org > Cc: Olivier Matz ; Maxime Gouin > ; Maxime Coquelin > > Subject: [PATCH] net/virtio: fix Rx checksum calculation > > From: Olivier Matz > > I

[PATCH] net/nfp: fix VF link speed problem

2024-12-17 Thread Chaoyong He
From: Long Wu The previous logic does not update the 'rte_eth_device' link status when the port link status changed, which cause the firmware won't be notified by the PMD. Furthermore, the physical representor port should also notify firmware its current speed with multi-pf firmware. Fix these p

[PATCH] net/nfp: implement the burst mode get operation

2024-12-17 Thread Chaoyong He
Implement the burst mode get operation functions for both Rx and Tx. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c| 2 ++ drivers/net/nfp/nfp_ethdev_vf.c | 2 ++ drivers/net/nfp/nfp_rxtx.c | 46 + drivers/net/nfp/n

[PATCH] net/nfp: unify the queue threshold value

2024-12-17 Thread Chaoyong He
Make sure the Rx queue threshold value query by API 'rte_eth_rx_queue_info_get()' and 'rte_eth_dev_info_get()' unify. Same for the Tx queue threshold value. Signed-off-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

Re: [PATCH v12] dts: port over queue start/stop suite

2024-12-17 Thread Stephen Hemminger
On Tue, 17 Dec 2024 18:08:37 -0500 Dean Marx wrote: > This suite tests the ability of the Poll Mode Driver > to enable and disable Rx/Tx queues on a port. > > Signed-off-by: Dean Marx > Reviewed-by: Jeremy Spewock > --- > dts/tests/TestSuite_queue_start_stop.py | 89 +

RE: 21.11.9 patches review and test

2024-12-17 Thread Xu, HailinX
> -Original Message- > From: Kevin Traynor > Sent: Wednesday, December 18, 2024 1:48 AM > To: Xu, HailinX ; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ; Ju-Hyoung Lee > ; Luca

[PATCH v12] dts: port over queue start/stop suite

2024-12-17 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/tests/TestSuite_queue_start_stop.py | 89 + 1 file changed, 89 insertions(+) create mode 100644 dts/tests/Test

[DPDK/core Bug 1605] lib/eal build failure with address and undefined behavior sanitizers

2024-12-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1605 Bug ID: 1605 Summary: lib/eal build failure with address and undefined behavior sanitizers Product: DPDK Version: 25.03 Hardware: All OS: All Status: UN

Re: [PATCH 2/2] dts: clear out Python syntax warnings

2024-12-17 Thread Patrick Robb
Reviewed-by: Patrick Robb A question for main branch maintainers - should this series go directly to the main branch? I don't think I should apply this to next-dts due to the 1/2 patch. On Sat, Dec 14, 2024 at 5:43 AM Ariel Otilibili wrote: > * follow up of a discussion with Robin Jarry > * sin

Re: 21.11.9 patches review and test

2024-12-17 Thread Kevin Traynor
On 17/12/2024 11:30, Kevin Traynor wrote: > On 17/12/2024 10:01, Xu, HailinX wrote: >>> -Original Message- >>> From: Kevin Traynor >>> Sent: Wednesday, December 4, 2024 11:59 PM >>> To: sta...@dpdk.org >>> Cc: dev@dpdk.org; Abhishek Marathe ; >>> Ali Alnubani ; David Christensen >>> ; Hema

[PATCH] net/virtio: fix Rx checksum calculation

2024-12-17 Thread Maxime Coquelin
From: Olivier Matz If hdr->csum_start is larger than packet length, the len argument passed to rte_raw_cksum_mbuf() overflows and causes a segmentation fault. Ignore checksum computation in this case. CVE-2024-11614 Fixes: ca7036b4af3a ("vhost: fix offload flags in Rx path") Signed-off-by: Ma

CVE-2024-11614: DPDK Vhost Rx checksum vulnerability

2024-12-17 Thread Maxime Coquelin
A vulnerability was fixed in DPDK. Some downstream stakeholders were warned in advance through security-prerele...@dpdk.org in order to coordinate the release of fixes and reduce the vulnerability window [0]. A malicious guest using a virtio driver can cause the vhost-user side to crash by sendi

DPDK 22.11.7 released

2024-12-17 Thread luca . boccassi
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-22.11.7.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=22.11 This release includes the fix for CVE-2024-11614. Luca Boccassi --- .mailmap | 10 +-

DPDK 23.11.3 released

2024-12-17 Thread Xueming Li
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-23.11.3.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=23.11 This release contains v23.11.3 plus a fix for CVE-2024-11614. Xueming Li --- .mailmap

DPDK 21.11.9 released

2024-12-17 Thread Kevin Traynor
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-21.11.9.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=21.11 It contains ~130 fixes since v21.11.8 including a fix for CVE-2024-11614. This is the last planned 21.11 LTS release. From this po

DPDK 24.11.1 released

2024-12-17 Thread Kevin Traynor
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-24.11.1.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=24.11 This release contains v24.11 plus a fix for CVE-2024-11614. Kevin --- VERSION| 2 +- doc/guides

Re: 21.11.9 patches review and test

2024-12-17 Thread Kevin Traynor
On 16/12/2024 18:14, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, December 4, 2024 5:59 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; Ali >> Alnubani ; David Christensen ; >> Hemant Agrawal ; Ian Stokes >> ; Jerin Jacob ; John McN

[PATCH v3 13/15] net/zxdh: rss hash config/update, reta update/get

2024-12-17 Thread Junlong Wang
provided rss hash config/update, reta update/get ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 3 + doc/guides/nics/zxdh.rst | 1 + drivers/net/zxdh/zxdh_ethdev.c | 51 drivers/net/zxdh/zxdh_ethdev.h | 4 +- drivers/net/zxdh/zxdh_ethdev_o

[PATCH v3 10/15] net/zxdh: mac set/add/remove ops implementations

2024-12-17 Thread Junlong Wang
provided mac set/add/remove ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + doc/guides/nics/zxdh.rst | 2 + drivers/net/zxdh/zxdh_common.c | 24 +++ drivers/net/zxdh/zxdh_common.h | 1 + drivers/net/zxdh/zxdh_ethdev.c | 32 +++- driver

[PATCH v3 15/15] net/zxdh: mtu update ops implementations

2024-12-17 Thread Junlong Wang
mtu update ops implementations. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 1 + doc/guides/nics/zxdh.rst | 2 + drivers/net/zxdh/zxdh_ethdev.c | 5 ++ drivers/net/zxdh/zxdh_ethdev_ops.c | 78 ++ drivers/net/zxdh/zxdh_ethdev_o

[PATCH v3 12/15] net/zxdh: vlan filter/ offload ops implementations

2024-12-17 Thread Junlong Wang
provided vlan filter, vlan offload ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 3 + doc/guides/nics/zxdh.rst | 3 + drivers/net/zxdh/zxdh_ethdev.c | 40 +- drivers/net/zxdh/zxdh_ethdev_ops.c | 223 + drivers/net/zxd

[PATCH v3 11/15] net/zxdh: promisc/allmulti ops implementations

2024-12-17 Thread Junlong Wang
provided promiscuous/allmulticast ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + doc/guides/nics/zxdh.rst | 2 + drivers/net/zxdh/zxdh_ethdev.c | 21 ++- drivers/net/zxdh/zxdh_ethdev.h | 2 + drivers/net/zxdh/zxdh_ethdev_ops.c | 132 ++

[PATCH v3 08/15] net/zxdh: provided dev simple rx implementations

2024-12-17 Thread Junlong Wang
provided dev simple rx implementations. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 1 + doc/guides/nics/zxdh.rst | 1 + drivers/net/zxdh/zxdh_ethdev.c| 2 + drivers/net/zxdh/zxdh_rxtx.c | 313 ++ drivers/net/zxdh/zxdh_r

[PATCH v3 07/15] net/zxdh: provided dev simple tx implementations

2024-12-17 Thread Junlong Wang
provided dev simple tx implementations. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 20 ++ drivers/net/zxdh/zxdh_queue.h | 26 ++- drivers/net/zxdh/zxdh_rxtx.c | 396 + drivers/net/zxdh/zxdh_rxtx.h

[PATCH v3 06/15] net/zxdh: dev start/stop ops implementations

2024-12-17 Thread Junlong Wang
dev start/stop implementations, start/stop the rx/tx queues. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + doc/guides/nics/zxdh.rst | 2 + drivers/net/zxdh/zxdh_ethdev.c| 61 + drivers/net/zxdh/zxdh_pci.c | 24 drivers/

[PATCH v3 09/15] net/zxdh: link info update, set link up/down

2024-12-17 Thread Junlong Wang
provided link info update, set link up /down, and link intr. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + doc/guides/nics/zxdh.rst | 3 + drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 14 ++- drivers/net/zxdh/zxdh_eth

[PATCH v3 02/15] net/zxdh: zxdh np uninit implementation

2024-12-17 Thread Junlong Wang
(np)network processor release resources in host. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 48 drivers/net/zxdh/zxdh_np.c | 470 + drivers/net/zxdh/zxdh_np.h | 107 3 files changed, 625 insertions(+) diff --git a/driv

[PATCH v3 04/15] net/zxdh: port tables unint implementations

2024-12-17 Thread Junlong Wang
delete port tables in host. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 18 ++ drivers/net/zxdh/zxdh_msg.h| 1 + drivers/net/zxdh/zxdh_np.c | 103 + drivers/net/zxdh/zxdh_np.h | 9 +++ drivers/net/zxdh/zxdh_tables.c | 33

[PATCH v3 05/15] net/zxdh: rx/tx queue setup and intr enable

2024-12-17 Thread Junlong Wang
rx/tx queue setup and intr enable implementations. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 4 + drivers/net/zxdh/zxdh_queue.c | 149 + drivers/net/zxdh/zxdh_queue.h | 33 3 files changed, 186 insertions(+) diff --git a/drive

[PATCH v3 00/15] net/zxdh: updated net zxdh driver

2024-12-17 Thread Junlong Wang
V3: - use rte_zmalloc and rte_calloc to avoid memset. - remove unnecessary initialization, which first usage will set. - adjust some function which is always return 0, changed to void and skip the ASSERTION later. - resolved some WARNING:MACRO_ARG_UNUSED issues. - resolved some other

Re: 21.11.9 patches review and test

2024-12-17 Thread Kevin Traynor
On 17/12/2024 10:01, Xu, HailinX wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, December 4, 2024 11:59 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Ali Alnubani ; David Christensen >> ; Hemant Agrawal ; >> Stokes, Ian ; Jerin Jacob ; >> Mcna

RE: [PATCH v2 7/7] dts: update linters in doc page

2024-12-17 Thread Xu, HailinX
Hi Luca, There is no error with this series. The error is caused by the CI doesn't apply any changes with doc/*. In history, Community decided to exclude doc/*, as doc/* change frequently, especially the release notes, cause a lot of conflict with main tree. We manually merged this patch and suc

RE: 21.11.9 patches review and test

2024-12-17 Thread Xu, HailinX
> -Original Message- > From: Kevin Traynor > Sent: Wednesday, December 4, 2024 11:59 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ; Ju-Hyoung Lee > ; Kevin Traynor ; Lu

Re: [PATCH 0/3] Defer lcore variables allocation

2024-12-17 Thread David Marchand
On Mon, Dec 16, 2024 at 10:49 AM David Marchand wrote: > > > For now, this series only focus on fixing subsystems using lcore > > > variables so that those allocations are deferred either in rte_eal_init() > > > or in the path that does require such lcore variables. > > > > > > > > > > An idle que

Re: [PATCH v6] graph: mcore: optimize graph search

2024-12-17 Thread David Marchand
On Mon, Dec 16, 2024 at 3:49 PM David Marchand wrote: > $ abidiff --suppr > /home/dmarchan/git/pub/dpdk.org/main/devtools/libabigail.abignore > --no-added-syms --headers-dir1 > /home/dmarchan/abi/v24.11/build-gcc-shared/usr/local/include > --headers-dir2 > /home/dmarchan/builds/main/build-gcc-sha

[PATCH v2 5/5] eal/x86: defer power intrinsics variable allocation

2024-12-17 Thread David Marchand
The lcore variable in this code unit is only used through rte_power_monitor*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 18b5049ab4fe ("eal/x86: keep power intrinsics state in lcore variable") Cc: sta...@dpdk.org Signed-off-by: David Marchand ---

[PATCH v2 4/5] power: reduce memory footprint of per-lcore state

2024-12-17 Thread David Marchand
Now that the per-lcore state was moved into a lcore variable, there is no reason to align a per-lcore state on a cache line to avoid false sharing. Remove this alignment and save a few bytes. Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") Signed-off-by: David Marchand ---

[PATCH v2 2/5] random: defer seeding to EAL init

2024-12-17 Thread David Marchand
The RNG is documented as being seeded as part of EAL init. Move the initialisation (seeding) helper out of a constructor and call it explicitly from rte_eal_init() as it was done before commit 3f002f069612 ("eal: replace libc-based random generation with LFSR"). This also moves the unconditional

[PATCH v2 3/5] power: defer lcore variable allocation

2024-12-17 Thread David Marchand
The lcore variable in this code unit is only used through rte_power_ethdev_pmgmt_queue_*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") Cc: sta...@dpdk.org Signed-off-by: David Marchand

[PATCH v2 1/5] eal: check lcore variable handle

2024-12-17 Thread David Marchand
Add an assert to double check the passed handle is not NULL, as it points at an initialisation/allocation issue prior to accessing this lcore variable. Signed-off-by: David Marchand --- lib/eal/include/rte_lcore_var.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/include/rte_lcor

[PATCH v2 0/5] Defer lcore variables allocation

2024-12-17 Thread David Marchand
As I had reported in rc2, the lcore variables allocation have a noticeable impact on applications consuming DPDK, even when such applications does not use DPDK, or use features associated to some lcore variables. While the amount has been reduced in a rush before rc2, there are still cases when th

[DPDK/other Bug 1604] Issues with packet capture counting in dpdk-dumpcap

2024-12-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1604 Bug ID: 1604 Summary: Issues with packet capture counting in dpdk-dumpcap Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: 23.11.3 patches review and test

2024-12-17 Thread Xueming Li
Hi Hailin, Thanks very much for the verification. Regarding the known issue, I'll try to handle it in next release. Thanks, Xueming From: Xu, HailinX Sent: Tuesday, December 17, 2024 3:54 PM To: Xueming Li ; sta...@dpdk.org Cc: dev@dpdk.org ; Abhishek Marathe

Re: GCP cloud : Virtio-PMD performance Issue

2024-12-17 Thread Mukul Sinha
Thanks Maxime, We will analyse further and try pinpointing the regression commit between DPDK-21.11 & DPDK-21.08. Will get back with further queries once we have an update. On Fri, Dec 13, 2024 at 4:17 PM Maxime Coquelin wrote: > (with DPDK ML that got removed) > > On 12/13/24 11:46, Maxime Coqu

rte_hash socket memory usage is not balance issue

2024-12-17 Thread Jiang Aengus
steps: 1.master thread create rte_hash for every socket with same size. each socket hash with the each socket_id pass by rte_hash_param.socket_id 2.use numasta -p `pidof your_app` like below: [cid:a0ba8efb-58a9-4cca-b773-724878024a3e] review the sourcec code dpdk23.11 found that: it will allocate

[PING] buildtools: clear out regex syntax warnings

2024-12-17 Thread Ariel Otilibili-Anieli
Hello, Any news on the patch? If anything is needed for its review, I am available. Regards, On Sunday, December 08, 2024 03:25 CET, Ariel Otilibili wrote: > Hello, > > This is my first patch to the list; your feedback is much appreciated. > > My aim is to understand the internals of DPDK.