[DPDK/meson Bug 1589] meson_tests/driver link_bonding_autotest test failed

2024-11-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1589 Bug ID: 1589 Summary: meson_tests/driver link_bonding_autotest test failed Product: DPDK Version: 24.11 Hardware: x86 OS: All Status: UNCONFIRMED Severity: normal

[PATCH] eal: fix bus cleanup in secondary process

2024-11-27 Thread myang
eal_bus_cleanup has been added in rte_eal_cleanup. But for secondary process, eal_bus_cleanup will trigger vdev_cleanup which trigger rte_vdev_driver to remove. Then our crypto devices will execute ipsec_mb_remove to rte_cryptodev_pmd_destroy. Finally error logs occur as below: CRYPTODEV: rte_cryp

RE: [EXTERNAL] Re: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-27 Thread Gowrishankar Muthukrishnan
Hi Jason, > Hello: > > On Fri, Nov 22, 2024 at 2:03 AM Gowrishankar Muthukrishnan > wrote: > > > > Hi, > > We are adding support for vDPA user backend for virtio-crypto PMD in DPDK. > > I wonder what kind of vDPA device you are using? Is there a marvell specific > vDPA or just a standard virtio-

[PATCH 2/2] lib/hash: avoid implicit conversion to 64 bit number

2024-11-27 Thread Andre Muezerie
MSVC issues the warnings below: 1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) The code would be better off by using 64 bit numbers to begin with. That eliminates the need for a conver

[PATCH 1/2] lib/cryptodev: avoid implicit conversion to 64 bit number

2024-11-27 Thread Andre Muezerie
MSVC issues the warning below: ../lib/cryptodev/rte_cryptodev.c(623): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) The code would be better off by using 64 bit numbers to begin with. That eliminates the need for a conversion to 6

[PATCH 2/2] app/test: add test_init_m128i using compiler intrinsic

2024-11-27 Thread Andre Muezerie
This test initializes an __m128i data type using the old non-portable way used until now and the more portable way using compiler intrinsics. The test ensures the resulting values after initialization match. Signed-off-by: Andre Muezerie --- app/test/test_thash.c | 37 +++

[PATCH 1/2] lib/hash: initialize __m128i data type in a portable way

2024-11-27 Thread Andre Muezerie
The mechanism used to initialize an __m128i data type in rte_thash.h is non-portable and MSVC does not like it. It clearly is not doing what is desired: ..\lib\hash\rte_thash.h(38): warning C4305: 'initializing': truncation from 'unsigned __int64' to 'char' ..\lib\hash\rte_thash.h(38): warning

[PATCH 2/2] app/test: add test_init_m128i using compiler intrinsic

2024-11-27 Thread Andre Muezerie
This test initializes an __m128i data type using the old non-portable way used until now and the more portable way using compiler intrinsics. The test ensures the resulting values after initialization match. Signed-off-by: Andre Muezerie --- app/test/test_thash.c | 37 +++

[PATCH 1/2] lib/hash: initialize __m128i data type in a portable way

2024-11-27 Thread Andre Muezerie
The mechanism used to initialize an __m128i data type in rte_thash.h is non-portable and MSVC does not like it. It clearly is not doing what is desired: ..\lib\hash\rte_thash.h(38): warning C4305: 'initializing': truncation from 'unsigned __int64' to 'char' ..\lib\hash\rte_thash.h(38): warning

[PATCH v2] lib/eal: fix macros for noinline and alwaysinline for MSVC

2024-11-27 Thread Andre Muezerie
MSVC supports forcing code to be inlined or forcing code to not be inlined, like other compilers. This patch fixes existing macros __rte_noinline and __rte_always_inline so that they also do what is expected from them when used with MSVC. Signed-off-by: Andre Muezerie --- lib/eal/include/rte_co

Re: [PATCH v1 1/1] net/ixgbe: fix missing VF PCI ID

2024-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2024 at 04:16:17PM +, Anatoly Burakov wrote: > PCI ID's for E610 devices were added, but the ID's that were added were > only for physical functions, not VF's. Add missing PCI ID for E610 VF. > > Fixes: 5662e97457eb ("net/ixgbe: add PCI IDs for new E610 variants") > > Signed-o

Re: [PATCH v5 6/8] build: reduce driver dependencies

2024-11-27 Thread Burakov, Anatoly
On 11/27/2024 3:56 PM, Anatoly Burakov wrote: From: Bruce Richardson Remove any unnecessary dependencies from the driver dependency lists. This will give each driver a near-minimum set of required dependencies. Signed-off-by: Bruce Richardson Reviewed-by: Rosen Xu --- diff --git a/driver

[PATCH v1 1/1] net/ixgbe: fix missing VF PCI ID

2024-11-27 Thread Anatoly Burakov
PCI ID's for E610 devices were added, but the ID's that were added were only for physical functions, not VF's. Add missing PCI ID for E610 VF. Fixes: 5662e97457eb ("net/ixgbe: add PCI IDs for new E610 variants") Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file c

[PATCH] lib/eal: fix macros for noinline and alwaysinline for MSVC

2024-11-27 Thread Andre Muezerie
From: Andre Muezerie MSVC supports forcing code to be inlined or forcing code to not be inlined, like other compilers. This patch fixes existing macros __rte_noinline and __rte_always_inline so that they also do what is expected from them when used with MSVC. Signed-off-by: Andre Muezerie ---

[PATCH v1 1/1] usertools/devbind: fix missing active marker

2024-11-27 Thread Anatoly Burakov
When adding NUMA node printouts, the "*Active*" marker was accidentally omitted. Add it back in. Fixes: a7d69cef8f20 ("usertools/devbind: print device NUMA node") Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 1 + 1 file changed, 1 insertion(+) diff --git a/usertools/dpdk-devb

Re: [PATCH] examples/ptpclient: revert add frequency adjustment

2024-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2024 at 07:27:21AM +, Mingjin Ye wrote: > This commit references GPL-licensed code and therefore cannot be applied > to the DPDK. > > Therefore the following commit was reverted accordingly. > > Fixes: 6d55af611fd5 ("examples/ptpclient: add frequency adjustment") > > By resum

[PATCH] test/crypto: return proper codes in create session

2024-11-27 Thread Rajesh Mudimadugula
Return proper error codes in create_auth_session() to avoid segfaults as a result of this. Signed-off-by: Rajesh Mudimadugula --- app/test/test_cryptodev.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/app/test/test_cryptodev.c b/app

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

2024-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2024 at 03:16:01AM +, Lingli Chen wrote: > Add tested Intel platforms with Intel NICs to v24.11 release note. > > Signed-off-by: Lingli Chen > --- > doc/guides/rel_notes/release_24_11.rst | 165 + > 1 file changed, 165 insertions(+) > Applied to dpdk-

[PATCH v3 0/1] Add DPDK build directory configuration script

2024-11-27 Thread Anatoly Burakov
Note: this patch depends upon Bruce's v5 patchset: https://patches.dpdk.org/project/dpdk/list/?series=34055 This patch is based on initial script for VSCode configuration: https://patches.dpdk.org/project/dpdk/patch/6a6b20c037cffcc5f68a341c4b4e4f21990ae991.1721997016.git.anatoly.bura...@intel.co

[PATCH v3 1/1] devtools: add DPDK build directory setup script

2024-11-27 Thread Anatoly Burakov
Currently, the only way to set up a build directory for DPDK development is through running Meson directly. This has a number of drawbacks. For one, the default configuration is very "fat", meaning everything gets enabled and built (aside from examples, which have to be enabled manually), so while

[PATCH v5 6/8] build: reduce driver dependencies

2024-11-27 Thread Anatoly Burakov
From: Bruce Richardson Remove any unnecessary dependencies from the driver dependency lists. This will give each driver a near-minimum set of required dependencies. Signed-off-by: Bruce Richardson Reviewed-by: Rosen Xu --- drivers/baseband/fpga_5gnr_fec/meson.build | 2 +- drivers/baseband/fp

[PATCH v5 8/8] devtools: add script to generate DPDK dependency graphs

2024-11-27 Thread Anatoly Burakov
From: Bruce Richardson Rather than the single monolithic graph that would be output from the deps.dot file in a build directory, we can post-process that to generate simpler graphs for different tasks. This new "draw_dependency_graphs" script takes the "deps.dot" as input and generates an output

[PATCH v5 7/8] build: reduce app dependencies

2024-11-27 Thread Anatoly Burakov
From: Bruce Richardson Remove any unnecessary dependencies from the app dependency lists. This will give each app a near-minimum set of required dependencies. Signed-off-by: Bruce Richardson --- app/dumpcap/meson.build | 2 +- app/graph/meson.build| 2 +- app/pdump/meson.b

[PATCH v5 5/8] build: reduce library dependencies

2024-11-27 Thread Anatoly Burakov
From: Bruce Richardson Rather than having each library depend up on EAL + any extra libs, we can take advantage of recursive dependency support in meson and just assign the dependencies of each directory directly, rather than appending to the array. For libraries which only depend upon EAL, keep

[PATCH v5 4/8] build: remove kvargs from driver class dependencies

2024-11-27 Thread Anatoly Burakov
From: Bruce Richardson The kvargs library is used by EAL, and therefore is implicitly a dependency of every DPDK driver. Remove it from the minimum set of dependencies for each driver class as it's unnecessary to call it out there. Signed-off-by: Bruce Richardson --- drivers/event/meson.build

[PATCH v5 2/8] build: output a dependency log in build directory

2024-11-27 Thread Anatoly Burakov
From: Bruce Richardson As meson processes our DPDK source tree it manages dependencies specified by each individual driver. To enable future analysis of the dependency links between components, log the dependencies of each DPDK component as it gets processed. This could potentially allow other to

[PATCH v5 3/8] devtools: add script to flag unneeded dependencies

2024-11-27 Thread Anatoly Burakov
From: Bruce Richardson While not a serious problem, DPDK components often list more dependencies than are actually necessary to build, due to the use of recursive dependencies. In extreme cases, such as with core libraries, this can lead to longer configuration times due to meson having to dedupl

[PATCH v5 1/8] build: introduce optional internal dependencies

2024-11-27 Thread Anatoly Burakov
Allow specifying internal dependencies as either mandatory or optional. Specifying a dependency as optional will mean that the component being built will not be skipped if said dependency is not being built. At build time, the build system will resolve any optional dependencies and add them to the

[PATCH v5 0/8] Record and rework component dependencies

2024-11-27 Thread Anatoly Burakov
As part of the meson build, we can record the dependencies for each component as we process it, logging them to a file. This file can be used as input to a number of other scripts and tools, for example, to graph the dependencies, or to allow higher-level build-config tools to automatically enable

[PATCH v2] crypto/virtio: remove redundant crypto queue free

2024-11-27 Thread Rajesh Mudimadugula
Remove multiple invocations of virtio_crypto_queue_release, and set virtio crypto queue as null upon free to avoid segfaults. Signed-off-by: Rajesh Mudimadugula --- .mailmap | 1 + drivers/crypto/virtio/virtio_cryptodev.c | 11 +-- 2 files changed, 6 inse

RE: [EXTERNAL] [RFC 3/6] eventdev: do not include driver header in DMA adapter

2024-11-27 Thread Amit Prakash Shukla
> Subject: [EXTERNAL] [RFC 3/6] eventdev: do not include driver header in DMA > adapter > > The dma adapter header does not require including rte_dmadev_pmd. h > which is a driver header. Fixes: 66a30a29387a ("eventdev/dma: introduce > DMA adapter") Signed-off-by: David Marchand > --- lib/eventde

[PATCH] crypto/virtio: remove redundant crypto queue free

2024-11-27 Thread Rajesh Mudimadugula
Remove multiple invocations of virtio_crypto_queue_release, and set virtio crypto queue as null upon free to avoid segfaults. Signed-off-by: Rajesh Mudimadugula Reviewed-on: https://sj1git1.cavium.com/c/IP/SW/dataplane/dpdk/+/138957 Base-Builds: sa_ip-toolkits-Jenkins Tested-by: sa_ip-toolkits-J

Re: [PATCH v2] docs: remove html dir from nested docs

2024-11-27 Thread Thomas Monjalon
27/11/2024 12:41, Paul Szczepanek: > +# don't append html dir if dst is already nested in one but first > +# remove the part of the path outside the tree in case html dir exists > there > +rel_path = os.path.relpath(dst, os.path.dirname(__file__)) > +html_dst = dst if 'html' in rel

[PATCH v2] docs: remove html dir from nested docs

2024-11-27 Thread Paul Szczepanek
To facilitate deploying docs to the website and make paths more consistent remove the html directory from nested docs. Signed-off-by: Paul Szczepanek Reviewed-by: Luca Vizzarro --- buildtools/call-sphinx-build.py | 7 +-- doc/api/meson.build | 2 +- 2 files changed, 6 insertions

[RFC 2/6] drivers: drop export of driver headers

2024-11-27 Thread David Marchand
Many classes are exposing driver only headers as public headers. Move them to the driver_sdk_headers list. Signed-off-by: David Marchand --- lib/bbdev/meson.build| 5 ++--- lib/ethdev/meson.build | 6 +++--- lib/mldev/meson.build| 5 + lib/rawdev/meson.build | 3 ++- lib/regexdev

Re: [PATCH v2] doc: add mlx5 xstats send scheduling counters description

2024-11-27 Thread Thomas Monjalon
27/11/2024 01:36, Stephen Hemminger: > On Thu, 31 Oct 2024 10:04:38 +0200 > Viacheslav Ovsiienko wrote: > > > The mlx5 provides the scheduling send on time capability. > > To check the operating status of this feature the extended statistics > > counters are provided. This patch adds the counter

Re: [RFC 5/6] build: install indirect headers to a dedicated directory

2024-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2024 at 12:26:15PM +0100, David Marchand wrote: > The headers check currently skips "indirect" headers as instrusted via > the indirect_headers meson variable. > > This headers check has some limitation that will be addressed in a next > change by inspected all exported headers. >

[PATCH v2] net/sxe: submit the build directory and rough doc documentation

2024-11-27 Thread Jie Liu
Modify sxe pf document. Signed-off-by: Jie Liu --- doc/guides/nics/features/sxe.ini | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/sxe.ini b/doc/guides/nics/features/sxe.ini index 209825a1fc..173ab48889 100644 --- a/doc/guides/nics/features/sxe

[RFC 6/6] buildtools: externally check exported headers

2024-11-27 Thread David Marchand
At the moment, the headers check (triggered via the check_includes meson option) is run "internally", iow with compilation flags and include path coming from the meson components. One issue is that both internal and public headers are usually stored in a single directory in the DPDK components. If

[RFC 5/6] build: install indirect headers to a dedicated directory

2024-11-27 Thread David Marchand
The headers check currently skips "indirect" headers as instrusted via the indirect_headers meson variable. This headers check has some limitation that will be addressed in a next change by inspected all exported headers. However, exported headers lack the information about "indirect" quality. Se

[RFC 0/6] Add a stricter headers check

2024-11-27 Thread David Marchand
As explained in patch 6, the current headers check can not catch issues when a public header includes an internal header. Fixing this from meson does not seem an easy task. The approach of this RFC is to reimplement the check in a Makefile invoked out of DPDK (like what is done for external compil

[RFC 4/6] drivers: fix exported headers

2024-11-27 Thread David Marchand
Those headers could not be included individually as they were not including their dependencies, or were subject to some build warnings. Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Fixes: 5b2a1a02dcaf ("crypto/cnxk: fix experimental version for PMD API") Fixes: e5abbfa5 (

[RFC 3/6] eventdev: do not include driver header in DMA adapter

2024-11-27 Thread David Marchand
The dma adapter header does not require including rte_dmadev_pmd.h which is a driver header. Fixes: 66a30a29387a ("eventdev/dma: introduce DMA adapter") Signed-off-by: David Marchand --- lib/eventdev/rte_event_dma_adapter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib

[RFC 1/6] baseband/acc: fix exported header

2024-11-27 Thread David Marchand
rte_acc_cfg.h relies on rte_acc_common_cfg.h. Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code") Signed-off-by: David Marchand --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/meson.build b/driv

Re: rte_event_eth_tx_adapter_enqueue() short enqueue

2024-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2024 at 11:53:50AM +0100, Mattias Rönnblom wrote: > On 2024-11-27 11:38, Bruce Richardson wrote: > > On Wed, Nov 27, 2024 at 11:03:31AM +0100, Mattias Rönnblom wrote: > > > Hi. > > > > > > Consider the following situation: > > > > > > An application does > > > > > > rte_event_eth

Re: rte_event_eth_tx_adapter_enqueue() short enqueue

2024-11-27 Thread Mattias Rönnblom
On 2024-11-27 11:38, Bruce Richardson wrote: On Wed, Nov 27, 2024 at 11:03:31AM +0100, Mattias Rönnblom wrote: Hi. Consider the following situation: An application does rte_event_eth_tx_adapter_enqueue() and due to back-pressure or some other reason not all events/packets could be enqueued,

RE: [PATCH 2/3] eventdev: fix uninitialized variable

2024-11-27 Thread Gujjar, Abhinandan S
> -Original Message- > From: Ma, WenwuX > Sent: Monday, November 25, 2024 12:18 PM > To: ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > amitpraka...@marvell.com; Gujjar, Abhinandan S > ; dev@dpdk.org; sta...@dpdk.org > Cc: Liao, TingtingX ; Ma, WenwuX > > Subject: [PATCH 2/3

Re: rte_event_eth_tx_adapter_enqueue() short enqueue

2024-11-27 Thread Bruce Richardson
On Wed, Nov 27, 2024 at 11:03:31AM +0100, Mattias Rönnblom wrote: > Hi. > > Consider the following situation: > > An application does > > rte_event_eth_tx_adapter_enqueue() > > and due to back-pressure or some other reason not all events/packets could > be enqueued, and a count lower than the n

[PATCH v4] net/hns3: fix Rx packet without CRC data

2024-11-27 Thread Jie Hai
From: Dengdui Huang When KEEP_CRC offload is enabled, the CRC data is still stripped in following cases: 1. For HIP08 network engine, the packet type is TCP and the length is less than or equal to 60B. 2. For HIP09 network engine, the packet type is IP and the length is less than or equal t

rte_event_eth_tx_adapter_enqueue() short enqueue

2024-11-27 Thread Mattias Rönnblom
Hi. Consider the following situation: An application does rte_event_eth_tx_adapter_enqueue() and due to back-pressure or some other reason not all events/packets could be enqueued, and a count lower than the nb_events input parameter is returned. The API says that "/../ the remaining event

[PATCH v3 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-27 Thread Anatoly Burakov
Currently, when binding a device to VFIO, the UID/GID for the device will always stay as system default (`root`). Yet, when running DPDK as non-root user, one has to change the UID/GID of the device to match the user's UID/GID to use the device. This patch adds an option to `dpdk-devbind.py` to ch

Re: [PATCH v2 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-27 Thread Burakov, Anatoly
On 11/26/2024 5:15 PM, Robin Jarry wrote: Hi Anatoly, Anatoly Burakov, Nov 26, 2024 at 16:02: Currently, when binding a device to VFIO, the UID/GID for the device will always stay as system default (`root`). Yet, when running DPDK as non- root user, one has to change the UID/GID of the device

Re: Doubts in JumboFrames and stats_checks tests in DTS.

2024-11-27 Thread Bharati Bhole - Geminus
Hi Patrick, 11/26 16:00 UTC works for me. Please let me know which link to join. Thanks, Bharati. From: Patrick Robb Sent: Monday, November 25, 2024 9:27:29 PM To: Bharati Bhole - Geminus Cc: d...@dpdk.org ; Nicholas Pratte ; Dean Marx ; Paul Szczepanek ; Luca

Re: Doubts in JumboFrames and stats_checks tests in DTS.

2024-11-27 Thread Bharati Bhole - Geminus
Hi Patrik, I used site - https://dpdk.org/git/dpdk to clone the DPDK code. I tried to go through the DTS/README.md file. This file says, it uses docker container for dev as well as test execution. But I did not find any steps for setting up the test environment for it. I tried to look for the

[PATCH] vhost: clear ring addresses when getting vring base

2024-11-27 Thread jianping.zhao
From: "Jianping.zhao" Clear ring addresses during vring base retrieval to handle guest reboot scenarios correctly. This is particularly important for vdpa-blk devices where the following issue occurs: When a guest OS with vdpa-blk device reboots, during UEFI stage, only one vring is actually use

Re: [PATCH] maintainers: update for DMA perf app

2024-11-27 Thread 姜诚
Good to have more maintainers for this app. Thanks. Acked-by: Cheng Jiang 在 2023/10/27 11:00, Gowrishankar Muthukrishnan 写道: Add co-maintainer for DMA perf app. Signed-off-by: Gowrishankar Muthukrishnan --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAI

Re: Doubts in JumboFrames and stats_checks tests in DTS.

2024-11-27 Thread Bharati Bhole - Geminus
Hi Patrick, Thanks a lot for the quick response. Thank you for adding me in the discussion meeting. Thank you, Bharati. From: Patrick Robb Sent: Friday, November 22, 2024 10:29:18 PM To: Bharati Bhole - Geminus Cc: d...@dpdk.org ; Nicholas Pratte ; Dean Marx ;

Re: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-27 Thread Jason Wang
Hello: On Fri, Nov 22, 2024 at 2:03 AM Gowrishankar Muthukrishnan wrote: > > Hi, > We are adding support for vDPA user backend for virtio-crypto PMD in DPDK. I wonder what kind of vDPA device you are using? Is there a marvell specific vDPA or just a standard virtio-pci device via vp-vdpa. Thank

RE: release candidate 24.11-rc3

2024-11-27 Thread Xu, HailinX
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 20, 2024 10:13 AM > To: annou...@dpdk.org > Subject: release candidate 24.11-rc3 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v24.11-rc3 > > There are 192 new patc