Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

On Fri, Oct 25, 2024 at 11:26:14PM +0300, Dmitry Kozlyuk wrote: > It was impossible to include mapped contigmem buffers in core dump. > Add hw.contigmem.coredump_enable tunable to control the inclusion. > > Mappings backed by OBJ_FICTITIOUS are excluded from core dump. > While contigmem is a devic

[PATCH v8 01/21] eal: include header required for alloca

From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/eal/linux/include/rte_os

[PATCH v10 21/21] hash: remove use of VLAs by using standard arrays

MSVC does not support VLAs, replace VLAs with standard C arrays. Signed-off-by: Andre Muezerie --- lib/hash/rte_thash_gf2_poly_math.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/hash/rte_thash_gf2_poly_math.c b/lib/hash/rte_thash_gf2_poly_math.c index 1c62974e

Re: [PATCH v2] doc: documentation update for idxd driver

On 2024/11/20 1:42, Thomas Monjalon wrote: > 08/10/2024 08:52, Shaiq Wani: >> Added a note to avoid usage errors by end user. >> >> Signed-off-by: Shaiq Wani >> >> v2 - addressed review comments. >> --- >> --- a/app/test-dma-perf/config.ini >> +++ b/app/test-dma-perf/config.ini >> @@ -61,6 +61,9 @

[PATCH v8 03/21] eal/common: remove use of VLAs

From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev --- lib/eal/common/eal_common_proc.c | 5 +++-- 1 file cha

RE: [EXTERNAL] [PATCH v3] app/dma-perf: calrify incorrect NUMA config

> Subject: [EXTERNAL] [PATCH v3] app/dma-perf: calrify incorrect NUMA config Looks good to me, with minor correction in subject: calrify -> clarify. Thanks, Gowrishankar

Re: [v5,2/5] raw/gdtc: add support for queue setup operation

14/11/2024 10:20, Yong Zhang: > +#define ZXDH_GDMA_SRC_LLI_ERR (1 << 16) > +#define ZXDH_GDMA_SRC_DATA_ERR (1 << 17) > +#define ZXDH_GDMA_DST_ADDR_ERR (1 << 18) > +#define ZXDH_GDMA_ERR_STATUS(1 << 19) > +#define ZXDH_GDMA_ERR_

[v3 2/3] examples/l3fwd: fix return value on rules add

fix return value on adding the EM or LPM rules. Fixes: e7e6dd643092 ("examples/l3fwd: support config file for EM") Fixes: 52def963fc1c ("examples/l3fwd: support config file for LPM/FIB") Cc: sean.morris...@intel.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- examples/l3fwd/em_route_

[v3 0/3] L3fwd changes

v3 changes: * rebased the series to latest commit. v2 changes: * Handled a comment to enhance the invalid port ID logic and added a user option to decide exit or silently skip in case invalid port in the rules list. Gagandeep Singh (3): examples/l3fwd: support single route file exampl

[PATCH v10 14/21] common/idpf: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- drivers/common/idpf/idpf_common_rxtx.c

RE: [v2 3/3] examples/l3fwd: enhance valid ports checking

Hi, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 19, 2024 10:43 PM > To: Gagandeep Singh > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [v2 3/3] examples/l3fwd: enhance valid ports checking > > 13/11/2024 20:39, Stephen Hemminger: > > On Tue, 6 Aug 2024

[v3 3/3] examples/l3fwd: enhance valid ports checking

The current port ID validation logic in the routes add code has two issues: - It can pass if port ID in route is 31+. - It silently skips rules with disabled or invalid port IDs This patch is: - Improving the enabled port IDs check logic. - Introducing a user option, "exit_on_failure", to

[v3 1/3] examples/l3fwd: support single route file

IPv6 rules file needs to be specified together with IPv4 rules file to configure user given rules. But if user want to give only IPv4 or only IPv6 rules, application returns error: "Missing 1 or more rule files" With this patch application can accept only IPv4, only IPv6 or both IP rules. Signed-

[PATCH v2] doc: no longer support end of life CentOS versions

The CentOS Project has shifted focus from CentOS Linux to CentOS Stream. Both CentOS 7 and 8 are now end of life (EOL). CentOS Linux 7 EOL: 2024-06-30 CentOS Linux 8 EOL: 2021-12-31 CentOS Stream 8 EOL: 2024-05-31 Update the documentation and release notes. There is no exp

Re: [PATCH v3] app/dma-perf: calrify incorrect NUMA config

20/03/2024 02:40, Vipin Varghese: > In case incorrect NUMA configuration, the current commit shares > 1) either `source or destination numa is greater` > 2) instead of `actual NUMA` it is `acture NUMA` > 3) uses `printf` instead of PRINT_ERR > > current patch changes the above to > 1) identify

Re: [PATCH v2] usertools/devbind: support all possible values in sysfs flag

12/11/2024 15:08, Robin Jarry: > Rogelio Domínguez Hernández, Nov 12, 2024 at 15:07: > > This patch adds support for 'y' and 'Y' values when reading > > vfio-pci unsafe_noiommu_mode flag. > > > > Possible values were taken from linux kernel > > (sysfs__read_bool() in tools/lib/api/fs/fs.c) > > > >

RE: release candidate 24.11-rc2

> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 12, 2024 11:24 PM > To: annou...@dpdk.org > Subject: release candidate 24.11-rc2 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v24.11-rc2 > > There are 444 new patche

[PATCH v10 02/21] eal/linux: remove use of VLAs

From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array ‘events’ MSVC does not support VLAs. Use alloca() to allocate the memory on the stack. 2) ./lib/eal/linux/eal_interrupts.c:1319:16 : warning: ISO C90 forbids variable le

[PATCH v10 09/21] gro: remove use of VLAs

From: Konstantin Ananyev ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to collect un-used by GRO packets, and then cop

[PATCH v10 18/21] build: enable vla warnings on Windows built code

From: Tyler Retzlaff MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meso

[PATCH v10 17/21] net/mlx5: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

[PATCH v10 16/21] common/mlx5: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v10 20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v10 19/21] test: remove use of VLAs for Windows built code in bitset tests

1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=array-bounds=] 3695

[PATCH v10 13/21] test: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test/test.c | 2 +- app/test/test_cmdline_s

[PATCH v10 15/21] net/i40e: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Reviewed-by: Bruce Richardson --- drivers/net/i40e/i40e_testpmd.c | 5 ++-

[PATCH v10 11/21] net/ice: remove use of VLAs

From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we ca

[PATCH v10 08/21] gro: fix overwrite unprocessed packets

From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Ferr

[PATCH v10 12/21] app/testpmd: remove use of VLAs for Windows built

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/cmdline_flow.c | 15

[PATCH v10 10/21] net/ixgbe: remove use of VLAs

From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable len

[PATCH v10 06/21] hash/thash: remove use of VLAs for Windows built

From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ >From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to replace VLA with fixed size array. Signed-off-by: Konstant

[PATCH v10 04/21] ethdev: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v10 07/21] rcu: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v10 03/21] eal/common: remove use of VLAs

From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev --- lib/eal/common/eal_common_proc.c | 5 +++-- 1 file cha

[PATCH v10 05/21] hash: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v10 00/21] remove use of VLAs for Windows

As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

[PATCH v10 01/21] eal: include header required for alloca

From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/eal/linux/include/rte_os

[PATCH v3] doc: add security document

This is a new document covering security protocols implemented in DPDK. Signed-off-by: Nandini Persad Signed-off-by: Thomas Monjalon Reviewed-by: Stephen Hemminger --- doc/guides/index.rst | 1 + doc/guides/security/index.rst | 336 ++ 2 files changed

Re: [PATCH v4 0/7] refactor kvargs test

01/11/2024 03:26, lihuisong (C): > For this series, > Acked-by: Huisong Li > 在 2024/10/30 16:54, Chengwen Feng 写道: > > When developing patchset [1], I found the kvargs test is hard to > > understand when tried to add some testcase. > > > > So refactor kvargs by: > > 1. introduce UT suite framework

[PATCH] net/r8169: replace rte_smp_rmb with atomic read

rte_smp_rmb is deprecated and it is too heavy. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_rxtx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/r8169/r8169_rxtx.c b/drivers/net/r8169/r8169_rxtx.c index a3b86300f0..57b97338d4 100644 --- a/drivers

[PATCH v8 11/21] net/ice: remove use of VLAs

From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we ca

[PATCH v8 17/21] net/mlx5: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

release candidate 24.11-rc3

A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v24.11-rc3 There are 192 new patches in this snapshot. Hopefully almost everything expected should be in. Release notes: https://doc.dpdk.org/guides/rel_notes/release_24_11.html Highlights of 24.

[PATCH v9 02/21] eal/linux: remove use of VLAs

From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array ‘events’ MSVC does not support VLAs. Use alloca() to allocate the memory on the stack. 2) ./lib/eal/linux/eal_interrupts.c:1319:16 : warning: ISO C90 forbids variable le

Re: [v5,2/5] raw/gdtc: add support for queue setup operation

20/11/2024 02:45, zhang.yon...@zte.com.cn: > The patch is currently in the accepted state. Yes I've merged it. > Should I resubmit the patch or modify it in the next release? You can modify with a new patch for the next release.

[PATCH v9 19/21] test: remove use of VLAs for Windows built code in bitset tests

1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=array-bounds=] 3695

[PATCH v9 17/21] net/mlx5: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5.c | 5 ++--- drivers/net/mlx5/mlx5_flow.c |

[PATCH v9 18/21] build: enable vla warnings on Windows built code

From: Tyler Retzlaff MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meso

[PATCH v9 16/21] common/mlx5: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v9 15/21] net/i40e: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Reviewed-by: Bruce Richardson --- drivers/net/i40e/i40e_testpmd.c | 5 ++-

[PATCH v9 21/21] hash: remove use of VLAs by using standard arrays

MSVC does not support VLAs, replace VLAs with standard C arrays. Signed-off-by: Andre Muezerie --- lib/hash/rte_thash_gf2_poly_math.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/hash/rte_thash_gf2_poly_math.c b/lib/hash/rte_thash_gf2_poly_math.c index 1c62974e

[PATCH v9 20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v9 08/21] gro: fix overwrite unprocessed packets

From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Ferr

[PATCH v9 12/21] app/testpmd: remove use of VLAs for Windows built

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/cmdline_flow.c | 15

[PATCH v9 13/21] test: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test/test.c | 2 +- app/test/test_cmdline_s

[PATCH v9 14/21] common/idpf: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- drivers/common/idpf/idpf_common_rxtx.c

[PATCH v9 05/21] hash: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v9 10/21] net/ixgbe: remove use of VLAs

From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable len

[PATCH v9 11/21] net/ice: remove use of VLAs

From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX from particular queue, at rx_queue_setup() we ca

[PATCH v9 06/21] hash/thash: remove use of VLAs for Windows built

From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ >From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to replace VLA with fixed size array. Signed-off-by: Konstant

[PATCH v9 07/21] rcu: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

[PATCH v9 00/21] remove use of VLAs for Windows

As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. MSVC does not support VL

[PATCH v9 03/21] eal/common: remove use of VLAs

From: Konstantin Ananyev 1) ../lib/eal/common/eal_common_proc.c:695:15 : warning: variable length array used As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced it with fixed size array. Signed-off-by: Konstantin Ananyev --- lib/eal/common/eal_common_proc.c | 5 +++-- 1 file cha

[PATCH v9 04/21] ethdev: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v9 01/21] eal: include header required for alloca

From: Tyler Retzlaff Include alloca.h for Linux and malloc.h for Windows to get declaration of alloca(). Signed-off-by: Tyler Retzlaff --- lib/eal/linux/include/rte_os.h | 1 + lib/eal/windows/include/rte_os.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/eal/linux/include/rte_os

Re: [PATCH v3] examples/flow_filtering: introduce use cases snippets

14/10/2024 18:47, Stephen Hemminger: > On Mon, 30 Sep 2024 22:53:21 +0300 > Shani Peretz wrote: > > > These code snippets demonstrate rule creation using > > template and non-template APIs. > > They include functions that enable developers to create rules. > > The purpose of providing these snipp

Re: [v5,2/5] raw/gdtc: add support for queue setup operation

Hi Thomas, >> +#define ZXDH_GDMA_SRC_LLI_ERR (1 << 16)>> +#define >> ZXDH_GDMA_SRC_DATA_ERR (1 << 17)>> +#define >> ZXDH_GDMA_DST_ADDR_ERR (1 << 18)>> +#define >> ZXDH_GDMA_ERR_STATUS(1 << 19)>> +#define >> ZXDH_GDMA_ERR_I

[PATCH v8 14/21] common/idpf: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- drivers/common/idpf/idpf_common_rxtx.c

[PATCH v8 05/21] hash: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/hash/rte_cuckoo_hash.c:2362:9 : warning: ISO C90 forbids variable length array ‘positions’ 2) ../lib/hash/rte_cuckoo_hash.c:2478:9 : warning: ISO C90 forbids variable length array ‘positions’ Both rte_hash_lookup_bulk_data() and rte_hash_lookup_with_hash

[PATCH v8 06/21] hash/thash: remove use of VLAs for Windows built

From: Konstantin Ananyev 1) ./lib/hash/rte_thash.c:774:9 : warning: ISO C90 forbids variable length array ‘tmp_tuple’ >From my understanding, tuple size here should never exceed sizeof(union rte_thash_tuple), so it should be safe to replace VLA with fixed size array. Signed-off-by: Konstant

[PATCH v8 12/21] app/testpmd: remove use of VLAs for Windows built

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/cmdline_flow.c | 15

[PATCH v8 19/21] test: remove use of VLAs for Windows built code in bitset tests

From: Andre Muezerie 1) MSVC does not support VLAs. Use standard fixed C arrays of maximum size required instead. 2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: error: array subscript 9 is outside array bounds of 'uint64_t[16]' {aka 'long unsigned int[16]'} [-Werror=

[PATCH v8 16/21] common/mlx5: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx

[PATCH v8 07/21] rcu: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/rcu/rte_rcu_qsbr.c:359:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] 2) ./lib/rcu/rte_rcu_qsbr.c:422:9 : warning: ISO C90 forbids variable length array ‘data’ [-Wvla] In both cases we allocate VLA for one element from RCU deferred que

Re: [v5,1/5] raw/gdtc: introduce gdtc raw device driver

14/11/2024 10:20, Yong Zhang: > Introduce rawdev driver support for GDTC which > can help to connect two separate hosts with each other. > > Signed-off-by: Yong Zhang I've sorted things, and avoided reindent in the last patch. Series applied, thanks.

[PATCH v8 13/21] test: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- app/test/test.c | 2 +- app/test/test_cmdline_s

[PATCH v8 20/21] app/testpmd: remove use of VLAs for Windows built code in shared_rxq_fwd

From: Andre Muezerie MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Andre Muezerie --- app/test-pmd/shared_rxq_fwd.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v8 18/21] build: enable vla warnings on Windows built code

From: Tyler Retzlaff MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meso

[PATCH v8 21/21] hash: remove use of VLAs by using standard arrays

From: Andre Muezerie MSVC does not support VLAs, replace VLAs with standard C arrays. Signed-off-by: Andre Muezerie --- lib/hash/rte_thash_gf2_poly_math.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/hash/rte_thash_gf2_poly_math.c b/lib/hash/rte_thash_gf2_pol

[PATCH v8 08/21] gro: fix overwrite unprocessed packets

From: Konstantin Ananyev gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account that first entries in pkts[] can be already occupied by un-processed packets. Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") Cc: sta...@dpdk.org Signed-off-by: Konstantin Ananyev Acked-by: Ferr

[PATCH v8 10/21] net/ixgbe: remove use of VLAs

From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable len

[PATCH v8 15/21] net/i40e: remove use of VLAs for Windows built code

From: Tyler Retzlaff MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff Reviewed-by: Bruce Richardson --- drivers/net/i40e/i40e_testpmd.c | 5 ++-

[PATCH v8 09/21] gro: remove use of VLAs

From: Konstantin Ananyev ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to collect un-used by GRO packets, and then cop

[PATCH v8 02/21] eal/linux: remove use of VLAs

From: Konstantin Ananyev 1) ./lib/eal/linux/eal_interrupts.c:1073:16 : warning: ISO C90 forbids variable length array ‘events’ MSVC does not support VLAs. Use alloca() to allocate the memory on the stack. 2) ./lib/eal/linux/eal_interrupts.c:1319:16 : warning: ISO C90 forbids variable le

[PATCH v8 04/21] ethdev: remove use of VLAs for Windows built code

From: Konstantin Ananyev 1) ./lib/ethdev/rte_ethdev.c:3244:16 : warning: ISO C90 forbids variable length array ‘xstats_names’ 2) ./lib/ethdev/rte_ethdev.c:3345:17 : warning: ISO C90 forbids variable length array ‘ids_copy’ 3) ./lib/ethdev/rte_ethdev.c:3538:16 : warning: ISO C90 forbid

[PATCH v8 00/21] remove use of VLAs for Windows

From: Andre Muezerie As per guidance technical board meeting 2024/04/17. This series removes the use of VLAs from code built for Windows for all 3 toolchains. If there are additional opportunities to convert VLAs to regular C arrays please provide the details for incorporation into the series. M

Re: [PATCH v7 19/21] test: remove use of VLAs for Windows built code in bitset tests

On Tue, Nov 19, 2024 at 11:16:04AM +0100, Mattias Rönnblom wrote: > On 2024-11-12 03:02, Andre Muezerie wrote: > >1) MSVC does not support VLAs. Use standard fixed C arrays of > >maximum size required instead. > > > >2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8: > > error:

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

19/11/2024 19:27, Dmitry Kozlyuk: > 2024-11-19 15:48 (UTC+), Bruce Richardson: > > On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote: > > > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > > > > Is the extra control necessary, i.e., why not just always do this and > > > > let > > >

Re: [PATCH] build: output source and build dirs at end of config

On Wed, Oct 30, 2024 at 05:16:01PM +, Bruce Richardson wrote: > The configuration run of meson produces a lot of output. When running > test-meson-builds script, or any other script which does multiple > builds, it can be useful to see the directory in which ninja is being > run. Currently this

Re: [PATCH v3 0/2] Testpmd flow update/destroy fixes

> Danylo Vodopianov (2): > app/testpmd: fix flow update > app/testpmd: fix aged flow destroy Applied, thanks.

Re: [PATCH v3] app/proc-info: add rte_eal_cleanup() to avoid memory leak

09/10/2024 03:22, fengchengwen: > On 2024/10/4 10:48, Stephen Hemminger wrote: > > From: Fidaullah Noonari > > > > when app is launched with -m proc-info exit without > > rte_eal_cleanup() causing memory leakage. This commit resolves the > > memory leakage issue and closes app properly. > > > >

Re: [PATCH v2 2/2] test/dma: add functions to verify zero and one fill

19/04/2024 11:07, Vidya Sagar Velumuri: > Add test cases to verify zero fill and one fill > > Signed-off-by: Vidya Sagar Velumuri Waiting for review from DMA maintainers. > diff --git a/app/test/test.h b/app/test/test.h > index 15e23d297f..0ca6519f6e 100644 > --- a/app/test/test.h > +++ b/app/t

Re: [PATCH v6 0/4] test: restore cfgfile lib tests

13/08/2024 17:57, Stephen Hemminger: > The cfgfile tests did not get built since conversion to meson > and they used an awkward way to manage the test data. > > This patchset converts the tests to use a helper to take > text file and make it into a C header. Then use the C header > to generate tem

Re: [PATCH] member: fix choice of bucket for displacement

16/11/2024 02:12, Stephen Hemminger: > Because of misuse of & vs && operator, the member code would > always use the primary bucket. > > Fixes: 904ec78a239c ("member: implement HT mode") > Cc: yipeng1.w...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Stephen Hemminger Applied, thanks.

Re: [PATCH v3] power: fix a typo in the PM QoS guide

13/11/2024 01:59, Huisong Li: > The typo in the guide is hard to understand. Necessary to fix it. > > Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide") > > Signed-off-by: Huisong Li Applied, thanks.

Re: [PATCH] doc: no longer support end of life CentOS versions

19/11/2024 19:40, Stephen Hemminger: > On Tue, 19 Nov 2024 16:34:24 +0100 > Thomas Monjalon wrote: > > > 31/07/2024 01:40, Stephen Hemminger: > > > The CentOS Project has shifted focus from CentOS Linux to CentOS Stream. > > > Both CentOS 7 and 8 are now end of life (EOL). > > > > > > CentOS L

Re: [PATCH] doc: no longer support end of life CentOS versions

On Tue, 19 Nov 2024 16:34:24 +0100 Thomas Monjalon wrote: > 31/07/2024 01:40, Stephen Hemminger: > > The CentOS Project has shifted focus from CentOS Linux to CentOS Stream. > > Both CentOS 7 and 8 are now end of life (EOL). > > > > CentOS Linux 7 EOL: 2024-06-30 > > CentOS Linux 8 EOL:

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-11-19 15:48 (UTC+), Bruce Richardson: > On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote: > > 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > > > Is the extra control necessary, i.e., why not just always do this and let > > > the EAL option control whether the pages get dumped

Re: [PATCH v4 0/2] examples/l3fwd: add more options

18/10/2024 03:08, Jie Hai: > Add options to support configuring RX burst size and cache size > of mbuf mempoool. Applied, thanks.

Re: [PATCH v2 00/19] minor fixes from PVS studio bug list

18/11/2024 19:20, Stephen Hemminger: > v2 - add a few more fixes, and rebase Please could you resend with "--cc-cmd devtools/get-maintainer.sh" ? Given these patches are not critical I think we can wait for maintainers review, even if it means missing the 24.11 release?

  1   2   >