Hi,

> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Tuesday, November 19, 2024 10:43 PM
> To: Gagandeep Singh <g.si...@nxp.com>
> Cc: dev@dpdk.org; Stephen Hemminger <step...@networkplumber.org>
> Subject: Re: [v2 3/3] examples/l3fwd: enhance valid ports checking
> 
> 13/11/2024 20:39, Stephen Hemminger:
> > On Tue,  6 Aug 2024 09:11:20 +0530
> > Gagandeep Singh <g.si...@nxp.com> wrote:
> >
> > > The current port ID validation logic in the routes add code has two
> > > issues:
> > >
> > >  - It can pass if port ID in route is 31+.
> > >  - It silently skips rules with disabled or invalid
> > >    port IDs
> > >
> > > This patch is:
> > >  - Improving the enabled port IDs check logic.
> > >  - Introducing a user option, "exit_on_failure", to control
> > >    the behavior when attempting to add rules for disabled or
> > >    invalid port IDs (either exit or skip)
> > >  - Creating a port ID validation function for use across
> > >    various setup functions
> > >
> > > Signed-off-by: Gagandeep Singh <g.si...@nxp.com>
> >
> > Patch looks fine, but other changes in the intervening time have
> > caused conflicts with this patch. Needs to be rebased.
> 
> Waiting for a rebase please?
> 
I have sent  the rebase series as v3.

Reply via email to