[PATCH] net/hns3: remove roh devices

2024-10-25 Thread Jie Hai
From: Dengdui Huang The devices added in commit 3f1436d7006c ("net/hns3: support new device") is no longer available, so revert it. Fixes: 3f1436d7006c ("net/hns3: support new device") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_cmd.c| 4 +--- drivers/net/hn

RE: [PATCH v9 1/6] power: refactor core power management library

2024-10-25 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Huisong, > -Original Message- > From: lihuisong (C) > Sent: Saturday, October 26, 2024 8:37 AM > To: Tummala, Sivaprasad > Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com; > jer...@marvell.com; radu.nico...@in

RE: [PATCH v2 0/2] Hugepage inclusion in core dump

2024-10-25 Thread Morten Brørup
For the series, Acked-by: Morten Brørup

Re: [PATCH RESEND v7 0/5] app/testpmd: support multiple process attach and detach port

2024-10-25 Thread lihuisong (C)
Hi Ferruh, 在 2024/10/18 10:48, lihuisong (C) 写道: Hi Ferruh, Thanks for your considering again. please see reply inline. 在 2024/10/18 9:04, Ferruh Yigit 写道: On 10/8/2024 3:32 AM, lihuisong (C) wrote: Hi Thomas and Ferruh, We've discussed it on and off a few times, and we've reached some con

Re: [PATCH v9 6/6] power: rename library sources for cpu frequency management

2024-10-25 Thread lihuisong (C)
Hi Sivaprasad, 在 2024/10/23 13:11, Sivaprasad Tummala 写道: This patch renames the existing core power library source files from rte_power.* to rte_power_cpufreq.* for better clarity Now it is more clarity for cpufeq and uncore. Thank you for this work. But I have another question, pmd_mgmt com

Re: [PATCH] net/netvsc: force TX VLAN offload on 801.2Q packet

2024-10-25 Thread Ferruh Yigit
On 10/19/2024 4:32 PM, Stephen Hemminger wrote: > On Fri, 18 Oct 2024 11:13:50 -0700 > lon...@linuxonhyperv.com wrote: > >> icrosoft.com> >> >> The VSP assumes the packet doesn't have VLAN tags. When VLAN tag is >> present in a TX packet, always strip it and use PPI to send VLAN info >> through VS

Re: [PATCH v9 2/6] power: refactor uncore power management library

2024-10-25 Thread lihuisong (C)
Already reviewed before. Acked-by: Huisong Li 在 2024/10/23 13:11, Sivaprasad Tummala 写道: This patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The

Re: [PATCH 0/4] net/hns3: support more flow pattern match

2024-10-25 Thread Ferruh Yigit
On 10/18/2024 7:19 AM, Jie Hai wrote: > 1. support general tunnel flow match > 2. support outer VLAN flow match > > Chengwen Feng (4): > net/hns3: restrict FDIR only support one tunnel header > net/hns3: support general tunnel flow match > net/hns3: add FDIR VLAN match mode param string >

Re: [PATCH v9 1/6] power: refactor core power management library

2024-10-25 Thread lihuisong (C)
Hi Sivaprasad, LGTM except for some trivial comments inline, With belows to change, you can add Acked-by: Huisong Li /Huisong 在 2024/10/23 13:11, Sivaprasad Tummala 写道: This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modula

Re: [v7,9/9] net/zxdh: add zxdh dev configure ops

2024-10-25 Thread Junlong Wang
Hi Ferruh, I hope this message finds you well. I have made the revisions according to your review comments, and the final version was submitted on Oct 22th. Since then, I have not received any feedback from the community. I would appreciate it if you could provide any suggestions for mod

Re: [PATCH] ethdev: fix link with C++

2024-10-25 Thread Ferruh Yigit
On 10/25/2024 8:18 AM, Andrew Rybchenko wrote: > On 10/24/24 23:25, David Marchand wrote: >> Some ethdev symbols were put out of extern "C" {} and became unavailable >> when linking with C++ objects. >> >> Fixes: 719834a6849e ("use C linkage where appropriate in headers") >> >> Reported-by: John Mi

Re: [PATCH v01] net/af_packet: don't specify protocol on socket create

2024-10-25 Thread Ferruh Yigit
On 10/26/2024 12:10 AM, Ferruh Yigit wrote: > On 10/17/2024 2:38 AM, Stephen Hemminger wrote: >> On Sun, 13 Oct 2024 16:59:47 +0300 >> Gur Stavi wrote: >> >>> When creating AF_PACKET socket with specified protocol it is >>> immediately implicitly bound to any existing interface and >>> becomes RUN

Re: [PATCH] net/nfp: fix return value check problem

2024-10-25 Thread Ferruh Yigit
On 10/17/2024 8:36 AM, Chaoyong He wrote: > Fix one return value check problem found by the CI. > > Coverity issue: 445519 > Fixes: 08ea495d624b ("net/nfp: support loading firmware from flash") > Cc: sta...@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Peng Zhang > Applied to dpdk-ne

[PATCH v29 10/13] log: add timestamp option

2024-10-25 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

Re: [PATCH 0/4] net/hns3: support more flow pattern match

2024-10-25 Thread Ferruh Yigit
Recheck-request: iol-unit-arm64-testing, iol-unit-amd64-testing

[PATCH v29 08/13] eal: initialize log before everything else

2024-10-25 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

Re: [PATCH v01] net/af_packet: don't specify protocol on socket create

2024-10-25 Thread Ferruh Yigit
On 10/17/2024 2:38 AM, Stephen Hemminger wrote: > On Sun, 13 Oct 2024 16:59:47 +0300 > Gur Stavi wrote: > >> When creating AF_PACKET socket with specified protocol it is >> immediately implicitly bound to any existing interface and >> becomes RUNNING. Calling bind on such socket is affectively un

RE: [PATCH 2/2] drivers/net: support single queue per port

2024-10-25 Thread Long Li
> Subject: [PATCH 2/2] drivers/net: support single queue per port > > When configuring DPDK for one queue per port (#define > RTE_MAX_QUEUES_PER_PORT 1), compilation of some network drivers fails with > e.g.: > > ../drivers/net/bnxt/bnxt_rxq.c: In function 'bnxt_rx_queue_stop': > ../drivers/net/b

Re: [PATCH v4 00/42] replace strerror

2024-10-25 Thread Thomas Monjalon
24/10/2024 08:47, huangdengdui: > On 2024/10/23 23:42, Stephen Hemminger wrote: > > On Wed, 23 Oct 2024 16:28:10 +0800 > > Dengdui Huang wrote: > > > >> The function strerror() is insecure in a multi-thread environment. > >> It is better to use rte_strerror() instead of strerror(). > >> In this p

Re: [PATCH] MAINTAINERS: add maintainer for next-net-intel tree

2024-10-25 Thread Thomas Monjalon
24/10/2024 18:41, Stephen Hemminger: > On Thu, 24 Oct 2024 15:51:22 +0100 > Bruce Richardson wrote: > > > For last two releases, I have been committer for the next-net-intel > > tree, so update the details in MAINTAINERS file to reflect that fact. > > > > Signed-off-by: Bruce Richardson > > ---

[PATCH v29 13/13] doc: add release note about log library

2024-10-25 Thread Stephen Hemminger
Significant enough to warrant a release note. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- doc/guides/rel_notes/release_24_11.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/rel_notes/r

[PATCH v29 12/13] log: colorize log output

2024-10-25 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. The default is to not use color since it may disturb automatic tests and other embedded us

[PATCH v29 11/13] log: add support for systemd journal

2024-10-25 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v29 09/13] log: add hook for printing log messages

2024-10-25 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

[PATCH v29 03/13] windows: update os shim

2024-10-25 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Use rte_os_shim.h in lib/log instead of redefine of strdup. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng ---

[PATCH v29 07/13] log: rework syslog handling

2024-10-25 Thread Stephen Hemminger
Refactor how syslog is handled, make it common to Linux and FreeBSD The syslog facility property is better handled in lib/log rather than in eal. This also add syslog support to FreeBSD. Log to syslog only if option is specified. If no --syslog is given then use console only. Signed-off-by: Steph

[PATCH v29 06/13] eal: change rte_exit() output to match rte_log()

2024-10-25 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v29 05/13] eal: do not duplicate rte_init_alert() messages

2024-10-25 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/

[PATCH v29 04/13] eal: make eal_log_level_parse common

2024-10-25 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/common/eal_options.h

[PATCH v29 01/13] maintainers: add for log library

2024-10-25 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINE

[PATCH v29 02/13] windows: make getopt functions have const properties

2024-10-25 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v29 00/13] Logging subsystem enhancements

2024-10-25 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

Re: [PATCH] MAINTAINERS: add maintainers for Intel NIC drivers

2024-10-25 Thread Thomas Monjalon
24/10/2024 18:42, Stephen Hemminger: > On Thu, 24 Oct 2024 16:05:29 +0100 > Bruce Richardson wrote: > > > The ixgbe, i40e, iavf and ice NIC drivers are all actively maintained > > and receiving updates. Add official maintainer names for these drivers > > in the MAINTAINERS file. > > > > Signed-o

Re: [PATCH 2/2] drivers/net: support single queue per port

2024-10-25 Thread Ajit Khaparde
On Fri, Oct 25, 2024 at 4:52 AM Morten Brørup wrote: > > When configuring DPDK for one queue per port > (#define RTE_MAX_QUEUES_PER_PORT 1), compilation of some network drivers > fails with e.g.: > > ../drivers/net/bnxt/bnxt_rxq.c: In function 'bnxt_rx_queue_stop': > ../drivers/net/bnxt/bnxt_rxq.

RE: [EXTERNAL] Re: [PATCH v5 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc

2024-10-25 Thread Akhil Goyal
Hi Stephen, > On Thu, 24 Oct 2024 18:47:52 +0530 > Akhil Goyal wrote: > > > +/** > > + * @file cnxk_rvu_lf_driver.h > > + * > > + * Marvell RVU LF raw PMD specific structures and interface > > + * > > + * This API allows external driver/application to manage RVU LF device > > + * in user space al

[PATCH v2 0/2] Hugepage inclusion in core dump

2024-10-25 Thread Dmitry Kozlyuk
From: Dmitry Kozlyuk Hugepages often contain information useful for debugging and thus desired for inclusion in core dumps. However, including them has implications and drawbacks, so it must be an opt-in at user's discretion. This patchset add the ability to do so for FreeBSD and for Linux it jus

[PATCH v2 0/2] doc: enhance build instructions on windows

2024-10-25 Thread Andre Muezerie
* Updated about old Meson issue * Added instruction to get developer prompt --- v2: - provide Meson version that works Andre Muezerie (2): doc: enhanced build instructions on Windows doc: provide Meson version that works .mailmap | 1 + doc/guides/windows_gsg/

[PATCH v2 2/2] doc: add instruction for including hugepages in core dump

2024-10-25 Thread Dmitry Kozlyuk
Linux excludes hugepages from core dump by default. Describe the means to override this behavior as well as implications of doing so. Only mapped hugepages will be included in core dump, because Linux EAL explicitly excludes reserved regions. Signed-off-by: Dmitry Kozlyuk --- doc/guides/linux_gs

[PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-10-25 Thread Dmitry Kozlyuk
It was impossible to include mapped contigmem buffers in core dump. Add hw.contigmem.coredump_enable tunable to control the inclusion. Mappings backed by OBJ_FICTITIOUS are excluded from core dump. While contigmem is a device and its OBJT_DEVICE mappings get this flag, they are actually backed by

RE: [EXTERNAL] [PATCH v15 21/21] crypto/zsda: add functions of cryptodev create and destroy

2024-10-25 Thread Akhil Goyal
> Add functions of cryptodev create and destroy. > > Signed-off-by: Hanxiao Li This patch should be your first crypto driver patch as it does the device initialization. Please update the list that I commented earlier. > --- > drivers/crypto/zsda/zsda_sym_pmd.c | 129 +

RE: [EXTERNAL] [PATCH v15 14/21] crypto/zsda: introduce key expansion code

2024-10-25 Thread Akhil Goyal
> Introduce key expansion code for zsda sym drivers. > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build| 15 +- > drivers/crypto/zsda/zsda_sym_session.c | 281 + > drivers/crypto/zsda/zsda_sym_session.h | 9 + > 3 files changed, 304 insertion

[PATCH v2 2/2] doc: provide Meson version that works

2024-10-25 Thread Andre Muezerie
Signed-off-by: Andre Muezerie --- doc/guides/windows_gsg/build_dpdk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/windows_gsg/build_dpdk.rst b/doc/guides/windows_gsg/build_dpdk.rst index c5fad81..76bfc22 100644 --- a/doc/guides/windows_gsg/build_dpdk.rst +++

[PATCH v2 1/2] doc: enhanced build instructions on Windows

2024-10-25 Thread Andre Muezerie
Signed-off-by: Andre Muezerie --- .mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 16 +++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/.mailmap b/.mailmap index 5290420..60db768 100644 --- a/.mailmap +++ b/.mailmap @@ -98,6 +98

RE: [EXTERNAL] [PATCH v15 01/21] zsda: add zsdadev driver documents

2024-10-25 Thread Akhil Goyal
> Introduce ZTE Storage Data Accelerator(ZSDA) drivers > which can help accelerate storage data process. > > The official product documenttation web page is: > https://enterprise.zte.com.cn/products.html?id=101 > > It is recommended to update MAINTAINERS in the > first patch in the new PMD guidel

[PATCH v7 16/22] event/cnxk: support CN20K Rx adapter fast path

2024-10-25 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 122 - drivers/event/cnxk/cn20k_worker.c | 54 -- drivers/event/cnxk/cn20k_worker.h | 165

Re: [PATCH v2 5/7] dts: add support for externally compiled DPDK

2024-10-25 Thread Dean Marx
Just wondering, if the user wants to run DTS using the configuration yaml file or the environment variables instead of the command line args, are they supposed to run main.py by itself after setup? Because right now, it won't run without the --tarball or --dpdk-tree args, even if it's specified in

RE: [PATCH v2 0/3] Import Kernel uAPI header files

2024-10-25 Thread Morten Brørup
For the series, Acked-by: Morten Brørup

Re: [PATCH v2 7/7] dts: remove git ref option

2024-10-25 Thread Dean Marx
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro wrote: > From: Tomáš Ďurovec > > Given the whole DPDK tree directory can now be copied to the nodes, > there is no more need to use the git ref option, as the tree can be > controlled directly by the user. > > Signed-off-by: Tomáš Ďurovec > Signed-o

Re: [PATCH v2 6/7] doc: update argument options for external DPDK build

2024-10-25 Thread Dean Marx
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro wrote: > From: Tomáš Ďurovec > > By adding support for external build, we extend the > argument documentation for supported options. > > Signed-off-by: Tomáš Ďurovec > Signed-off-by: Luca Vizzarro > Other than the comments I brought up on the prev

RE: [EXTERNAL] [PATCH v15 03/21] common/zsda: add logging macros

2024-10-25 Thread Akhil Goyal
> Add logging macros and functions for zsda drivers > > Signed-off-by: Hanxiao Li > --- > drivers/common/zsda/meson.build | 13 + > drivers/common/zsda/zsda_logs.c | 19 +++ > drivers/common/zsda/zsda_logs.h | 27 +++ > drivers/meson.build

[PATCH 07/13] net/bnxt: register for and handle RSS change event

2024-10-25 Thread Ajit Khaparde
From: Manish Kurup 1. Register for RSS change events. When an RSS change occurs (especially for custom parsed tunnels), we need to update the RSS flags in the VNIC QCAPS so that upstream drivers don't send down the now unsupported bits ("config port all rss all" command). This will ca

Re: [PATCH v2 4/7] dts: enable copying directories to and from nodes

2024-10-25 Thread Dean Marx
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro wrote: > From: Tomáš Ďurovec > > Currently there is no support to transfer whole directories between the > DTS host and the nodes. This change adds this new feature. > > Signed-off-by: Tomáš Ďurovec > Signed-off-by: Luca Vizzarro > Reviewed-by: De

Re: [PATCH v3 3/7] dts: change remote and local paths objects

2024-10-25 Thread Dean Marx
On Mon, Oct 21, 2024 at 6:46 PM Luca Vizzarro wrote: > From: Tomáš Ďurovec > > The OSSession (and its subclasses) should accept PurePaths > for remote paths to translate from OS-unaware (PurePath) > to OS-aware (Path) only on the remote side. For local paths, > they should accept Paths, as Pytho

[PATCH 10/13] net/bnxt: remove the VNIC async event handler

2024-10-25 Thread Ajit Khaparde
From: Kishore Padmanabha The VNIC async event handler is removed, it is no longer required if during the port initialization if svif is used instead of VNIC which could be invalid for rep port if the rep's VF port link is down. Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle ---

Re: [PATCH v2 2/7] dts: enforce one dpdk build per test run

2024-10-25 Thread Dean Marx
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro wrote: > From: Tomáš Ďurovec > > Given a pre-built DPDK repository can be supplied to DTS, there is no > need to define multiple build targets. To simplify the process this > change makes each test run use only one DPDK build whether it's > pre-built

Re: [PATCH v2 1/7] dts: rename build target to DPDK build

2024-10-25 Thread Dean Marx
On Mon, Oct 21, 2024 at 9:49 AM Luca Vizzarro wrote: > From: Tomáš Ďurovec > > Since the DPDK may already be built, some more general name > is needed that includes both the DPDK location and the build > config (if we are going to build). > > Signed-off-by: Tomáš Ďurovec > Signed-off-by: Luca V

Re: [PATCH] dts: improve statistics

2024-10-25 Thread Dean Marx
Hi Tomáš, This all looks great, one thing I did notice when running locally is that the "test_suites" section of results.json contains null values instead of the names of the suites that were run. Could just be something strange happening on my side, but I would double check on your end just in ca

[PATCH 13/13] net/bnxt: remove unnecessary ifdef

2024-10-25 Thread Ajit Khaparde
Remove the unnnecessary and useless compile-time option for IEEE 1588. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 8f0a1b9cfd..5b43bcbea6 100644 --- a/drive

[PATCH 12/13] net/bnxt: add support for buffer split Rx offload

2024-10-25 Thread Ajit Khaparde
Add header and data split Rx offload support if the hardware supports it. The packet will be split at fixed offset for IPv4 or IPv6 packets. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 5 + drivers/net/bnxt/bnxt_ethdev.c | 5 + drivers/net/bnxt/bnxt_hwrm.c | 29

[PATCH 11/13] net/bnxt: remove some unnecessary logs

2024-10-25 Thread Ajit Khaparde
Remove some unnecessary logs messages when buffer allocation fails. We already have stats to indicate such failures. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/

[PATCH 09/13] net/bnxt: disable VLAN filter when TF is enabled

2024-10-25 Thread Ajit Khaparde
From: Kishore Padmanabha For p7 platform, the vlan filter and strip is disabled if the truflow is enabled on the platform. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 6 +- drivers/net/bnxt/bnxt_rxq.c| 17 +++-- 2 files

[PATCH 08/13] net/bnxt: fix LRO offload capability

2024-10-25 Thread Ajit Khaparde
Fix LRO offload capability for P7 devices. Export the capability to the application only if compressed Rx CQE mode is not enabled. LRO aka TPA is not supported when compressed CQE mode is set. Fixes: 3b56c3ffc182 ("net/bnxt: refactor code to support P7 devices") Cc: sta...@dpdk.org Signed-off-by

[PATCH 06/13] net/bnxt: free and account a bad Tx mbuf

2024-10-25 Thread Ajit Khaparde
When the PMD gets a bad Tx mbuf from the application, it is not freeing it currently. The PMD is depending on the application to do it. but in most cases, the application may not know this. Instead the Tx burst function now frees the mbuf and updates the oerrors counter to indicate that the PMD en

[PATCH 05/13] net/bnxt: add check for invalid mbuf passed by application

2024-10-25 Thread Ajit Khaparde
From: Kalesh AP If the application passes invalid mbuf for a Tx pkt, this could escape all the existing driver checks and driver could end up sending down invalid TX BDs to the HW. This in turn could lead to a FW reset. Fix by validating the "mbuf->buf_iova" or "mbuf->buf_addr" passed for the Tx

[PATCH 04/13] net/bnxt: add check for number of segs

2024-10-25 Thread Ajit Khaparde
From: Somnath Kotur If the application passes incorrect number of segs for a Tx pkt i.e. sets it to 5 while actually sending down only a single mbuf, this could escape all the existing driver checks and driver could end up sending down garbage TX BDs to the HW. This in turn could lead to a Tx pip

[PATCH 03/13] net/bnxt: add check to validate TSO segment size

2024-10-25 Thread Ajit Khaparde
From: Kalesh AP Currently driver has a check to validate TSO seg_size for 0 which is to detect corrupted packet. But user can set any value as the TSO seg_size. Adding a check to validate the minimum TSO seg_size in the driver. Driver will drop a packet with TSO seg_size less than 4 when TSO is

[PATCH 00/13] patchset for bnxt PMD

2024-10-25 Thread Ajit Khaparde
This patchset contains changes to the BNXT PMD. Some of them are fixes. Please accept and apply. Ajit Khaparde (6): net/bnxt: fix TCP and UDP checksum flags net/bnxt: free and account a bad Tx mbuf net/bnxt: fix LRO offload capability net/bnxt: remove some unnecessary logs net/bnxt: add

[PATCH 02/13] net/bnxt: fix bad action offset in Tx bd

2024-10-25 Thread Ajit Khaparde
From: Peter Spreadborough This change ensures that the high part of an action table entry offset stored in the Tx BD is set correctly. A bad value will cause the PDCU to abort a fetch an may stall the pipeline. Fixes: 527b10089cc5 ("net/bnxt: optimize Tx completion handling") Cc: sta...@dpdk.org

[PATCH 01/13] net/bnxt: fix TCP and UDP checksum flags

2024-10-25 Thread Ajit Khaparde
Set TCP and UDP checksum flags explicitly for LSO capable packets. In some older chip variants, this will enable the hardware compute the checksum correctly for tunnel and non-tunnel packets. Fixes: 1d76c878b21d ("net/bnxt: support updating IPID") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde

[PATCH v1 0/2] app/bbdev: minor application updates

2024-10-25 Thread Nicolas Chautru
Hi Maxime, all, Adding a couple of changes to the built in test application for bbdev test on top of previous changes. Thanks, Nic Nicolas Chautru (2): app/bbdev: add capture of queue dump app/bbdev: add support for interrupt disable app/test-bbdev/test_bbdev_perf.c | 40 ++

[PATCH v1 2/2] app/bbdev: add support for interrupt disable

2024-10-25 Thread Nicolas Chautru
Adding support for calling the interrupt disable api for coverage. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 24 1 file changed, 24 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 405c22de4

[PATCH v1 1/2] app/bbdev: add capture of queue dump

2024-10-25 Thread Nicolas Chautru
Capturing additional queue dump information in the bbdev-test application using the api introduced earlier. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 16 1 file changed, 16 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/

Re: [PATCH v28 11/13] log: add support for systemd journal

2024-10-25 Thread Stephen Hemminger
On Fri, 25 Oct 2024 18:33:40 +0300 Baruch Even wrote: > Can we have an option to disable journal auto-detection? > In my case I want to redirect the DPDK to our own tracing infrastructure > and for that I use the fopencookie myself and redirect it to our own > system. The journal will force it ou

Re: [PATCH v5 5/5] net/ice: provide parameter to limit scheduler layers

2024-10-25 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 23/10/2024 17:55, Bruce Richardson wrote: In order to help with backward compatibility for applications, which may expect the ice driver tx scheduler (accessed via tm apis) to only have 3 layers, add in a devarg to allow the user to explicitly limit the number of

Re: [PATCH v5 4/5] net/ice: allowing stopping port to apply TM topology

2024-10-25 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 23/10/2024 17:55, Bruce Richardson wrote: The rte_tm topology commit requires the port to be stopped on apply. Rather than just returning an error when the port is already started, we can stop the port, apply the topology to it and then restart it. Signed-off-by

Re: [PATCH v5 3/5] net/ice: enhance Tx scheduler hierarchy support

2024-10-25 Thread Medvedkin, Vladimir
Hi Bruce, On 23/10/2024 17:55, Bruce Richardson wrote: Increase the flexibility of the Tx scheduler hierarchy support in the driver. If the HW/firmware allows it, allow creating up to 2k child nodes per scheduler node. Also expand the number of supported layers to the max available, rather than

Re: [PATCH v5 2/5] net/ice/base: make context alloc function non-static

2024-10-25 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 23/10/2024 17:55, Bruce Richardson wrote: The function "ice_alloc_lan_q_ctx" will be needed by the driver code, so make it non-static. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_sched.c | 2 +- drivers/net/ice/base/ice_sched.h | 3 +++ 2 f

Re: [PATCH v5 1/5] net/ice: add option to download scheduler topology

2024-10-25 Thread Medvedkin, Vladimir
Hi Bruce, On 23/10/2024 17:55, Bruce Richardson wrote: The DDP package file being loaded at init time may contain an alternative Tx Scheduler topology in it. Add driver option to load this topology at init time. Signed-off-by: Bruce Richardson --- doc/guides/nics/ice.rst| 15 +

[PATCH v3 0/5] dts: Pydantic configuration

2024-10-25 Thread Luca Vizzarro
Hi there, sending a v3 for the pydantic changes. v3: - removed the common FrozenModel and configured each BaseModel individually, due to mypy complaints v2: - rebased and merge conflicts resolved: - capabilities patch introducing TestCase has now been combined with TestSuiteSpec - exter

[PATCH v3 5/5] dts: use TestSuiteSpec class imports

2024-10-25 Thread Luca Vizzarro
The introduction of TestSuiteSpec adds auto-discovery of test suites, which are also automatically imported. This causes double imports as the runner loads the test suites. This changes the behaviour of the runner to load the imported classes from TestSuiteSpec instead of importing them again. Sig

[PATCH v2 6/6] build: limit scope of packed member warning disabling

2024-10-25 Thread Bruce Richardson
The flag '-Wno-address-of-packed-member' is a global warning flag in DPDK. Rather than disabling this warning globally, it is better to just have it enabled for components that may need it. This patch limits the scope of it in the following ways: * limit the use of the flag to the drivers subfolde

Re: [PATCH 0/6] Reduce scope address-of-packed-member warning

2024-10-25 Thread Bruce Richardson
On Fri, Oct 25, 2024 at 04:55:08PM +0200, David Marchand wrote: > On Fri, Oct 25, 2024 at 3:24 PM David Marchand > wrote: > > > > On Thu, Oct 17, 2024 at 4:22 PM Bruce Richardson > > wrote: > > > > > > The warning for address-of-packed-member was being disabled globally in > > > DPDK. While for

[PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-25 Thread Bruce Richardson
There are multiple instances in the DPDK app folder where we set up an IP header and then compute the checksum field by direct addition of nine uint16_t values in the header (20 bytes less the cksum field). The existing rte_ip.h checksum function is more general than necessary here and requires tha

[PATCH v2 4/6] pipeline: remove packed attribute

2024-10-25 Thread Bruce Richardson
The rte_trtcm_data structure, and its substructures, only consist of uint64_t types. This makes packing unnecessary to remove the packed attribute from the structure. Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/pipeline/rte_table_action.c | 2 +-

[PATCH v2 3/6] bus/ifpga: remove packed attribute

2024-10-25 Thread Bruce Richardson
The struct rte_afu_device does not need to be packed, so remove the packed attribute from it. Signed-off-by: Bruce Richardson Acked-by: Rosen Xu Acked-by: Stephen Hemminger Acked-by: Morten Brørup --- drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 2/6] efd: remove unnecessary packed attributes

2024-10-25 Thread Bruce Richardson
The structure "efd_online_group_entry" only consists of values which are typedefs of "uint16_t", so packing the structure has no effect. The "efd_online_chunk" structure has a mix of "uint8_t" and the "efd_online_group_entry" struct, i.e. uint16_t values, but since the first, uint8_t, member array

[PATCH v2 0/6] Reduce scope address-of-packed-member warning

2024-10-25 Thread Bruce Richardson
The warning for address-of-packed-member was being disabled globally in DPDK. While for drivers which need to access hardware-defined data-structures the use of packed may make sense, for normal libs and applications the use of packed data should be generally avoided. This patchset initially appl

[PATCH v2 1/6] ip_frag: remove use of unaligned variable

2024-10-25 Thread Bruce Richardson
If compiling with -Waddress-of-packed-member, we get a warning about the use of the unaligned uint64_t value which is used to copy 8 bytes from ip_hdr to the key. Replace this unaligned assignment with an equivalent 8-byte constant-sized memcpy, allowing the compiler to choose optimal instructions

[PATCH v3 4/5] dts: remove warlock dependency

2024-10-25 Thread Luca Vizzarro
Since pydantic has completely replaced warlock, there is no more need to keep it as a dependency. This removes it. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.lock| 227 + dts/pyproject.toml | 1 - 2 files changed, 1

[PATCH v3 3/5] dts: use pydantic in the configuration

2024-10-25 Thread Luca Vizzarro
This change brings in pydantic in place of warlock. Pydantic offers a built-in model validation system in the classes, which allows for a more resilient and simpler code. As a consequence of this change: - most validation is now built-in - further validation is added to verify: - cross referenci

[PATCH v3 2/5] dts: add TestSuiteSpec class and discovery

2024-10-25 Thread Luca Vizzarro
Currently there is a lack of a definition which identifies all the test suites available to test. This change intends to simplify the process to discover all the test suites and idenfity them. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/runner.py

[PATCH v3 1/5] dts: add pydantic dependency

2024-10-25 Thread Luca Vizzarro
As part of configuration validation and deserialization improvements, this adds pydantic as a project dependency. Pydantic is a library that caters to all of the aforementioned needs, while improving the process and code. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.

[PATCH v2 1/5] dts: add pydantic dependency

2024-10-25 Thread Luca Vizzarro
As part of configuration validation and deserialization improvements, this adds pydantic as a project dependency. Pydantic is a library that caters to all of the aforementioned needs, while improving the process and code. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.

[PATCH v2 5/5] dts: use TestSuiteSpec class imports

2024-10-25 Thread Luca Vizzarro
The introduction of TestSuiteSpec adds auto-discovery of test suites, which are also automatically imported. This causes double imports as the runner loads the test suites. This changes the behaviour of the runner to load the imported classes from TestSuiteSpec instead of importing them again. Sig

[PATCH v2 4/5] dts: remove warlock dependency

2024-10-25 Thread Luca Vizzarro
Since pydantic has completely replaced warlock, there is no more need to keep it as a dependency. This removes it. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.lock| 227 + dts/pyproject.toml | 1 - 2 files changed, 1

[PATCH v2 3/5] dts: use pydantic in the configuration

2024-10-25 Thread Luca Vizzarro
This change brings in pydantic in place of warlock. Pydantic offers a built-in model validation system in the classes, which allows for a more resilient and simpler code. As a consequence of this change: - most validation is now built-in - further validation is added to verify: - cross referenci

[PATCH v2 2/5] dts: add TestSuiteSpec class and discovery

2024-10-25 Thread Luca Vizzarro
Currently there is a lack of a definition which identifies all the test suites available to test. This change intends to simplify the process to discover all the test suites and idenfity them. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/runner.py

[PATCH v2 0/5] dts: Pydantic configuration

2024-10-25 Thread Luca Vizzarro
Hi there, sending a v2 for the pydantic changes. v2: - rebased and merge conflicts resolved: - capabilities patch introducing TestCase has now been combined with TestSuiteSpec - external build patch added more configuration complexity which has been re-worked in pydantic adding exclus

Re: [PATCH 8/8] net/cnxk: handle RSS action for representees

2024-10-25 Thread Jerin Jacob
On Wed, Oct 23, 2024 at 9:10 PM Harman Kalra wrote: > > Flows installed via single queue'd port representors on behalf of > multiple queue'd gets installed as unicast flows, causing representee > application to loose RSS advantage. Handling the scenario by > appending a RSS action to flow action l

[PATCH v7 22/22] event/cnxk: add CN20K timer adapter

2024-10-25 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer adapter support for CN20K platform. Implement new HWWQE insertion feature supported by CN20K platform. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_tim.c| 6 +- drivers/event/cnxk/cn20k_eventdev.c | 16 ++- drivers/event/cnxk/cn20

  1   2   3   4   >