[PATCH v28 03/13] windows: update os shim

2024-10-24 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Use rte_os_shim.h in lib/log instead of redefine of strdup. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng ---

Re: [PATCH v5 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc

2024-10-24 Thread Jerin Jacob
On Thu, Oct 24, 2024 at 7:00 PM Akhil Goyal wrote: > For all patches, please change subject to raw/cnxk_rvu_lf: support ... > + > +#include > + > +/** > + * @file cnxk_rvu_lf_driver.h > + * > + * Marvell RVU LF raw PMD specific structures and interface > + * > + * This API allows external dri

[PATCH v4 10/18] net/r8169: add link status and interrupt management

2024-10-24 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 5 +- drivers/net/r8169/r8169_ethdev.c | 278 ++- drivers/net/r8169/r8169_ethdev.h | 3 + drivers/net/r8169/r8169_hw.c | 8 +- drivers/net/r8169/r8169_hw.h | 3 + drivers/net/r8169/r8169_

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-24 Thread Dmitry Kozlyuk
2024-10-24 23:54 (UTC+0300), Dmitry Kozlyuk: > 2024-10-24 09:38 (UTC-0700), Stephen Hemminger: > > Having a process set a system global value like coredump_filter via an > > internal > > call seems like a potential problem. What about other processes on the > > system? > > It may not even be allo

Re: [PATCH v4 01/22] event/cnxk: use stdatomic API

2024-10-24 Thread Jerin Jacob
On Wed, Oct 23, 2024 at 1:05 AM wrote: > > From: Pavan Nikhilesh > > Replace gcc inbuilt __atomic_xxx intrinsics with rte_atomic_xxx API. > > Signed-off-by: Pavan Nikhilesh > --- > Depends-on: series-33602 ("event/cnxk: fix getwork write data on reconfig") Some reason CI not ran due to this dep

Re: [PATCH] event/cnxk: fix getwork write data on reconfig

2024-10-24 Thread Jerin Jacob
On Tue, Oct 22, 2024 at 9:29 PM wrote: > > From: Pavan Nikhilesh > > Update getwork write data on device reconfiguration > to avoid working with stale configuration. > > Fixes: acc65ee307f7 ("eventdev: introduce event pre-scheduling") > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net-

RE: [PATCH v4] ethdev: TEST support single queue per port

2024-10-24 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 24 October 2024 18.42 > > On Thu, 24 Oct 2024 14:55:50 + > Morten Brørup wrote: > > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > > index 1f7c0d77d5..f34a953ecd 100644 > > ---

Re: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share()

2024-10-24 Thread Bruce Richardson
On Tue, Oct 22, 2024 at 09:16:55AM -0700, Stephen Hemminger wrote: > On Tue, 22 Oct 2024 09:42:05 -0500 > l...@perftech.com wrote: > > > From: Lewis Donzis > > > > Forcing wait true prevents checking link status without delay, because the > > function will wait more than 10 seconds for link sta

[PATCH v3 1/6] vhost: fix VDUSE device creation error handling

2024-10-24 Thread Maxime Coquelin
This patch fixes missing reconnection log unmapping miss in the error path at VDUSE creation time. Coverity issue: 445525 Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE") Signed-off-by: Maxime Coquelin --- lib/vhost/vduse.c | 27 +++ 1 file changed, 15 in

[PATCH v2] net/ice: fix incorrect reading of PHY timestamp

2024-10-24 Thread Soumyadeep Hore
In ICE PMD, previously the ready bitmap checking before reading PHY timestamp was not present. This caused incorrect Tx timestamping. The ready bitmap checking is enabled and PHY timestamp is read once the ready bitmap gives positive value. Fixes: 881169950d80 ("net/ice/base: implement initial PT

Re: [PATCH v3] bus/pci: don't open uio device in secondary process

2024-10-24 Thread David Marchand
On Fri, Oct 11, 2024 at 1:17 PM Konrad Sztyber wrote: > > The uio_pci_generic driver clears the bus master bit when the device > file is closed. So, when the secondary process terminates after probing > a device, that device becomes unusable in the primary process. > > To avoid that, the device fi

[PATCH 3/6] common/dpaax: use prefetch macros

2024-10-24 Thread David Marchand
Prefer EAL macros over __builtin_ helpers. Signed-off-by: David Marchand --- drivers/common/dpaax/compat.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/common/dpaax/compat.h b/drivers/common/dpaax/compat.h index cbabc1588b..7c8d82c2b2 100644 --- a/drivers/com

[PATCH v4 17/18] net/r8169: add driver_start and driver_stop

2024-10-24 Thread Howard Wang
rtl8125ap and rtl8125bp need driver start and stop whether dash is enabled or not. Signed-off-by: Howard Wang --- drivers/net/r8169/base/rtl8126a_mcu.h | 1 + drivers/net/r8169/r8169_base.h| 6 +- drivers/net/r8169/r8169_dash.c| 149 +- drivers/net/r81

[PATCH v4 15/18] net/r8169: implement MTU configuration

2024-10-24 Thread Howard Wang
Add support for updating MTU value. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index 3c3a302e8b..b569160172 100644 --- a/drivers/net/

[PATCH v4 04/18] net/r8169: implement core logic for Tx/Rx

2024-10-24 Thread Howard Wang
Add RX/TX function prototypes for further datapath development. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_ethdev.c | 17 ++ drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_rxtx.c | 56 ++

[PATCH v4 09/18] net/r8169: add support for hw initialization

2024-10-24 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 43 +++ drivers/net/r8169/r8169_dash.c | 88 + drivers/net/r8169/r8169_dash.h | 33 ++ drivers/net/r8169/r8169_ethdev.c | 47 ++- drivers/net/r8169/r8169_ethdev.h | 30 +- driv

Re: [PATCH v12 3/3] examples/l3fwd-power: add PM QoS configuration

2024-10-24 Thread lihuisong (C)
在 2024/10/25 0:44, Konstantin Ananyev 写道: The '--cpu-resume-latency' can use to control C-state selection. Setting the CPU resume latency to 0 can limit the CPU just to enter C0-state to improve performance, which also may increase the power consumption of platform. Signed-off-by: Huisong Li

[PATCH v4 18/18] doc/guides/nics: add documents for r8169 pmd

2024-10-24 Thread Howard Wang
Signed-off-by: Howard Wang --- MAINTAINERS| 2 ++ doc/guides/nics/features/r8169.ini | 32 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/r8169.rst | 17 4 files changed, 52 insertions(+) create mode 10

[PATCH v4 16/18] net/r8169: add support for getting fw version

2024-10-24 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index b569160172..6fc3b557bd 100644 --- a/drivers/net/r8169/r8169_ethdev.c +++ b/drivers/ne

[PATCH v4 13/18] net/r8169: implement device statistics

2024-10-24 Thread Howard Wang
Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 16 +++ drivers/net/r8169/r8169_ethdev.c | 48 +++ drivers/net/r8169/r8169_ethdev.h | 3 ++ drivers/net/r8169/r8169_hw.c | 80 drivers/net/r8169/r8169_hw.h | 6 +++ 5 f

[PATCH v4 14/18] net/r8169: implement promisc and allmulti modes

2024-10-24 Thread Howard Wang
Add support for promiscuous/allmulticast modes configuration. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 67 1 file changed, 67 insertions(+) diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c index 2d907a1e81

[PATCH v4 11/18] net/r8169: implement Rx path

2024-10-24 Thread Howard Wang
Add implementation for RX datapath. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_base.h | 24 + drivers/net/r8169/r8169_ethdev.c | 76 ++- drivers/net/r8169/r8169_ethdev.h | 18 + drivers/net/r8169/r8169_rxtx.c | 781 ++- 4 files changed, 896 insertio

[PATCH v4 12/18] net/r8169: implement Tx path

2024-10-24 Thread Howard Wang
Add implementation for TX datapath. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 6 + drivers/net/r8169/r8169_ethdev.h | 11 + drivers/net/r8169/r8169_rxtx.c | 683 ++- 3 files changed, 684 insertions(+), 16 deletions(-) diff --git a/drivers

[PATCH v4 08/18] net/r8169: add support for phy configuration

2024-10-24 Thread Howard Wang
This patch contains phy config, ephy config and so on. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 10 + drivers/net/r8169/r8169_ethdev.h | 6 + drivers/net/r8169/r8169_phy.c| 448 +++ drivers/net/r8169/r8169_phy.h| 100 +++ 4 file

[PATCH v4 05/18] net/r8169: add support for hw config

2024-10-24 Thread Howard Wang
Implement the rtl_hw_config function to configure the hardware. Signed-off-by: Howard Wang --- drivers/net/r8169/meson.build| 1 + drivers/net/r8169/r8169_base.h | 125 ++ drivers/net/r8169/r8169_ethdev.c | 2 + drivers/net/r8169/r8169_ethdev.h | 15 +- drivers/net/r8169/r8169_hw.

[PATCH v4 02/18] net/r8169: add logging structure

2024-10-24 Thread Howard Wang
Implement logging macros for debug purposes. Signed-off-by: Howard Wang --- drivers/net/r8169/r8169_ethdev.c | 9 +++ drivers/net/r8169/r8169_logs.h | 46 2 files changed, 55 insertions(+) create mode 100644 drivers/net/r8169/r8169_logs.h diff --git a/dr

[PATCH v4 01/18] net/r8169: add PMD driver skeleton

2024-10-24 Thread Howard Wang
Meson build infrastructure, r8169_ethdev minimal skeleton, header with Realtek NIC device and vendor IDs. Signed-off-by: Howard Wang --- MAINTAINERS | 7 ++ drivers/net/meson.build | 1 + drivers/net/r8169/meson.build| 6 ++ drivers/net/r8169/r8169_base.h

[PATCH v4 00/18] Modify code as suggested by the maintainer.

2024-10-24 Thread Howard Wang
Some small things. Howard Wang (18): net/r8169: add PMD driver skeleton net/r8169: add logging structure net/r8169: add hardware registers access routines net/r8169: implement core logic for Tx/Rx net/r8169: add support for hw config net/r8169: add phy registers access routines net/r

Re: [PATCH] mbuf: add transport mode ESP packet type

2024-10-24 Thread Ajit Khaparde
On Thu, Oct 24, 2024 at 12:30 PM Alexander Kozyrev wrote: > > >>And we definitely need RTE_PTYPE_INNER_L4_ESP for ESP over UDP support. > >Isn't this already taken care when mbuf->packet_type = > >(RTE_PTYPE_L4_UDP | RTE_PTYPE_TUNNEL_ESP) ? > > This is ambigous. And both UDP and ESP are L4 headers

Re: [PATCH] dts: fix doxygen API link

2024-10-24 Thread Paul Szczepanek
On 24/10/2024 10:12, David Marchand wrote: >> >> Looking again while applying, something is fishy in doc/api/meson.build: >> >> if not doxygen.found() >> # process DTS API doc build even if DPDK API doc build can't be done >> cdata = configuration_data() >> subdir('dts') >> subdir_done() >>

RE: [PATCH] ethdev: fix link with C++

2024-10-24 Thread Morten Brørup
Acked-by: Morten Brørup

[PATCH v28 01/13] maintainers: add for log library

2024-10-24 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINE

[PATCH v14 00/12] drivers/zsda: introduce zsda drivers

2024-10-24 Thread Hanxiao Li
v14: - Uniform Byte Alignment. v13: - resolve some comiler warnings that are being suppressed. v12: - use RTE_LOG_LINE_PREFIX in logging macro. - delete the check for null with rte_mempool_free. - delete some unused initial values. v11: - use RTE_LOG_LINE in logging macro. - fix some known bugs.

Re: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Bruce Richardson
On Thu, Oct 24, 2024 at 06:28:27PM +0200, Morten Brørup wrote: > > > > - for (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) { > > > > + for (i = 0; i < RTE_MIN(IXGBE_QUEUE_STAT_COUNTERS, > > > > + > > > > (typeof(IXGBE_QUEUE_STAT_COUNTERS))RTE_ETHDEV_QUEUE_STAT_CNTRS); > > > > i++)

[PATCH v28 05/13] eal: do not duplicate rte_init_alert() messages

2024-10-24 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/

[PATCH v28 09/13] log: add hook for printing log messages

2024-10-24 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

[PATCH v28 13/13] doc: add release note about log library

2024-10-24 Thread Stephen Hemminger
Significant enough to add some documentation. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- doc/guides/rel_notes/release_24_11.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/guides/rel_notes/re

[PATCH v28 02/13] windows: make getopt functions have const properties

2024-10-24 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v7] ethdev: TEST support single queue per port

2024-10-24 Thread Morten Brørup
Configuring one queue per port (#define RTE_MAX_QUEUES_PER_PORT 1) fails compilation with e.g.: ../drivers/net/bnxt/bnxt_rxq.c: In function 'bnxt_rx_queue_stop': ../drivers/net/bnxt/bnxt_rxq.c:587:34: error: array subscript 1 is above array bounds of 'uint8_t[1]' {aka 'unsigned char[1]'} [-Werror

[PATCH v28 00/13] Logging subsystem improvements

2024-10-24 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

[PATCH v28 10/13] log: add timestamp option

2024-10-24 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

Re: [PATCH] mbuf: add transport mode ESP packet type

2024-10-24 Thread Alexander Kozyrev
>>And we definitely need RTE_PTYPE_INNER_L4_ESP for ESP over UDP support. >Isn't this already taken care when mbuf->packet_type = >(RTE_PTYPE_L4_UDP | RTE_PTYPE_TUNNEL_ESP) ? This is ambigous. And both UDP and ESP are L4 headers, which can lead to the undefined behavior when we specify both of the

[PATCH v28 12/13] log: colorize log output

2024-10-24 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. The default is to not use color since it may disturb automatic tests and other embedded us

Re: [PATCH v2] net/ixgbe: support per-queue stats for fewer queues

2024-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2024 18:53:52 + Morten Brørup wrote: > Remove the requirement that the configured number of queues to provide > statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the > driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS). > > Signed-off-by: Mort

[PATCH v28 07/13] log: rework syslog handling

2024-10-24 Thread Stephen Hemminger
Refactor how syslog is handled, make it common to Linux and FreeBSD The syslog facility property is better handled in lib/log rather than in eal. This also add syslog support to FreeBSD. Log to syslog only if option is specified. If no --syslog is given then use console only. Signed-off-by: Steph

RE: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Morten Brørup
Forgot the --in-reply-to, so here's the link to the V2 patch: https://inbox.dpdk.org/dev/20241024185352.987356-1...@smartsharesystems.com/

[PATCH v28 04/13] eal: make eal_log_level_parse common

2024-10-24 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/common/eal_options.h

Re: [PATCH v4 1/4] thash: add RSS hash key generation API

2024-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2024 18:46:53 + Vladimir Medvedkin wrote: > Currently the only way to have non static Toeplitz hash key is to > generate it randomly. Such a key may not guarantee good packets > distribution, especially if there are small number of flows. > > This patch adds stub implementatio

[PATCH v2] net/ixgbe: support per-queue stats for fewer queues

2024-10-24 Thread Morten Brørup
Remove the requirement that the configured number of queues to provide statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS). Signed-off-by: Morten Brørup --- v2: * Fix subject. (Bruce Richardson) * Simplify type

[PATCH v4 4/4] test/thash: add tests for RSS key generation API

2024-10-24 Thread Vladimir Medvedkin
This patch adds tests for RSS key generation. In this test we measure distribution of hash LSBs for a given random tuple where only some part of bits is variable. At first we generate random hash key and measure the worst distribution for a given ReTa size value (RETA_SZ_LOG). Then we adjust the k

[PATCH v4 3/4] hash: implement RSS hash key generation API

2024-10-24 Thread Vladimir Medvedkin
This patch implements Toeplitz hash key generation function using the new polynomial generation function. Signed-off-by: Vladimir Medvedkin --- doc/guides/rel_notes/release_24_11.rst | 3 +++ lib/hash/rte_thash.c | 23 ++- 2 files changed, 21 insertions(+),

[PATCH v4 2/4] hash: add dynamic polynomial calculation

2024-10-24 Thread Vladimir Medvedkin
Current polynomial table has the following limitations: 1. It has polynomials up to degree 16 2. For each degree there are only 4 polynomials The above results in less entropy when generating Toeplitz hash key subsequences. This patch replaces the current static table approach with dynamic polyn

[PATCH v4 0/4] RSS hash key generation

2024-10-24 Thread Vladimir Medvedkin
Currently there are 2 methods to get the RSS hash key. The first method is to randomly generate it. The second one is to use well known RSS hash keys. Both methods have drawbacks. The first method not always provides a good hash distribution. The second one does, but not for all ReTa sizes and not

[PATCH v4 5/5] net/mlx5: implement jump to table index action

2024-10-24 Thread Alexander Kozyrev
Implement RTE_FLOW_ACTION_TYPE_JUMP_TO_TABLE_INDEX action. Create the hardware steering jump to matcher action, associated with the template matcher. Use this action and provide the rule index as an offset in the matcher. Note that it is only supported by the isolated matcher, i.e. the table insert

[PATCH v4 2/5] net/mlx5/hws: introduce jump to matcher action

2024-10-24 Thread Alexander Kozyrev
From: Hamdan Igbaria Introduce jump to matcher action, this action will allow jumping to another matcher. For now this jump restricted to STE array matchers and matchers of size 1. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5/hws/mlx5

[PATCH v4 4/5] net/mlx5: add flow rule insertion by index with pattern

2024-10-24 Thread Alexander Kozyrev
Implement rte_flow_async_create_by_index_with_pattern() function. Rework the driver implementation to reduce code duplication by providing a single flow insertion routine, that can be called with different parameters depending on the insertion type. Signed-off-by: Alexander Kozyrev --- doc/guide

[PATCH v4 0/5] jump to table index support in mlx5

2024-10-24 Thread Alexander Kozyrev
Support the new Flow API JUMP_TO_TABLE_INDEX action in mlx5. Seried-acked-by: Dariusz Sosnowski Alexander Kozyrev (3): net/mlx5: create array ste matcher net/mlx5: add flow rule insertion by index with pattern net/mlx5: implement jump to table index action Hamdan Igbaria (2): net/mlx5/h

[PATCH 2/4] crypto/dpaa_sec: enabling diffserv and ECN support

2024-10-24 Thread Hemant Agrawal
Enabling DIFFSERV and ECN in IPSEC proto offload descriptor. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 14 -- drivers/crypto/dpaa_sec/dpaa_sec.h | 8 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_se

Re: [PATCH v2 0/7] DTS external DPDK build

2024-10-24 Thread Dean Marx
Ah okay, that makes sense. Yes I'll review that ASAP On Tue, Oct 22, 2024 at 10:56 AM Luca Vizzarro wrote: > On 21/10/2024 23:39, Dean Marx wrote: > > Hi Luca, > > > > I noticed in the new version of this series the "improve statistics" > > patch was taken out, was there any reason for this? I b

Re: [PATCH v4 22/42] net/af_xdp: use rte strerror

2024-10-24 Thread Maryam Tahhan
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Maryam Tahhan

Re: [PATCH] MAINTAINERS: add maintainer for next-net-intel tree

2024-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2024 15:51:22 +0100 Bruce Richardson wrote: > For last two releases, I have been committer for the next-net-intel > tree, so update the details in MAINTAINERS file to reflect that fact. > > Signed-off-by: Bruce Richardson > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(

Re: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2024 11:17:57 + Morten Brørup wrote: > Remove the requirement that the configured number of queues to provide > statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the > driver's max supported number of the same (IXGBE_QUEUE_STAT_COUNTERS). > > Signed-off-by: Mort

Re: [PATCH v4] ethdev: TEST support single queue per port

2024-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2024 14:55:50 + Morten Brørup wrote: > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 1f7c0d77d5..f34a953ecd 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -842,6 +842,8 @@ static int bnxt_alloc_pr

RE: [PATCH v12 2/3] examples/l3fwd-power: fix data overflow when parse command line

2024-10-24 Thread Konstantin Ananyev
> Many variables are 'uint32_t', like, 'pause_duration', 'scale_freq_min' > and so on. They use parse_int() to parse it from command line. > But overflow problem occurs when this function return. > > Fixes: 59f2853c4cae ("examples/l3fwd_power: add configuration options") > Cc: sta...@dpdk.org >

RE: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Morten Brørup
> > > - for (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) { > > > + for (i = 0; i < RTE_MIN(IXGBE_QUEUE_STAT_COUNTERS, > > > + > > > (typeof(IXGBE_QUEUE_STAT_COUNTERS))RTE_ETHDEV_QUEUE_STAT_CNTRS); > > > i++) { > > The big cast using "typeof" is awkward-looking but is probably the best > way > to

Re: [PATCH v5 9/9] raw/cnxk_rvu_lf: add selftest

2024-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2024 18:47:59 +0530 Akhil Goyal wrote: > Added raw device selftest for cnxk_rvu_lf to verify > various PMD APIs. > > Signed-off-by: Akhil Goyal Missing include of rte_common.h?? ---BEGIN LOGS ##

Re: [PATCH v1 1/3] uapi: introduce kernel uAPI headers import

2024-10-24 Thread Stephen Hemminger
On Thu, 24 Oct 2024 14:45:10 +0200 Maxime Coquelin wrote: > >> > >> > >> Rather than copy-pasting headers_install.sh, could you use it directly? > >> > >> The copy/paste from GPL-2.0 concerns me. > >> And the potential upstream change as well. > >> > > > > The downside I see by calling directl

RE: [EXTERNAL] Re: [PATCH] common/cnxk: allow enabling IOVA field in mbuf

2024-10-24 Thread Shijith Thotton
>On Thu, Oct 24, 2024 at 04:40:40PM +0530, Jerin Jacob wrote: >> On Mon, Oct 14, 2024 at 4:37 PM Shijith Thotton >wrote: >> > >> > Value of RTE_IOVA_IN_MBUF was always disabled on cnxk platforms, as >IOVA >> > in the mbuf is not required. This change modifies that behavior, >> > allowing RTE_IOVA_

[PATCH v4] ethdev: TEST support single queue per port

2024-10-24 Thread Morten Brørup
Configuring one queue per port fails compilation on my system. Test to see how much it fails in CI. Signed-off-by: Morten Brørup --- v4: * Workaound GCC optimizer incorrectly throwing a warning in these network drivers: * bnxt * e1000 * failsafe * hns3 v3: * Fix net/ixgbe driver. v2: *

Re: [PATCH] net/ixgbe: fix per-queue stats for less queues

2024-10-24 Thread Bruce Richardson
On Thu, Oct 24, 2024 at 05:15:10PM +0200, Morten Brørup wrote: > Forwarding to the now official maintainers for review. :-) > > Thank you for updating the MAINTAINERS file, Bruce. > > PS: Please correct "fix"->"support" in the subject when merging, it was a > typo. > > > From: Morten Brørup [ma

[PATCH v5] ethdev: TEST support single queue per port

2024-10-24 Thread Morten Brørup
Configuring one queue per port fails compilation on my system. Test to see how much it fails in CI. Signed-off-by: Morten Brørup --- v5: * Wrap GCC optimizer pragmas in if defined(RTE_TOOLCHAIN_GCC). v4: * Workaound GCC optimizer incorrectly throwing a warning in these network drivers: * bnxt

[PATCH v3 1/5] net/mlx5/hws: introduce new matcher type

2024-10-24 Thread Alexander Kozyrev
From: Hamdan Igbaria introduce STE array matcher, where this matcher can only be isolated under a parent table and not chained to the table matchers chain. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr.h | 13 +- drivers/net/mlx5/hws/mlx5dr_debug.c | 12 +- dr

[PATCH v3 4/5] net/mlx5: add flow rule insertion by index with pattern

2024-10-24 Thread Alexander Kozyrev
Implement rte_flow_async_create_by_index_with_pattern() function. Rework the driver implementation to reduce code duplication by providing a single flow insertion routine, that can be called with different parameters depending on the insertion type. Signed-off-by: Alexander Kozyrev --- doc/guide

[PATCH v3 2/5] net/mlx5/hws: introduce jump to matcher action

2024-10-24 Thread Alexander Kozyrev
From: Hamdan Igbaria Introduce jump to matcher action, this action will allow jumping to another matcher. For now this jump restricted to STE array matchers and matchers of size 1. Signed-off-by: Hamdan Igbaria --- drivers/net/mlx5/hws/mlx5dr.h| 29 ++ drivers/net/mlx5/hws/mlx5

[PATCH dpdk 2/2] net/ipv6: fix out-of-bounds read

2024-10-24 Thread Robin Jarry
Fix the following out-of-bounds read in rte_ipv6_addr_mask() reported by Coverity: 83 static inline void 84 rte_ipv6_addr_mask(struct rte_ipv6_addr *ip, uint8_t depth) 85 { 1. Condition depth < 128 /* 16 * 8 */, taking true branch. 2. cond_at_most: Checking depth < 128 implies that d

[PATCH dpdk 0/2] IPv6: Fix coverity issues

2024-10-24 Thread Robin Jarry
Hi all, Here are fixes for three coverity issues: /lib/net/rte_ip6.h: 91 in rte_ipv6_addr_mask() *** CID 446754: Memory - illegal accesses (OVERRUN) 85 { 86 if (depth < RTE_IPV6_MAX_DEPTH) { 87 uint8_t d = depth / 8; 88 uint8_t mask = ~(UI

[PATCH] MAINTAINERS: add maintainers for Intel NIC drivers

2024-10-24 Thread Bruce Richardson
The ixgbe, i40e, iavf and ice NIC drivers are all actively maintained and receiving updates. Add official maintainer names for these drivers in the MAINTAINERS file. Signed-off-by: Bruce Richardson --- MAINTAINERS | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/MAINTA

[PATCH 4/4] crypto/dpaa2_sec: add support for IPv6 UDP encap

2024-10-24 Thread Hemant Agrawal
This patch enables support for NAT-T traversal in IPSEC ESP protocol offload mode for IPv6 Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 68 + 1 file changed, 43 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_

[PATCH 3/4] crypto/dpaa_sec: add support for UDP-encapsulated ESP

2024-10-24 Thread Hemant Agrawal
From: Barry Cao This patch enables support for NAT-T traversal in IPSEC ESP protocol offload mode. Signed-off-by: Hemant Agrawal Signed-off-by: Barry Cao --- drivers/crypto/dpaa_sec/dpaa_sec.c | 63 -- drivers/crypto/dpaa_sec/dpaa_sec.h | 14 +++ 2 files change

RE: [RFC v2] ethdev: an API for cache stashing hints

2024-10-24 Thread Wathsala Wathawana Vithanage
> If we had a hwtopo API in DPDK, we could just use a node id in such a graph > (of CPUs and caches) to describe were the data ideally would land. > In such a case, you could have a node id for DDR as well, and thus you could > drop the notion of "stashing". Just a "drop off the data here, please,

RE: [PATCH 4/6] crypto/openssl: fix 3DES-CTR with big endian CPUs

2024-10-24 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 24 October 2024 15.30 > > On Thu, Oct 24, 2024 at 3:17 PM David Marchand > wrote: > > @@ -1209,14 +1195,16 @@ process_openssl_cipher_des3ctr(struct > rte_mbuf > > *mbuf_src, uint8_t *dst, > > l = rte_pktmbuf_data_

Tech Board Meeting Minutes - Sept. 23, 2024

2024-10-24 Thread Aaron Conole
Attendees - Aaron Conole Bruce Richardson David Marchand Hemant Agrawal Honnappa Nagarahalli Kevin Traynor Konstantin Ananyev Maxime Coquelin Morten Brorup Robin Jarry Stephen Hemminger Thomas Monjalon Notes - The Tech Board met at a f2f session in Montreal, prior to the DPDK Summi

[PATCH v5 7/9] raw/cnxk_rvu_lf: add API to get device pffunc

2024-10-24 Thread Akhil Goyal
Added ``rte_pmd_rvu_lf_pf_func_get`` API to get RVU LF device pffunc for the application use. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_rvu_lf.c | 2 +- drivers/common/cnxk/roc_rvu_lf.h | 2 ++ drivers/common/cnxk/version.map | 1 + drivers/r

[PATCH v5 0/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-24 Thread Akhil Goyal
CNXK product families can have a use case to allow PF and VF applications to communicate using mailboxes and also get notified of any interrupt that may occur on the device. Hence, a new raw device driver is added for such RVU LF devices. These devices can map to a PF or a VF which can send mailbox

[PATCH v5 9/9] raw/cnxk_rvu_lf: add selftest

2024-10-24 Thread Akhil Goyal
Added raw device selftest for cnxk_rvu_lf to verify various PMD APIs. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 18 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 4 +- drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.h | 2 + .../raw/cnxk_rvu_lf/cnxk_rvu

Re: [PATCH 4/6] crypto/openssl: fix 3DES-CTR with big endian CPUs

2024-10-24 Thread David Marchand
On Thu, Oct 24, 2024 at 2:55 PM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Thursday, 24 October 2024 14.06 > > > > Caught by code review. > > > > Don't byte swap unconditionally (assuming that CPU is little endian is > > wrong). Instead, convert f

[PATCH v5 1/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-24 Thread Akhil Goyal
CNXK product families can have a use case to allow PF and VF applications to communicate using mailboxes and also get notified of any interrupt that may occur on the device. Hence, a new raw device driver is added for such RVU LF devices. These devices can map to a PF or a VF which can send mailbox

[PATCH v4 1/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-24 Thread Akhil Goyal
CNXK product families can have a use case to allow PF and VF applications to communicate using mailboxes and also get notified of any interrupt that may occur on the device. Hence, a new raw device driver is added for such RVU LF devices. These devices can map to a PF or a VF which can send mailbox

[PATCH v5 8/9] raw/cnxk_rvu_lf: add API to get BAR addresses

2024-10-24 Thread Akhil Goyal
Added rte_pmd_rvu_lf_bar_get() API to get BAR address for application to configure hardware. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 7 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c| 24 drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_driver

[PATCH v5 6/9] raw/cnxk_rvu_lf: process mailbox message

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_process() to process mailbox messages between rvu_lf devices. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 ++ doc/guides/rel_notes/release_24_11.rst | 5 + drivers/common/cnxk/roc_dev.c| 118 ++

[PATCH v5 3/9] raw/cnxk_rvu_lf: register/unregister interrupt handler

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_irq_register() and rte_pmd_rvu_lf_irq_unregister() to register/unregister interrupt handlers for rvu lf raw device. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 drivers/common/cnxk/roc_rvu_lf.c | 26 +++ drive

[PATCH v5 5/9] raw/cnxk_rvu_lf: set message ID range

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_id_range_set() to set RVU mailbox message id range. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 12 drivers/common/cnxk/roc_mbox.h | 1 + drivers/common/cnxk/roc_rvu_lf.c | 30

Re: [PATCH 4/6] crypto/openssl: fix 3DES-CTR with big endian CPUs

2024-10-24 Thread David Marchand
On Thu, Oct 24, 2024 at 3:10 PM David Marchand wrote: > > There may be an alignment bug too; the way it is used in > > process_openssl_cipher_des3ctr(), "ctr" is not guaranteed to be uint64_t > > aligned. > > > > How about this instead: > > > > ctr_inc(void *ctr) > > { > > uint64_t ctr64

[PATCH v4 8/9] raw/cnxk_rvu_lf: add API to get BAR addresses

2024-10-24 Thread Akhil Goyal
Added rte_pmd_rvu_lf_bar_get() API to get BAR address for application to configure hardware. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 7 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c| 24 drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_driver

Re: [PATCH v2 1/1] dma/cnxk: support dma queue priority configuration

2024-10-24 Thread Jerin Jacob
On Mon, Oct 21, 2024 at 6:29 PM Vamsi Krishna wrote: > > From: Vamsi Attunuru > > Allow configuration of DPI DMA queue priority through > mailbox request. > > Signed-off-by: Vamsi Attunuru Please update the release note for this new feature in the PMD section.

Re: [PATCH] test/event: fix device stop

2024-10-24 Thread Jerin Jacob
On Tue, Oct 22, 2024 at 5:33 PM wrote: > > From: Pavan Nikhilesh > > Fix missing event device stop after finishing the > test case. > > Fixes: acc65ee307f7 ("eventdev: introduce event pre-scheduling") > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net-eventdev/for-main. Thanks

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-24 Thread Lewis Donzis
- On Oct 23, 2024, at 6:18 PM, Dmitry Kozlyuk dmitry.kozl...@gmail.com wrote: > Lewis, testing on FreeBSD would be appreciated. Well, unfortunately, it's not working very well... The contigmem memory was not included in the core dump. I added logging just before the madvise() call to pr

[PATCH v4 9/9] raw/cnxk_rvu_lf: add selftest

2024-10-24 Thread Akhil Goyal
Added raw device selftest for cnxk_rvu_lf to verify various PMD APIs. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 18 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 4 +- drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.h | 2 + .../raw/cnxk_rvu_lf/cnxk_rvu

[PATCH v4 5/9] raw/cnxk_rvu_lf: set message ID range

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_msg_id_range_set() to set RVU mailbox message id range. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 12 drivers/common/cnxk/roc_mbox.h | 1 + drivers/common/cnxk/roc_rvu_lf.c | 30

[PATCH v4 3/9] raw/cnxk_rvu_lf: register/unregister interrupt handler

2024-10-24 Thread Akhil Goyal
Added API rte_pmd_rvu_lf_irq_register() and rte_pmd_rvu_lf_irq_unregister() to register/unregister interrupt handlers for rvu lf raw device. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 8 drivers/common/cnxk/roc_rvu_lf.c | 26 +++ drive

  1   2   >