On 24/10/2024 10:12, David Marchand wrote:
>>
>> Looking again while applying, something is fishy in doc/api/meson.build:
>>
>> if not doxygen.found()
>>   # process DTS API doc build even if DPDK API doc build can't be done
>>   cdata = configuration_data()
>>   subdir('dts')
>>   subdir_done()
>> endif
>>
>> Should this cdata (unused afaics) object be removed too?

Yes, I'm removing this.

> 
> It seems there are more issues with the doc generation.
> 
> Looking at dpdk.org documentation (https://doc.dpdk.org/api/), there
> is a dead link to DTS at the bottom of the page:
> tests: [DTS]()

That's what the original patch addressed.

> 
> The documentation for dts should be generated to dpdk_build_root
> /doc/api/html/dts

Yes, my V2 will fix this and place dts inside API so the website docs work.

> And I think the link should be a relative one, like
> cdata.set('DTS_API_MAIN_PAGE', join_paths('dts', 'index.html'))
> 
> Please have a look.
> 

Thanks. Will send out V2 as soon as it clears local checks.

Reply via email to