RE: [RFC v3 2/2] ethdev: introduce the cache stashing hints API

2024-10-23 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Thursday, 24 October 2024 07.49 > > On Mon, Oct 21, 2024 at 7:23 AM Wathsala Vithanage > wrote: > > > > Extend the ethdev library to enable the stashing of different data > > objects, such as the ones listed below, into CPU caches directl

RE: Can DPDK AF_XDP PMD support macvlan driver in container?

2024-10-23 Thread Xiaohua Wang
How can I confirm this is a kernel problem? And I added some codes in xsk_configure to set xdp attach mode as " SKB_MODE", then the testpmd works fine in this test environment on p1p1 interface. So, could you add one option to set "xdp attach mode" in AF_XDP Options in next DPDK release? htt

[PATCH v27 14/14] doc: add release note about log library

2024-10-23 Thread Stephen Hemminger
Significant enough to add some documentation. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- doc/guides/rel_notes/release_24_11.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/guides/rel_notes/re

Re: [PATCH v4 00/42] replace strerror

2024-10-23 Thread huangdengdui
Hi, Stephen Hemminger On 2024/10/23 23:42, Stephen Hemminger wrote: > On Wed, 23 Oct 2024 16:28:10 +0800 > Dengdui Huang wrote: > >> The function strerror() is insecure in a multi-thread environment. >> It is better to use rte_strerror() instead of strerror(). >> In this patchset, only the libs

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-23 Thread Stephen Hemminger
On Thu, 24 Oct 2024 02:18:59 +0300 Dmitry Kozlyuk wrote: > --- a/lib/eal/common/eal_internal_cfg.h > +++ b/lib/eal/common/eal_internal_cfg.h > @@ -103,6 +103,8 @@ struct internal_config { > struct simd_bitwidth max_simd_bitwidth; > /**< max simd bitwidth path to use */ > size_t

Re:RE: Re:RE: [EXTERNAL] [PATCH] test/graph: fix graph autotest second test failure

2024-10-23 Thread Huichao Cai
There is a problem with deleting static nodes: the node ID is recorded using the global variable node_id, which is continuously increasing. If an intermediate node is deleted, the node ID will appear empty, which can introduce some problems, such as how to choose the node ID for cloning later

Re: [PATCH v1 1/1] net/octeon_ep: fix return code

2024-10-23 Thread Jerin Jacob
On Tue, Oct 15, 2024 at 1:09 PM Vamsi Krishna wrote: > > From: Vamsi Attunuru > > In the changeset 304ba46be396, a goto statement was > mistakenly added after a return statement. This patch > corrects the code by removing the erroneous return. > > Coverity issue: 445484 > Fixes: 304ba46be396 ("ne

Re: [RFC v3 2/2] ethdev: introduce the cache stashing hints API

2024-10-23 Thread Jerin Jacob
On Mon, Oct 21, 2024 at 7:23 AM Wathsala Vithanage wrote: > > Extend the ethdev library to enable the stashing of different data > objects, such as the ones listed below, into CPU caches directly > from the NIC. > > - Rx/Tx queue descriptors > - Rx packets > - Packet headers > - packet payloads >

Re: [PATCH v6 00/47] TruFlow update for Thor2

2024-10-23 Thread Ajit Khaparde
On Mon, Oct 21, 2024 at 1:14 AM Sriharsha Basavapatna wrote: > > This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. > > TruFlow(TF) is the software library that exposes CFA HW resources to > upper layer protocols or applications. This patch series implements the > tfc (tf_c

[PATCH v3 1/1] event/octeontx: resolve possible integer overflow

2024-10-23 Thread Hanumanth Pothula
The last argument passed to ssovf_parsekv() is an unsigned char*, but it is accessed as an integer. This can lead to an integer overflow. Hence, make ensure the argument is accessed as a char and for better error handling use strtol instead of atoi. Signed-off-by: Hanumanth Pothula --- v2: use

[PATCH v27 09/14] log: add hook for printing log messages

2024-10-23 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

[PATCH v27 12/14] log: add support for systemd journal

2024-10-23 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v27 13/14] log: colorize log output

2024-10-23 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. The default is to not use color since it may disturb automatic tests and other embedded us

[PATCH v27 10/14] log: modify syslog handling

2024-10-23 Thread Stephen Hemminger
Log to syslog only if option is specified. If no --syslog is given then use console only. Signed-off-by: Stephen Hemminger --- app/test/test_eal_flags.c | 16 +++ doc/guides/linux_gsg/linux_eal_parameters.rst | 27 doc/guides/prog_guide/log_lib.rst

[PATCH v27 11/14] log: add timestamp option

2024-10-23 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v27 08/14] eal: initialize log before everything else

2024-10-23 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v27 07/14] log: move handling of syslog facility out of eal

2024-10-23 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also add syslog support to FreeBSD. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_options.c | 53 ++-- lib

[PATCH v27 06/14] eal: change rte_exit() output to match rte_log()

2024-10-23 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v27 05/14] eal: do not duplicate rte_init_alert() messages

2024-10-23 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/

[PATCH v27 04/14] eal: make eal_log_level_parse common

2024-10-23 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/common/eal_options.h

[PATCH v27 03/14] windows: update os shim

2024-10-23 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Use rte_os_shim.h in lib/log instead of redefine of strdup. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng ---

[PATCH v27 01/14] maintainers: add for log library

2024-10-23 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINE

[PATCH v27 00/14] Log subsystem changes

2024-10-23 Thread Stephen Hemminger
Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of

[PATCH v3 14/73] net/ntnic: add item eth

2024-10-23 Thread Serhii Iliushyk
Add possibility to use RTE_FLOW_ITEM_TYPE_ETH Signed-off-by: Serhii Iliushyk --- doc/guides/nics/features/ntnic.ini| 1 + drivers/net/ntnic/include/hw_mod_backend.h| 23 +++ .../profile_inline/flow_api_profile_inline.c | 180 ++ 3 files changed, 204 insertions

[PATCH v3 18/73] net/ntnic: add item void

2024-10-23 Thread Serhii Iliushyk
Add possibility to use RTE_FLOW_ITEM_TYPE_VOID Signed-off-by: Serhii Iliushyk --- .../nthw/flow_api/profile_inline/flow_api_profile_inline.c| 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c b/drivers/net/ntnic/n

Re: [PATCH] eal: support including mapped memory in core dump

2024-10-23 Thread Stephen Hemminger
On Thu, 24 Oct 2024 02:18:59 +0300 Dmitry Kozlyuk wrote: > From: Dmitry Kozlyuk > > Commit d72e4042c5eb ("mem: exclude unused memory from core dump") > unconditionally excluded all hugepage memory managed by DPDK. > The rationale was to avoid overly large core dumps > generated from reserved (P

Re: Can DPDK AF_XDP PMD support macvlan driver in container?

2024-10-23 Thread Stephen Hemminger
On Wed, 23 Oct 2024 06:07:22 + Xiaohua Wang wrote: > eth_rx_queue_setup(): Set up rx queue, rx queue id: 0, xsk queue id: 0 > libbpf: elf: skipping unrecognized data section(8) .xdp_run_config > libbpf: elf: skipping unrecognized data section(9) xdp_metadata > libbpf: elf: skipping unrecogniz

Re: [PATCH v2] net/bnxt: fix issue reading sff8436 sfp eeproms

2024-10-23 Thread Ajit Khaparde
On Mon, Aug 12, 2024 at 3:34 AM Peter Morrow wrote: > > From: Peter Morrow > > If a SFP which supports SFF-8436 is present then > currently the DDM information present in the eeprom > is not read. Furthermore bnxt_get_module_eeprom() > will return -EINVAL for these eeproms since the > length of t

Re: [PATCH v10] examples/ptp: replace terms master and slave

2024-10-23 Thread Ajit Khaparde
On Tue, Oct 22, 2024 at 10:26 AM Ajit Khaparde wrote: > > On Tue, Oct 22, 2024 at 9:39 AM Stephen Hemminger > wrote: > > > > On Fri, 14 Jun 2024 08:41:07 -0700 > > Stephen Hemminger wrote: > > > > > Remove one of the few remaining uses of master/slave. > > > > > > The IEEE 1588 standard has been

[PATCH v3 46/73] net/ntnic: add MAC Tx module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Media Access Control Transmit module contains counters that keep track on transmitted packets. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 38 ++- .../ntnic/nthw/supported/nthw_fpga_mod_defs.h | 3 +- .

[PATCH v3 33/73] net/ntnic: add FLM module

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 42 ++

[PATCH v3 58/73] net/ntnic: add tsm module

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov tsm module which operate with timers in the physical nic was added. Necessary defines and implementation were added. The Time Stamp Module controls every aspect of packet timestamping, including time synchronization, time stamp format, PTP protocol, etc. Signed-off-by:

[PATCH v3 54/73] net/ntnic: add statistics API

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Statistics init, setup, get, reset APIs and their implementation were added. Statistics fpga defines were added. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 29 +- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 192 +

[PATCH v3 12/73] net/ntnic: add ation jump

2024-10-23 Thread Serhii Iliushyk
Add possibility to use RTE_FLOW_ACTION_TYPE_JUMP Signed-off-by: Serhii Iliushyk --- doc/guides/nics/features/ntnic.ini | 1 + .../profile_inline/flow_api_profile_inline.c| 17 + 2 files changed, 18 insertions(+) diff --git a/doc/guides/nics/features/ntnic.ini

[PATCH v3 15/73] net/ntnic: add item IPv4

2024-10-23 Thread Serhii Iliushyk
Add possibility to use RTE_FLOW_ITEM_TYPE_IPV4 Signed-off-by: Serhii Iliushyk --- doc/guides/nics/features/ntnic.ini| 1 + .../profile_inline/flow_api_profile_inline.c | 162 ++ 2 files changed, 163 insertions(+) diff --git a/doc/guides/nics/features/ntnic.ini b/

[PATCH v3 61/73] net/ntnic: add xstats

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Extended statistics implementation and initialization were added. eth_dev_ops api was extended with new xstats apis. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 1 + drivers/net/ntnic/include/ntnic_stat.h| 36 + drive

[PATCH v3 23/73] net/ntnic: add items IPv6 and ICMPv6

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Add possibility to use * RTE_FLOW_ITEM_TYPE_IPV6 * RTE_FLOW_ITEM_TYPE_ICMP6 Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 2 + drivers/net/ntnic/include/hw_mod_backend.h| 2 + drivers/net/ntnic/nthw/flow_api/flow_api.c|

[PATCH v3 55/73] net/ntnic: add rpf module

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov The Receive Port FIFO module controls the small FPGA FIFO that packets are stored in before they enter the packet processor pipeline. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 25 +++- drivers/net/ntnic/include/ntnic_stat.h

[PATCH v4 1/5] net/ice: add option to download scheduler topology

2024-10-23 Thread Bruce Richardson
The DDP package file being loaded at init time may contain an alternative Tx Scheduler topology in it. Add driver option to load this topology at init time. Signed-off-by: Bruce Richardson --- doc/guides/nics/ice.rst| 15 +++ drivers/net/ice/base/ice_ddp.c | 18 ++

[PATCH v3 06/73] net/ntnic: add management API for NT flow profile

2024-10-23 Thread Serhii Iliushyk
Management API implements (re)setting of the NT flow dev Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/flow_api.h | 1 + drivers/net/ntnic/include/flow_api_engine.h | 5 ++ drivers/net/ntnic/nthw/flow_api/flow_api.c| 60 +++ .../profile_inline/flow

[PATCH v3 53/73] net/ntnic: enable RSS feature

2024-10-23 Thread Serhii Iliushyk
Enable receive side scaling Signed-off-by: Serhii Iliushyk --- doc/guides/nics/features/ntnic.ini| 3 + drivers/net/ntnic/include/create_elements.h | 1 + drivers/net/ntnic/include/flow_api.h | 2 + drivers/net/ntnic/nthw/flow_api/flow_api.c| 6 ++ .../profile_inli

[PATCH v3 44/73] net/ntnic: add IFR module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The IP Fragmenter module can fragment outgoing packets based on a programmable MTU. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 41 ++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/n

[PATCH v3 20/73] net/ntnic: add action TCP

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Add possibility to use RTE_FLOW_ITEM_TYPE_TCP Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 1 + drivers/net/ntnic/include/hw_mod_backend.h| 2 + .../profile_inline/flow_api_profile_inline.c | 108 ++ 3 fil

[PATCH v3 43/73] net/ntnic: add HFU module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Header Field Update module updates protocol fields if the packets have been changed, for example length fields and next protocol fields. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 38 ++- 1 file changed

[PATCH v3 05/73] net/ntnic: add minimal NT flow inline profile

2024-10-23 Thread Serhii Iliushyk
The flow profile implements a all flow related operations Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/flow_api.h | 15 + drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic/nthw/flow_api/flow_api.c| 28 +++- .../profile_inline/flow_api_pr

[PATCH] eal: support including mapped memory in core dump

2024-10-23 Thread Dmitry Kozlyuk
From: Dmitry Kozlyuk Commit d72e4042c5eb ("mem: exclude unused memory from core dump") unconditionally excluded all hugepage memory managed by DPDK. The rationale was to avoid overly large core dumps generated from reserved (PROT_NONE) but not mapped memory. Mapped hugepages, however, may hold da

Re: Can DPDK AF_XDP PMD support macvlan driver in container?

2024-10-23 Thread Stephen Hemminger
On Wed, 23 Oct 2024 06:07:22 + Xiaohua Wang wrote: > Hi, > > dpdk-testpmd with AF_XDP PMD can't work on p1p1 (macvlan) interface, but can > work on eth0 (veth) interface. > > And is there a method to enable AF_XDP PMD to work in XDP SKB mode? Or add > one option to set "SKB mode" in AF_XD

Re: [PATCH v17 1/1] dts: VLAN test suite implementation

2024-10-23 Thread Patrick Robb
Applied to next-dts, thanks. I did end up doing a fixup to update the vlan_setup method and the VLAN capitalization, along with a commit reword to align a little bit more with the dpdk submission guidelines (imperative verb use).

Re: [PATCH v17 1/1] dts: VLAN test suite implementation

2024-10-23 Thread Patrick Robb
On Tue, Oct 8, 2024 at 3:18 PM Dean Marx wrote: > > Test suite for verifying VLAN filtering, stripping, and insertion > functionality on Poll Mode Driver. > > Depends-on: Patch-145500 ("dts: add VLAN methods to testpmd shell") > > Signed-off-by: Dean Marx > Reviewed-by: Jeremy Spewock > --- > d

Re: [PATCH 3/6] vhost: fix VDUSE reconnect device start failure

2024-10-23 Thread David Marchand
On Wed, Oct 23, 2024 at 5:16 PM Maxime Coquelin wrote: > > This patch fixes a FD leak in the VDUSE device reconnect > code fails to start the device. > > Also take the opportunity to refactor the related code into > a dedicated function. > > Fixes: da79cc7fda76 ("vhost: add reconnection support to

RE: [EXTERNAL] Re: [PATCH v2 1/1] event/octeontx: resolve possible integer overflow

2024-10-23 Thread Hanumanth Reddy Pothula
From: Stephen Hemminger Sent: Wednesday, October 23, 2024 9:46 PM To: Hanumanth Reddy Pothula Cc: Jerin Jacob ; dev@dpdk.org; Harman Kalra Subject: [EXTERNAL] Re: [PATCH v2 1/1] event/octeontx: resolve possible integer overflow On Wed, 23 Oct 2024 12: 45: 46 +0530 Hanumanth Pothula wrote:

Re: [PATCH 1/6] vhost: fix vduse device creation error handling

2024-10-23 Thread Maxime Coquelin
On 10/23/24 18:06, David Marchand wrote: On Wed, Oct 23, 2024 at 5:16 PM Maxime Coquelin wrote: This patch fixes missing reconnection log unmapping miss in the error path at VDUSE creation time. Coverity issue: 445525 Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE") Signed

[PATCH v3 60/73] net/ntnic: add TSM module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets fpga map was extended with tsm module support which enable statistics functionality. Signed-off-by: Oleksandr Kolomeiets --- doc/guides/nics/features/ntnic.ini| 1 + .../supported/nthw_fpga_9563_055_049_.c | 394 +- .../nthw/suppor

Re: [PATCH v4 21/42] net/bnxt: use rte strerror

2024-10-23 Thread Ajit Khaparde
On Wed, Oct 23, 2024 at 1:32 AM Dengdui Huang wrote: > > The function strerror() is insecure in a multi-thread environment. > This patch uses rte_strerror() to replace it. > > Cc: sta...@dpdk.org > > Signed-off-by: Dengdui Huang > Acked-by: Chengwen Feng > Acked-by: Morten Brørup Acked-by: Ajit

[PATCH v3 03/73] net/ntnic: add minimal create/destroy flow operations

2024-10-23 Thread Serhii Iliushyk
Add high level API with describes base create/destroy implementation Signed-off-by: Serhii Iliushyk --- v2 * Change cast to void with __rte_unused --- drivers/net/ntnic/include/create_elements.h | 51 drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 227 +- drivers/net/ntn

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-10-23 Thread Stephen Hemminger
On Wed, 23 Oct 2024 19:59:35 +0200 Mattias Rönnblom wrote: > > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > > index 883e59a927..b90dc8793b 100644 > > --- a/lib/ethdev/ethdev_driver.h > > +++ b/lib/ethdev/ethdev_driver.h > > @@ -1235,6 +1235,70 @@ typedef int (*eth_count_

[PATCH v3 24/73] net/ntnic: add action modify filed

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Add possibility to use RTE_FLOW_ACTION_TYPE_MODIFY_FIELD Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini| 1 + drivers/net/ntnic/include/flow_api_engine.h | 7 + drivers/net/ntnic/include/hw_mod_backend.h| 1 + .../profile

[PATCH v3 73/73] net/ntnic: update meter documentation

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Update ntnic.ini ntnic.rst and release notes Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini | 1 + doc/guides/nics/ntnic.rst | 1 + doc/guides/rel_notes/release_24_11.rst | 1 + 3 files changed, 3 insertions(+) diff --git a/doc

[PATCH v3 04/73] net/ntnic: add internal flow create/destroy API

2024-10-23 Thread Serhii Iliushyk
NT-specific flow filter API for creating/destroying a flow Signed-off-by: Serhii Iliushyk --- v2 * Change cast to void with __rte_unused --- drivers/net/ntnic/nthw/flow_api/flow_api.c| 39 +++ drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 66 ++- drivers/net/ntnic/n

Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-23 Thread Thomas Monjalon
23/10/2024 21:14, Akhil Goyal: > > 22/10/2024 14:06, Akhil Goyal: > > > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > > > > address" to DPDK are > > > > > > -Yet another 200K of driver C++ code which does

[PATCH v3 69/73] net/ntnic: add termination thread

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Introduce clear_pdrv to unregister driver from global tracking. Modify drv_deinit to call clear_pdirv and ensure safe termination. Add flm sta and age event free. Signed-off-by: Danylo Vodopianov --- .../flow_api/profile_inline/flm_age_queue.c | 10 +++ .../flow_api

[PATCH v3 72/73] net/ntnic: add meter module

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Meter module was added: 1. add/remove profile 2. create/destroy flow 3. add/remove meter policy 4. read/update stats eth_dev_ops struct was extended with ops above. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntos_drv.h | 14 + drivers/net/

RE: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-23 Thread Akhil Goyal
> 22/10/2024 14:06, Akhil Goyal: > > > On Tue, Oct 22, 2024 at 8:06 AM Akhil Goyal wrote: > > > > > The rational to NOT pull "Hardware abstraction library using the BAR > > > > > address" to DPDK are > > > > > -Yet another 200K of driver C++ code which does not make sense to keep > > > > > in dpdk

[PATCH v3 63/73] net/ntnic: add scrub registers

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Scrub fields were added to the fpga map file Remove duplicated macro Signed-off-by: Danylo Vodopianov --- .../supported/nthw_fpga_9563_055_049_.c | 17 - drivers/net/ntnic/ntnic_ethdev.c| 3 --- 2 files changed, 16 insertions(+),

Re: [PATCH 4/6] vhost: refactor VDUSE reconnection log mapping

2024-10-23 Thread Maxime Coquelin
On 10/23/24 18:07, David Marchand wrote: On Wed, Oct 23, 2024 at 5:16 PM Maxime Coquelin wrote: This patch moves the VDUSE reconnection log mapping, as well as creation if needed, into a dedicated function. This is a preliminary rework to simplify VDUSE device creation. Signed-off-by: Max

Re: [PATCH 3/6] vhost: fix VDUSE reconnect device start failure

2024-10-23 Thread Maxime Coquelin
On 10/23/24 18:06, David Marchand wrote: On Wed, Oct 23, 2024 at 5:16 PM Maxime Coquelin wrote: This patch fixes a FD leak in the VDUSE device reconnect code fails to start the device. Also take the opportunity to refactor the related code into a dedicated function. Fixes: da79cc7fda76 ("

[PATCH v3 56/73] net/ntnic: add statistics poll

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Mechanism which poll statistics module and update values with dma module. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 343 ++ drivers/net/ntnic/include/ntdrv_4ga.h | 1 + drivers/net/ntnic/include/ntnic_

[PATCH v3 71/73] net/ntnic: add meter API

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Add meter API and implementation to the profile inline. management functions were extended with meter flow support. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 1 + drivers/net/ntnic/include/flow_api_engine.h | 5 + .../fl

[PATCH v3 66/73] net/ntnic: add aging API to the inline profile

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Added implementation for flow get aging API. Module which operate with age queue was extended with get, count and size operations. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/meson.build | 1 + .../flow_api/profile_inline/flm_age_queue.c |

[PATCH v3 59/73] net/ntnic: add STA module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets fpga map was extended with STA module support which enable statistics functionality. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 92 ++- .../nthw/supported/nthw_fpga_mod_str_map.c| 1 + .../nthw/support

[PATCH v3 57/73] net/ntnic: added flm stat interface

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov flm stat module interface was added. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 2 ++ drivers/net/ntnic/include/flow_filter.h| 1 + drivers/net/ntnic/nthw/flow_api/flow_api.c | 11 +++ drivers/net/ntnic/ntnic_mod_reg.

[PATCH v3 67/73] net/ntnic: add flow info and flow configure APIs

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Inline profile was extended with flow info and create APIS. Module which operate with age queue was extended with create and free operations. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 3 + drivers/net/ntnic/include/flow_api_e

[PATCH v3 68/73] net/ntnic: add flow aging event

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Port thread was extended with new age event callback handler. LRN, INF, STA registers getter setter was added. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api_engine.h | 13 ++ drivers/net/ntnic/include/hw_mod_backend.h| 11 ++ .../net/nt

[PATCH v3 65/73] net/ntnic: add flow aging API

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov add flow aging API to the ops structure Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/flow_api/flow_api.c| 71 +++ drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 88 +++ drivers/net/ntnic/ntnic_mod_reg.h | 21 ++

[PATCH v3 70/73] net/ntnic: add aging documentation

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov ntnic.rst document was exntede with age feature specification. ntnic.ini was extended with rte_flow action age support. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini | 1 + doc/guides/nics/ntnic.rst | 18 ++ do

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-10-23 Thread Mattias Rönnblom
On 2024-07-16 00:11, Wathsala Vithanage wrote: An application provides cache stashing hints to the ethernet devices to improve memory access latencies from the CPU and the NIC. This patch introduces three distinct hints for this purpose. The RTE_ETH_DEV_STASH_HINT_HOST_WILLNEED hint indicates th

[PATCH v3 09/73] net/ntnic: add infrastructure for for flow actions and items

2024-10-23 Thread Serhii Iliushyk
Add etities(utilities, structures, etc) required for flow API Signed-off-by: Serhii Iliushyk --- v2 * Change cast to void with __rte_unused --- drivers/net/ntnic/include/flow_api.h | 34 drivers/net/ntnic/include/flow_api_engine.h | 46 +++ drivers/net/ntnic/include/h

[PATCH v3 51/73] net/ntnic: add Tx RPL module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Replacer module can replace a range of bytes in a packet. The replacing data is stored in a table in the module and will often contain tunnel data. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 41 ++-

[PATCH v3 41/73] net/ntnic: add MOD CSU

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Checksum Update module updates the checksums of packets that has been modified in any way. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 20 ++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git

[PATCH v4 2/5] net/ice/base: make context alloc function non-static

2024-10-23 Thread Bruce Richardson
The function "ice_alloc_lan_q_ctx" will be needed by the driver code, so make it non-static. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_sched.c | 2 +- drivers/net/ice/base/ice_sched.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/i

[PATCH v3 64/73] net/ntnic: update documentation

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Update required documentation Signed-off-by: Oleksandr Kolomeiets --- doc/guides/nics/ntnic.rst | 30 ++ doc/guides/rel_notes/release_24_11.rst | 2 ++ 2 files changed, 32 insertions(+) diff --git a/doc/guides/nics/ntnic.rst b/d

[PATCH v3 62/73] net/ntnic: added flow statistics

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov xstats was extended with flow statistics support. Additional counters that shows learn, unlearn, lps, aps and other. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 40 drivers/net/ntnic/include/hw_mod_backend.h| 3 + dr

[PATCH v3 39/73] net/ntnic: add GMF (Generic MAC Feeder) module

2024-10-23 Thread Serhii Iliushyk
The Generic MAC Feeder module provides a way to feed data to the MAC modules directly from the FPGA, rather than from host or physical ports. The use case for this is as a test tool and is not used by NTNIC. This module is requireqd for correct initialization Signed-off-by: Serhii Iliushyk --- .

[PATCH v3 01/73] net/ntnic: add API for configuration NT flow dev

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov This API allows to enable of flow profile for NT SmartNIC Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 30 +++ drivers/net/ntnic/include/flow_api_engine.h | 5 + drivers/net/ntnic/include/ntos_drv.h | 1 + .../ntni

[PATCH v3 00/73] Provide flow filter API and statistics

2024-10-23 Thread Serhii Iliushyk
The list of updates provided by the patchset: * Multiple TX and RX queues. * Scattered and gather for TX and RX. * RSS hash * RSS key update * RSS based on VLAN or 5-tuple. * RSS using different combinations of fields: L3 only, L4 only or both, and source only, destination only or b

[PATCH v4 3/5] net/ice: enhance Tx scheduler hierarchy support

2024-10-23 Thread Bruce Richardson
Increase the flexibility of the Tx scheduler hierarchy support in the driver. If the HW/firmware allows it, allow creating up to 2k child nodes per scheduler node. Also expand the number of supported layers to the max available, rather than always just having 3 layers. One restriction on this chan

[PATCH v3 31/73] net/ntnic: add hash API

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 40 + drivers/net/ntnic/include/flow_api_engine.

[PATCH v3 52/73] net/ntnic: update alignment for virt queue structs

2024-10-23 Thread Serhii Iliushyk
Update incorrect alignment Signed-off-by: Serhii Iliushyk --- v2 * Fix __rte_packed usage Original NT PMD driver use pragma pack(1) wich is similar with combination attributes packed and aligned In this case aligned(1) can be ignored in case of use attribute packed

[PATCH v3 50/73] net/ntnic: add Tx INS module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Inserter module injects zeros into an offset of a packet, effectively expanding the packet. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 19 ++- .../ntnic/nthw/supported/nthw_fpga_mod_defs.h | 3 ++-

[PATCH v3 45/73] net/ntnic: add MAC Rx module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The IP Fragmenter module can fragment outgoing packets based on a programmable MTU. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 61 ++- .../ntnic/nthw/supported/nthw_fpga_mod_defs.h | 3 +- .../ntnic/nthw/s

[PATCH v3 47/73] net/ntnic: add RPP LR module

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The RX Packet Process for Local Retransmit module can add bytes in the FPGA TX pipeline, which is needed when the packet increases in size. Note, this makes room for packet expansion, but the actual expansion is done by the modules. Signed-off-by: Oleksandr Kolomeiets

[PATCH v3 48/73] net/ntnic: add MOD SLC LR

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055

[PATCH v3 42/73] net/ntnic: add MOD FLM

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c |

[PATCH v3 38/73] net/ntnic: add flow flush

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Implements flow flush API Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/nthw/flow_api/flow_api.c| 13 ++ .../profile_inline/flow_api_profile_inline.c | 43 +++ .../profile_inline/flow_api_profile_inline.h | 4 ++ drivers/net/ntn

[PATCH v3 40/73] net/ntnic: sort FPGA registers alphanumerically

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Beatification commit. It is required for pretty supporting different FPGA Signed-off-by: Oleksandr Kolomeiets --- .../supported/nthw_fpga_9563_055_049_.c | 364 +- 1 file changed, 182 insertions(+), 182 deletions(-) diff --git a/drivers/net/ntn

[PATCH v3 30/73] net/ntnic: add KM module

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api_engine.h |

[PATCH v3 37/73] net/ntnic: add flow dump feature

2024-10-23 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add posibilyty to dump flow in human readable format Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api_engine.h | 2 + drivers/net/ntnic/nthw/flow_api/flow_api.c| 17 ++ .../profile_inline/flow_api_hw_db_inline.c| 264 +++

[PATCH v3 36/73] net/ntnic: match and action db attributes were added

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov Implements match/action dereferencing Signed-off-by: Danylo Vodopianov --- .../profile_inline/flow_api_hw_db_inline.c| 795 ++ .../profile_inline/flow_api_hw_db_inline.h| 35 + .../profile_inline/flow_api_profile_inline.c | 55 ++ 3 files chan

[PATCH v3 29/73] net/ntnic: add QSL module

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/flow_api.h | 3 + drivers/net/ntnic/include/hw_mod_backe

[PATCH v3 28/73] net/ntnic: add PDB module

2024-10-23 Thread Serhii Iliushyk
From: Danylo Vodopianov The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/hw_mod_backend.h| 3 + .../ntnic/nthw/flow_api/hw_mod/hw_mod_pdb.c | 144 ++ .../profile

  1   2   3   >