Re: [PATCH v15 0/7] Lcore variables

2024-10-18 Thread Mattias Rönnblom
On 2024-10-18 17:37, Thomas Monjalon wrote: 17/10/2024 07:57, Mattias Rönnblom: Mattias Rönnblom (7): eal: add static per-lcore memory allocation facility eal: add lcore variable functional tests eal: add lcore variable performance test random: keep PRNG state in lcore variable po

release candidate 24.11-rc1

2024-10-18 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v24.11-rc1 There are 630 new patches in this snapshot, including many API/ABI compatibility breakages. This release won't be ABI-compatible with previous ones. Release notes: https://doc.dpdk.org/

Re: [PATCH] dma/idxd: set defaults for GRPCFG traffic class

2024-10-18 Thread David Marchand
On Fri, Oct 4, 2024 at 6:49 PM Bruce Richardson wrote: > > On Wed, Jun 26, 2024 at 05:45:23AM +, Shaiq Wani wrote: > > Set GRPCFG traffic class to value of 1 for best performance on current > > generation of accelerators. Applicable to gen1 and gen2 devices. > > > > Signed-off-by: Shaiq Wani

Re: [PATCH v26 00/15] Log subsystem improvements

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 19:07:18 +0200 David Marchand wrote: > Hello Stephen, > > On Wed, Oct 16, 2024 at 10:24 PM Stephen Hemminger > wrote: > > > > Improvements and unification of logging library. > > This version works on all platforms: Linux, Windows and FreeBSD. > > > > This is update to rewor

[PATCH] net/netvsc: force TX VLAN offload on 801.2Q packet

2024-10-18 Thread longli
From: Long Li The VSP assumes the packet doesn't have VLAN tags. When VLAN tag is present in a TX packet, always strip it and use PPI to send VLAN info through VSP packet. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: Hui (Hui) Ling Cc: Stephen Hemminger Cc: Wei Hu Cc: st

Re: [PATCH] net/mvpp2: fix build with IPv6 address structure

2024-10-18 Thread Thomas Monjalon
18/10/2024 22:11, Thomas Monjalon: > A structure has been created for IPv6 addresses > replacing the byte arrays of the IPv6 header. > > This change was failing the compilation: > mrvl_flow.c:1055:29: error: incompatible type for argument 1 of 'memcmp' > > Instead of adapting the memcmp call, a n

[PATCH] net/mvpp2: fix build with IPv6 address structure

2024-10-18 Thread Thomas Monjalon
A structure has been created for IPv6 addresses replacing the byte arrays of the IPv6 header. This change was failing the compilation: mrvl_flow.c:1055:29: error: incompatible type for argument 1 of 'memcmp' Instead of adapting the memcmp call, a new function is used to compare an IPv6 address wi

Restrict max packet size on rx

2024-10-18 Thread Rajasekhar Pulluru
Team, Does setting mtu using rte_eth_dev_set_mtu limit the maximum size of the packet received on the dpdk port to the configured mtu size? On an intel machine with ixgbe port, with mtu set to 1500, no rx-offloads enabled, ixgbe dpdk port is able to receive packets greater than 1500 size and even

RE: [PATCH v1 1/2] baseband/acc: FFT support in VRB2 PRQ device

2024-10-18 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, October 18, 2024 12:54 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; Vargas, Hernan > Subject: Re: [PATCH v1 1/2] baseband/acc: FFT support in VRB2 PRQ device > > Hi Nicolas, > > On 10/15/

Re: Restrict max packet size on rx

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 22:19:35 +0530 Rajasekhar Pulluru wrote: > Thanks Stephen. > > On Fri, Oct 18, 2024 at 10:13 PM Stephen Hemminger < > step...@networkplumber.org> wrote: > > > On Fri, 18 Oct 2024 22:05:24 +0530 > > Rajasekhar Pulluru wrote: > > > > > Team, > > > Does setting mtu using r

Re: [PATCH] event/octeontx: resolve possible integer overflow

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 13:29:03 +0530 Hanumanth Pothula wrote: > The last argument passed to ssovf_parsekv() is an > unsigned char*, but it is accessed as an integer. > This can lead to an integer overflow. > > Hence, make ensure the argument is accessed as a char > and for better error handling us

Re: [PATCH v26 00/15] Log subsystem improvements

2024-10-18 Thread David Marchand
Hello Stephen, On Wed, Oct 16, 2024 at 10:24 PM Stephen Hemminger wrote: > > Improvements and unification of logging library. > This version works on all platforms: Linux, Windows and FreeBSD. > > This is update to rework patch set. It adds several new features > to the console log output. > >

Re: [PATCH v6] doc: add new driver guidelines

2024-10-18 Thread Thomas Monjalon
06/10/2024 23:09, Ferruh Yigit: > On 10/6/2024 7:42 PM, Nandini Persad wrote: > > This document was created to assist contributors in creating DPDK drivers > > and provides suggestions and guidelines on how to upstream effectively. > > > > Signed-off-by: Ferruh Yigit > > Signed-off-by: Nandini Pe

Re: Restrict max packet size on rx

2024-10-18 Thread Rajasekhar Pulluru
Thanks Stephen. On Fri, Oct 18, 2024 at 10:13 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Fri, 18 Oct 2024 22:05:24 +0530 > Rajasekhar Pulluru wrote: > > > Team, > > Does setting mtu using rte_eth_dev_set_mtu limit the maximum size of the > > packet received on the dpdk port t

Re: [PATCH v4] net: add bit fields to IPv6 header definition

2024-10-18 Thread David Marchand
On Tue, Jun 18, 2024 at 2:44 PM Morten Brørup wrote: > > From: Gregory Etelson [mailto:getel...@nvidia.com] > > > > DPDK IPv6 header definition combined the `version`, `traffic class` > > and `flow label` header fields into a single 32 bits structure member > > `vtc_flow`. > > > > The patch expan

Re: [PATCH] common/cnxk: replace deprecated function for cross compilation

2024-10-18 Thread David Marchand
On Fri, Oct 18, 2024 at 6:26 PM Bruce Richardson wrote: > > On Fri, Oct 18, 2024 at 06:00:43PM +0200, David Marchand wrote: > > Some (newly introduced) use of "get_cross_property" was missed. > > Convert to get_external_property. > > > > Fixes: b0d0c84b3c0f ("build: replace deprecated function for

Re: Restrict max packet size on rx

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 22:05:24 +0530 Rajasekhar Pulluru wrote: > Team, > Does setting mtu using rte_eth_dev_set_mtu limit the maximum size of the > packet received on the dpdk port to the configured mtu size? > > On an intel machine with ixgbe port, with mtu set to 1500, no rx-offloads > enabled,

Re: [PATCH 4/4] net/hns3: support outer VLAN flow match

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 14:19:41 +0800 Jie Hai wrote: > @@ -306,11 +324,16 @@ hns3_parse_devargs(struct rte_eth_dev *dev) > &hns3_parse_dev_caps_mask, &dev_caps_mask); > (void)rte_kvargs_process(kvlist, HNS3_DEVARG_MBX_TIME_LIMIT_MS, > &hns3_par

Re: [PATCH v2 03/18] net/r8169: add hardware registers access routines

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 03:41:28 + 王颢 wrote: > Dear Stephen, > > In r8169 pmd, mdelay and udelay are macros. > #define mdelay rte_delay_ms > #define udelay rte_delay_us > > Best Regards, > Howard Wang That kind of redefinition can lead to confusion, can it be avoided?

Re: [PATCH v2 05/18] net/r8169: add support for hw config

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 05:45:18 + 王颢 wrote: > Dear Stephen, > > As you can see, there are some issues with the current code regarding > whitespace and CODE_INDENT. I used astyle to adjust the code format with the > following command. However, I found that I could not fully meet the > checkpa

RE: [EXTERNAL] [PATCH] event/octeontx: resolve possible integer overflow

2024-10-18 Thread Pavan Nikhilesh Bhagavatula
> The last argument passed to ssovf_parsekv() is an > unsigned char*, but it is accessed as an integer. > This can lead to an integer overflow. > > Hence, make ensure the argument is accessed as a char > and for better error handling use strtol instead of atoi. > > Signed-off-by: Hanumanth Pothul

Re: [PATCH] common/cnxk: replace deprecated function for cross compilation

2024-10-18 Thread Bruce Richardson
On Fri, Oct 18, 2024 at 06:00:43PM +0200, David Marchand wrote: > Some (newly introduced) use of "get_cross_property" was missed. > Convert to get_external_property. > > Fixes: b0d0c84b3c0f ("build: replace deprecated function for cross > compilation") > > Signed-off-by: David Marchand > --- Ac

Re: [PATCH] ci: fix unit tests with Fedora 37

2024-10-18 Thread David Marchand
On Fri, Oct 18, 2024 at 3:57 PM David Marchand wrote: > > This was detected in UNH envs. > > In Fedora 37 and other distributions, meson 0.57 breaks when calling > the unit tests (probably because of an incompatibility with Python 3.11): > > $ meson test -C build --suite DPDK:fast-tests > ninja: E

Re: [PATCH v5 00/47] TruFlow update for Thor2

2024-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2024 14:40:37 +0530 Sriharsha Basavapatna wrote: > This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. > > TruFlow(TF) is the software library that exposes CFA HW resources to > upper layer protocols or applications. This patch series implements the > tfc (t

Re: [PATCH dpdk v5 00/17] IPv6 APIs overhaul

2024-10-18 Thread David Marchand
On Fri, Oct 18, 2024 at 4:06 PM Robin Jarry wrote: > > Hi everyone, > > As discussed recently [1], here is a first draft of the IPv6 APIs rework. The > API change was announced before the 24.07 release [2]. This series is intended > for 24.11. > > [1] http://inbox.dpdk.org/dev/d2sr8t1h39cj.jrqfi6j

[PATCH] common/cnxk: replace deprecated function for cross compilation

2024-10-18 Thread David Marchand
Some (newly introduced) use of "get_cross_property" was missed. Convert to get_external_property. Fixes: b0d0c84b3c0f ("build: replace deprecated function for cross compilation") Signed-off-by: David Marchand --- drivers/common/cnxk/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v15 0/7] Lcore variables

2024-10-18 Thread Thomas Monjalon
17/10/2024 07:57, Mattias Rönnblom: > Mattias Rönnblom (7): > eal: add static per-lcore memory allocation facility > eal: add lcore variable functional tests > eal: add lcore variable performance test > random: keep PRNG state in lcore variable > power: keep per-lcore state in lcore varia

Re: [PATCH] maintainers: remove Pallavi as windows maintainer

2024-10-18 Thread Thomas Monjalon
> Pallavi Kadam is no longer working on DPDK, so she has requested that her > name be removed from the maintainers file. > > Signed-off-by: Bruce Richardson > Acked-by: Pallavi Kadam Applied, thanks.

Re: [PATCH dpdk v2] net: add more icmp types and code

2024-10-18 Thread Thomas Monjalon
18/10/2024 02:39, Morten Brørup: > > From: Robin Jarry [mailto:rja...@redhat.com] > > Sent: Friday, 18 October 2024 00.42 > > > > Add more ICMP message types and codes based on RFC 792. Change the > > namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow > > differentiation > > between types an

[DPDK/core Bug 1409] arparse library assumes enum are 64 bit

2024-10-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1409 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resoluti

Re: [PATCH v4 0/6] refine argparse library

2024-10-18 Thread Thomas Monjalon
18/10/2024 03:09, fengchengwen: > Hi Thomas and David, > > This patchset was already acked by Stephen. > It missed in DPDK 24.07, hope merge in 24.11. > > Thanks > > On 2024/10/10 9:35, fengchengwen wrote: > > Hi Thomas and David, > > > > Kindly ping for merge. > > > > On 2024/10/10 3:33, Step

[PATCH v3 2/4] net/ice: improve Tx scheduler graph output

2024-10-18 Thread Bruce Richardson
The function to dump the TX scheduler topology only adds to the chart nodes connected to TX queues or for the flow director VSI. Change the function to work recursively from the root node and thereby include all scheduler nodes, whether in use or not, in the dump. Also, improve the output of the T

[PATCH v3 4/4] net/ice: limit the number of queues to sched capabilities

2024-10-18 Thread Bruce Richardson
Rather than assuming that each VSI can hold up to 256 queue pairs, or the reported device limit, query the available nodes in the scheduler tree to check that we are not overflowing the limit for number of child scheduling nodes at each level. Do this by multiplying max_children for each level beyo

[PATCH v3 1/4] net/ice: detect stopping a flow-director queue twice

2024-10-18 Thread Bruce Richardson
If the flow-director queue is stopped at some point during the running of an application, the shutdown procedure for the port issues an error as it tries to stop the queue a second time, and fails to do so. We can eliminate this error by setting the tail-register pointer to NULL on stop, and checki

[PATCH v3 3/4] net/ice: add option to choose DDP package file

2024-10-18 Thread Bruce Richardson
The "Dynamic Device Personalization" package is loaded at initialization time by the driver, but the specific package file loaded depends upon what package file is found first by searching through a hard-coded list of firmware paths. To enable greater control over the package loading, we can add a

[PATCH v3 0/4] updates for net/ice driver

2024-10-18 Thread Bruce Richardson
This patchset contains a set of updates for the ice driver, a number of which are in the area of the "rte_tm" APIs for Tx scheduling. These patches were previously submitted as part of a larger set[1], but separating them out here for easier review and merge ahead of the more substantial changes f

Re: [PATCH dpdk v5 08/17] cmdline: use IPv6 address structure

2024-10-18 Thread Bruce Richardson
On Fri, Oct 18, 2024 at 04:05:44PM +0200, Robin Jarry wrote: > The previous commits introduced a new rte_ipv6_addr structure without > any alignment requirements. It is not compatible with the in6_addr POSIX > type available in netinet/in.h. > > The main issue is that in6_addr is not uniform on al

[PATCH dpdk v5 08/17] cmdline: use IPv6 address structure

2024-10-18 Thread Robin Jarry
The previous commits introduced a new rte_ipv6_addr structure without any alignment requirements. It is not compatible with the in6_addr POSIX type available in netinet/in.h. The main issue is that in6_addr is not uniform on all platforms which causes unaligned access warnings when compiling witho

[PATCH dpdk v5 07/17] rib6: use IPv6 address structure and utils

2024-10-18 Thread Robin Jarry
Replace ad-hoc uint8_t[16] array types in the API of rte_rib6 with rte_ipv6_addr structures. Replace duplicate functions and macros with common ones from rte_ip6.h. Update all code accordingly. Signed-off-by: Robin Jarry --- app/test/test_rib6.c | 55 ++-- doc/guides/r

[PATCH dpdk v5 13/17] hash: use IPv6 address structure

2024-10-18 Thread Robin Jarry
Update rte_ipv6_tuple to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- app/test/test_thash.c | 46 ++ doc/guides/rel_notes/deprecation.rst | 2 -- doc/guides/rel_notes/release_24_11.rst | 2 ++ lib/hash/rte

[PATCH dpdk v5 10/17] pipeline: use IPv6 structures

2024-10-18 Thread Robin Jarry
Update rte_table_action_ipv6_header and rte_table_action_nat_params to use rte_ipv6_addr structures instead of uint8_t[16] arrays. For consistency, also update rte_swx_ipsec_sa_encap_params to use rte_ipv6_addr instead of in6_addr. Signed-off-by: Robin Jarry --- doc/guides/rel_notes/deprecation

[PATCH dpdk v5 02/17] net: split IPv4 and IPv6 symbols in separate headers

2024-10-18 Thread Robin Jarry
Split IPv4 and IPv6 symbols in two separate headers. rte_ip4.h and rte_ip6.h, respectively. Update doxygen index accordingly. Include rte_ip4.h and rte_ip6.h in rte_ip.h for backward compatibility in applications. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- doc/api/doxy-api-ind

[PATCH dpdk v5 16/17] net: add utilities for well known IPv6 address types

2024-10-18 Thread Robin Jarry
Add more utilities to work with IPv6 addresses. These functions will be required in order to help building IPv6 routing applications. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- app/test/test_net_ip6.c | 68 + lib/net/rte_ip6.h | 209 +++

[PATCH dpdk v5 17/17] net: add function to check IPv6 version

2024-10-18 Thread Robin Jarry
Add a function to check the version in IPv6 headers. Signed-off-by: Robin Jarry --- app/test/test_net_ip6.c | 16 lib/net/rte_ip6.h | 16 2 files changed, 32 insertions(+) diff --git a/app/test/test_net_ip6.c b/app/test/test_net_ip6.c index 94033421ad0b..

[PATCH dpdk v5 15/17] flow: use IPv6 address structure

2024-10-18 Thread Robin Jarry
Update rte_flow_tunnel, rte_flow_action_set_ipv6, rte_flow_item_icmp6_nd_na and rte_flow_item_icmp6_nd_ns to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- app/test-flow-perf/actions_gen.c | 4 ++-- doc/guides/rel_notes/deprecation.rst | 1

[PATCH dpdk v5 14/17] gro: use IPv6 address structure

2024-10-18 Thread Robin Jarry
Update tcp6_flow_key to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- doc/guides/rel_notes/deprecation.rst | 2 -- doc/guides/rel_notes/release_24_11.rst | 2 ++ lib/gro/gro_tcp6.c | 8 lib/gro/gro_tcp6.h

[PATCH dpdk v5 12/17] security: use IPv6 address structure

2024-10-18 Thread Robin Jarry
For consistency with the rest of the code base, update rte_security_ipsec_tunnel_param to use rte_ipv6_addr structures instead of in6_addr. Signed-off-by: Robin Jarry --- doc/guides/rel_notes/release_24_11.rst | 2 ++ drivers/common/cnxk/cnxk_security.c| 14 ++ drivers/net/iavf/

[PATCH dpdk v5 04/17] net: use IPv6 structure for packet headers

2024-10-18 Thread Robin Jarry
The rte_ipv6_hdr uses ad-hoc uint8_t[16] arrays to represent addresses. Replace these arrays with the newly added rte_ipv6_addr structure. Adapt all code accordingly. Signed-off-by: Robin Jarry --- app/test-flow-perf/items_gen.c | 4 +-- app/test-pipeline/pipeline_hash.c| 4 +

[PATCH dpdk v5 09/17] node: use IPv6 address structure and utils

2024-10-18 Thread Robin Jarry
Replace ad-hoc uint8_t[16] arrays with rte_ipv6_addr structures. Replace duplicated code with utils from rte_ip6.h. Signed-off-by: Robin Jarry --- app/graph/ethdev.c | 44 +++--- app/graph/ethdev.h | 9 ++--- app/graph/ip6_route.c

[PATCH dpdk v5 11/17] ipsec: use IPv6 address structure

2024-10-18 Thread Robin Jarry
Update rte_ipsec_sadv6_key to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- app/test-sad/main.c| 24 ++-- app/test/test_ipsec_sad.c | 46 doc/guides/prog_guide/ipsec_lib.rst| 4 +- doc/guides/rel_notes

[PATCH dpdk v5 06/17] fib6: use IPv6 address structure and utils

2024-10-18 Thread Robin Jarry
Replace ad-hoc uint8_t[16] array types in the API of rte_fib6 with rte_ipv6_addr structures. Replace duplicate functions and macros with common ones from rte_ip6.h. Update all code accordingly. Signed-off-by: Robin Jarry --- app/test-fib/main.c| 8 +- app/test/test_fib6.c

[PATCH dpdk v5 03/17] net: add IPv6 address structure and utils

2024-10-18 Thread Robin Jarry
There is currently no structure defined for IPv6 addresses. Introduce one that is simply a uint8_t array of 16 elements. The idea is to ensure this structure alignment is 1 so that it can be mapped directly on unaligned packet memory. Add utility functions and macros that use the newly added rte_i

[PATCH dpdk v5 01/17] net: split raw checksum functions in separate header

2024-10-18 Thread Robin Jarry
The checksum functions are used by both ipv4 and ipv6 functions. In preparation of moving ipv6 symbols to a new header, move the checksum related symbols to another dedicated header. Update doxygen index accordingly. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- doc/api/doxy-api-i

Re: [PATCH] ci: fix unit tests with Fedora 37

2024-10-18 Thread Patrick Robb
Acked-by: Patrick Robb

[PATCH dpdk v5 00/17] IPv6 APIs overhaul

2024-10-18 Thread Robin Jarry
Hi everyone, As discussed recently [1], here is a first draft of the IPv6 APIs rework. The API change was announced before the 24.07 release [2]. This series is intended for 24.11. [1] http://inbox.dpdk.org/dev/d2sr8t1h39cj.jrqfi6jeh...@redhat.com/ [2] https://git.dpdk.org/dpdk/commit/?id=835d4c

[PATCH] ci: fix unit tests with Fedora 37

2024-10-18 Thread David Marchand
This was detected in UNH envs. In Fedora 37 and other distributions, meson 0.57 breaks when calling the unit tests (probably because of an incompatibility with Python 3.11): $ meson test -C build --suite DPDK:fast-tests ninja: Entering directory `/root/dpdk/build' ninja: no work to do. Exception

[PATCH v5 28/47] net/bnxt: tf_ulp: modify return values to adhere to C coding standard

2024-10-18 Thread Sriharsha Basavapatna
From: Shuanglin Wang Modified return values of the several ULP utilities to comply C coding standard. Like using macros EXIT_SUCCESS(0) and EXIT_FAILURE(1) for the conventional status value for success and failure, respectively. They are declared in the file stdlib.h. Signed-off-by: Shuanglin W

Re: [PATCH] mbuf: add transport mode ESP packet type

2024-10-18 Thread David Marchand
On Thu, Aug 22, 2024 at 5:33 PM Alexander Kozyrev wrote: > > Support the IP Encapsulating Security Payload (ESP) in transport mode. > Currently, we have RTE_PTYPE_TUNNEL_ESP for the ESP tunnel mode. > Transport mode can be detected by parsing the "Next Header" field. > The Next Header is TCP for t

Re: [PATCH v3 2/4] hash: add dynamic polynomial calculation

2024-10-18 Thread Medvedkin, Vladimir
Hi Stephen, On 17/10/2024 04:23, Stephen Hemminger wrote: On Wed, 16 Oct 2024 17:28:17 +0100 "Medvedkin, Vladimir" wrote: Hi Stephen, On 15/10/2024 23:29, Stephen Hemminger wrote: On Fri, 11 Oct 2024 18:17:00 + Vladimir Medvedkin wrote: + +uint32_t +rte_thash_get_rand_poly(uint32_

RE: [PATCH v3] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-18 Thread Dooley, Brian
Hey ARM folks, Intel IPsec MB minimum version is being bumped to 1.4. > -Original Message- > From: Dooley, Brian > Sent: Thursday 10 October 2024 11:13 > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > Subject: [PATCH v3] crypto/ipsec_mb:

Re: [PATCH v4] hash: separate creation parameters checks

2024-10-18 Thread Thomas Monjalon
17/10/2024 17:10, Thomas Monjalon: > From: Niall Meade > > Separate name, entries and key_len parameter checks in rte_hash_create(). > Also make the error messages more informative/verbose > to help with debugging. > > Signed-off-by: Niall Meade > Acked-by: Stephen Hemminger > --- > v4: format

[PATCH dpdk v4 08/17] cmdline: use IPv6 address structure

2024-10-18 Thread Robin Jarry
The previous commits introduced a new rte_ipv6_addr structure without any alignment requirements. It is not compatible with the in6_addr POSIX type available in netinet/in.h. The main issue is that in6_addr is not uniform on all platforms which causes unaligned access warnings when compiling witho

RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op

2024-10-18 Thread Akhil Goyal
> > > > -Original Message- > > From: Akhil Goyal > > Sent: Friday, October 11, 2024 2:18 PM > > To: Kusztal, ArkadiuszX ; dev@dpdk.org > > Cc: Dooley, Brian > > Subject: RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op > > > > > In the case when PMD cannot support the fu

[PATCH v5 25/47] net/bnxt: tf_ulp: update template files

2024-10-18 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch updates template files for the following list of changes, that are being added in the next patch. - enable recipe id generation - fix segfault in the wildcard recipe process Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v5 42/47] net/bnxt: tf_ulp: TFC support flow scale query for Thor2

2024-10-18 Thread Sriharsha Basavapatna
From: Shuanglin Wang TFC supports the flow scale query feature for OVS application. The resource usage(WC-TCAM) is tracked inside Thor2 firmware. This patch is to query the wc-tcam usage info when adding/ deleting a flow. It is just for debugging purpose and disabled by default. Using the build

[PATCH v5 19/47] net/bnxt: tf_ulp: convert recipe table to dynamic memory

2024-10-18 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Converted the recipe table allocation from static model to dynamic memory allocation model. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 175 +

[PATCH v5 47/47] net/bnxt: tf_ulp: add stats cache for thor2

2024-10-18 Thread Sriharsha Basavapatna
From: Peter Spreadborough This change adds a stats cache for Thor2 flows using counters. Flow stats will be harvested periodically in the background and stats reads by the application will be returned stats from the cache and not by initiating a read from HW. This change also adds read-clear fun

[PATCH v5 36/47] net/bnxt: tf_ulp: add support for rss flow query to ULP

2024-10-18 Thread Sriharsha Basavapatna
From: Randy Schacher Support flow query rss command for truflow in ULP layer. Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c| 39 +- drivers/net/bnxt/bnxt_

[PATCH v5 39/47] net/bnxt: tf_ulp: switch ulp to use rte crc32 hash

2024-10-18 Thread Sriharsha Basavapatna
From: Peter Spreadborough The RTE hash is highly optimized and will use HW acceleration when available. Signed-off-by: Peter Spreadborough Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 4 dr

Re: [PATCH] doc: fix Sphinx build without RTD theme

2024-10-18 Thread Thomas Monjalon
17/10/2024 19:14, Thomas Monjalon: > DTS is using a specific configuration of Sphinx > which is supported only with the theme Read The Docs. > If not available, this error may be seen: > unsupported theme option 'collapse_navigation' given > > In order to allow doc generation without this th

[PATCH v5 09/47] net/bnxt: tf_core: remove dead AFM code from session-based priority TCAM mgr

2024-10-18 Thread Sriharsha Basavapatna
From: Randy Schacher Remove references to AFM allocated memory which is no longer supported with TCAM mgr and truflow Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Farah Smith Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[PATCH v5 07/47] net/bnxt: tf_core: fix slice count in case of HA entry move

2024-10-18 Thread Sriharsha Basavapatna
From: Sangtani Parag Satishbhai When entries are moved during HA, a shared move function transfers TCAM entries by using get/set message APIs, and the slice number of the entry is required to accomplish the movement. The slice number is calculated as the product of row_slice and entry size. Befor

Re: [PATCH v2 1/2] power: fix power library with --lcores

2024-10-18 Thread Thomas Monjalon
18/10/2024 05:34, Sivaprasad Tummala: > This commit fixes an issue in the power library > related to using lcores mapped to different > physical cores (--lcores option in EAL). > > Previously, the power library incorrectly accessed > CPU sysfs attributes for power management, treating > lcore IDs

[PATCH dpdk v4 14/17] gro: use IPv6 address structure

2024-10-18 Thread Robin Jarry
Update tcp6_flow_key to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- doc/guides/rel_notes/deprecation.rst | 2 -- doc/guides/rel_notes/release_24_11.rst | 2 ++ lib/gro/gro_tcp6.c | 8 lib/gro/gro_tcp6.h

[PATCH v5 10/47] net/bnxt: tf_core: remove dead code from session-based priority TCAM mgr

2024-10-18 Thread Sriharsha Basavapatna
From: Randy Schacher Remove references to tx_tcam_supported and rx_tcam_supported logic which chooses between FW-based tcam resource allocation and driver-based tcam manager. Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Peter Spreadborough Reviewed-by: Manis

[PATCH v5 35/47] net/bnxt: tf_ulp: TF support flow scale query

2024-10-18 Thread Sriharsha Basavapatna
From: Shuanglin Wang TF supports the flow scale query feature for OVS application. The resource usage is tracked when opening a TF session or adding/deleting a flow. The resources includes WC TCAM, EM, Action, Counter, Meter, ACT_ENCAP, ACT_ENCAP, and SP_SMAC. User can query the resource usage us

[PATCH v5 00/47] TruFlow update for Thor2

2024-10-18 Thread Sriharsha Basavapatna
This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. TruFlow(TF) is the software library that exposes CFA HW resources to upper layer protocols or applications. This patch series implements the tfc (tf_core) and the tf_ulp libraries as a part of the bnxt PMD, so that upper la

[PATCH v5 06/47] net/bnxt: tf_core: TF support flow scale query

2024-10-18 Thread Sriharsha Basavapatna
From: Shuanglin Wang TF supports the flow scale query feature for OVS application. The resource usage is tracked when opening a TF session or adding/deleting a flow. The resources includes WC TCAM, EM, Action, Counter, Meter, ACT_ENCAP, ACT_ENCAP, and SP_SMAC. User can query the resource usage us

[PATCH dpdk v4 12/17] security: use IPv6 address structure

2024-10-18 Thread Robin Jarry
For consistency with the rest of the code base, update rte_security_ipsec_tunnel_param to use rte_ipv6_addr structures instead of in6_addr. Signed-off-by: Robin Jarry --- doc/guides/rel_notes/release_24_11.rst | 2 ++ drivers/common/cnxk/cnxk_security.c| 14 ++ drivers/net/iavf/

Re: [PATCH v4] hash: separate creation parameters checks

2024-10-18 Thread Meade, Niall
>17/10/2024 17:10, Thomas Monjalon: >> From: Niall Meade >> >> Separate name, entries and key_len parameter checks in rte_hash_create(). >> Also make the error messages more informative/verbose >> to help with debugging. >> >> Signed-off-by: Niall Meade >> Acked-by: Stephen Hemminger >> --- >> v

[PATCH dpdk v4 15/17] flow: use IPv6 address structure

2024-10-18 Thread Robin Jarry
Update rte_flow_tunnel, rte_flow_action_set_ipv6, rte_flow_item_icmp6_nd_na and rte_flow_item_icmp6_nd_ns to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- app/test-flow-perf/actions_gen.c | 4 ++-- doc/guides/rel_notes/deprecation.rst | 1

[PATCH dpdk v4 03/17] net: add IPv6 address structure and utils

2024-10-18 Thread Robin Jarry
There is currently no structure defined for IPv6 addresses. Introduce one that is simply a uint8_t array of 16 elements. The idea is to ensure this structure alignment is 1 so that it can be mapped directly on unaligned packet memory. Add utility functions and macros that use the newly added rte_i

[PATCH dpdk v4 09/17] node: use IPv6 address structure and utils

2024-10-18 Thread Robin Jarry
Replace ad-hoc uint8_t[16] arrays with rte_ipv6_addr structures. Replace duplicated code with utils from rte_ip6.h. Signed-off-by: Robin Jarry --- app/graph/ethdev.c | 44 +++--- app/graph/ethdev.h | 9 ++--- app/graph/ip6_route.c

[PATCH dpdk v4 04/17] net: use IPv6 structure for packet headers

2024-10-18 Thread Robin Jarry
The rte_ipv6_hdr uses ad-hoc uint8_t[16] arrays to represent addresses. Replace these arrays with the newly added rte_ipv6_addr structure. Adapt all code accordingly. Signed-off-by: Robin Jarry --- app/test-flow-perf/items_gen.c | 4 +-- app/test-pipeline/pipeline_hash.c| 4 +

[PATCH v5 44/47] net/bnxt: tf_ulp: enable support for truflow feature configuration

2024-10-18 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added truflow feature bit meson configuration parameter to enable optional capability features of the appplication. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_

[PATCH v5 34/47] net/bnxt: tf_ulp: add rte_mtr support for Thor2

2024-10-18 Thread Sriharsha Basavapatna
From: Jay Ding 1. Implement Thor2 meter template tables 2. Add Thor2 meter support in ULP 3. Make rte_mtr API implementation device independent to adapt Thor2 meter hw change 4. Fix the round issue in xir calculation Signed-off-by: Jay Ding Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v5 45/47] net/bnxt: tf_ulp: support a few feature extensions

2024-10-18 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch supports the following features. add support for port table write operation Added support for port table write operation from the template so that template can write mirror id details into the port database. support generic template fo

[PATCH dpdk v4 16/17] net: add utilities for well known IPv6 address types

2024-10-18 Thread Robin Jarry
Add more utilities to work with IPv6 addresses. These functions will be required in order to help building IPv6 routing applications. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- app/test/test_net_ip6.c | 68 +++ lib/net/rte_ip6.h | 143 +

[PATCH dpdk v4 17/17] net: add function to check IPv6 version

2024-10-18 Thread Robin Jarry
Add a function to check the version in IPv6 headers. Signed-off-by: Robin Jarry --- app/test/test_net_ip6.c | 16 lib/net/rte_ip6.h | 14 ++ 2 files changed, 30 insertions(+) diff --git a/app/test/test_net_ip6.c b/app/test/test_net_ip6.c index 94033421ad0b..9c

[PATCH dpdk v4 13/17] hash: use IPv6 address structure

2024-10-18 Thread Robin Jarry
Update rte_ipv6_tuple to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- app/test/test_thash.c | 46 ++ doc/guides/rel_notes/deprecation.rst | 2 -- doc/guides/rel_notes/release_24_11.rst | 2 ++ lib/hash/rte

[PATCH dpdk v4 10/17] pipeline: use IPv6 structures

2024-10-18 Thread Robin Jarry
Update rte_table_action_ipv6_header and rte_table_action_nat_params to use rte_ipv6_addr structures instead of uint8_t[16] arrays. For consistency, also update rte_swx_ipsec_sa_encap_params to use rte_ipv6_addr instead of in6_addr. Signed-off-by: Robin Jarry --- doc/guides/rel_notes/deprecation

[PATCH dpdk v4 11/17] ipsec: use IPv6 address structure

2024-10-18 Thread Robin Jarry
Update rte_ipsec_sadv6_key to use rte_ipv6_addr structures instead of uint8_t[16] arrays. Signed-off-by: Robin Jarry --- app/test-sad/main.c| 24 ++-- app/test/test_ipsec_sad.c | 46 doc/guides/prog_guide/ipsec_lib.rst| 4 +- doc/guides/rel_notes

[PATCH dpdk v4 06/17] fib6: use IPv6 address structure and utils

2024-10-18 Thread Robin Jarry
Replace ad-hoc uint8_t[16] array types in the API of rte_fib6 with rte_ipv6_addr structures. Replace duplicate functions and macros with common ones from rte_ip6.h. Update all code accordingly. Signed-off-by: Robin Jarry --- app/test-fib/main.c| 8 +- app/test/test_fib6.c

[PATCH dpdk v4 07/17] rib6: use IPv6 address structure and utils

2024-10-18 Thread Robin Jarry
Replace ad-hoc uint8_t[16] array types in the API of rte_rib6 with rte_ipv6_addr structures. Replace duplicate functions and macros with common ones from rte_ip6.h. Update all code accordingly. Signed-off-by: Robin Jarry --- app/test/test_rib6.c | 55 ++-- doc/guides/r

[PATCH dpdk v4 01/17] net: split raw checksum functions in separate header

2024-10-18 Thread Robin Jarry
The checksum functions are used by both ipv4 and ipv6 functions. In preparation of moving ipv6 symbols to a new header, move the checksum related symbols to another dedicated header. Update doxygen index accordingly. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- doc/api/doxy-api-i

[PATCH dpdk v4 00/17] IPv6 APIs overhaul

2024-10-18 Thread Robin Jarry
Hi everyone, As discussed recently [1], here is a first draft of the IPv6 APIs rework. The API change was announced before the 24.07 release [2]. This series is intended for 24.11. [1] http://inbox.dpdk.org/dev/d2sr8t1h39cj.jrqfi6jeh...@redhat.com/ [2] https://git.dpdk.org/dpdk/commit/?id=835d4c

[PATCH dpdk v4 02/17] net: split IPv4 and IPv6 symbols in separate headers

2024-10-18 Thread Robin Jarry
Split IPv4 and IPv6 symbols in two separate headers. rte_ip4.h and rte_ip6.h, respectively. Update doxygen index accordingly. Include rte_ip4.h and rte_ip6.h in rte_ip.h for backward compatibility in applications. Signed-off-by: Robin Jarry Acked-by: Stephen Hemminger --- doc/api/doxy-api-ind

Re: [PATCH] net: improve vlan header type alignment

2024-10-18 Thread Thomas Monjalon
13/10/2024 10:35, Morten Brørup: > Ethernet packets can be VLAN tagged, i.e. an Ethernet header can have a > VLAN tag (a.k.a. VLAN header) embedded. > Since the Ethernet header is 2 byte aligned, and the VLAN tag is directly > related to the Ethernet header, the VLAN tag is also 2 byte aligned, so

Re: [PATCH v4] mem: allow using ASan in multi-process mode

2024-10-18 Thread Artur Paszkiewicz
Recheck-request: iol-unit-amd64-testing

Re: [PATCH v1 2/2] baseband/acc: saturate input to 6 bits for VRB decoder

2024-10-18 Thread Maxime Coquelin
On 10/15/24 00:30, Nicolas Chautru wrote: Making the decoder more robust by forcing a default 6 bits LLR saturation to LDPC Decoder input. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/acc/rte_

  1   2   >