Re: [v6,9/9] net/zxdh: add zxdh dev configure ops

2024-10-17 Thread David Marchand
Hello Junlong, On Fri, Oct 18, 2024 at 7:21 AM Junlong Wang wrote: > > Hi, Maintainer > > iol-unit-amd64-testing/ Debian 12 | FAIL > DPDK:fast-tests / bitops_autotest FAIL 1.72 s (exit status 255 or signal > 127 SIGinvalid) > > Do we need to solve this error? We haven't found the de

[PATCH 4/4] net/hns3: support outer VLAN flow match

2024-10-17 Thread Jie Hai
From: Chengwen Feng The hardware FDIR supports many tuples match (including outer vlan), however, the width of hardware entries is limited, therefore, only part of tuples are enabled, unfortunately, outer vlan is not enabled. This commit supports outer vlan match, to avoid affecting the current

[PATCH 2/4] net/hns3: support general tunnel flow match

2024-10-17 Thread Jie Hai
From: Chengwen Feng In the current driver implementation, if you want to configure the same action for all tunnel packets, you need to configure a rule for each specific tunnel packet. e.g: flow create 0 ingress pattern ipv4 / udp / vxlan / end actions ... flow create 0 ingress pattern ipv4

[PATCH 0/4] net/hns3: support more flow pattern match

2024-10-17 Thread Jie Hai
1. support general tunnel flow match 2. support outer VLAN flow match Chengwen Feng (4): net/hns3: restrict FDIR only support one tunnel header net/hns3: support general tunnel flow match net/hns3: add FDIR VLAN match mode param string net/hns3: support outer VLAN flow match doc/guides/n

[PATCH 3/4] net/hns3: add FDIR VLAN match mode param string

2024-10-17 Thread Jie Hai
From: Chengwen Feng This commit adds fdir_vlan_match_mode in RTE_PMD_REGISTER_PARAM_STRING. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_e

[PATCH 1/4] net/hns3: restrict FDIR only support one tunnel header

2024-10-17 Thread Jie Hai
From: Chengwen Feng The device's flow director supports a maximum of one tunnel header, if passed more than one tunnel header from rte-flow API, the driver should return error. Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-b

答复: [PATCH v2 05/18] net/r8169: add support for hw config

2024-10-17 Thread 王颢
Dear Stephen, As you can see, there are some issues with the current code regarding whitespace and CODE_INDENT. I used astyle to adjust the code format with the following command. However, I found that I could not fully meet the checkpatch requirements (unless I modify them manually). Would you

RE: [PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread Chaoyong He
> On Fri, 18 Oct 2024 03:21:28 + > Chaoyong He wrote: > > > > RTE_PKTMBUF_HEADROOM); } > > > > + > > > > > > Not sure why this is needed? What is the problem with the original code? > > > Are you trying to force packets to be segmented? > > > > Actually, we are trying to force packets *not* s

Re: [v6,9/9] net/zxdh: add zxdh dev configure ops

2024-10-17 Thread Junlong Wang
Hi, Maintainer iol-unit-amd64-testing/ Debian 12 | FAIL DPDK:fast-tests / bitops_autotest FAIL 1.72 s (exit status 255 or signal 127 SIGinvalid) Do we need to solve this error? We haven't found the detailed reason for the error in the output log. I noticed that the patches submit

答复: [PATCH v2 03/18] net/r8169: add hardware registers access routines

2024-10-17 Thread 王颢
Dear Stephen, In r8169 pmd, mdelay and udelay are macros. #define mdelay rte_delay_ms #define udelay rte_delay_us Best Regards, Howard Wang -邮件原件- 发件人: Stephen Hemminger 发送时间: 2024年10月18日 0:34 收件人: 王颢 抄送: dev@dpdk.org; pro_nic_d...@realtek.com 主题: Re: [PATCH v2 03/18] net/r8169: add h

[PATCH v2 1/2] power: fix power library with --lcores

2024-10-17 Thread Sivaprasad Tummala
This commit fixes an issue in the power library related to using lcores mapped to different physical cores (--lcores option in EAL). Previously, the power library incorrectly accessed CPU sysfs attributes for power management, treating lcore IDs as CPU IDs. e.g. with --lcores '1@128', lcore_id '1'

[PATCH v2 2/2] test/power: fix power library with --lcores

2024-10-17 Thread Sivaprasad Tummala
When user request to use lcores mapped to different physical cores using --lcores eal option, power application accesses incorrect cpu sysfs attribute for checking current frequency The patch fixes the cpu_id based on the lcore and cpu mappings. Signed-off-by: Sivaprasad Tummala Acked-by: Huison

RE: [PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread Chaoyong He
> On Fri, 18 Oct 2024 10:42:53 +0800 > Chaoyong He wrote: > > > From: Long Wu > > > > The previous code used a macro as the data size for mbuf to create the > > mempool and users cannot modify the size. > > > > Now modify the code to support setting the data size of mbuf by > > '--mbuf-size' par

Re: [PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread Stephen Hemminger
On Fri, 18 Oct 2024 10:42:53 +0800 Chaoyong He wrote: > From: Long Wu > > The previous code used a macro as the data size for mbuf > to create the mempool and users cannot modify the size. > > Now modify the code to support setting the data size of > mbuf by '--mbuf-size' parameter. If user do

RE: [PATCH v1 1/2] power: fix power library with --lcores

2024-10-17 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Lihuisong, > -Original Message- > From: lihuisong (C) > Sent: Thursday, October 17, 2024 5:35 PM > To: Tummala, Sivaprasad ; > david.h...@intel.com; anatoly.bura...@intel.com; jer...@marvell.com; > radu.nico...@intel.com; gak...

Re: [PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread lihuisong (C)
在 2024/10/18 10:42, Chaoyong He 写道: From: Long Wu The previous code used a macro as the data size for mbuf to create the mempool and users cannot modify the size. Now modify the code to support setting the data size of mbuf by '--mbuf-size' parameter. If user does not add the parameter in star

Re: [PATCH RESEND v7 0/5] app/testpmd: support multiple process attach and detach port

2024-10-17 Thread lihuisong (C)
Hi Ferruh, Thanks for your considering again. please see reply inline. 在 2024/10/18 9:04, Ferruh Yigit 写道: On 10/8/2024 3:32 AM, lihuisong (C) wrote: Hi Thomas and Ferruh, We've discussed it on and off a few times, and we've reached some consensus. They've been going through more than 2 years

[PATCH v2] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread Chaoyong He
From: Long Wu The previous code used a macro as the data size for mbuf to create the mempool and users cannot modify the size. Now modify the code to support setting the data size of mbuf by '--mbuf-size' parameter. If user does not add the parameter in start command line, the default size is st

答复: [PATCH v2 11/18] net/r8169: implement Rx path

2024-10-17 Thread 王颢
Dear Stephen, These CamelCase are from our linux kernel drivers. In order to maintain consistency with Linux kernel drivers and facilitate maintenance, our DPDK PMD has adopted this naming convention. May we continue using CamelCase? Best Regards, Howard Wang -邮件原件- 发件人: Stephen Hemmin

Re: [PATCH v3 0/3] bugfix about KEEP CRC offload

2024-10-17 Thread Jie Hai
Hi, all maintainers, Kindly ping for review. Thanks, Jie Hai On 2024/7/19 17:04, Jie Hai wrote: For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is still be stripped in rare scenarios. Some users of hns3 are already using this feature. So driver has to recaculate packet CRC. In a

[PATCH v4 2/2] examples/l3fwd: add option to set mbuf cache size

2024-10-17 Thread Jie Hai
The mempool cache size of mbuf is set to RTE_MEMPOOL_CACHE_MAX_SIZE as default. This patch allows users to configure the cache size by "--mbcache", and limits the parameter to a maximum of RTE_MEMPOOL_CACHE_MAX_SIZE. Signed-off-by: Jie Hai Acked-by: Huisong Li Acked-by: Morten Brørup Acked-by:

[PATCH v4 1/2] examples/l3fwd: add option to set RX burst size

2024-10-17 Thread Jie Hai
Now the Rx burst size is fixed to MAX_PKT_BURST (32). This parameter needs to be modified in some performance optimization scenarios. So an option '--burst' is added to set the burst size explicitly. The default value is DEFAULT_PKT_BURST (32) and maximum value is MAX_PKT_BURST (512). Signed-off-b

[PATCH v4 0/2] examples/l3fwd: add more options

2024-10-17 Thread Jie Hai
Add options to support configuring RX burst size and cache size of mbuf mempoool. -- v4: 1. fix help info. v3: 1. add Acked-bys. 2. fix compile error. -- Jie Hai (2): examples/l3fwd: add option to set RX burst size examples/l3fwd: add option to set mbuf cache size examples/l3fwd/l3fwd.h

Re: [PATCH v4 0/6] refine argparse library

2024-10-17 Thread fengchengwen
Hi Thomas and David, This patchset was already acked by Stephen. It missed in DPDK 24.07, hope merge in 24.11. Thanks On 2024/10/10 9:35, fengchengwen wrote: > Hi Thomas and David, > > Kindly ping for merge. > > On 2024/10/10 3:33, Stephen Hemminger wrote: >> On Mon, 18 Mar 2024 11:18:32 +

Re: [PATCH RESEND v7 0/5] app/testpmd: support multiple process attach and detach port

2024-10-17 Thread Ferruh Yigit
On 10/8/2024 3:32 AM, lihuisong (C) wrote: > Hi Thomas and Ferruh, > > We've discussed it on and off a few times, and we've reached some > consensus. > They've been going through more than 2 years😅 > Can you have a look at this series again? > If we really don't need it, I will drop it from my ups

RE: [PATCH dpdk v2] net: add more icmp types and code

2024-10-17 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Friday, 18 October 2024 00.42 > > Add more ICMP message types and codes based on RFC 792. Change the > namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow > differentiation > between types and codes. > > Do not include deprecated message

RE: [PATCH 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-17 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 17 October 2024 21.35 > > On Thu, 17 Oct 2024 20:03:13 +0100 > Bruce Richardson wrote: > > > On Thu, Oct 17, 2024 at 07:15:10PM +0200, Morten Brørup wrote: > > > > +/** > > > > + * Process the IPv4 checksum of an IPv

Re: [PATCH] net/gve: replace typedefs with macros in gve osdep

2024-10-17 Thread Ferruh Yigit
On 10/18/2024 12:42 AM, Joshua Washington wrote: > Currently, a number of integer types are typedef'd to their > corresponding upserspace or RTE values. This can be problematic if these > types are already defined somewhere else, as it would cause type > collisions. This patch changes the typedefs

Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues

2024-10-17 Thread Ferruh Yigit
On 10/17/2024 8:20 PM, lon...@linuxonhyperv.com wrote: > From: Alan Elder > > The previous code allowed the number of Tx queues to be set higher than > the number of Rx queues. If a packet was sent on a Tx queue with index >> = number Rx queues there was a segfault due to accessing beyond the en

Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues

2024-10-17 Thread Ferruh Yigit
On 10/18/2024 12:02 AM, Stephen Hemminger wrote: > On Thu, 17 Oct 2024 22:38:49 + > Long Li wrote: > >>> Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues >>> >>> On Thu, 17 Oct 2024 12:20:29 -0700 >>> lon...@linuxonhyperv.com wrote: >>> +static void +hn_rx_que

[PATCH] net/gve: replace typedefs with macros in gve osdep

2024-10-17 Thread Joshua Washington
Currently, a number of integer types are typedef'd to their corresponding upserspace or RTE values. This can be problematic if these types are already defined somewhere else, as it would cause type collisions. This patch changes the typedefs to #define macros which are only defined if the types are

RE: [PATCH] net: improve vlan header type alignment

2024-10-17 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 17 October 2024 22.44 > > 13/10/2024 10:35, Morten Brørup: > > +static_assert(sizeof(struct rte_ether_addr) == 6, > > + "sizeof(struct rte_ether_addr) == 6"); > > +static_assert(alignof(struct rte_ether_addr) == 2, >

Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues

2024-10-17 Thread Ferruh Yigit
Recheck-request: intel-Functional, intel-Testing

Re: Build issue with Fedora Rawhide

2024-10-17 Thread Joshua Washington
Hello, I have a fix that changes all typedefs in gve_osdep.h to #defines. It should be going out shortly. On Thu, Oct 17, 2024 at 5:12 AM David Marchand wrote: > > Hello guys, > > I am not clear if this issue is new (and what caused it), but > compilation fails on Rawhide for the net/gve driver (

[PATCH 2/2] gpudev: add malloc annotations to rte_gpu_mem_alloc

2024-10-17 Thread Stephen Hemminger
Add function attributes that allow detecting use after free, and calling free on bad pointer at compile time. Signed-off-by: Stephen Hemminger --- lib/gpudev/rte_gpudev.h | 46 + 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/lib/gpudev/rt

[PATCH 1/2] test-gpudev: avoid use-after-free and free-non-heap warnings

2024-10-17 Thread Stephen Hemminger
This test intentionally frees a bad pointer in GPU memory, and GCC sees that at compile time. Suppress the warnings to allow the test to run. Signed-off-by: Stephen Hemminger --- app/test-gpudev/main.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/app/test-gpudev/

[PATCH 0/2] gpudev: annotate memory allocation

2024-10-17 Thread Stephen Hemminger
Use function attributes to catch misuse of GPU memory at compile time. Stephen Hemminger (2): test-gpudev: avoid use-after-free and free-non-heap warnings gpudev: add malloc annotations to rte_gpu_mem_alloc app/test-gpudev/main.c | 10 - lib/gpudev/rte_gpudev.h | 46

Re: [PATCH] net/nfp: fix RSS failed on VXLAN inner layer

2024-10-17 Thread Ferruh Yigit
On 10/16/2024 9:17 AM, Chaoyong He wrote: > From: Long Wu > > Before the commit 5126a904fae0 > ("net/nfp: use offload flag to control VXLAN configuration"), > in the initial logic 'nfp_net_start()' will enable the > NFP_NET_CFG_CTRL_VXLAN flag if hardware has the capability, > 'udp_tunnel_port_ad

Re: [PATCH dpdk] net: add more icmp types and code

2024-10-17 Thread Ferruh Yigit
On 10/17/2024 11:33 PM, Robin Jarry wrote: > Ferruh Yigit, Oct 18, 2024 at 00:22: >> On 10/17/2024 5:02 PM, Stephen Hemminger wrote: >>> On Thu, 17 Oct 2024 10:33:22 +0200 >>> Robin Jarry wrote: >>> Add more ICMP message types and codes based on RFC 792. Change the namespace prefix from

[PATCH dpdk v2] net: add more icmp types and code

2024-10-17 Thread Robin Jarry
Add more ICMP message types and codes based on RFC 792. Change the namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow differentiation between types and codes. Do not include deprecated message types as described in RFC 6918. Link: https://www.rfc-editor.org/rfc/rfc792 Link: https://www.rfc-

RE: [Patch v5] net/netvsc: fix number Tx queues > Rx queues

2024-10-17 Thread Long Li
> Subject: Re: [Patch v5] net/netvsc: fix number Tx queues > Rx queues > > On Thu, 17 Oct 2024 12:20:29 -0700 > lon...@linuxonhyperv.com wrote: > > > +static void > > +hn_rx_queue_free_common(struct hn_rx_queue *rxq) { > > + if (!rxq) > > + return; > > + > > + rte_free(rxq->rxbuf_in

Re: [PATCH dpdk] net: add more icmp types and code

2024-10-17 Thread Robin Jarry
Ferruh Yigit, Oct 18, 2024 at 00:22: On 10/17/2024 5:02 PM, Stephen Hemminger wrote: On Thu, 17 Oct 2024 10:33:22 +0200 Robin Jarry wrote: Add more ICMP message types and codes based on RFC 792. Change the namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow differentiation between types

Re: [PATCH dpdk] net: add more icmp types and code

2024-10-17 Thread Ferruh Yigit
On 10/17/2024 5:02 PM, Stephen Hemminger wrote: > On Thu, 17 Oct 2024 10:33:22 +0200 > Robin Jarry wrote: > >> Add more ICMP message types and codes based on RFC 792. Change the >> namespace prefix from RTE_IP_ICMP_ to RTE_ICMP_ to allow differentiation >> between types and codes. >> >> Signed-of

Re: [PATCH v1 1/1] mldev: add scale and zero point to I/O info struct

2024-10-17 Thread Thomas Monjalon
31/07/2024 08:25, Srikanth Yalavarthi: > Added scale and zero point to I/O information structure. > This would provision sharing the recommended sclae factor > and zero point to the user for quantization process. > > Signed-off-by: Srikanth Yalavarthi Applied with a Doxygen comment fixed.

RE: [PATCH] maintainers: remove Pallavi as windows maintainer

2024-10-17 Thread Kadam, Pallavi
-Original Message- From: Richardson, Bruce Sent: Thursday, October 17, 2024 11:59 AM To: dev@dpdk.org Cc: Kadam, Pallavi ; Richardson, Bruce Subject: [PATCH] maintainers: remove Pallavi as windows maintainer Pallavi Kadam is no longer working on DPDK, so she has requested that her n

Community Call for Adding Support of PCIe Steering Tags Support in DPDK

2024-10-17 Thread Wathsala Wathawana Vithanage
A DPDK community call on adding support for PCIe steering tags is scheduled for 10/23/24 at 9AM CST. Steering tags allow for the stashing of descriptors and packet data closer to the CPUs, possibly allowing for lower latency and higher throughput. This feature requires contributions from CPU vend

Re: [PATCH v1 1/1] mldev: introduce data type conversion functions

2024-10-17 Thread Thomas Monjalon
31/07/2024 08:32, Srikanth Yalavarthi: > Introduced data type conversion functions with support for > user defined scale factor and zero-point. Updated library > functions to support asymmetric / affine conversion for > integer types. > > Signed-off-by: Srikanth Yalavarthi Applied, thanks.

Re: [PATCH v1 1/1] mldev: support get queue pair count

2024-10-17 Thread Thomas Monjalon
31/07/2024 08:13, Srikanth Yalavarthi: > Added API to get ML device queue-pair count. > > Signed-off-by: Srikanth Yalavarthi Applied, thanks.

Re: [PATCH] mbuf: add transport mode ESP packet type

2024-10-17 Thread Thomas Monjalon
Please could we have another review? 22/08/2024 17:32, Alexander Kozyrev: > Support the IP Encapsulating Security Payload (ESP) in transport mode. > Currently, we have RTE_PTYPE_TUNNEL_ESP for the ESP tunnel mode. > Transport mode can be detected by parsing the "Next Header" field. > The Next Hea

Re: [PATCH] net: improve vlan header type alignment

2024-10-17 Thread Thomas Monjalon
13/10/2024 10:35, Morten Brørup: > +static_assert(sizeof(struct rte_ether_addr) == 6, > + "sizeof(struct rte_ether_addr) == 6"); > +static_assert(alignof(struct rte_ether_addr) == 2, > + "alignof(struct rte_ether_addr) == 2"); Instead of repeating the condition twice, it wo

DPDK - PCIe Steering Tags Meeting on 10/23/24

2024-10-17 Thread Wathsala Wathawana Vithanage
Hi all, This is an invitation to discuss adding PCIe steering tags support to DPDK. We have had brief conversations over the idea at the DPDK summit. Steering tags allows stashing of descriptors and packet data closer to the CPUs, possibly allowing for lower latency and higher throughput. This

Re: [PATCH dpdk v2] mbuf: fix strict aliasing error in allocator

2024-10-17 Thread Thomas Monjalon
25/09/2024 17:47, Stephen Hemminger: > On Wed, 25 Sep 2024 11:40:54 -0400 > Robin Jarry wrote: > > > From: Robin Jarry > > To: dev@dpdk.org > > Subject: [PATCH dpdk v2] mbuf: fix strict aliasing error in allocator > > Date: Wed, 25 Sep 2024 11:40:54 -0400 > > > > When building an application wi

Re: [PATCH 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 20:03:13 +0100 Bruce Richardson wrote: > On Thu, Oct 17, 2024 at 07:15:10PM +0200, Morten Brørup wrote: > > > +/** > > > + * Process the IPv4 checksum of an IPv4 header without any extensions. > > > + * > > > + * The checksum field does NOT have to be set by the caller, the fi

Re: [PATCH v11 05/12] common/zsda: configure zsda queue base functions

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 17:22:02 +0800 Hanxiao Li wrote: > +static int > +zsda_get_queue_cfg_by_id(const struct zsda_pci_device *zsda_pci_dev, > + const uint8_t qid, struct qinfo *qcfg) > +{ > + struct zsda_admin_req_qcfg req = {0}; > + struct zsda_admin_resp_qcfg resp =

Re: [PATCH v11 00/12] drivers/zsda: introduce zsda drivers

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 17:21:57 +0800 Hanxiao Li wrote: > v11: > - use RTE_LOG_LINE in logging macro. > - fix some known bugs. > > v10: > - delete new blank line at EOF > - Cleaning up some code in zsda_log.h > > v9: > - add a new feature in default.ini. > - Re-split the patch according to the ne

RE: [PATCH v4] net/netvsc: fix number Tx queues > Rx queues

2024-10-17 Thread Long Li
> This version of the patch is garbled in patchwork which means the CI test > never > ran because patch would not apply. > > You need cleanup and resubmit it. I have sent v5 on behalf of Alan.

[Patch v5] net/netvsc: fix number Tx queues > Rx queues

2024-10-17 Thread longli
From: Alan Elder The previous code allowed the number of Tx queues to be set higher than the number of Rx queues. If a packet was sent on a Tx queue with index >= number Rx queues there was a segfault due to accessing beyond the end of the dev->data->rx_queues[] array. This commit fixes the iss

Re: [PATCH] examples/l3fwd: support setting the data size of mbuf

2024-10-17 Thread Stephen Hemminger
On Wed, 16 Oct 2024 16:22:32 +0800 Chaoyong He wrote: > From: Long Wu > > The previous code used a macro as the data size for mbuf > to create the mempool and users cannot modify the size. > > Now modify the code to support setting the data size of > mbuf by '--mbuf-size' parameter. If user do

Re: [PATCH 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-17 Thread Bruce Richardson
On Thu, Oct 17, 2024 at 07:15:10PM +0200, Morten Brørup wrote: > > +/** > > + * Process the IPv4 checksum of an IPv4 header without any extensions. > > + * > > + * The checksum field does NOT have to be set by the caller, the field > > + * is skipped by the calculation. > > + * > > + * @param ipv4_

[PATCH] maintainers: remove Pallavi as windows maintainer

2024-10-17 Thread Bruce Richardson
Pallavi Kadam is no longer working on DPDK, so she has requested that her name be removed from the maintainers file. Signed-off-by: Bruce Richardson --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6814991735..05a5aa4b97 100644 --- a/MAINTAINERS

RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op

2024-10-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Friday, October 11, 2024 2:18 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Dooley, Brian > Subject: RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op > > > In the case when PMD cannot support the full process of the

Updated Invitation: Adding support for PCIe steering tags in DPDK

2024-10-17 Thread Data Plane Development Kit - Meetings
This meeting has changed times. The instructions to join the call are the same. Adding support for PCIe steering tags in DPDK

[DPDK/DTS Bug 1567] dts: Replace the helloworld testsuite with a testsuite which starts testpmd but does nothing

2024-10-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1567 Bug ID: 1567 Summary: dts: Replace the helloworld testsuite with a testsuite which starts testpmd but does nothing Product: DPDK Version: unspecified Hardware: All

Rescheduling next week's DTS meeting

2024-10-17 Thread Patrick Robb
Hello, There is a joint Governing Board & Tech Board meeting next Thursday (October 24) at 9AM EST, when we normally have the DTS meeting. I think I need to be available to join this, so we will need to reschedule the DTS call. I am going to preliminarily move it to Friday at the normal time, but

Re: [PATCH dpdk v3 00/17] IPv6 APIs overhaul

2024-10-17 Thread Robin Jarry
David Marchand, Oct 17, 2024 at 15:52: Hello Robin, [snip] - Now that many changes hit the main repo, this series needs some rebasing (conflicts are not too difficult, but having this rebase run through a bit in the CI would be great). Will do. - From a compatibility pov, I am not fond of

Re: [PATCH] Revert "build: disable gcc 10 zero-length-bounds warning"

2024-10-17 Thread Thomas Monjalon
14/10/2024 09:58, Bruce Richardson: > On Fri, Oct 11, 2024 at 10:57:10AM -0700, Stephen Hemminger wrote: > > The zero length array warning can be re-enabled. > > The zero length marker fields are now removed by > > commit 9e152e674c77 ("mbuf: remove marker fields") > > in DPDK 24.03. > > > > This

Re: [PATCH] power: don't disable all cast qualifier warnings

2024-10-17 Thread Thomas Monjalon
13/08/2024 08:11, Morten Brørup: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > > Only in one place does the power library need un-constify a pointer > > and this can be done by casting to uintptr_t first. Better, to have > > the warning enabled across the rest of the code.

Re: [PATCH v6 1/1] dmadev: support strict priority configuration

2024-10-17 Thread Thomas Monjalon
11/10/2024 12:12, Vamsi Krishna: > From: Vamsi Attunuru > > Some DMA controllers offer the ability to configure priority > level for the DMA channels, allowing for the prioritization > of DMA command execution based on channel importance. > > This patch supports such strict priority configuratio

Re: [PATCH v26 05/15] eal: do not duplicate rte_init_alert() messages

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 18:47:54 +0200 David Marchand wrote: > > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > > index 40d750ed0d..c53a051405 100644 > > --- a/lib/eal/linux/eal.c > > +++ b/lib/eal/linux/eal.c > > @@ -830,8 +830,7 @@ rte_eal_iopl_init(void) > > > > static void rte_eal_init

RE: [PATCH 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-17 Thread Morten Brørup
> +/** > + * Process the IPv4 checksum of an IPv4 header without any extensions. > + * > + * The checksum field does NOT have to be set by the caller, the field > + * is skipped by the calculation. > + * > + * @param ipv4_hdr > + * The pointer to the contiguous IPv4 header. > + * @return > + *

[PATCH] doc: fix Sphinx build without RTD theme

2024-10-17 Thread Thomas Monjalon
DTS is using a specific configuration of Sphinx which is supported only with the theme Read The Docs. If not available, this error may be seen: unsupported theme option 'collapse_navigation' given In order to allow doc generation without this theme, a check is added to make the specific co

Re: [PATCH 0/6] Reduce scope address-of-packed-member warning

2024-10-17 Thread Bruce Richardson
On Thu, Oct 17, 2024 at 09:21:48AM -0700, Stephen Hemminger wrote: > On Thu, 17 Oct 2024 15:22:07 +0100 > Bruce Richardson wrote: > > > The warning for address-of-packed-member was being disabled globally in > > DPDK. While for drivers which need to access hardware-defined > > data-structures th

Re: [PATCH 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-17 Thread Bruce Richardson
On Thu, Oct 17, 2024 at 09:24:37AM -0700, Stephen Hemminger wrote: > On Thu, 17 Oct 2024 15:22:12 +0100 > Bruce Richardson wrote: > > > There are multiple instances in the DPDK app folder where we set up an > > IP header and then compute the checksum field by direct addition of > > nine uint16_t

Re: [PATCH v26 05/15] eal: do not duplicate rte_init_alert() messages

2024-10-17 Thread David Marchand
Hello, On Wed, Oct 16, 2024 at 10:24 PM Stephen Hemminger wrote: > > The message already goes through logging, and does not need > to be printed on stderr. Message level should be ALERT > to match function name. > > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > Acked-by: Morten

Re: [PATCH v2 05/18] net/r8169: add support for hw config

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 14:31:47 +0800 Howard Wang wrote: > Implement the rtl_hw_config function to configure the hardware. > > Signed-off-by: Howard Wang More indent issues flagged in this patch ERROR:CODE_INDENT: code indent should use tabs where possible #292: FILE: drivers/net/r8169/r8169_hw.

Re: [PATCH v2 02/18] net/r8169: add logging structure

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 14:31:44 +0800 Howard Wang wrote: > Implement logging macros for debug purposes. > > Signed-off-by: Howard Wang > --- > drivers/net/r8169/r8169_ethdev.c | 40 > drivers/net/r8169/r8169_logs.h | 53 > 2 files change

Re: [PATCH v2 00/18] net/r8169: add r8169 pmd to dpdk

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 14:31:42 +0800 Howard Wang wrote: > PATCH v2: modify some code as suggested by the maintainer. > > Howard Wang (18): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core

Re: [PATCH v2 03/18] net/r8169: add hardware registers access routines

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 14:31:45 +0800 Howard Wang wrote: > +u32 > +rtl_csi_read(struct rtl_hw *hw, u32 addr) > +{ > + u32 cmd; > + int i; > + u32 value = 0; > + > + cmd = CSIAR_Read | CSIAR_ByteEn << CSIAR_ByteEn_shift | > + (addr & CSIAR_Addr_Mask); > + > + RTL_W32(hw,

Re: [PATCH v2 18/18] doc/guides/nics: add documents for r8169 pmd

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 14:32:00 +0800 Howard Wang wrote: > Signed-off-by: Howard Wang > --- > MAINTAINERS| 2 ++ > doc/guides/nics/features/r8169.ini | 32 ++ > doc/guides/nics/index.rst | 1 + > doc/guides/nics/r8169.rst | 17

Re: [RESEND 0/2] dmadev: clean code for dmadev

2024-10-17 Thread Thomas Monjalon
12/10/2024 11:17, Jie Hai: > This patch set make clean codes for dmadev. > > Chengwen Feng (2): > dmadev: fix potential null pointer access > dmadev: clean code for verify parameter Series applied, thanks.

RE: [PATCH 1/6] ip_frag: remove use of unaligned variable

2024-10-17 Thread Konstantin Ananyev
> If compiling with -Waddress-of-packed-member, we get a warning about the > use of the unaligned uint64_t value which is used to copy 8 bytes from > ip_hdr to the key. Replace this unaligned assignment with an equivalent > 8-byte constant-sized memcpy, allowing the compiler to choose optimal >

Re: [PATCH v2 01/18] net/r8169: add PMD driver skeleton

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 14:31:43 +0800 Howard Wang wrote: > Meson build infrastructure, r8169_ethdev minimal skeleton, > header with Realtek NIC device and vendor IDs. > > Signed-off-by: Howard Wang ERROR:CODE_INDENT: code indent should use tabs where possible #311: FILE: drivers/net/r8169/r8169_e

Re: [PATCH 3/6] bus/ifpga: remove packed attribute

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 15:22:10 +0100 Bruce Richardson wrote: > The struct rte_afu_device does not need to be packed, so remove the > packed attribute from it. > > Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger

Re: [PATCH 1/6] ip_frag: remove use of unaligned variable

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 15:22:08 +0100 Bruce Richardson wrote: > If compiling with -Waddress-of-packed-member, we get a warning about the > use of the unaligned uint64_t value which is used to copy 8 bytes from > ip_hdr to the key. Replace this unaligned assignment with an equivalent > 8-byte constan

Re: [PATCH 4/6] pipeline: remove packed attribute

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 15:22:11 +0100 Bruce Richardson wrote: > The rte_trtcm_data structure, and its substructures, only consist of > uint64_t types. This makes packing unnecessary to remove the packed > attribute from the structure. > > Signed-off-by: Bruce Richardson Acked-by: Stephen Hemminger

Re: [PATCH 2/6] efd: remove unnecessary packed attributes

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 15:22:09 +0100 Bruce Richardson wrote: > The structure "efd_online_group_entry" only consists of values which are > typedefs of "uint16_t", so packing the structure has no effect. The > "efd_online_chunk" structure has a mix of "uint8_t" and the > "efd_online_group_entry" stru

Re: [PATCH] git: show hidden tracked files

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 17:15:03 +0200 Thomas Monjalon wrote: > The hidden files are not considered because of the first rule in > .gitignore file. > > In order to see changes in the hidden tracked files, > they are added in .gitignore as explicit include rules. > > The derivatives of the first lev

Re: [PATCH 0/6] Reduce scope address-of-packed-member warning

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 15:22:07 +0100 Bruce Richardson wrote: > The warning for address-of-packed-member was being disabled globally in > DPDK. While for drivers which need to access hardware-defined > data-structures the use of packed may make sense, for normal libs and > applications the use of p

Re: [PATCH v5 0/5] power: refactor power management library

2024-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2024 10:26:44 + Sivaprasad Tummala wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers

Re: [PATCH v3] bus/fslmc/dpaa2: replace system("echo ...") with file i/o

2024-10-17 Thread Thomas Monjalon
26/08/2024 18:11, Stephen Hemminger: > Using system() is a bad idea in driver code because it introduces > a number of potential security issues. The codeql analysis tool > flags this a potential security issue. > > Instead just use normal stdio to do the same thing. > > Compile test only, do not

[PATCH] crypto/openssl: fix potential string overflow

2024-10-17 Thread Stephen Hemminger
The algorithm name is a string and should be copied with strlcpy() rather than rte_memcpy(). This fixes a warning detected with clang and ASAN. Bugzilla ID: 1565 Fixes: 2b9c693f6ef5 ("crypto/openssl: support AES-CMAC operations") Cc: asek...@marvell.com Signed-off-by: Stephen Hemminger --- driv

Re: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size

2024-10-17 Thread Thomas Monjalon
11/10/2024 05:24, Chaoyong He: > From: Long Wu > > The testpmd application can not modify the value of > dedicated hardware Rx/Tx queue size, and hardcoded > them as (128/512). This will cause the bonding port > start fail if some NIC requires more Rx/Tx descriptors > than the hardcoded number. >

Re: [PATCH v2] net/bonding: add user callback for bond xmit policy

2024-10-17 Thread Thomas Monjalon
15/10/2024 10:20, vignesh.purushotham.srini...@ericsson.com: > From: Vignesh PS > > Add support to bonding PMD to allow user callback > function registration for TX transmit policy. > > Signed-off-by: Vignesh PS We have a lack of reviews on bonding patches. Please could you have a try to look

Re: [v1 2/3] meson: add a meson option to install examples source

2024-10-17 Thread Thomas Monjalon
07/08/2024 06:08, Gagandeep Singh: > From: Bruce Richardson > > On Tue, Aug 06, 2024 at 07:12:17PM +0530, Gagandeep Singh wrote: > > > Adding a meson option "enable_examples_source_install" > > > to enable or disable installation of examples source code. > > > > > > Default value is true. > > > >

Re: [v1 1/3] meson: add a meson option to install examples

2024-10-17 Thread Thomas Monjalon
07/08/2024 06:09, Gagandeep Singh: > From: Bruce Richardson > > On Tue, Aug 06, 2024 at 07:12:16PM +0530, Gagandeep Singh wrote: > > > Adding a meson option "enable_examples_bin_install" > > > to install the examples binaries in bin. > > > > > > Default value is false. > > > > > > Signed-off-by: G

Re: [PATCH] usertools/devbind: add support for non-IOMMU mode

2024-10-17 Thread Thomas Monjalon
03/10/2024 11:27, Bruce Richardson: > On Wed, Oct 02, 2024 at 11:13:12AM -0700, Stephen Hemminger wrote: > > From: Fidaullah Noonari > > > > This patch adds noiommu option to dpdk-devbind. > > If the no IOMMU is detected, then if noiommu flag is set > > the vfio-pci unsafe_noiommu_mode flag is se

[PATCH] git: show hidden tracked files

2024-10-17 Thread Thomas Monjalon
The hidden files are not considered because of the first rule in .gitignore file. In order to see changes in the hidden tracked files, they are added in .gitignore as explicit include rules. The derivatives of the first level files are also shown. Example: .mailmap.rej Signed-off-by: Thomas Monj

[PATCH v4] hash: separate creation parameters checks

2024-10-17 Thread Thomas Monjalon
From: Niall Meade Separate name, entries and key_len parameter checks in rte_hash_create(). Also make the error messages more informative/verbose to help with debugging. Signed-off-by: Niall Meade Acked-by: Stephen Hemminger --- v4: formatting details sent for triggering a new CI run ---

RE: [PATCH 3/6] bus/ifpga: remove packed attribute

2024-10-17 Thread Xu, Rosen
Hi, > -Original Message- > From: Richardson, Bruce > Sent: Thursday, October 17, 2024 10:22 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Xu, Rosen > > Subject: [PATCH 3/6] bus/ifpga: remove packed attribute > > The struct rte_afu_device does not need to be packed, so remove the > pac

Re: [PATCH 4/6] pipeline: remove packed attribute

2024-10-17 Thread Bruce Richardson
On Thu, Oct 17, 2024 at 03:22:11PM +0100, Bruce Richardson wrote: > The rte_trtcm_data structure, and its substructures, only consist of > uint64_t types. This makes packing unnecessary to remove the packed s/to/, so/ > attribute from the structure. > > Signed-off-by: Bruce Richardson > --- >

  1   2   >