Re: [PATCH] fib: network byte order IPv4 lookup

2024-09-27 Thread David Marchand
On Fri, Sep 6, 2024 at 1:07 PM Vladimir Medvedkin wrote: > > Previously when running rte_fib_lookup IPv4 addresses must have been in > host byte order. > > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on > fib create, which will allow to have IPv4 in network byte order on >

Re: [PATCH] fib: implement RCU rule reclamation

2024-09-27 Thread David Marchand
On Fri, Sep 27, 2024 at 6:13 PM Robin Jarry wrote: > > Vladimir Medvedkin, Sep 06, 2024 at 13:09: > > Currently, for DIR24-8 algorithm, the tbl8 group is freed even though the > > readers might be using the tbl8 group entries. The freed tbl8 group can > > be reallocated quickly. As a result, looku

Re: [PATCH v3] net/nfp: implement the device packet type set interface

2024-09-27 Thread Ferruh Yigit
On 9/27/2024 4:10 AM, Chaoyong He wrote: > From: Long Wu > > Using the Rx packet offload flag rather than the device > capability to control the packet type offload configuration. > Also implement the device packet type set interface to > let application can set the Rx packet offload flag. > > S

Re: [PATCH v2 1/1] ethdev: fix int overflow in descriptor count logic

2024-09-27 Thread Ferruh Yigit
On 9/27/2024 2:23 PM, Niall Meade wrote: > Addressed a specific overflow issue in the eth_dev_adjust_nb_desc() > function where the uint16_t variable nb_desc would overflow when its > value was greater than (2^16 - nb_align). This overflow caused nb_desc > to incorrectly wrap around between 0 and n

Re: [PATCH 01/16] eal: add function attributes for allocation functions

2024-09-27 Thread Stephen Hemminger
On Fri, 27 Sep 2024 18:09:22 -0400 David Marchand wrote: > On Fri, Sep 27, 2024 at 4:48 PM Stephen Hemminger > wrote: > > > > The allocation functions take a alignment argument that > > can be useful to hint the compiler optimizer. > > > > This is supported by Gcc and Clang but only useful with

Re: [PATCH v4 01/11] dts: add the aenum dependency

2024-09-27 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v4 02/11] dts: add test case decorators

2024-09-27 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

[PATCH 4/7] dts: add the ability to copy directories via remote

2024-09-27 Thread Tomáš Ďurovec
Before, the remote session did't allows to copy directories, only files. This feature will be used in future commit. Signed-off-by: Tomáš Ďurovec --- dts/framework/testbed_model/os_session.py| 120 ++- dts/framework/testbed_model/posix_session.py | 88 +- dts/fra

Re: [PATCH 01/16] eal: add function attributes for allocation functions

2024-09-27 Thread David Marchand
On Fri, Sep 27, 2024 at 4:48 PM Stephen Hemminger wrote: > > The allocation functions take a alignment argument that > can be useful to hint the compiler optimizer. > > This is supported by Gcc and Clang but only useful with > Gcc because Clang gives warning if alignment is 0. > > Recent versions

FreeBSD problem with ixgbe

2024-09-27 Thread Lewis Donzis
I'm pretty sure this is been reported before, but in ixgbe_ethdev.c, line 4311 begins: /* BSD has no interrupt mechanism, so force NIC status synchronization. */ #ifdef RTE_EXEC_ENV_FREEBSD wait = 1; #endif We've had to remove this code ever since it was added because it causes improper

Re: [PATCH v6 0/2] Add link_speed lanes support

2024-09-27 Thread Ferruh Yigit
On 9/26/2024 10:43 PM, Damodharam Ammepalli wrote: > This patch series is a continuation of the patch set that supports > configuring speed lanes. > https://patchwork.dpdk.org/project/dpdk/patch/20240708232351.491529-1- > damodharam.ammepa...@broadcom.com/ > > The patchset consists > 1) rtelib/te

[PATCH 7/7] dts: remove git ref option

2024-09-27 Thread Tomáš Ďurovec
In the previous commits we're adding the support for copying the whole local DPDK tree directory and git-ref option was meant to do the same thing. Signed-off-by: Tomáš Ďurovec --- doc/guides/tools/dts.rst | 9 --- dts/framework/settings.py | 51 +++- dts/framework/utils.py|

[PATCH 6/7] doc: update argument options for external DPDK build

2024-09-27 Thread Tomáš Ďurovec
By adding support for external build, we extend the argument documentation for supported options. Signed-off-by: Tomáš Ďurovec --- doc/guides/tools/dts.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst index 65cce

[PATCH v12 1/4] lib: add generic support for reading PMU events

2024-09-27 Thread Tomasz Duszynski
Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performance. Signed

[PATCH 1/7] dts: rename build target to DPDK build

2024-09-27 Thread Tomáš Ďurovec
Since the DPDK may already be built, some more general name is needed that includes both the DPDK location and the build config (if we are going to build). Signed-off-by: Tomáš Ďurovec --- dts/conf.yaml | 2 +- dts/framework/config/__init__.py | 26 ++---

Re: [PATCH] fib: implement RCU rule reclamation

2024-09-27 Thread Robin Jarry
Vladimir Medvedkin, Sep 06, 2024 at 13:09: Currently, for DIR24-8 algorithm, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. As a result, lookup may be performed incorrectly. To address that, RCU QSBR is inte

[PATCH 7/7] dts: remove git ref option

2024-09-27 Thread Tomáš Ďurovec
In the previous commits we're adding the support for copying the whole local DPDK tree directory and git-ref option was meant to do the same thing. Signed-off-by: Tomáš Ďurovec --- doc/guides/tools/dts.rst | 9 --- dts/framework/settings.py | 51 +++- dts/framework/utils.py|

[PATCH 5/7] dts: add support for externally compiled DPDK

2024-09-27 Thread Tomáš Ďurovec
Add support for using DPDK source tree directory as well as DPDK tarball with the pre-build directory that can user specify and type of location, it can be stored in the local filesystem or SUT node. Additionally, this can be set up with the config file or cmd arguments/environment variables. Sign

[PATCH 4/7] dts: add the ability to copy directories via remote

2024-09-27 Thread Tomáš Ďurovec
Before, the remote session did't allows to copy directories, only files. This feature will be used in future commit. Signed-off-by: Tomáš Ďurovec --- dts/framework/testbed_model/os_session.py| 120 ++- dts/framework/testbed_model/posix_session.py | 88 +- dts/fra

[PATCH 2/7] dts: one dpdk build per test run

2024-09-27 Thread Tomáš Ďurovec
When the DPDK build can be already pre-build, there is not a need for defining multiple build targets. To make it cleaner we decide to use one DPDK build wheater can be pre-build or DTS will build it. Signed-off-by: Tomáš Ďurovec --- dts/conf.yaml | 14 +-- dts/fram

[PATCH 3/7] dts: fix remote session file transfer vars

2024-09-27 Thread Tomáš Ďurovec
The OSSession (and its subclasses) should accept PurePaths for remote paths to translate from OS-unaware (PurePath) to OS-aware (Path) only on the remote side. For local paths, they should accept Paths, as Python is OS-aware locally. Signed-off-by: Tomáš Ďurovec --- .../remote_session/remote_ses

[PATCH 1/7] dts: rename build target to DPDK build

2024-09-27 Thread Tomáš Ďurovec
Since the DPDK may already be built, some more general name is needed that includes both the DPDK location and the build config (if we are going to build). Signed-off-by: Tomáš Ďurovec --- dts/conf.yaml | 2 +- dts/framework/config/__init__.py | 26 ++---

[PATCH 0/7] DTS external DPDK build

2024-09-27 Thread Tomáš Ďurovec
This patch series adds ability to use pre-build DPDK in various options of usage. User can specify this option from config file or cmd arguments/environment variables: * The source of DPDK (tarball or tree), * The build dir witch will be located in a subdirectory of DPDK tree root directory, oth

[PATCH v12 2/4] pmu: support reading ARM PMU events in runtime

2024-09-27 Thread Tomasz Duszynski
Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 4 ++ lib/pmu/meson.build | 8 lib/pmu/pmu_arm64.c | 94 + lib/pmu/rte_pmu.h | 4 ++ lib/pmu/rte_pmu_pmc_arm6

[PATCH 6/7] doc: update argument options for external DPDK build

2024-09-27 Thread Tomáš Ďurovec
By adding support for external build, we extend the argument documentation for supported options. Signed-off-by: Tomáš Ďurovec --- doc/guides/tools/dts.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst index 65cce

Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

2024-09-27 Thread Meade, Niall
>On 9/26/2024 3:03 PM, Meade, Niall wrote: >>> From: Ferruh Yigit >>> Sent: Thursday, September 26, 2024 12:16 AM >>> To: Meade, Niall ; Thomas Monjalon >>> ; Andrew Rybchenko ; >>> Roman Zhukov >>> Cc: dev@dpdk.org >>> Subject: Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

[PATCH 5/7] dts: add support for externally compiled DPDK

2024-09-27 Thread Tomáš Ďurovec
Add support for using DPDK source tree directory as well as DPDK tarball with the pre-build directory that can user specify and type of location, it can be stored in the local filesystem or SUT node. Additionally, this can be set up with the config file or cmd arguments/environment variables. Sign

[PATCH v2 1/1] ethdev: fix int overflow in descriptor count logic

2024-09-27 Thread Niall Meade
Addressed a specific overflow issue in the eth_dev_adjust_nb_desc() function where the uint16_t variable nb_desc would overflow when its value was greater than (2^16 - nb_align). This overflow caused nb_desc to incorrectly wrap around between 0 and nb_align-1, leading to the function setting nb_des

Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

2024-09-27 Thread Meade, Niall
> From: Ferruh Yigit > Sent: Thursday, September 26, 2024 12:16 AM > To: Meade, Niall ; Thomas Monjalon > ; Andrew Rybchenko ; > Roman Zhukov > Cc: dev@dpdk.org > Subject: Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic > > The resolution involves upcasting nb_desc to a uint

[PATCH 3/7] dts: fix remote session file transfer vars

2024-09-27 Thread Tomáš Ďurovec
The OSSession (and its subclasses) should accept PurePaths for remote paths to translate from OS-unaware (PurePath) to OS-aware (Path) only on the remote side. For local paths, they should accept Paths, as Python is OS-aware locally. Signed-off-by: Tomáš Ďurovec --- .../remote_session/remote_ses

[PATCH 2/7] dts: one dpdk build per test run

2024-09-27 Thread Tomáš Ďurovec
When the DPDK build can be already pre-build, there is not a need for defining multiple build targets. To make it cleaner we decide to use one DPDK build wheater can be pre-build or DTS will build it. Signed-off-by: Tomáš Ďurovec --- dts/conf.yaml | 14 +-- dts/fram

[PATCH v12 4/4] eal: add PMU support to tracing library

2024-09-27 Thread Tomasz Duszynski
In order to profile app one needs to store significant amount of samples somewhere for an analysis later on. Since trace library supports storing data in a CTF format lets take advantage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski --- app/test/test_trace_perf.c

[PATCH v12 3/4] pmu: support reading Intel x86_64 PMU events in runtime

2024-09-27 Thread Tomasz Duszynski
Add support for reading Intel x86_64 PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 2 ++ lib/pmu/meson.build | 1 + lib/pmu/rte_pmu.h| 2 ++ lib/pmu/rte_pmu_pmc_x86_64.h | 24 4 files changed, 29 inserti

[PATCH v12 0/4] add support for self monitoring

2024-09-27 Thread Tomasz Duszynski
This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain advantages when application runs on isolated cores running dedicated tasks. Events can be read directly using rte_pmu_read()

[PATCH] net/nfp: fix duplicate call to rte_free

2024-09-27 Thread Stephen Hemminger
Calling rte_free twice on same object will corrupt the heap. Warning is: In function 'nfp_pre_tun_table_check_del', inlined from 'nfp_flow_destroy' at ../drivers/net/nfp/flower/nfp_flower_flow.c:5143:9: ../drivers/net/nfp/flower/nfp_flower_flow.c:3830:9: error: pointer 'entry' used after 'rte_fre

Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

2024-09-27 Thread Ferruh Yigit
On 9/27/2024 11:46 AM, Meade, Niall wrote: >> On 9/26/2024 3:03 PM, Meade, Niall wrote: From: Ferruh Yigit Sent: Thursday, September 26, 2024 12:16 AM To: Meade, Niall ; Thomas Monjalon ; Andrew Rybchenko ; Roman Zhukov Cc: dev@dpdk.org Subject: Re: [PATCH v1

Re: [PATCH v9 0/8] support dump reigster names and filter

2024-09-27 Thread Ferruh Yigit
On 9/26/2024 1:42 PM, Jie Hai wrote: > The registers can be dumped through the API rte_eth_dev_get_reg_info. > However, only register values are exported, which is inconvenient for > users to interpret. Therefore, an extension of the structure > "rte_dev_reg_info" and a new API rte_eth_dev_get_reg_

[PATCH 09/16] net/e1000: fix use-after-free

2024-09-27 Thread Stephen Hemminger
The driver cleanup code was freeing the filter object then dereferencing it. Bugzilla ID: 1550 Fixes: 6a4d050e2855 ("net/igb: flush all the filter") Cc: wei.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_ethdev.c | 4 ++-- 1 file changed, 2 insert

[PATCH 04/16] dma/ixd: fix incorrect free function in cleanup

2024-09-27 Thread Stephen Hemminger
The data structure is allocated with rte_malloc and incorrectly freed in cleanup logic using free. Bugzilla ID: 1549 Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: kevin.la...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/dma/idxd/idxd_pc

[PATCH 16/16] mempool: annotate mempool create

2024-09-27 Thread Stephen Hemminger
Use rte_alloc_function annotation to catch mismatch errors on memzone handling. Signed-off-by: Stephen Hemminger --- lib/mempool/rte_mempool.h | 41 +-- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte

[PATCH 12/16] raw/ifpga/base: fix use after free

2024-09-27 Thread Stephen Hemminger
The TAILQ_FOREACH() macro would refer to info after it had been freed. Fix by introducing TAILQ_FOREACH_SAFE here. Fixes: 4a19f89104f8 ("raw/ifpga/base: support multiple cards") Cc: tianfei.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/base/opae_inte

[PATCH 15/16] eal: add alloc_function attribute to rte_malloc

2024-09-27 Thread Stephen Hemminger
Use the GCC function attribute to detect cases where memory is allocated with rte_malloc and freed incorrectly with libc version of free (and vice versa). Also will detect some other pointer mismatches. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_malloc.h | 55 +-

[PATCH 13/16] common/qat: fix use after free

2024-09-27 Thread Stephen Hemminger
Checking return value of rte_memzone_free() is pointless and if it failed then it was because the pointer was null. Fixes: 7b1374b1e6e7 ("common/qat: limit configuration to primary process") Cc: arkadiuszx.kusz...@intel.com Signed-off-by: Stephen Hemminger --- drivers/common/qat/qat_device.c |

[PATCH 14/16] drivers/ifpga: fix free function mismatch

2024-09-27 Thread Stephen Hemminger
The raw ifpga driver redefines malloc to be opae_malloc and free to be opae_free; which is a bad idea. This leads to case where interrupt efd array is allocated with calloc() and then passed to rte_free. The workaround is to allocate the array with rte_calloc() instead. Fixes: d61138d4f0e2 ("driv

[PATCH 11/16] net/cpfl: fix free of nonheap object

2024-09-27 Thread Stephen Hemminger
With proper annotation, GCC discovers that this driver is calling rte_free() on an object that was not allocated (it is part of array in another object). In function ‘cpfl_flow_js_mr_layout’, inlined from ‘cpfl_flow_js_mr_action’ at ../drivers/net/cpfl/cpfl_flow_parser.c:848:9, inlined fr

[PATCH 10/16] net/sfc: fix use-after-free warning messages

2024-09-27 Thread Stephen Hemminger
If compiler detection of use-after-free is enabled then this drivers debug messages will cause warnings. Change to move debug message before the object is freed. Bugzilla ID: 1551 Fixes: 55c1238246d5 ("net/sfc: add more debug messages to transfer flows") Cc: ivan.ma...@oktetlabs.ru Signed-off-by:

[PATCH 07/16] net/cnxk: fix use-after-free

2024-09-27 Thread Stephen Hemminger
The driver would refer to the mempool object after it was freed. Bugzilla ID: 1554 Fixes: 7ea187184a51 ("common/cnxk: support 1-N pool-aura per NIX LF") Cc: rbhans...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev_sec.c | 2 +- 1 file changed,

[PATCH 08/16] bpf: fix free mismatch if convert fails

2024-09-27 Thread Stephen Hemminger
If conversion of cBF to eBPF fails then an object allocated with rte_malloc() would be passed to free(). [908/3201] Compiling C object lib/librte_bpf.a.p/bpf_bpf_convert.c.o ../lib/bpf/bpf_convert.c: In function ‘rte_bpf_convert’: ../lib/bpf/bpf_convert.c:559:17: warning: ‘free’ called on pointer

[PATCH 06/16] examples/vhost: fix free function mismatch

2024-09-27 Thread Stephen Hemminger
The pointer bdev is allocated with rte_zmalloc() and then incorrectly freed with free() which will lead pool corruption. Bugzilla ID: 1553 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Cc: jin...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- exa

[PATCH 05/16] event/cnxk: fix pointer mismatch in cleanup

2024-09-27 Thread Stephen Hemminger
The code to cleanup in case of error was passing incorrect value to rte_free. The ports[] entry was allocated with rte_malloc and that should be used instead of the offset in that object. Fixes: 97a05c1fe634 ("event/cnxk: add port config") Cc: sthot...@marvell.com Cc: sta...@dpdk.org Signed-off-b

[PATCH 03/16] cryptodev/bcmfs: fix mis-matched free

2024-09-27 Thread Stephen Hemminger
The device structure is allocated with rte_malloc() and then incorrectly freed with free(). This will lead to corrupt malloc pool. Bugzilla ID: 1552 Fixes: c8e79da7c676 ("crypto/bcmfs: introduce BCMFS driver") Cc: vikas.gu...@broadcom.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger ---

[PATCH 02/16] memzone: fix use after free in tracing

2024-09-27 Thread Stephen Hemminger
Using the freed value for tracing is not a good idea. Although it is harmless for tracing, it will cause analyzers to flag this as unsafe. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_memzone.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/eal/common

[PATCH 01/16] eal: add function attributes for allocation functions

2024-09-27 Thread Stephen Hemminger
The allocation functions take a alignment argument that can be useful to hint the compiler optimizer. This is supported by Gcc and Clang but only useful with Gcc because Clang gives warning if alignment is 0. Recent versions of GCC have a malloc attribute that can be used to find mismatches betwe

[PATCH 00/16] Fix allocation issues and add hardening

2024-09-27 Thread Stephen Hemminger
Recent versions of GCC have some additional function attributes that can help with DPDK performance and stability. The alloc_align attribute can tell the compiler what the alignment of the allocation will be, and the optimizer can use this to produce better code (especially memcpy and structure co

[PATCH v2 42/47] net/bnxt: tf_ulp: TFC support flow scale query for Thor2

2024-09-27 Thread Sriharsha Basavapatna
From: Shuanglin Wang TFC supports the flow scale query feature for OVS application. The resource usage(WC-TCAM) is tracked inside Thor2 firmware. This patch is to query the wc-tcam usage info when adding/ deleting a flow. It is just for debugging purpose and disabled by default. Using the build

[PATCH v2 39/47] net/bnxt: tf_ulp: switch ulp to use rte crc32 hash

2024-09-27 Thread Sriharsha Basavapatna
From: Peter Spreadborough The RTE hash is highly optimized and will use HW acceleration when available. Signed-off-by: Peter Spreadborough Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 4 dr

[PATCH v2 01/47] net/bnxt: tf_core: fix wc tcam multi slice delete issue

2024-09-27 Thread Sriharsha Basavapatna
From: Shahaji Bhosle FW tries to update the HWRM request data in the delete case to update the mode bit and also update invalid profile id. This update only happens when the data is send over DMA. HWRM requests are read only buffers and cannot be updated. So driver now will always send WC tcam se

[PATCH v2 13/47] net/bnxt: tf_ulp: add custom l2 etype tunnel support

2024-09-27 Thread Sriharsha Basavapatna
From: Shahaji Bhosle Add hooks in the hwrm and ulp layer to enable, custom tunnel header support on wh+ generic app(ovs). Signed-off-by: Shahaji Bhosle Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 4

[PATCH v2 14/47] net/bnxt: tf_ulp: add support for vf to vf flow offload

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added support for the vf to vf flow offload for the whitney platform. It includes the change of the pipeline from using vlan tags to using custom L2 encap and decap of the packets. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shah

[PATCH v2 21/47] net/bnxt: tf_ulp: add action read and clear support

2024-09-27 Thread Sriharsha Basavapatna
From: Jay Ding Implement action read and clear support. Change flow query count to reset the count after read in ULP. Update cli cmds accordingly. Fixed bnxt_mpc_xmit() to pad the mpc message to be multiple of 16 bytes. Signed-off-by: Jay Ding Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v2 03/47] net/bnxt: tf_core: External EM support cleanup

2024-09-27 Thread Sriharsha Basavapatna
From: Shuanglin Wang Isolate external EM support as it is now defunct on Wh+. Signed-off-by: Shuanglin Wang Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shahaji Bhosle Reviewed-by: Farah Smith Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/meson.build |2 - drivers/ne

[PATCH v2 07/47] net/bnxt: tf_core: fix slice count in case of HA entry move

2024-09-27 Thread Sriharsha Basavapatna
From: Sangtani Parag Satishbhai When entries are moved during HA, a shared move function transfers TCAM entries by using get/set message APIs, and the slice number of the entry is required to accomplish the movement. The slice number is calculated as the product of row_slice and entry size. Befor

[DPDK/ethdev Bug 1554] Use after free in cnxk_ethdev

2024-09-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1554 Bug ID: 1554 Summary: Use after free in cnxk_ethdev Product: DPDK Version: 24.11 Hardware: All OS: All Status: UNCONFIRMED Severity: major Priority: Nor

[PATCH v2 30/47] net/bnxt: tf_ulp: add mask defaults when mask is not specified

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha If application does not specify mask in a field description then use the default mask values from dpdk header files. This patch also includes the following related changes. fix stats collection for shared session The stats accumulation was being performed on def

[PATCH v2 41/47] net/bnxt: tf_ulp: support a few generic template items

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch provides the following changes. support generic template items Add support for jump action, dynamic tunnels and flow priority to thor2 platform. fix generic application template The queue action is enabled for Thor2 platform. E

[PATCH v2 04/47] net/bnxt: tf_core: Thor TF EM key size check

2024-09-27 Thread Sriharsha Basavapatna
From: Farah Smith The maximum EM key size is 640 bits for Thor. But the lookup record + the key size is 679 bits. This value must be rounded up to a 128 bit aligned number. So the size check should be 96 bytes rather than 80. This fix allows keys > 601 bits to be successfully inserted. Fixes:

[PATCH v2 05/47] net/bnxt: tf_core: flow scale improvement

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added logic to add flows to wildcard tcam if flows fail to be added to exact match table. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde Reviewed-by: Shahaji Bhosle Signed-off-by: Sriharsha Basavapatna --- drivers/net/bnxt/

[PATCH v2 27/47] net/bnxt: tf_ulp: fixed parent child db counters

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha The locking for the parent child counters need to be done till the stats are retrieved. Also the OVS is creating multiple F1 flows for same tunnel hence reference count needs to be maintined for the F1 flows. Fix name conflicts for class and action tables. Matcher alloca

[PATCH v2 47/47] net/bnxt: tf_ulp: add stats cache for thor2

2024-09-27 Thread Sriharsha Basavapatna
From: Peter Spreadborough This change adds a stats cache for Thor2 flows using counters. Flow stats will be harvested periodically in the background and stats reads by the application will be returned stats from the cache and not by initiating a read from HW. This change also adds read-clear fun

[PATCH v2 45/47] net/bnxt: tf_ulp: support a few feature extensions

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch supports the following features. add support for port table write operation Added support for port table write operation from the template so that template can write mirror id details into the port database. support generic template fo

[PATCH v2 44/47] net/bnxt: tf_ulp: enable support for truflow feature configuration

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added truflow feature bit meson configuration parameter to enable optional capability features of the appplication. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_

[PATCH v2 36/47] net/bnxt: tf_ulp: add support for rss flow query to ULP

2024-09-27 Thread Sriharsha Basavapatna
From: Randy Schacher Support flow query rss command for truflow in ULP layer. Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c| 39 +- drivers/net/bnxt/bnxt_

[PATCH v2 35/47] net/bnxt: tf_ulp: TF support flow scale query

2024-09-27 Thread Sriharsha Basavapatna
From: Shuanglin Wang TF supports the flow scale query feature for OVS application. The resource usage is tracked when opening a TF session or adding/deleting a flow. The resources includes WC TCAM, EM, Action, Counter, Meter, ACT_ENCAP, ACT_ENCAP, and SP_SMAC. User can query the resource usage us

[PATCH v2 34/47] net/bnxt: tf_ulp: add rte_mtr support for Thor2

2024-09-27 Thread Sriharsha Basavapatna
From: Jay Ding 1. Implement Thor2 meter template tables 2. Add Thor2 meter support in ULP 3. Make rte_mtr API implementation device independent to adapt Thor2 meter hw change 4. Fix the round issue in xir calculation Signed-off-by: Jay Ding Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v2 29/47] net/bnxt: tf_ulp: update template files

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch updates template files for the following list of changes, that are being added in the next patch. dynamic support for VF representor mode (template files only) The configurable VF representor mode is removed and it is dynamic. The action record

[PATCH v2 28/47] net/bnxt: tf_ulp: modify return values to adhere to C coding standard

2024-09-27 Thread Sriharsha Basavapatna
From: Shuanglin Wang Modified return values of the several ULP utilities to comply C coding standard. Like using macros EXIT_SUCCESS(0) and EXIT_FAILURE(1) for the conventional status value for success and failure, respectively. They are declared in the file stdlib.h. Signed-off-by: Shuanglin W

[PATCH v2 26/47] net/bnxt: tf_ulp: enable recipe id generation

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added support to generate recipe id generation. This patch includes a few related changes: fix segfault in the wildcard recipe process The recipe id is being passed as 8 bit instead of 64bit causing the crash. Ported code using default_non_ha resource

[PATCH v2 25/47] net/bnxt: tf_ulp: update template files

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch updates template files for the following list of changes, that are being added in the next patch. - enable recipe id generation - fix segfault in the wildcard recipe process Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v2 23/47] net/bnxt: tf_ulp: VFR updates for Thor 2

2024-09-27 Thread Sriharsha Basavapatna
From: Mike Baucom Update to VFR code to: - add the endpoint (efid) to the session - modify the generic tables to write the l2 context id - tfc session code changes to allow the efid to be added to the sid - release both rfid and efid from afm This patch includes a few related changes: Thor2 cha

[PATCH v2 19/47] net/bnxt: tf_ulp: convert recipe table to dynamic memory

2024-09-27 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Converted the recipe table allocation from static model to dynamic memory allocation model. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 175 +

[PATCH v2 16/47] net/bnxt: tf_ulp: miscellaneous fixes

2024-09-27 Thread Sriharsha Basavapatna
From: Mike Baucom Template compiler modifications for v3 api: Compile named/unnamed shared app resources for the applications that are capable. Change app id signature with base zero offset: The app id is used in the calculation of the matching signatures and as app id value incr

[PATCH v2 15/47] net/bnxt: tf_ulp: Wh+ mirroring support

2024-09-27 Thread Sriharsha Basavapatna
From: Manish Kurup 1. ULP fixes to enable primitives to support mirroring 2. RTE parser changes to support and use multiple ports in RTE input msgs 3. Template changes required to support ingress mirroring 4. Template changes required to support egress mirroring (using VFR pipeline) Signed

[PATCH v2 10/47] net/bnxt: tf_core: remove dead code from session-based priority TCAM mgr

2024-09-27 Thread Sriharsha Basavapatna
From: Randy Schacher Remove references to tx_tcam_supported and rx_tcam_supported logic which chooses between FW-based tcam resource allocation and driver-based tcam manager. Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Peter Spreadborough Reviewed-by: Manis

[PATCH v2 09/47] net/bnxt: tf_core: remove dead AFM code from session-based priority TCAM mgr

2024-09-27 Thread Sriharsha Basavapatna
From: Randy Schacher Remove references to AFM allocated memory which is no longer supported with TCAM mgr and truflow Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Farah Smith Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[PATCH v2 06/47] net/bnxt: tf_core: TF support flow scale query

2024-09-27 Thread Sriharsha Basavapatna
From: Shuanglin Wang TF supports the flow scale query feature for OVS application. The resource usage is tracked when opening a TF session or adding/deleting a flow. The resources includes WC TCAM, EM, Action, Counter, Meter, ACT_ENCAP, ACT_ENCAP, and SP_SMAC. User can query the resource usage us

[PATCH v2 02/47] net/bnxt: tf_core: tcam manager data corruption

2024-09-27 Thread Sriharsha Basavapatna
From: Shahaji Bhosle Max entries per session were not getting initialized to 0, when the sessions were closed. Reset max entries counter session when the session is initialized Fixes: 97435d7906d7 ("net/bnxt: update Truflow core") Signed-off-by: Shahaji Bhosle Signed-off-by: Sriharsha Basavapat

[PATCH v2 00/47] TruFlow update for Thor2

2024-09-27 Thread Sriharsha Basavapatna
This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. TruFlow(TF) is the software library that exposes CFA HW resources to upper layer protocols or applications. This patch series implements the tfc (tf_core) and the tf_ulp libraries as a part of the bnxt PMD, so that upper la

Re: [PATCH] dts: add per-test-suite configuration

2024-09-27 Thread Jeremy Spewock
Hi Luca, I apologize for not giving this patch more time/attention. I think this patch is worth having a more in-depth discussion about since it does add quite a bit more complexity, but the benefit of that is some valuable simplicity. I know we discussed in the recent team meeting about whether o

Re: [PATCH v6 2/2] net/bnxt: code refactor for supporting speed lanes

2024-09-27 Thread Ajit Khaparde
On Thu, Sep 26, 2024 at 2:56 PM Damodharam Ammepalli wrote: > > Broadcom Thor2 NICs support link mode settings where user > can configure fixed speed and associated supported number of > lanes. This patch does code-refactoring to address proposed > poll mode library design updates. > > Signed-off-

Re: [PATCH v6 1/2] ethdev: Add link_speed lanes support

2024-09-27 Thread Ajit Khaparde
On Thu, Sep 26, 2024 at 5:39 PM Ferruh Yigit wrote: > > On 9/26/2024 10:43 PM, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get, get capabilities and set ethernet link speed lanes. > > Update the testpmd to provide required config and informatio

Re: [PATCH v1 3/3] dts: rework test suite and dts runner to include test_run configs

2024-09-27 Thread Jeremy Spewock
On Tue, Sep 10, 2024 at 7:05 AM Juraj Linkeš wrote: > > >> -tg_port.peer, > >> -tg_port.identifier, > >> -): > >> -self._port_links.append(PortLink(sut_port=sut_port, > >> tg_port=tg_port)) > >> +sut_ports = [] >

Re: [PATCH v4] doc: add new driver guidelines

2024-09-27 Thread Thomas Monjalon
27/09/2024 02:19, Ferruh Yigit: > On 9/16/2024 5:28 PM, Stephen Hemminger wrote: > > From: Nandini Persad > > +Avoid doing the following: > > + > > +* Using PMD specific macros when DPDK macros exist > > +* Including unused headers (process-iwyu.py) > > +* Disabling compiler warnings for driver >

[PATCH v7 6/8] lib/cryptodev: add sm4 xts for crypto

2024-09-27 Thread Hanxiao Li
add support of sm4 xts . Signed-off-by: Hanxiao Li --- lib/cryptodev/rte_crypto_sym.h | 4 +++- lib/cryptodev/rte_cryptodev.c | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sym.h index 53b18b9412..b34d041fe0 1006

[PATCH v7 4/8] compress/zsda: configure drivers of compressdev

2024-09-27 Thread Hanxiao Li
Add drivers and some interfaces of zsda compressdev. Signed-off-by: Hanxiao Li --- MAINTAINERS | 4 + drivers/common/zsda/meson.build | 12 +- drivers/compress/zsda/zsda_comp.c | 392 ++ drivers/compress/zsda/zsda_comp.h | 52 +++ d

Re: [PATCH v4 06/11] dts: add NIC capability support

2024-09-27 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

[PATCH v7 7/8] app/test: add sm4-xts test.

2024-09-27 Thread Hanxiao Li
add support of sm4 xts test. Signed-off-by: Hanxiao Li --- app/test/test_cryptodev_blockcipher.c | 3 +- app/test/test_cryptodev_sm4_test_vectors.h | 58 ++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/

[PATCH v7 0/8] drivers/zsda: introduce zsda drivers

2024-09-27 Thread Hanxiao Li
v7: - add release notes and some documentations. - add MAINTAINERS context in the patch where the file/folder is added. - add files in meason.build which are included in the patch only. - add a check for unsupported on Windows - notice the implicit cast in C. - add cover letter. - compile each of

[PATCH v7 8/8] doc/guides: add documents and release notes for two drivers

2024-09-27 Thread Hanxiao Li
This patch adds documents and release notes about compressdev and cryptodev. Signed-off-by: Hanxiao Li --- doc/guides/compressdevs/features/zsda.ini | 15 ++ doc/guides/compressdevs/index.rst | 1 + doc/guides/compressdevs/zsda.rst | 45 doc/guides/cryptodevs/features/z

Re: [PATCH v4 07/11] dts: add NIC capabilities from show rxq info

2024-09-27 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v4 11/11] dts: add NIC capabilities from show port info

2024-09-27 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

  1   2   >