27/09/2024 02:19, Ferruh Yigit: > On 9/16/2024 5:28 PM, Stephen Hemminger wrote: > > From: Nandini Persad <nandinipersad...@gmail.com> > > +Avoid doing the following: > > + > > +* Using PMD specific macros when DPDK macros exist > > +* Including unused headers (process-iwyu.py) > > +* Disabling compiler warnings for driver > > +* #ifdef with driver-defined macros > > +* DPDK version checks (via RTE_VERSION_NUM) in the upstream code > > +* Introducing Public APIs directly from the driver > > +* Adding driver private APIs. If a new feature is needed, it is > > + better to extend the corresponding framework API > > + > > > > Last two items are for the same issue, we sometime call public APIs from > drivers as "driver private APIs". > First one looks simpler, perhaps we can keep that one, but I don't have > strong opinion, as long as we remove the duplication.
I prefer talking about public API from the driver, it's clear. Note that an API is for the Application, so it's always public :) but better to make it explicit.
