Re: [PATCH v3 0/2] bbdev: dump debug information

2024-09-19 Thread Hemant Agrawal
Hi Nicolas,     I have ack your patches.  One suggestion, if you can use "--in-reply-to=" in you patch series, it will be helpful. This will link your new series with old series. Regards Hemant On 14-09-2024 04:48, Nicolas Chautru wrote: v3: updated based on Maxime comments related to p

RE: [PATCH] net/af_packet: add timestamp offloading support

2024-09-19 Thread Stefan Lässer
> > +uint64_t af_packet_timestamp_dynflag; int > > +af_packet_timestamp_dynfield_offset = -1; > > No need to expose these publicly, they should be static. > This also means that you can remove the af_packet_ prefix. > > eth_dev_start(struct rte_eth_dev *dev) { > > struct pmd_internals *inter

Re: [PATCH v3 2/2] baseband/acc: improvement to logging mechanism

2024-09-19 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [PATCH v3 1/2] bbdev: add new function to dump debug information

2024-09-19 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[PATCH v2] net/af_packet: add timestamp offloading support

2024-09-19 Thread Stefan Laesser
Add the packet timestamp from TPACKET_V2 to the mbuf dynamic rx timestamp register if offload RTE_ETH_RX_OFFLOAD_TIMESTAMP is enabled. TPACKET_V2 provides the timestamp with nanosecond resolution and UNIX origo, i.e. time since 1-JAN-1970 UTC. Signed-off-by: Stefan Laesser Acked-by: Morten Brøru

[PATCH v11 6/7] eal: add unit tests for atomic bit access functions

2024-09-19 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --

[PATCH v11 5/7] eal: add atomic bit operations

2024-09-19 Thread Mattias Rönnblom
Add atomic bit test/set/clear/assign/flip and test-and-set/clear/assign/flip functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston --

[PATCH v11 0/7] Improve EAL bit operations API

2024-09-19 Thread Mattias Rönnblom
This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

[PATCH v11 4/7] eal: add unit tests for bit operations

2024-09-19 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_[test|set|clear|assign|flip]() functions. The tests are converted to use the test suite runner framework. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v6: * Test rte_bit_*test()

[PATCH v11 7/7] eal: extend bitops to handle volatile pointers

2024-09-19 Thread Mattias Rönnblom
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston -- PATCH v3: * Updated to reflect removed 'fun' parameter in __RTE_GEN_BIT_*() (Jack Bond-Preston). PATC

[PATCH v11 1/7] buildtools/chkincs: relax C linkage requirement

2024-09-19 Thread Mattias Rönnblom
Relax chkincs requirement of all DPDK header files having to contain 'extern "C"'. Instructing a C++ toolchain to use C linkage is only necessarily if the header file declares symbols (i.e., functions or global variables). With this change, chkincs tries to find if any functions or references to

[PATCH v11 3/7] eal: extend bit manipulation functionality

2024-09-19 Thread Mattias Rönnblom
Add functionality to test and modify the value of individual bits in 32-bit or 64-bit words. These functions have no implications on memory ordering, atomicity and does not use volatile and thus does not prevent any compiler optimizations. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup

RE: [PATCH v2] ipsec: allow stateless IPsec processing

2024-09-19 Thread Aakash Sasidharan
> > > Introduce stateless packet preparation API for IPsec processing. The > > > new API would allow preparation of IPsec packets without altering > > > the internal state of an IPsec session. > > > > > > For outbound IPsec processing, the change enables user to provide > > > sequence number to be

[PATCH v2 1/1] net/octeon_ep: add device removal event callback

2024-09-19 Thread Vamsi Krishna
From: Vamsi Attunuru Adds an event callback to catch any device removal event occurred during driver probe. This callback helps in terminating the execution if there is any device removal event during the driver probe. Also moved global register configuration into dev_configure() routine and als

Re: [PATCH 5/5] common/cnxk: enable PF VF mbox

2024-09-19 Thread Jerin Jacob
On Mon, Sep 2, 2024 at 12:08 PM Harman Kalra wrote: > > * Setting up the mailbox communication between PF and VF for cn20k > * Update PFVF mbox CSRs offset change introduced in cn20k > * Memory to be allocated by PF driver for PF VF mbox should be > aligned to next power of 2. > > Signed-off-by: H

RE: [EXTERNAL] Re: [PATCH] net/octeon_ep: add device removal event callback

2024-09-19 Thread Vamsi Krishna Attunuru
>-Original Message- >From: Jerin Jacob >Sent: Thursday, September 19, 2024 11:49 PM >To: Vamsi Krishna Attunuru >Cc: dev@dpdk.org; Jerin Jacob >Subject: [EXTERNAL] Re: [PATCH] net/octeon_ep: add device removal event >callback > >On Tue, Aug 27, 2024 at 11: 03 AM Vamsi Krishna >wrote:

RE: [PATCH v2] ipsec: allow stateless IPsec processing

2024-09-19 Thread Aakash Sasidharan
> > Introduce stateless packet preparation API for IPsec processing. The > > new API would allow preparation of IPsec packets without altering the > > internal state of an IPsec session. > > > > For outbound IPsec processing, the change enables user to provide > > sequence number to be used for the

Re:[PATCH] raw/zxdh: introduce zxdh raw device driver

2024-09-19 Thread Yong Zhang
Hi thomas, Could you please provide feedback on the patch I submitted on August 12? Any suggestions for improvement would be appreciated. Thanks

Re: [PATCH 1/5] dts: add TestSuiteSpec class and discovery

2024-09-19 Thread Nicholas Pratte
I think Juraj's comments here make sense, it probably would make sense to separate this in-conjunction with Juraj's decorator patch and use it as a dependency. From what I can understand, the changes offered here make sense to me. Reviewed-by: Nicholas Pratte -- *Let's Connect!* ...  *Octob

Re: [PATCH 2/5] dts: add Pydantic and remove Warlock

2024-09-19 Thread Nicholas Pratte
I understand Juraj's concern about the dependencies assuming this change was to stay in its own isolated patch in the log. That aside, this is pretty straightforward, and I have confidence in the judgement of whatever decision is made between the two of you. Reviewed-by: Nicholas Pratte On Thu,

Re: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits

2024-09-19 Thread Igor Gutorov
Hi, On Wed, Aug 7, 2024 at 11:58 PM Igor Gutorov wrote: > > Hi, > > Sorry, I used the wrong --to and --cc switches. > Adding Slava just in case. > > Sincerely, > Igor. > > On Wed, Aug 7, 2024 at 11:44 PM Igor Gutorov wrote: > > > > Hi, Slava > > > > > > Is an `int` appropriate for `log_max_wq_sz

[PATCH v10 7/7] eal: extend bitops to handle volatile pointers

2024-09-19 Thread Mattias Rönnblom
Have rte_bit_[test|set|clear|assign|flip]() and rte_bit_atomic_*() handle volatile-marked pointers. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Jack Bond-Preston -- PATCH v3: * Updated to reflect removed 'fun' parameter in __RTE_GEN_BIT_*() (Jack Bond-Preston). PATC

[PATCH v10 0/7] Improve EAL bit operations API

2024-09-19 Thread Mattias Rönnblom
This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

[PATCH v10 1/7] buildtools/chkincs: relax C linkage requirement

2024-09-19 Thread Mattias Rönnblom
Relax chkincs requirement of all DPDK header files having to contain 'extern "C"'. Instructing a C++ toolchain to use C linkage is only necessarily if the header file declares symbols (i.e., functions or global variables). With this change, chkincs tries to find if any functions or references to

[PATCH v10 6/7] eal: add unit tests for atomic bit access functions

2024-09-19 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_atomic_*() family of functions. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. --

[PATCH v10 3/7] eal: extend bit manipulation functionality

2024-09-19 Thread Mattias Rönnblom
Add functionality to test and modify the value of individual bits in 32-bit or 64-bit words. These functions have no implications on memory ordering, atomicity and does not use volatile and thus does not prevent any compiler optimizations. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup

[PATCH v10 5/7] eal: add atomic bit operations

2024-09-19 Thread Mattias Rönnblom
Add atomic bit test/set/clear/assign/flip and test-and-set/clear/assign/flip functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston --

[PATCH v10 4/7] eal: add unit tests for bit operations

2024-09-19 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_[test|set|clear|assign|flip]() functions. The tests are converted to use the test suite runner framework. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff Acked-by: Jack Bond-Preston -- RFC v6: * Test rte_bit_*test()

Re: [PATCH v2 1/6] eal: add static per-lcore memory allocation facility

2024-09-19 Thread Mattias Rönnblom
On 2024-09-18 12:11, Jerin Jacob wrote: On Thu, Sep 12, 2024 at 8:52 PM Jerin Jacob wrote: On Thu, Sep 12, 2024 at 7:11 PM Morten Brørup wrote: From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sent: Thursday, 12 September 2024 15.17 On Thu, Sep 12, 2024 at 2:40 PM Morten Brørup wrote:

Re: [PATCH v3 19/19] net/xsc: add dev basic stats ops

2024-09-19 Thread Stephen Hemminger
On Wed, 18 Sep 2024 14:09:36 +0800 "WanRenyong" wrote: > @@ -166,6 +169,7 @@ xsc_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, > uint16_t pkts_n) > /* Fill wqe */ > wqe->va = rte_cpu_to_le_64(rte_pktmbuf_iova(rep)); > rte_pktmbuf_data_len(seg) = len;

Re: [PATCH v3 19/19] net/xsc: add dev basic stats ops

2024-09-19 Thread Stephen Hemminger
On Wed, 18 Sep 2024 14:09:36 +0800 "WanRenyong" wrote: > > +static int > +xsc_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +{ > + struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev); > + uint32_t rxqs_n = priv->num_rq; > + uint32_t txqs_n = priv->num_s

[PATCH v3 0/1] dts: replace XML-RPC server

2024-09-19 Thread jspewock
From: Jeremy Spewock v3: * rebase on next-dts branch Jeremy Spewock (1): dts: Remove XML-RPC server for Scapy TG and instead use PythonShell .../single_active_interactive_shell.py| 7 +- .../traffic_generator/__init__.py | 2 +- .../testbed_model/traffic_generator/s

[PATCH v3 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-09-19 Thread jspewock
From: Jeremy Spewock Previously all scapy commands were handled using an XML-RPC server that ran on the TGNode. This unnecessarily enforces a minimum Python version of 3.10 on the server that is being used as a traffic generator and complicates the implementation of scapy methods. This patch remo

Re: [PATCH] net/octeon_ep: add device removal event callback

2024-09-19 Thread Jerin Jacob
On Tue, Aug 27, 2024 at 11:03 AM Vamsi Krishna wrote: > > From: Vamsi Attunuru > > Patch adds an event callback to catch any device removal Please remove patch. > event occurred during driver probe. This callback helps > in terminating the execution if there is any device removal > event durin

[PATCH v2 1/1] dts: add binding to different drivers to TG node

2024-09-19 Thread jspewock
From: Jeremy Spewock The DTS framework in its current state supports binding ports to different drivers on the SUT node but not the TG node. The TG node already has the information that it needs about the different drivers that it has available in the configuration file, but it did not previously

[PATCH v2 0/1] dts: add driver binding on TG

2024-09-19 Thread jspewock
From: Jeremy Spewock v2: * only copy the devbind script onto the TG node rather than the entire DPDK directory Jeremy Spewock (1): dts: add binding to different drivers to TG node dts/framework/runner.py | 2 + dts/framework/testbed_model/node.py | 49 +

Re: [PATCH] common/cnxk: use atomic load acquire in batch ops

2024-09-19 Thread Jerin Jacob
On Fri, Aug 23, 2024 at 12:21 PM Nawal Kishor wrote: > > In roc batch alloc wait code, __ATOMIC_RELAXED is changed to > __ATOMIC_ACQUIRE in order to avoid potential out of order loads. > > Signed-off-by: Nawal Kishor Could you add Fixes: And change subject to common/cnxk: fix ...

Re: [PATCH 1/1] common/cnxk: updated loglevel from NOTICE to INFO

2024-09-19 Thread Jerin Jacob
On Thu, Aug 22, 2024 at 12:03 PM Rakesh Kudurumalla wrote: > > In latest dpdk PMD log type is removed and driver > specific log type is added for CNXK. This patch > changes loglevel of CNXK from NOTICE to INFO > to display logs while running applications Could you add Fixes: And change subject t

RE: [PATCH] netvsc: optimize stats counters performance

2024-09-19 Thread Long Li
> Subject: RE: [PATCH] netvsc: optimize stats counters performance > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, 2 August 2024 19.33 > > > > On Fri, 2 Aug 2024 19:28:26 +0200 > > Morten Brørup wrote: > > > > > > > ea = rte_pktmbuf_mtod(m, const struct r

[PATCH v2] common/cnxk: unregister IRQ before reconfigure

2024-09-19 Thread pbhagavatula
From: Pavan Nikhilesh Unregister SSO device and NPA IRQs before resizing them. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Reorder npa interrupt un-registration. drivers/common/cnxk/roc_dev.c | 16 +++- drivers/common/cnxk/roc_dev_priv.h | 2 ++ drivers/common/cnxk/roc_

Re: [PATCH] net/octeon_ep: extend mailbox functionality

2024-09-19 Thread Jerin Jacob
On Tue, Aug 6, 2024 at 8:20 PM Vamsi Attunuru wrote: > > Patch extends mbox functionality to handle pf to vf mbox > messages and also updates current mbox version to V3. > > As part of PF FLR notify event, event handler invokes > device removal event callback to tear down the driver. > > Signed-of

Re: [PATCH v1 1/1] ml/cnxk: updates to cn10k error handling

2024-09-19 Thread Jerin Jacob
On Wed, Jul 31, 2024 at 12:33 PM Srikanth Yalavarthi wrote: > > Renamed cnxk error codes as cn10k error codes. Added > support for model specific op_error_get routines. > > Signed-off-by: Srikanth Yalavarthi Applied to dpdk-next-net-mrvl/for-main. Thanks

Re: [PATCH 1/1] ml/cnxk: enable data caching for all MRVL layers

2024-09-19 Thread Jerin Jacob
On Wed, Jul 31, 2024 at 12:08 PM Srikanth Yalavarthi wrote: > > From: Anup Prabhu > > Enabled data caching for all MRVL layers in TVM models Add why? If it is Fix, please add Fixes: tag Also, MRVL can be removed > > Signed-off-by: Anup Prabhu > --- > drivers/ml/cnxk/cn10k_ml_ops.c | 9 ++---

Re: [PATCH v1 1/1] ml/cnxk: fix incorrect handling of TVM model I/O

2024-09-19 Thread Jerin Jacob
On Wed, Jul 31, 2024 at 11:43 AM Srikanth Yalavarthi wrote: > > Fixed incorrect handling of TVM models with single MRVL > layer. Set the I/O layout to packed and fixed calculation > of quantized and dequantized data buffer addresses. > > Fixes: 5cea2c67edfc ("ml/cnxk: update internal TVM model inf

Re: [PATCH v4 4/5] ring/soring: introduce Staged Ordered Ring

2024-09-19 Thread Jerin Jacob
On Tue, Sep 17, 2024 at 5:49 PM Konstantin Ananyev wrote: > > From: Konstantin Ananyev > > Staged-Ordered-Ring (SORING) provides a SW abstraction for 'ordered' queues > with multiple processing 'stages'. > It is based on conventional DPDK rte_ring, re-uses many of its concepts, > and even substan

Re: [PATCH v3] ethdev: optimize the activation of fast-path tracepoints

2024-09-19 Thread Jerin Jacob
On Thu, Sep 19, 2024 at 12:16 AM Adel Belkhiri wrote: > > From: Adel Belkhiri > > Split the tracepoints rte_ethdev_trace_rx_burst and > rte_eth_trace_call_rx_callbacks into two separate ones > for empty and non-empty calls to avoid saturating > quickly the trace buffer. > > Signed-off-by: Adel Be

Re: [PATCH v2] eal: add build-time option to omit trace

2024-09-19 Thread Jerin Jacob
On Thu, Sep 19, 2024 at 9:38 PM Morten Brørup wrote: > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Thursday, 19 September 2024 17.49 > > > > On Thu, Sep 19, 2024 at 9:05 PM Morten Brørup > > wrote: > > > > > > > Could you share data with a real-world application of the elf siz

RE: [PATCH v2] eal: add build-time option to omit trace

2024-09-19 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Thursday, 19 September 2024 17.49 > > On Thu, Sep 19, 2024 at 9:05 PM Morten Brørup > wrote: > > > > > Could you share data with a real-world application of the elf size? > > > 1)Without any change > > > > Size of the statically linked ex

Re: [PATCH v2] examples/eventdev: fix segment fault with generic pipeline

2024-09-19 Thread Jerin Jacob
On Wed, Sep 18, 2024 at 12:10 PM Chengwen Feng wrote: > > There was a segmentation fault when executing eventdev_pipeline with > command [1] with ConnectX-5 NIC card: > > 0x0079208c in rte_eth_tx_buffer (tx_pkt=0x16f8ed300, buffer=0x100, >queue_id=11, port_id=0) at >

Re: [RFC PATCH v3 0/2] Initial Implementation For Jumbo Frames

2024-09-19 Thread Alex Chapman
Hey Nick, After going through this test suite (jumbo frames) and mtu update, it seems as though mtu update contains all of the test cases of jumbo frames and more. To reduce the amount of maintenance and code duplication, it would make sense to remove this test suite and supercede it with mt

Re: [PATCH v2] eal: add build-time option to omit trace

2024-09-19 Thread Jerin Jacob
On Thu, Sep 19, 2024 at 9:05 PM Morten Brørup wrote: > > > Could you share data with a real-world application of the elf size? > > 1)Without any change > > Size of the statically linked executable on the target file system: > 3,800,528 byte > > > 2)Only disabling via __rte_trace_point_emit_header

RE: [PATCH v2] eal: add build-time option to omit trace

2024-09-19 Thread Morten Brørup
> Could you share data with a real-world application of the elf size? > 1)Without any change Size of the statically linked executable on the target file system: 3,800,528 byte > 2)Only disabling via __rte_trace_point_emit_header_generic() .. aka below > patch. 3,572,032 byte > 3)Full disable.

[PATCH v25 01/15] maintainers: add for log library

2024-09-19 Thread Stephen Hemminger
"You touch it you own it" Add myself as maintainer for log library. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINE

[PATCH v25 09/15] log: drop syslog support, and make code common

2024-09-19 Thread Stephen Hemminger
This patch makes the log setup code common across all platforms. Drops syslog support for now, will come back in later patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- app/test/test_eal_flags.c | 11 ++- lib/eal/common/eal_common_option

[PATCH v25 02/15] windows: make getopt functions have const properties

2024-09-19 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

Re: [PATCH v3 00/26] add meson config options for queues per port

2024-09-19 Thread Bruce Richardson
On Thu, Sep 19, 2024 at 04:14:28PM +0200, David Marchand wrote: > On Wed, Aug 14, 2024 at 12:50 PM Bruce Richardson > wrote: > > > > There are a number of issues with the current RTE_MAX_QUEUES_PER_PORT > > setting in DPDK that are addressed by this patchset: > > > > * The name does not make it cl

[PATCH v25 15/15] doc: add release note about log library

2024-09-19 Thread Stephen Hemminger
Significant enough to add some documentation. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- doc/guides/rel_notes/release_24_11.rst | 27 ++ 1 file changed, 27 insertions(+) diff --git a/doc/guides/rel_n

[PATCH v25 05/15] eal: do not duplicate rte_init_alert() messages

2024-09-19 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/

[PATCH v25 14/15] log: colorize log output

2024-09-19 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Ack

[PATCH v25 07/15] log: move handling of syslog facility out of eal

2024-09-19 Thread Stephen Hemminger
The syslog facility property is better handled in lib/log rather than in eal. This also allows for changes to what syslog flag means in later steps. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_option

[PATCH v25 12/15] log: add optional support of syslog

2024-09-19 Thread Stephen Hemminger
Log to syslog only if option is specified. And if syslog is used then normally only log to syslog, don't duplicate output. Also enables syslog support on FreeBSD. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- app/test/test_eal_

[PATCH v25 13/15] log: add support for systemd journal

2024-09-19 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v25 08/15] eal: initialize log before everything else

2024-09-19 Thread Stephen Hemminger
In order for all log messages (including CPU mismatch) to come out through the logging library, it must be initialized as early in rte_eal_init() as possible on all platforms. Where it was done before was likely historical based on the support of non-OS isolated CPU's which required a shared memor

[PATCH v25 11/15] log: add timestamp option

2024-09-19 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v25 10/15] log: add hook for printing log messages

2024-09-19 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/log/log.c | 6 +- lib/log/log_private.h | 9 + 2 f

[PATCH v25 00/15] Logging enhancements for 24.11

2024-09-19 Thread Stephen Hemminger
mprovements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of s

[PATCH v25 06/15] eal: change rte_exit() output to match rte_log()

2024-09-19 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v25 03/15] windows: add os shim for localtime_r

2024-09-19 Thread Stephen Hemminger
Windows does not have localtime_r but it does have a similar function that can be used instead. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/windows/include/rte_os_shim.h | 10 ++ 1 fi

[PATCH v25 04/15] eal: make eal_log_level_parse common

2024-09-19 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eal/common/eal_common_options.c | 40 +++ lib/eal/common/eal_options.h

Re: [PATCH v3] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
On 19. 9. 2024 16:24, jspew...@iol.unh.edu wrote: From: Jeremy Spewock Currently the runner target in the Dockerfile attempts to run the `poetry install` command when building the image, but this fails due to poetry not being found in the container. Poetry is installed in a previous step wit

Re: [PATCH v3] dts: fix runner target in the Dockerfile

2024-09-19 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

[PATCH v3] dts: fix runner target in the Dockerfile

2024-09-19 Thread jspewock
From: Jeremy Spewock Currently the runner target in the Dockerfile attempts to run the `poetry install` command when building the image, but this fails due to poetry not being found in the container. Poetry is installed in a previous step with pipx, but doing so adds the binary to use poetry to ~

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Jeremy Spewock
On Thu, Sep 19, 2024 at 3:09 AM Juraj Linkeš wrote: > > > > On 18. 9. 2024 16:16, Jeremy Spewock wrote: > > On Wed, Sep 18, 2024 at 3:57 AM Juraj Linkeš > > wrote: > >> > >> > >>> diff --git a/dts/Dockerfile b/dts/Dockerfile > >> > >>> @@ -24,9 +27,12 @@ FROM base AS runner > >> > >>> +# Adds ~/

Re: [PATCH v3 00/26] add meson config options for queues per port

2024-09-19 Thread David Marchand
On Wed, Aug 14, 2024 at 12:50 PM Bruce Richardson wrote: > > There are a number of issues with the current RTE_MAX_QUEUES_PER_PORT > setting in DPDK that are addressed by this patchset: > > * The name does not make it clear that this is intended as an > ethdev-only setting > * A number of other

Re: [PATCH v2] eal: add build-time option to omit trace

2024-09-19 Thread Jerin Jacob
On Thu, Sep 19, 2024 at 6:45 PM Morten Brørup wrote: > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Thursday, 19 September 2024 10.52 > > > > On Thu, Sep 19, 2024 at 1:37 PM Morten Brørup > > wrote: > > > > > > Some applications want to omit the trace feature. > > > Either to r

RE: [PATCH] netvsc: optimize stats counters performance

2024-09-19 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 2 August 2024 19.33 > > On Fri, 2 Aug 2024 19:28:26 +0200 > Morten Brørup wrote: > > > > > ea = rte_pktmbuf_mtod(m, const struct rte_ether_addr *); > > > > - if (rte_is_multicast_ether_addr(ea)) { > > > >

Re: [PATCH v3 03/26] app/test-bbdev: remove use of ethdev queue count value

2024-09-19 Thread David Marchand
On Wed, Aug 14, 2024 at 12:50 PM Bruce Richardson wrote: > > Replace the use of RTE_MAX_QUEUES_PER_PORT, which is intended as an > ethdev define, with the limit from the bbdev library. > > Signed-off-by: Bruce Richardson > Acked-by: Morten Brørup Cc: Maxime > --- > app/test-bbdev/test_bbdev.c

Re: [PATCH v3 01/26] cryptodev: remove use of ethdev max queues definition

2024-09-19 Thread David Marchand
On Wed, Aug 14, 2024 at 12:50 PM Bruce Richardson wrote: > > The number of queue pairs supported by cryptodev should not be dependent > on the number of ethdev Rx or Tx queues, so add a new define for > cryptodev specifically. > > Signed-off-by: Bruce Richardson > Acked-by: Morten Brørup > --- >

RE: [PATCH v2] eal: add build-time option to omit trace

2024-09-19 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Thursday, 19 September 2024 10.52 > > On Thu, Sep 19, 2024 at 1:37 PM Morten Brørup > wrote: > > > > Some applications want to omit the trace feature. > > Either to reduce the memory footprint, to reduce the exposed attack > > surface, or

RE: [PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-19 Thread Pavan Nikhilesh Bhagavatula
> > From: pbhagavat...@marvell.com > > Sent: Tuesday, September 17, 2024 3:11 AM > > To: jer...@marvell.com; sthot...@marvell.com; Sevincer, Abdullah > > ; hemant.agra...@nxp.com; > > sachin.sax...@oss.nxp.com; Van Haaren, Harry > ; > > mattias.ronnb...@ericsson.com; lian...@liangbit.com; Mccarthy

Re: [PATCH v2 0/4] simplify doing 32-bit DPDK builds

2024-09-19 Thread Bruce Richardson
On Thu, Sep 19, 2024 at 02:09:20PM +0200, Robin Jarry wrote: > David Marchand, Sep 19, 2024 at 13:32: > > On Thu, Sep 19, 2024 at 1:15 PM Bruce Richardson > > wrote: > > > > > > On Thu, Sep 19, 2024 at 10:08:21AM +0200, David Marchand wrote: > > > > On Thu, Sep 19, 2024 at 10:02 AM Bruce Richardso

Re: [PATCH] net/virtio-user: reset used index counter in dev reset

2024-09-19 Thread Maxime Coquelin
On 8/5/24 12:08, Kommula Shiva Shankar wrote: When the virtio device is reinitialized during ethdev reconfiguration, all the virtio rings are recreated and repopulated on the device. Accordingly, reset the used index counter value back to zero. Signed-off-by: Kommula Shiva Shankar --- driv

Re: [PATCH v5 1/1] dts: add text parser for testpmd verbose output

2024-09-19 Thread Juraj Linkeš
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py @@ -577,6 +577,497 @@ class TestPmdPortStats(TextParser): tx_bps: int = field(metadata=TextParser.find_int(r"Tx-bps:\s+(\d+)")) +class PacketOffloadFlag(Flag): +"""Flag r

Re: [PATCH] vhost: fix offset while mmaping log base address

2024-09-19 Thread Maxime Coquelin
On 7/8/24 08:57, BillXiang wrote: From: BillXiang For sanity the offset should be the last parameter of mmap. Fixes: fbc4d24 ("vhost: fix offset while mmaping log base address") Signed-off-by: BillXiang --- lib/vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: [PATCH] vhost: fix offset while mmaping log base address

2024-09-19 Thread Maxime Coquelin
On 7/8/24 08:57, BillXiang wrote: From: BillXiang For sanity the offset should be the last parameter of mmap. Fixes: fbc4d24 ("vhost: fix offset while mmaping log base address") Signed-off-by: BillXiang --- lib/vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 0/4] simplify doing 32-bit DPDK builds

2024-09-19 Thread Robin Jarry
David Marchand, Sep 19, 2024 at 13:32: On Thu, Sep 19, 2024 at 1:15 PM Bruce Richardson wrote: > > On Thu, Sep 19, 2024 at 10:08:21AM +0200, David Marchand wrote: > > On Thu, Sep 19, 2024 at 10:02 AM Bruce Richardson > > wrote: > > > Overall, I think we haven't increased our minimum meson versi

Re: [PATCH v4 00/11] support software live migration

2024-09-19 Thread Maxime Coquelin
On 8/5/24 04:12, Chaoyong He wrote: This patch series aims to add the support of software live migration feature for NFP vDPA device. --- v4: * Rebase to the newest main branch. * Add the 'Review-by' tag of the external reviewer. v3: * Fix one compile error when using standard atomic. v2: * A

Re: [PATCH] vhost-user: optimize stats counters performance

2024-09-19 Thread Maxime Coquelin
On 8/2/24 16:32, Morten Brørup wrote: Optimized the performance of updating the statistics counters by reducing the number of branches. Ordered the packet size comparisons according to the probability with typical internet traffic mix. Signed-off-by: Morten Brørup --- lib/vhost/virtio_net

Re: [PATCH v5] virtio: optimize stats counters performance

2024-09-19 Thread Maxime Coquelin
On 8/1/24 18:03, Morten Brørup wrote: Optimized the performance of updating the virtio statistics counters by reducing the number of branches. Ordered the packet size comparisons according to the probability with typical internet traffic mix. Signed-off-by: Morten Brørup --- v5: * Do not in

[PATCH] net/iavf: fix mac address with i40e PF Linux driver

2024-09-19 Thread David Marchand
Following an upstream Linux kernel change (see link), the mac address of a iavf port, serviced by a i40e PF driver, is reset to 0 during the VIRTCHNL_OP_GET_VF_RESOURCES query. The DPDK iavf driver then assigns a new random mac address. Such sequence is triggered every time the VF is initialised

Re: [PATCH v2 0/4] simplify doing 32-bit DPDK builds

2024-09-19 Thread David Marchand
On Thu, Sep 19, 2024 at 1:15 PM Bruce Richardson wrote: > > On Thu, Sep 19, 2024 at 10:08:21AM +0200, David Marchand wrote: > > On Thu, Sep 19, 2024 at 10:02 AM Bruce Richardson > > wrote: > > > Overall, I think we haven't increased our minimum meson version in some > > > time. Maybe it's time to

Re: [PATCH v2] dts: fix runner target in the Dockerfile

2024-09-19 Thread Juraj Linkeš
On 19. 9. 2024 11:36, Juraj Linkeš wrote: diff --git a/dts/Dockerfile b/dts/Dockerfile @@ -24,9 +27,12 @@ FROM base AS runner   # It bakes DTS into the image during the build.   COPY . /dpdk/dts -RUN poetry install --no-dev +# Adds ~/.local/bin to PATH so that packages installed with pipx

Re: [EXTERNAL] [PATCH] net/virtio-user: reset used index counter in dev reset

2024-09-19 Thread Maxime Coquelin
On 9/19/24 12:54, Maxime Coquelin wrote: Hi, On 9/6/24 12:14, Shiva Shankar Kommula wrote: Hello Maxime, could you please review the following change ? Thanks Subject: [EXTERNAL] [PATCH] net/virtio-user: reset used index counter in dev reset When the virtio device is reinitialized durin

Re: [PATCH v2 0/4] simplify doing 32-bit DPDK builds

2024-09-19 Thread Bruce Richardson
On Thu, Sep 19, 2024 at 10:08:21AM +0200, David Marchand wrote: > On Thu, Sep 19, 2024 at 10:02 AM Bruce Richardson > wrote: > > Overall, I think we haven't increased our minimum meson version in some > > time. Maybe it's time to consider doing so in this release or the next one? > > Need to look

Re: [RFC v3 1/3] uapi: introduce kernel uAPI headers import

2024-09-19 Thread Thomas Monjalon
11/09/2024 21:32, Maxime Coquelin: > This patch introduces uAPI headers import into the DPDK > repository. This import is possible thanks to Linux Kernel > licence exception for syscalls: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/exceptions/Linux-syscall-

Re: [EXTERNAL] [PATCH] net/virtio-user: reset used index counter in dev reset

2024-09-19 Thread Maxime Coquelin
Hi, On 9/6/24 12:14, Shiva Shankar Kommula wrote: Hello Maxime, could you please review the following change ? Thanks Subject: [EXTERNAL] [PATCH] net/virtio-user: reset used index counter in dev reset When the virtio device is reinitialized during ethdev reconfiguration, all the virtio rings

Re: [PATCH v12 3/3] event/dsw: add capability for independent enqueue

2024-09-19 Thread Jerin Jacob
On Mon, Sep 9, 2024 at 9:43 PM Abdullah Sevincer wrote: > > To use independent enqueue capability applications need to set flag > RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the > capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this > commit adds the capability of inde

RE: [EXTERNAL] [PATCH v12 2/3] event/dlb2: add support for independent enqueue

2024-09-19 Thread Jerin Jacob
> -Original Message- > From: Abdullah Sevincer > Sent: Monday, September 9, 2024 9:35 PM > To: dev@dpdk.org > Cc: Jerin Jacob ; bruce.richard...@intel.com; > pravin.pat...@intel.com; mattias.ronnb...@ericsson.com; > manish.aggar...@intel.com; Abdullah Sevincer > Subject: [EXTERNAL] [PATCH

Re: [PATCH v2] eal: add build-time option to omit trace

2024-09-19 Thread Jerin Jacob
On Thu, Sep 19, 2024 at 1:37 PM Morten Brørup wrote: > > Some applications want to omit the trace feature. > Either to reduce the memory footprint, to reduce the exposed attack > surface, or for other reasons. > > This patch adds an option in rte_config.h to include or omit trace in the > build.

[DPDK/meson Bug 1542] [dpdk21.11.8-rc1] meson build failed on Ubuntu24.04 and Fedora40

2024-09-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1542 Kevin Traynor (ktray...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED Status|UN

  1   2   >