RE: [EXTERNAL] [PATCH v3 1/2] cryptodev: fix crypto callbacks on unsetting callbacks macro

2024-06-26 Thread Akhil Goyal
> Crypto callbacks APIs are available in header files but when > the macro RTE_CRYPTO_CALLBACKS unset, test application need to > put #ifdef in its code. > > The test application should be able to build and run, regardless > DPDK library is built with RTE_CRYPTO_CALLBACKS defined or not. > > Adde

[PATCH v4 2/2] examples/l3fwd-power: add PM QoS configuration

2024-06-26 Thread Huisong Li
Add PM QoS configuration to declease the delay after sleep in case of entering deeper idle state. Signed-off-by: Huisong Li Acked-by: Morten Brørup --- examples/l3fwd-power/main.c | 28 1 file changed, 28 insertions(+) diff --git a/examples/l3fwd-power/main.c b/exa

[PATCH v4 0/2] power: introduce PM QoS interface

2024-06-26 Thread Huisong Li
The deeper the idle state, the lower the power consumption, but the longer the resume time. Some service are delay sensitive and very except the low resume time, like interrupt packet receiving mode. And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs interface is used to s

[PATCH v4 1/2] power: introduce PM QoS API on CPU wide

2024-06-26 Thread Huisong Li
The deeper the idle state, the lower the power consumption, but the longer the resume time. Some service are delay sensitive and very except the low resume time, like interrupt packet receiving mode. And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs interface is used to s

Recall: [PATCH v2] config/arm: add Ampere AmpereOneX platform

2024-06-26 Thread Yutang Jiang
Yutang Jiang would like to recall the message, "[PATCH v2] config/arm: add Ampere AmpereOneX platform". CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Ampe

[PATCH] app/dma-perf: documentation update of DMA perf for idxd

2024-06-26 Thread Shaiq Wani
Added a note to avoid usage errors by end user. Signed-off-by: Shaiq Wani --- app/test-dma-perf/config.ini | 3 +++ doc/guides/tools/dmaperf.rst | 1 + 2 files changed, 4 insertions(+) diff --git a/app/test-dma-perf/config.ini b/app/test-dma-perf/config.ini index a1222ae86c..5008103979 100644 -

[PATCH] app/eventdev: increase default queue depth for cryptodev

2024-06-26 Thread Aakash Sasidharan
With crypto adapter, larger queue depths are desirable since same queue could be used from multiple cores at the same time. With devices that are capable of doing large bursts, larger queues would help in multi core management of same queue. Increase default queue depth in cryptodev to cater to su

RE: [PATCH v1] crypto/cnxk: minimal normalization on input

2024-06-26 Thread Akhil Goyal
> Subject: [PATCH v1] crypto/cnxk: minimal normalization on input > > Fix modex to nomalize input only when MSW is zero. > > Fixes: 5a3513caeb45 ("crypto/cnxk: add asymmetric session") > Cc: sta...@dpdk.org > > Signed-off-by: Gowrishankar Muthukrishnan Title updated as " crypto/cnxk: fix minima

RE: [PATCH v3 0/3] test/crypto: add modex test for zero padding

2024-06-26 Thread Akhil Goyal
> This patch series add modex test for zero padded operands > > v3: > - removed patch to use common test function which will be addressed >seperately due to document conflict. > > Gowrishankar Muthukrishnan (3): > test/crypto: validate modex result from first nonzero value > test/crypto:

RE: [PATCH v3 00/12] Fixes and improvements to CNXK crypto PMD

2024-06-26 Thread Akhil Goyal
> Subject: [PATCH v3 00/12] Fixes and improvements to CNXK crypto PMD > > v3: > * Fix compilation error by moving function meant for arm64 under > "#if defined(RTE_ARCH_ARM64)" guard. > v2: > * Fix compilation errors observed with arm gcc-13. > > This series adds improvements to CNXK crypto PMD

[PATCH] doc: documentation update for idxd driver

2024-06-26 Thread Shaiq Wani
Added a note to avoid usage errors by end user. Signed-off-by: Shaiq Wani --- app/test-dma-perf/config.ini | 3 +++ doc/guides/tools/dmaperf.rst | 1 + 2 files changed, 4 insertions(+) diff --git a/app/test-dma-perf/config.ini b/app/test-dma-perf/config.ini index a1222ae86c..5008103979 100644 -

RE: [PATCH v2] config/arm: add Ampere AmpereOneX platform

2024-06-26 Thread Yutang Jiang
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 20, 2024 3:44 AM > To: ruifeng.w...@arm.com; wathsala.vithan...@arm.com; > honnappa.nagaraha...@arm.com > Cc: dev@dpdk.org; Open Source Submission > ; Yutang Jiang > ; Yutang Jiang OS > ; n...@arm.com; > juraj.lin...@pan

RE: [PATCH v2] config/arm: add Ampere AmpereOneX platform

2024-06-26 Thread Yutang Jiang
Thank you, Ruifeng. I noticed that variable patch, and have updated and submitted a new v3 patch. > -Original Message- > From: Ruifeng Wang > Sent: Thursday, June 20, 2024 4:41 PM > To: Yutang Jiang OS ; > dev@dpdk.org > Cc: Open Source Submission ; Yutang Jiang > ; n...@arm.com; > juraj.

RE: [EXTERNAL] [PATCH v2] app/graph: fix destination buffer too small

2024-06-26 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: Mahmoud Matook > Sent: Thursday, June 27, 2024 1:49 AM > To: Kiran Kumar Kokkilagadda > Cc: Sunil Kumar Kori ; Rakesh Kudurumalla > ; Nithin Kumar Dabilpuram > ; Jerin Jacob ; > dev@dpdk.org > Subject: Re: [EXTERNAL] [PATCH v2] app/graph: fix destination bu

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-06-26 Thread Kundapura, Ganapati
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Wednesday, June 26, 2024 11:33 AM > To: Kundapura, Ganapati ; dev@dpdk.org; > Gujjar, Abhinandan S ; Mcnamara, John > ; Richardson, Bruce > > Cc: Morten Brørup ; ferruh.yi...@amd.com; > fanzhang@gmail.com; tho...@monjalon.net

[PATCH v3 2/2] cryptodev: validate crypto callbacks from next node

2024-06-26 Thread Ganapati Kundapura
Crypto callbacks are invoked on checking from head node which is always valid pointer. This patch checks next node from the head node if callbacks registered before invoking callbacks. Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks") Signed-off-by: Ganapati Kundapura --- v3

[PATCH v3 1/2] cryptodev: fix crypto callbacks on unsetting callbacks macro

2024-06-26 Thread Ganapati Kundapura
Crypto callbacks APIs are available in header files but when the macro RTE_CRYPTO_CALLBACKS unset, test application need to put #ifdef in its code. The test application should be able to build and run, regardless DPDK library is built with RTE_CRYPTO_CALLBACKS defined or not. Added ENOTSUP from t

Re: [PATCH] app/graph: fix destination buffer too small

2024-06-26 Thread Mahmoud Matook
On 06/23, Stephen Hemminger wrote: > On Mon, 24 Jun 2024 00:09:21 +0400 > Mahmoud Maatuq wrote: > > > as sizeof(config.rx.mempool_name) is < sizeof(res->mempool), it's safer > > to copy min size of them to avoide out of bound memory write. > > > > Coverity issue: 415430 > > Fixes: 3850cb06ab9c

Re: [EXTERNAL] [PATCH v2] app/graph: fix destination buffer too small

2024-06-26 Thread Mahmoud Matook
On 06/25, Kiran Kumar Kokkilagadda wrote: > > > From: Mahmoud Maatuq > Sent: Tuesday, June 25, 2024 1:31 AM > To: Sunil Kumar Kori ; Rakesh Kudurumalla > ; Nithin Kumar Dabilpuram > ; Jerin Jacob > Cc: dev@dpdk.org; Mahmoud Maatuq > Subject: [EXTERNAL] [PATCH v2] app/graph: fix destination

RE: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-26 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 26 June 2024 20.48 > > On Wed, Jun 26, 2024 at 05:24:04PM +0200, Maxime Coquelin wrote: > > > > > > On 6/26/24 16:58, Stephen Hemminger wrote: > > > On Wed, 26 Jun 2024 10:37:31 +0200 > > > Maxime Coquelin wrote: > > > > >

[PATCH v4 20/23] net/ntnic: add QSFP28 support

2024-06-26 Thread Serhii Iliushyk
Includes support for QSFP28 Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntnic_nim.h| 21 ++ drivers/net/ntnic/link_mgmt/nt4ga_link.c | 25 +++ drivers/net/ntnic/nim/i2c_nim.c | 267 ++- drivers/net/ntnic/nim/nim_defines.h | 1 + 4 files

[PATCH v4 22/23] net/ntnic: add MAC PCS register interface module

2024-06-26 Thread Serhii Iliushyk
Add API for MAC and PCS(Physical Coding Sublayer) Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/nt4ga_link.h| 1 + .../link_mgmt/link_100g/nt4ga_link_100g.c | 393 +++- drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_co

[PATCH v4 18/23] net/ntnic: add NIM module

2024-06-26 Thread Serhii Iliushyk
Add API for control NIM Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 34 +++ drivers/net/ntnic/include/nt4ga_adapter.h | 3 + drivers/net/ntnic/include/nt4ga_link.h| 13 + drivers/net/ntnic/include/ntnic_nim.h | 61 + .../link_mg

[PATCH v4 23/23] net/ntnic: add GMF (Generic MAC Feeder) module

2024-06-26 Thread Serhii Iliushyk
Add API for Generic MAC Feeder Signed-off-by: Serhii Iliushyk --- .../link_mgmt/link_100g/nt4ga_link_100g.c | 8 ++ drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_core.h | 1 + .../net/ntnic/nthw/core/include/nthw_gmf.h| 64 + d

[PATCH v4 21/23] net/ntnic: add GPIO PHY module

2024-06-26 Thread Serhii Iliushyk
Add GPIO API for comunication with NIM Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/nt4ga_link.h| 1 + .../link_mgmt/link_100g/nt4ga_link_100g.c | 71 - drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_core.h |

[PATCH v4 19/23] net/ntnic: add QSFP support

2024-06-26 Thread Serhii Iliushyk
Includes support for QSFP and QSFP+. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntnic_nim.h | 10 + .../link_mgmt/link_100g/nt4ga_link_100g.c | 12 +- drivers/net/ntnic/nim/i2c_nim.c | 310 +- drivers/net/ntnic/nim/i2c_nim.h

[PATCH v4 14/23] net/ntnic: add clock profiles for the NT200A0X smartNIC

2024-06-26 Thread Serhii Iliushyk
Add API for control clock NT200 and FW 9563 Signed-off-by: Serhii Iliushyk --- .../ntnic/include/clock_profiles_structs.h| 35 + .../include/ntnic_nthw_fpga_rst_nt200a0x.h| 1 + drivers/net/ntnic/meson.build | 2 + .../net/ntnic/nthw/core/include/nthw_core.h | 2

[PATCH v4 16/23] net/ntnic: add link management module

2024-06-26 Thread Serhii Iliushyk
Add link control API Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 6 + drivers/net/ntnic/include/nt4ga_adapter.h | 5 +- drivers/net/ntnic/include/nt4ga_link.h | 84 +++ drivers/net/ntnic/link_mgmt/nt4ga_link.c | 176 +++ drivers/net

[PATCH v4 15/23] net/ntnic: add MAC and packet features

2024-06-26 Thread Serhii Iliushyk
Add basic control for MAC addresses packets and queues Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntos_drv.h | 15 +++ drivers/net/ntnic/ntnic_ethdev.c | 39 ++-- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/net/ntn

[PATCH v4 10/23] net/ntnic: add core platform functionality

2024-06-26 Thread Serhii Iliushyk
Add ntnic platform interfaces for FPGA registers Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_core.h | 16 + .../net/ntnic/nthw/core/include/nthw_hif.h| 151 .../net/ntnic/nthw/core/include/nthw_iic.h

[PATCH v4 13/23] net/ntnic: add reset module for the NT200A0X smartNIC

2024-06-26 Thread Serhii Iliushyk
Add API for reset NT200 and FW 9563 Signed-off-by: Serhii Iliushyk --- .../include/ntnic_nthw_fpga_rst_nt200a0x.h| 81 +++ drivers/net/ntnic/meson.build | 3 + .../net/ntnic/nthw/core/include/nthw_core.h | 2 + .../net/ntnic/nthw/core/include/nthw_fpga.h | 6 + ...

[PATCH v4 17/23] net/ntnic: add link 100G module

2024-06-26 Thread Serhii Iliushyk
Add ntnic 100G link support. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 12 - .../link_mgmt/link_100g/nt4ga_link_100g.c | 49 +++ drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic/ntnic_mod_reg.c |

[PATCH v4 11/23] net/ntnic: add FPGA initialization functionality

2024-06-26 Thread Serhii Iliushyk
Enable FPGA initalization Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 52 +++- drivers/net/ntnic/meson.build | 7 + .../net/ntnic/nthw/core/include/nthw_core.h | 4 + .../net/ntnic/nthw/core/include/nthw_fpga.h | 22 ++ drivers/net

[PATCH v4 12/23] net/ntnic: add support of the NT200A0X smartNIC

2024-06-26 Thread Serhii Iliushyk
Add ntnic support for NT200A0X NIC Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 6 +++ drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_fpga.h | 7 +++ .../nthw/core/nt200a0x/nthw_fpga_nt200a0x.c | 54 +

[PATCH v4 08/23] net/ntnic: add adapter initialization

2024-06-26 Thread Serhii Iliushyk
Add interfaces for initialize the adapter Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 148 ++ drivers/net/ntnic/include/nt4ga_adapter.h | 40 ++ drivers/net/ntnic/include/ntdrv_4ga.h | 2 + drivers/net/ntnic/meson.build

[PATCH v4 07/23] net/ntnic: add core platform functionality

2024-06-26 Thread Serhii Iliushyk
Add ntnic basic platform interfaces Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntos_drv.h | 2 + drivers/net/ntnic/meson.build | 2 + drivers/net/ntnic/nthw/nthw_drv.h | 88 ++ drivers/net/ntnic/nthw/nthw_platform.c | 14 +++

[PATCH v4 05/23] net/ntnic: add VFIO module

2024-06-26 Thread Serhii Iliushyk
Add ntnic VFIO functionality. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic/ntnic_ethdev.c | 20 +- drivers/net/ntnic/ntnic_vfio.c | 235 + drivers/net/ntnic/ntnic_vfio.h | 29 +++

[PATCH v4 06/23] net/ntnic: add NT NIC driver dependencies

2024-06-26 Thread Serhii Iliushyk
Add structures and interfaces specific for NT smartNiC Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/ntdrv_4ga.h | 17 ++ drivers/net/ntnic/include/ntos_drv.h| 33 drivers/net/ntnic/include/ntos_system.h | 21 ++ drivers/net/ntnic/meson.build | 1 + drive

[PATCH v4 03/23] net/ntnic: add minimal initialization for PCI device

2024-06-26 Thread Serhii Iliushyk
add implementation for probe/init and remove/deinit of the PCI device Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/ntnic_ethdev.c | 104 ++- 1 file changed, 103 insertions(+), 1 deletion(-) diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntn

[PATCH v4 04/23] net/ntnic: add NT utilities implementation

2024-06-26 Thread Serhii Iliushyk
Add ntnic utilities. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/meson.build | 2 ++ drivers/net/ntnic/ntnic_ethdev.c | 2 ++ drivers/net/ntnic/ntutil/include/nt_util.h | 28 ++ drivers/net/ntnic/ntutil/nt_util.c | 33

[PATCH v4 02/23] net/ntnic: add logging implementation

2024-06-26 Thread Serhii Iliushyk
Add ntnic specific implementation for logging Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/meson.build | 2 + drivers/net/ntnic/ntlog/include/ntlog.h | 49 +++ drivers/net/ntnic/ntlog/ntlog.c | 53 + drivers/net/ntnic/ntnic_e

[PATCH v4 01/23] net/ntnic: add ethdev and makes PMD available

2024-06-26 Thread Serhii Iliushyk
Add ntnic ethdev base implementation Signed-off-by: Serhii Iliushyk --- .mailmap | 1 + MAINTAINERS| 7 doc/guides/nics/features/ntnic.ini | 9 + doc/guides/nics/index.rst | 1 + doc/guides/nics/ntnic.rst | 43

Re: [PATCH v3 3/3] dts: queue suite conf schema

2024-06-26 Thread Jeremy Spewock
On Wed, Jun 26, 2024 at 9:52 AM Dean Marx wrote: > > Configuration schema for the queue_start_stop suite. > > Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock

Re: [PATCH v3 2/3] dts: add functions to testpmd shell

2024-06-26 Thread Jeremy Spewock
On Wed, Jun 26, 2024 at 9:52 AM Dean Marx wrote: > > added set promisc, set verbose, and port stop > commands to testpmd shell. > > Signed-off-by: Dean Marx > --- > dts/framework/remote_session/testpmd_shell.py | 157 +++--- > 1 file changed, 136 insertions(+), 21 deletions(-) > > di

Re: [PATCH v3 1/3] dts: initial queue start/stop suite implementation

2024-06-26 Thread Jeremy Spewock
Overall, this looks good to me. I just left some small comments, mostly about documentation, but a few about logic. I still think however that this commit should come after the testpmd changes in the order of the patches. Also, it looks like this series is throwing some warnings/errors with the f

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-26 Thread Mattias Rönnblom
On Wed, Jun 26, 2024 at 05:24:04PM +0200, Maxime Coquelin wrote: > > > On 6/26/24 16:58, Stephen Hemminger wrote: > > On Wed, 26 Jun 2024 10:37:31 +0200 > > Maxime Coquelin wrote: > > > > > On 6/25/24 21:27, Mattias Rönnblom wrote: > > > > On Tue, Jun 25, 2024 at 05:29:35PM +0200, Maxime Coquel

RE: [PATCH v3 2/2] eventdev: add support for enqueue reorder

2024-06-26 Thread Sevincer, Abdullah
Hi Jerin my responses below: >+# Is this feature or limitation? This is a new feature to enable enqueuing to PMD in any order when the underlined hardware device needs enqueues in a strict dequeue order. >+# What is the use case for this feature? This is needed by the applications which processes

Re: [PATCH v7 3/3] dts: config schema

2024-06-26 Thread Jeremy Spewock
On Tue, Jun 25, 2024 at 11:34 AM Dean Marx wrote: > > Configuration to run vlan test suite > > Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock

Re: [PATCH v7 2/3] dts: add VLAN methods to testpmd shell

2024-06-26 Thread Jeremy Spewock
The functionality all looks good to me, just a few documentation nit-picks and a suggestion for something that I think could shorten up one function. On Tue, Jun 25, 2024 at 11:34 AM Dean Marx wrote: > > added the following methods to testpmd shell class: > vlan set filter on/off, rx vlan add/rm,

Re: [PATCH v7 1/3] dts: VLAN test suite implementation

2024-06-26 Thread Jeremy Spewock
Hey Dean, thanks for the update! I just went through and added my comments to the patches, but most of my feedback was about documentation and a few places where I think the classes could be improved by refactoring a little bit and breaking some things out into their own methods. A few comments on

[PATCH v3 8/8] net/mlx5: add async flow operation validation

2024-06-26 Thread Dariusz Sosnowski
This patch adds validation to implementations of the following API functions: - rte_flow_async_create() - rte_flow_async_create_by_index() - rte_flow_async_update() - rte_flow_async_destroy() These validations are enabled if and only if RTE_LIBRTE_MLX5_DEBUG macro is defined. Signed-off-by: Dari

[PATCH v3 6/8] net/mlx5: store modify field action

2024-06-26 Thread Dariusz Sosnowski
When template table is created, list of unmasked actions is recorded for future flow rule insertions. This patch expands entries for RTE_FLOW_ACTION_TYPE_MODIFY_FIELD actions in this list with a copy of the action from the template. This will be used in follow up commits which add flow rule operati

[PATCH v3 7/8] common/mlx5: add debug mode indicator

2024-06-26 Thread Dariusz Sosnowski
Add mlx5_fp_debug_enabled() function which: - returns true if RTE_LIBRTE_MLX5_DEBUG is defined, - returns false otherwise. This allows for conditional execution of code meant to be executed only when mlx5 debug mode is enabled, without adding conditional compilation guards inside source code. Whe

[PATCH v3 4/8] net/mlx5: store original actions in template

2024-06-26 Thread Dariusz Sosnowski
When actions template is created in mlx5 PMD, some actions will be replaced with another or some actions will be added to implement required template semantics on NVIDIA NICs. For example: - RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID actions is replaced with modify field action. - Modify field action

[PATCH v3 5/8] net/mlx5: store expected type on indirect action

2024-06-26 Thread Dariusz Sosnowski
When template table is created, list of unmasked actions is recorded for future flow rule insertions. This patch expands entries for RTE_FLOW_ACTION_TYPE_INDIRECT actions in this list with information about expected indirect action type. This will be used in follow up commits which add flow rule op

[PATCH v3 3/8] net/mlx5: store pattern template items

2024-06-26 Thread Dariusz Sosnowski
Store items which define the pattern template on creation. This allows validation of items, provided by the user during flow rule creation, against pattern template. Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.h| 2 ++ drivers/net/mlx5/mlx5_flow_hw.c |

[PATCH v3 2/8] net/mlx5: extract queue index validation

2024-06-26 Thread Dariusz Sosnowski
Extract validation of queue index out of validation of RTE_FLOW_ACTION_TYPE_QUEUE action to allow reuse in template API flow rule creation implementation. Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 59 +--- drivers/net/m

[PATCH v3 1/8] net/mlx5: extract target port validation

2024-06-26 Thread Dariusz Sosnowski
Extract code responsible for validation if port specified in configuration of RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT action is correct. Allow for reuse of this logic for both RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT actions and RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT items. Signed-off-by: Dariusz Sosnowsk

[PATCH v3 0/8] net/mlx5: flow fast path validation

2024-06-26 Thread Dariusz Sosnowski
This patchset adds validations for flow items and actions supplied by the user to fast path async flow API functions implemented in mlx5 PMD. - Patches 1-7: Prepares mlx5 PMD for adding fast path validations. Specifically: - Required functionality for validating queue indexes and target r

Re: [PATCH v4 000/103] Update net/ice base driver to latest upstream snapshot

2024-06-26 Thread Bruce Richardson
On Wed, Jun 26, 2024 at 12:40:48PM +0100, Anatoly Burakov wrote: > This is a patchset loosely based on internal development tree which > tracked ICE driver development over a period of time since last > snapshot update. > > v3-> v4: > - Rebased on top of latest next-net-intel as some patches were

[PATCH] net/ice: use a different method to filter LLDP packets

2024-06-26 Thread Vladimir Medvedkin
Currently, ice_dev_init() calls ice_vsi_config_sw_lldp(), which uses switch filters to match packets ethertype to redirect LLDP packets to the default VSI. However, some NVMs have an issue creating such a rule. This patch changes the method from using LLDP ethertyple switch filter to utilizing a s

Re: [PATCH] doc: enhance the global log level documentation

2024-06-26 Thread Ilya Maximets
On 6/26/24 17:09, David Marchand wrote: > The current documentation is non intuitive in that the global log level > can be understood as being a single knob controlling all components > logs. > On the contrary, all the global log level is for is to reduce verbosity > globally. > > Remove examples

Re: [PATCH 3/3] dts: mac filter test suite refactored for new dts

2024-06-26 Thread Jeremy Spewock
On Fri, Jun 21, 2024 at 1:24 PM Nicholas Pratte wrote: > > The mac address filter test suite, whose test cases are based on old > DTS's test cases, has been refactored to interface with the new DTS > framework. > > In porting over this test suite into the new framework, some > adjustments were mad

Re: [PATCH 2/3] dts: add testpmd methods for test suite

2024-06-26 Thread Jeremy Spewock
I think the subject line of this commit makes sense in the context of this series, but might be less helpful when the commit is applied to the git tree. For this reason I might favor changing it to something that briefly says what the added testpmd commands actually do. On Fri, Jun 21, 2024 at 1:2

Re: [PATCH 1/3] dts: add boolean to adjust addresses

2024-06-26 Thread Jeremy Spewock
This is funny because I actually ended up trying to solve the same problem when writing the dynamic queue test suite. We ended up taking different approaches, so we should probably have a discussion about the best way to handle this. Now that we have a few use cases for why this fix is needed, it w

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-26 Thread Maxime Coquelin
On 6/26/24 16:58, Stephen Hemminger wrote: On Wed, 26 Jun 2024 10:37:31 +0200 Maxime Coquelin wrote: On 6/25/24 21:27, Mattias Rönnblom wrote: On Tue, Jun 25, 2024 at 05:29:35PM +0200, Maxime Coquelin wrote: Hi Mattias, On 6/20/24 19:57, Mattias Rönnblom wrote: This patch set make DPDK

[PATCH] doc: enhance the global log level documentation

2024-06-26 Thread David Marchand
The current documentation is non intuitive in that the global log level can be understood as being a single knob controlling all components logs. On the contrary, all the global log level is for is to reduce verbosity globally. Remove examples of setting --log-level=8|debug, which is a noop. Cc:

Re: [PATCH] eal/linux: lower log level on allocation attempt failure

2024-06-26 Thread Stephen Hemminger
On Wed, 26 Jun 2024 16:51:42 +0200 David Marchand wrote: > On a ARM system with only 2MB hugepages configured, EAL emits an error > log with allocations larger than 512MB. > > Example with testpmd: > $ dpdk-testpmd --in-memory --no-pci --log-level=*:debug -- -i > ... > EAL: In-memory mode enable

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-26 Thread Stephen Hemminger
On Wed, 26 Jun 2024 10:37:31 +0200 Maxime Coquelin wrote: > On 6/25/24 21:27, Mattias Rönnblom wrote: > > On Tue, Jun 25, 2024 at 05:29:35PM +0200, Maxime Coquelin wrote: > >> Hi Mattias, > >> > >> On 6/20/24 19:57, Mattias Rönnblom wrote: > >>> This patch set make DPDK library, driver, and a

[PATCH] eal/linux: lower log level on allocation attempt failure

2024-06-26 Thread David Marchand
On a ARM system with only 2MB hugepages configured, EAL emits an error log with allocations larger than 512MB. Example with testpmd: $ dpdk-testpmd --in-memory --no-pci --log-level=*:debug -- -i ... EAL: In-memory mode enabled, hugepages of size 33554432 bytes will be allocated anonymously

[PATCH v3 3/3] dts: queue suite conf schema

2024-06-26 Thread Dean Marx
Configuration schema for the queue_start_stop suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a31

[PATCH v3 2/3] dts: add functions to testpmd shell

2024-06-26 Thread Dean Marx
added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 157 +++--- 1 file changed, 136 insertions(+), 21 deletions(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/fram

[PATCH v3 1/3] dts: initial queue start/stop suite implementation

2024-06-26 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_queue_start_stop.py | 88 + 1 file changed, 88 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py di

RE: [PATCH v2 0/6] app/crypto-perf: add asymmetric crypto tests

2024-06-26 Thread Akhil Goyal
> Subject: [PATCH v2 0/6] app/crypto-perf: add asymmetric crypto tests > > This patch series adds below asymmetric tests in crypto-perf tool: > * MODEX group tests (RFC 3526) > * SM2 tests > * ECDSA P256R1 tests > > Akhil Goyal (1): > app/crypto-perf: support SM2 > > Gowrishankar Muthukr

RE: [PATCH] mbuf: fix API to copy mbuf dynamic fields

2024-06-26 Thread Morten Brørup
> From: Shijith Thotton [mailto:sthot...@marvell.com] > Sent: Wednesday, 26 June 2024 14.08 > > Fixed rte_mbuf_dynfield_copy() API to copy dynamic fields from one mbuf > to another. When RTE_IOVA_AS_PA is not defined during the build, an > additional dynamic field (dynfield2) becomes available. Th

Re: [PATCH v4 093/103] net/ice/base: make Tx and Rx vernier offset calibration independent

2024-06-26 Thread Burakov, Anatoly
On 6/26/2024 1:42 PM, Anatoly Burakov wrote: The Tx and Rx calibration and timestamp generation blocks are independent. It is not required to wait for both to complete before programming the offsets. Instead, we can program the offset for each independently as soon as they are ready. Modify the

Re: [PATCH v4 093/103] net/ice/base: make Tx and Rx vernier offset calibration independent

2024-06-26 Thread Bruce Richardson
On Wed, Jun 26, 2024 at 02:11:32PM +0200, Burakov, Anatoly wrote: > On 6/26/2024 1:42 PM, Anatoly Burakov wrote: > > The Tx and Rx calibration and timestamp generation blocks are independent. > > It is > > not required to wait for both to complete before programming the offsets. > > Instead, we ca

Re: [PATCH v4 073/103] net/ice/base: add port option commands

2024-06-26 Thread Burakov, Anatoly
On 6/26/2024 1:42 PM, Anatoly Burakov wrote: Adds the Set/Get Port Options commands (0x06EA/0x06EB), also include additional status and ID bits to improve the Link topology configuration as well as ability to change port option from pre-boot environment via the UEFI driver. Signed-off-by: Anatol

Re: [PATCH v4 096/103] net/ice/base: make is_gps_present more generic

2024-06-26 Thread Burakov, Anatoly
On 6/26/2024 1:42 PM, Anatoly Burakov wrote: The driver checks the netlist for nodes indicating hardware support using functions named "ice_is__present" sometimes with an additional _e810t postfix. These functions check the contents of the netlist, and don't make any direct device ID check. When

[PATCH] mbuf: fix API to copy mbuf dynamic fields

2024-06-26 Thread Shijith Thotton
Fixed rte_mbuf_dynfield_copy() API to copy dynamic fields from one mbuf to another. When RTE_IOVA_AS_PA is not defined during the build, an additional dynamic field (dynfield2) becomes available. This field should be conditionally copied to ensure the complete duplication of dynamic fields between

[PATCH v4 103/103] net/ice: add new device ids

2024-06-26 Thread Anatoly Burakov
From: Bruce Richardson Add new device ids for latest gen NICs. Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index dbdcacf019..f7189b2dfe 100644 --- a/dri

[PATCH v4 102/103] net/ice/base: add missing files for shared code update

2024-06-26 Thread Anatoly Burakov
From: Ian Stokes Add missing files that are present in shared code update. Although these do not contain code add them so that shared code update matches like for like. Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_fwlog.c | 5 + .../{vmxnet3/base/vmwar

[PATCH v4 101/103] net/ice/base: introduce new functions in ice_sched_node

2024-06-26 Thread Anatoly Burakov
From: Michal Wilczynski Add new functions to configure the hardware with new parameters. Signed-off-by: Michal Wilczynski Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_sched.c | 52 drivers/net/ice/base/ice_sched.h | 9 ++ 2 files changed, 61 ins

[PATCH v4 100/103] net/ice/base: make some functions static

2024-06-26 Thread Anatoly Burakov
To better align with upstream release, remove some functions from switch header and make them static instead. Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 14 +++--- drivers/net/ice/base/ice_ptp_hw.h | 16 2 files changed, 7 insertions(+), 23 de

[PATCH v4 099/103] net/ice/base: make some functions non-static

2024-06-26 Thread Anatoly Burakov
To better align with base driver, make some functions non-static, and move structure definitions where necessary. Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 4 ++-- drivers/net/ice/base/ice_ptp_hw.h | 2 ++ drivers/net/ice/base/ice_sched.c | 8 +++ drivers/net

[PATCH v4 098/103] net/ice/base: align code to base driver

2024-06-26 Thread Anatoly Burakov
Currently, there are some miscellaneous changes that are missing from DPDK that are present in base driver code. This patch aligns our code to that of base driver, with following changes happening: - Whitespace/line break alignment (majority of changes) - Comment fixes - Moving function definition

[PATCH v4 097/103] net/ice/base: add missing defines and misc cleanup

2024-06-26 Thread Anatoly Burakov
From: Ian Stokes Add various missing defines and definitions that are currently not present in DPDK but are present in upstream code. Signed-off-by: Ian Stokes Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_adminq_cmd.h | 84 +++ drivers/net/ice/base/ice_l

[PATCH v4 096/103] net/ice/base: make is_gps_present more generic

2024-06-26 Thread Anatoly Burakov
The driver checks the netlist for nodes indicating hardware support using functions named "ice_is__present" sometimes with an additional _e810t postfix. These functions check the contents of the netlist, and don't make any direct device ID check. When upstreaming the functions to Linux, the name w

[PATCH v4 095/103] net/ice/base: rename SMA register macros

2024-06-26 Thread Anatoly Burakov
From: Jacob Keller The macros used to define the bits for controlling the SMA are different to what was submitted to Linux. Correct the names to match. Signed-off-by: Jacob Keller Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ptp_hw.c | 8 drivers/net/ice/base/ice_ptp_hw.h

[PATCH v4 094/103] net/ice/base: change a method to get pca9575 handle

2024-06-26 Thread Anatoly Burakov
From: Milena Olech More universal method for getting pca9575 handle is introduced. The first step is to look for CLK_MUX handle. Having that it is possible to find CLK_MUX GPIO pin. Provided data let check what is driving the pin - the expectation is that pca9575 node part number is returned. Si

[PATCH v4 093/103] net/ice/base: make Tx and Rx vernier offset calibration independent

2024-06-26 Thread Anatoly Burakov
The Tx and Rx calibration and timestamp generation blocks are independent. It is not required to wait for both to complete before programming the offsets. Instead, we can program the offset for each independently as soon as they are ready. Modify the ice_phy_cfg_tx_offset_e822 and ice_phy_cfg_rx_o

[PATCH v4 092/103] net/ice/base: implement TX interrupt enablement functions

2024-06-26 Thread Anatoly Burakov
From: Sergey Temerkhanov Introduce functions enabling/disabling TX TS interrupts for the E822 and ETH56G PHYs Signed-off-by: Sergey Temerkhanov Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 73 +++ drivers/net/ice/base/ice_ptp_hw.h | 4 ++

[PATCH v4 091/103] net/ice/base: remove PHY port timer bypass mode

2024-06-26 Thread Anatoly Burakov
From: Milena Olech Previous implementation switches between bypass and Vernier mode dynamically. However bypass mode should be removed due to low precision. Signed-off-by: Milena Olech Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 195 +- d

[PATCH v4 090/103] net/ice/base: cleanup timestamp registers correctly

2024-06-26 Thread Anatoly Burakov
From: Karol Kolacinski E822 PHY TS registers should not be written and the only way to cleanup them is to reset QUAD memory. To ensure that the status bit for the timestamp index is cleared, ensure that ice_clear_phy_tstamp implementations first read the timestamp out. Implementations which can

[PATCH v4 089/103] net/ice/base: enable CGU error reporting

2024-06-26 Thread Anatoly Burakov
From: Karol Kolacinski Enable CGU error reporting for SyncE and TimeSync issues. Process TimeSync loss of lock event by trying to acquire lock with the default config. Signed-off-by: Karol Kolacinski Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ptp_hw.c | 49

[PATCH v4 088/103] net/ice/base: update boost struct for traffic types

2024-06-26 Thread Anatoly Burakov
From: Przemek Kitszel Update boost struc to support both udp and vlan based on union. Signed-off-by: Przemek Kitszel Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_flex_type.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_fl

[PATCH v4 087/103] net/ice/base: add AQ function to configure SyncE error reporting

2024-06-26 Thread Anatoly Burakov
From: Ben Shelton The AE driver will call this function to enable the SyncE error reporting mechanism and enable event reporting when errors occur. Signed-off-by: Ben Shelton Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_adminq_cmd.h | 29 +++ drivers/net/ice/

[PATCH v4 086/103] net/ice/base: fix masking in ice_get_ctx()

2024-06-26 Thread Anatoly Burakov
From: Yahui Cao No need to invert mask since we only reserve the masked bits instead of clear them. Fixes: a03c714bfe0b ("net/ice/base: add two helper functions") Cc: qi.z.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Yahui Cao Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_comm

[PATCH v4 085/103] net/ice/base: use a variable to store reset count

2024-06-26 Thread Anatoly Burakov
From: Fabio Pricoco Depending on platform and whether silicon validation tools are used, the timeout value may be set to a different value. This patch uses a variable to store the reset count value as opposed to using the macro directly. Signed-off-by: Fabio Pricoco Signed-off-by: Ian Stokes -

[PATCH v4 084/103] net/ice/base: increase PF reset wait timeout to 500 milliseconds

2024-06-26 Thread Anatoly Burakov
From: Benjamin Mikailenko In the CORE ICE driver enabled devlink to issue EMPR resets during NVM update. As a result, resets took a matter of around 25ms longer than driver wait time to finish. Fix this by increasing driver wait time from 300ms to 500ms. Signed-off-by: Benjamin Mikailenko Sign

  1   2   3   >