Hi Akhil, > -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Wednesday, June 26, 2024 11:33 AM > To: Kundapura, Ganapati <ganapati.kundap...@intel.com>; dev@dpdk.org; > Gujjar, Abhinandan S <abhinandan.guj...@intel.com>; Mcnamara, John > <john.mcnam...@intel.com>; Richardson, Bruce > <bruce.richard...@intel.com> > Cc: Morten Brørup <m...@smartsharesystems.com>; ferruh.yi...@amd.com; > fanzhang....@gmail.com; tho...@monjalon.net > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting > crypto callbacks macro > > > > > Hi Ganapati, > > > > Can you send a new version incorporating above comments and work > > > > on similar lines as ethdev is currently doing. > > > > > > > > I believe as Morten pointed out, use of ifdef is as per DPDK > > > > convention, So better move it that way. > > > > We can discuss later if we can incorporate these in meson options. > > > > > > > Any update on this? > > Working on it, will post the patch soon. > > > Any update? or else this is going for next release. Posted v3
With crypto callbacks macro enabled + Test Suite : Crypto General Unit Test Suite + ------------------------------------------------------- + CRYPTODEV: rte_cryptodev_configure() line 1148: Invalid dev_id=7 CRYPTODEV: rte_cryptodev_configure() line 1148: Invalid dev_id=255 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=0 already stopped + TestCase [ 0] : test_device_configure_invalid_dev_id succeeded CRYPTODEV: rte_cryptodev_queue_pair_setup() line 1364: Invalid queue_pair_id=1 CRYPTODEV: rte_cryptodev_queue_pair_setup() line 1364: Invalid queue_pair_id=65535 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=0 already stopped + TestCase [ 1] : test_queue_pair_descriptor_setup succeeded CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1086: invalid param: dev 0x7fe4a91a8940, nb_queues 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_pairs_config = -22 CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1101: Invalid num queue_pairs (65535) for dev 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_pairs_config = -22 CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1101: Invalid num queue_pairs (2) for dev 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_pairs_config = -22 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=0 already stopped + TestCase [ 2] : test_device_configure_invalid_queue_pair_ids succeeded CRYPTODEV: rte_cryptodev_stats_get() line 1701: Invalid dev_id=88 CRYPTODEV: rte_cryptodev_stats_get() line 1706: Invalid stats ptr CRYPTODEV: rte_cryptodev_stats_reset() line 1729: Invalid dev_id=44 + TestCase [ 3] : test_stats succeeded CRYPTODEV: rte_cryptodev_add_enq_callback() line 1425: Invalid dev_id=64 CRYPTODEV: rte_cryptodev_add_enq_callback() line 1432: Invalid queue_pair_id=2 CRYPTODEV: rte_cryptodev_add_enq_callback() line 1419: Callback is NULL on dev_id=0 CRYPTODEV: rte_cryptodev_remove_enq_callback() line 1495: Invalid dev_id=64 CRYPTODEV: rte_cryptodev_remove_enq_callback() line 1503: Invalid queue_pair_id=2 CRYPTODEV: rte_cryptodev_remove_enq_callback() line 1490: Callback is NULL + TestCase [ 4] : test_enq_callback_setup succeeded CRYPTODEV: rte_cryptodev_add_deq_callback() line 1570: Invalid dev_id=64 CRYPTODEV: rte_cryptodev_add_deq_callback() line 1577: Invalid queue_pair_id=2 CRYPTODEV: rte_cryptodev_add_deq_callback() line 1564: Callback is NULL on dev_id=0 CRYPTODEV: rte_cryptodev_remove_enq_callback() line 1495: Invalid dev_id=64 CRYPTODEV: rte_cryptodev_remove_deq_callback() line 1649: Invalid queue_pair_id=2 CRYPTODEV: rte_cryptodev_remove_deq_callback() line 1636: Callback is NULL + TestCase [ 5] : test_deq_callback_setup succeeded + ------------------------------------------------------- + + Test Suite Summary : Crypto General Unit Test Suite + ------------------------------------------------------- + + Tests Total : 6 + Tests Skipped : 0 + Tests Executed : 6 + Tests Unsupported: 0 + Tests Passed : 6 + Tests Failed : 0 With crypto_callbacks macro disabled + Test Suite : Crypto General Unit Test Suite + ------------------------------------------------------- + CRYPTODEV: rte_cryptodev_configure() line 1148: Invalid dev_id=7 CRYPTODEV: rte_cryptodev_configure() line 1148: Invalid dev_id=255 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=0 already stopped + TestCase [ 0] : test_device_configure_invalid_dev_id succeeded CRYPTODEV: rte_cryptodev_queue_pair_setup() line 1364: Invalid queue_pair_id=1 CRYPTODEV: rte_cryptodev_queue_pair_setup() line 1364: Invalid queue_pair_id=65535 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=0 already stopped + TestCase [ 1] : test_queue_pair_descriptor_setup succeeded CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1086: invalid param: dev 0x7f2eac8cb940, nb_queues 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_pairs_config = -22 CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1101: Invalid num queue_pairs (65535) for dev 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_pairs_config = -22 CRYPTODEV: rte_cryptodev_queue_pairs_config() line 1101: Invalid num queue_pairs (2) for dev 0 CRYPTODEV: rte_cryptodev_configure() line 1171: dev0 rte_crypto_dev_queue_pairs_config = -22 CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=0 already stopped + TestCase [ 2] : test_device_configure_invalid_queue_pair_ids succeeded CRYPTODEV: rte_cryptodev_stats_get() line 1701: Invalid dev_id=88 CRYPTODEV: rte_cryptodev_stats_get() line 1706: Invalid stats ptr CRYPTODEV: rte_cryptodev_stats_reset() line 1729: Invalid dev_id=44 + TestCase [ 3] : test_stats succeeded CRYPTODEV: test_enq_callback_setup line 13003: Not supported, skipped CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=0 already stopped + TestCase [ 4] : test_enq_callback_setup skipped CRYPTODEV: test_deq_callback_setup line 13116: Not supported, skipped CRYPTODEV: rte_cryptodev_stop() line 1241: Device with dev_id=0 already stopped + TestCase [ 5] : test_deq_callback_setup skipped + ------------------------------------------------------- + + Test Suite Summary : Crypto General Unit Test Suite + ------------------------------------------------------- + + Tests Total : 6 + Tests Skipped : 2 + Tests Executed : 6 + Tests Unsupported: 0 + Tests Passed : 4 + Tests Failed : 0 + ------------------------------------------------------- + + -------------------------------------------------------
