Re: [PATCH v3 1/3] Added VLAN commands to testpmd_shell class

2024-06-14 Thread Patrick Robb
On Fri, Jun 14, 2024 at 4:29 PM Jeremy Spewock wrote: > > I wonder whether, when convenient, we want to name the methods more or > > less 1:1 according to the actual testpmd text command they send? I.e. > > in this case should the method be named vlan_set_filter_on instead of > > vlan_filter_set_

Re: [PATCH v2 5/5] baseband/acc: cosmetic log changes

2024-06-14 Thread Thomas Monjalon
14/06/2024 23:04, Thomas Monjalon: > 02/05/2024 22:45, Hernan Vargas: > > - rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"\n", > > desc->req.word0); > > + rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"", > > desc->req.word0); > > Why keeping an empty string

Re: [PATCH v2 5/5] baseband/acc: cosmetic log changes

2024-06-14 Thread Thomas Monjalon
02/05/2024 22:45, Hernan Vargas: > - rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"\n", > desc->req.word0); > + rte_bbdev_log(WARNING, "DMA Response %#"PRIx32"", > desc->req.word0); Why keeping an empty string after PRIx32? Should I remove it when pulling

Re: [PATCH v3 1/3] dts: Improve output gathering in interactive shells

2024-06-14 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Wed, May 29, 2024 at 3:49 PM wrote: > > From: Jeremy Spewock > > The current implementation of consuming output from interactive shells > relies on being able to find an expected prompt somewhere within the > output buffer after sending the command. This is usefu

Re: [PATCH v3 2/3] dts: Add missing docstring from XML-RPC server

2024-06-14 Thread Nicholas Pratte
Just a small nitpick. Otherwise: Reviewed-by: Nicholas Pratte > class QuittableXMLRPCServer(SimpleXMLRPCServer): > -"""Basic XML-RPC server. > +r"""Basic XML-RPC server. > > The server may be augmented by functions serializable by the > :mod:`marshal` module. > + > +Example:

Re: [PATCH v3 1/3] Added VLAN commands to testpmd_shell class

2024-06-14 Thread Jeremy Spewock
On Fri, Jun 14, 2024 at 12:00 PM Patrick Robb wrote: > > On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote: > > +def vlan_filter_set_on(self, port: int = 0, verify: bool = True): > > +"""Set vlan filter on. > > + > > +Args: > > +port: The port number to use, should

Re: [PATCH v3 3/3] dts: Improve logging for interactive shells

2024-06-14 Thread Nicholas Pratte
Ran a couple test suites to observe the output. As expected, everything works fine. Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Wed, May 29, 2024 at 3:49 PM wrote: > > From: Jeremy Spewock > > The messages being logged by interactive shells currently are using the > same logger

Re: [PATCH v5 1/5] dts: fix InteractiveShell command prompt filtering

2024-06-14 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, Jun 6, 2024 at 5:34 PM Luca Vizzarro wrote: > > When sending a command using an instance of InteractiveShell the output > should filter out the trailing shell prompt when returning it. After > every command two shell prompts are su

Re: [PATCH 2/5] dts: skip first line of send_command output

2024-06-14 Thread Nicholas Pratte
> > > >> @@ -132,6 +135,9 @@ def send_command(self, command: str, prompt: str | > > > >> None = None) -> str: > > > >> self._stdin.flush() > > > >> out: str = "" > > > >> for line in self._stdout: > > > >> +if skip_first_line: > > > >> +sk

Re: [PATCH v1] dts: Testbed And Node Configuration Split

2024-06-14 Thread Jeremy Spewock
On Mon, Jun 10, 2024 at 3:37 PM Nicholas Pratte wrote: > > > > > -def load_config(config_file_path: Path) -> Configuration: > > +def load_config(node_config_file_path: Path, exec_config_file_path: Path) > > -> Configuration: > > """Load DTS test run configuration from a file. > > > > -L

Re: [PATCH v1] dts: Testbed And Node Configuration Split

2024-06-14 Thread Jeremy Spewock
I think this is definitely a step in the right direction in terms of how we structure the config files. Something that I think could also be a cool improvement for how we handle configs is just making a `conf/` directory and then taking all of the configuration in each of the yaml files present in

Re: [PATCH v2 1/4] lib/ethdev: Add link_speed lanes support into rte lib

2024-06-14 Thread Damodharam Ammepalli
On Tue, Jun 11, 2024 at 4:39 PM Ferruh Yigit wrote: > > On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get and set number of speed lanes. This will help user to > > configure the same fixed speed with different number of lane

Re: [PATCH 4/4] dts: Rework DPDK Attributes In SUT Node Config

2024-06-14 Thread Jeremy Spewock
Funny, this commit addresses a comment I had on the previous. I think it makes a lot of sense to split the EAL parameter information into a DPDK specific config that the TG doesn't have since it likely won't need it. On Thu, Jun 13, 2024 at 4:22 PM Nicholas Pratte wrote: > > Rework 'lcores' and '

Re: [PATCH 3/4] dts: Self-Discovering Architecture Change

2024-06-14 Thread Jeremy Spewock
Looks good to me, just looks like a testing command got left behind. Otherwise though: Reviewed-by: Jeremy Spewock On Thu, Jun 13, 2024 at 4:22 PM Nicholas Pratte wrote: > > The 'arch' attribute in the conf.yaml is unnecessary, as this can be > readily discovered within the constructor of any g

Re: [PATCH 2/4] dts: Use First Core Logic Change

2024-06-14 Thread Jeremy Spewock
On Thu, Jun 13, 2024 at 4:21 PM Nicholas Pratte wrote: > > Removed use_first_core from the conf.yaml in favor of determining this > within the framework. use_first_core continue to serve a purpose in that > it is only enabled when core 0 is explicitly provided in the > configuration. Any other con

Re: [PATCH 1/4] dts: Remove build target config and list of devices

2024-06-14 Thread Jeremy Spewock
On Thu, Jun 13, 2024 at 4:21 PM Nicholas Pratte wrote: > > Remove the list of devices from the schema, as these are unuesed. > Likewise, removed build-target information since these is not currently > used, and it is unlikely to be used in the future. Adjustments to the > dts.rst are made to refle

RE: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-14 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 14 June 2024 17.27 > > On Fri, 14 Jun 2024 10:01:02 +0100 > Ferruh Yigit wrote: > > > On 6/13/2024 8:13 PM, Stephen Hemminger wrote: > > > On Thu, 13 Jun 2024 17:51:14 +0100 > > > Ferruh Yigit wrote: > > > > > >>> Hi

Re: [PATCH v5 3/5] dts: add parsing utility module

2024-06-14 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, Jun 6, 2024 at 5:34 PM Luca Vizzarro wrote: > > Adds parsing text into a custom dataclass. It provides a new > `TextParser` dataclass to be inherited. This implements the `parse` > method, which combined with the parser functions,

Re: [PATCH v5 4/5] dts: add `show port info` command to TestPmdShell

2024-06-14 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, Jun 6, 2024 at 5:34 PM Luca Vizzarro wrote: > > Add a new TestPmdPort data structure to represent the output > returned by `show port info`, which is implemented as part of > TestPmdShell. > > The TestPmdPort data structure and its

Re: [PATCH v5 5/5] dts: add `show port stats` command to TestPmdShell

2024-06-14 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte wrote: > > Add a new TestPmdPortStats data structure to represent the output > returned by `show port stats`, which is implemented as part of > TestPmdShell. > > Bugzilla ID: 1407 > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepa

Re: [PATCH v3 2/3] Initial implementation for VLAN test suite

2024-06-14 Thread Patrick Robb
Looks promising thanks - some comments below. On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote: > +class TestVlan(TestSuite): > +"""DPDK VLAN test suite. > + > +Ensures VLAN packet reception on the Poll Mode Driver when certain > conditions are met. > +If one or more of these conditi

Re: [PATCH v3 1/3] Added VLAN commands to testpmd_shell class

2024-06-14 Thread Patrick Robb
On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote: > +def vlan_filter_set_on(self, port: int = 0, verify: bool = True): > +"""Set vlan filter on. > + > +Args: > +port: The port number to use, should be within 0-32. > +verify: If :data:`True`, the output o

[PATCH v10] examples/ptp: replace terms master and slave

2024-06-14 Thread Stephen Hemminger
Remove one of the few remaining uses of master/slave. The IEEE 1588 standard has been updated to remove the use of master-slave terminology. Change the sample to Use the terms recommended by IEEE 1588g-2022 amendment. In place of the term “master”, use the term “timeTransmitter”. In place of

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-14 Thread Ferruh Yigit
On 6/14/2024 4:27 PM, Stephen Hemminger wrote: > On Fri, 14 Jun 2024 10:01:02 +0100 > Ferruh Yigit wrote: > >> On 6/13/2024 8:13 PM, Stephen Hemminger wrote: >>> On Thu, 13 Jun 2024 17:51:14 +0100 >>> Ferruh Yigit wrote: >>> > Hi Sivaprasad, > > Is this '(lcoreid_t)' cast required

Re: [RFC 4/4] net/ice: remove use of VLAs

2024-06-14 Thread Ferruh Yigit
On 6/13/2024 11:32 AM, Konstantin Ananyev wrote: > > >> >> On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: >>> From: Konstantin Ananyev >>> >>> ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used >>> [-Wvla] >>> >>> Here VLA is used as a temp array for mbufs that will be

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-14 Thread Stephen Hemminger
On Fri, 14 Jun 2024 10:01:02 +0100 Ferruh Yigit wrote: > On 6/13/2024 8:13 PM, Stephen Hemminger wrote: > > On Thu, 13 Jun 2024 17:51:14 +0100 > > Ferruh Yigit wrote: > > > >>> Hi Sivaprasad, > >>> > >>> Is this '(lcoreid_t)' cast required? Because of integer promotion I > >>> think result wi

Re: [RFC 2/4] gro: remove use of VLAs

2024-06-14 Thread Ferruh Yigit
On 6/13/2024 11:20 AM, Konstantin Ananyev wrote: > > >> >> On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: >>> From: Konstantin Ananyev >>> >>> ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] >>> ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] >>

[PATCH v3 3/3] Config schema

2024-06-14 Thread Dean Marx
Configuration to run vlan test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index 4731f4511d..eca8244f27

[PATCH v3 2/3] Initial implementation for VLAN test suite

2024-06-14 Thread Dean Marx
Test suite for ensuring Poll Mode Driver can enable or disable vlan filtering, stripping, and header insertion of packets sent on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_vlan.py | 172 1 file changed, 172 insertions(+) create mode 100644 dts

[PATCH v3 1/3] Added VLAN commands to testpmd_shell class

2024-06-14 Thread Dean Marx
The testpmd_shell class is intended for sending commands to a remote testpmd session within a test suite, and as of right now it is missing most commands. Added commands for vlan filtering, stripping, and insertion, as well as stopping and starting ports during testpmd runtime. Signed-off-by:

Re: [PATCH v5 0/2] build and install only one library type on Windows

2024-06-14 Thread David Marchand
On Fri, Jun 14, 2024 at 5:00 PM David Marchand wrote: > > On Mon, Apr 15, 2024 at 7:13 PM Tyler Retzlaff > wrote: > > > > MSVC is the only compiler that can produce usable shared libraries for > > DPDK on Windows because of the use of exported TLS variables. > > > > Disable building of shared lib

[PATCH v3 0/3] VLAN Test Suite

2024-06-14 Thread Dean Marx
VLAN test suite for ensuring VLAN filtering, stripping, and header insertion is functional on DPDK Poll Mode Drivers. The suite contains four test cases: 1. Enable VLAN filtering and disable stripping - verifies that packets with a VLAN tag found in the filter list are received with the tag when s

Re: [PATCH v5 0/2] build and install only one library type on Windows

2024-06-14 Thread David Marchand
On Mon, Apr 15, 2024 at 7:13 PM Tyler Retzlaff wrote: > > MSVC is the only compiler that can produce usable shared libraries for > DPDK on Windows because of the use of exported TLS variables. > > Disable building of shared libraries with LLVM and MinGW so that > remaining __declspec macros needed

Re: [PATCH 0/2] adapt prefetch functions for MSVC

2024-06-14 Thread David Marchand
On Wed, Mar 20, 2024 at 10:18 PM Tyler Retzlaff wrote: > > MSVC does not have intrinsics that allow prefetch specifying > read/write so adjust conditional compilation to allow MSVC to > use the non access type inline functions from rte_prefetch.h > > While here fix issues with C++ build (which onl

Re: [PATCH 2/2] eal: add rte ffs32 and rte ffs64 inline functions

2024-06-14 Thread David Marchand
On Wed, Mar 20, 2024 at 10:25 PM Tyler Retzlaff wrote: > > provide toolchain abstraction for __builtin_ffs{,l,ll} gcc built-in > intrinsics. > > Signed-off-by: Tyler Retzlaff Please add a unit test and an entry in the release notes. > --- > lib/eal/include/rte_bitops.h | 34 +++

Re: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

2024-06-14 Thread David Marchand
On Wed, May 29, 2024 at 4:51 PM Thomas Monjalon wrote: > > 20/03/2024 22:33, Tyler Retzlaff: > > Use newly introduced __rte_constant(e) macro instead of directly using > > __builtin_constant_p() allowing mempool to be built by MSVC. > > Does it mean we should enable mempool build? > If yes, please

Re: [PATCH v4 2/3] dts: add API doc sources

2024-06-14 Thread Jeremy Spewock
I noticed one small typo but otherwise: Reviewed-by: Jeremy Spewock On Fri, Apr 12, 2024 at 6:14 AM Juraj Linkeš wrote: > > These sources could be generated with the sphinx-apidoc utility, but > that doesn't give us enough flexibility, such as sorting the order of > modules or changing the head

Re: [PATCH 0/2] mempool: patches

2024-06-14 Thread David Marchand
On Mon, Apr 1, 2024 at 7:03 PM Stephen Hemminger wrote: > > Tried building mempool with MSVC. In addition to the > __rte_constant macro Tyler had already done. > > This fixes a couple of warnings, and cleans up the > code. > > Stephen Hemminger (2): > mempool: replace GCC pragma with cast > me

Re: [PATCH v4 1/3] dts: add doc generation dependencies

2024-06-14 Thread Jeremy Spewock
On Fri, Apr 12, 2024 at 6:14 AM Juraj Linkeš wrote: > > Sphinx imports every Python module when generating documentation from > docstrings, meaning all DTS dependencies, including Python version, > must be satisfied. > By adding Sphinx to DTS dependencies we provide a convenient way to > generate

Re: [PATCH v3] mempool: dump includes list of memory chunks

2024-06-14 Thread David Marchand
On Tue, Jun 11, 2024 at 8:51 AM Morten Brørup wrote: > > Added information about the memory chunks holding the objects in the > mempool when dumping the status of the mempool to a file. > > Signed-off-by: Morten Brørup > Acked-by: Paul Szczepanek > Acked-by: Andrew Rybchenko > Acked-by: Konsta

[PATCH v2 1/1] crypto/ipsec_mb: unify some IPsec MB PMDs

2024-06-14 Thread Brian Dooley
Currently IPsec MB provides both the JOB API and direct API. AESNI_MB PMD is using the JOB API codepath while KASUMI and CHACHA20_POLY1305 are using the direct API. Instead of using the direct API for these PMDs, they should now make use of the JOB API codepath. This would remove all use of the IPs

[PATCH v2 0/1] Unifying IPsec MB

2024-06-14 Thread Brian Dooley
Unifying some PMDs in the ipsec_mb crypto driver As discussed previously on the mailing list: https://patches.dpdk.org/project/dpdk/patch/20240228113301.934291-1-brian.doo...@intel.com/ v2: * fix doc indentation Brian Dooley (1): crypto/ipsec_mb: unify some IPsec MB PMDs doc/guides/rel_notes/

Re: [PATCH v6 3/3] dts: store stderr in RemoteCommandExecutionError

2024-06-14 Thread Jeremy Spewock
On Fri, May 31, 2024 at 8:51 AM Juraj Linkeš wrote: > > On Fri, May 31, 2024 at 1:22 PM Luca Vizzarro wrote: > > > > Store the stderr of an executed command in RemoteCommandExecutionError. > > Consequently, when the exception is logged the error message includes > > the stderr. > > > > Signed-off

Re: [PATCH v6 2/3] dts: constrain DPDK source argument

2024-06-14 Thread Jeremy Spewock
On Fri, May 31, 2024 at 8:51 AM Juraj Linkeš wrote: > > On Fri, May 31, 2024 at 1:22 PM Luca Vizzarro wrote: > > > > DTS needs an input to gather the DPDK source code from. This is then > > built on the remote target. This commit makes sure that this input is > > more constrained, separating the

Re: [PATCH v6 1/3] dts: rework arguments framework

2024-06-14 Thread Jeremy Spewock
On Fri, May 31, 2024 at 7:22 AM Luca Vizzarro wrote: > > The existing argument handling in the code relies on basic argparse > functionality and a custom argparse action to integrate environment > variables. This commit improves the current handling by augmenting > argparse. > > This rework implem

Re: [PATCH v9 0/4] hash: add SVE support for bulk key lookup

2024-06-14 Thread David Marchand
On Tue, Apr 30, 2024 at 6:28 PM Yoan Picchi wrote: > > This patchset adds SVE support for the signature comparison in the cuckoo > hash lookup and improves the existing NEON implementation. These > optimizations required changes to the data format and signature of the > relevant functions to suppo

Re: [PATCH v9 1/4] hash: pack the hitmask for hash in bulk lookup

2024-06-14 Thread David Marchand
On Tue, Apr 30, 2024 at 6:28 PM Yoan Picchi wrote: > > Current hitmask includes padding due to Intel's SIMD > implementation detail. This patch allows non Intel SIMD > implementations to benefit from a dense hitmask. > In addition, the new dense hitmask interweave the primary > and secondary match

Re: [PATCH v9 4/4] hash: add SVE support for bulk key lookup

2024-06-14 Thread David Marchand
On Tue, Apr 30, 2024 at 6:28 PM Yoan Picchi wrote: > > - Implemented SVE code for comparing signatures in bulk lookup. > - New SVE code is ~5% slower than optimized NEON for N2 processor for > 128b vectors. > > Signed-off-by: Yoan Picchi > Signed-off-by: Harjot Singh > Reviewed-by: Nathan Brown

Re: [PATCH] lib/hash: fix the return value description of rte_hash

2024-06-14 Thread David Marchand
Hello, On Mon, Jun 27, 2022 at 3:13 PM Chenming C wrote: > > The rte_hash lookup can return ZERO which is not a positive value. > Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org > Signed-off-by: Chenming C Acked-by: Stephen Hemminger Acked-by: Vladimir Medvedkin Sorry, I h

Re: [PATCH] hash: fix segfault by adding param name NULL check

2024-06-14 Thread David Marchand
On Thu, Jul 6, 2023 at 5:26 PM Conor Fogarty wrote: > > Add NULL pointer check to params->name, which is later > copied into the hash datastructure. Without this check > the code segfaults on the strlcpy() of a NULL pointer. > > Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")

[DPDK/DTS Bug 1460] Decorate test cases

2024-06-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1460 Bug ID: 1460 Summary: Decorate test cases Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal

Re: [PATCH v3 00/22] Update MEV TS Base Driver

2024-06-14 Thread Burakov, Anatoly
On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: These patches integrate the latest changes in MEV TS IDPF Base driver. --- v3: - Removed additional whitespace changes - Fixed warnings of CI - Updated documentation relating to MEV TS FW release --- Off list, I don't know anything about idpf drive

Re: [PATCH v3 09/22] common/idpf: refactor size check macro

2024-06-14 Thread Burakov, Anatoly
On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: Instead of using 'divide by 0' to check the struct length, use the static_assert macro Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/driver

Re: [PATCH v3 07/22] common/idpf: convert data type to 'le'

2024-06-14 Thread Burakov, Anatoly
On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: 'u32' data type is used for the struct members in 'virtchnl2_version_info' which should be '__le32'. Make the change accordingly. It is not stated why the data type "should" be __le32. Can the commit message be clarified to explain why this should b

Re: [PATCH v3 05/22] common/idpf: avoid defensive programming

2024-06-14 Thread Burakov, Anatoly
On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: Based on the upstream feedback, driver should not use any defensive programming strategy by checking for NULL pointers and other conditional checks unnecessarily in the code flow to fall back, instead fail and fix the bug in a proper way. Some of the

Re: [PATCH v3 02/22] common/idpf: updated IDPF VF device ID

2024-06-14 Thread Burakov, Anatoly
On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: Update IDPF VF device id to 145C. Also added device ID for S-IOV device. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_devids.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base

Re: [PATCH v3 01/22] common/idpf: added NVME CPF specific code with defines

2024-06-14 Thread Burakov, Anatoly
On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: Removes NVME dependency on memory allocations and uses a prepared buffer instead. The changes do not affect other components. Signed-off-by: Soumyadeep Hore --- return status; } @@ -232,8 +244,13 @@ void idpf_ctlq_remove(struct idpf_h

Re: [PATCH v15 0/6] add pointer compression API

2024-06-14 Thread David Marchand
On Tue, Jun 11, 2024 at 3:00 PM Paul Szczepanek wrote: > > This patchset is proposing adding a new header only library > with utility functions that allow compression of arrays of pointers. > > Since this is a header only library a patch needed to be added to amend > the build system to allow addi

RE: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption

2024-06-14 Thread Suanming Mou
Hi Akhil, As we mentioned the application in another thread, do you know if we can take the patch for now? BR, Suanming > -Original Message- > From: Suanming Mou > Sent: Monday, April 1, 2024 8:30 AM > To: Suanming Mou ; Power, Ciara > ; gak...@marvell.com > Cc: dev@dpdk.org > Subject:

RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec operation

2024-06-14 Thread Suanming Mou
Hi, > -Original Message- > From: Akhil Goyal > Sent: Friday, June 14, 2024 5:07 PM > To: Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec > operation > > > Hi Akhil, > > > > > -Original Message- > > > Fr

RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec operation

2024-06-14 Thread Akhil Goyal
> Hi Akhil, > > > -Original Message- > > From: Akhil Goyal > > Sent: Friday, June 14, 2024 2:49 PM > > To: Suanming Mou ; Matan Azrad > > > > Cc: dev@dpdk.org > > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec > > operation > > > > > To optimize AES-GCM IPsec

Re: [PATCH v2] app/testpmd: fix lcore ID restriction

2024-06-14 Thread Ferruh Yigit
On 6/13/2024 8:13 PM, Stephen Hemminger wrote: > On Thu, 13 Jun 2024 17:51:14 +0100 > Ferruh Yigit wrote: > >>> Hi Sivaprasad, >>> >>> Is this '(lcoreid_t)' cast required? Because of integer promotion I >>> think result will be correct without casting. >>> >>> (And without integer promotion consi

Speakers and sessions at the DPDK Summit APAC

2024-06-14 Thread Ben Thomas
Speakers and sessions at the DPDK Summit APAC in Bangkok on July 9-10, 2024 are live. Featured Sessions Include: - Explorations into the UACCE Bus of DPDK by Feng Chengwen from Huawei Technologies. - Insights into ZXDH DPU Adapter and its applications by Lijie Shan & Wang Junlong from ZTE. - Intro

RE: [PATCH v2 1/2] power: introduce PM QoS API on CPU wide

2024-06-14 Thread Morten Brørup
> +#define PM_QOS_SYSFILE_RESUME_LATENCY_US \ > + "/sys/devices/system/cpu/cpu%u/power/pm_qos_resume_latency_us" Is it OK to access this path using the lcore_id as CPU parameter to open_core_sysfs_file(), or must it be mapped through rte_lcore_to_cpu_id(lcore_id) first? @David, do you k

RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec operation

2024-06-14 Thread Suanming Mou
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Friday, June 14, 2024 2:49 PM > To: Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec > operation > > > To optimize AES-GCM IPsec operation within crypto

[PATCH v2 11/11] doc: update nfp document

2024-06-14 Thread Chaoyong He
From: Xinying Yu Add the software assisted vDPA live migration feature into NFP document. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- doc/guides/vdpadevs/nfp.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/v

[PATCH v2 10/11] vdpa/nfp: enable feature bits of live migration

2024-06-14 Thread Chaoyong He
From: Xinying Yu Add the 'VHOST_F_LOG_ALL' feature bits inorder to enable the live migration function. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dri

[PATCH v2 09/11] vdpa/nfp: setup vring relay thread

2024-06-14 Thread Chaoyong He
From: Xinying Yu Setup the vring relay thread to monitor the interruption from device. And do the dirty page logging or notify device according to event data. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c

[PATCH v2 08/11] vdpa/nfp: recover the ring index on new host

2024-06-14 Thread Chaoyong He
From: Xinying Yu After migrating to new host, the vring information is recovered by the value in offset 'NFP_NET_CFG_TX_USED_INDEX' and 'NFP_NET_CFG_RX_USED_INDEX'. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_com

[PATCH v2 07/11] vdpa/nfp: setup the VF configure

2024-06-14 Thread Chaoyong He
From: Xinying Yu Create the relay vring on host and then set the address of Rx used ring to the VF config bar. So the device can DMA the used ring information to host rather than directly to VM. Use 'NFP_NET_CFG_CTRL_LM_RELAY' notify the device side. And enable the MSIX interrupt on device. Tx

[PATCH v2 06/11] vdpa/nfp: add the interrupt logic of vring relay

2024-06-14 Thread Chaoyong He
From: Xinying Yu Add the interrupt setup logic of vring relay. The epoll fd is provided here so host can get the interrupt from device on Rx direction, all other operations on vring relay are based on this. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by:

[PATCH v2 05/11] vdpa/nfp: add the live migration logic

2024-06-14 Thread Chaoyong He
From: Xinying Yu Add the basic logic of software live migration. Unset the ring notify area to stop the direct IO datapath if the device support, then we can setup the vring relay to help the live migration. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by:

[PATCH v2 04/11] vdpa/nfp: refactor the logic of datapath update

2024-06-14 Thread Chaoyong He
From: Xinying Yu In order to add the new configuration logic of software live migration, split the datapath update logic into two parts, queue configuration and VF configuration. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa

[PATCH v2 03/11] vdpa/nfp: fix the logic of reconfiguration

2024-06-14 Thread Chaoyong He
From: Xinying Yu The ctrl words of vDPA is located on the extended word, so it should use the 'nfp_ext_reconfig()' rather than 'nfp_reconfig()'. Also replace the misuse of 'NFP_NET_CFG_CTRL_SCATTER' macro with 'NFP_NET_CFG_CTRL_VIRTIO'. Fixes: b47a0373903f ("vdpa/nfp: add datapath update") Cc:

[PATCH v2 02/11] vdpa/nfp: fix logic in hardware init

2024-06-14 Thread Chaoyong He
From: Xinying Yu Reconfigure the NIC will fail because lack of the initialization logic of queue configuration pointer. Fix this by adding the correct initialization logic. Fixes: d89f4990c14e ("vdpa/nfp: add hardware init") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Xinyin

[PATCH v2 01/11] mailmap: add new contributor

2024-06-14 Thread Chaoyong He
From: Xinying Yu Add new contributor. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 6b396107d0..01c31b8c70 100644 --- a/.mailmap +++ b/.mailmap @@ -15

[PATCH v2 00/11] support software live migration

2024-06-14 Thread Chaoyong He
This patch series aims to add the support of software live migration feature for NFP vDPA device. --- v2: * Adjust some spell in the commit message. * Split out a commit to enable this feature. --- Xinying Yu (11): mailmap: add new contributor vdpa/nfp: fix logic in hardware init vdpa/nfp: