[PATCH v4 7/8] net/tap: use generic SW stats

2024-05-15 Thread Stephen Hemminger
Use new common sw statistics. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 88 ++- drivers/net/tap/rte_eth_tap.h | 15 ++ 2 files changed, 18 insertions(+), 85 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/r

[PATCH v4 8/8] net/null: use generic SW stats

2024-05-15 Thread Stephen Hemminger
Use the new common code for statistics. This also fixes the bug that this driver was not accounting for bytes. Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 80 +++-- 1 file changed, 17 insertions(+), 63 deletions(-) diff --git a/drivers/net/

[PATCH v4 6/8] net/ring: use generic SW stats

2024-05-15 Thread Stephen Hemminger
Use generic per-queue infrastructure. This also fixes bug where ring code was not accounting for bytes. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 71 + 1 file changed, 28 insertions(+), 43 deletions(-) diff --git a/drivers/net/ring/rt

[PATCH v4 5/8] net/pcap: use generic SW stats

2024-05-15 Thread Stephen Hemminger
Use common statistics for SW drivers. Signed-off-by: Stephen Hemminger --- drivers/net/pcap/pcap_ethdev.c | 125 +++-- 1 file changed, 26 insertions(+), 99 deletions(-) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c index bfec085045..b1a

[PATCH v4 4/8] net/af_xdp: use generic SW stats

2024-05-15 Thread Stephen Hemminger
Use common code for all SW stats. Signed-off-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 98 - 1 file changed, 25 insertions(+), 73 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 268a130c

[PATCH v4 3/8] net/af_packet: use generic SW stats

2024-05-15 Thread Stephen Hemminger
Use the new generic SW stats. Signed-off-by: Stephen Hemminger --- drivers/net/af_packet/rte_eth_af_packet.c | 82 --- 1 file changed, 14 insertions(+), 68 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index

[PATCH v4 2/8] ethdev: add common counters for statistics

2024-05-15 Thread Stephen Hemminger
Introduce common helper routines for keeping track of per-queue statistics in SW PMD's. The code in several drivers had copy/pasted the same code for this, but had common issues with 64 bit counters on 32 bit platforms. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_swstats.c | 109 +

[PATCH v4 1/8] eal: generic 64 bit counter

2024-05-15 Thread Stephen Hemminger
This header implements 64 bit counters that are NOT atomic but are safe against load/store splits on 32 bit platforms. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/eal/include/meson.build | 1 + lib/eal/include/rte_counter.h | 91 +++ 2 fil

[PATCH v4 0/8] Generic 64 bit counters for SW PMD's

2024-05-15 Thread Stephen Hemminger
Adds common code for collecting basic statistics used by many SW based PMD's such as af_packet, af_xdp, null, tap and ring. Solves the problem where counters could tear because of 32 bit load/store on 32 bit platforms. v4 - cleanup the comments - handle null pmd as well Stephen Hemminger (8):

RE: RE: [PATCH v5 0/4] add pointer compression API

2024-05-15 Thread Morten Brørup
> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com] > Sent: Wednesday, 15 May 2024 19.01 > > On 04/03/2024 14:44, Konstantin Ananyev wrote: > >> This feature is targeted for pipeline mode of applications. We see > many customers using pipeline mode. This feature helps in reducing > >> the cos

Re: [PATCH v4] devtools: add .clang-format file

2024-05-15 Thread Abdullah Ömer Yamaç
On Wed, May 15, 2024 at 6:07 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Wed, 15 May 2024 09:43:22 +0100 > Bruce Richardson wrote: > > > On Wed, May 15, 2024 at 11:28:33AM +0300, Abdullah Ömer Yamaç wrote: > > >I want to update you. > > >On Mon, May 13, 2024 at 4:08 PM

Re: [PATCH v2 3/3] dts: Improve logging for interactive shells

2024-05-15 Thread Jeremy Spewock
On Mon, May 13, 2024 at 11:03 AM Juraj Linkeš wrote: > > Good idea. And again, with the one minor point below, > Reviewed-by: Juraj Linkeš > > > diff --git a/dts/framework/remote_session/interactive_shell.py > > b/dts/framework/remote_session/interactive_shell.py > > index 0b0ccdb545..eb9c9b6843

Re: [PATCH v2 1/3] dts: Improve output gathering in interactive shells

2024-05-15 Thread Jeremy Spewock
On Mon, May 13, 2024 at 10:58 AM Juraj Linkeš wrote: > > Other than the one minor documentation nitpick, > Reviewed-by: Juraj Linkeš > > > > diff --git a/dts/framework/remote_session/interactive_shell.py > > b/dts/framework/remote_session/interactive_shell.py > > > @@ -124,20 +130,34 @@ def sen

Re: [PATCH] bus/pci: fix build with musl 1.2.4 / Alpine 3.19

2024-05-15 Thread Thomas Monjalon
29/04/2024 16:09, Patrick Robb: > On Mon, Apr 29, 2024 at 6:01 AM David Marchand > wrote: > > > Following an upgrade of musl, pread64/pwrite64 wrappers are not provided > > anymore. Switch to POSIX pread/pwrite. > > > > Bugzilla ID: 1422 > > Cc: sta...@dpdk.org > > > > Signed-off-by: David Marcha

Re: RE: [PATCH v5 0/4] add pointer compression API

2024-05-15 Thread Paul Szczepanek
On 04/03/2024 14:44, Konstantin Ananyev wrote: >> This feature is targeted for pipeline mode of applications. We see many >> customers using pipeline mode. This feature helps in reducing >> the cost of transferring the packets between cores by reducing the copies >> involved. > > I do understand

[PATCH] crypto/mvsam: fix build

2024-05-15 Thread Thomas Monjalon
When moving the alignment attribute, a semicolon was missed. Fixes: 27595cd83053 ("drivers: move alignment attribute on types for MSVC") Signed-off-by: Thomas Monjalon --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/mvsa

RE: [PATCH v3 1/7] eal: generic 64 bit counter

2024-05-15 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 15 May 2024 17.03 > > On Wed, 15 May 2024 11:30:45 +0200 > Morten Brørup wrote: > > > With a long term perspective, I consider this patch very useful. > > And its 32 bit implementation can be optimized for various >

Re: RSS Hash value returned by the gvnic pmd dpdk driver not matching Toeplitz

2024-05-15 Thread Nagesh Mallappa
Hi Stephen, Thanks for your response, I have verified that too, but that is not the case. Thanks, Nagesh On Wed, May 15, 2024 at 8:34 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Wed, 15 May 2024 13:50:38 +0530 > Nagesh Mallappa wrote: > > > Hi Team, > > > > We are using a C3

Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term

2024-05-15 Thread Nicholas Pratte
On Mon, May 13, 2024 at 6:06 AM Juraj Linkeš wrote: > > On Tue, May 7, 2024 at 3:00 PM Bruce Richardson > wrote: > > > > On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote: > > > On 07/05/2024 13:05, Bruce Richardson wrote: > > > > Sorry to be late to the reviews here, but since this i

Re: [PATCH v4] devtools: add .clang-format file

2024-05-15 Thread Stephen Hemminger
On Wed, 15 May 2024 09:43:22 +0100 Bruce Richardson wrote: > On Wed, May 15, 2024 at 11:28:33AM +0300, Abdullah Ömer Yamaç wrote: > >I want to update you. > >On Mon, May 13, 2024 at 4:08 PM Ferruh Yigit <[1]ferruh.yi...@amd.com> > >wrote: > > > > On 5/8/2024 10:19 PM, Abdullah Ö

Re: RSS Hash value returned by the gvnic pmd dpdk driver not matching Toeplitz

2024-05-15 Thread Stephen Hemminger
On Wed, 15 May 2024 13:50:38 +0530 Nagesh Mallappa wrote: > Hi Team, > > We are using a C3 GCP instance having GVNIC with DPDK enabled. > We are using latest version of DPDK ( dpdk-24.03 ) to configure RSS key, we > understand C3 GCP instance with gvnic supports Toeplitz rss algorithm ( > Refere

Re: [PATCH v3 1/7] eal: generic 64 bit counter

2024-05-15 Thread Stephen Hemminger
On Wed, 15 May 2024 11:30:45 +0200 Morten Brørup wrote: > With a long term perspective, I consider this patch very useful. > And its 32 bit implementation can be optimized for various > architectures/compilers later. > > > In addition, it would be "nice to have" if reset() and fetch() could be

Re: [PATCH v6 0/2] Methodology change for hugepage configuration

2024-05-15 Thread Nicholas Pratte
>What's the difference between this version and v4? Version 5 was a response to your suggestions regarding the semantics of the hugepage variable names as it relates to countable or uncountable nouns. This patch, which was originally just a single patch, was expanded into a patch series since the

Re: [PATCH v4] devtools: add .clang-format file

2024-05-15 Thread Bruce Richardson
On Wed, May 15, 2024 at 01:19:50PM +0300, Abdullah Ömer Yamaç wrote: >On Wed, May 15, 2024 at 11:43 AM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > On Wed, May 15, 2024 at 11:28:33AM +0300, Abdullah Ömer Yamaç wrote: > >I want to update you. > >On Mon

[PATCH] doc: remove confusing release candidate statements

2024-05-15 Thread Thomas Monjalon
The help of "dpdk-next-*" repositories is welcome at all stages, except maybe during the last release candidate. Better to remove statements about a time limit, and let decisions happen on the fly. Signed-off-by: Thomas Monjalon --- doc/guides/contributing/patches.rst | 2 -- 1 file changed, 2 d

[PATCH v6] lib/hash: add defer queue reclaim API

2024-05-15 Thread Abdullah Ömer Yamaç
This patch adds a new feature to the hash library to allow the user to reclaim the defer queue. This is useful when the user wants to force reclaim resources that are not being used. This API is only available if the RCU is enabled. Signed-off-by: Abdullah Ömer Yamaç --- app/test/test_hash.c

[PATCH v5] lib/hash: add defer queue reclaim API

2024-05-15 Thread Abdullah Ömer Yamaç
This patch adds a new feature to the hash library to allow the user to reclaim the defer queue. This is useful when the user wants to force reclaim resources that are not being used. This API is only available if the RCU is enabled. Signed-off-by: Abdullah Ömer Yamaç --- app/test/test_hash.c

Re: [PATCH v4] devtools: add .clang-format file

2024-05-15 Thread Abdullah Ömer Yamaç
On Wed, May 15, 2024 at 11:43 AM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Wed, May 15, 2024 at 11:28:33AM +0300, Abdullah Ömer Yamaç wrote: > >I want to update you. > >On Mon, May 13, 2024 at 4:08 PM Ferruh Yigit <[1]ferruh.yi...@amd.com > > > >wrote: > > > > On

[PATCH] net/mlx5: fix bug trunk is null

2024-05-15 Thread Haifei Luo
When _mlx5_ipool_get_cache is called, idx may be invalid and the "trunk" is NULL in this case. Assert is not correct and add checks that if trunk is NULL or not. Return NULL If trunk is NULL. Fixes: 42f463395f ("net/mlx5: support indexed pool non-lcore operations") Cc: sta...@dpdk.org Signed-off-

RE: [PATCH v3 1/7] eal: generic 64 bit counter

2024-05-15 Thread Morten Brørup
+To: @Mattias, @Ferruh, @Bruce, participants in a related discussion > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 14 May 2024 17.35 > > This header implements 64 bit counters that are NOT atomic > but are safe against load/store splits on 32 bit platforms. > > S

Re: [RFC] graph/node: feedback and future improvements

2024-05-15 Thread Bruce Richardson
On Wed, May 15, 2024 at 10:10:09AM +0200, Robin Jarry wrote: > Jerin Jacob, May 09, 2024 at 10:24: > > On Thu, May 9, 2024 at 3:34 AM Robin Jarry wrote: > > > > > > Hi Jerin, > > > > > > Jerin Jacob, May 04, 2024 at 12:03: > > > > 2) Control plane code: IMO, if you are willing, I will be glad to s

Re: [PATCH v4] devtools: add .clang-format file

2024-05-15 Thread Bruce Richardson
On Wed, May 15, 2024 at 11:28:33AM +0300, Abdullah Ömer Yamaç wrote: >I want to update you. >On Mon, May 13, 2024 at 4:08 PM Ferruh Yigit <[1]ferruh.yi...@amd.com> >wrote: > > On 5/8/2024 10:19 PM, Abdullah Ömer Yamaç wrote: > > clang-format is a tool to format C/C++/Objectiv

Re: [PATCH v3] cmdline: increase input buffer size

2024-05-15 Thread Gregory Etelson
Hello, What is the status of that patch ? Regards, Gregory From: Gregory Etelson Sent: Friday, May 3, 2024 07:27 To: Gregory Etelson Cc: Ali Alnubani ; dev@dpdk.org ; Maayan Kashani ; Raslan Darawsheh ; bruce.richard...@intel.com ; step...@networkplumber.org

[DPDK/ethdev Bug 1441] RSS Hash returned by the gvnic pmd dpdk driver not matching Toeplitz

2024-05-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1441 Bug ID: 1441 Summary: RSS Hash returned by the gvnic pmd dpdk driver not matching Toeplitz Product: DPDK Version: 24.03 Hardware: Other OS: Linux Status

RSS Hash value returned by the gvnic pmd dpdk driver not matching Toeplitz

2024-05-15 Thread Nagesh Mallappa
Hi Team, We are using a C3 GCP instance having GVNIC with DPDK enabled. We are using latest version of DPDK ( dpdk-24.03 ) to configure RSS key, we understand C3 GCP instance with gvnic supports Toeplitz rss algorithm ( Reference - https://github.com/google/compute-virtual-ethernet-dpdk/blob/main/

Re: [PATCH v4] devtools: add .clang-format file

2024-05-15 Thread Abdullah Ömer Yamaç
I want to update you. On Mon, May 13, 2024 at 4:08 PM Ferruh Yigit wrote: > On 5/8/2024 10:19 PM, Abdullah Ömer Yamaç wrote: > > clang-format is a tool to format C/C++/Objective-C code. It can be used > > to reformat code to match a given coding style, or to ensure that code > > adheres to a spe

Re: [RFC] graph/node: feedback and future improvements

2024-05-15 Thread Robin Jarry
Jerin Jacob, May 09, 2024 at 10:24: On Thu, May 9, 2024 at 3:34 AM Robin Jarry wrote: > > Hi Jerin, > > Jerin Jacob, May 04, 2024 at 12:03: > > 2) Control plane code: IMO, if you are willing, I will be glad to see > >it is hosted at https://www.dpdk.org/hosted-projects/ like pktgen. > >T